[v2 4/4] drm/edid: parse HF-EEODB CEA extension block

2022-02-28 Thread Lee Shawn C
While adding CEA modes, try to get available EEODB block number. Then based on it to parse numbers of ext blocks, retrieve CEA information and add more CEA modes. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_displayid.c | 5 -

[v2 3/4] drm/edid: read HF-EEODB ext block

2022-02-28 Thread Lee Shawn C
According to HDMI 2.1 spec. "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) is utilized by Sink Devices to provide an alternate method to indicate an EDID Extension Block count larger than 1, while avoiding the need to present a VESA Block Map in the first E-EDID Extension Block."

[v2 2/4] drm/edid: parse multiple CEA extension block

2022-02-28 Thread Lee Shawn C
Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_edid.c | 70

[v2 1/4] drm/edid: seek for available CEA block from specific EDID block index

2022-02-28 Thread Lee Shawn C
drm_find_cea_extension() always look for a top level CEA block. Pass ext_index from caller then this function to search next available CEA ext block from a specific EDID block pointer. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C ---

[v2 0/4] enhanced edid driver compatibility

2022-02-28 Thread Lee Shawn C
Support to parse multiple CEA extension blocks and HF-EEODB to extend drm edid driver's capability. Lee Shawn C (4): drm/edid: seek for available CEA block from specific EDID block index drm/edid: parse multiple CEA extension block drm/edid: read HF-EEODB ext block drm/edid: parse

Re: [Intel-gfx] [PATCH 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-02-28 Thread Lucas De Marchi
On Mon, Feb 28, 2022 at 11:48:58PM -0800, Lucas De Marchi wrote: On Tue, Feb 22, 2022 at 08:22:01PM +0530, Balasubramani Vivekanandan wrote: Fast copy using non-temporal instructions for x86 currently exists at two locations. One is implemented in i915 driver at i915/i915_memcpy.c and another

Re: [Intel-gfx] [PATCH 3/7] drm/i915: use the memcpy_from_wc call from the drm

2022-02-28 Thread Lucas De Marchi
On Tue, Feb 22, 2022 at 08:22:02PM +0530, Balasubramani Vivekanandan wrote: memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan ---

Re: [PATCH 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-02-28 Thread Lucas De Marchi
On Tue, Feb 22, 2022 at 08:22:01PM +0530, Balasubramani Vivekanandan wrote: Fast copy using non-temporal instructions for x86 currently exists at two locations. One is implemented in i915 driver at i915/i915_memcpy.c and another copy at drm_cache.c. The plan is to remove the duplicate

Re: [PATCH] drm/amdgpu: fix suspend/resume hang regression

2022-02-28 Thread Christian König
Am 01.03.22 um 07:26 schrieb Qiang Yu: Regression has been reported that suspend/resume may hang with the previous vm ready check commit: https://gitlab.freedesktop.org/drm/amd/-/issues/1915#note_1278198 So bring back the evicted list check as a temp fix. Fixes: cc8dd2cc1a97 ("drm/amdgpu:

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-28 Thread Inki Dae
Hi Martin, 22. 2. 25. 18:33에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: >> Hi Martin, >> >> 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: >>> Hello Inki, >>> >>> On Thu, Feb 24, 2022 at 10:41:04AM +0900, Inki Dae wrote: Hi Martin.

Re: [Intel-gfx] [PATCH 1/7] drm: Relax alignment constraint for destination address

2022-02-28 Thread Lucas De Marchi
On Tue, Feb 22, 2022 at 08:22:00PM +0530, Balasubramani Vivekanandan wrote: There is no need for the destination address to be aligned to 16 byte boundary to be able to use the non-temporal instructions while copying. Non-temporal instructions are used only for loading from the source address

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Alex Shi
On Mon, Feb 28, 2022 at 6:32 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jeffrey Walton
On Mon, Feb 28, 2022 at 3:45 PM James Bottomley wrote: > ... > > Just from skimming over the patches to change this and experience > > with the drivers/subsystems I help to maintain I think the primary > > pattern looks something like this: > > > > list_for_each_entry(entry, head, member) { > >

Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-28 Thread Dmitry Osipenko
On 2/28/22 17:19, Sascha Hauer wrote: > On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: >> On Fri, Feb 25, 2022 at 12:41:23PM +, Robin Murphy wrote: >>> On 2022-02-25 11:10, Dmitry Osipenko wrote: 25.02.2022 13:49, Sascha Hauer пишет: > On Fri, Feb 25, 2022 at 01:26:14PM

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Segher Boessenkool
On Mon, Feb 28, 2022 at 12:14:44PM -0800, Linus Torvalds wrote: > On Mon, Feb 28, 2022 at 12:10 PM Linus Torvalds > wrote: > > > > We can do > > > > typeof(pos) pos > > > > in the 'for ()' loop, and never use __iter at all. > > > > That means that inside the for-loop, we use a _different_

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jakob Koschel
> On 28. Feb 2022, at 21:56, Christian König wrote: > > > > Am 28.02.22 um 21:42 schrieb James Bottomley: >> On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: >>> Am 28.02.22 um 20:56 schrieb Linus Torvalds: On Mon, Feb 28, 2022 at 4:19 AM Christian König wrote:

Re: [PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-28 Thread youling257
this patch cause suspend to disk resume amdgpu hang, [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, signaled seq=8330, emitted seq=8332 https://gitlab.freedesktop.org/drm/amd/-/issues/1915

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jakob Koschel
> On 28. Feb 2022, at 21:10, Linus Torvalds > wrote: > > On Mon, Feb 28, 2022 at 12:03 PM Linus Torvalds > wrote: >> >> Side note: we do need *some* way to do it. > > Ooh. > > This patch is a work of art. > > And I mean that in the worst possible way. > > We can do > >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jakob Koschel
> On 28. Feb 2022, at 12:20, Greg KH wrote: > > On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: >> If the list does not contain the expected element, the value of >> list_for_each_entry() iterator will not point to a valid structure. >> To avoid type confusion in such case, the

Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Jakob Koschel
> On 28. Feb 2022, at 12:24, Dan Carpenter wrote: > > On Mon, Feb 28, 2022 at 12:08:17PM +0100, Jakob Koschel wrote: >> diff --git a/drivers/usb/gadget/udc/at91_udc.c >> b/drivers/usb/gadget/udc/at91_udc.c >> index 9040a0561466..0fd0307bc07b 100644 >> --- a/drivers/usb/gadget/udc/at91_udc.c

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Segher Boessenkool
On Mon, Feb 28, 2022 at 05:28:58PM -0500, James Bottomley wrote: > On Mon, 2022-02-28 at 23:59 +0200, Mike Rapoport wrote: > > > > On February 28, 2022 10:42:53 PM GMT+02:00, James Bottomley < > > james.bottom...@hansenpartnership.com> wrote: > > > On Mon, 2022-02-28 at 21:07 +0100, Christian

Re: [PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-28 Thread youling 257
https://gitlab.freedesktop.org/drm/amd/-/issues/1922 2022-03-01 1:26 GMT+08:00, youling257 : > this patch cause suspend to disk resume amdgpu hang, > [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, signaled > seq=8330, emitted seq=8332 > >

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Mika Westerberg
Hi, On Mon, Feb 28, 2022 at 10:36:59PM +, Limonciello, Mario wrote: > [AMD Official Use Only] > > > -Original Message- > > From: Lukas Wunner > > Sent: Monday, February 28, 2022 16:33 > > To: Bjorn Helgaas > > Cc: Limonciello, Mario ; Mika Westerberg > > ; Michael Jamet > > ; open

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Christian König
Am 28.02.22 um 22:13 schrieb James Bottomley: On Mon, 2022-02-28 at 21:56 +0100, Christian König wrote: Am 28.02.22 um 21:42 schrieb James Bottomley: On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: Am 28.02.22 um 20:56 schrieb Linus Torvalds: On Mon, Feb 28, 2022 at 4:19 AM

RE: [PATCH v5 5/7] drm/aspeed: Add reset and clock for AST2600

2022-02-28 Thread Tommy Huang
Hi Joel, It seems that the reset control could keep original code behavior. Just change the reset define in the .dtsi file from ASPEED_RESET_CRT1 into ASPEED_RESET_GRAPHICS. By the way, the HW controller states and FW programming register will be reset by CRT reset

Re: linux-next: build failure after merge of the drm tree

2022-02-28 Thread Dave Airlie
Yes, please do., sorry for HTML, stuck on tablet. On Tue, 1 Mar 2022, 1:33 am Robert Foss, wrote: > > > > > > > > Caused by commit > > > > > > > > b5c84a9edcd418 ("drm/bridge: add it6505 driver") > > > > > > > > I have used the drm tree from yesterday instead. > > > > > > hi all, > > > > > >

Re: [Intel-gfx] [PATCH v2 06/13] drm/i915: Move context descriptor fields to intel_lrc.h

2022-02-28 Thread Lucas De Marchi
On Mon, Feb 28, 2022 at 09:42:38AM -0800, Matt Roper wrote: This is a more appropriate header for these definitions. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 34 ---

Re: [PATCH v2 04/13] drm/i915/xehp: compute engine pipe_control

2022-02-28 Thread Lucas De Marchi
On Mon, Feb 28, 2022 at 09:42:36AM -0800, Matt Roper wrote: From: Daniele Ceraolo Spurio CCS will reuse the RCS functions for breadcrumb and flush emission. However, CCS pipe_control has additional programming restrictions: - Command Streamer Stall Enable must be always set - Post Sync

RE: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-28 Thread David Laight
From: Abhinav Kumar > Sent: 28 February 2022 21:38 ... > We also did some profiling around how much increasing the block size > helps and here is the data: > > Block sizecost > > 4KB 229s > 8KB86s You must have an O(n^2) operation in there - find it. David -

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jakub Kicinski
On Mon, 28 Feb 2022 16:41:04 -0800 Linus Torvalds wrote: > So yes, initially my idea had been to just move the iterator entirely > inside the macro. But specifying the type got so ugly that I think > that > > typeof (pos) pos > > trick inside the macro really ends up giving us the best

[PATCH] drm/amdgpu: fix suspend/resume hang regression

2022-02-28 Thread Qiang Yu
Regression has been reported that suspend/resume may hang with the previous vm ready check commit: https://gitlab.freedesktop.org/drm/amd/-/issues/1915#note_1278198 So bring back the evicted list check as a temp fix. Fixes: cc8dd2cc1a97 ("drm/amdgpu: check vm ready by amdgpu_vm->evicting flag")

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-02-28 Thread Dave Airlie
On Tue, 1 Mar 2022 at 03:11, Alex Deucher wrote: > > On Mon, Feb 28, 2022 at 1:55 AM Dave Airlie wrote: > > > > On Sat, 26 Feb 2022 at 04:35, Alex Deucher > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > New stuff for 5.18. > > > > > > The following changes since commit > > >

Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 10:20:28AM -0800, Joe Perches wrote: > On Mon, 2022-02-28 at 14:24 +0300, Dan Carpenter wrote: > > > a multi-line indent gets curly braces for readability even though > > it's not required by C. And then both sides would get curly braces. > > That's more your personal

[PATCH] drm/i915/xehp: Drop aux table invalidation on FlatCCS platforms

2022-02-28 Thread Matt Roper
Platforms with FlatCCS do not use auxiliary planes for compression control data and thus do not need traditional aux table invalidation (and the registers no longer even exist). Original-author: CQ Tang Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 28

Re: [PATCH v2 2/2] drm/atomic: Force bridge self-refresh-exit on CRTC switch

2022-02-28 Thread Liu Ying
On Mon, 2022-02-28 at 12:25 -0800, Brian Norris wrote: > It's possible to change which CRTC is in use for a given > connector/encoder/bridge while we're in self-refresh without fully > disabling the connector/encoder/bridge along the way. This can confuse > the bridge encoder/bridge, because > (a)

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread David Laight
From: Matthew Wilcox > Sent: 28 February 2022 20:16 > > On Mon, Feb 28, 2022 at 12:10:24PM -0800, Linus Torvalds wrote: > > We can do > > > > typeof(pos) pos > > > > in the 'for ()' loop, and never use __iter at all. > > > > That means that inside the for-loop, we use a _different_ 'pos'

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-28 Thread Liu Ying
On Mon, 2022-02-28 at 16:34 +0100, Marek Vasut wrote: > On 2/28/22 09:18, Liu Ying wrote: > > Hi, Hi, > > > > > On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > > > > > Add compatible string for i.MX8MP LCDIF variant. This is called > > > > > LCDIFv3 > > > > > and is completely

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread David Laight
From: Linus Torvalds > Sent: 28 February 2022 19:56 > On Mon, Feb 28, 2022 at 4:19 AM Christian König > wrote: > > > > I don't think that using the extra variable makes the code in any way > > more reliable or easier to read. > > So I think the next step is to do the attached patch (which

linux-next: manual merge of the drm tree with the v4l-dvb tree

2022-02-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt between commit: 6d0990e6e844 ("media: dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW") from the v4l-dvb tree and commit:

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 4:38 PM Segher Boessenkool wrote: > > In C its scope is the rest of the declaration and the entire loop, not > anything after it. This was the same in C++98 already, btw (but in > pre-standard versions of C++ things were like you remember, yes, and it > was painful).

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 4:45 PM Linus Torvalds wrote: > > Yeah, except that's ugly beyond belief, plus it's literally not what > we do in the kernel. (Of course, I probably shouldn't have used 'min()' as an example, because that is actually one of the few places where we do exactly that, using

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 3:26 PM Matthew Wilcox wrote: > > #define ___PASTE(a, b) a##b > #define __PASTE(a, b) ___PASTE(a, b) > #define _min(a, b, u) ({ \ Yeah, except that's ugly beyond belief, plus it's literally not what we do in the kernel. Really. The "-Wshadow doesn't work on the

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 1:47 PM Jakob Koschel wrote: > > The goal of this is to get compiler warnings right? This would indeed be > great. Yes, so I don't mind having a one-time patch that has been gathered using some automated checker tool, but I don't think that works from a long-term

Re: [PATCH] drm/i915/guc: Fix flag query helper function to not modify state

2022-02-28 Thread Ceraolo Spurio, Daniele
On 2/17/2022 1:29 PM, john.c.harri...@intel.com wrote: From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as it was out of date. NB: No need for a 'Fixes' tag. The test was only ever used

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Matthew Wilcox
On Mon, Feb 28, 2022 at 12:37:15PM -0800, Linus Torvalds wrote: > On Mon, Feb 28, 2022 at 12:16 PM Matthew Wilcox wrote: > > > > Then we can never use -Wshadow ;-( I'd love to be able to turn it on; > > it catches real bugs. > > Oh, we already can never use -Wshadow regardless of things like

Re: [PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge

2022-02-28 Thread Kieran Bingham
Hi José Quoting José Expósito (2022-02-28 18:39:54) > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Signed-off-by: José Expósito > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c |

Re: [PATCH] drm/i915/guc: Fix flag query helper function to not modify state

2022-02-28 Thread Ceraolo Spurio, Daniele
On 2/17/2022 1:29 PM, john.c.harri...@intel.com wrote: From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as it was out of date. NB: No need for a 'Fixes' tag. The test was only ever used

Re: [PATCH] mm: split vm_normal_pages for LRU and non-LRU handling

2022-02-28 Thread Felix Kuehling
On 2022-02-28 15:34, Alex Sierra wrote: DEVICE_COHERENT pages introduce a subtle distinction in the way "normal" pages can be used by various callers throughout the kernel. They behave like normal pages for purposes of mapping in CPU page tables, and for COW. But they do not support LRU lists,

RE: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Lukas Wunner > Sent: Monday, February 28, 2022 16:33 > To: Bjorn Helgaas > Cc: Limonciello, Mario ; Mika Westerberg > ; Michael Jamet > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Lukas Wunner
On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote: > On Mon, Feb 28, 2022 at 03:33:13PM +, Limonciello, Mario wrote: > > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external- > > > facing" > > > >

Re: [PATCH v2] drm/amdgpu: Fix realloc of ptr

2022-02-28 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 28, 2022 at 5:55 AM Christian König wrote: > > Am 27.02.22 um 16:33 schrieb t...@redhat.com: > > From: Tom Rix > > > > Clang static analysis reports this error > > amdgpu_debugfs.c:1690:9: warning: 1st function call > >argument is an uninitialized value >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 23:59 +0200, Mike Rapoport wrote: > > On February 28, 2022 10:42:53 PM GMT+02:00, James Bottomley < > james.bottom...@hansenpartnership.com> wrote: > > On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: [...] > > > > I do wish we could actually poison the 'pos' value

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Bjorn Helgaas
On Mon, Feb 28, 2022 at 03:33:13PM +, Limonciello, Mario wrote: > [AMD Official Use Only] > > > > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external- > > facing" > > > assumption above. Not having a

Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-02-28 Thread Mark Brown
On Mon, Feb 28, 2022 at 03:38:02PM -0600, Rob Herring wrote: > Another pass at removing unnecessary use of 'allOf' with a '$ref'. > > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Mike Rapoport
On February 28, 2022 10:42:53 PM GMT+02:00, James Bottomley wrote: >On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: >> Am 28.02.22 um 20:56 schrieb Linus Torvalds: >> > On Mon, Feb 28, 2022 at 4:19 AM Christian König >> > wrote: >> > > I don't think that using the extra variable

Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-02-28 Thread Marek Behún
On Mon, 28 Feb 2022 15:38:02 -0600 Rob Herring wrote: > Another pass at removing unnecessary use of 'allOf' with a '$ref'. > > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a

Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins

2022-02-28 Thread Abhinav Kumar
Hi Johannes and Greg On 2/12/2022 12:35 AM, Abhinav Kumar wrote: Hi Johannes On 2/12/2022 12:24 AM, Johannes Berg wrote: On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: The thread is writing the data to a file in local storage. From our profiling, the read is the one taking the time

[PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-02-28 Thread Rob Herring
Another pass at removing unnecessary use of 'allOf' with a '$ref'. json-schema versions draft7 and earlier have a weird behavior in that any keywords combined with a '$ref' are ignored (silently). The correct form was to put a '$ref' under an 'allOf'. This behavior is now changed in the 2019-09

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-02-28 Thread Nicolas Dufresne
Hi Yunfei, this patch does not work unless userland calls enum_framesizes, which is completely optional. See comment and suggestion below. Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > Supported max resolution for different platforms are not the same: 2K > or 4K, getting it

Re: [PATCH] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-02-28 Thread Ramalingam C
Matt, This is the continuation of review happened at https://patchwork.freedesktop.org/patch/475177/?series=100419=1 On 2022-03-01 at 02:51:39 +0530, Ramalingam C wrote: > From: Ayaz A Siddiqui > > Xe-HP and latest devices support Flat CCS which reserved a portion of > the device memory to

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Theodore Ts'o
On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > case 1. Code with an actual circular dependency, but not deadlock. > > > >A circular dependency can be broken by a rescue wakeup source e.g. > >timeout. It's not a deadlock. If it's okay that the contexts > >participating

Re: [PATCH] drm/v3d: centralize error handling when init scheduler fails

2022-02-28 Thread Andrey Grodzovsky
Acked-by: Andrey Grodzovsky Andrey On 2022-02-28 13:16, Melissa Wen wrote: Remove redundant error message (since now it is very similar to what we do in drm_sched_init) and centralize all error handling in a unique place, as we follow the same steps in any case of failure. Signed-off-by:

[PATCH] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-02-28 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W.

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 21:56 +0100, Christian König wrote: > > Am 28.02.22 um 21:42 schrieb James Bottomley: > > On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: > > > Am 28.02.22 um 20:56 schrieb Linus Torvalds: > > > > On Mon, Feb 28, 2022 at 4:19 AM Christian König > > > > wrote: > >

[PATCH 2/2] drm/amd/display: move FPU code from dcn10 to dml/dcn10 folder

2022-02-28 Thread Melissa Wen
FPU operations in dcn10 was already moved to dml folder via calcs code. However, dcn1_0_ip and dcn_1_0_soc with FPU componentd remains on dcn10. Following previous changes to isolate FPU, this patch creates dcn10_fpu files to isolate FPU-specific code and moves those structs to it. Signed-off-by:

[PATCH 1/2] drm/amd/display: move FPU operations from dcn21 to dml/dcn20 folder

2022-02-28 Thread Melissa Wen
dml/dcn20_fpu file centralizes all DCN2x functions that require FPU access. Therefore, this patch moves FPU-related code from dcn21 to dcn20_fpu. These include: - dcn21_populate_dml_pipes_from_context() - dcn21_validate_bandwidth_fp() and related: - dcn21_calculate_wm(), -

[PATCH 0/2] isolate FPU code from dcn10 and dcn21 to dml folder

2022-02-28 Thread Melissa Wen
Continuing the work of isolating FPU code from DCN drivers, this patchset moves FPU-specific operations from dcn10 and dcn21 to dml folder. I move FPU code from dcn21 to dml/dcn20_fpu since there is a documentation in dcn20_fpu.c that states dcn20_fpu centralizes: `all DCN20 and DCN2.1 (DCN2x)

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Christian König
Am 28.02.22 um 21:42 schrieb James Bottomley: On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: Am 28.02.22 um 20:56 schrieb Linus Torvalds: On Mon, Feb 28, 2022 at 4:19 AM Christian König wrote: [SNIP] Anybody have any ideas? I think we should look at the use cases why code is

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread James Bottomley
On Mon, 2022-02-28 at 21:07 +0100, Christian König wrote: > Am 28.02.22 um 20:56 schrieb Linus Torvalds: > > On Mon, Feb 28, 2022 at 4:19 AM Christian König > > wrote: > > > I don't think that using the extra variable makes the code in any > > > way > > > more reliable or easier to read. > > So I

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 12:29 PM Johannes Berg wrote: > > If we're willing to change the API for the macro, we could do > > list_for_each_entry(type, pos, head, member) > > and then actually take advantage of -Wshadow? See my reply to Willy. There is no way -Wshadow will ever happen. I

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 12:16 PM Matthew Wilcox wrote: > > Then we can never use -Wshadow ;-( I'd love to be able to turn it on; > it catches real bugs. Oh, we already can never use -Wshadow regardless of things like this. That bridge hasn't just been burned, it never existed in the first

Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-02-28 Thread Michal Wajdeczko
On 17.02.2022 15:41, Andi Shyti wrote: > From: Sujaritha Sundaresan > > This patch adds the following new sysfs frequency attributes; > - punit_req_freq_mhz > - throttle_reason_status > - throttle_reason_pl1 > - throttle_reason_pl2 > - throttle_reason_pl4 >

[PATCH] mm: split vm_normal_pages for LRU and non-LRU handling

2022-02-28 Thread Alex Sierra
DEVICE_COHERENT pages introduce a subtle distinction in the way "normal" pages can be used by various callers throughout the kernel. They behave like normal pages for purposes of mapping in CPU page tables, and for COW. But they do not support LRU lists, NUMA migration or THP. Therefore we split

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Johannes Berg
On Mon, 2022-02-28 at 20:16 +, Matthew Wilcox wrote: > On Mon, Feb 28, 2022 at 12:10:24PM -0800, Linus Torvalds wrote: > > We can do > > > > typeof(pos) pos > > > > in the 'for ()' loop, and never use __iter at all. > > > > That means that inside the for-loop, we use a _different_

[PATCH v2 2/2] drm/atomic: Force bridge self-refresh-exit on CRTC switch

2022-02-28 Thread Brian Norris
It's possible to change which CRTC is in use for a given connector/encoder/bridge while we're in self-refresh without fully disabling the connector/encoder/bridge along the way. This can confuse the bridge encoder/bridge, because (a) it needs to track the SR state (trying to perform "active"

[PATCH v2 1/2] drm/bridge: analogix_dp: Support PSR-exit to disable transition

2022-02-28 Thread Brian Norris
Most eDP panel functions only work correctly when the panel is not in self-refresh. In particular, analogix_dp_bridge_disable() tends to hit AUX channel errors if the panel is in self-refresh. Given the above, it appears that so far, this driver assumes that we are never in self-refresh when it

[PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

2022-02-28 Thread Brian Norris
Hi, I've been investigating several eDP issues on a Rockchip RK3399 system and have two proposed bugfixes. RK3399 has two CRTCs, either of which can be used for eDP output. For both fixes, we have bugs due to the relationship between the generalized "self refresh helpers" and the analogix-dp

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 12:10 PM Linus Torvalds wrote: > > We can do > > typeof(pos) pos > > in the 'for ()' loop, and never use __iter at all. > > That means that inside the for-loop, we use a _different_ 'pos' than outside. The thing that makes me throw up in my mouth a bit is that in

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Matthew Wilcox
On Mon, Feb 28, 2022 at 12:10:24PM -0800, Linus Torvalds wrote: > We can do > > typeof(pos) pos > > in the 'for ()' loop, and never use __iter at all. > > That means that inside the for-loop, we use a _different_ 'pos' than outside. Then we can never use -Wshadow ;-( I'd love to be

[PATCH] drm/i915: Add a DP1.2 compatible way to read LTTPR capabilities

2022-02-28 Thread Imre Deak
At least some DELL monitors (P2715Q) with DPCD_REV 1.2 return corrupted DPCD register values when reading from the 0xF- LTTPR range with an AUX transaction block size bigger than 1. The DP standard requires 0 to be returned - as for any other reserved/invalid addresses - but these monitors

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 12:03 PM Linus Torvalds wrote: > > Side note: we do need *some* way to do it. Ooh. This patch is a work of art. And I mean that in the worst possible way. We can do typeof(pos) pos in the 'for ()' loop, and never use __iter at all. That means that inside the

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Christian König
Am 28.02.22 um 20:56 schrieb Linus Torvalds: On Mon, Feb 28, 2022 at 4:19 AM Christian König wrote: I don't think that using the extra variable makes the code in any way more reliable or easier to read. So I think the next step is to do the attached patch (which requires that "-std=gnu11"

Re: [PATCH 2/2] drm/atomic: Force bridge self-refresh-exit on CRTC switch

2022-02-28 Thread Brian Norris
Hi Liu, On Mon, Feb 28, 2022 at 1:02 AM Liu Ying wrote: > On Tue, 2022-02-15 at 15:54 -0800, Brian Norris wrote: > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > @@ -1011,9 +1011,19 @@ crtc_needs_disable(struct drm_crtc_state *old_state, > >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 11:56 AM Linus Torvalds wrote: > > I do wish we could actually poison the 'pos' value after the loop > somehow - but clearly the "might be uninitialized" I was hoping for > isn't the way to do it. Side note: we do need *some* way to do it. Because if we make that change,

Re: [Intel-gfx] [PATCH v5 3/7] drm/i915/gt: add gt_is_root() helper

2022-02-28 Thread Michal Wajdeczko
On 17.02.2022 15:41, Andi Shyti wrote: > The "gt_is_root(struct intel_gt *gt)" helper return true if the > gt is the root gt, which means that its id is 0. Return false > otherwise. > > Suggested-by: Michal Wajdeczko > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gt/intel_gt.h | 5

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 4:19 AM Christian König wrote: > > I don't think that using the extra variable makes the code in any way > more reliable or easier to read. So I think the next step is to do the attached patch (which requires that "-std=gnu11" that was discussed in the original thread).

Re: [PATCH v5 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0

2022-02-28 Thread Michal Wajdeczko
On 17.02.2022 15:41, Andi Shyti wrote: > With the upcoming multitile support each tile will have its own > local memory. Mark the current LMEM with the suffix '0' to > emphasise that it belongs to the root tile. > > Suggested-by: Michal Wajdeczko > Signed-off-by: Andi Shyti > --- >

Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

2022-02-28 Thread Rob Herring
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara wrote: > > On Tue, 25 Jan 2022 12:37:38 + > Liviu Dudau wrote: > > Hi, > > > On Mon, Jan 24, 2022 at 04:24:37PM +, carsten.haitz...@foss.arm.com > > wrote: > > > From: Carsten Haitzler > > > > > > Without DRM_GEM_CMA_HELPER HDLCD won't

[CI 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-02-28 Thread Vivek Kasireddy
On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[CI 0/2] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation

2022-02-28 Thread Vivek Kasireddy
The first patch is a drm core patch that replaces the for loop in drm_mm_insert_node_in_range() with the iterator and would not cause any functional changes. The second patch is a i915 driver specific patch that also uses the iterator but solves a different problem. v2: - Added a new patch to

[CI 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v5)

2022-02-28 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-28 Thread John Harrison
On 2/28/2022 07:32, Tvrtko Ursulin wrote: On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin wrote: On 25/02/2022 17:11, John Harrison wrote: On 2/25/2022 08:36, Tvrtko Ursulin

RE: [Intel-gfx] [CI 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v4)

2022-02-28 Thread Kasireddy, Vivek
Hi Tvrtko, > > Hi Vivek, > > On 27/02/2022 17:29, Vivek Kasireddy wrote: > > This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() > > functions to identify suitable holes for an allocation of a given > > size by efficiently traversing the rbtree associated with the given > >

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-28 Thread John Harrison
On 2/28/2022 09:12, Tvrtko Ursulin wrote: On 25/02/2022 18:48, John Harrison wrote: On 2/25/2022 10:14, Tvrtko Ursulin wrote: I'll try to simplify the discussion here: On 24/02/2022 19:45, John Harrison wrote: On 2/24/2022 03:41, Tvrtko Ursulin wrote: On 23/02/2022 20:00, John Harrison

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 3:37 AM Arnd Bergmann wrote: > > I think the KBUILD_USERCFLAGS portion and the modpost.c fix for it > make sense regardless of the -std=gnu11 change I do think they make sense, but I want to note again that people doing cross builds obviously use different tools for user

[PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge

2022-02-28 Thread José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

[PATCH] drm/bridge: ti-sn65dsi83: switch to devm_drm_of_get_bridge

2022-02-28 Thread José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-)

[PATCH] drm/bridge: tc358775: switch to devm_drm_of_get_bridge

2022-02-28 Thread José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/tc358775.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[PATCH] drm/bridge: tc358762: switch to devm_drm_of_get_bridge

2022-02-28 Thread José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- drivers/gpu/drm/bridge/tc358762.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-28 Thread John Harrison
On 2/28/2022 08:11, Tvrtko Ursulin wrote: On 25/02/2022 17:39, John Harrison wrote: On 2/25/2022 09:06, Tvrtko Ursulin wrote: On 24/02/2022 19:19, John Harrison wrote: [snip] ./gt/uc/intel_guc_fwif.h: u32 execution_quantum; ./gt/uc/intel_guc_submission.c: desc->execution_quantum =

  1   2   3   >