Re: [PATCH 9/9] drm: mxsfb: Add support for i.MX8MP LCDIF variant

2022-03-01 Thread kernel test robot
://anongit.freedesktop.org/drm-intel for-linux-next config: mips-randconfig-c004-20220227 (https://download.01.org/0day-ci/archive/20220301/202203010150.l57eax3w-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e

[PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

2022-03-01 Thread Jiasheng Jiang
As the potential failure of the i915_gem_object_trylock(), it should be better to check it and return error if fails. Fixes: 94ce0d65076c ("drm/i915/gt: Setup a default migration context on the GT") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 6 +- 1 file

[PATCH v5 11/13] drm/i915/xehp: handle fused off CCS engines

2022-03-01 Thread Matt Roper
From: Daniele Ceraolo Spurio HW resources are divided across the active CCS engines at the compute slice level, with each CCS having priority on one of the cslices. If a compute slice has no enabled DSS, its paired compute engine is not usable in full parallel execution because the other ones

[PATCH] dt-bindings: gpu: Convert aspeed-gfx bindings to yaml

2022-03-01 Thread Joel Stanley
Convert the bindings to yaml and add the ast2600 compatible string. Signed-off-by: Joel Stanley --- .../devicetree/bindings/gpu/aspeed,gfx.yaml | 69 +++ .../devicetree/bindings/gpu/aspeed-gfx.txt| 41 --- 2 files changed, 69 insertions(+), 41 deletions(-) create

Re: linux-next: build warning after merge of the drm-misc tree

2022-03-01 Thread Stephen Rothwell
Hi Andrey, On Tue, 1 Mar 2022 22:26:12 -0500 Andrey Grodzovsky wrote: > > Please check you have commit c7703ce38c1e Andrey Grodzovsky   3 weeks ago    > drm/amdgpu: Fix htmldoc warning That has arrived in linux-next today for the first time. It is in the drm tree, but that tree has had build

Re: [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Dmitry Baryshkov
On 02/03/2022 05:44, Bjorn Andersson wrote: On Tue 01 Mar 17:47 PST 2022, Dmitry Baryshkov wrote: On Wed, 2 Mar 2022 at 04:27, Bjorn Andersson wrote: It's typical for the bootloader to bring up the display for showing a boot splash or efi framebuffer. But in some cases the kernel driver

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Jagan Teki
On Wed, Mar 2, 2022 at 4:50 AM Linus Walleij wrote: > > On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki wrote: > > > + bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > > + if (IS_ERR(bridge)) { > > + dev_err(dev, "error to get bridge\n"); > > + return

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Jagan Teki
On Wed, Mar 2, 2022 at 4:43 AM Linus Walleij wrote: > > On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki wrote: > > > devm_drm_of_get_bridge is capable of looking up the downstream > > bridge and panel and trying to add a panel bridge if the panel > > is found. > > > > Replace explicit finding calls

Re: [PATCH 2/2] drm/i915: Remove the vm open count

2022-03-01 Thread Niranjana Vishwanathapura
On Tue, Feb 22, 2022 at 06:10:30PM +0100, Thomas Hellström wrote: vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount. The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make

Re: linux-next: build warning after merge of the drm-misc tree

2022-03-01 Thread Andrey Grodzovsky
Please check you have commit c7703ce38c1e Andrey Grodzovsky   3 weeks ago    drm/amdgpu: Fix htmldoc warning Andrey On 2022-03-01 20:31, Stephen Rothwell wrote: Hi all, On Thu, 20 Jan 2022 14:26:39 +1100 Stephen Rothwell wrote: On Wed, 17 Nov 2021 13:49:26 +1100 Stephen Rothwell wrote:

Re: [PATCH v6 0/5] Add Aspeed AST2600 soc display support

2022-03-01 Thread Joel Stanley
On Wed, 2 Mar 2022 at 02:49, Tommy Haung wrote: > > v6: > Remove some unnecessary reset patch. > Refine patch format. > Add detail explain of SOC display reset bits. > > v5: > Add lost reset define. > > v4: > Add necessary reset control for ast2600. > Add chip caps for futher use. >

Re: [PATCH v6 5/5] ARM: dtsi: aspeed: Modified gfx reset control

2022-03-01 Thread Joel Stanley
On Wed, 2 Mar 2022 at 02:50, Tommy Haung wrote: > > Remove the ast2500-gfx from aspeed-g6.dtsi. > In the AST2600, the ASPEED_RESET_CRT1 is replaced by > ASPEED_RESET_GRAPHICS. This is no differnce between these two reset > behavior but reigster location is changed. The HW controller states > and

[PATCH v6 5/5] ARM: dtsi: aspeed: Modified gfx reset control

2022-03-01 Thread Tommy Haung
Remove the ast2500-gfx from aspeed-g6.dtsi. In the AST2600, the ASPEED_RESET_CRT1 is replaced by ASPEED_RESET_GRAPHICS. This is no differnce between these two reset behavior but reigster location is changed. The HW controller states and FW programming resgiter will be reset by CRT reset controller

[PATCH v6 4/5] drm/aspeed: Add AST2600 chip support

2022-03-01 Thread Tommy Haung
Add AST2600 chip support and setting. Signed-off-by: Tommy Haung --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index d4b56b3c7597..d10246b1d1c2 100644

[PATCH v6 0/5] Add Aspeed AST2600 soc display support

2022-03-01 Thread Tommy Haung
v6: Remove some unnecessary reset patch. Refine patch format. Add detail explain of SOC display reset bits. v5: Add lost reset define. v4: Add necessary reset control for ast2600. Add chip caps for futher use. These code are test on AST2500 and AST2600 by below steps. 1. Add

[PATCH v6 1/5] ARM: dts: aspeed: Add GFX node to AST2600

2022-03-01 Thread Tommy Haung
From: Joel Stanley The GFX device is present in the AST2600 SoC. Signed-off-by: Joel Stanley Signed-off-by: Tommy Haung --- arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi

[PATCH v6 3/5] drm/aspeed: Update INTR_STS handling

2022-03-01 Thread Tommy Haung
Add interrupt clear register define for further chip support. Signed-off-by: Tommy Haung --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 1 + drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h

[PATCH v6 2/5] ARM: dts: aspeed: ast2600-evb: Enable GFX device

2022-03-01 Thread Tommy Haung
From: Joel Stanley Enable the GFX device with a framebuffer memory region. Signed-off-by: Joel Stanley Signed-off-by: Tommy Haung --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Marek Vasut
On 3/1/22 14:18, Lucas Stach wrote: Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: On 3/1/22 11:04, Lucas Stach wrote: Hi, [...] Given the two totally

Re: [PATCH v9] drm/amdgpu: add drm buddy support to amdgpu

2022-03-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next v5.17-rc6 next-20220301] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Marek Vasut
On 3/1/22 14:37, Robby Cai wrote: Hi, [...] I tend to agree with Marek on this one. We have an instance where the blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, but different enough where each SoC has it's own set of tables and some checks. Lucas created the framework,

Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-03-01 Thread Bjorn Andersson
On Mon 28 Feb 13:38 PST 2022, Rob Herring wrote: > Another pass at removing unnecessary use of 'allOf' with a '$ref'. > > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref'

Re: [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Bjorn Andersson
On Tue 01 Mar 17:47 PST 2022, Dmitry Baryshkov wrote: > On Wed, 2 Mar 2022 at 04:27, Bjorn Andersson > wrote: > > > > It's typical for the bootloader to bring up the display for showing a > > boot splash or efi framebuffer. But in some cases the kernel driver ends > > up only partially

[PATCH v4 2/2] drm/bridge: analogix_dp: Enable autosuspend

2022-03-01 Thread Brian Norris
DP AUX transactions can consist of many short operations. There's no need to power things up/down in short intervals. I pick an arbitrary 100ms; for the systems I'm testing (Rockchip RK3399), runtime-PM transitions only take a few microseconds. Signed-off-by: Brian Norris --- Changes in v4: -

[PATCH v4 1/2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-03-01 Thread Brian Norris
If the display is not enable()d, then we aren't holding a runtime PM reference here. Thus, it's easy to accidentally cause a hang, if user space is poking around at /dev/drm_dp_aux0 at the "wrong" time. Let's get a runtime PM reference, and check that we "see" the panel. Don't force any panel

Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-03-01 Thread Jakub Kicinski
On Mon, 28 Feb 2022 15:38:02 -0600 Rob Herring wrote: > Another pass at removing unnecessary use of 'allOf' with a '$ref'. > > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref'

Re: [PATCH v3 2/2] drm/bridge: analogix_dp: Enable autosuspend

2022-03-01 Thread Brian Norris
On Tue, Feb 22, 2022 at 2:10 PM Doug Anderson wrote: > On Thu, Feb 17, 2022 at 2:42 PM Brian Norris wrote: > > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > > @@ -1121,7 +1121,7 @@ static int analogix_dp_get_modes(struct

Re: [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Dmitry Baryshkov
On Wed, 2 Mar 2022 at 04:27, Bjorn Andersson wrote: > > It's typical for the bootloader to bring up the display for showing a > boot splash or efi framebuffer. But in some cases the kernel driver ends > up only partially configuring (in particular) the DPU, which might > result in e.g. that two

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:14:10) > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix > indentation for another brace, so it matches the corresponding line. > > Reported-by: Rob Herring > Cc: Loic Poulain > Reviewed-by: Bjorn Andersson > Signed-off-by: Dmitry

Re: [PATCH 5/5] arm64: dts: qcom: sm8250: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:52:10) > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH 4/5] arm64: dts: qcom: sdm845: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:52:09) > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH 3/5] arm64: dts: qcom: sdm660: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:52:08) > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH 2/5] arm64: dts: qcom: sdm630: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:52:07) > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-01 16:52:06) > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Signed-off-by: Dmitry Baryshkov > ---

Re: linux-next: build warning after merge of the drm tree

2022-03-01 Thread Stephen Rothwell
Hi all, On Wed, 2 Feb 2022 09:38:37 +0100 Hans de Goede wrote: > > On 2/2/22 05:03, Stephen Rothwell wrote: > > > > On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell > > wrote: > >> > >> After merging the drm tree, today's linux-next build (htmldocs) produced > >> this warning: > >> > >>

Re: linux-next: build warning after merge of the drm tree

2022-03-01 Thread Stephen Rothwell
Hi all, On Wed, 2 Feb 2022 15:10:45 +1100 Stephen Rothwell wrote: > > After merging the drm tree, today's linux-next build (htmldocs) produced > this warning: > > include/drm/drm_connector.h:637: warning: Function parameter or member > 'edid_hdmi_rgb444_dc_modes' not described in

Re: linux-next: build warning after merge of the drm-misc tree

2022-03-01 Thread Stephen Rothwell
Hi all, On Thu, 20 Jan 2022 14:26:39 +1100 Stephen Rothwell wrote: > > On Wed, 17 Nov 2021 13:49:26 +1100 Stephen Rothwell > wrote: > > > > After merging the drm-misc tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/drm/gpu_scheduler.h:316: warning:

[PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Bjorn Andersson
It's typical for the bootloader to bring up the display for showing a boot splash or efi framebuffer. But in some cases the kernel driver ends up only partially configuring (in particular) the DPU, which might result in e.g. that two different data paths attempts to push data to the interface -

[PATCH v2 1/2] dt-bindings: display: msm: Add optional resets

2022-03-01 Thread Bjorn Andersson
Add an optional reference to the MDSS_CORE reset, which when specified can be used by the implementation to reset the hardware blocks. Signed-off-by: Bjorn Andersson --- Changes since v1: - New approach/patch .../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 4

[PATCH 5/5] arm64: dts: qcom: sm8250: Drop flags for mdss irqs

2022-03-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++--- 1 file changed,

[PATCH 3/5] arm64: dts: qcom: sdm660: Drop flags for mdss irqs

2022-03-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm660.dtsi | 2 +- 1 file changed, 1

[PATCH 4/5] arm64: dts: qcom: sdm845: Drop flags for mdss irqs

2022-03-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++--- 1 file changed,

[PATCH 2/5] arm64: dts: qcom: sdm630: Drop flags for mdss irqs

2022-03-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 4 ++-- 1 file changed, 2

[PATCH 1/5] arm64: dts: qcom: msm8996: Drop flags for mdss irqs

2022-03-01 Thread Dmitry Baryshkov
The number of interrupt cells for the mdss interrupt controller is 1, meaning there should only be one cell for the interrupt number, not two. Drop the second cell containing (unused) irq flags. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++--- 1 file

Re: [PATCH v3 RESEND 21/24] drm/exynos/decon5433: add local path support

2022-03-01 Thread Inki Dae
Hi Krzysztof, 22. 2. 7. 01:51에 Krzysztof Kozlowski 이(가) 쓴 글: > On 25/03/2019 08:13, Andrzej Hajda wrote: >> GSCALERs in Exynos5433 have local path to DECON and DECON_TV. >> They can be used as extra planes with support for non-RGB formats and >> scaling. >> To enable it on DECON update_plane and

Re: [Freedreno] [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Abhinav Kumar
On 3/1/2022 4:14 PM, Dmitry Baryshkov wrote: Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix indentation for another brace, so it matches the corresponding line. Reported-by: Rob Herring Cc: Loic Poulain Reviewed-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov

[PATCH v3 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-03-01 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2

[PATCH v3 3/8] drm/i915/guc: Better name for context id limit

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. Instead, size the pool according to the number of contexts allowed. Note that this is just a naming change, the actual limit is identical in value. While at it, also

[PATCH v3 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is inefficient, so move the setup to later in the process after the

[PATCH v3 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++

[PATCH v3 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-03-01 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file

[PATCH v3 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio ---

[PATCH v3 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try to register functions. Note that some of those 'try to

[PATCH v3 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Also, rename the set/clear/query helper functions for context id mappings to better reflect

[PATCH v3 0/8] Prep work for next GuC release

2022-03-01 Thread John . C . Harrison
From: John Harrison The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Dmitry Baryshkov
On Wed, 2 Mar 2022 at 03:14, Dmitry Baryshkov wrote: > > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix > indentation for another brace, so it matches the corresponding line. > > Reported-by: Rob Herring > Cc: Loic Poulain > Reviewed-by: Bjorn Andersson > Signed-off-by:

Re: [PATCH v3 09/13] drm/i915/xehp/guc: enable compute engine inside GuC

2022-03-01 Thread Matt Roper
On Tue, Mar 01, 2022 at 03:15:45PM -0800, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > Tell GuC that CCS is enabled by setting a bit in its ADS. > > Cc: Vinay Belgaumkar > Original-author: Michel Thierry > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matt Roper

[PATCH v4 08/13] drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE

2022-03-01 Thread Matt Roper
We have to specify in the Render Control Unit Mode register when CCS is enabled. v2: - Move RCU_MODE programming to a helper function. (Tvrtko) - Clean up and clarify comments. (Tvrtko) - Add RCU_MODE to the GuC save/restore list. (Daniele) v3: - Move this patch before the GuC ADS update

[RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Dmitry Baryshkov
Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix indentation for another brace, so it matches the corresponding line. Reported-by: Rob Herring Cc: Loic Poulain Reviewed-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov --- Didn't include freedreno@ in the first email, so

Re: [PATCH 0/2] DSI host and peripheral initialisation ordering

2022-03-01 Thread Doug Anderson
Hi, On Wed, Feb 16, 2022 at 9:00 AM Dave Stevenson wrote: > > Hi All > > Hopefully I've cc'ed all those that have bashed this problem around > previously, > or are otherwise linked to DRM bridges. > > There have been numerous discussions around how DSI support is currently > broken > as it

Re: [PATCH v3 13/13] drm/i915/xehpsdv: Move render/compute engine reset domains related workarounds

2022-03-01 Thread Matt Roper
On Tue, Mar 01, 2022 at 03:15:49PM -0800, Matt Roper wrote: > From: Srinivasan Shanmugam > > Registers that exist in the shared render/compute reset domain need to > be placed on an engine workaround list to ensure that they are properly > re-applied whenever an RCS or CCS engine is reset. We

Re: [Intel-gfx] [PATCH v3 08/13] drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE

2022-03-01 Thread Matt Roper
On Tue, Mar 01, 2022 at 03:51:21PM -0800, Umesh Nerlige Ramappa wrote: > On Tue, Mar 01, 2022 at 03:15:44PM -0800, Matt Roper wrote: > > We have to specify in the Render Control Unit Mode register > > when CCS is enabled. > > > > v2: > > - Move RCU_MODE programming to a helper function. (Tvrtko)

RE: [PATCH v5 5/7] drm/aspeed: Add reset and clock for AST2600

2022-03-01 Thread Tommy Huang
Hi Joel, > -Original Message- > From: Joel Stanley > Sent: Tuesday, March 1, 2022 7:05 PM > To: Tommy Huang > Cc: David Airlie ; Daniel Vetter ; Rob > Herring ; Andrew Jeffery ; > linux-aspeed ; open list:DRM DRIVERS > ; devicetree ; > Linux ARM ; Linux Kernel Mailing List > ; BMC-SW >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Linus Torvalds
On Tue, Mar 1, 2022 at 3:19 PM David Laight wrote: > > Having said that there are so few users of list_entry_is_head() > it is reasonable to generate two new names. Well, the problem is that the users of list_entry_is_head() may be few - but there are a number of _other_ ways to check "was that

Re: [Intel-gfx] [PATCH v3 08/13] drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE

2022-03-01 Thread Umesh Nerlige Ramappa
On Tue, Mar 01, 2022 at 03:15:44PM -0800, Matt Roper wrote: We have to specify in the Render Control Unit Mode register when CCS is enabled. v2: - Move RCU_MODE programming to a helper function. (Tvrtko) - Clean up and clarify comments. (Tvrtko) - Add RCU_MODE to the GuC save/restore list.

Re: [PATCH v3 11/13] drm/i915/xehp: handle fused off CCS engines

2022-03-01 Thread Matt Roper
On Tue, Mar 01, 2022 at 03:15:47PM -0800, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > HW resources are divided across the active CCS engines at the compute > slice level, with each CCS having priority on one of the cslices. > If a compute slice has no enabled DSS, its paired compute

Re: [PATCH] drm/v3d: centralize error handling when init scheduler fails

2022-03-01 Thread Melissa Wen
On Mon, Feb 28, 2022 at 8:21 PM Andrey Grodzovsky wrote: > > Acked-by: Andrey Grodzovsky > > Andrey Thanks. Applied to drm-misc-next. Melissa > > On 2022-02-28 13:16, Melissa Wen wrote: > > Remove redundant error message (since now it is very similar to what > > we do in drm_sched_init) and

Re: [PATCH v3 09/13] drm/i915/xehp/guc: enable compute engine inside GuC

2022-03-01 Thread Ceraolo Spurio, Daniele
On 3/1/2022 3:15 PM, Matt Roper wrote: From: Daniele Ceraolo Spurio Tell GuC that CCS is enabled by setting a bit in its ADS. It's a mask, not a bit. Reviewed-by: Daniele Ceraolo Spurio Daniele Cc: Vinay Belgaumkar Original-author: Michel Thierry Signed-off-by: Daniele Ceraolo

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Linus Walleij
On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki wrote: > + bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > + if (IS_ERR(bridge)) { > + dev_err(dev, "error to get bridge\n"); > + return PTR_ERR(bridge); > } > > d->bridge_out = bridge;

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread David Laight
From: Linus Torvalds > Sent: 01 March 2022 23:03 > > On Tue, Mar 1, 2022 at 2:58 PM David Laight wrote: > > > > Can it be resolved by making: > > #define list_entry_is_head(pos, head, member) ((pos) == NULL) > > and double-checking that it isn't used anywhere else (except in > > the list macros

Re: [PATCH] dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes

2022-03-01 Thread Dmitry Baryshkov
On Wed, 2 Mar 2022 at 00:05, Rob Herring wrote: > > The MDSS interrupt provider is a single cell, so specifying interrupt flags > on the consumers is incorrect. > > Signed-off-by: Rob Herring Reviewed-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/dpu-msm8998.yaml

[PATCH v3 12/13] drm/i915/xehp: Add compute workarounds

2022-03-01 Thread Matt Roper
Additional workarounds are required once we start exposing CCS engines. Note that we have a number of workarounds that update registers in the shared render/compute reset domain. Historically we've just added such registers to the RCS engine's workaround list. But going forward we should be

[PATCH v3 09/13] drm/i915/xehp/guc: enable compute engine inside GuC

2022-03-01 Thread Matt Roper
From: Daniele Ceraolo Spurio Tell GuC that CCS is enabled by setting a bit in its ADS. Cc: Vinay Belgaumkar Original-author: Michel Thierry Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 13/13] drm/i915/xehpsdv: Move render/compute engine reset domains related workarounds

2022-03-01 Thread Matt Roper
From: Srinivasan Shanmugam Registers that exist in the shared render/compute reset domain need to be placed on an engine workaround list to ensure that they are properly re-applied whenever an RCS or CCS engine is reset. We have a number of workarounds (updating registers MLTICTXCTL,

[PATCH v3 08/13] drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE

2022-03-01 Thread Matt Roper
We have to specify in the Render Control Unit Mode register when CCS is enabled. v2: - Move RCU_MODE programming to a helper function. (Tvrtko) - Clean up and clarify comments. (Tvrtko) - Add RCU_MODE to the GuC save/restore list. (Daniele) v3: - Move this patch before the GuC ADS update

[PATCH v3 10/13] drm/i915/xehp: Don't support parallel submission on compute / render

2022-03-01 Thread Matt Roper
From: Matthew Brost A different emit breadcrumbs ring programming is required for compute / render and we don't have UMD user so just reject parallel submission for these engine classes. Signed-off-by: Matthew Brost Signed-off-by: Matt Roper Reviewed-by: Daniele Ceraolo Spurio ---

[PATCH v3 11/13] drm/i915/xehp: handle fused off CCS engines

2022-03-01 Thread Matt Roper
From: Daniele Ceraolo Spurio HW resources are divided across the active CCS engines at the compute slice level, with each CCS having priority on one of the cslices. If a compute slice has no enabled DSS, its paired compute engine is not usable in full parallel execution because the other ones

[PATCH v3 07/13] drm/i915/xehp: Define context scheduling attributes in lrc descriptor

2022-03-01 Thread Matt Roper
In Dual Context mode the EUs are shared between render and compute command streamers. The hardware provides a field in the lrc descriptor to indicate the prioritization of the thread dispatch associated to the corresponding context. The context priority is set to 'low' at creation time and relies

[PATCH v3 05/13] drm/i915/xehp: CCS should use RCS setup functions

2022-03-01 Thread Matt Roper
The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to the render one, so reuse it. Note that the compute engine has its own

[PATCH v3 06/13] drm/i915: Move context descriptor fields to intel_lrc.h

2022-03-01 Thread Matt Roper
This is a more appropriate header for these definitions. v2: - Cleanup whitespace. (Lucas) Signed-off-by: Matt Roper Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 34 ---

[PATCH v3 04/13] drm/i915/xehp: compute engine pipe_control

2022-03-01 Thread Matt Roper
From: Daniele Ceraolo Spurio CCS will reuse the RCS functions for breadcrumb and flush emission. However, CCS pipe_control has additional programming restrictions: - Command Streamer Stall Enable must be always set - Post Sync Operations must not be set to Write PS Depth Count - 3D-related

[PATCH v3 03/13] drm/i915/xehp: Add Compute CS IRQ handlers

2022-03-01 Thread Matt Roper
Add execlists and GuC interrupts for compute CS into existing IRQ handlers. All compute command streamers belong to the same compute class, so the only change needed to enable their interrupts is to program their GT engine interrupt mask registers. CCS0 shares the register with CCS1, while CCS2

[PATCH v3 01/13] drm/i915/xehp: Define compute class and engine

2022-03-01 Thread Matt Roper
Introduce a Compute Command Streamer (CCS), which has access to the media and GPGPU pipelines (but not the 3D pipeline). To begin with, define the compute class/engine common functions, based on the existing render ones. v2: - Add kerneldoc for drm_i915_gem_engine_class since we're adding a new

[PATCH v3 02/13] drm/i915/xehp: CCS shares the render reset domain

2022-03-01 Thread Matt Roper
The reset domain is shared between render and all compute engines, so resetting one will affect the others. Note: Before performing a reset on an RCS or CCS engine, the GuC will attempt to preempt-to-idle the other non-hung RCS/CCS engines to avoid impacting other clients (since some shared

[PATCH v3 00/13] i915: Prepare for Xe_HP compute engines

2022-03-01 Thread Matt Roper
The Xe_HP architecture introduces compute engines as a new engine class. These compute command streamers (CCS) are similar to the render engine, except that they're intended for GPGPU usage and lack support for the 3D pipeline. For now we're just sending some initial "under the hood" preparation

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Linus Walleij
On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki wrote: > devm_drm_of_get_bridge is capable of looking up the downstream > bridge and panel and trying to add a panel bridge if the panel > is found. > > Replace explicit finding calls with devm_drm_of_get_bridge. > > Cc: Linus Walleij > Signed-off-by:

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Linus Torvalds
On Tue, Mar 1, 2022 at 2:58 PM David Laight wrote: > > Can it be resolved by making: > #define list_entry_is_head(pos, head, member) ((pos) == NULL) > and double-checking that it isn't used anywhere else (except in > the list macros themselves). Well, yes, except for the fact that then the name

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread David Laight
From: Linus Torvalds > Sent: 01 March 2022 19:07 > On Mon, Feb 28, 2022 at 2:29 PM James Bottomley > wrote: > > > > However, if the desire is really to poison the loop variable then we > > can do > > > > #define list_for_each_entry(pos, head, member) \ > > for

Re: [PATCH v2 11/13] drm/i915/xehp: handle fused off CCS engines

2022-03-01 Thread Matt Roper
On Mon, Feb 28, 2022 at 09:42:43AM -0800, Matt Roper wrote: > From: Daniele Ceraolo Spurio > > HW resources are divided across the active CCS engines at the compute > slice level, with each CCS having priority on one of the cslices. > If a compute slice has no enabled DSS, its paired compute

[pull] drm/msm: drm-msm-next-2022-03-01 for 5.18

2022-03-01 Thread Rob Clark
Hi Dave & Daniel, This is the main pull for v5.18. We're experimenting a bit with the process this time, with Dmitry collecting display patches and merging them into msm-next with me handling the gpu/etc side of things. Summary of interesting new bits and pieces * dpu + dp support for sc8180x

Re: [PATCH v7, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. You already have a reviewed tag, but I'm under the impression that there is a fair amount of duplication

Re: [PATCH v7, 14/15] media: mtk-vcodec: support stateless VP8 decoding

2022-03-01 Thread Nicolas Dufresne
Thanks for this work. Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Add support for VP8 decoding using the stateless API, > as supported by MT8192. With the struct members naming made consistent, even though I would like your patch better if it was not duplicating so much

Re: [PATCH v7, 13/15] media: mtk-vcodec: support stateless H.264 decoding for mt8192

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Adds h264 lat and core architecture driver for mt8192, > and the decode mode is frame based for stateless decoder. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/Makefile| 1 + >

Re: [Intel-gfx] [PATCH v3] drm/i915/guc: Do not complain about stale reset notifications

2022-03-01 Thread Ceraolo Spurio, Daniele
On 2/24/2022 5:52 PM, john.c.harri...@intel.com wrote: From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets

[PATCH v2 4/4] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-01 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

[PATCH v2 3/4] drm/i915/gem: Extra pages in ttm_tt for ccs data

2022-03-01 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

[PATCH v2 2/4] drm/ttm: parameter to add extra pages into ttm_tt

2022-03-01 Thread Ramalingam C
When a driver needs extra pages in ttm_tt, to facilidate such requirement, parameter called "extra_pages" is added for ttm_tt_init Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas --- drivers/gpu/drm/drm_gem_vram_helper.c | 2 +-

[PATCH v2 1/4] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-03-01 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W.

[PATCH v2 0/4] drm/i915/ttm: Evict and store of compressed object

2022-03-01 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the

[PATCH v6] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-03-01 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W.

  1   2   3   >