RE: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

[AMD Official Use Only] Hi Chandan, This issue we found on the Zork project which uses the kernel 5.4 on. So I just implemented it on kernel 5.4. For finding out which is 3250c, I referenced the function which is implemented from another function. Below is the part where I found it.

RE: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

Hi Ryan, Is this change applicable on a specific kernel version? On latest I see IP DISCOVERY based impl for CHIP_RAVEN. >[Why] >External displays take priority over internal display when there are fewer >display controllers than displays. > > [How] >The root cause is because of that number

Re: [PATCH v13 3/6] dt-bindings: display: Add Loongson display controller

On 2022/3/29 21:27, Rob Herring wrote: On Sun, Mar 27, 2022 at 9:29 PM Sui Jingfeng <15330273...@189.cn> wrote: Add DT bindings and simple usages for Loongson display controller found in LS7A1000 bridge chip and LS2k1000 SoC. Signed-off-by: Sui Jingfeng <15330273...@189.cn> ---

Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

On Tue, Mar 29, 2022 at 10:57 PM Ryan Lin wrote: > > [Why] > External displays take priority over internal display when there are fewer > display controllers than displays. > > [How] > The root cause is because of that number of the crtc is not correct. > The number of the crtc on the 3250c is 3,

[PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

[Why] External displays take priority over internal display when there are fewer display controllers than displays. [How] The root cause is because of that number of the crtc is not correct. The number of the crtc on the 3250c is 3, but on the 3500c is 4. On the source code, we can see that

Re: [PATCH 9/9] drm/msm: Add a way for userspace to allocate GPU iova

On Tue, Mar 29, 2022 at 4:42 PM Dmitry Baryshkov wrote: > > On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > > > From: Rob Clark > > > > The motivation at this point is mainly native userspace mesa driver in a > > VM guest. The one remaining synchronous "hotpath" is buffer allocation, > >

Re: [PATCH 9/9] drm/msm: Add a way for userspace to allocate GPU iova

On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > From: Rob Clark > > The motivation at this point is mainly native userspace mesa driver in a > VM guest. The one remaining synchronous "hotpath" is buffer allocation, > because guest needs to wait to know the bo's iova before it can start >

Re: [PATCH 9/9] drm/msm: Add a way for userspace to allocate GPU iova

On 3/30/22 02:00, Rob Clark wrote: > +static int msm_ioctl_gem_info_set_iova(struct drm_device *dev, > + struct drm_file *file, struct drm_gem_object *obj, > + uint64_t iova) > +{ > + struct msm_drm_private *priv = dev->dev_private; > + struct msm_file_private

Re: [PATCH 4/9] drm/msm/gem: Drop PAGE_SHIFT for address space mm

On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > From: Rob Clark > > Get rid of all the unnecessary conversion between address/size and page > offsets. It just confuses things. Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2

Re: [PATCH 1/9] drm/msm/gem: Move prototypes

On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > From: Rob Clark > > These belong more cleanly in the gem header. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH 9/9] drm/msm: Add a way for userspace to allocate GPU iova

From: Rob Clark The motivation at this point is mainly native userspace mesa driver in a VM guest. The one remaining synchronous "hotpath" is buffer allocation, because guest needs to wait to know the bo's iova before it can start emitting cmdstream/state that references the new bo. By

[PATCH 7/9] drm/msm/gem: Split vma lookup and pin

From: Rob Clark This way we only lookup vma once per object per submit, for both the submit and retire path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c| 60 +--- drivers/gpu/drm/msm/msm_gem.h| 9 +++--

[PATCH 8/9] drm/msm/gem: Add fenced vma unpin

From: Rob Clark With userspace allocated iova (next patch), we can have a race condition where userspace observes the fence completion and deletes the vma before retire_submit() gets around to unpinning the vma. To handle this, add a fenced unpin which drops the refcount but tracks the fence,

[PATCH 6/9] drm/msm/gem: Rework vma lookup and pin

From: Rob Clark Combines duplicate vma lookup in the get_and_pin path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH 5/9] drm/msm: Drop msm_gem_iova()

From: Rob Clark There was only a single user, which could just as easily stash the iova when pinning. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fb.c | 16 ++-- drivers/gpu/drm/msm/msm_gem.c | 16 drivers/gpu/drm/msm/msm_gem.h | 2 -- 3 files changed,

[PATCH 0/9] drm/msm: Userspace allocated GPU addresses

From: Rob Clark The first five paches are various cleanups and simplifications. The next two get rid of redundant vma lookups in the submit and retire paths. Following that, fenced vma lets us indicate a fence value following which the vma is no longer used, which is needed because otherwise

[PATCH 4/9] drm/msm/gem: Drop PAGE_SHIFT for address space mm

From: Rob Clark Get rid of all the unnecessary conversion between address/size and page offsets. It just confuses things. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 5 ++--- drivers/gpu/drm/msm/msm_gem.h | 4

[PATCH 3/9] drm/msm/gem: Split out inuse helper

From: Rob Clark Prep for a following patch. While we are at it, convert a few remaining WARN_ON()s to GEM_WARN_ON(). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem.h | 1 + drivers/gpu/drm/msm/msm_gem_vma.c | 15 ++- 3

[PATCH 2/9] drm/msm/gpu: Drop duplicate fence counter

From: Rob Clark The ring seqno counter duplicates the fence-context last_fence counter. They end up getting incremented in lock-step, on the same scheduler thread, but the split just makes things less obvious. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +-

[PATCH 1/9] drm/msm/gem: Move prototypes

From: Rob Clark These belong more cleanly in the gem header. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.h | 23 --- drivers/gpu/drm/msm/msm_gem.h | 22 ++ 2 files changed, 22 insertions(+), 23 deletions(-) diff --git

Re: [PATCH v9 03/22] dt-bindings: mediatek,dp_phy: Add Display Port PHY binding

On Mon, Mar 28, 2022 at 12:39:08AM +0200, Guillaume Ranquet wrote: > This phy controller is embedded in the Display Port Controller on mt8195 SoCs. Sorry, but I think you need to go back to what you had in v8. While yes, the phy and controller IP often do change independently, this h/w looks

[PATCH next] dma-buf/sync-file: do not allow zero size allocations

syzbot reported GPF in dma_fence_array_first(), which is caused by dereferencing ZERO_PTR in dma-buf internals. ZERO_PTR was generated in sync_file_merge(). This functuion tries to reduce allocation size, but does not check if it reducing to 0. Fix reported bug by validating `index` value before

Re: [syzbot] general protection fault in dma_fence_array_first

On 3/30/22 00:23, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:8515d05bf6bc Add linux-next specific files for 20220328 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1694e21b70 kernel config:

Re: [PATCH 3/3] drm/msm/dpu: drop VBIF indices

On 2/16/2022 7:45 PM, Dmitry Baryshkov wrote: We do not expect to have other VBIFs. Drop VBIF_n indices and always use VBIF_RT and VBIF_NRT. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 4 +--

Re: [PATCH 2/3] drm/msm/dpu: fix error handling around dpu_hw_vbif_init

On 2/16/2022 7:45 PM, Dmitry Baryshkov wrote: Using IS_ERR_OR_NULL() together with PTR_ERR() is a typical mistake. If the value is NULL, then the function will return 0 instead of a proper return code. Moreover dpu_hw_vbif_init() function can not return NULL. So, replace corresponding

Re: [PATCH 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

Assuming this series is newer and supersedes https://patchwork.freedesktop.org/patch/464353/?series=97307=2, please check below. On 2/16/2022 7:45 PM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx as an index in the array. This fixes an error in

[Bug 213983] WARNING: CPU: 3 PID: 520 at drivers/gpu/drm/ttm/ttm_bo.c:409 ttm_bo_release+0x7a/0x803 [ttm]

https://bugzilla.kernel.org/show_bug.cgi?id=213983 --- Comment #6 from Erhard F. (erhar...@mailbox.org) --- While this being true this one is the older bug (2021-08-06) and the duplicate is the later one (2021-10-04) in timeline. Also the bugs being linked you can have a look at the other bugs

[Bug 213983] WARNING: CPU: 3 PID: 520 at drivers/gpu/drm/ttm/ttm_bo.c:409 ttm_bo_release+0x7a/0x803 [ttm]

https://bugzilla.kernel.org/show_bug.cgi?id=213983 François Cami (f...@fcami.net) changed: What|Removed |Added CC||f...@fcami.net ---

Re: [PATCH] drm: msm: add null pointer check

Seems to be a duplicate of https://patchwork.freedesktop.org/patch/479378/ Thanks Abhinav On 3/29/2022 3:34 AM, cgel@gmail.com wrote: From: Lv Ruyi kzalloc is a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid

[drm-tip:drm-tip 4/8] drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:200:33: error: no member named 'tbo' in 'struct ttm_range_mgr_node'

tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: a8459e73b79b7c55405331f36fe8a48e1bad5c33 commit: 752f483905202334e91d2d5b87a3904df72aa147 [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: s390-randconfig-r006-20220327

[PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

"Pre-multiplied" is the default pixel blend mode for KMS/DRM, as documented in supported_modes of drm_plane_create_blend_mode_property(): https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_blend.c In this mode, both 'pixel alpha' and 'plane alpha' participate in the calculation,

[drm-tip:drm-tip 4/8] drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:200:45: error: 'struct ttm_range_mgr_node' has no member named 'tbo'

tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: a8459e73b79b7c55405331f36fe8a48e1bad5c33 commit: 752f483905202334e91d2d5b87a3904df72aa147 [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: parisc-randconfig-r003-20220327

Re: [PATCH 0/8] drm: Introduce display-helper library

For patches 2, 3, and 4: Reviewed-by: Lyude Paul On Tue, 2022-03-22 at 20:27 +0100, Thomas Zimmermann wrote: > Move DisplayPort, HDMI and various other display helpers from KMS > helpers into a new module. Adapt all drivers. > > This patch is part of an on-going effort to reduce the minimum

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

On 29/03/22 9:30 pm, Arunpravin Paneer Selvam wrote: > > > On 29/03/22 4:54 pm, Christian König wrote: >> Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: >>> [SNIP] > + pages_left = node->base.num_pages; > > i = 0; > - spin_lock(>lock); >

[PATCH 12/12] drm/edid: reduce magic when updating the EDID block checksum

The code modifying the EDID block should not need to do tricks to fix the checksum. We have a function for computing the checksum, use it. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 11/12] drm/edid: track invalid blocks in drm_do_get_edid()

Track invalid blocks instead of valid extensions to minimize impact on the happy day scenario, and hide the details in the separate function. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-)

[PATCH 07/12] drm/edid: split drm_edid_block_valid() to check and act parts

Add edid_block_check() that only checks the EDID block validity, without any actions. Turns out it's simple and crystal clear. Rewrite drm_edid_block_valid() around it, keeping all the functionality fairly closely the same, warts and all. Turns out it's incredibly complicated for a function you'd

[PATCH 09/12] drm/edid: simplify block check when filtering invalid blocks

There's no need to handle complicated scenarios or debug log when filtering blocks that have already been identified as invalid. Simplify by adding an edid_block_valid() helper that operates on const data and prints nothing. (Finally, here's the justification for the previously added separate

[PATCH 10/12] drm/edid: split out invalid block filtering to a separate function

It's such a special case there's no point in keeping it inline in the happy day scenario, confusing matters. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git

[PATCH 08/12] drm/edid: use a better variable name for EDID block read retries

Just i is a bit terse, clarify what it's about. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH 06/12] drm/edid: split out edid_header_fix()

Give a name to the EDID header fixup instead of having an inline memcpy. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH 04/12] drm/edid: make drm_edid_header_is_valid() accept void pointer

It will be useful to accept a struct edid *, but for compatibility with existing usage accept void *. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 +--- include/drm/drm_edid.h | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 05/12] drm/edid: clean up edid_is_zero()

Simplify, rename, take void pointer. No need for the drm_ prefix for internal helpers. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH 03/12] drm/edid: add edid_block_tag() helper to get the EDID extension tag

The extension tag at offset 0 is not present in struct edid, add a helper for it to reduce the need to use u8 *. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH 02/12] drm/edid: clean up EDID block checksum functions

Have two clear functions, one to compute the checksum over the EDID, and another to get the checksum from the EDID. Throw away the diff function. Ditch the drm_ prefix for static functions, and accept const void * to help transition to struct edid * usage. Cc: Ville Syrjälä Signed-off-by: Jani

[PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

Mixing u8 * and struct edid * is confusing, switch to the latter. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH 00/12] drm/edid: cleanup and refactoring around validity checks

Another day, another batch of EDID code refactoring. Mostly the goal was to simplify drm_do_get_edid(), but trying to extract a const function for checking a single block validity lead me down a rabbit hole... BR, Jani. Cc: Ville Syrjälä Cc: Emil Velikov Jani Nikula (12): drm/edid: use

DRM Master ignoring hotplug event during display switching (QT)

Hi all, I have implemented runtime display switching in the MIPI switch design where LVDS and HDMI bridges are selected with the help of runtime GPIO. Initial discussion on the same can be found here, https://www.spinics.net/lists/dri-devel/msg318524.html The implementation has been done by

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

Le mar., mars 29 2022 at 16:07:21 +0200, Daniel Vetter a écrit : On Tue, Mar 29, 2022 at 10:47:23AM +0100, Paul Cercueil wrote: Hi Daniel, Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter a écrit : > On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: > >

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

Hi Daniel, Le mar., mars 29 2022 at 16:10:44 +0200, Daniel Vetter a écrit : On Tue, Mar 29, 2022 at 10:11:14AM +0100, Paul Cercueil wrote: Hi Daniel, Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vetter a écrit : > On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: > >

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

Hi Liviu Gentle reminder ... Can you please help to clarify the last set of questions so that I can work on the next version? Thanks Abhinav On 3/25/2022 9:31 AM, Abhinav Kumar wrote: Hi Liviu On 3/25/2022 3:19 AM, Liviu Dudau wrote: On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav

Re: [RFC v4 2/8] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory

Hello, On Mon, Mar 28, 2022 at 03:59:41AM +, T.J. Mercier wrote: > The API/UAPI can be extended to set per-device/total allocation limits > in the future. This total thing kinda bothers me. Can you please provide some concrete examples of how this and per-device limits would be used?

Re: [PATCH] drm/imx: make static read-only array channel_offsets const

On So, 2022-01-23 at 22:34 +, Colin Ian King wrote: > The static array channel_offsets is read-only so it make sense to > make > it const. > > Signed-off-by: Colin Ian King > --- >  drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [RFC v4 4/8] dmabuf: heaps: export system_heap buffers with GPU cgroup charging

On Tue, Mar 29, 2022 at 10:42:20AM +0200, Daniel Vetter wrote: > Hm I just realized ... are the names in the groups abi? If yes then I > think we need to fix this before we merge anything. Yes. Thanks. -- tejun

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

On 03/28, Melissa Wen wrote: > On 03/28, Kazlauskas, Nicholas wrote: > > [AMD Official Use Only] > > > > > -Original Message- > > > From: Melissa Wen > > > Sent: Friday, March 25, 2022 4:45 PM > > > To: amd-...@lists.freedesktop.org; Wentland, Harry > > > ; Deucher, Alexander > > > ;

Re: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

On Mo, 2022-02-07 at 16:14 +0100, Mark Jonas wrote: > From: Leo Ruan > > This commit corrects the printing of the IPU clock error percentage > if > it is between -0.1% to -0.9%. For example, if the pixel clock > requested > is 27.2 MHz but only 27.0 MHz can be achieved the deviation is -0.8%. >

Re: [PATCH] drm/imx: dw_hdmi-imx: Fix bailout in error cases of probe

On Fr, 2022-01-28 at 17:19 +0800, Liu Ying wrote: > In dw_hdmi_imx_probe(), if error happens after dw_hdmi_probe() > returns > successfully, dw_hdmi_remove() should be called where necessary as > bailout. > > Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into > probe") > Cc:

Re: [PATCH] drm/imx: imx-ldb: Check for null pointer after calling kmemdup

On Mi, 2022-01-05 at 15:47 +0800, Jiasheng Jiang wrote: > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the return value of kmemdup() > and return error if fails. > > Fixes: dc80d7038883 ("drm/imx-ldb: Add support to

Re: [PATCH v2] drm/imx: Fix memory leak in imx_pd_connector_get_modes

On Sa, 2022-01-08 at 17:52 +0100, José Expósito wrote: > Avoid leaking the display mode variable if of_get_drm_display_mode > fails. > > Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code > from of_get_drm_display_mode()") > Addresses-Coverity-ID: 1443943 ("Resource leak") >

Re: [PATCH v2] panel-edp: drm/panel-edp: Add AUO B133UAN01

Hi, On Thu, Mar 24, 2022 at 1:51 PM Doug Anderson wrote: > > Hi, > > On Thu, Mar 24, 2022 at 1:48 PM Matthias Kaehlcke wrote: > > > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v2: > > - autodetect and configure the

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

I don't know what iris does, but I would guess that the same problems as with AMD GPUs apply, making GPUs resets very fragile. Marek On Tue., Mar. 29, 2022, 08:14 Christian König, wrote: > My main question is what does the iris driver better than radeonsi when > the client doesn't support the

Re: [PATCH 20/23] dma-buf: add DMA_RESV_USAGE_BOOKKEEP v2

On Mon, Mar 21, 2022 at 02:58:53PM +0100, Christian König wrote: > Add an usage for submissions independent of implicit sync but still > interesting for memory management. This fails to mention that you're hding the amdgpu vm optimization in here. I'd split that out, but it really needs to be in

Re: [PATCH 23/23] drm/ttm: remove bo->moving

On Mon, Mar 21, 2022 at 02:58:56PM +0100, Christian König wrote: > This is now handled by the DMA-buf framework in the dma_resv obj. > > Signed-off-by: Christian König > --- > .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 7 ++-- >

Re: [PATCH 22/23] drm/i915: drop bo->moving dependency

On Mon, Mar 21, 2022 at 02:58:55PM +0100, Christian König wrote: > That should now be handled by the common dma_resv framework. > > Signed-off-by: Christian König > Cc: intel-...@lists.freedesktop.org Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 29

Re: [PATCH 21/23] dma-buf: wait for map to complete for static attachments

On Mon, Mar 21, 2022 at 02:58:54PM +0100, Christian König wrote: > We have previously done that in the individual drivers but it is > more defensive to move that into the common code. > > Dynamic attachments should wait for map operations to complete by themselves. > > Signed-off-by: Christian

Re: [PATCH 19/23] dma-buf: add DMA_RESV_USAGE_KERNEL v2

On Mon, Mar 21, 2022 at 02:58:52PM +0100, Christian König wrote: > Add an usage for kernel submissions. Waiting for those > are mandatory for dynamic DMA-bufs. > > v2: use "must" in documentation, fix whitespaces > > Signed-off-by: Christian König I think it's not super great that you smash

Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells

On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote: > On 28-03-22, 13:21, Rob Herring wrote: > > On Mon, Mar 28, 2022 at 12:18 PM Krzysztof Kozlowski > > wrote: > > > > > > On 28/03/2022 19:16, Vinod Koul wrote: > > > > On 28-03-22, 19:43, Dmitry Baryshkov wrote: > > > >> On Mon, 28 Mar

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

On 29/03/22 4:54 pm, Christian König wrote: > Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: >> [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(>lock); while (pages_left) { - uint32_t alignment =

Re: [PATCH 18/23] drm/amdgpu: remove dma_resv workaround

On Mon, Mar 21, 2022 at 02:58:51PM +0100, Christian König wrote: > We can now add multiple writers to the dma_resv object. > > Also enable the check for not adding containers in dma_resv.c again. > > Signed-off-by: Christian König > Cc: amd-...@lists.freedesktop.org It's a bit much magic, but

Re: [PATCH 17/23] dma-buf: specify usage while adding fences to dma_resv obj v5

On Mon, Mar 21, 2022 at 02:58:50PM +0100, Christian König wrote: > Instead of distingting between shared and exclusive fences specify > the fence usage while adding fences. > > Rework all drivers to use this interface instead and deprecate the old one. > > v2: some kerneldoc comments suggested

Re: [PATCH 16/23] dma-buf: add enum dma_resv_usage v3

On Mon, Mar 21, 2022 at 02:58:49PM +0100, Christian König wrote: > This change adds the dma_resv_usage enum and allows us to specify why a > dma_resv object is queried for its containing fences. > > Additional to that a dma_resv_usage_rw() helper function is added to aid > retrieving the fences

Re: [PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

On 2022-03-29 10:33, Harry Wentland wrote: > > > On 2022-03-24 19:10, Ryan Lin wrote: >> Disable ABM feature when the system is running on AC mode to get >> the more perfect contrast of the display. >> >> Signed-off-by: Ryan Lin >> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c |

Re: amdgpu link problem (was Re: [git pull] drm for 5.18-rc1)

On Mon, Mar 28, 2022 at 9:54 PM Linus Torvalds wrote: > > I didn't notice this until now, probably because everything still > _works_, but I get a new big warning splat at bootup on my main > workstation these days as of the merge window changes. > > The full warning is attached, but it's

Re: [PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

On 2022-03-24 19:10, Ryan Lin wrote: > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c|

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

On Tue, Mar 29, 2022 at 10:11:14AM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le mar., mars 29 2022 at 10:33:32 +0200, Daniel Vetter a > écrit : > > On Tue, Feb 15, 2022 at 05:43:35PM +, Paul Cercueil wrote: > > > Hi Jonathan, > > > > > > Le dim., févr. 13 2022 at 18:46:16 +,

Re: DSI Bridge switching

On Thu, Mar 10, 2022 at 4:05 PM Maxime Ripard wrote: > > On Wed, Mar 09, 2022 at 06:45:10PM -0600, Adam Ford wrote: > > On Wed, Mar 9, 2022 at 1:11 PM Jagan Teki > > wrote: > > > > > > or a Hi All, > > > > > > On Thu, Oct 14, 2021 at 6:45 PM Jagan Teki > > > wrote: > > > > > > > > Hi

Re: [PATCH v2 12/12] Documentation: iio: Document high-speed DMABUF based API

On Tue, Mar 29, 2022 at 10:47:23AM +0100, Paul Cercueil wrote: > Hi Daniel, > > Le mar., mars 29 2022 at 10:54:43 +0200, Daniel Vetter a > écrit : > > On Mon, Feb 07, 2022 at 01:01:40PM +, Paul Cercueil wrote: > > > Document the new DMABUF based API. > > > > > > v2: - Explicitly state

Re: drm/amdgpu: Disable ABM when AC mode

On Tue, Mar 29, 2022 at 4:56 AM Ryan Lin wrote: > > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > v2: remove "UPSTREAM" from the subject. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4

Re: Allow ttm_buffer_object without resource

On Tue, Mar 29, 2022 at 01:02:32PM +0200, Christian König wrote: > Hi guys, > > this patch set cleans up the handling of TTM buffer objects quite a bit > by allowing to create them without allocating a ttm_resource as well. > > That's not only cleaner in general, but also a necessary

Re: [PATCH v13 3/6] dt-bindings: display: Add Loongson display controller

On Sun, Mar 27, 2022 at 9:29 PM Sui Jingfeng <15330273...@189.cn> wrote: > > Add DT bindings and simple usages for Loongson display controller > found in LS7A1000 bridge chip and LS2k1000 SoC. > > Signed-off-by: Sui Jingfeng <15330273...@189.cn> > --- >

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

On Tue, Mar 29, 2022 at 10:02:11AM +0800, Sui Jingfeng wrote: > > On 2022/3/28 22:04, Rob Herring wrote: > > On Sat, Mar 26, 2022 at 06:04:46PM +0800, Sui Jingfeng wrote: > > > On 2022/3/24 21:26, Rob Herring wrote: > > > > On Thu, Mar 24, 2022 at 09:48:19AM +0800, Sui Jingfeng wrote: > > > > >

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

On 29.03.2022 00:37, Ramalingam C wrote: > Move the static calculations out of the loops for copy and clear. > > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - > 1 file changed, 21 insertions(+), 23

Re: [PATCH v9 01/23] clk: rk3568: Mark hclk_vo as critical

On 3/28/22 18:10, Sascha Hauer wrote: > Whenever pclk_vo is enabled hclk_vo must be enabled as well. This is > described in the Reference Manual as: > > | 2.8.6 NIU Clock gating reliance > | > | A part of niu clocks have a dependence on another niu clock in order to > | sharing the internal bus.

Re: [PATCH] drm/dp_mst: Lower down debug info level when receive NAK

On 2022-03-29 04:05, Wayne Lin wrote: > [Why] > It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. > Downstream device might reply NAK with the reason and source should > react accordingly. > > e.g. > 1. When downstream device can't handle corresponding message in time, > it

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

My main question is what does the iris driver better than radeonsi when the client doesn't support the robustness extension? From Daniels description it sounds like they have at least a partial recovery mechanism in place. Apart from that I completely agree to what you said below.

Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional

Hi Sascha: On 3/28/22 23:11, Sascha Hauer wrote: With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/Kconfig| 8 drivers/gpu/drm/rockchip/Makefile | 3 ++-

Re: [PATCH] drm/v3d: Use kvcalloc

On 28/03/22 5:55 pm, Melissa Wen wrote: On 03/12, Harshit Mogalapalli wrote: kvcalloc is same as kvmalloc_array + __GFP_ZERO. Signed-off-by: Harshit Mogalapalli --- drivers/gpu/drm/v3d/v3d_gem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2] drm: add a check to verify the size alignment

Am 29.03.22 um 13:28 schrieb Arunpravin Paneer Selvam: On 23/03/22 1:15 pm, Christian König wrote: Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: Add a simple check to reject any size not aligned to the min_page_size. handle instances when size is not aligned with the min_page_size.

Re: [PATCH v2] drm: add a check to verify the size alignment

On Tue, 29 Mar 2022 at 12:17, Arunpravin Paneer Selvam wrote: > > > > On 23/03/22 1:15 pm, Christian König wrote: > > Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: > >> Add a simple check to reject any size not aligned to the > >> min_page_size. > >> > >> handle instances when size is

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

Am 29.03.22 um 13:19 schrieb Arunpravin Paneer Selvam: [SNIP] + pages_left = node->base.num_pages; i = 0; - spin_lock(>lock); while (pages_left) { - uint32_t alignment = tbo->page_alignment; + if (tbo->page_alignment) +

Re: [PATCH v2] drm: add a check to verify the size alignment

On 23/03/22 1:15 pm, Christian König wrote: > Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: >> Add a simple check to reject any size not aligned to the >> min_page_size. >> >> handle instances when size is not aligned with the min_page_size. >> Unigine Heaven has allocation requests

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

> -Original Message- > From: amd-gfx On Behalf Of Christian > König > Sent: Wednesday, March 23, 2022 1:07 PM > To: Paneer Selvam, Arunpravin ; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Deucher, Alexander ;

[PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting

That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[PATCH 07/11] drm/amdgpu: audit bo->resource usage

Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 09/11] drm/ttm: audit bo->resource usage

Allow BOs to exist without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b7e259245f82..bd001fdde9fb 100644 ---

[PATCH 08/11] drm/nouveau: audit bo->resource usage

Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index

[PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation

That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König ---

[PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

It's the only driver using this. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 9 + drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_object.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index

  1   2   >