Re: [PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Randy Dunlap
On 5/23/22 15:23, Dmitry Baryshkov wrote: > Hi, > > On Mon, 23 May 2022 at 23:43, Randy Dunlap wrote: >> >> Fix a Kconfig warning for DRM_MSM by making it depend on OF, >> since 'select' does not follow any dependency chaings. >> >> WARNING: unmet direct dependencies detected for

Re: [PATCH v2 10/11] drm/msm: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Abhinav Kumar
On 5/23/2022 6:05 PM, Marek Vasut wrote: Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Reviewed-by: Dmitry Baryshkov Signed-off-by: Marek Vasut Reviewed-by: Abhinav Kumar Cc: Abhinav Kumar Cc: Andrzej Hajda Cc: Dmitry

[PATCH v2 11/11] drm/bridge: rcar: Convert to drm_of_get_data_lanes_count_ep

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 08/11] drm/bridge: ti-sn65dsi83: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 07/11] drm/bridge: tc358775: Convert to drm_of_get_data_lanes_count_ep

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 10/11] drm/msm: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Reviewed-by: Dmitry Baryshkov Signed-off-by: Marek Vasut Cc: Abhinav Kumar Cc: Andrzej Hajda Cc: Dmitry Baryshkov Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Rob Clark

[PATCH v2 09/11] drm/bridge: ti-sn65dsi86: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 05/11] drm/bridge: lt9211: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 03/11] drm/bridge: icn6211: Convert to drm_of_get_data_lanes_count_ep

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Jagan Teki Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org

[PATCH v2 06/11] drm/bridge: tc358767: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- V2: -

[PATCH v2 04/11] drm/bridge: lt8912: Convert to drm_of_get_data_lanes_count_ep

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To:

[PATCH v2 02/11] drm/bridge: anx7625: Convert to drm_of_get_data_lanes_count

2022-05-23 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Andrzej Hajda Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Xin Ji To: dri-devel@lists.freedesktop.org ---

[PATCH v2 01/11] drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep

2022-05-23 Thread Marek Vasut
Add helper function to count and sanitize DT "data-lanes" property and return either error or the data-lanes count. This is useful for both DSI and (e)DP "data-lanes" property. The later version of the function is an extra wrapper which handles the endpoint look up by regs, that's what majority of

Re: [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

2022-05-23 Thread Doug Anderson
Hi, On Fri, May 20, 2022 at 5:01 PM Doug Anderson wrote: > > Hi, > > On Mon, May 16, 2022 at 3:28 AM Thomas Zimmermann wrote: > > > > Hi Douglas, > > > > I understand that you're trying to tell userspace that the modelist has > > been made up, but it's not something that should be done via

[linux-next:master] BUILD REGRESSION cc63e8e92cb872081f249ea16e6c460642f3e4fb

2022-05-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: cc63e8e92cb872081f249ea16e6c460642f3e4fb Add linux-next specific files for 20220523 Error/Warning reports: https://lore.kernel.org/linux-mm/202204291924.vtgzmeri-...@intel.com https

Re: [PATCH 0/9] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
Hi, On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > As stated in [1] I promised to tackle and send this series. > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups

Re: [PATCH 09/14] ACPI: video: Make backlight class device registration a separate step

2022-05-23 Thread Daniel Dadap
On 5/20/22 16:41, Daniel Dadap wrote: On 5/17/22 10:23, Hans de Goede wrote: On x86/ACPI boards the acpi_video driver will usually initializing before the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 to show up and then the kms driver registers its own native

Re: [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-23 Thread Rob Clark
On Mon, May 23, 2022 at 7:45 AM Tvrtko Ursulin wrote: > > > Hi Rob, > > On 28/07/2021 02:06, Rob Clark wrote: > > From: Rob Clark > > > > The drm/scheduler provides additional prioritization on top of that > > provided by however many number of ringbuffers (each with their own > > priority

Re: [PATCH 9/9] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:39, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by:

Re: [PATCH 8/9] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by:

Re: [PATCH 7/9] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by:

Re: [PATCH 6/9] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > The clock names formatted into the hw_clk's init structure are only used > for the duration of the registration function where they are kstrdup'ed, > making it unnecessary to keep the allocations alive for the duration of > the device

Re: [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 01:44, Dmitry Baryshkov wrote: > > On Tue, 24 May 2022 at 00:38, Marijn Suijten > wrote: > > > > parent_hw pointers are easier to manage and cheaper to use than > > repeatedly formatting the parent name and subsequently leaving the clk > > framework to perform lookups

Re: [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. Can you please add a followup patch (or a preface

Re: [PATCH 4/9] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten > --- >

Re: [PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Dmitry Baryshkov
Hi, On Mon, 23 May 2022 at 23:43, Randy Dunlap wrote: > > Fix a Kconfig warning for DRM_MSM by making it depend on OF, > since 'select' does not follow any dependency chaings. > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS I think it was agreed that DRM_DP_AUX_BUS should

Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

2022-05-23 Thread Brian Norris
On Thu, Mar 10, 2022 at 3:50 PM Brian Norris wrote: > On Mon, Feb 28, 2022 at 12:25 PM Brian Norris > wrote: > Ping for review? Sean, perhaps? (You already reviewed this on the > Chromium tracker.) Ping

Re: [PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-23 Thread Marijn Suijten
On 2022-05-03 01:02:42, Dmitry Baryshkov wrote: > On 03/05/2022 00:42, Marijn Suijten wrote: > > On 2022-05-02 13:47:51, Stephen Boyd wrote: > >> Quoting Dmitry Baryshkov (2022-05-01 12:56:20) > >>> Remove dividers that are not recommended for DSI DPHY mode when setting > >> > >> Is "DPHY"

[PATCH 4/9] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 52 +- 1

[PATCH 6/9] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-05-23 Thread Marijn Suijten
The clock names formatted into the hw_clk's init structure are only used for the duration of the registration function where they are kstrdup'ed, making it unnecessary to keep the allocations alive for the duration of the device (through devm). Just like the other DSI PHY PLL clock trees, use a

[PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- .../gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c| 18 +++--- 1

[PATCH 8/9] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 92 ++ 1

[PATCH 9/9] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 92 +++ 1

[PATCH 7/9] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 36 ++ 1

[PATCH 3/9] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-05-23 Thread Marijn Suijten
Add the devres and non-devres variant of clk_hw_register_fixed_factor_parent_hw() for registering a fixed factor clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- drivers/clk/clk-fixed-factor.c | 57 --

[PATCH 2/9] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

2022-05-23 Thread Marijn Suijten
Add the devres variant of clk_hw_register_mux_hws() for registering a mux clock with clk_hw parent pointers instead of parent names. Signed-off-by: Marijn Suijten --- include/linux/clk-provider.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/clk-provider.h

[PATCH 0/9] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
As stated in [1] I promised to tackle and send this series. parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. This series starts out by adding extra constructors

[PATCH 1/9] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw()

2022-05-23 Thread Marijn Suijten
Add the devres variant of clk_hw_register_divider_parent_hw() for registering a divider clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- include/linux/clk-provider.h | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCH] drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Matt Roper
On Mon, May 23, 2022 at 01:21:16PM +0530, Balasubramani Vivekanandan wrote: > ADL-N being a subplatform of ADL-P, it lacks support for hwconfig > table. Explicit check added to skip ADL-N. > > Signed-off-by: Balasubramani Vivekanandan > Reviewed-by: Matt Roper > --- >

[PATCH v5 5/6] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-05-23 Thread Matt Roper
As with EU masks, it's easier to store subslice/DSS masks internally in a format that's more natural for the driver to work with, and then only covert into the u8[] uapi form when the query ioctl is invoked. Since the hardware design changed significantly with Xe_HP, we'll use a union to choose

[PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Randy Dunlap
Fix a Kconfig warning for DRM_MSM by making it depend on OF, since 'select' does not follow any dependency chaings. WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && OF [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM

Re: [PATCH] drm/amdkfd: fix typo in comment

2022-05-23 Thread Alex Deucher
Applied. Thanks! Alex On Sat, May 21, 2022 at 7:12 AM Julia Lawall wrote: > > Spelling mistake (triple letters) in comment. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |2 +- > 1 file changed, 1

Re: [PATCH] drm/amdgpu/gfx: fix typos in comments

2022-05-23 Thread Alex Deucher
Applied. Thanks! Alex On Sat, May 21, 2022 at 7:12 AM Julia Lawall wrote: > > Spelling mistakes (triple letters) in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c |2 +- >

Re: [PATCH] drm/nouveau/tegra: remove needless NULL check

2022-05-23 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a moment On Thu, 2022-05-19 at 15:29 +0800, Guo Zhengkui wrote: > There has already been NULL check in clk_prepare_enable() and > clk_disable_unprepare(), so remove needless NULL check before > calling them. > > Signed-off-by: Guo

Re: [Nouveau] nouveau lockdep deadlock report with 5.18-rc6

2022-05-23 Thread Lyude Paul
On Fri, 2022-05-20 at 13:46 +0200, Computer Enthusiastic wrote: > Hello, > > Il giorno mer 18 mag 2022 alle ore 19:42 Lyude Paul > ha scritto: > > > > On Tue, 2022-05-17 at 13:10 +0200, Hans de Goede wrote: > > > Hi All, > > > I just noticed the below lockdep possible deadlock report with a

Re: [PATCH] drm/nouveau/mmu: fix typo in comment

2022-05-23 Thread Lyude Paul
Reviewed-by: Lyude Paul Will fix that double space after the punctuation while I'm at it as well, and will push to the appropriate branch in a little bit. Thanks! On Sat, 2022-05-21 at 13:11 +0200, Julia Lawall wrote: > Spelling mistake (triple letters) in comment. > Detected with the help of

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-05-23 Thread Niranjana Vishwanathapura
On Thu, May 19, 2022 at 04:07:30PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Ensure proper kernel-doc formatting with cross references. Also add new uapi and documentation as per review

Re: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-05-23 Thread Niranjana Vishwanathapura
On Mon, May 23, 2022 at 12:05:05PM -0700, Niranjana Vishwanathapura wrote: On Thu, May 19, 2022 at 03:52:01PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Add more

Re: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-05-23 Thread Niranjana Vishwanathapura
On Thu, May 19, 2022 at 03:52:01PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Add more documentation and format as per review comments from Daniel. Signed-off-by:

Re: [PATCH v3] drm/nouveau: clear output poll workers before nouveau_fbcon_destroy()

2022-05-23 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a bit, thanks! On Mon, 2022-05-23 at 13:35 +0200, Mark Menzynski wrote: > Resources needed for output poll workers are destroyed in > nouveau_fbcon_fini() before output poll workers are cleared in > nouveau_display_fini(). This

Re: [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

2022-05-23 Thread Doug Anderson
Hi, On Sat, May 21, 2022 at 2:17 AM Maxime Ripard wrote: > > Hi, > > On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote: > > This adds a devm managed version of drm_bridge_add(). Like other > > "devm" function listed in drm_bridge.h, this function takes an > > explicit "dev" to use

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-23 Thread Rob Herring
On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote: > On 19/05/2022 23:14, Rob Herring wrote: > > Now that the schema tools can extract type information for all > > properties (in order to decode dtb files), finding properties missing > > any type definition is fairly trivial

Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m

2022-05-23 Thread Doug Anderson
Hi, On Mon, May 23, 2022 at 1:58 AM gaochao wrote: > > If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m, > bulding fails: > > drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function > `atana33xc20_probe': > panel-samsung-atna33xc20.c:(.text+0x744): undefined

Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1

2022-05-23 Thread Icenowy Zheng
在 2022-05-22星期日的 10:36 +0200,Jernej Škrabec写道: > Hi! > > Dne sobota, 21. maj 2022 ob 15:34:43 CEST je Genfu Pan napisal(a): > > Accrording the SDK from Allwinner, the scanline value of yuv and > > rgb for > > V3s are both 1024. > > s/scanline value/scanline length/ > > Which SDK? All SDKs that

Re: [PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Robert Foss
On Mon, 23 May 2022 at 18:15, Robert Foss wrote: > > This reverts commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1. > > This patch depends on the patches just aplied to the media tree, and will > not build without them, which leaves drm-misc-next in a broken state. > Let's revert the two latter

[PATCH v2 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property"

2022-05-23 Thread Robert Foss
This reverts commit 7328736d270aa4fa6fcd033ade02acc2874a2db5. This patch depends on the patches just aplied to the media tree, and will not build without them, which leaves drm-misc-next in a broken state. Let's revert the two latter patches until rc1 has been branched, and rc1 has been

[PATCH v2 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Robert Foss
This reverts commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1. This patch depends on the patches just aplied to the media tree, and will not build without them, which leaves drm-misc-next in a broken state. Let's revert the two latter patches until rc1 has been branched, and rc1 has been

Re: [PATCH v1 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Robert Foss
On Mon, 23 May 2022 at 14:54, Robert Foss wrote: > > These two patches need to be reverted since they were part (3/4 & 4/4) > of a series, that was partially (1/4 + 2/4) on the linux-media tree. > These two patches depend on the patches in the media tree, and will > not build without them, which

Re: [PATCH v1 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Daniel Vetter
On Mon, 23 May 2022 at 14:54, Robert Foss wrote: > These two patches need to be reverted since they were part (3/4 & 4/4) > of a series, that was partially (1/4 + 2/4) on the linux-media tree. > These two patches depend on the patches in the media tree, and will > not build without them, which

Re: [PATCH 3/4] drm/i915: allow volatile buffers to use ttm pool allocator

2022-05-23 Thread Robert Beckett
On 11/05/2022 13:42, Thomas Hellström wrote: Hi, Bob, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: internal buffers should be shmem backed. if a volatile buffer is requested, allow ttm to use the pool allocator to provide volatile pages as backing Signed-off-by: Robert Beckett

Re: [PATCH 1/4] drm/i915: add gen6 ppgtt dummy creation function

2022-05-23 Thread Robert Beckett
On 11/05/2022 11:13, Thomas Hellström wrote: Hi, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: Internal gem objects will soon just be volatile system memory region objects. To enable this, create a separate dummy object creation function for gen6 ppgtt It's not clear from the

Re: [PATCH 4/4] drm/i915: internal buffers use ttm backend

2022-05-23 Thread Robert Beckett
On 11/05/2022 15:14, Thomas Hellström wrote: On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: refactor internal buffer backend to allocate volatile pages via ttm pool allocator Signed-off-by: Robert Beckett ---  drivers/gpu/drm/i915/gem/i915_gem_internal.c | 264 -

Re: [PATCH 03/11] drm/bridge: icn6211: Convert to drm_of_get_data_lanes_ep

2022-05-23 Thread Andrzej Hajda
On 19.05.2022 13:26, Marek Vasut wrote: Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Jagan Teki Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To:

Re: [PATCH 02/11] drm/bridge: anx7625: Convert to drm_of_get_data_lanes

2022-05-23 Thread Andrzej Hajda
On 19.05.2022 13:26, Marek Vasut wrote: Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Xin Ji To:

Re: [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-23 Thread Tvrtko Ursulin
Hi Rob, On 28/07/2021 02:06, Rob Clark wrote: From: Rob Clark The drm/scheduler provides additional prioritization on top of that provided by however many number of ringbuffers (each with their own priority level) is supported on a given generation. Expose the additional levels of priority

Re: [PATCH 01/11] drm: of: Add drm_of_get_data_lanes and drm_of_get_data_lanes_ep

2022-05-23 Thread Andrzej Hajda
On 19.05.2022 13:26, Marek Vasut wrote: Add helper function to count and sanitize DT "data-lanes" property and return either error or the data-lanes count. This is useful for both DSI and (e)DP "data-lanes" property. The later version of the function is an extra wrapper which handles the

Re: [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T

2022-05-23 Thread Javier Martinez Canillas
Hello Geert, On 5/20/22 14:02, Geert Uytterhoeven wrote: > Hi Javier, > > CC spi > > On Fri, May 20, 2022 at 11:16 AM Javier Martinez Canillas > wrote: >> The SPI core always reports a "MODALIAS=spi:", even if the device was >> registered via OF. This means that the st7735r.ko module won't

Re: [PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

2022-05-23 Thread Marek Vasut
On 5/23/22 15:20, Jonathan Liu wrote: Hi Marek, On Mon, 23 May 2022 at 23:15, Marek Vasut wrote: On 5/23/22 15:01, Jonathan Liu wrote: The code from [1] sets SYS_CTRL_1 to different values depending on the desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the positive edge

Re: [PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

2022-05-23 Thread Jonathan Liu
Hi Marek, On Mon, 23 May 2022 at 23:15, Marek Vasut wrote: > > On 5/23/22 15:01, Jonathan Liu wrote: > > The code from [1] sets SYS_CTRL_1 to different values depending on the > > desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the > > positive edge of the clock with the

Re: [PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

2022-05-23 Thread Marek Vasut
On 5/23/22 15:01, Jonathan Liu wrote: The code from [1] sets SYS_CTRL_1 to different values depending on the desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the positive edge of the clock with the pixel data while other values delay the clock by a fraction of the clock

[PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

2022-05-23 Thread Jonathan Liu
The code from [1] sets SYS_CTRL_1 to different values depending on the desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the positive edge of the clock with the pixel data while other values delay the clock by a fraction of the clock period. A clock phase of 1/2 aligns the

Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

2022-05-23 Thread Dmitry Baryshkov
On 23/05/2022 15:54, Linus Walleij wrote: On Mon, May 23, 2022 at 2:46 PM Linus Walleij wrote: On Fri, May 6, 2022 at 2:33 PM YueHaibing wrote: While CONFIG_OF is n but COMPILE_TEST is y, we got this: WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]:

Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

2022-05-23 Thread Linus Walleij
On Mon, May 23, 2022 at 2:46 PM Linus Walleij wrote: > On Fri, May 6, 2022 at 2:33 PM YueHaibing wrote: > > > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF

Re: [PATCH v1 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Robert Foss
These two patches need to be reverted since they were part (3/4 & 4/4) of a series, that was partially (1/4 + 2/4) on the linux-media tree. These two patches depend on the patches in the media tree, and will not build without them, which leaves linux-drm-misc-next in a broken state. Let's revert

Re: [PATCH v1 2/2] Revert "dt-bindings:drm/bridge:anx7625: add port@0 property"

2022-05-23 Thread Robert Foss
On Mon, 23 May 2022 at 10:46, Robert Foss wrote: > > This reverts commit 7328736d270aa4fa6fcd033ade02acc2874a2db5. > --- > .../display/bridge/analogix,anx7625.yaml | 19 +-- > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git >

Re: [PATCH v1 1/2] Revert "drm/bridge: anx7625: Use DPI bus type"

2022-05-23 Thread Robert Foss
On Mon, 23 May 2022 at 10:46, Robert Foss wrote: > > This reverts commit a77c2af0994e24ee36c7ffb6dc852770bdf06fb1. > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c >

Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

2022-05-23 Thread Linus Walleij
On Fri, May 6, 2022 at 2:33 PM YueHaibing wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] &&

Re: [PATCH v2 11/13] mm: handling Non-LRU pages returned by vm_normal_pages

2022-05-23 Thread Alistair Popple
Technically I think this patch should be earlier in the series. As I understand it patch 1 allows DEVICE_COHERENT pages to be inserted in the page tables and therefore makes it possible for page table walkers to see non-LRU pages. Some more comments below: Alex Sierra writes: > With

Re: [PATCH v10 01/21] dt-bindings: mediatek, dpi: Add DPINTF compatible

2022-05-23 Thread Rob Herring
On Mon, 23 May 2022 12:47:34 +0200, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > DPINTF is similar to DPI but does not have the exact same feature set > or register layouts. > > DPINTF is the sink of the display pipeline that is connected to the > DisplayPort controller and

Re: How should "max bpc" KMS property work?

2022-05-23 Thread Sebastian Wick
On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: > > On Fri, 20 May 2022 17:20:50 +0200 > Hans de Goede wrote: > > > I got pointed to this thread by Jonas Ådahl while asking some questions > > the "max bpc" property related to: > > > >

[PATCH v3] drm/nouveau: clear output poll workers before nouveau_fbcon_destroy()

2022-05-23 Thread Mark Menzynski
Resources needed for output poll workers are destroyed in nouveau_fbcon_fini() before output poll workers are cleared in nouveau_display_fini(). This means there is a time between fbcon_fini() and display_fini(), where if output poll happens, it crashes. This patch introduces another output poll

Re: [PATCH] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

2022-05-23 Thread Marek Vasut
On 5/23/22 04:38, Jonathan Liu wrote: The code from [1] sets SYS_CTRL_1 to different values depending on the desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the positive edge of the clock with the pixel data while other values delay the clock by a fraction of the clock

Re: [PATCH] udmabuf: Set the DMA mask for the udmabuf device

2022-05-23 Thread Dan Carpenter
Hi Vivek, url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/udmabuf-Set-the-DMA-mask-for-the-udmabuf-device/20220520-144218 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-m001

Re: [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc

2022-05-23 Thread Matthias Brugger
On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > Signed-off-by: Guillaume Ranquet > We need a commit message here. > --- >  include/drm/drm_edid.h | 12 +--- >  1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h

Re: [PATCH] drm/bridge: ti-sn65dsi83: Handle dsi_lanes == 0 as invalid

2022-05-23 Thread Marek Vasut
On 5/23/22 12:23, Robert Foss wrote: On Mon, 23 May 2022 at 11:58, Marek Vasut wrote: On 5/23/22 11:40, Robert Foss wrote: On Thu, 19 May 2022 at 09:57, Lucas Stach wrote: Am Donnerstag, dem 19.05.2022 um 01:38 +0200 schrieb Marek Vasut: Handle empty data-lanes = < >; property, which

[PATCH v10 21/21] drm/mediatek: DP audio support for mt8195

2022-05-23 Thread Guillaume Ranquet
This patch adds audio support to the DP driver for mt8195 with up to 8 channels. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 784 +- 1 file changed, 777 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c

[PATCH v10 20/21] drm/mediatek: add hpd debounce

2022-05-23 Thread Guillaume Ranquet
From: Jitao Shi >From the DP spec 1.4a chapter 3.3, upstream devices should implement HPD signal de-bouncing on an external connection. A period of 100ms should be used to detect an HPD connect event. To cover these cases, HPD de-bounce should be implemented only after HPD low has been detected

[PATCH v10 19/21] drm/mediatek: Add mt8195 External DisplayPort support

2022-05-23 Thread Guillaume Ranquet
This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 104 +++--- 1 file changed, 81 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c

[PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-05-23 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver creates a child device for the phy. The child device will never exist without the

[PATCH v10 17/21] phy: phy-mtk-dp: Add driver for DP phy

2022-05-23 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the mt8195. The phy is integrated into the DisplayPort controller and will be created by the mtk-dp driver. This driver expects a struct regmap to be able to work on

[PATCH v10 16/21] drm/meditek: dpi: Add matrix_sel helper

2022-05-23 Thread Guillaume Ranquet
Add a mtk_dpi_matrix_sel() helper to update the DPI_MATRIX_SET register depending on the color format. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 3 +++ 2 files changed, 24 insertions(+)

[PATCH v10 15/21] drm/mediatek: dpi: Only enable dpi after the bridge is enabled

2022-05-23 Thread Guillaume Ranquet
Enabling the dpi too early causes glitches on screen. Move the call to mtk_dpi_enable() at the end of the bridge_enable callback to ensure everything is setup properly before enabling dpi. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1

[PATCH v10 14/21] drm/mediatek: dpi: Add dpintf support

2022-05-23 Thread Guillaume Ranquet
dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some features/functional components are not available for dpintf which are now excluded from

[PATCH v10 13/21] drm/mediatek: dpi: move the csc_enable bit to SoC config

2022-05-23 Thread Guillaume Ranquet
Add flexibility by moving the csc_enable bit to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v10 12/21] drm/mediatek: dpi: move the yuv422_en_bit to SoC config

2022-05-23 Thread Guillaume Ranquet
Add flexibility by moving the yuv422 en bit to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config

2022-05-23 Thread Guillaume Ranquet
Add flexibility by moving the swap shift value to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: Rex-BC Chen Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v10 10/21] drm/mediatek: dpi: move hvsize_mask to SoC config

2022-05-23 Thread Guillaume Ranquet
Add flexibility by moving the hvsize mask to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v10 09/21] drm/mediatek: dpi: move dimension mask to SoC config

2022-05-23 Thread Guillaume Ranquet
Add flexibility by moving the dimension mask to the SoC config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff

[PATCH v10 08/21] drm/mediatek: dpi: implement a swap_input toggle in SoC config

2022-05-23 Thread Guillaume Ranquet
Adds a bit of flexibility to support SoCs without swap_input support Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

[PATCH v10 07/21] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config

2022-05-23 Thread Guillaume Ranquet
Adds a bit of flexibility to support SoCs without CK/DE pol support Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen --- drivers/gpu/drm/mediatek/mtk_dpi.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff

  1   2   >