[PULL] drm-misc-next

2022-09-05 Thread Maarten Lankhorst
Hi Dave, Daniel, A pull request prepared in Germany and Denmark, but sent from Sweden after fighting with gpg on an infamous bridge. My computer's somewhere in my trunk so I just copied someone else's pull request and pretend my laptop is a dev machine that sends pull requests every day works

RE: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended one to configure and enable regulator

2022-09-05 Thread Biju Das
Hi Clement, > > Hi, > > On Mon, 5 Sept 2022 at 20:17, Biju Das > wrote: > > > > Hi, > > > > Thanks for the patch. > > > > > Subject: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the > > > recommended one to configure and enable regulator > > > > > > devm_pm_opp_set_regulators() doesn't enab

Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-05 Thread Christian König
Am 05.09.22 um 18:34 schrieb Arvind Yadav: Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove CONFIG_DEBUG_FS check from this patch. 2- The version of this patch is also changed and previously it wa

[PATCH v3 3/5] arm64: dts: allwinner: h6: Add GPU OPP table

2022-09-05 Thread Clément Péron
Add an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6. The voltage range is set with minival voltage set to the target and the maximal voltage set to 1.2V. This allow DVFS framework to work properly on board with fixed regulator. Signed-off-

[PATCH v3 5/5] arm64: dts: allwinner: beelink-gs1: Enable GPU OPP

2022-09-05 Thread Clément Péron
Enable GPU OPP table for Beelink GS1. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts in

[PATCH v3 2/5] arm64: dts: allwinner: h6: Add cooling map for GPU

2022-09-05 Thread Clément Péron
Add a simple cooling map for the GPU. This cooling map come from the vendor kernel 4.9 with a 2°C hysteresis added. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 51 +++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/arch/arm64/

Re: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended one to configure and enable regulator

2022-09-05 Thread Clément Péron
Hi, On Mon, 5 Sept 2022 at 20:17, Biju Das wrote: > > Hi, > > Thanks for the patch. > > > Subject: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended > > one to configure and enable regulator > > > > devm_pm_opp_set_regulators() doesn't enable regulator, which make > > regulator fra

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-05 Thread Alex Young
Thanks for your reply. We think that when intel_gvt_dma_map_guest_page() fails, ppgtt_invalidate_spt is called to handle this error. If the ppgtt_invalidate_spt is successful to kfree the spt object, then in the ppgtt_populate_spt function there is no need to kfree the spt again. And if the ppg

[PATCH v3 1/5] arm64: defconfig: Enable devfreq cooling device

2022-09-05 Thread Clément Péron
Devfreq cooling device framework is used in Panfrost to throttle GPU in order to regulate its temperature. Enable this driver for ARM64 SoC. Signed-off-by: Clément Péron Acked-by: Jernej Skrabec --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/con

[PATCH v3 0/5] Allwinner H6 GPU devfreq

2022-09-05 Thread Clément Péron
Hi, This is a refresh of previous patches sent to enable GPU Devfreq on H6 Beelink GS1 but that wasn't stable at that time[0]. With the recent fix on GPU PLL from Roman Stratiienko I have retested and everything seems stable and works as expected[1]. Regards, Clement 0: https://lore.kernel.org

[PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended one to configure and enable regulator

2022-09-05 Thread Clément Péron
devm_pm_opp_set_regulators() doesn't enable regulator, which make regulator framework switching it off during regulator_late_cleanup(). Call dev_pm_opp_set_opp() with the recommend OPP in panfrost_devfreq_init() to enable the regulator and avoid any switch off by regulator_late_cleanup(). Suggest

Re: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended one to configure and enable regulator

2022-09-05 Thread Viresh Kumar
Your subject is 87 columns long, better to squeeze it a bit. On 05-09-22, 19:16, Clément Péron wrote: > devm_pm_opp_set_regulators() doesn't enable regulator, which make > regulator framework switching it off during regulator_late_cleanup(). This isn't the normal behavior as it works for everyone

Re: [PATCH] drm/bridge: anx7625: Set HPD irq detect window to 2ms

2022-09-05 Thread Xin Ji
On Mon, Sep 05, 2022 at 06:48:06PM +0200, Robert Foss wrote: > Hi Xin, > > On Sat, 3 Sept 2022 at 15:09, Xin Ji wrote: > > > > Some panels trigger HPD irq due to noise, the HPD debounce > > may be 1.8ms, exceeding the default irq detect window, ~1.4ms. > > This patch set HPD irq detection window

Re: [PATCH 2/6] dt-bindings: reserved-memory: Support framebuffer reserved memory

2022-09-05 Thread Rob Herring
On Mon, 05 Sep 2022 18:32:56 +0200, Thierry Reding wrote: > From: Thierry Reding > > Document the "framebuffer" compatible string for reserved memory nodes > to annotate reserved memory regions used for framebuffer carveouts. > > Signed-off-by: Thierry Reding > --- > .../bindings/reserved-memo

Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed

2022-09-05 Thread Bagas Sanjaya
On 9/6/22 01:47, Michał Winiarski wrote: > References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default > on UML") Use Fixes: tag for bugfix patches instead. -- An old man doll... just what I always wanted! - Clara

[drm-misc:for-linux-next 3/9] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encod

2022-09-05 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 396369d6754993e40f1c84b2e22e40e92dfa4c49 commit: 254fe9c106ed69245fbe0beac582054c98a91482 [3/9] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation config: i386-randconfig-a011-20220905

Re: [PATCH v17 00/10] Add MT8195 DisplayPort driver

2022-09-05 Thread Chun-Kuang Hu
Hi, Dmitry: Dmitry Osipenko 於 2022年9月5日 週一 下午6:53寫道: > > On 9/4/22 15:59, Dmitry Osipenko wrote: > > 01.09.2022 07:41, Bo-Chen Chen пишет: > >> This patch is separated from v10 which is including dp driver, phy driver > >> and dpintf driver. This series is only contained the DisplayPort driver. >

[drm-misc:for-linux-next 9/9] drivers/gpu/drm/vkms/vkms_formats.c:259: undefined reference to `__divdi3'

2022-09-05 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 396369d6754993e40f1c84b2e22e40e92dfa4c49 commit: 396369d6754993e40f1c84b2e22e40e92dfa4c49 [9/9] drm: vkms: Add support to the RGB565 format config: i386-randconfig-a006-20220905 (https://download.01.org/0day-ci/archive

Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index()

2022-09-05 Thread Dmitry Torokhov
On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit, so let's switch to the generic > fwnode property API. > > Signed-off-by: Dmitry Torokhov > > diff --git a/drivers/pci/con

Re: [PATCH v17 03/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-09-05 Thread Chun-Kuang Hu
Hi, Bo-Chen: Please help to fix the compile warning: ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=] 947 | d

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Tue, Sep 06, 2022 at 01:10:10AM +0200, Pali Rohár wrote: > On Monday 05 September 2022 15:54:53 Dmitry Torokhov wrote: > > On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Rohár wrote: > > > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > > > I would like to stop exporting OF-speci

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Pali Rohár
On Monday 05 September 2022 15:54:53 Dmitry Torokhov wrote: > On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Rohár wrote: > > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > > so that gpiolib can be clean

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Rohár wrote: > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > device property API. >

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 09:19:02AM +0200, Pali Rohár wrote: > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > I would like to limit (or maybe even remove) use of > > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > > a bit, so let's switch to the generic dev

[PATCH v2] drm/ssd130x: Replace simple display helpers with the atomic helpers

2022-09-05 Thread Javier Martinez Canillas
The simple display pipeline is a set of helpers that can be used by DRM drivers to avoid dealing with all the needed components and just define a few functions to operate a simple display device with one full-screen scanout buffer feeding a single output. But it is arguable that this provides the

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 12:47, Dmitry Torokhov wrote: [ ... ] We know that count is either 1 or 2 here, so strictly speaking if (count == 1) { } else { } would be sufficient. On the other side, that depends on ARRAY_SIZE() being exactly 2, so if (count == 1) { } else if

Re: [PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 11:03:38PM +0200, Linus Walleij wrote: > On Mon, Sep 5, 2022 at 9:37 PM Dmitry Torokhov > wrote: > > On Mon, Sep 05, 2022 at 01:57:01PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > > > wrote: > > > > > > > > I would like to limit (or

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 12:55, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 10:51 PM Dmitry Torokhov wrote: On Mon, Sep 05, 2022 at 10:41:40PM +0300, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov wrote: On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: On Mon, Sep

Re: [PATCH v7 0/9] Add new formats support to vkms

2022-09-05 Thread Melissa Wen
On 09/05, Igor Torrente wrote: > Summary > === > This series of patches refactor some vkms components in order to introduce > new formats to the planes and writeback connector. > > Now in the blend function, the plane's pixels are converted to ARGB16161616 > and then blended together. > > The

Re: [PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Linus Walleij
On Mon, Sep 5, 2022 at 9:37 PM Dmitry Torokhov wrote: > On Mon, Sep 05, 2022 at 01:57:01PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > > wrote: > > > > > > I would like to limit (or maybe even remove) use of > > > [devm_]gpiod_get_from_of_node in drivers so

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 10:51 PM Dmitry Torokhov wrote: > On Mon, Sep 05, 2022 at 10:41:40PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov > > wrote: > > > On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > > > > On Mon, Sep 5, 2022 at 9:32 AM Dm

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:47:41PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 10:02 AM Pali Rohár wrote: > > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > > so that gpiolib can be cleaned a

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 10:41:40PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov > wrote: > > On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > > > wrote: > > ... > > > > > - gp

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 08:49:58AM -0700, Guenter Roeck wrote: > On 9/5/22 08:21, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 6:13 PM Guenter Roeck wrote: > > > On 9/5/22 04:09, Andy Shevchenko wrote: > > > > On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov > > > > wrote: > > > > ... > > >

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov wrote: > On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > > wrote: ... > > > - gpiod = devm_gpiod_get_from_of_node(&pdev->dev, np, > > > -

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > wrote: > > > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic > > device property A

Re: [PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:57:01PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > wrote: > > > > I would like to limit (or maybe even remove) use of > > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > > a bit, so let's switch to the gener

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_device.c

2022-09-05 Thread Jingyu Wang
Fix some checkpatch.pl complained about in amdgpu_device.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 136 +++-- 1 file changed, 69 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdg

[PATCH v7 8/9] drm: vkms: Adds XRGB_16161616 and ARGB_1616161616 formats

2022-09-05 Thread Igor Torrente
This will be useful to write tests that depends on these formats. ARGB and XRGB follows the a similar implementation of the former formats. Just adjusting for 16 bits per channel. V3: Adapt the handlers to the new format introduced in patch 7 V3. V5: Minor improvements Added le16_to_cpu/cpu_t

[PATCH v7 9/9] drm: vkms: Add support to the RGB565 format

2022-09-05 Thread Igor Torrente
This commit also adds new helper macros to deal with fixed-point arithmetic. It was done to improve the precision of the conversion to ARGB16161616 since the "conversion ratio" is not an integer. V3: Adapt the handlers to the new format introduced in patch 7 V3. V5: Minor improvements V6: Minor i

[PATCH v7 7/9] drm: vkms: Supports to the case where primary plane doesn't match the CRTC

2022-09-05 Thread Igor Torrente
We will remove the current assumption that the primary plane has the same size and position as CRTC and that the primary plane is the bottom-most in zpos order, or is even enabled. At least as far as the blending machinery is concerned. For that we will add CRTC dimension information to `vkms_crtc

[PATCH v7 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-09-05 Thread Igor Torrente
Currently the blend function only accepts XRGB_ and ARGB_ as a color input. This patch refactors all the functions related to the plane composition to overcome this limitation. The pixels blend is done using the new internal format. And new handlers are being added to convert a specific f

[PATCH v7 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-09-05 Thread Igor Torrente
This commit is the groundwork to introduce new formats to the planes and writeback buffer. As part of it, a new buffer metadata field is added to `vkms_writeback_job`, this metadata is represented by the `vkms_frame_info` struct. Also adds two new function pointers (`line_to_frame_func` and `frame

[PATCH v7 4/9] drm: vkms: get the reference to `drm_framebuffer` instead if coping it

2022-09-05 Thread Igor Torrente
Instead of coping `drm_framebuffer` - which can cause problems - we just get the reference and add the ref count. Reviewed-by: Melissa Wen Signed-off-by: Igor Torrente --- drivers/gpu/drm/vkms/vkms_composer.c | 4 ++-- drivers/gpu/drm/vkms/vkms_drv.h | 2 +- drivers/gpu/drm/vkms/vkms_pla

[PATCH v7 3/9] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation

2022-09-05 Thread Igor Torrente
Add a helper function to validate the connector configuration received in the encoder atomic_check by the drivers. So the drivers don't need to do these common validations themselves. V2: Move the format verification to a new helper at the drm_atomic_helper.c (Thomas Zimmermann). V3: Format c

[PATCH v7 2/9] drm: vkms: Rename `vkms_composer` to `vkms_frame_info`

2022-09-05 Thread Igor Torrente
Changes the name of this struct to a more meaningful name. A name that represents better what this struct is about. Composer is the code that do the compositing of the planes. This struct contains information on the frame used in the output composition. Thus, vkms_frame_info is a better name to re

[PATCH v7 1/9] drm: vkms: Replace hardcoded value of `vkms_composer.map` to DRM_FORMAT_MAX_PLANES

2022-09-05 Thread Igor Torrente
The `map` vector at `vkms_composer` uses a hardcoded value to define its size. If someday the maximum number of planes increases, this hardcoded value can be a problem. This value is being replaced with the DRM_FORMAT_MAX_PLANES macro. Acked-by: Thomas Zimmermann Reviewed-by: Melissa Wen Signe

[PATCH v7 0/9] Add new formats support to vkms

2022-09-05 Thread Igor Torrente
Summary === This series of patches refactor some vkms components in order to introduce new formats to the planes and writeback connector. Now in the blend function, the plane's pixels are converted to ARGB16161616 and then blended together. The CRC is calculated based on the ARGB1616161616 bu

[PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed

2022-09-05 Thread Michał Winiarski
When built for UML, KUnit provides virtio/PCI, which means that the DMA/IOMEM UML emulation needed by DRM is already present and does not need to be manually added with --kconfig_add. References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML") Signed-off-by: Michał Winiar

[PATCH] drm/amdgpu: cleanup coding style in amdgpu_kms.c

2022-09-05 Thread Jingyu Wang
Fix some checkpatch.pl complained about in amdgpu_kms.c Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c i

[PATCH v3 2/2] drm/plane_helper: Split into parameterized test cases

2022-09-05 Thread Michał Winiarski
The test was constructed as a single function (test case) which checks multiple conditions, calling the function that is tested multiple times with different arguments. This usually means that it can be easily converted into multiple test cases. Split igt_check_plane_state into two parameterized te

[PATCH v3 1/2] drm/plane_helper: Print actual/expected values on failure

2022-09-05 Thread Michał Winiarski
Currently the values are printed with debug log level. Adjust the log level and link the output with the test by using kunit_err. Example output: foo: dst: 20x20+10+10, expected: 10x10+0+0 foo: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:85 Signed-off-by: Michał Winiarski

Re: [PATCH 1/4] dma-buf: Check status of enable-signaling bit on debug

2022-09-05 Thread Christian König
Am 05.09.22 um 18:39 schrieb Tvrtko Ursulin: On 05/09/2022 12:21, Christian König wrote: Am 05.09.22 um 12:56 schrieb Arvind Yadav: The core DMA-buf framework needs to enable signaling before the fence is signaled. The core DMA-buf framework can forget to enable signaling before the fence is s

Re: [PATCH RESEND drm-misc-next 0/8] drm/arm/malidp: use drm managed resources

2022-09-05 Thread Liviu Dudau
On Mon, Sep 05, 2022 at 05:19:02PM +0200, Danilo Krummrich wrote: > Hi, Hi Danilo, > > This patch series converts the driver to use drm managed resources to prevent > potential use-after-free issues on driver unbind/rebind and to get rid of the > usage of deprecated APIs. Appologies for the ext

RE: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended one to configure and enable regulator

2022-09-05 Thread Biju Das
Hi, Thanks for the patch. > Subject: [PATCH v3 4/5] drm/panfrost: devfreq: set opp to the recommended > one to configure and enable regulator > > devm_pm_opp_set_regulators() doesn't enable regulator, which make > regulator framework switching it off during regulator_late_cleanup(). In that cas

Re: [PATCH v4 4/8] drm/vc4: hdmi: Simplify the hotplug handling

2022-09-05 Thread Ville Syrjälä
On Mon, Aug 29, 2022 at 03:47:27PM +0200, Maxime Ripard wrote: > Our detect callback has a bunch of operations to perform depending on > the current and last status of the connector, such a setting the CEC > physical address or enabling the scrambling again. > > This is currently dealt with a bunc

Re: [PATCH v3 2/5] arm64: dts: allwinner: h6: Add cooling map for GPU

2022-09-05 Thread Jernej Škrabec
Dne ponedeljek, 05. september 2022 ob 19:15:58 CEST je Clément Péron napisal(a): > Add a simple cooling map for the GPU. > > This cooling map come from the vendor kernel 4.9 with a > 2°C hysteresis added. > > Signed-off-by: Clément Péron > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 5

Re: [PATCH v3 0/3] Drivers: hv: Avoid allocating MMIO from framebuffer region for other passed through PCI devices

2022-09-05 Thread Wei Liu
On Sat, Aug 27, 2022 at 03:03:42PM +0200, Vitaly Kuznetsov wrote: [...] > Changes since v2re (PATCH3). > > Vitaly Kuznetsov (3): > PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO > definitions to pci_ids.h > Drivers: hv: Always reserve framebuffer region for Gen1 VMs > Drive

Re: [PATCH v3 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-09-05 Thread Wei Liu
On Tue, Aug 30, 2022 at 09:31:54AM +0200, Vitaly Kuznetsov wrote: > Bjorn Helgaas writes: > > > On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: > >> There are already three places in kernel which define > >> PCI_VENDOR_ID_MICROSOFT > >> and two for PCI_DEVICE_ID_HYPERV_VIDEO an

Re: [PATCH] drm/bridge: anx7625: Set HPD irq detect window to 2ms

2022-09-05 Thread Robert Foss
Hi Xin, On Sat, 3 Sept 2022 at 15:09, Xin Ji wrote: > > Some panels trigger HPD irq due to noise, the HPD debounce > may be 1.8ms, exceeding the default irq detect window, ~1.4ms. > This patch set HPD irq detection window to 2ms to > tolerate the HPD noise. > > Signed-off-by: Xin Ji > --- > dri

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-05 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 5.09.2022 o 15:37, Maxime Ripard pisze: >>> +    vfp = vfp_min + (porches_rem / 2); >>> +    vbp = porches - vfp; >> >> Relative position of the vertical sync within the VBI effectively moves the >> image up and down. Adding that (porches_rem / 2) moves the image up off >> cente

Re: [PATCH 1/4] dma-buf: Check status of enable-signaling bit on debug

2022-09-05 Thread Tvrtko Ursulin
On 05/09/2022 12:21, Christian König wrote: Am 05.09.22 um 12:56 schrieb Arvind Yadav: The core DMA-buf framework needs to enable signaling before the fence is signaled. The core DMA-buf framework can forget to enable signaling before the fence is signaled. To avoid this scenario on the debug

[PATCH v2 4/4] dma-buf: Check status of enable-signaling bit on debug

2022-09-05 Thread Arvind Yadav
The core DMA-buf framework needs to enable signaling before the fence is signaled. The core DMA-buf framework can forget to enable signaling before the fence is signaled. To avoid this scenario on the debug kernel, check the DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT status bit before checking the signaling

[PATCH v2 3/4] dma-buf: enable signaling for selftest fence on debug

2022-09-05 Thread Arvind Yadav
Here's on debug enabling software signaling for selftest. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove unnecessary callback. 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS. 3- The version of this patch is also changed and pre

[PATCH v2 2/4] dma-buf: enable signaling for the stub fence on debug

2022-09-05 Thread Arvind Yadav
Here's on debug enabling software signaling for the stub fence which is always signaled. This fence should enable software signaling otherwise the AMD GPU scheduler will cause a GPU reset due to a GPU scheduler cleanup activity timeout. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressi

[PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-05 Thread Arvind Yadav
Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove CONFIG_DEBUG_FS check from this patch. 2- The version of this patch is also changed and previously it was [PATCH 2/4] --- drivers/gpu/drm/schedul

[PATCH v2 0/4] dma-buf: To check enable signaling before signaled

2022-09-05 Thread Arvind Yadav
TTM, GEM, DRM or the core DMA-buf framework are needs to enable software signaling before the fence is signaled. The core DMA-buf framework software can forget to call enable_signaling before the fence is signaled. It means framework code can forget to call dma_fence_enable_sw_signaling() before ca

[PATCH 6/6] arm64: tegra: Add simple framebuffer on Jetson Xavier NX

2022-09-05 Thread Thierry Reding
From: Thierry Reding Add the framebuffer carveout reserved memory node as well as a simple- framebuffer node that is used to bind to the framebuffer that the bootloader has set up. Signed-off-by: Thierry Reding --- .../nvidia/tegra194-p3509-+p3668-0001.dts | 32 +++ arch/ar

[PATCH 4/6] drm/format-helper: Support the AB24 format

2022-09-05 Thread Thierry Reding
From: Thierry Reding Add a conversion helper for the AB24 format to use in drm_fb_blit(). Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_format_helper.c | 35 + 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/

[PATCH 5/6] drm/simpledrm: Support the AB24 format

2022-09-05 Thread Thierry Reding
From: Thierry Reding Add AB24 to the list of supported formats. The format helpers support conversion to that format and it is documented in the simple-framebuffer device tree bindings. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tiny/simpledrm.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 3/6] drm/simpledrm: Add support for system memory framebuffers

2022-09-05 Thread Thierry Reding
From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory region referenced in the memory-region property. Signed

[PATCH 1/6] dt-bindings: display: simple-framebuffer: Support system memory framebuffers

2022-09-05 Thread Thierry Reding
From: Thierry Reding In order to support framebuffers residing in system memory, allow the memory-region property to override the framebuffer memory specification in the "reg" property. Signed-off-by: Thierry Reding --- .../devicetree/bindings/display/simple-framebuffer.yaml | 5 + 1

[PATCH 2/6] dt-bindings: reserved-memory: Support framebuffer reserved memory

2022-09-05 Thread Thierry Reding
From: Thierry Reding Document the "framebuffer" compatible string for reserved memory nodes to annotate reserved memory regions used for framebuffer carveouts. Signed-off-by: Thierry Reding --- .../bindings/reserved-memory/framebuffer.yaml | 46 +++ 1 file changed, 46 insertion

[PATCH 0/6] drm/simpledrm: Support system memory framebuffers

2022-09-05 Thread Thierry Reding
From: Thierry Reding Hi, this series of patches adds support for framebuffers residing in system memory to the simple-framebuffer DRM driver. To do this, the DT bindings are extended do accept the memory-region property in addition to the reg property for specifying the framebuffer memory. This

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-05 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > Hi, > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: +enum drm_mode_analog { +    DRM_MODE_ANALOG_NTSC, +    DRM_MODE_ANALOG_PAL, +}; >>> >>> Using "NTSC" and "PAL" to describe the 50Hz and 60Hz

[PATCH] drm/aperture: Fix some kerneldoc comments

2022-09-05 Thread Thierry Reding
From: Thierry Reding Reword some kerneldoc comments for the DRM aperture handling code. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_aperture.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_aperture.c b/drivers/gpu/drm/drm_aperture.

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 08:21, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 6:13 PM Guenter Roeck wrote: On 9/5/22 04:09, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov wrote: ... + count = device_property_count_u32(dev->parent, "rohm,hw-timeout-ms"); + if (count < 0

Re: [PATCH 2/4] drm/sched: Add callback and enable signaling on debug

2022-09-05 Thread Christian König
Am 05.09.22 um 15:46 schrieb Yadav, Arvind: On 9/5/2022 4:55 PM, Christian König wrote: [SNIP] Am 05.09.22 um 12:56 schrieb Arvind Yadav:   .release = drm_sched_fence_release_finished,   };   diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c ind

[PATCH RESEND drm-misc-next 7/7] drm/arm/hdlcd: debugfs: protect device resources after removal

2022-09-05 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH RESEND drm-misc-next 6/7] drm/arm/hdlcd: crtc: protect device resources after removal

2022-09-05 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH RESEND drm-misc-next 4/7] drm/arm/hdlcd: plane: use drm managed resources

2022-09-05 Thread Danilo Krummrich
Use drm managed resource allocation (drmm_universal_plane_alloc()) in order to get rid of the explicit destroy hook in struct drm_plane_funcs. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_crtc.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --

[PATCH RESEND drm-misc-next 5/7] drm/arm/hdlcd: use drm_dev_unplug()

2022-09-05 Thread Danilo Krummrich
When the driver is unbound, there might still be users in userspace having an open fd and are calling into the driver. While this is fine for drm managed resources, it is not for resources bound to the device/driver lifecycle, e.g. clocks or MMIO mappings. To prevent use-after-free issues we need

[PATCH RESEND drm-misc-next 1/7] drm/arm/hdlcd: use drmm_* to allocate driver structures

2022-09-05 Thread Danilo Krummrich
Use drm managed resources to allocate driver structures and get rid of the deprecated drm_dev_alloc() call and replace it with devm_drm_dev_alloc(). This also serves as preparation to get rid of drm_device->dev_private and to fix use-after-free issues on driver unload. Signed-off-by: Danilo Krumm

[PATCH RESEND drm-misc-next 3/7] drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()

2022-09-05 Thread Danilo Krummrich
Use drmm_crtc_init_with_planes() instead of drm_crtc_init_with_planes() to get rid of the explicit drm_crtc_cleanup() call. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_crtc

[PATCH RESEND drm-misc-next 2/7] drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv()

2022-09-05 Thread Danilo Krummrich
Using drm_device->dev_private is deprecated. Since we've switched to devm_drm_dev_alloc(), struct drm_device is now embedded in struct hdlcd_drm_private, hence we can use container_of() to get the struct drm_device instance instead. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_c

[PATCH RESEND drm-misc-next 0/7] drm/arm/hdlcd: use drm managed resources

2022-09-05 Thread Danilo Krummrich
Hi, This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs. Danilo Krummrich (7): drm/arm/hdlcd: use drmm_* to allocate driver structures drm/arm/hdlcd: replace drm->d

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Andy Shevchenko
On Mon, Sep 5, 2022 at 6:13 PM Guenter Roeck wrote: > On 9/5/22 04:09, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov > > wrote: ... > >> + count = device_property_count_u32(dev->parent, > >> "rohm,hw-timeout-ms"); > >> + if (count < 0 && count != -EINVAL

Re: [PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-09-05 Thread Robert Foss
Thanks Laurent, On Sat, 3 Sept 2022 at 02:17, Laurent Pinchart wrote: > > Hi Chris, > > Thank you for the patch. > > On Fri, Sep 02, 2022 at 10:39:05AM -0500, Chris Morgan wrote: > > From: Chris Morgan > > > > Update dt-binding documentation to add support for setting byteswap of > > chrontel ch

[PATCH RESEND drm-misc-next 8/8] drm/arm/malidp: drv: protect device resources after removal

2022-09-05 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH RESEND drm-misc-next 7/8] drm/arm/malidp: crtc: protect device resources after removal

2022-09-05 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH RESEND drm-misc-next 6/8] drm/arm/malidp: plane: protect device resources after removal

2022-09-05 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH RESEND drm-misc-next 5/8] drm/arm/malidp: use drm_dev_unplug()

2022-09-05 Thread Danilo Krummrich
When the driver is unbound, there might still be users in userspace having an open fd and are calling into the driver. While this is fine for drm managed resources, it is not for resources bound to the device/driver lifecycle, e.g. clocks or MMIO mappings. To prevent use-after-free issues we need

[PATCH RESEND drm-misc-next 4/8] drm/arm/malidp: plane: use drm managed resources

2022-09-05 Thread Danilo Krummrich
Use drm managed resource allocation (drmm_universal_plane_alloc()) in order to get rid of the explicit destroy hook in struct drm_plane_funcs. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/malidp_planes.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(

[PATCH RESEND drm-misc-next 3/8] drm/arm/malidp: crtc: use drmm_crtc_init_with_planes()

2022-09-05 Thread Danilo Krummrich
Use drmm_crtc_init_with_planes() instead of drm_crtc_init_with_planes() to get rid of the explicit destroy hook in struct drm_plane_funcs. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/malidp_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/dr

[PATCH RESEND drm-misc-next 2/8] drm/arm/malidp: replace drm->dev_private with drm_to_malidp()

2022-09-05 Thread Danilo Krummrich
Using drm_device->dev_private is deprecated. Since we've switched to devm_drm_dev_alloc(), struct drm_device is now embedded in struct malidp_drm, hence we can use container_of() to get the struct drm_device instance instead. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/malidp_crtc.c

[PATCH RESEND drm-misc-next 0/8] drm/arm/malidp: use drm managed resources

2022-09-05 Thread Danilo Krummrich
Hi, This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs. Danilo Krummrich (8): drm/arm/malidp: use drmm_* to allocate driver structures drm/arm/malidp: replace drm-

[PATCH RESEND drm-misc-next 1/8] drm/arm/malidp: use drmm_* to allocate driver structures

2022-09-05 Thread Danilo Krummrich
Use drm managed resources to allocate driver structures and get rid of the deprecated drm_dev_alloc() call and replace it with devm_drm_dev_alloc(). This also serves as preparation to get rid of drm_device->dev_private and to fix use-after-free issues on driver unload. Signed-off-by: Danilo Krumm

Re: [PATCH v9 04/10] dt-bindings: backlight: Add MediaTek MT6370 backlight

2022-09-05 Thread Lee Jones
On Tue, 30 Aug 2022, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add MT6370 backlight binding documentation. > > Reviewed-by: Rob Herring > Reviewed-by: Daniel Thompson > Signed-off-by: ChiYuan Huang > Signed-off-by: ChiaEn Wu > --- > .../leds/backlight/mediatek,mt6370-backlight.yaml | 121

Re: [PATCH v9 10/10] video: backlight: mt6370: Add MediaTek MT6370 support

2022-09-05 Thread Lee Jones
On Tue, 30 Aug 2022, ChiaEn Wu wrote: > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB Type-C & PD

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-05 Thread Noralf Trønnes
Den 05.09.2022 16.57, skrev Maxime Ripard: > On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: >> >> >> Den 01.09.2022 21.35, skrev Noralf Trønnes: >>> >>> >>> I have finally found a workaround for my kernel hangs. >>> >>> Dom had a look at my kernel and found that the VideoCore wa

  1   2   3   >