Re: [PATCH v2 02/10] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > In preparation for adding new bindings for new MediaTek SoCs, split out > the power-domain-names and power-domainsvariation from the `else` in ^ missing space Otherwise,

Re: [PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 04:37:30PM +0100, AngeloGioacchino Del Regno wrote: > Changes in v2: > - Add power-domain-names commit from Chen-Yu to the series > - Kept sram-supply in base schema, overridden for non-MediaTek > - Added Reviewed-by tags from Steven Price to the driver commits >(as

Re: [PATCH 2/2] drm: rcar-du: Disable alpha blending for DU planes used with VSP

2023-02-21 Thread Tomi Valkeinen
On 22/02/2023 07:06, Laurent Pinchart wrote: When the input to a DU channel comes from a VSP, the DU doesn't perform any blending operation. Select XRGB instead of ARGB to ensure that the corresponding registers don't get written with invalid values. Signed-off-by: Laurent Pinchart ---

Re: [PATCH v2 10/10] drm/panfrost: Add new compatible for Mali on the MT8183 SoC

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > The "mediatek,mt8183-mali" compatible uses platform data that calls for > getting (and managing) two regulators ("mali" and "sram") but devfreq > does not support this usecase, resulting in DVFS not working. > > Since a lot of

[PATCH 7/7] drm/i915/dsc: Add debugfs entry to validate DSC output formats

2023-02-21 Thread Suraj Kandpal
From: Swati Sharma DSC_Output_Format_Sink_Support entry is added to i915_dsc_fec_support_show to depict if sink supports DSC output formats (RGB/YCbCr420/YCbCr444). Also, new debugfs entry is created to enforce output format. This is required because of our driver policy. For ex. if a mode is

[PATCH 5/7] drm/i915/display: Fill in native_420 field

2023-02-21 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420

[PATCH 6/7] drm/i915/vdsc: Check slice design requirement

2023-02-21 Thread Suraj Kandpal
Add function to check if slice design requirements are being met as defined in Bspec: 49259 in the section Slice Design Requirement --v7 -remove full bspec link [Jani] -rename intel_dsc_check_slice_design_req to intel_dsc_slice_dimensions_valid [Jani] --v8 -fix condition to check if slice width

[PATCH 4/7] drm/i915: Enable YCbCr420 for VDSC

2023-02-21 Thread Suraj Kandpal
Implementation of VDSC for YCbCr420. Add QP tables for 8,10,12 BPC from rc_tables.h in intel_qp_tables.c (Derived from C-Model, which is given along with DSC1.2a Spec from Vesa) intel_lookup_range_min/max_qp functons need to take into account the output format. Based on that appropriate qp table

[PATCH 3/7] drm/i915: Adding the new registers for DSC

2023-02-21 Thread Suraj Kandpal
Adding new DSC register which are introducted MTL onwards Signed-off-by: Suraj Kandpal Reviewed-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_reg.h | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[PATCH 2/7] drm/i915/dp: Check if DSC supports the given output_format

2023-02-21 Thread Suraj Kandpal
From: Ankit Nautiyal Go with DSC only if the given output_format is supported. v2: Use drm helper to get DSC format support for sink. v3: remove drm_dp_dsc_compute_bpp. Cc: Uma Shankar Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 28 +

[PATCH 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format

2023-02-21 Thread Suraj Kandpal
From: Ankit Nautiyal Add helper to check if the DP sink supports DSC with the given o/p format. v2: Add documentation for the helper. (Uma Shankar) Signed-off-by: Ankit Nautiyal --- include/drm/display/drm_dp_helper.h | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 0/7] Enable YCbCr420 format for VDSC

2023-02-21 Thread Suraj Kandpal
This patch series aims to enable the YCbCr420 format for DSC. Changes are mostly compute params related for hdmi,dp and dsi along with the addition of new rc_tables for native_420 and corresponding changes to macros used to fetch them. There have been discussions prior to this series in which some

[PATCH 2/2] drm: rcar-du: Disable alpha blending for DU planes used with VSP

2023-02-21 Thread Laurent Pinchart
When the input to a DU channel comes from a VSP, the DU doesn't perform any blending operation. Select XRGB instead of ARGB to ensure that the corresponding registers don't get written with invalid values. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-

[PATCH 1/2] drm: rcar-du: Don't write unimplemented ESCR and OTAR registers on Gen3

2023-02-21 Thread Laurent Pinchart
The ESCR and OTAR registers are not present in all DU channels on Gen3 SoCs. ESCR only exists in channels that can be routed to an LVDS or DPAD, and OTAR in channels that can be routed to a DPAD. Skip writing those registers for other channels. This replaces the DU gen check, as Gen4 doesn't have

[PATCH 0/2] drm: rcar-du: Avoid writing reserved register fields

2023-02-21 Thread Laurent Pinchart
Hello, This patch series addresses writes to reserved register fields or reserved registers. Depending on the DU variant, some registers or register fields are marked as reserved, but the rcar-du driver writes them unconditionally. There is a high chance that those registers and fields are

Re: [PATCH v12 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-02-21 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Tue, Feb 21, 2023 at 7:36 PM Andy Shevchenko wrote: > > On Tue, Feb 21, 2023 at 05:50:51PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant ports are available in Device Tree. Configure the

Re: [PATCH v12 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-02-21 Thread Pin-yen Lin
On Tue, Feb 21, 2023 at 5:51 PM Pin-yen Lin wrote: > > These two drivers embed a i2c_client in there private driver data, but This should be "their private driver data". I'll fix this in the next version. Pin-yen > only strict device is actually needed. Replace the i2c_client reference > with

Re: [PATCH v2 09/10] drm/panfrost: Add mediatek, mt8192-mali compatible

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > From: Alyssa Rosenzweig > > Required for Mali-G57 on the Mediatek MT8192 and MT8195, which > uses even more power domains than the MT8183 before it. > > Signed-off-by: Alyssa Rosenzweig > [Angelo: Removed unneeded "sram"

Re: [PATCH v2 07/10] drm/panfrost: Increase MAX_PM_DOMAINS to 5

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > From: Alyssa Rosenzweig > > Increase the MAX_PM_DOMAINS constant from 3 to 5, to support the > extra power domains required by the Mali-G57 on the MT8192. > > Signed-off-by: Alyssa Rosenzweig > Signed-off-by:

Re: [PATCH v2 08/10] drm/panfrost: Add the MT8192 GPU ID

2023-02-21 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > From: Alyssa Rosenzweig > > MediaTek MT8192 has a Mali-G57 with a special GPU ID. Add its GPU ID, > but treat it as otherwise identical to a standard Mali-G57. > > We do _not_ fix up the GPU ID here -- userspace needs to be

Re: [PATCH v2] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread Felix Kuehling
Am 2023-02-21 um 22:05 schrieb qu.hu...@linux.dev: In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events() function, it

[drm-misc:for-linux-next 1/1] drivers/gpu/drm/msm/msm_fbdev.c:144:6: warning: variable 'helper' is used uninitialized whenever 'if' condition is true

2023-02-21 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 3fb1f62f80a1d249260db5ea9e22c51e52fab9ae commit: 3fb1f62f80a1d249260db5ea9e22c51e52fab9ae [1/1] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini() config: arm-buildonly-randconfig-r004-20230219

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 3:20 PM Rob Clark wrote: > > On Tue, Feb 21, 2023 at 2:46 PM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > > > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Feb 21, 2023 at 11:39:40PM

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 2:46 PM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > > wrote: > > > > > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > > > On Tue, Feb 21, 2023 at 11:54:55AM

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > > > On Tue, Feb 21, 2023 at 5:01 AM Ville

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Feb 21, 2023 at

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > > wrote: > > > > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > > On Mon, 20 Feb 2023 07:55:41

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > On Mon, 20 Feb 2023 07:55:41 -0800 > > > Rob Clark wrote: > > > > > > > On Mon, Feb 20, 2023 at 1:08

[PATCH] dt-bindings: display: Start the info graphics with HS/VS change

2023-02-21 Thread Marek Vasut
The VS signal change is synchronized to HS signal change, start the info graphics with that event, instead of having that event occur in the middle of it. Scope trace of DPI bus with HS/VS active HIGH looks as follows: ...__ VS...___/__ __\__...

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023

Re: [PATCH v4 08/14] drm/scheduler: Add fence deadline support

2023-02-21 Thread Luben Tuikov
On 2023-02-18 16:15, Rob Clark wrote: > As the finished fence is the one that is exposed to userspace, and > therefore the one that other operations, like atomic update, would > block on, we need to propagate the deadline from from the finished > fence to the actual hw fence. > > v2: Split into

Re: [PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread Christophe JAILLET
Le 21/02/2023 à 17:26, Felix Kuehling a écrit : On 2023-02-21 06:35, qu.huang-fxuvxftifdnyg1zeobx...@public.gmane.org wrote: From: Qu Huang In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure

[PATCH v4 4/4] drm/msm/mdp4: Remove empty prepare_commit() function

2023-02-21 Thread Jessica Zhang
Remove empty prepare_commit() function from MDP4 driver. Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

[PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-02-21 Thread Jessica Zhang
Now that the TE setup has been moved to prepare_for_kickoff(), we have not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit() do nothing. Remove prepare_commit() from DPU driver. Changes in V3: - Reworded commit message to be more clear - Corrected spelling mistake in

[PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit()

2023-02-21 Thread Jessica Zhang
Add a NULL check before calling prepare_commit() in msm_atomic_commit_tail() Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_atomic.c

[PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-21 Thread Jessica Zhang
Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is only initialized in

[PATCH v4 0/4] Move TE setup to prepare_for_kickoff()

2023-02-21 Thread Jessica Zhang
Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() functions in both MDP4 and DPU drivers. Changes in V2: - Added changes to remove empty prepare_commit() functions Changes in V3: - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for clarity - Fixed

Re: [PATCH drm-next v2 04/16] maple_tree: add flag MT_FLAGS_LOCK_NONE

2023-02-21 Thread Matthew Wilcox
On Tue, Feb 21, 2023 at 03:37:49PM +0100, Danilo Krummrich wrote: > On Mon, Feb 20, 2023 at 08:33:35PM +, Matthew Wilcox wrote: > > On Mon, Feb 20, 2023 at 06:06:03PM +0100, Danilo Krummrich wrote: > > > On 2/20/23 16:10, Matthew Wilcox wrote: > > > > This is why we like people to use the

Re: [PATCH] drm/i915/sseu: fix max_subslices array-index-out-of-bounds access

2023-02-21 Thread Matt Roper
On Tue, Feb 21, 2023 at 09:01:24AM +, Tvrtko Ursulin wrote: > > > On 20/02/2023 17:18, Andrea Righi wrote: > > It seems that commit bc3c5e0809ae ("drm/i915/sseu: Don't try to store EU > > mask internally in UAPI format") exposed a potential out-of-bounds > > access, reported by UBSAN as

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-21 Thread Liam R. Howlett
* Danilo Krummrich [230217 08:45]: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to request

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 8:01 AM Sebastian Wick wrote: > > On Tue, Feb 21, 2023 at 9:38 AM Pekka Paalanen wrote: > > > > On Mon, 20 Feb 2023 08:14:47 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023 13:15:49

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 8:48 AM Luben Tuikov wrote: > > On 2023-02-20 11:14, Rob Clark wrote: > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > >> > >> On Sat, 18 Feb 2023 13:15:49 -0800 > >> Rob Clark wrote: > >> > >>> From: Rob Clark > >>> > >>> Allow userspace to use the

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023

Re: [Intel-gfx] [PATCH 7/7] drm/ttm: cleanup ttm_range_mgr_node

2023-02-21 Thread Matthew Auld
On Fri, 17 Feb 2023 at 12:23, Christian König wrote: > > We don't need multiple drm_mm nodes any more. Clean that up and remove > the extra complexity. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld

Re: [PATCH 5/7] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-02-21 Thread Matthew Auld
On Fri, 17 Feb 2023 at 12:23, Christian König wrote: > > From: Somalapuram Amaranath > > ttm_resource can allocate size in bytes to support less than page size. > > Signed-off-by: Somalapuram Amaranath > Reviewed-by: Christian König > Signed-off-by: Christian König > Link: >

Re: [PATCH v5 09/14] drm/syncobj: Add deadline support for syncobj waits

2023-02-21 Thread Rob Clark
On Tue, Feb 21, 2023 at 12:53 AM Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 12:18:56 -0800 > Rob Clark wrote: > > > From: Rob Clark > > > > Add a new flag to let userspace provide a deadline as a hint for syncobj > > and timeline waits. This gives a hint to the driver signaling the > >

[PATCH] dt-bindings: display: bridge: parade, ps8622: convert to dtschema

2023-02-21 Thread Krzysztof Kozlowski
Convert the Parade PS8622/PS8625 DisplayPort to LVDS Converter bindings to DT schema. Changes during conversion: add missing vdd12-supply, used by Linux driver. Signed-off-by: Krzysztof Kozlowski --- .../display/bridge/parade,ps8622.yaml | 115 ++

Re: [PATCH drm-next v2 03/16] maple_tree: split up MA_STATE() macro

2023-02-21 Thread Liam R. Howlett
* Danilo Krummrich [230220 09:38]: > On 2/17/23 19:34, Liam R. Howlett wrote: > > * Danilo Krummrich [230217 08:44]: > > > Split up the MA_STATE() macro such that components using the maple tree > > > can easily inherit from struct ma_state and build custom tree walk > > > macros to hide their

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-21 Thread Luben Tuikov
On 2023-02-20 11:14, Rob Clark wrote: > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: >> >> On Sat, 18 Feb 2023 13:15:49 -0800 >> Rob Clark wrote: >> >>> From: Rob Clark >>> >>> Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent >>> wait (as opposed to a

Re: [PATCH 0/4] drm/displayid: use primary use case to figure out non-desktop

2023-02-21 Thread Dmitry Osipenko
On 2/20/23 18:44, Dmitry Osipenko wrote: > On 2/16/23 23:44, Jani Nikula wrote: >> Mostly this is prep work and plumbing for easier use of displayid >> structure version and primary use case for parsing the displayid blocks, >> but it can be nicely used for figuring out non-desktop too. >> >>

Re: [PATCH 5/4] drm/edid: parse Tiled Display Topology Data Block for DisplayID 2.0

2023-02-21 Thread Dmitry Osipenko
On 2/17/23 13:46, Jani Nikula wrote: > Currently we only parse the Tiled Display Topology Data Block for > DisplayID structure version 1.2, but not 2.0. The contents seem to be > the same for both, so expand the parsing to structure version 2.0. > > Note that DisplayID spec version is not the

Re: [PATCH 4/4] drm/edid: update non-desktop use also from DisplayID

2023-02-21 Thread Dmitry Osipenko
On 2/16/23 23:45, Jani Nikula wrote: > Use the DisplayID 2.0 primary use case information to deduce whether > this is a head-mounted display, and should not be used for desktop. > > Cc: Iaroslav Boliukin > Cc: Dmitry Osipenko > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c |

Re: [PATCH 3/4] drm/displayid: provide access to DisplayID version and primary use case

2023-02-21 Thread Dmitry Osipenko
On 2/16/23 23:45, Jani Nikula wrote: > The DisplayID structure version and primary use case are stored in the > DisplayID Base Section. We should be checking them in a number of places > when parsing the DisplayID blocks. Currently, we completely ignore the > primary use case, and just look at the

Re: [PATCH 2/4] drm/displayid: return struct displayid_header from validate_displayid()

2023-02-21 Thread Dmitry Osipenko
On 2/16/23 23:44, Jani Nikula wrote: > Avoid figuring out the header pointer multiple times. > > Cc: Iaroslav Boliukin > Cc: Dmitry Osipenko > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_displayid.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff

Re: [PATCH 1/4] drm/displayid: add displayid_get_header() and check bounds better

2023-02-21 Thread Dmitry Osipenko
On 2/16/23 23:44, Jani Nikula wrote: > Add a helper to get a pointer to struct displayid_header. To be > pedantic, add buffer overflow checks to not touch the base if that > itself would overflow. > > Cc: Iaroslav Boliukin > Cc: Dmitry Osipenko > Signed-off-by: Jani Nikula > --- >

Re: [PATCH 1/4] drm/gem-vram: handle NULL bo->resource in move callback

2023-02-21 Thread Christian König
Am 21.02.23 um 17:26 schrieb Matthew Auld: On 21/02/2023 16:17, Christian König wrote: Am 21.02.23 um 17:13 schrieb Matthew Auld: On 10/02/2023 11:03, Christian König wrote: Am 08.02.23 um 15:53 schrieb Matthew Auld: The ttm BO now initially has NULL bo->resource, and leaves the driver the

Re: [PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread Felix Kuehling
On 2023-02-21 06:35, qu.hu...@linux.dev wrote: From: Qu Huang In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events()

Re: [PATCH 1/4] drm/gem-vram: handle NULL bo->resource in move callback

2023-02-21 Thread Matthew Auld
On 21/02/2023 16:17, Christian König wrote: Am 21.02.23 um 17:13 schrieb Matthew Auld: On 10/02/2023 11:03, Christian König wrote: Am 08.02.23 um 15:53 schrieb Matthew Auld: The ttm BO now initially has NULL bo->resource, and leaves the driver the handle that. However it looks like we forgot

Re: [PATCH 1/4] drm/gem-vram: handle NULL bo->resource in move callback

2023-02-21 Thread Christian König
Am 21.02.23 um 17:13 schrieb Matthew Auld: On 10/02/2023 11:03, Christian König wrote: Am 08.02.23 um 15:53 schrieb Matthew Auld: The ttm BO now initially has NULL bo->resource, and leaves the driver the handle that. However it looks like we forgot to handle that for ttm_bo_move_memcpy()

Re: [PATCH 1/4] drm/gem-vram: handle NULL bo->resource in move callback

2023-02-21 Thread Matthew Auld
On 10/02/2023 11:03, Christian König wrote: Am 08.02.23 um 15:53 schrieb Matthew Auld: The ttm BO now initially has NULL bo->resource, and leaves the driver the handle that. However it looks like we forgot to handle that for ttm_bo_move_memcpy() users, like with vram-gem, since it just silently

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-21 Thread Sebastian Wick
On Tue, Feb 21, 2023 at 9:38 AM Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 08:14:47 -0800 > Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > > > > > > On Sat, 18 Feb 2023 13:15:49 -0800 > > > Rob Clark wrote: > > > > > > > From: Rob Clark > > > > > > > >

[PATCH 3/4] drm/ast: Rename struct ast_private to struct ast_device

2023-02-21 Thread Thomas Zimmermann
The data structure struct ast_private represents an AST device. Its name comes from the time when it was allocated and stored separately in struct drm_device.dev_private. The DRM device is now embedded, so rename struct ast_private to struct ast_device. Signed-off-by: Thomas Zimmermann ---

[PATCH 0/4] drm/ast: Use struct ast_device

2023-02-21 Thread Thomas Zimmermann
Rename struct ast_private to struct ast_device. The old name comes from the time when struct drm_device.dev_private was still in use. Also update the upcast helper. The renaming touches ast's I/O-helper macros, which generate warnings with checkpatch. So fix the I/O helpers in the first two

[PATCH 1/4] drm/ast: Remove little-endianism from I/O helpers

2023-02-21 Thread Thomas Zimmermann
Replace one call to ast_io_write16() with two calls to ast_io_write8() in ast_set_index_reg(). The combined 16-bit-wide write of an index register and the corresponding data register only works on little- endian systems. Write both registers independent from each other. Signed-off-by: Thomas

[PATCH 4/4] drm/ast: Rename to_ast_private() to to_ast_device()

2023-02-21 Thread Thomas Zimmermann
The helper to_ast_private() now upcasts to struct ast_device. Rename it accordingly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c| 10 +- drivers/gpu/drm/ast/ast_dp501.c | 20 ++-- drivers/gpu/drm/ast/ast_drv.h | 2 +-

[PATCH 2/4] drm/ast: Rework definition of I/O read and write helpers

2023-02-21 Thread Thomas Zimmermann
Ast defines a number of I/O helpers for accessing hardware. Only 4 of the many generated functions are actually used. Replace the respective generator macros with those 4 functions. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 48

Re: [PATCH v3 1/5] dt-bindings: display: bridge: Add ddc-i2c-bus for anx7688

2023-02-21 Thread Rob Herring
On Sat, Feb 18, 2023 at 07:17:08PM +0800, Pin-yen Lin wrote: > Introduce a optional "ddc-i2c-bus" property for anx7688 bridge. This > allows the bridge to register a .get_edid callback. What's .get_edid? This is a binding and is independent of Linux. > > Signed-off-by: Pin-yen Lin > --- > >

[PATCH v2 05/10] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible

2023-02-21 Thread AngeloGioacchino Del Regno
Since new platform data was required in Panfrost for getting GPU DVFS finally working on MediaTek SoCs, add a new "mediatek,mt8183b-mali" compatible. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring --- .../bindings/gpu/arm,mali-bifrost.yaml| 19 +++

[PATCH v2 07/10] drm/panfrost: Increase MAX_PM_DOMAINS to 5

2023-02-21 Thread AngeloGioacchino Del Regno
From: Alyssa Rosenzweig Increase the MAX_PM_DOMAINS constant from 3 to 5, to support the extra power domains required by the Mali-G57 on the MT8192. Signed-off-by: Alyssa Rosenzweig Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price ---

[PATCH v2 09/10] drm/panfrost: Add mediatek,mt8192-mali compatible

2023-02-21 Thread AngeloGioacchino Del Regno
From: Alyssa Rosenzweig Required for Mali-G57 on the Mediatek MT8192 and MT8195, which uses even more power domains than the MT8183 before it. Signed-off-by: Alyssa Rosenzweig [Angelo: Removed unneeded "sram" supply, added mt8195 to commit description] Co-developed-by: AngeloGioacchino Del

[PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-21 Thread AngeloGioacchino Del Regno
Get GPU support on MT8186 by adding its compatible. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml

[PATCH v2 08/10] drm/panfrost: Add the MT8192 GPU ID

2023-02-21 Thread AngeloGioacchino Del Regno
From: Alyssa Rosenzweig MediaTek MT8192 has a Mali-G57 with a special GPU ID. Add its GPU ID, but treat it as otherwise identical to a standard Mali-G57. We do _not_ fix up the GPU ID here -- userspace needs to be aware of the special GPU ID, in case we find functional differences between

[PATCH v2 10/10] drm/panfrost: Add new compatible for Mali on the MT8183 SoC

2023-02-21 Thread AngeloGioacchino Del Regno
The "mediatek,mt8183-mali" compatible uses platform data that calls for getting (and managing) two regulators ("mali" and "sram") but devfreq does not support this usecase, resulting in DVFS not working. Since a lot of MediaTek SoCs need to set the voltages for the GPU SRAM regulator in a

[PATCH v2 04/10] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC

2023-02-21 Thread AngeloGioacchino Del Regno
The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the same number of power domains and requirements as MT8192 in terms of bindings. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 + 1

[PATCH v2 01/10] dt-bindings: gpu: mali-bifrost: Add power-domain-names to base schema

2023-02-21 Thread AngeloGioacchino Del Regno
From: Chen-Yu Tsai In commit a7a596cd3115 ("dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183"), "power-domain-names" was added to the mt8183-mali sub-schema, but was not added to the base mali-bifrost schema. Because validation happens for the base schema and any sub-schemas separately, this

[PATCH v2 03/10] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192

2023-02-21 Thread AngeloGioacchino Del Regno
MediaTek MT8192 (and similar) needs five power domains for the Mali GPU and no sram-supply: change the binding to allow so. Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring ---

[PATCH v2 02/10] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation

2023-02-21 Thread AngeloGioacchino Del Regno
In preparation for adding new bindings for new MediaTek SoCs, split out the power-domain-names and power-domainsvariation from the `else` in the current mediatek,mt8183-mali conditional. The sram-supply part is left in place to be disallowed for anything that is not compatible with

[PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support

2023-02-21 Thread AngeloGioacchino Del Regno
Changes in v2: - Add power-domain-names commit from Chen-Yu to the series - Kept sram-supply in base schema, overridden for non-MediaTek - Added Reviewed-by tags from Steven Price to the driver commits (as released in reply to v1's cover letter - thanks!) This series adds support for new

Re: [PATCH drm-next v2 01/16] drm: execution context for GEM buffers

2023-02-21 Thread Danilo Krummrich
On 2/17/23 17:00, Christian König wrote: Am 17.02.23 um 14:44 schrieb Danilo Krummrich: From: Christian König This adds the infrastructure for an execution context for GEM buffers which is similar to the existinc TTMs execbuf util and intended to replace it in the long term. The basic

Re: [PATCH drm-next v2 04/16] maple_tree: add flag MT_FLAGS_LOCK_NONE

2023-02-21 Thread Danilo Krummrich
On Mon, Feb 20, 2023 at 08:33:35PM +, Matthew Wilcox wrote: > On Mon, Feb 20, 2023 at 06:06:03PM +0100, Danilo Krummrich wrote: > > On 2/20/23 16:10, Matthew Wilcox wrote: > > > This is why we like people to use the spinlock embedded in the tree. > > > There's nothing for the user to care

Re: [PATCH v2 1/9] drm/vc4: Switch to container_of_const

2023-02-21 Thread Hans Verkuil
On 2/21/23 12:38, Maxime Ripard wrote: > Hi Hans, > > On Sat, Feb 18, 2023 at 11:45:04AM +0100, Hans Verkuil wrote: >>> diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c >>> index 86d629e45307..d0a00ed42cb0 100644 >>> --- a/drivers/gpu/drm/vc4/vc4_bo.c >>> +++

[Bug 217065] Linux 6.2.0 - AMDGPU cannot start, ends in a blank screen.

2023-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217065 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2023 at 03:11:33PM +0200, Pekka Paalanen wrote: > On Tue, 21 Feb 2023 15:01:35 +0200 > Ville Syrjälä wrote: > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > On Mon, 20 Feb 2023 07:55:41 -0800 > > > Rob Clark wrote: > > > > > > > On Mon, Feb 20, 2023

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Pekka Paalanen
On Tue, 21 Feb 2023 15:01:35 +0200 Ville Syrjälä wrote: > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-21 Thread Ville Syrjälä
On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > On Mon, 20 Feb 2023 07:55:41 -0800 > Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen wrote: > > > > > > On Sat, 18 Feb 2023 13:15:53 -0800 > > > Rob Clark wrote: > > > > > > > From: Rob Clark > > > > > >

a test email

2023-02-21 Thread liyi
this is a test email, Sorry to be a bother

[PULL] drm-misc-next-fixes

2023-02-21 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the final PR for drm-misc-next-fixes for this release cycle. Best regards Thomas drm-misc-next-fixes-2023-02-21: Short summary of fixes pull: Fixes GEM SHMEM locking and generic fbdev hotplugging. Constifies dma_buf kobj type. The following changes since commit

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the >>> calling fbdev implementation. Avoids a possible stale mutex with >>> generic fbdev code. >>> >>>

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Thomas Zimmermann
Hi Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the calling fbdev implementation. Avoids a possible stale mutex with generic fbdev code. As indicated by its name, drm_fb_helper_prepare()

Re: [PATCH v12 10/10] drm/bridge: it6505: Register Type C mode switches

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:54PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the "lane_swap" > state based on the entered alternate mode for a specific Type-C > connector, which ends up

Re: [PATCH v12 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:49PM +0800, Pin-yen Lin wrote: > The output port endpoints can be connected to USB-C connectors. > Running drm_of_find_panel_or_bridge() with such endpoints leads to > a continuous return value of -EPROBE_DEFER, even though there is > no panel present. > > To avoid

Re: [PATCH v12 03/10] drm/display: Add Type-C switch helpers

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:47PM +0800, Pin-yen Lin wrote: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "reg"

Re: [PATCH v2 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-02-21 Thread Hans Verkuil
On 2/20/23 16:23, Dave Stevenson wrote: > Hi Hans > > On Sat, 18 Feb 2023 at 11:33, Hans Verkuil wrote: >> >> Hi Maxime, Dave, >> >> On 26/01/2023 14:46, Maxime Ripard wrote: >>> From: Dave Stevenson >>> >>> Copy Intel's "Broadcast RGB" property semantics to add manual override >>> of the HDMI

Re: [PATCH v2 1/9] drm/vc4: Switch to container_of_const

2023-02-21 Thread Maxime Ripard
Hi Hans, On Sat, Feb 18, 2023 at 11:45:04AM +0100, Hans Verkuil wrote: > > diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c > > index 86d629e45307..d0a00ed42cb0 100644 > > --- a/drivers/gpu/drm/vc4/vc4_bo.c > > +++ b/drivers/gpu/drm/vc4/vc4_bo.c > > @@ -609,7 +609,7 @@

Re: [PATCH v2 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-02-21 Thread Sebastian Wick
On Mon, Feb 20, 2023 at 4:24 PM Dave Stevenson wrote: > > Hi Hans > > On Sat, 18 Feb 2023 at 11:33, Hans Verkuil wrote: > > > > Hi Maxime, Dave, > > > > On 26/01/2023 14:46, Maxime Ripard wrote: > > > From: Dave Stevenson > > > > > > Copy Intel's "Broadcast RGB" property semantics to add manual

Re: [PATCH v12 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:50PM +0800, Pin-yen Lin wrote: > These two drivers embed a i2c_client in there private driver data, but > only strict device is actually needed. Replace the i2c_client reference > with a struct device one. LGTM, Reviewed-by: Andy Shevchenko > Signed-off-by: Pin-yen

Re: [PATCH v12 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:51PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant ports are available in Device Tree. Configure the crosspoint > switch based on the entered alternate mode for a specific Type-C > connector. > >

Re: [PATCH v12 01/10] device property: Add remote endpoint to devcon matcher

2023-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2023 at 05:50:45PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate

[Bug 217065] New: Linux 6.2.0 - AMDGPU cannot start, ends in a blank screen.

2023-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217065 Bug ID: 217065 Summary: Linux 6.2.0 - AMDGPU cannot start, ends in a blank screen. Product: Drivers Version: 2.5 Kernel Version: 6.2.0 Hardware: All

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-21 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the > calling fbdev implementation. Avoids a possible stale mutex with > generic fbdev code. > > As indicated by its name, drm_fb_helper_prepare() prepares struct > drm_fb_helper before setting up the fbdev

  1   2   >