[PATCH v4] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-22 Thread Alan Previn
MESA driver is creating protected context on every driver handle creation to query caps bits for app. So when running CI tests, they are observing hundreds of drm_errors when enabling PXP in .config but using SOC fusing or BIOS configuration that cannot support PXP sessions. The fixes tag

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-22 Thread Teres Alexis, Alan Previn
On Fri, 2023-03-17 at 13:37 +0200, Tamminen, Eero T wrote: > Hi, > > On 16.3.2023 10.50, Tvrtko Ursulin wrote: > > > [   11.674183] i915 :00:02.0: PXP init-arb-session-15 failed due > > > to BIOS/SOC:0x101a:ERR_PLATFORM_CONFIG > ... > > Alan - is this expected during normal operation on

Re: [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread Andi Shyti
Hi, > On 3/22/2023 12:44 PM, John Harrison wrote: > > On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: > > > Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to > > > always hit the GDRST register twice when doing a reset, with the > > > reported aim to fix invalid post-reset

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-09 03:00:45) > On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > > > > Maxime Ripard writes: > > > > > Hi, > > > > > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > > > > Assigning the parent clock in the DT works once, at

Re: (subset) [PATCH v6 01/17] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2023-03-22 Thread Heiko Stuebner
On Thu, 22 Dec 2022 15:22:14 +0100, Johan Jonker wrote: > Convert rockchip-lvds.txt to YAML. > > Changed: > Add power-domains property. > Requirements between PX30 and RK3288 > > > [...] Applied, thanks! [09/17] ARM: dts: rockchip: rk3288: fix dsi node commit:

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-07 07:26:03) > On Mon, Nov 07, 2022 at 12:06:07PM +, Mark Brown wrote: > > On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > > > On Fri, Nov 04, 2022 at 03:59:53PM +, Mark Brown wrote: > > > > > > Well, hopefully everyone for whom it's an

Re: [PATCH V2] drm/rockchip: vop2: Add error check to devm_regmap_init_mmio

2023-03-22 Thread Heiko Stuebner
Am Mittwoch, 22. März 2023, 23:44:11 CET schrieb Alfredo Cruz: > devm_regmap_init_mmio() may return an invalid pointer in case of an error. > This patch adds the corresponding IS_ERR check to vop2->map. > > Signed-off-by: Alfredo Cruz applied to drm-misc Thanks for the refresh Heiko

[RFC] drm/scheduler: Unwrap job dependencies

2023-03-22 Thread Rob Clark
From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap array or chain fences. Signed-off-by: Rob Clark --- tbh, I'm not sure why we weren't doing this already, unless there is something I'm

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-22 Thread Dmitry Baryshkov
On Wed, 22 Mar 2023 at 12:47, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "reg" properties are

Re: [PATCH] drm/rockchip: vop2: add error check to devm_regmap_init_mmio

2023-03-22 Thread Heiko Stuebner
Hi Alfredo, while I do agree with the patch content, there are missing: a patch description ... just a customary thing for a change like this but more importantly the Signed-off-by line . Heiko Am Dienstag, 14. März 2023, 20:15:32 CET schrieb Alfredo Cruz: > --- >

Re: [PATCH 32/32] drm/amdkfd: bump kfd ioctl minor version for debug api availability

2023-03-22 Thread Felix Kuehling
Am 2023-01-25 um 14:54 schrieb Jonathan Kim: Bump the minor version to declare debugging capability is now available. Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling This needs to be bumped to 1.13 once you rebase on the latest staging. With that fixed, the patch is Reviewed-by:

Re: [PATCH 31/32] drm/amdkfd: add debug device snapshot operation

2023-03-22 Thread Felix Kuehling
Am 2023-01-25 um 14:54 schrieb Jonathan Kim: Similar to queue snapshot, return an array of device information using an entry_size check and return. Unlike queue snapshots, the debugger needs to pass to correct number of devices that exist. If it fails to do so, the KFD will return the number of

Re: [PATCH 30/32] drm/amdkfd: add debug queue snapshot operation

2023-03-22 Thread Felix Kuehling
Am 2023-01-25 um 14:53 schrieb Jonathan Kim: Allow the debugger to get a snapshot of a specified number of queues containing various queue property information that is copied to the debugger. Since the debugger doesn't know how many queues exist at any given time, allow the debugger to pass

Re: [PATCH] drm: xlnx: zynqmp: Use dev_err_probe()

2023-03-22 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc3 next-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 27/32] drm/amdkfd: add debug set flags operation

2023-03-22 Thread Felix Kuehling
Am 2023-01-25 um 14:53 schrieb Jonathan Kim: Allow the debugger to set single memory and single ALU operations. Some exceptions are imprecise (memory violations, address watch) in the sense that a trap occurs only when the exception interrupt occurs and not at the non-halting faulty

Re: [PATCH] drm/nouveau/disp: More DP_RECEIVER_CAP_SIZE array fixes

2023-03-22 Thread Gustavo A. R. Silva
On 2/4/23 12:43, Kees Cook wrote: More arrays (and arguments) for dcpd were set to 16, when it looks like DP_RECEIVER_CAP_SIZE (15) should be used. Fix the remaining cases, seen with GCC 13: ../drivers/gpu/drm/nouveau/nvif/outp.c: In function 'nvif_outp_acquire_dp':

Re: [PATCH v2 1/2] drm/virtio: Refactor job submission code path

2023-03-22 Thread Dmitry Osipenko
On 3/23/23 00:25, Rob Clark wrote: ... >> +static int virtio_gpu_dma_fence_wait(struct virtio_gpu_submit *submit, >> +struct dma_fence *fence) >> +{ >> + struct dma_fence *itr; >> + int idx, err; >> + >> + dma_fence_array_for_each(itr, idx,

Re: [PATCH 26/32] drm/amdkfd: add debug set and clear address watch points operation

2023-03-22 Thread Felix Kuehling
Am 2023-01-25 um 14:53 schrieb Jonathan Kim: Shader read, write and atomic memory operations can be alerted to the debugger as an address watch exception. Allow the debugger to pass in a watch point to a particular memory address per device. Note that there exists only 4 watch points per

Re: [PATCH v2 1/2] drm/virtio: Refactor job submission code path

2023-03-22 Thread Rob Clark
On Sun, Mar 19, 2023 at 9:11 AM Dmitry Osipenko wrote: > > Move virtio_gpu_execbuffer_ioctl() into separate virtgpu_submit.c file > and refactor the code along the way to ease addition of new features to > the ioctl. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/virtio/Makefile

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/16/2023 3:06 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the GuC is occasionally observed where the GuC log actually showed that the GuC had loaded just fine. The implication being that the load just took ever so slightly longer than the 200ms timeout.

Re: [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread John Harrison
On 3/22/2023 13:59, Ceraolo Spurio, Daniele wrote: On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915

Re: [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to always hit the GDRST register twice when doing a reset, with the reported aim to fix invalid post-reset engine state on some

Re: [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 side we only need to apply this for full GT reset.

Re: [PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-22 Thread Rob Clark
On Tue, Mar 21, 2023 at 8:08 AM Randy Dunlap wrote: > > > > On 3/6/23 01:06, Geert Uytterhoeven wrote: > > With gcc-5 and CONFIG_UBSAN_SHIFT=y: > > > > drivers/gpu/drm/msm/msm_mdss.c: In function 'msm_mdss_enable': > > drivers/gpu/drm/msm/msm_mdss.c:296:2: error: case label does not

Re: Linux 6.3-rc3

2023-03-22 Thread Nathan Chancellor
On Wed, Mar 22, 2023 at 09:36:37AM -0700, Nathan Chancellor wrote: > On Wed, Mar 22, 2023 at 02:44:47PM +0200, Kalle Valo wrote: > > Nathan Chancellor writes: > > > > > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > > >> On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor > >

Re: [PATCH] drm/rockchip: vop2: fix uninitialized variable possible_crtcs

2023-03-22 Thread Heiko Stuebner
On Thu, 16 Mar 2023 09:23:02 -0400, Tom Rix wrote: > clang reportes this error > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:2322:8: error: > variable 'possible_crtcs' is used uninitialized whenever 'if' > condition is false [-Werror,-Wsometimes-uninitialized] > if

[PATCH AUTOSEL 4.14 9/9] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 4.14 6/9] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 4.14 8/9] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 4.14 7/9] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 4.14 4/9] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 4.19 8/9] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 4.19 9/9] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 4.19 7/9] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 4.19 6/9] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 4.19 4/9] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 5.4 9/9] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 5.4 8/9] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 5.4 7/9] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 5.4 6/9] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 5.4 4/9] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 5.10 10/12] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 5.10 08/12] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 5.10 09/12] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 5.10 07/12] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 5.10 05/12] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 5.15 13/16] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 5.15 11/16] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 5.15 12/16] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 5.15 10/16] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 5.15 08/16] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 6.1 31/34] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 6.1 30/34] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 6.1 29/34] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 6.1 28/34] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 6.1 26/34] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-22 Thread Sasha Levin
From: David Belanger [ Upstream commit 20bc9f76b6a2455c6b54b91ae7634f147f64987f ] Handle case when module is unloaded (kfd_exit) before a process space (mm_struct) is released. v2: Fixed potential race conditions by removing all kfd_process from the process table first, then working on

[PATCH AUTOSEL 6.1 22/34] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 6.1 18/34] drm/amdkfd: fix potential kgd_mem UAFs

2023-03-22 Thread Sasha Levin
From: Chia-I Wu [ Upstream commit 9da050b0d9e04439d225a2ec3044af70cdfb3933 ] kgd_mem pointers returned by kfd_process_device_translate_handle are only guaranteed to be valid while p->mutex is held. As soon as the mutex is unlocked, another thread can free the BO. Signed-off-by: Chia-I Wu

[PATCH AUTOSEL 6.1 17/34] drm/amdkfd: fix a potential double free in pqm_create_queue

2023-03-22 Thread Sasha Levin
From: Chia-I Wu [ Upstream commit b2ca5c5d416b4e72d1e9d0293fc720e2d525fd42 ] Set *q to NULL on errors, otherwise pqm_create_queue would free it again. Signed-off-by: Chia-I Wu Signed-off-by: Felix Kuehling Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 6.1 16/34] drm/amdkfd: Fix BO offset for multi-VMA page migration

2023-03-22 Thread Sasha Levin
From: Xiaogang Chen [ Upstream commit b4ee9606378bb9520c94d8b96f0305c3696f5c29 ] svm_migrate_ram_to_vram migrates a prange from sys ram to vram. The prange may cross multiple vma. Need remember current dst vram offset in the TTM resource for each migration. v2: squash in warning fix (Alex)

[PATCH AUTOSEL 6.2 41/45] fbdev: lxfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen Signed-off-by: Helge Deller Signed-off-by:

[PATCH AUTOSEL 6.2 42/45] fbdev: au1200fb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ] var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen

[PATCH AUTOSEL 6.2 39/45] fbdev: nvidia: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit 92e2a00f2987483e1f9253625828622edd442e61 ] variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in nvidiafb_set_par. Similar crashes have happened in other fbdev drivers. There is no check and modification on

[PATCH AUTOSEL 6.2 40/45] fbdev: intelfb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ] Variable var->pixclock is controlled by user and can be assigned to zero. Without proper check, divide by zero would occur in intelfbhw_validate_mode and intelfbhw_mode_to_hw. Error out if var->pixclock is zero.

[PATCH AUTOSEL 6.2 37/45] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-22 Thread Sasha Levin
From: David Belanger [ Upstream commit 20bc9f76b6a2455c6b54b91ae7634f147f64987f ] Handle case when module is unloaded (kfd_exit) before a process space (mm_struct) is released. v2: Fixed potential race conditions by removing all kfd_process from the process table first, then working on

[PATCH AUTOSEL 6.2 32/45] fbdev: tgafb: Fix potential divide by zero

2023-03-22 Thread Sasha Levin
From: Wei Chen [ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ] fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when

[PATCH AUTOSEL 6.2 28/45] drm/amd/display: Fix HDCP failing to enable after suspend

2023-03-22 Thread Sasha Levin
From: Bhawanpreet Lakha [ Upstream commit 728cefa53a36ba378ed4a7f31a0c08289687d824 ] [Why] On resume some displays are not ready for HDCP, so they will fail if we start the hdcp authentintication too soon. Add a delay so that the displays can be ready before we start. NOTE: Previoulsy this

[PATCH AUTOSEL 6.2 27/45] drm/amdkfd: fix potential kgd_mem UAFs

2023-03-22 Thread Sasha Levin
From: Chia-I Wu [ Upstream commit 9da050b0d9e04439d225a2ec3044af70cdfb3933 ] kgd_mem pointers returned by kfd_process_device_translate_handle are only guaranteed to be valid while p->mutex is held. As soon as the mutex is unlocked, another thread can free the BO. Signed-off-by: Chia-I Wu

[PATCH AUTOSEL 6.2 26/45] drm/amdgpu/vcn: custom video info caps for sriov

2023-03-22 Thread Sasha Levin
From: Jane Jian [ Upstream commit d71e38df3b730a17ab6b25cabb2ccfe8a7f04385 ] for sriov, we added a new flag to indicate av1 support, this will override the original caps info. Signed-off-by: Jane Jian Acked-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.2 24/45] drm/amdkfd: Fix BO offset for multi-VMA page migration

2023-03-22 Thread Sasha Levin
From: Xiaogang Chen [ Upstream commit b4ee9606378bb9520c94d8b96f0305c3696f5c29 ] svm_migrate_ram_to_vram migrates a prange from sys ram to vram. The prange may cross multiple vma. Need remember current dst vram offset in the TTM resource for each migration. v2: squash in warning fix (Alex)

[PATCH AUTOSEL 6.2 25/45] drm/amdkfd: fix a potential double free in pqm_create_queue

2023-03-22 Thread Sasha Levin
From: Chia-I Wu [ Upstream commit b2ca5c5d416b4e72d1e9d0293fc720e2d525fd42 ] Set *q to NULL on errors, otherwise pqm_create_queue would free it again. Signed-off-by: Chia-I Wu Signed-off-by: Felix Kuehling Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

Re: [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread John Harrison
On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to always hit the GDRST register twice when doing a reset, with the reported aim to fix invalid post-reset engine state on some platforms (Jasperlake being the only one actually

Re: [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread John Harrison
On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 side we only need to apply this for full GT reset. Given that we do full GT resets in the resume

Re: [PATCH 1/5] drm/tests: Test drm_rect_intersect()

2023-03-22 Thread Arthur Grillo Queiroz Cabral
On 22/03/23 11:26, Ville Syrjälä wrote: > On Wed, Mar 22, 2023 at 11:06:57AM -0300, Arthur Grillo wrote: >> Insert test for the drm_rect_intersect() function, it also create a >> helper for comparing drm_rects more easily. >> >> Signed-off-by: Arthur Grillo >> --- >>

Re: [PATCH v6 2/2] Documentation/gpu: Add Synaptics tiling formats documentation

2023-03-22 Thread kernel test robot
-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hsia-Jun-Li/drm-fourcc-Add

Re: Linux 6.3-rc3

2023-03-22 Thread Nick Desaulniers
+ Masahiro and linux-kbuild for the proposal On Wed, Mar 22, 2023 at 9:56 AM Linus Torvalds wrote: > > On Wed, Mar 22, 2023 at 9:40 AM Sedat Dilek wrote: > > > > You have to pass `make LLVM=1` in any case... to `oldconfig` or when > > adding any MAKEFLAGS like -j${number-of-available-cpus}. > >

Re: [PATCH] drm/display: Add missing OLED Vesa brightnesses definitions

2023-03-22 Thread Harry Wentland
On 3/22/23 12:05, Rodrigo Siqueira wrote: > Cc: Anthony Koo > Cc: Iswara Negulendran > Cc: Felipe Clark > Cc: Harry Wentland > Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Harry > --- > include/drm/display/drm_dp.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH v2] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

2023-03-22 Thread Neil Armstrong
Hi, On Wed, 22 Mar 2023 15:38:21 +0100, Francesco Dolcini wrote: > Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent > with what all the other DRM bridge drivers are doing and this is > required since the bridge might not be there when the driver is probed > and this should

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-22 Thread Neil Armstrong
Hi, On Mon, 06 Mar 2023 11:35:33 +0100, Johan Hovold wrote: > Make sure to unbind all subcomponents when binding the aggregate device > fails. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] drm/meson: fix missing component unbind on bind

[PATCH 11/12] drm/tegra: sor: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 00/12] drm/tegra: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
Hello, this series adapts the platform drivers below drivers/gpu/drm/tegra to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only

[PATCH 01/12] gpu: host1x: Make host1x_client_unregister() return void

2023-03-22 Thread Uwe Kleine-König
This function returned zero unconditionally. Make it return no value and simplify all callers accordingly. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tegra/dc.c | 7 +-- drivers/gpu/drm/tegra/dsi.c | 8 +--- drivers/gpu/drm/tegra/gr2d.c| 8

[PATCH 07/12] drm/tegra: gr3d: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 06/12] drm/tegra: gr2d: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 08/12] drm/tegra: hdmi: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 10/12] drm/tegra: nvdec: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 12/12] drm/tegra: vic: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 09/12] drm/tegra: hub: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 05/12] drm/tegra: dsi: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 02/12] drm/tegra: rgb: Make tegra_dc_rgb_remove() return void

2023-03-22 Thread Uwe Kleine-König
This function returned zero unconditionally. Make it return no value and simplify all callers accordingly. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tegra/dc.c | 7 +-- drivers/gpu/drm/tegra/dc.h | 2 +- drivers/gpu/drm/tegra/rgb.c | 6 ++ 3 files changed, 4 insertions(+),

[PATCH 03/12] drm/tegra: dc: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 04/12] drm/tegra: dpaux: Convert to platform remove callback returning void

2023-03-22 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

Re: Linux 6.3-rc3

2023-03-22 Thread Linus Torvalds
On Wed, Mar 22, 2023 at 9:40 AM Sedat Dilek wrote: > > You have to pass `make LLVM=1` in any case... to `oldconfig` or when > adding any MAKEFLAGS like -j${number-of-available-cpus}. I actually think we should look (again) at just making the compiler choice (and the prefix) be a Kconfig option.

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-22 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2023年3月21日 週二 下午8:19寫道: > > The hardware path of vdosys1 with DPTx output need to go through by several > modules, such as, OVL_ADAPTOR and MERGE. For this series, applied to mediatek-drm-next [1], thanks. [1]

Re: Linux 6.3-rc3

2023-03-22 Thread Sedat Dilek
On Wed, Mar 22, 2023 at 1:49 PM Kalle Valo wrote: > > Nathan Chancellor writes: > > > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > >> On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor > >> wrote: > >> > > >> > On the clang front, I am still seeing the following warning

Re: Linux 6.3-rc3

2023-03-22 Thread Nathan Chancellor
On Wed, Mar 22, 2023 at 02:44:47PM +0200, Kalle Valo wrote: > Nathan Chancellor writes: > > > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > >> On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor > >> wrote: > >> > > >> > On the clang front, I am still seeing the following

Re: [PATCH 7/7] accel/ivpu: Fix VPU clock calculation

2023-03-22 Thread Stanislaw Gruszka
On Wed, Mar 22, 2023 at 08:52:56AM -0600, Jeffrey Hugo wrote: > On 3/22/2023 3:19 AM, Stanislaw Gruszka wrote: > > VPU cpu clock frequency depends on the workpoint configuration > > that was granted by the punit. Previously driver was passing > > incorrect frequency to the VPU firmware. > > This

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-22 Thread Jani Nikula
On Wed, 22 Mar 2023, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: >> +#ifdef CONFIG_DRM_DISPLAY_DP_TYPEC_HELPER > > Ah, maybe this should use IS_REACHABLE() ? Personally, I think IS_REACHABLE() is a build-time band-aid solution to a problem that should be

[PATCH] drm/display: Add missing OLED Vesa brightnesses definitions

2023-03-22 Thread Rodrigo Siqueira
Cc: Anthony Koo Cc: Iswara Negulendran Cc: Felipe Clark Cc: Harry Wentland Signed-off-by: Rodrigo Siqueira --- include/drm/display/drm_dp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 632376c291db..d30a9b2f450c

Re: [PATCH v4 1/8] accel/qaic: Add documentation for AIC100 accelerator driver

2023-03-22 Thread Jeffrey Hugo
On 3/21/2023 10:39 PM, Bagas Sanjaya wrote: On Tue, Mar 21, 2023 at 03:52:11PM -0600, Jeffrey Hugo wrote: + +Request field descriptions: + +| req_id- request ID. A request FIFO element and a response FIFO element with +| the same request ID refer to the same command. + +| seq_id-

  1   2   3   >