[Bug 208611] amdgpu crash on sharing image memory between Vulkan and OpenGL

2023-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208611 Ivan Molodetskikh (yalt...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[drm-misc:for-linux-next 10/12] drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:422:31: warning: cast to pointer from integer of different size

2023-08-04 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 82d750e9d2f5d0594c8f7057ce59127e701af781 commit: 6b252cf42281045a9f803d2198023500cfa6ebd2 [10/12] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm config: mips-allyesconfig

Re: [PATCH 1/2] dt-bindings: display/msm: document DPU on SM7150

2023-08-04 Thread Rob Herring
On Thu, 03 Aug 2023 22:47:23 +0300, Danila Tikhonov wrote: > Document the DPU hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 116 ++ > 1 file changed, 116 insertions(+) > create mode

Re: nouveau bug in linux/6.1.38-2

2023-08-04 Thread Karol Herbst
On Fri, Aug 4, 2023 at 8:10 PM Olaf Skibbe wrote: > > Dear all, > > On Fri, 4 Aug 2023 at 14:15, Karol Herbst wrote: > > >>> 62aecf23f3d1 drm/nouveau: add nv_encoder pointer check for NULL > >>> fb725beca62d drm/nouveau/dp: check for NULL nv_connector->native_mode > >>> 90748be0f4f3 drm/nouveau:

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Javier Martinez Canillas
Randy Dunlap writes: Hello Randy, > On 8/4/23 05:51, Javier Martinez Canillas wrote: >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select FB_CORE', so any config that

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-08-04 Thread Kasireddy, Vivek
Hi David, > > > Right, the "the zero pages are changed into writable pages" in your > above comment just might not apply, because there won't be any > >> page > replacement (hopefully :) ). > >> > >>> If the page replacement does not happen when there are new >

[RFC] PM / QoS: Decouple request alloc from dev_pm_qos_mtx (alternative solution)

2023-08-04 Thread Rob Clark
From: Rob Clark Similar to the previous patch, move the allocation out from under dev_pm_qos_mtx, by speculatively doing the allocation and handle any race after acquiring dev_pm_qos_mtx by freeing the redundant allocation. Suggested-by: Rafael J. Wysocki Signed-off-by: Rob Clark --- This is

Re: [Intel-xe] [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-08-04 Thread Zanoni, Paulo R
On Fri, 2023-08-04 at 16:02 -0400, Rodrigo Vivi wrote: > On Wed, Jul 19, 2023 at 07:50:21PM +, Zanoni, Paulo R wrote: > > On Sat, 2023-07-15 at 17:45 +0200, Thomas Hellström wrote: > > > Add a motivation for and description of asynchronous VM_BIND operation > > > > I think I may have missed

[Bug 217764] New: nouveau: system hangs when changing pstate on GeForce GT 320M (NVAF (MCP89))

2023-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217764 Bug ID: 217764 Summary: nouveau: system hangs when changing pstate on GeForce GT 320M (NVAF (MCP89)) Product: Drivers Version: 2.5 Hardware: i386 OS: Linux

[RFC PATCH 09/10] drm/panel: sony-acx565akm: Don't double-check enabled state in disable

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 10/10] drm/panel: Update TODO list item for cleaning up prepared/enabled tracking

2023-08-04 Thread Douglas Anderson
Now that most panels have been updated not to track/double-check their prepared/enabled state update the TODO with next steps. Signed-off-by: Douglas Anderson --- Documentation/gpu/todo.rst | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git

[RFC PATCH 08/10] drm/panel: rm67191: Don't store+check enabled

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 07/10] drm/panel: st7703: Don't store+check prepared

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 06/10] drm/panel: Don't store+check prepared/enabled for panels disabled at shutdown

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 05/10] drm/panel: Don't store+check prepared/enabled for panels needing shutdown

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 03/10] drm/panel: otm8009a: Don't double check prepared/enabled

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-04 Thread Douglas Anderson
The goal of this file is to contain helper functions for panel drivers to use. To start off with, let's add drm_panel_helper_shutdown() for use by panels that want to make sure they're powered off at shutdown/remove time if they happen to be powered on. The main goal of introducting this function

[RFC PATCH 02/10] drm/panel: s6e63m0: Don't store+check prepared/enabled

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 01/10] drm/panel: Don't store+check prepared/enabled for simple cases

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

[RFC PATCH 00/10] drm/panel: Remove most store/double-check of prepared/enabled state

2023-08-04 Thread Douglas Anderson
As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is

Re: [PATCH 1/4] vgacon: rework Kconfig dependencies

2023-08-04 Thread Arnd Bergmann
On Tue, Aug 1, 2023, at 19:05, Russell King (Oracle) wrote: > On Fri, Jul 07, 2023 at 11:52:23AM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The list of dependencies here is phrased as an opt-out, but this is missing >> a lot of architectures that don't actually support VGA

Re: [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking

2023-08-04 Thread Rafael J. Wysocki
On Fri, Aug 4, 2023 at 10:38 PM Rob Clark wrote: > > On Fri, Aug 4, 2023 at 12:11 PM Rafael J. Wysocki wrote: > > > > On Fri, Aug 4, 2023 at 8:38 PM Rob Clark wrote: > > > > > > On Fri, Aug 4, 2023 at 10:07 AM Rafael J. Wysocki > > > wrote: > > > > > > > > On Fri, Aug 4, 2023 at 12:02 AM Rob

Re: [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking

2023-08-04 Thread Rob Clark
On Fri, Aug 4, 2023 at 12:11 PM Rafael J. Wysocki wrote: > > On Fri, Aug 4, 2023 at 8:38 PM Rob Clark wrote: > > > > On Fri, Aug 4, 2023 at 10:07 AM Rafael J. Wysocki wrote: > > > > > > On Fri, Aug 4, 2023 at 12:02 AM Rob Clark wrote: > > > > > > > > From: Rob Clark > > > > > > > > In the

Re: [Intel-xe] [RFC PATCH] Documentation/gpu: Draft VM_BIND locking document

2023-08-04 Thread Rodrigo Vivi
On Fri, Jun 30, 2023 at 06:44:52PM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and for

Re: [Intel-xe] [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-08-04 Thread Rodrigo Vivi
On Wed, Jul 19, 2023 at 07:50:21PM +, Zanoni, Paulo R wrote: > On Sat, 2023-07-15 at 17:45 +0200, Thomas Hellström wrote: > > Add a motivation for and description of asynchronous VM_BIND operation > > I think I may have missed some other documentation, which would explain > some of my

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Randy Dunlap
On 8/4/23 05:51, Javier Martinez Canillas wrote: > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has

Re: [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking

2023-08-04 Thread Rafael J. Wysocki
On Fri, Aug 4, 2023 at 8:38 PM Rob Clark wrote: > > On Fri, Aug 4, 2023 at 10:07 AM Rafael J. Wysocki wrote: > > > > On Fri, Aug 4, 2023 at 12:02 AM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > In the process of adding lockdep annotation for drm GPU scheduler's > > > job_run() to

Re: [git pull] drm fixes for 6.5-rc5

2023-08-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Aug 2023 15:07:56 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4142fc6743d39271e712936d9fb284cd84cb6010 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Jernej Škrabec
Dne petek, 04. avgust 2023 ob 16:27:06 CEST je Uwe Kleine-König napisal(a): > Instead of requiring each driver to care for assigning the owner member > of struct pwm_ops, handle that implicitly using a macro. Note that the > owner member has to be moved to struct pwm_chip, as the ops structure >

Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Florian Fainelli
On 8/4/23 07:27, Uwe Kleine-König wrote: Instead of requiring each driver to care for assigning the owner member of struct pwm_ops, handle that implicitly using a macro. Note that the owner member has to be moved to struct pwm_chip, as the ops structure usually lives in read-only memory and so

Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Andy Shevchenko
On Fri, Aug 4, 2023 at 5:28 PM Uwe Kleine-König wrote: > > Instead of requiring each driver to care for assigning the owner member > of struct pwm_ops, handle that implicitly using a macro. Note that the > owner member has to be moved to struct pwm_chip, as the ops structure > usually lives in

Re: [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking

2023-08-04 Thread Rob Clark
On Fri, Aug 4, 2023 at 10:07 AM Rafael J. Wysocki wrote: > > On Fri, Aug 4, 2023 at 12:02 AM Rob Clark wrote: > > > > From: Rob Clark > > > > In the process of adding lockdep annotation for drm GPU scheduler's > > job_run() to detect potential deadlock against shrinker/reclaim, I hit > > this

[PATCH drm-misc-next v10 12/12] drm/nouveau: debugfs: implement DRM GPU VA debugfs

2023-08-04 Thread Danilo Krummrich
Provide the driver indirection iterating over all DRM GPU VA spaces to enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces. Reviewed-by: Dave Airlie Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39 +++ 1 file changed, 39

[PATCH drm-misc-next v10 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-08-04 Thread Danilo Krummrich
This commit provides the implementation for the new uapi motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IOCTL_NOUVEAU_VM_INIT ioctl for UMDs to specify the portion of VA space managed by the kernel and

[PATCH drm-misc-next v10 10/12] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm

2023-08-04 Thread Danilo Krummrich
The new VM_BIND UAPI uses the DRM GPU VA manager to manage the VA space. Hence, we a need a way to manipulate the MMUs page tables without going through the internal range allocator implemented by nvkm/vmm. This patch adds a raw interface for nvkm/vmm to pass the resposibility for managing the

[PATCH drm-misc-next v10 09/12] drm/nouveau: chan: provide nouveau_channel_kill()

2023-08-04 Thread Danilo Krummrich
The new VM_BIND UAPI implementation introduced in subsequent commits will allow asynchronous jobs processing push buffers and emitting fences. If a job times out, we need a way to recover from this situation. For now, simply kill the channel to unblock all hung up jobs and signal userspace that

[PATCH drm-misc-next v10 08/12] drm/nouveau: fence: fail to emit when fence context is killed

2023-08-04 Thread Danilo Krummrich
The new VM_BIND UAPI implementation introduced in subsequent commits will allow asynchronous jobs processing push buffers and emitting fences. If a fence context is killed, e.g. due to a channel fault, jobs which are already queued for execution might still emit new fences. In such a case a job

[PATCH drm-misc-next v10 07/12] drm/nouveau: fence: separate fence alloc and emit

2023-08-04 Thread Danilo Krummrich
The new (VM_BIND) UAPI exports DMA fences through DRM syncobjs. Hence, in order to emit fences within DMA fence signalling critical sections (e.g. as typically done in the DRM GPU schedulers run_job() callback) we need to separate fence allocation and fence emitting. Reviewed-by: Dave Airlie

Re: [PATCH v2] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Harry Wentland
On 2023-08-04 14:20, Hamza Mahfooz wrote: > We should be checking to see if async flips are supported in > amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, > async flipping isn't supported if a plane's framebuffer changes memory > domains during an atomic commit. So,

[PATCH drm-misc-next v10 06/12] drm/nouveau: move usercopy helpers to nouveau_drv.h

2023-08-04 Thread Danilo Krummrich
Move the usercopy helpers to a common driver header file to make it usable for the new API added in subsequent commits. Reviewed-by: Dave Airlie Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_drv.h | 26 ++ drivers/gpu/drm/nouveau/nouveau_gem.c | 26

[PATCH drm-misc-next v10 05/12] drm/nouveau: bo: initialize GEM GPU VA interface

2023-08-04 Thread Danilo Krummrich
Initialize the GEM's DRM GPU VA manager interface in preparation for the (u)vmm implementation, provided by subsequent commits, to make use of it. Reviewed-by: Dave Airlie Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_bo.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH drm-misc-next v10 04/12] drm/nouveau: get vmm via nouveau_cli_vmm()

2023-08-04 Thread Danilo Krummrich
Provide a getter function for the client's current vmm context. Since we'll add a new (u)vmm context for UMD bindings in subsequent commits, this will keep the code clean. Reviewed-by: Dave Airlie Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-

[PATCH drm-misc-next v10 02/12] drm/nouveau: fixup the uapi header file.

2023-08-04 Thread Danilo Krummrich
From: Dave Airlie nouveau > 10 years ago had a plan for new multiplexer inside a multiplexer API using nvif. It never fully reached fruition, fast forward 10 years, and the new vulkan driver is avoiding libdrm and calling ioctls, and these 3 ioctls, getparam, channel alloc + free don't seem to

[PATCH drm-misc-next v10 03/12] drm/nouveau: new VM_BIND uAPI interfaces

2023-08-04 Thread Danilo Krummrich
This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs can provide a kernel reserved VA area. 2) Bind and unbind GPU VA space

[PATCH drm-misc-next v10 01/12] drm/gem: fix lockdep check for dma-resv lock

2023-08-04 Thread Danilo Krummrich
When no custom lock is set to protect a GEMs GPUVA list, lockdep checks should fall back to the GEM objects dma-resv lock. With the current implementation we're setting the lock_dep_map of the GEM objects 'resv' pointer (in case no custom lock_dep_map is set yet) on drm_gem_private_object_init().

[PATCH drm-misc-next v10 00/12] Nouveau VM_BIND UAPI & DRM GPUVA Manager (merged)

2023-08-04 Thread Danilo Krummrich
This patch series provides a new UAPI for the Nouveau driver in order to support Vulkan features, such as sparse bindings and sparse residency. Furthermore, with the DRM GPUVA manager it provides a new DRM core feature to keep track of GPU virtual address (VA) mappings in a more generic way

[PATCH v2] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Hamza Mahfooz
We should be checking to see if async flips are supported in amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, async flipping isn't supported if a plane's framebuffer changes memory domains during an atomic commit. So, move the check from dm_crtc_helper_atomic_check() to

Re: [PATCH] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Harry Wentland
On 2023-08-04 11:56, Hamza Mahfooz wrote: > We should be checking to see if async flips are supported in > amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, > async flipping isn't supported if a plane's framebuffer changes memory > domains during an atomic commit. So,

Re: [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking

2023-08-04 Thread Rafael J. Wysocki
On Fri, Aug 4, 2023 at 12:02 AM Rob Clark wrote: > > From: Rob Clark > > In the process of adding lockdep annotation for drm GPU scheduler's > job_run() to detect potential deadlock against shrinker/reclaim, I hit > this lockdep splat: > >

Re: [PATCH] drm/msm/a6xx: Fix GMU lockdep splat

2023-08-04 Thread Doug Anderson
Hi, On Thu, Aug 3, 2023 at 10:34 AM Rob Clark wrote: > > From: Rob Clark > > For normal GPU devfreq, we need to acquire the GMU lock while already > holding devfreq locks. But in the teardown path, we were calling > dev_pm_domain_detach() while already holding the GMU lock, resulting in > this

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Javier Martinez Canillas
Arthur Grillo writes: > On 04/08/23 09:51, Javier Martinez Canillas wrote: >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select FB_CORE', so any config that previously had

[PATCH 1/2] dt-bindings: display: newvision, nv3051d: Add Anbernic 351V Support

2023-08-04 Thread Chris Morgan
From: Chris Morgan Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag. Signed-off-by: Chris Morgan --- .../display/panel/newvision,nv3051d.yaml | 18 +++--- 1 file

[PATCH 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-08-04 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP kernel, but works fine with the same ones used in

[PATCH 0/2] Support Anbernic RG351V Panel

2023-08-04 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG351V panel. This panel is mostly identical to the one used in the 353 series, except it has a different panel ID when queried (0x4000 for the 351V, 0x3052 for the 353 panel) and will not work without the inclusion of the

Re: [PATCH] PCI/VGA: Make the vga_is_firmware_default() arch-independent

2023-08-04 Thread Bjorn Helgaas
On Fri, Aug 04, 2023 at 11:11:12AM +0800, suijingfeng wrote: > On 2023/8/3 20:25, kernel test robot wrote: > > Hi Sui, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on pci/next] > > [also build test ERROR on pci/for-linus linus/master v6.5-rc4

Re: [PATCH] drm/amdkfd: fix build failure without CONFIG_DYNAMIC_DEBUG

2023-08-04 Thread Felix Kuehling
On 2023-08-04 9:29, Arnd Bergmann wrote: From: Arnd Bergmann When CONFIG_DYNAMIC_DEBUG is disabled altogether, calling _dynamic_func_call_no_desc() does not work: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function 'svm_range_set_attr':

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Arthur Grillo
On 04/08/23 09:51, Javier Martinez Canillas wrote: > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has

[PATCH] drm/amd/display: ensure async flips are only accepted for fast updates

2023-08-04 Thread Hamza Mahfooz
We should be checking to see if async flips are supported in amdgpu_dm_atomic_check() (i.e. not dm_crtc_helper_atomic_check()). Also, async flipping isn't supported if a plane's framebuffer changes memory domains during an atomic commit. So, move the check from dm_crtc_helper_atomic_check() to

Re: [PATCH 1/2] drm: rcar-du: Add more formats to DRM_MODE_BLEND_PIXEL_NONE support

2023-08-04 Thread Laurent Pinchart
Hi Damian, (CC'ing Tomi) On Fri, Aug 04, 2023 at 11:49:32AM -0400, Damian Hobson-Garcia wrote: > On 2023/08/03 20:06, Laurent Pinchart wrote: > > On Fri, Aug 04, 2023 at 02:53:17AM +0300, Laurent Pinchart wrote: > >> On Fri, Aug 04, 2023 at 02:47:04AM +0300, Laurent Pinchart wrote: > >>> Hi

RE: [PATCH v4 1/1] drm/i915: Move abs_diff() to math.h

2023-08-04 Thread David Laight
From: Andrew Morton > Sent: 03 August 2023 18:25 > > On Thu, 3 Aug 2023 16:19:18 +0300 Andy Shevchenko > wrote: > > > abs_diff() belongs to math.h. Move it there. > > This will allow others to use it. > > > > ... > > > > --- a/include/linux/math.h > > +++ b/include/linux/math.h > > @@ -155,6

Re: [PATCH v2] drm/msm/dpu: Drop encoder vsync_event

2023-08-04 Thread Dmitry Baryshkov
On Wed, 02 Aug 2023 10:01:13 -0700, Jessica Zhang wrote: > Drop vsync_event and vsync_event_work handlers as they are unnecessary. > In addition drop the dpu_enc_ktime_template event class as it will be > unused after the vsync_event handlers are dropped. > > Applied, thanks! [1/1]

Re: [PATCH] drm/msm/dpu: clean up some inconsistent indenting

2023-08-04 Thread Dmitry Baryshkov
On Fri, 04 Aug 2023 15:57:46 +0800, Jiapeng Chong wrote: > No functional modification involved. > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:183 dpu_core_perf_crtc_check() > warn: inconsistent indenting. > > Applied, thanks! [1/1] drm/msm/dpu: clean up some inconsistent indenting

Re: [PATCH v5 0/8] drm/msm/dpu: change interrupts code to make 0 be the no IRQ

2023-08-04 Thread Dmitry Baryshkov
On Wed, 02 Aug 2023 13:04:18 +0300, Dmitry Baryshkov wrote: > Having an explicit init of interrupt fields to -1 for not existing IRQs > makes it easier to forget and/or miss such initialisation, resulting in > a wrong interrupt definition. > > Instead shift all IRQ indices to turn '0' to be the

Re: [PATCH] drm/msm/dpu: initialise clk_rate to 0 in _dpu_core_perf_get_core_clk_rate

2023-08-04 Thread Dmitry Baryshkov
On Fri, 04 Aug 2023 12:48:04 +0300, Dmitry Baryshkov wrote: > When removing the core perf tune overrides, I also occasionaly removed the > initialisation of the clk_rate variable. Initialise it to 0 to let max() > correctly calculate the maximum of requested clock rates. > > Applied, thanks!

Re: [PATCH] drm/msm/mdp5: Don't leak some plane state

2023-08-04 Thread Dmitry Baryshkov
On Thu, 03 Aug 2023 22:45:21 +0200, Daniel Vetter wrote: > Apparently no one noticed that mdp5 plane states leak like a sieve > ever since we introduced plane_state->commit refcount a few years ago > in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too > early by tracking commits,

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-04 Thread Imre Deak
On Fri, Aug 04, 2023 at 02:20:29PM +0800, Wayne Lin wrote: > [...] > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c > b/drivers/gpu/drm/display/drm_dp_mst_topology.c > index e04f87ff755a..4270178f95f6 100644 > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c > +++

Re: [PATCH v2 13/13] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-08-04 Thread Dmitry Baryshkov
On Fri, 28 Jul 2023 at 00:23, Rob Clark wrote: > > From: Rob Clark > > Since the revision becomes an opaque identifier with future GPUs, move > away from treating different ranges of bits as having a given meaning. > This means that we need to explicitly list different patch revisions in > the

[PATCH] drm/panel: simple: Fix AUO G121EAN01 panel timings according to the docs

2023-08-04 Thread Luca Ceresoli
Commit 03e909acd95a ("drm/panel: simple: Add support for AUO G121EAN01.4 panel") added support for this panel model, but the timings it implements are very different from what the datasheet describes. I checked both the G121EAN01.0 datasheet from [0] and the G121EAN01.4 one from [1] and they all

[PATCH] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-04 Thread Luca Ceresoli
This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical one mentioned on the documentation to avoid flickering on the unit tested. Testing on a different unit shows that the panel actually works with the

Re: [PATCH 1/4] drm/bridge: lt8912b: Fix bridge_detach

2023-08-04 Thread Robert Foss
On Fri, Aug 4, 2023 at 12:48 PM Tomi Valkeinen wrote: > > The driver calls lt8912_bridge_detach() from its lt8912_remove() > function. As the DRM core detaches bridges automatically, this leads to > calling lt8912_bridge_detach() twice. The code probably has tried to > manage the double-call with

Re: [PATCH 2/4] drm/bridge: lt8912b: Fix crash on bridge detach

2023-08-04 Thread Robert Foss
On Fri, Aug 4, 2023 at 12:48 PM Tomi Valkeinen wrote: > > The lt8912b driver, in its bridge detach function, calls > drm_connector_unregister() and drm_connector_cleanup(). > > drm_connector_unregister() should be called only for connectors > explicitly registered with drm_connector_register(),

Re: [PATCH] drm/msm/dpu: initialise clk_rate to 0 in _dpu_core_perf_get_core_clk_rate

2023-08-04 Thread Abhinav Kumar
On 8/4/2023 2:48 AM, Dmitry Baryshkov wrote: When removing the core perf tune overrides, I also occasionaly removed the initialisation of the clk_rate variable. Initialise it to 0 to let max() correctly calculate the maximum of requested clock rates. Reported-by: Dan Carpenter Fixes:

Re: [PATCH 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-04 Thread kernel test robot
Hi Wayne, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.5-rc4 next-20230804] [cannot apply to drm-intel/for-linux-next] [If your patch is applied

Re: [PATCH 0/5 v4] accel/qaic: Improve bounds checking in encode/decode

2023-08-04 Thread Jeffrey Hugo
On 7/12/2023 12:30 AM, Dan Carpenter wrote: On Tue, Jul 11, 2023 at 11:33:25AM -0600, Jeffrey Hugo wrote: On 7/11/2023 2:20 AM, Dan Carpenter wrote: Fixed in v4: Send the correct [PATCH 1/5] patch. Fixed in v3: Redo messed up threading Fixed two things in v2: Include the file. Change the

Re: [PATCH 2/2] drm/panel-simple: Add Innolux G156HCE-L01 panel entry

2023-08-04 Thread Luca Ceresoli
Hi Marek, Neil, On Fri, 4 Aug 2023 10:19:12 +0200 Luca Ceresoli wrote: > Hi Marek, > > On Thu, 3 Aug 2023 19:10:35 +0200 > Marek Vasut wrote: > > > On 8/3/23 17:06, Luca Ceresoli wrote: > > > Hi Marek, > > > > > > On Thu, 3 Aug 2023 16:25:37 +0200 > > > Marek Vasut wrote: > > > > >

[PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Uwe Kleine-König
Instead of requiring each driver to care for assigning the owner member of struct pwm_ops, handle that implicitly using a macro. Note that the owner member has to be moved to struct pwm_chip, as the ops structure usually lives in read-only memory and so cannot be modified. The upside is that new

[PATCH v2 0/2] pwm: Manage owner assignment implicitly for drivers

2023-08-04 Thread Uwe Kleine-König
Hello, (implicit) v1 of this series can be found at https://lore.kernel.org/linux-pwm/20230803140633.138165-1-u.kleine-koe...@pengutronix.de . Changes since then only affect documentation that I missed to adapt before. Thanks to Laurent for catching that Best regards Uwe Uwe Kleine-König (2):

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-04 Thread Matthew Brost
On Fri, Aug 04, 2023 at 10:50:36AM +0200, Daniel Vetter wrote: > On Thu, Aug 03, 2023 at 11:35:30AM +0200, Christian König wrote: > > Am 03.08.23 um 10:58 schrieb Daniel Vetter: > > > On Thu, 3 Aug 2023 at 10:53, Christian König > > > wrote: > > > > Am 01.08.23 um 22:50 schrieb Matthew Brost: >

Re: [PATCH 2/2] drm/framebuffer: Fix use of uninitialized variable

2023-08-04 Thread Laurent Pinchart
On Fri, Aug 04, 2023 at 01:57:40PM +0300, Tomi Valkeinen wrote: > smatch reports: > > drivers/gpu/drm/drm_framebuffer.c:654 drm_mode_getfb2_ioctl() error: > uninitialized symbol 'ret'. > > 'ret' is possibly not set when there are no errors, causing the error > above. I can't say if that ever

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Javier Martinez Canillas
"Arnd Bergmann" writes: > On Fri, Aug 4, 2023, at 15:07, Daniel Vetter wrote: >> On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas >> wrote: >>> >>> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >>> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-04 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Thomas Zimmermann writes: > [...] >> The reasoning is that userspace should always be in control of the >> format (sans that one exception). If userspace wants packed 24-bits it >> can support RGB888 explicitly. For the color-format transformation, >>

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Dmitry Baryshkov
On Fri, 4 Aug 2023 at 16:44, Sebastian Wick wrote: > > On Fri, Aug 4, 2023 at 3:27 PM Dmitry Baryshkov > wrote: > > > > On Fri, 28 Jul 2023 at 20:03, Jessica Zhang > > wrote: > > > > > > Document and add support for solid_fill property to drm_plane. In > > > addition, add support for setting

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Arnd Bergmann
On Fri, Aug 4, 2023, at 15:07, Daniel Vetter wrote: > On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas > wrote: >> >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select

Re: [PATCH 1/2] drm/drm_file: fix use of uninitialized variable

2023-08-04 Thread Laurent Pinchart
On Fri, Aug 04, 2023 at 01:57:39PM +0300, Tomi Valkeinen wrote: > smatch reports: > > drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized > symbol 'supported_status'. > > 'supported_status' is only set in one code path. I'm not familiar with > the code to say if that

Re: Bug#1042753: nouveau bug in linux/6.1.38-2

2023-08-04 Thread Diederik de Haas
On Friday, 4 August 2023 15:11:46 CEST Olaf Skibbe wrote: > (On the occasion a maybe silly question: am I right assuming that the > kernel has to be build on the machine we want to reproduce the bug on? > Otherwise it could use much faster hardware (running also bookworm).) If that is also an

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 Jose Roberto (colombo...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:27 PM Dmitry Baryshkov wrote: > > On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: > > > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Mon, Jul 31, 2023 at 6:01 AM Dmitry Baryshkov wrote: > > On 28/07/2023 20:02, Jessica Zhang wrote: > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill planes, userspace

Re: [PATCH v2 3/4] drm/panel: sitronix-st7789v: add support for partial mode

2023-08-04 Thread Maxime Ripard
On Fri, Aug 04, 2023 at 03:02:34PM +0200, Michael Riesch wrote: > The ST7789V controller features support for the partial mode. Here, > the area to be displayed can be restricted in one direction (by default, > in vertical direction). This is useful for panels that are partially > occluded by

[PATCH] drm/amdkfd: fix build failure without CONFIG_DYNAMIC_DEBUG

2023-08-04 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_DYNAMIC_DEBUG is disabled altogether, calling _dynamic_func_call_no_desc() does not work: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c: In function 'svm_range_set_attr': drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:52:9: error: implicit declaration of

Re: [PATCH v2 0/4] drm/panel: sitronix-st7789v: add support for partial mode

2023-08-04 Thread Neil Armstrong
Hi, On Fri, 04 Aug 2023 15:02:31 +0200, Michael Riesch wrote: > This series adds support for the partial display mode to the Sitronix > ST7789V panel driver. This is useful for panels that are partially > occluded by design, such as the Jasonic JT240MHQS-HWT-EK-E3. Support > for this particular

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Dmitry Baryshkov
On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: > > Document and add support for solid_fill property to drm_plane. In > addition, add support for setting and getting the values for solid_fill. > > To enable solid fill planes, userspace must assign a property blob to > the "solid_fill" plane

Re: [PATCH] drm/msm/dpu: clean up some inconsistent indenting

2023-08-04 Thread Dmitry Baryshkov
On Fri, 4 Aug 2023 at 10:57, Jiapeng Chong wrote: > > No functional modification involved. > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:183 dpu_core_perf_crtc_check() > warn: inconsistent indenting. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6096

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. In addition, force pixel_source to > DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break > legacy userspace. > > This enum property will allow

Re: [PATCH v2] drm/msm/dpu: Drop encoder vsync_event

2023-08-04 Thread Dmitry Baryshkov
On Wed, 2 Aug 2023 at 20:01, Jessica Zhang wrote: > > Drop vsync_event and vsync_event_work handlers as they are unnecessary. > In addition drop the dpu_enc_ktime_template event class as it will be > unused after the vsync_event handlers are dropped. > > Signed-off-by: Jessica Zhang > --- >

Re: [PATCH v2 4/4] drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support

2023-08-04 Thread Neil Armstrong
On 04/08/2023 15:02, Michael Riesch wrote: The Jasonic JT240MHQS-HWT-EK-E3 is a custom panel using the Sitronix ST7789V controller. While the controller features a resolution of 320x240, only an area of 280x240 is visible by design. Signed-off-by: Michael Riesch ---

Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

2023-08-04 Thread Daniel Vetter
On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas wrote: > > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n

Re: [PATCH v2 3/4] drm/panel: sitronix-st7789v: add support for partial mode

2023-08-04 Thread Neil Armstrong
On 04/08/2023 15:02, Michael Riesch wrote: The ST7789V controller features support for the partial mode. Here, the area to be displayed can be restricted in one direction (by default, in vertical direction). This is useful for panels that are partially occluded by design. Add support for the

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-04 Thread Daniel Vetter
On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

[PATCH v2 2/4] dt-bindings: display: st7789v: add jasonic jt240mhqs-hwt-ek-e3 display

2023-08-04 Thread Michael Riesch
Add compatible for the Jasonic Technology Ltd. JT240MHQS-HWT-EK-E3 display. Acked-by: Conor Dooley Signed-off-by: Michael Riesch --- Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

  1   2   3   >