Re: [PATCH 2/2] Revert "drm/omapdrm: Annotate dma-fence critical section in commit path"

2023-10-02 Thread Aradhya Bhatia
On 20-Sep-23 18:27, Tomi Valkeinen wrote: > This reverts commit 250aa22920cd5d956a5d3e9c6a43d671c2bae217. > > The DMA-fence annotations cause a lockdep warning (see below). As per > https://patchwork.freedesktop.org/patch/462170/ it sounds like the > annotations don't work correctly. > >

Re: [RESEND PATCH v6 17/20] drm/mediatek: Support MT8188 Padding in display driver

2023-10-02 Thread 宋孝謙

Re: [PATCH v6 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP

2023-10-02 Thread Manikandan.M
On 28/09/23 11:31 am, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, Manikandan, > > On 27.09.2023 12:47, Manikandan Muralidharan wrote: >> +void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, >> +

Re: [PATCH v2] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2023-10-02 Thread Zack Rusin
On Mon, 2023-10-02 at 16:27 +0200, Thomas Hellström wrote: > !! External Email > > On Mon, 2023-10-02 at 10:16 +0200, Thomas Hellström wrote: > > Hi, Zack > > > > On 9/26/23 19:51, Zack Rusin wrote: > > > From: Zack Rusin > > > > > > Some drivers require the mapped tt pages to be decrypted. In

Re: [PATCH v10 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-02 Thread 林睿祥

Re: [PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA

2023-10-02 Thread 何宗原
On Fri, 2023-09-22 at 16:46 +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 03:21:05PM +0800, Moudy Ho wrote: > > Support for MT8195 RDMA has been added, allowing for > > the configuration of multiple MDP3 pipes. > > Furthermore, this particular device does not require > > sharing SRAM with

Re: [PATCH v6 02/16] dt-bindings: media: mediatek: mdp3: split out general properties

2023-10-02 Thread 何宗原
On Sat, 2023-09-23 at 18:42 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 22/09/2023 09:21, Moudy Ho wrote: > > In order to minimize duplication and standardize the document >

Re: [PATCH v8 2/5] drm/panfrost: Add fdinfo support GPU load metrics

2023-10-02 Thread kernel test robot
Hi Adrián, kernel test robot noticed the following build warnings: [auto build test WARNING on f45acf7acf75921c0409d452f0165f51a19a74fd] url: https://github.com/intel-lab-lkp/linux/commits/Adri-n-Larumbe/drm-panfrost-Add-cycle-count-GPU-register-definitions/20230930-041528 base:

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-02 Thread Abhinav Kumar
On 10/2/2023 3:58 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2023-09-28 17:46:11) On 9/27/2023 3:01 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2023-09-25 09:07:18) However for external DP case, link training can not be guarantee always success without link rate or lane being

[RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-10-02 Thread Dongwon Kim
Having a fence linked to a virtio_gpu_framebuffer in the plane update sequence would cause conflict when several planes referencing the same framebuffer (e.g. Xorg screen covering multi-displays configured for an extended mode) and those planes are updated concurrently. So it is needed to allocate

[RFC PATCH v2 0/1] fence per plane state

2023-10-02 Thread Dongwon Kim
The patch "drm/virtio: new fence for every plane update" is to prevent a fence synchronization problem when multiple planes are referencing a single large FB (i.e. Xorg with multi displays configured as one extended surface.). One example of a possible problematic flow is

[PATCH v2 6/6] arm64: dts: qcom: sdm670: add display subsystem

2023-10-02 Thread Richard Acayan
The Snapdragon 670 has a display subsystem for controlling and outputting to the display. Add support for it in the device tree. Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670.dtsi | 294 +++ 1 file changed, 294 insertions(+) diff --git

[PATCH v2 5/6] drm/msm/dpu: Add hw revision 4.1 (SDM670)

2023-10-02 Thread Richard Acayan
The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Since revision 4.0 is SDM845, reuse some configuration from its catalog entry. Link:

[PATCH v2 4/6] drm/msm: mdss: add support for SDM670

2023-10-02 Thread Richard Acayan
Add support for the MDSS block on the SDM670 platform. Signed-off-by: Richard Acayan --- drivers/gpu/drm/msm/msm_mdss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 2e87dd6cb17b..2afb843271aa 100644 ---

[PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-02 Thread Richard Acayan
Add documentation for the SDM670 display subsystem, adapted from the SDM845 and SM6125 documentation. Signed-off-by: Richard Acayan --- .../display/msm/qcom,sdm670-mdss.yaml | 287 ++ 1 file changed, 287 insertions(+) create mode 100644

[PATCH v2 2/6] dt-bindings: display/msm: sdm845-dpu: Describe SDM670

2023-10-02 Thread Richard Acayan
The SDM670 display controller has the same requirements as the SDM845 display controller, despite having distinct properties as described in the catalog. Add the compatible for SDM670 to the SDM845 controller. Acked-by: Rob Herring Signed-off-by: Richard Acayan ---

[PATCH v2 1/6] dt-bindings: display/msm: dsi-controller-main: add SDM670 compatible

2023-10-02 Thread Richard Acayan
The SDM670 has DSI ports. Add the compatible for the controller. Acked-by: Rob Herring Signed-off-by: Richard Acayan --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 0/6] SDM670 display subsystem support

2023-10-02 Thread Richard Acayan
Changes since v1 (20230925232625.84-9-mailingrad...@gmail.com): - prefix dsi1 labels with `mdss_` in example dts (3/6) - make all parts of catalog entry const (5/6) - add spaces before closing brackets on same line (5/6) - join opening and closing braces on the same line in dsc array (5/6)

[PATCH 2/3] drm/fourcc: fix doc typos

2023-10-02 Thread Randy Dunlap
Correct spelling and remove an extraneous word. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_fourcc.h | 12 ++-- 1 file changed, 6

[PATCH 1/3] drm/uapi: drm_mode: fix doc typos

2023-10-02 Thread Randy Dunlap
Correct grammar (add s for plural, insert "the"). Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_mode.h |6 +++--- 1 file changed, 3 insertions(+),

[PATCH 3/3] drm/rect: fix kernel-doc typos

2023-10-02 Thread Randy Dunlap
Correct typos of "translated". Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/drm/drm_rect.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [PATCH] drm/bridge: ti-sn65dsi86: Associate DSI device lifetime with auxiliary device

2023-10-02 Thread Doug Anderson
Hi, On Mon, Oct 2, 2023 at 4:54 PM Stephen Boyd wrote: > > The kernel produces a warning splat and the DSI device fails to register > in this driver if the i2c driver probes, populates child auxiliary > devices, and then somewhere in ti_sn_bridge_probe() a function call > returns -EPROBE_DEFER.

Re: [PATCH v17 13/18] drm/shmem-helper: Add memory shrinker

2023-10-02 Thread Dmitry Osipenko
On 9/26/23 10:35, Boris Brezillon wrote: + __drm_gem_shmem_release_pages(shmem); >>> Make sure you drop the implicit pages_use_count ref the sgt had, this >>> way you can still tie the necessity to drop the pages to sgt != NULL in >>> drm_gem_shmem_free(). >> This will require further

Re: [PATCH 1/2] Revert "drm/tidss: Annotate dma-fence critical section in commit path"

2023-10-02 Thread Aradhya Bhatia
On 20-Sep-23 18:27, Tomi Valkeinen wrote: > This reverts commit 4d56a4f08391857ba93465de489707b66adad114. > > The DMA-fence annotations cause a lockdep warning (see below). As per > https://patchwork.freedesktop.org/patch/462170/ it sounds like the > annotations don't work correctly. > >

linux-next: manual merge of the drm-intel tree with the drm tree

2023-10-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commits: c9517783060a ("drm/i915/dg2: Drop Wa_16011777198") 5a213086a025 ("drm/i915: Eliminate IS_MTL_GRAPHICS_STEP") 81af8abe6513 ("drm/i915: Eliminate IS_MTL_MEDIA_STEP")

[PATCH] drm/bridge: ti-sn65dsi86: Associate DSI device lifetime with auxiliary device

2023-10-02 Thread Stephen Boyd
The kernel produces a warning splat and the DSI device fails to register in this driver if the i2c driver probes, populates child auxiliary devices, and then somewhere in ti_sn_bridge_probe() a function call returns -EPROBE_DEFER. When the auxiliary driver probe defers, the dsi device created by

Re: [PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-10-02 Thread Chris Morgan
On Mon, Oct 02, 2023 at 01:33:03PM -0700, Jessica Zhang wrote: > > > On 10/2/2023 12:30 PM, Chris Morgan wrote: > > From: Chris Morgan > > > > Add support for the Anbernic 351V. Just like the 353 series the > > underlying vendor is unknown/unmarked (at least not visible in a > >

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-02 Thread Stephen Boyd
Quoting Abhinav Kumar (2023-09-28 17:46:11) > On 9/27/2023 3:01 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2023-09-25 09:07:18) > >> > >> However for external DP case, link training can not be guarantee always > >> success without link rate or lane being reduced as Abhinav mentioned. > >> >

Re: [PATCH v4 5/8] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-02 Thread Kuogee Hsieh
On 9/27/2023 2:41 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This lead to msm edp panel can not be detected by edp_panel driver at generic_edp_panel_probe() due to aux dpcd read failed at

Re: [PATCH v4 5/8] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-02 Thread Kuogee Hsieh
On 9/27/2023 2:41 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This lead to msm edp panel can not be detected by edp_panel driver at generic_edp_panel_probe() due to aux dpcd read failed at

Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Phillip Potter
> From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information

Re: [PATCH 5/6] drm/msm/dpu: Add hw revision 4.1 (SDM670)

2023-10-02 Thread Richard Acayan
On Mon, Sep 25, 2023 at 07:26:32PM -0400, Richard Acayan wrote: > The Snapdragon 670 uses similar clocks (with one frequency added) to the > Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU > with configuration from the Pixel 3a downstream kernel. > > Since revision 4.0 is

[PATCH v4] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

2023-10-02 Thread Niko Tsirakis
This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", followed by link training errors. Intel engineers recommended increasing this timeout and that does resolve the issue. On some CometLake-based device designs the Parade PS175 takes more than 400ms to settle in PCON mode. 100

Re: [PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-10-02 Thread Jessica Zhang
On 10/2/2023 12:30 PM, Chris Morgan wrote: From: Chris Morgan Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP

Re: [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V

2023-10-02 Thread Conor Dooley
On Mon, Oct 02, 2023 at 02:30:15PM -0500, Chris Morgan wrote: > From: Chris Morgan > > Document the Anbernic RG351V panel, which is identical to the panel > used in their 353 series except for in inclusion of an additional DSI > format flag. > > Signed-off-by: Chris Morgan Acked-by: Conor

[PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-10-02 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP kernel, but works fine with the same ones used in

[PATCH V3 1/2] dt-bindings: display: newvision, nv3051d: Add Anbernic 351V

2023-10-02 Thread Chris Morgan
From: Chris Morgan Document the Anbernic RG351V panel, which is identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag. Signed-off-by: Chris Morgan --- .../devicetree/bindings/display/panel/newvision,nv3051d.yaml | 5 ++--- 1 file changed, 2

[PATCH V3 0/2] Support Anbernic RG351V Panel

2023-10-02 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG351V panel. This panel is mostly identical to the one used in the 353 series, except it has a different panel ID when queried (0x4000 for the 351V, 0x3052 for the 353 panel) and will not work without the inclusion of the

Re: [PATCH v17 13/18] drm/shmem-helper: Add memory shrinker

2023-10-02 Thread Dmitry Osipenko
On 9/26/23 10:35, Boris Brezillon wrote: >> On 9/15/23 11:46, Boris Brezillon wrote: >>> The naming becomes quite confusing, with drm_gem_shmem_unpin_locked() >>> and drm_gem_shmem_unpin_pages_locked(). By the look of it, it seems to >>> do exactly the opposite of drm_gem_shmem_swapin_locked(),

Re: [PATCH v2 1/3] drm/nouveau: chan: use struct nvif_mclass

2023-10-02 Thread Lyude Paul
For the whole series: Reviewed-by: Lyude Paul On Mon, 2023-10-02 at 15:46 +0200, Danilo Krummrich wrote: > Use actual struct nvif_mclass instead of identical anonymous struct. > > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_chan.c | 5 + > 1 file changed, 1

RE: [PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-10-02 Thread Biju Das
Hi Rob, > Subject: Re: [PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L > DU bindings > > > On Mon, 02 Oct 2023 13:27:37 +0100, Biju Das wrote: > > The RZ/G2L LCD controller is composed of Frame Compression Processor > > (FCPVD), Video Signal Processor (VSPD), and Display Unit

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 08:11:41PM +0200, Christian König wrote: > Am 02.10.23 um 20:08 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > > > Am 02.10.23 um 18:53 schrieb Kees Cook: > > > > On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > > >

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 20:08 schrieb Kees Cook: On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > Am 02.10.23 um 18:53 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > > > On Mon, Oct 2, 2023 at 5:20 AM Christian König > > > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > > >

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm

Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

2023-10-02 Thread Helen Koike
On 02/10/2023 13:47, Rob Clark wrote: From: Rob Clark Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm driver to not probe on devices that use panel-edp. Signed-off-by: Rob Clark Thank you a lot! Now sc7180, apq8096 and sdm845 are probing! Tested-by: Helen Koike

Re: [PATCH] dma-buf: heaps: Fix off by one in cma_heap_vm_fault()

2023-10-02 Thread T.J. Mercier
On Mon, Oct 2, 2023 at 12:04 AM Dan Carpenter wrote: > > The buffer->pages[] has "buffer->pagecount" elements so this > comparison > has to be changed to >= to avoid reading beyond the end of the array. > The buffer->pages[] array is allocated in cma_heap_allocate(). > > Fixes: a5d2d29e24be

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > On Mon, Oct 2, 2023 at 5:20 AM Christian König > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > > >> This is a batch of patches touching drm for preparing for the

[PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

2023-10-02 Thread Rob Clark
From: Rob Clark Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm driver to not probe on devices that use panel-edp. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/arm.config | 1 + drivers/gpu/drm/ci/arm64.config | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH] dma-buf: add dma_fence_timestamp helper

2023-10-02 Thread Alex Deucher
On Sat, Sep 30, 2023 at 7:06 PM Christian König wrote: > > When a fence signals there is a very small race window where the timestamp > isn't updated yet. sync_file solves this by busy waiting for the > timestamp to appear, but on other ocassions didn't handled this > correctly. > > Provide a

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-02 Thread kernel test robot
: a4ead6e37e3290cff399e2598d75e98777b69b37 patch link: https://lore.kernel.org/r/20230928191624.13703-5-dakr%40redhat.com patch subject: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects reproduce: (https://download.01.org/0day-ci/archive/20231002/202310022331.lpoa8krt

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
On pondělí 2. října 2023 16:32:45 CEST Matthew Wilcox wrote: > On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > > > > > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > > > > > > > > > > > Corrupted memory at 0xe173a294 [ ! ! ! ! ! ! ! ! ! ! ! !

DPMS problems with radeon card and dual monitor setup

2023-10-02 Thread Jeff Layton
I have been seeing problems when my displays go to sleep for a couple of releases now. I have a dual monitor setup and a single AMD RX 6600 card. When I leave for a bit and come back, often all of my windows have been shuffled to the secondary monitor, and sometimes GNOME designates that monitor

Re: ti-sn65dsi86 linux driver using dsi clock source for pll

2023-10-02 Thread Doug Anderson
Hi, On Sat, Sep 30, 2023 at 4:41 AM Douglas Cooper wrote: > > Hi Doug > > That’s really good feedback. Thanks so much for taking the time to outline > that. I’ll keep investigating and dig into those areas you mentioned. > > I should have mentioned I’m also using the chip in conjunction with a

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Alex Deucher
On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute.

Re: [PATCH] dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'

2023-10-02 Thread Rob Herring
On Sat, 30 Sep 2023 10:01:02 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > fsl,imx6-hdmi.yaml makes a reference to synopsys,dw-hdmi.yaml. > > The 'interrupts'and 'reg' properties are described in synopsys,dw-hdmi.yaml, > so use 'unevaluatedProperties: false' so that these two

Re: [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Hi Andi, On 10/2/2023 3:45 PM, Andi Shyti wrote: Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Nirmoy Das
+dri-devel On 10/2/2023 4:07 PM, Jonathan Cavitt wrote: From: Chris Wilson With multi-GT devices, the object may have been bound on each GT and so we need to invalidate the TLBs across all GT before releasing the pages back to the system. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs

Re: [PATCH v2 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Steve Wahl
On Mon, Oct 02, 2023 at 10:55:28AM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Matthew Wilcox
On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > > > > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > > > > > > > > > Corrupted memory at 0xe173a294 [ ! ! ! ! ! ! ! ! ! ! ! ! ! ! > > > > > ! ! ] (in kfence-#108): > > > > >

Re: [PATCH v2] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2023-10-02 Thread Thomas Hellström
On Mon, 2023-10-02 at 10:16 +0200, Thomas Hellström wrote: > Hi, Zack > > On 9/26/23 19:51, Zack Rusin wrote: > > From: Zack Rusin > > > > Some drivers require the mapped tt pages to be decrypted. In an > > ideal > > world this would have been handled by the dma layer, but the TTM > > page > >

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 10/2/23 12:48, Michel Dänzer wrote: > On 10/2/23 12:05, Michel Dänzer wrote: >> On 9/29/23 22:41, Hamza Mahfooz wrote: >>> From: Ivan Lipski >>> >>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >>> >>> Since, it causes the following IGT tests to fail: >>>

Re: [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread David Ahern
On 10/2/23 2:55 AM, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory

[PATCH v2 3/3] drm/nouveau: exec: report max pushs through getparam

2023-10-02 Thread Danilo Krummrich
Report the maximum number of IBs that can be pushed with a single DRM_IOCTL_NOUVEAU_EXEC through DRM_IOCTL_NOUVEAU_GETPARAM. While the maximum number of IBs per ring might vary between chipsets, the kernel will make sure that userspace can only push a fraction of the maximum number of IBs per

[PATCH v2 2/3] drm/nouveau: chan: use channel class definitions

2023-10-02 Thread Danilo Krummrich
Use channel class definitions instead of magic numbers. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_chan.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c b/drivers/gpu/drm/nouveau/nouveau_chan.c index

[PATCH v2 1/3] drm/nouveau: chan: use struct nvif_mclass

2023-10-02 Thread Danilo Krummrich
Use actual struct nvif_mclass instead of identical anonymous struct. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_chan.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.c

Re: [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Andi Shyti
Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: > Don't return early if one of the GT doesn't require > any flushing. > > Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") > Cc: Chris Wilson > Cc: Fei Yang > Cc: Mauro Carvalho Chehab > Cc: Andi Shyti >

Re: [PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-10-02 Thread Rob Herring
On Mon, 02 Oct 2023 13:27:37 +0100, Biju Das wrote: > The RZ/G2L LCD controller is composed of Frame Compression Processor > (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). > > The DU module supports the following hardware features > − Display Parallel Interface (DPI) and MIPI

Re: [PATCH v2 0/5] drm: Reuse temporary memory for format conversion

2023-10-02 Thread Maxime Ripard
On Fri, Sep 29, 2023 at 04:58:30PM +0200, Thomas Zimmermann wrote: > Am 29.09.23 um 14:11 schrieb Maxime Ripard: > > On Wed, Sep 20, 2023 at 04:24:26PM +0200, Thomas Zimmermann wrote: > > > DRM's format-conversion helpers require temporary memory. Pass the > > > buffer from the caller and keep it

[PATCH v11 4/4] MAINTAINERS: Add maintainer for RZ DU drivers

2023-10-02 Thread Biju Das
Add my self as maintainer for RZ DU drivers. While at it, update the entries for common parts, rcar-du and shmobile. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v10->v11: * No change. v9->v10: * No change. v8->v9: * Added Rb tag from Laurent. * Updated entries for common

[PATCH v11 3/4] drm: renesas: Add RZ/G2L DU Support

2023-10-02 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU

[PATCH v11 2/4] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-10-02 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- v10->v11: * No change. v9->v10: * No

[PATCH v11 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-10-02 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video

[PATCH v11 0/4] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-10-02 Thread Biju Das
This path series aims to add support for RZ/G2L DU DRM driver. RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com > > Comments/feedback greatly appreciated Same problem on powerpc CI tests, all boot target failed, most of them with similar OOPS, see https://patchwork.ozlabs.org/pro

[PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro Carvalho Chehab Cc: Andi Shyti Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Nirmoy Das

Re: [PATCH] dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'

2023-10-02 Thread Conor Dooley
On Sat, Sep 30, 2023 at 10:01:02AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > fsl,imx6-hdmi.yaml makes a reference to synopsys,dw-hdmi.yaml. > > The 'interrupts'and 'reg' properties are described in synopsys,dw-hdmi.yaml, > so use 'unevaluatedProperties: false' so that these two

[PATCH v2 2/5] drm/etnaviv: Fix coding style

2023-10-02 Thread Sui Jingfeng
1) Keep the curly brace aligned. 2) No indentation by double tabs where single tab indentation is enough. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c

[PATCH v2 1/5] drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl()

2023-10-02 Thread Sui Jingfeng
The mentioned second parameter is the 'u32 size', but it is not get used by the etnaviv_gem_new_impl() function, so drop it. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH v2 4/5] drm/etnaviv: Add a helper to get the first available GPU device node

2023-10-02 Thread Sui Jingfeng
This patch make the code in the etnaviv_pdev_probe() less twisted, and it also make it easier to drop the reference to device node after finished. Before apply this patch, there is no call to of_node_put() when done. We should call of_node_put() when done. Signed-off-by: Sui Jingfeng ---

[PATCH v2 5/5] drm/etnaviv: Using 'dev' instead of 'etnaviv_obj->base.dev'

2023-10-02 Thread Sui Jingfeng
As in the etnaviv_gem_get_pages() function, the point to the drm_device has already been cached to the 'dev' local variable. We can use it directly, While at it, using 'unsigned int' type to count the number of pages. As the drm_prime_pages_to_sg() function takes an unsigned int type for its third

[PATCH v2 0/5] drm/etnaviv: Various cleanup

2023-10-02 Thread Sui Jingfeng
v2: * refine on v1 and update Sui Jingfeng (5): drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl() drm/etnaviv: Fix coding style drm/etnaviv: Add helper functions to create and destroy platform device drm/etnaviv: Add a helper to get the first available GPU

[PATCH v2 3/5] drm/etnaviv: Add helper functions to create and destroy platform device

2023-10-02 Thread Sui Jingfeng
The newly introduced functions are etnaviv_create_platform_device() and etnaviv_destroy_platform_device(). Those two function are pure function and can be shared for other use case. Currently, the benefit is that we no longer need to call of_node_put() for three different cases, we only need to

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
/cc Matthew, Andrew (please see below) On pondělí 2. října 2023 12:42:42 CEST Bagas Sanjaya wrote: > On Mon, Oct 02, 2023 at 08:20:15AM +0200, Oleksandr Natalenko wrote: > > Hello. > > > > On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > > > On Sun, Oct 01, 2023 at 06:32:34PM +0200,

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

2023-10-02 Thread Sebastian Andrzej Siewior
On 2023-09-22 07:33:26 [+0200], Christian König wrote: > Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior: > > Hi, > > > > I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix > > is #4 + #5 and the rest was made while looking at the code. > > Oh, yes please :) > >

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 10/2/23 12:05, Michel Dänzer wrote: > On 9/29/23 22:41, Hamza Mahfooz wrote: >> From: Ivan Lipski >> >> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >> >> Since, it causes the following IGT tests to fail: >> kms_cursor_legacy@cursor-vs-flip.* >>

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Bagas Sanjaya
On Mon, Oct 02, 2023 at 08:20:15AM +0200, Oleksandr Natalenko wrote: > Hello. > > On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > > On Sun, Oct 01, 2023 at 06:32:34PM +0200, Oleksandr Natalenko wrote: > > > Hello. > > > > > > I've got a VM from a cloud provider, and since v6.5 I

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Bagas Sanjaya
On Sun, Oct 01, 2023 at 06:32:34PM +0200, Oleksandr Natalenko wrote: > Hello. > > I've got a VM from a cloud provider, and since v6.5 I observe the following > kfence splat in dmesg during boot: > > ``` > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > Corrupted memory at

Re: [PATCH] drm/mediatek: Correctly free sg_table in gem prime vmap

2023-10-02 Thread AngeloGioacchino Del Regno
Il 02/10/23 11:20, Chen-Yu Tsai ha scritto: The MediaTek DRM driver implements GEM PRIME vmap by fetching the sg_table for the object, iterating through the pages, and then vmapping them. In essence, unlike the GEM DMA helpers which vmap when the object is first created or imported, the MediaTek

RE: [PATCH v10 3/4] drm: renesas: Add RZ/G2L DU Support

2023-10-02 Thread Biju Das
Hi Jacopo, > Subject: Re: [PATCH v10 3/4] drm: renesas: Add RZ/G2L DU Support > > Hi Biju > > On Mon, Sep 18, 2023 at 08:09:58AM +, Biju Das wrote: > > Hi Jacopo Mondi, > > > > Looks like you are happy with my response for V10. I will send V11 soon. > > Sorry for the late reply.. > > See

Re: [PATCH v10 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-02 Thread AngeloGioacchino Del Regno
Il 02/10/23 09:14, Jason-JH Lin (林睿祥) ha scritto: Hi Angelo, Thanks for the reviews. On Thu, 2023-09-28 at 12:00 +0200, AngeloGioacchino Del Regno wrote: Il 27/09/23 17:38, Jason-JH.Lin ha scritto: Add dynamic select available connector flow in mtk_drm_crtc_create() and

Re: [PATCH] drm/msm/a6xx: don't set IO_PGTABLE_QUIRK_ARM_OUTER_WBWA with coherent SMMU

2023-10-02 Thread Will Deacon
On Fri, Sep 29, 2023 at 06:25:21PM +0100, Robin Murphy wrote: > On 29/09/2023 4:45 pm, Will Deacon wrote: > > On Mon, Sep 25, 2023 at 06:54:42PM +0100, Robin Murphy wrote: > > > On 2023-04-10 19:52, Dmitry Baryshkov wrote: > > > > If the Adreno SMMU is dma-coherent, allocation will fail unless we

Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"

2023-10-02 Thread Michel Dänzer
On 9/29/23 22:41, Hamza Mahfooz wrote: > From: Ivan Lipski > > This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. > > Since, it causes the following IGT tests to fail: > kms_cursor_legacy@cursor-vs-flip.* > kms_cursor_legacy@flip-vs-cursor.* Any information about how those tests

Re: [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

2023-10-02 Thread Jani Nikula
On Wed, 16 Aug 2023, Pablo Ceballos wrote: > This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", > followed by link training errors. Intel engineers recommended increasing > this timeout and that does resolve the issue. > > On some CometLake-based device designs the Parade

[PATCH] drm/mediatek: Correctly free sg_table in gem prime vmap

2023-10-02 Thread Chen-Yu Tsai
The MediaTek DRM driver implements GEM PRIME vmap by fetching the sg_table for the object, iterating through the pages, and then vmapping them. In essence, unlike the GEM DMA helpers which vmap when the object is first created or imported, the MediaTek version does it on request. Unfortunately,

Re: [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their

Re: [PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-02 Thread Ilpo Järvinen
On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > On 9/26/2023 10:38 PM, Ilpo Järvinen wrote: > > On Fri, 22 Sep 2023, Shyam Sundar S K wrote: > > > >> PMF driver sends changing inputs from each subystem to TA for evaluating > >> the conditions in the policy binary. > >> > >> Add initial support of

Re: [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:47, Joel Granados a écrit : > On Thu, Sep 28, 2023 at 04:31:30PM +, Christophe Leroy wrote: > I followed this trace and proc_handler is correctly defined in tty_table > (struct ctl_table) in drivers/tty/tty_io.c:tty_init and there is not > path that changes these values.

Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Greg Kroah-Hartman
On Mon, Oct 02, 2023 at 08:47:53AM +, Christophe Leroy wrote: > > > Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: > >> From: Joel Granados > >> > >> This commit comes at the tail end of a greater effort to remove the > >> empty

Re: [PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 02. 10. 23, 10:55, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

  1   2   >