Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Enable Wa_16019325821

2023-12-13 Thread Belgaumkar, Vinay
On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison ---

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Enable Wa_14019159160

2023-12-13 Thread Belgaumkar, Vinay
On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/guc: Add support for w/a KLVs

2023-12-13 Thread Belgaumkar, Vinay
On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 +

Re: [net-next v1 00/16] Device Memory TCP

2023-12-13 Thread Mina Almasry
On Wed, Dec 13, 2023 at 10:49 PM Christoph Hellwig wrote: > > On Thu, Dec 14, 2023 at 06:20:27AM +, patchwork-bot+netdev...@kernel.org > wrote: > > Hello: > > > > This series was applied to netdev/net-next.git (main) > > by Jakub Kicinski : > > Umm, this is still very broken in intraction

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-13 Thread Andy Yan
Hi Heiko: On 12/13/23 22:46, Heiko Stuebner wrote: On Mon, 11 Dec 2023 19:55:47 +0800, Andy Yan wrote: From: Andy Yan This patch sets aims at enable the VOP2 support on rk3588. Main feature of VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max

Re: [net-next v1 00/16] Device Memory TCP

2023-12-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 7 Dec 2023 16:52:31 -0800 you wrote: > Major changes in v1: > -- > > 1. Implemented MVP queue API ndos to remove the userspace-visible >driver reset. > > 2. Fixed issues in the

Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-13 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree

[PATCH v12 13/23] drm/mediatek: Manage component's clock with function pointers

2023-12-13 Thread Hsiao Chien Sung
By registering component related functions to the pointers, we can easily manage them within a for-loop and simplify the logic of clock control significantly. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung ---

[PATCH v12 06/23] dt-bindings: reset: mt8188: Add VDOSYS reset control bits

2023-12-13 Thread Hsiao Chien Sung
Add MT8188 VDOSYS0 and VDOSYS1 reset control bits. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Hsiao Chien Sung --- include/dt-bindings/reset/mt8188-resets.h | 75 +++ 1 file changed, 75 insertions(+) diff --git

[PATCH v12 10/23] soc: mediatek: Add MT8188 VDOSYS reset bit map

2023-12-13 Thread Hsiao Chien Sung
Add MT8188 reset bit map for VDOSYS0 and VDOSYS1. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 84 + drivers/soc/mediatek/mtk-mmsys.c| 7 ++- 2 files changed, 90 insertions(+), 1 deletion(-)

[PATCH v12 14/23] drm/mediatek: Power on/off devices with function pointers

2023-12-13 Thread Hsiao Chien Sung
Different from OVL, OVL adaptor is a pseudo device so we didn't define it in the device tree, consequently, pm_runtime_resume_and_get() called by .atomic_enable() powers on no device. For this reason, we implement a function to power on the RDMAs in OVL adaptor, and the system will make sure the

[PATCH v12 19/23] drm/mediatek: Add Padding to OVL adaptor

2023-12-13 Thread Hsiao Chien Sung
Add MT8188 Padding to OVL adaptor to probe the driver. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 26 +++ 1 file changed, 26 insertions(+) diff --git

[PATCH v12 08/23] soc: mediatek: Support MT8188 VDOSYS1 Padding in mtk-mmsys

2023-12-13 Thread Hsiao Chien Sung
- Add Padding components - Add Mutex module definitions for Padding Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mutex.c | 16 include/linux/soc/mediatek/mtk-mmsys.h | 8 2 files changed, 24 insertions(+)

[PATCH v12 02/23] dt-bindings: display: mediatek: mdp-rdma: Add compatible for MT8188

2023-12-13 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MDP-RDMA. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,mdp-rdma.yaml| 6 +- 1 file changed, 5 insertions(+), 1

[PATCH v12 15/23] drm/mediatek: Start/Stop components with function pointers

2023-12-13 Thread Hsiao Chien Sung
By registering component related functions to the pointers, we can easily manage them within a for-loop and simplify the logic of component start/stop process. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung ---

[PATCH v12 16/23] drm/mediatek: Sort OVL adaptor components

2023-12-13 Thread Hsiao Chien Sung
Sort OVL adaptor components' names in alphabetical order. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v12 03/23] dt-bindings: display: mediatek: merge: Add compatible for MT8188

2023-12-13 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 MERGE. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v12 17/23] drm/mediatek: Refine device table of OVL adaptor

2023-12-13 Thread Hsiao Chien Sung
- Adjust indentation to align with other files - Sort device table in alphabetical order - Add sentinel to device table Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 15 --- 1 file

[PATCH v12 04/23] dt-bindings: display: mediatek: padding: Add MT8188

2023-12-13 Thread Hsiao Chien Sung
Padding is a new hardware module on MediaTek MT8188, add dt-bindings for it. Reviewed-by: Krzysztof Kozlowski Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../display/mediatek/mediatek,padding.yaml| 81 +++ 1 file

[PATCH v12 18/23] drm/mediatek: Support MT8188 Padding in display driver

2023-12-13 Thread Hsiao Chien Sung
Padding is a new display module on MT8188, it provides ability to add pixels to width and height of a layer with specified colors. Due to hardware design, Mixer in VDOSYS1 requires width of a layer to be 2-pixel-align, or 4-pixel-align when ETHDR is enabled, we need Padding to deal with odd

[PATCH v12 22/23] drm/mediatek: Fix underrun in VDO1 when switches off the layer

2023-12-13 Thread Hsiao Chien Sung
Do not reset Merge while using CMDQ because reset API doesn't wait for frame done event as CMDQ does and could lead to underrun when the layer is switching off. Fixes: aaf94f7c3ae6 ("drm/mediatek: Add display merge async reset control") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

[PATCH v12 20/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock

2023-12-13 Thread Hsiao Chien Sung
Return the result of clk_prepare_enable() instead of always returns 0. Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for MT8195") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +--

[PATCH v12 11/23] drm/mediatek: Rename OVL_ADAPTOR_TYPE_RDMA

2023-12-13 Thread Hsiao Chien Sung
Rename OVL_ADAPTOR_TYPE_RDMA to OVL_ADAPTOR_TYPE_MDP_RDMA to align the naming rule of mtk_ovl_adaptor_comp_id. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 22 +-- 1 file

[PATCH v12 21/23] drm/mediatek: Remove the redundant driver data for DPI

2023-12-13 Thread Hsiao Chien Sung
DPI input is in 1T2P mode on both MT8195 and MT8188. Remove the redundant driver data to align the settings, or the screen will glitch. Fixes: 2847cd7e6403 ("drm/mediatek: Add mt8188 dpi compatibles and platform data") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by:

[PATCH v12 12/23] drm/mediatek: Add component ID to component match structure

2023-12-13 Thread Hsiao Chien Sung
Add component ID to component match structure so we can configure them with a for-loop. The main reason we do such code refactoring is that there is a new hardware component called "Padding" since MT8188, while MT8195 doesn't have this module, we can't use the original logic to manage the

[PATCH v12 23/23] drm/mediatek: Support MT8188 VDOSYS1 in display driver

2023-12-13 Thread Hsiao Chien Sung
- The mmsys_dev_num in MT8188 VDOSYS0 was set to 1 since VDOSYS1 was not available before. Increase it to support VDOSYS1 in display driver. - Add compatible name for MT8188 VDOSYS1 (shares the same driver data with MT8195 VDOSYS1) Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

[PATCH v12 09/23] soc: mediatek: Support reset bit mapping in mmsys driver

2023-12-13 Thread Hsiao Chien Sung
- Reset ID must starts from 0 and be consecutive, but the reset bits in our hardware design is not continuous, some bits are left unused, we need a map to solve the problem - Use old style 1-to-1 mapping if .rst_tb is not defined Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao

[PATCH v12 01/23] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

2023-12-13 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 ETHDR. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH v12 05/23] dt-bindings: arm: mediatek: Add compatible for MT8188

2023-12-13 Thread Hsiao Chien Sung
Add compatible name for MediaTek MT8188 VDOSYS1. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Hsiao Chien Sung --- .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v12 07/23] soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys

2023-12-13 Thread Hsiao Chien Sung
- Add register definitions for MT8188 - Add VDOSYS1 routing table - Update MUTEX definitions accordingly - Set VSYNC length from 0x40 (default) to 1 since ETHDR is bypassed Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mt8188-mmsys.h | 126

[PATCH v12 00/23] Add display driver for MT8188 VDOSYS1

2023-12-13 Thread Hsiao Chien Sung
This series is based on mediatek-drm-next branch of kernel/git/chunkuang.hu/linux.git Changes in v12: - Rebase on mediatek-drm-next branch of kernel/git/chunkuang.hu/linux.git Changes in v11: - Change "mtk-padding" to "mtk-disp-padding" for consistency - Remove patch "drm/mediatek: Remove

RE: [PATCH] dt-bindings: display: samsung,exynos-mixer: Fix 'regs' typo

2023-12-13 Thread Alim Akhtar
> -Original Message- > From: Rob Herring > Sent: Thursday, December 14, 2023 4:12 AM > To: Inki Dae ; Seung-Woo Kim > ; Kyungmin Park > ; Maarten Lankhorst > ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Daniel Vetter ; Krzysztof > Kozlowski ; Conor Dooley > ; Alim Akhtar >

Re:Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-13 Thread Andy Yan
Hi Keith: 在 2023-12-13 09:40:31,"Keith Zhao" 写道: > > >On 2023/12/11 20:13, Andy Yan wrote: >> Hi Keith: >> >> 在 2023-12-11 18:24:35,"Keith Zhao" 写道: >>>hi Maxime: >>>hi Andy: >>> >>>On 2023/12/8 17:14, Maxime Ripard wrote: Hi, On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan

Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-13 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree

Re: [net-next v1 05/16] net: netdev netlink api to bind dma-buf to a net device

2023-12-13 Thread Jakub Kicinski
On Thu, 7 Dec 2023 16:52:36 -0800 Mina Almasry wrote: > +name: type > +doc: rx or tx queue > +type: u8 > +enum: queue-type nit: the queue/napi GET was applied to net-next, would be good to stick to the same types (s/u8/u32)

Re: [net-next v1 03/16] queue_api: define queue api

2023-12-13 Thread Jakub Kicinski
On Thu, 7 Dec 2023 16:52:34 -0800 Mina Almasry wrote: > This API enables the net stack to reset the queues used for devmem. Nice, thanks for moving this forward. FWIW when I started hacking on it the API looked more like:

Re: [PATCH 1/2] drm/bridge: parade-ps8640: Never increase the length when reading from AUX

2023-12-13 Thread Stephen Boyd
Quoting Douglas Anderson (2023-12-11 16:55:26) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index 8161b1a1a4b1..fb2ec4264549 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -302,7

[PATCH -next] drm/amd/pm: Remove unneeded semicolon

2023-12-13 Thread Yang Li
./drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c:1418:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7743 Signed-off-by: Yang Li --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/nouveau/kms/nv50-: Don't allow inheritance of headless iors

2023-12-13 Thread Lyude Paul
Turns out we made a silly mistake when coming up with OR inheritance on nouveau. On pre-DCB 4.1, iors are statically routed to output paths via the DCB. On later generations iors are only routed to an output path if they're actually being used. Unfortunately, it appears with NVIF_OUTP_INHERIT_V0

Re: nouveau 0000:01:00.0: drm_WARN_ON(!found_head)

2023-12-13 Thread Lyude Paul
Nevermind - I don't think I'll need the logs, I stared at the code for long enough and I think I realized what's happening. I will have a patch for you to test in just a moment, just waiting for it to compile so I can verify nothing else breaks On Wed, 2023-12-13 at 18:48 -0500, Lyude Paul

Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-13 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree, kindly drop

Re: nouveau 0000:01:00.0: drm_WARN_ON(!found_head)

2023-12-13 Thread Lyude Paul
Hopefully you're still on at this point - if you are, could you try starting the machine up with the following kernel module arguments passed to nouveau? debug=disp=trace Then see if you can find any lines that mention INHERIT? I have a feeling I'm just going to have to add a workaround for the

Re: nouveau 0000:01:00.0: drm_WARN_ON(!found_head)

2023-12-13 Thread Lyude Paul
agh - thank you for repeatedly poking on this, I've been busy enough with GSP work I totally missed this. Yes - I'm quite surprised that this is blowing up, but considering that looks to be a GT218 I guess display state readback must just work a bit differently there since that's really early on

Re: [PATCH] dt-bindings: display: samsung, exynos-mixer: Fix 'regs' typo

2023-12-13 Thread Inki Dae
2023년 12월 14일 (목) 오전 7:43, Rob Herring 님이 작성: > The correct property name is 'reg' not 'regs'. > Thanks, Inki Dae > Fixes: 68e89bb36d58 ("dt-bindings: display: samsung,exynos-mixer: convert > to dtschema") > Signed-off-by: Rob Herring > --- >

Re: [PATCH v4 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 13:30:16 -0800, Jessica Zhang wrote: > This series drops the frame_count and enable parameters (as they're always > set to the same value). It also sets input_sel=0x1 for INTF. > Applied, thanks! [1/2] drm/msm/dpu: Set input_sel bit for INTF

Re: [PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-12-13 Thread Dmitry Baryshkov
On Tue, 07 Nov 2023 02:43:33 +0200, Dmitry Baryshkov wrote: > The funcion dp_display_get_next_bridge() can return -EPROBE_DEFER if the > next bridge is not (yet) available. However returning -EPROBE_DEFER from > msm_dp_modeset_init() is not ideal. This leads to -EPROBE return from >

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-13 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: > > At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. > However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd > index and another one has an even index. Each encoder can work > independently. But only two DSC

[PATCH] dt-bindings: display: samsung,exynos-mixer: Fix 'regs' typo

2023-12-13 Thread Rob Herring
The correct property name is 'reg' not 'regs'. Fixes: 68e89bb36d58 ("dt-bindings: display: samsung,exynos-mixer: convert to dtschema") Signed-off-by: Rob Herring --- .../bindings/display/samsung/samsung,exynos-mixer.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[pull] amdgpu drm-fixes-6.7

2023-12-13 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.7. The following changes since commit b7b5a56acec819bb8dcd03c687e97a091b29d28f: Merge tag 'exynos-drm-next-for-v6.7-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes (2023-12-08 13:55:32 +1000) are available in the Git

Re: [PATCH v4 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 at 23:30, Jessica Zhang wrote: > > Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they > are always set to the same values. > > In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as > frame_count is always set to the same value. > > Fixes:

Re: [PATCH v6 0/4] Add displays support for bsh-smm-s2/pro boards

2023-12-13 Thread Neil Armstrong
Le 13/12/2023 à 18:53, Rob Herring a écrit : On Wed, Dec 13, 2023 at 03:03:41PM +0100, Dario Binacchi wrote: The series adds drivers for the displays used by bsh-smm-s2/pro boards. This required applying some patches to the samsung-dsim driver. Changes in v6: - Drop patches: - [06/10]

Re: [PATCH v4 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Abhinav Kumar
On 12/13/2023 1:30 PM, Jessica Zhang wrote: Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is always set to the same value. Fixes: 7b37523fb1d1

Re: [PATCH v4 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Abhinav Kumar
On 12/13/2023 1:30 PM, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")

[PATCH v4 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is always set to the same value. Fixes: 7b37523fb1d1 ("drm/msm/dpu: Move MISR methods to dpu_hw_util")

[PATCH v4 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang ---

[PATCH v4 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. --- Changes in v4: - Moved comment about input_sel to outside of dpu_hw_setup_misr() - Link to v3: https://lore.kernel.org/r/20231213-encoder-fixup-v3-0

Re: [PATCH 1/2] drm: update drm_show_memory_stats() for dma-bufs

2023-12-13 Thread Felix Kuehling
On 2023-12-07 13:02, Alex Deucher wrote: Show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). You can add KFD to that list. With the in-progress CUDA11 VM changes and improved interop between KFD and render nodes, sharing DMABufs

Re: [PATCH v8 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-12-13 Thread Rodrigo Vivi
On Tue, Dec 12, 2023 at 08:57:16AM -0800, Alan Previn wrote: > If we are at the end of suspend or very early in resume > its possible an async fence signal (via rcu_call) is triggered > to free_engines which could lead us to the execution of > the context destruction worker (after a prior worker

Re: [PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
On 12/13/2023 1:20 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 22:51, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d

[PATCH v3 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang ---

[PATCH v3 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. --- Changes in v3: - Changed input_sel to u8 - Link to v2: https://lore.kernel.org/r/20231213-encoder-fixup-v2-0-b11a4ad35...@quicinc.com Changes in v2

[PATCH v3 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is always set to the same value. Fixes: 7b37523fb1d1 ("drm/msm/dpu: Move MISR methods to dpu_hw_util")

Re: [PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 at 22:51, Jessica Zhang wrote: > > Set the input_sel bit for encoders as it was missed in the initial > implementation. > > Reported-by: Rob Clark > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 > Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for

Re: [RFT PATCH v2 3/4] drm/msm/dpu: enable writeback on SM6125

2023-12-13 Thread Abhinav Kumar
On 12/2/2023 4:32 PM, Dmitry Baryshkov wrote: Enable WB2 hardware block, enabling writeback support on this platform. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [RFT PATCH v2 2/4] drm/msm/dpu: enable writeback on SC8108X

2023-12-13 Thread Abhinav Kumar
On 12/2/2023 4:32 PM, Dmitry Baryshkov wrote: Enable WB2 hardware block, enabling writeback support on this platform. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h| 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [RFT PATCH v2 1/4] drm/msm/dpu: enable writeback on SM8150

2023-12-13 Thread Abhinav Kumar
On 12/2/2023 4:32 PM, Dmitry Baryshkov wrote: Enable WB2 hardware block, enabling writeback support on this platform. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH 0/2] fdinfo shared stats

2023-12-13 Thread Alex Deucher
On Thu, Dec 7, 2023 at 1:03 PM Alex Deucher wrote: > > We had a request to add shared buffer stats to fdinfo for amdgpu and > while implementing that, Christian mentioned that just looking at > the GEM handle count doesn't take into account buffers shared with other > subsystems like V4L or RDMA.

Re: [RFT PATCH v2 0/4] drm/msm/dpu: enable writeback on the other platforms

2023-12-13 Thread Abhinav Kumar
On 12/11/2023 10:23 PM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 02:30, Abhinav Kumar wrote: On 12/2/2023 4:31 PM, Dmitry Baryshkov wrote: I was not able to test it on my own, this is a call for testing for the owners of these platforms. The git version of modetest now fully

Re: [PATCH v2 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
On 12/13/2023 1:00 PM, Abhinav Kumar wrote: On 12/13/2023 12:51 PM, Jessica Zhang wrote: Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is

Re: [PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Abhinav Kumar
On 12/13/2023 12:51 PM, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")

Re: [PATCH v2 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Abhinav Kumar
On 12/13/2023 12:51 PM, Jessica Zhang wrote: Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is always set to the same value. Fixes: 7b37523fb1d1

[PATCH v2 2/2] drm/msm/dpu: Drop enable and frame_count parameters from dpu_hw_setup_misr()

2023-12-13 Thread Jessica Zhang
Drop the enable and frame_count parameters from dpu_hw_setup_misr() as they are always set to the same values. In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as frame_count is always set to the same value. Fixes: 7b37523fb1d1 ("drm/msm/dpu: Move MISR methods to dpu_hw_util")

[PATCH v2 1/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by: Rob Clark Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39 Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface") Signed-off-by: Jessica Zhang ---

[PATCH v2 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-13 Thread Jessica Zhang
This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. --- Changes in v2: - Switched patch order - Changed input_sel parameter from bool to u8 - Link to v1:

Re: [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-12-13 Thread Alex Bee
Hi Heiko Am 12.12.23 um 21:03 schrieb Heiko Stuebner: Hi Alex, Am Dienstag, 29. August 2023, 19:16:16 CET schrieb Alex Bee: this series fixes some issues I found when testing my "new" RK3128 board with the mainline kernel and adds some core functionality like SMP bringup, usb and networking.

Re: [PATCH 2/2] drm/msm/dpu: Set input_sel bit for INTF

2023-12-13 Thread Jessica Zhang
On 12/2/2023 11:54 AM, Dmitry Baryshkov wrote: On 01/12/2023 23:29, Abhinav Kumar wrote: On 11/30/2023 11:36 PM, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote: Set the input_sel bit for encoders as it was missed in the initial implementation. Reported-by:

[PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-13 Thread Kuogee Hsieh
At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder can work independently. But only two DSC encoders from same DCE can be paired to work together to support

[PATCH v7 1/3] drm: bridge: samsung-dsim: enter display mode in the enable() callback

2023-12-13 Thread Dario Binacchi
The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the

[PATCH v7 2/3] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2023-12-13 Thread Dario Binacchi
The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++- 1 file

[PATCH v7 0/3] Add displays support for bsh-smm-s2/pro boards

2023-12-13 Thread Dario Binacchi
The series adds drivers for the displays used by bsh-smm-s2/pro boards. This required applying some patches to the samsung-dsim driver and the drm_bridge.c module. Changes in v7: - Drop [3/4] dt-bindings: display: panel: Add synaptics r63353 panel controller because applied. Changes in v6: -

Re: [PATCH v7 00/10] drm: ci: fixes

2023-12-13 Thread Helen Koike
On 07/12/2023 06:18, Vignesh Raman wrote: The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. v2: - Use fdtoverlay command to merge

Re: [PATCH v7 5/6] udmabuf: Pin the pages using memfd_pin_folios() API (v5)

2023-12-13 Thread Matthew Wilcox
On Mon, Dec 11, 2023 at 11:38:02PM -0800, Vivek Kasireddy wrote: > +++ b/drivers/dma-buf/udmabuf.c > @@ -42,7 +42,7 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) > if (pgoff >= ubuf->pagecount) > return VM_FAULT_SIGBUS; > > - pfn =

Re: [PATCH v7 4/6] udmabuf: Convert udmabuf driver to use folios

2023-12-13 Thread Matthew Wilcox
On Mon, Dec 11, 2023 at 11:38:01PM -0800, Vivek Kasireddy wrote: > @@ -42,7 +42,7 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) > if (pgoff >= ubuf->pagecount) > return VM_FAULT_SIGBUS; > > - pfn = page_to_pfn(ubuf->pages[pgoff]); > + pfn =

[PATCH] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w

2023-12-13 Thread Farouk Bouabid
The ltk050h3148w variant expects the horizontal component lane byte clock cycle(lbcc) to be calculated using lane_mbps (burst mode) instead of the pixel clock. Using the pixel clock rate by default for this calculation was introduced in commit ac87d23694f4 ("drm/bridge: synopsys: dw-mipi-dsi: Use

Re: [PATCH v6 3/4] dt-bindings: display: panel: Add synaptics r63353 panel controller

2023-12-13 Thread Rob Herring
On Wed, 13 Dec 2023 15:03:44 +0100, Dario Binacchi wrote: > From: Michael Trimarchi > > Add documentation for "synaptics,r63353" panel. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi > Reviewed-by: Krzysztof Kozlowski > > --- > > (no changes since v3) > > Changes

Re: [PATCH v6 0/4] Add displays support for bsh-smm-s2/pro boards

2023-12-13 Thread Rob Herring
On Wed, Dec 13, 2023 at 03:03:41PM +0100, Dario Binacchi wrote: > The series adds drivers for the displays used by bsh-smm-s2/pro boards. > This required applying some patches to the samsung-dsim driver. > > Changes in v6: > - Drop patches: > - [06/10] drm/panel: Add Synaptics R63353 panel

Re: [PATCH] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w

2023-12-13 Thread Heiko Stuebner
On Wed, 13 Dec 2023 15:50:45 +0100, Farouk Bouabid wrote: > The ltk050h3148w variant expects the horizontal component lane byte clock > cycle(lbcc) to be calculated using lane_mbps (burst mode) instead of the > pixel clock. > Using the pixel clock rate by default for this calculation was

Re: [PATCH] drm/panel: ltk050h3146w: Set burst mode for ltk050h3148w

2023-12-13 Thread Jessica Zhang
On 12/13/2023 6:50 AM, Farouk Bouabid wrote: The ltk050h3148w variant expects the horizontal component lane byte clock cycle(lbcc) to be calculated using lane_mbps (burst mode) instead of the pixel clock. Using the pixel clock rate by default for this calculation was introduced in commit

Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-13 Thread Jason Gunthorpe
On Wed, Dec 13, 2023 at 04:36:34PM +0100, Christoph Hellwig wrote: > On Wed, Dec 13, 2023 at 08:31:55AM -0400, Jason Gunthorpe wrote: > > > That is, populate a scatterlist with ubuf->pagecount number of entries, > > > where each segment if of size PAGE_SIZE, in order to be consistent and > > >

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Biju Das
Hi Laurent and Maxime, > -Original Message- > From: Laurent Pinchart > Sent: Wednesday, December 13, 2023 3:51 PM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Wed, Dec 13, 2023 at 04:47:09PM +0100, Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 10:51:27AM

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-13 Thread Neil Armstrong
know\" that [clk_rate_exclusive_get() returns zero unconditionally]" is wrong. As of next-20231213 there are 3 callers ignoring the return value of clk_rate_exclusive_get() and 4 that handle (imaginary) returned errors. I expected this function to be used more extensively. (In fact I think it

Re: [PATCH v2 4/4] drm/panel-edp: Add some panels with conservative timings

2023-12-13 Thread Doug Anderson
Hi, On Wed, Dec 13, 2023 at 7:34 AM Maxime Ripard wrote: > > > > > Repeating my comments from v1 here too, since I expect this patch to > > > > sit on the lists for a little while: > > > > > > > > > > > > This is OK w/ me, but it will need time on the mailing lists before > > > > landing in case

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Geert Uytterhoeven
On Wed, Dec 13, 2023 at 4:50 PM Laurent Pinchart wrote: > On Wed, Dec 13, 2023 at 04:47:09PM +0100, Maxime Ripard wrote: > > On Tue, Nov 28, 2023 at 10:51:27AM +, Biju Das wrote: > > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > > Video Signal Processor (VSPD),

[PATCH] MAINTAINERS: Updates to Intel DRM

2023-12-13 Thread Rodrigo Vivi
Introduce the Maintainers of the new drm/xe driver for upcoming Intel GPUs. Since it has a shared display with drm/i915, let's also create a dedicated block to group display related files. But without any substantial change to the i915 side. The display patches will continue to flow through i915

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Michel Dänzer
On 2023-12-13 16:39, Felix Kuehling wrote: > On 2023-12-13 9:20, Christian König wrote: >> Am 12.12.23 um 00:32 schrieb Felix Kuehling: >>> On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: > [SNIP] >> You also need a functionality which resets all

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-13 Thread Uwe Kleine-König
On Wed, Dec 13, 2023 at 12:54:14PM +0100, Maxime Ripard wrote: > On Wed, Dec 13, 2023 at 12:08:29PM +0100, Uwe Kleine-König wrote: > > On Wed, Dec 13, 2023 at 09:36:49AM +0100, Maxime Ripard wrote: > > > On Wed, Dec 13, 2023 at 08:43:00AM +0100, Uwe Kleine-König wrote: > > > > On Wed, Dec 13, 2023

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Laurent Pinchart
On Wed, Dec 13, 2023 at 04:47:09PM +0100, Maxime Ripard wrote: > On Tue, Nov 28, 2023 at 10:51:27AM +, Biju Das wrote: > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > Video Signal Processor (VSPD), and Display Unit (DU). > > > > It has DPI/DSI interfaces and

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Maxime Ripard
On Wed, Dec 13, 2023 at 04:47:09PM +0100, Maxime Ripard wrote: > On Tue, Nov 28, 2023 at 10:51:27AM +, Biju Das wrote: > > +int rzg2l_du_vsp_init(struct rzg2l_du_vsp *vsp, struct device_node *np, > > + unsigned int crtcs) > > +{ > > + struct rzg2l_du_device *rcdu = vsp->dev;

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Maxime Ripard
On Tue, Nov 28, 2023 at 10:51:27AM +, Biju Das wrote: > The LCD controller is composed of Frame Compression Processor (FCPVD), > Video Signal Processor (VSPD), and Display Unit (DU). > > It has DPI/DSI interfaces and supports a maximum resolution of 1080p > along with 2 RPFs to support the

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Christian König
Am 13.12.23 um 16:39 schrieb Felix Kuehling: On 2023-12-13 9:20, Christian König wrote: Am 12.12.23 um 00:32 schrieb Felix Kuehling: On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks

  1   2   >