[PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-20 Thread Rino Andre Johnsen
[Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen --- Changes in v2: 1. Do not initialize dm_crtc_state to NULL. ---

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-05-20 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-05-17 16:37:56) > diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c > index af6a6fcb1173..62c8e6163e81 100644 > --- a/drivers/gpu/drm/msm/msm_kms.c > +++ b/drivers/gpu/drm/msm/msm_kms.c > @@ -200,6 +200,28 @@ struct msm_gem_address_space

[drm-misc:drm-misc-next 1/6] drivers/gpu/drm/v3d/v3d_performance_counters.h:118:43: warning: 'v3d_v42_performance_counters' defined but not used

2024-05-20 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 673087d8b023faf34b84e8faf63bbeea3da87bab commit: 3cbcbe016c31ad4fe1b7a53b325c1a36be6191f4 [1/6] drm/v3d: Add Performance Counters descriptions for V3D 4.2 and 7.1 config: arm64-defconfig

[PATCH] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-05-20 Thread Anatoliy Klymenko
(format_changed) - zynqmp_disp_layer_enable(layer); + /* Enable or re-enable the plane. */ + zynqmp_disp_layer_enable(layer); } static const struct drm_plane_helper_funcs zynqmp_dpsub_plane_helper_funcs = { --- base-commit: 673087d8b023faf34b84e8faf63bbeea3da87bab change-id: 20240520-

Re: [PATCH v5 5/8] drm/xe: Add helper to accumulate exec queue runtime

2024-05-20 Thread Lucas De Marchi
On Tue, May 21, 2024 at 02:53:56AM GMT, Matthew Brost wrote: On Sat, May 18, 2024 at 09:37:20AM -0500, Lucas De Marchi wrote: On Fri, May 17, 2024 at 03:40:22PM GMT, Matt Roper wrote: > On Fri, May 17, 2024 at 01:43:07PM -0700, Lucas De Marchi wrote: > > From: Umesh Nerlige Ramappa > > > > Add

[PATCH v4 10/10] drm/vs: add simple dsi encoder

2024-05-20 Thread keith
add encoder to match cdns dsi driver Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Makefile| 3 +- drivers/gpu/drm/verisilicon/vs_drv.c| 1 + drivers/gpu/drm/verisilicon/vs_drv.h| 1 + drivers/gpu/drm/verisilicon/vs_simple_enc.c | 190

[PATCH v4 02/10] drm/bridge: add common api for inno hdmi

2024-05-20 Thread keith
Add INNO common api so that it can be used by vendor drivers which implement vendor specific extensions to Innosilicon HDMI. Signed-off-by: keith --- MAINTAINERS | 2 + drivers/gpu/drm/bridge/Kconfig| 2 + drivers/gpu/drm/bridge/Makefile

[PATCH v4 09/10] drm/vs: Innosilicon HDMI support

2024-05-20 Thread keith
add inno hdmi driver which binds to vs display controller and this driver uses the commom api from the inno hdmi Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Kconfig | 10 + drivers/gpu/drm/verisilicon/Makefile | 1 + .../gpu/drm/verisilicon/inno_hdmi-starfive.c |

[PATCH v4 04/10] drm/vs: Add hardware funcs for vs.

2024-05-20 Thread keith
add hardware base api for vs drm Signed-off-by: keith --- MAINTAINERS|1 + drivers/gpu/drm/Kconfig|2 + drivers/gpu/drm/Makefile |1 + drivers/gpu/drm/verisilicon/Kconfig| 13 + drivers/gpu/drm/verisilicon/Makefile |

[PATCH v4 08/10] drm/vs: add vs drm master driver

2024-05-20 Thread keith
Add vs DRM master driver for JH7110 SoC ADD DMA GEM driver Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_drv.c | 718 +++ 2 files changed, 720 insertions(+), 1 deletion(-) create mode 100644

[PATCH v4 07/10] drm/vs: add ctrc fun

2024-05-20 Thread keith
add crtc funs and helper funs Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_crtc.c | 241 ++ drivers/gpu/drm/verisilicon/vs_crtc.h | 17 ++ 3 files changed, 260 insertions(+), 1 deletion(-) create mode 100644

[PATCH v4 03/10] drm/rockchip:hdmi: migrate to use inno-hdmi bridge driver

2024-05-20 Thread keith
Add the ROCKCHIP inno hdmi driver that uses the Inno DesignWare HDMI TX bridge and remove the old separate one. Signed-off-by: keith --- drivers/gpu/drm/rockchip/Kconfig |1 + drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/inno_hdmi-rockchip.c

[PATCH v4 05/10] drm/vs: add vs mode config init

2024-05-20 Thread keith
add vs mode config base api Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_modeset.c | 36 drivers/gpu/drm/verisilicon/vs_modeset.h | 10 +++ 3 files changed, 48 insertions(+), 1 deletion(-) create mode

[PATCH v4 06/10] drm/vs: add vs plane api

2024-05-20 Thread keith
add plane funs and helper funs add vs drm common struct and funs Signed-off-by: keith --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_drv.h | 93 + drivers/gpu/drm/verisilicon/vs_plane.c | 487 +

[PATCH v4 01/10] dt-bindings: display: Add YAML schema for JH7110 display pipeline

2024-05-20 Thread keith
JH7110 SoC display pipeline includes a display controller and hdmi. Dc controller IP : Vivante DC8200 Dual Display HDMI IP : INNOSILICON HDMI2.0 As the INNO hdmi ip is also used by rockchip SoC in the driver code, the innosilicon,inno-hdmi.yaml schema containing the common properties for the INNO

[PATCH v4 00/10] drm/verisilicon : support DC8200 and inno hdmi

2024-05-20 Thread keith
Verisilicon/DC8200 display controller IP has 2 display pipes and each pipe support a primary plane and a cursor plane . In addition, there are four overlay planes as two display pipes common resources. The first display pipe is bound to the inno HDMI encoder. The second display pipe is bound

Re: [PATCH v5 5/8] drm/xe: Add helper to accumulate exec queue runtime

2024-05-20 Thread Matthew Brost
On Sat, May 18, 2024 at 09:37:20AM -0500, Lucas De Marchi wrote: > On Fri, May 17, 2024 at 03:40:22PM GMT, Matt Roper wrote: > > On Fri, May 17, 2024 at 01:43:07PM -0700, Lucas De Marchi wrote: > > > From: Umesh Nerlige Ramappa > > > > > > Add a helper to accumulate per-client runtime of all its

[PATCH -next] drm/amdgpu: Fix kernel-doc param for amdgpu_vm_is_bo_always_valid

2024-05-20 Thread Yang Li
Make @abo to @bo to silence the kernel-doc warning. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index

Re: [PATCH] drm/amd/display: Add pixel encoding info to debugfs

2024-05-20 Thread Mario Limonciello
On 5/20/2024 16:07, Rino Andre Johnsen wrote: [Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen ---

[PATCH] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-05-20 Thread Adam Ford
In the process of adding support for shared IRQ pins, a scenario was accidentally created where adv7511_irq_process returned prematurely causing the EDID to fail randomly. Since the interrupt handler is broken up into two main helper functions, update both of them to treat the helper functions as

[PATCH] dt-bindings: display: Reorganize legacy eDP panel bindings

2024-05-20 Thread Douglas Anderson
Back in the day, we used to need to list the exact panel in dts for eDP panels. This led to all sorts of problems including a large number of cases where people listed a bogus panel in their device tree because of the needs of second sourcing (and third sourcing, and fourth sourcing, ...). Back

[PATCH v3] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-05-20 Thread Clayton Craft
This panel is found on some laptops e.g., variants of the Thinkpad X13s. Signed-off-by: Clayton Craft --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 6db277efcbb7..f75db9917667

Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dr. David Alan Gilbert
* Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > On Mon, May 20, 2024 at 01:55:51PM +0100, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") > > has dropped all the users of the struct bridge_init

Re: [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-05-20 Thread Clayton Craft
On Tue, 21 May 2024 00:07:04 +0300 Dmitry Baryshkov wrote: > On Mon, May 20, 2024 at 01:06:00PM -0700, Clayton Craft wrote: > > This panel is found on some laptops e.g., variants of the Thinkpad X13s. > > > > Signed-off-by: Clayton Craft > > --- > > drivers/gpu/drm/panel/panel-edp.c | 1 + > >

[PATCH] drm/amd/display: Add pixel encoding info to debugfs

2024-05-20 Thread Rino Andre Johnsen
[Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 47 +++ 1 file

Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 01:55:51PM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") > has dropped all the users of the struct bridge_init from the > exynos_dp_core, while retaining unused structure

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 12:57:36PM +, Dr. David Alan Gilbert wrote: > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > > > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > > > On Sat, May 18, 2024

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 07:46:05AM -0500, Adam Ford wrote: > On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov > wrote: > > > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > > > > > Hi, > > > > > > > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > > > On Mon, 20 May 2024 at 14:11, Sui

Re: [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 01:06:00PM -0700, Clayton Craft wrote: > This panel is found on some laptops e.g., variants of the Thinkpad X13s. > > Signed-off-by: Clayton Craft > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Please don't send patches as a response

Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63

2024-05-20 Thread Dmitry Baryshkov
On Thu, Nov 02, 2023 at 11:19:07AM -0700, Clayton Craft wrote: > This panel is found on laptops e.g., variants of the Thinkpad X13s. > Configuration was collected from the panel's EDID. > > Signed-off-by: Clayton Craft > --- > > V2: renamed to "*_mode" since there is only 1 mode listed > >

Re: [PATCH v2 0/6] drm/v3d: Improve Performance Counters handling

2024-05-20 Thread Maíra Canal
On 5/12/24 19:23, Maíra Canal wrote:> Maíra Canal (6): drm/v3d: Add Performance Counters descriptions for V3D 4.2 and 7.1 drm/v3d: Different V3D versions can have different number of perfcnt drm/v3d: Create a new V3D parameter for the maximum number of perfcnt drm/v3d: Create new

[PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-05-20 Thread Clayton Craft
This panel is found on some laptops e.g., variants of the Thinkpad X13s. Signed-off-by: Clayton Craft --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 6db277efcbb7..f75db9917667

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-20 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

Re: Device / Driver and PCI Rust abstractions

2024-05-20 Thread Danilo Krummrich
https://lore.kernel.org/rust-for-linux/20240520172554.182094-1-d...@redhat.com/

[RFC PATCH 8/8] nova: add initial driver stub

2024-05-20 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to

[RFC PATCH 7/8] rust: add firmware abstractions

2024-05-20 Thread Danilo Krummrich
Add an abstraction around the kernels firmware API to request firmware images. The abstraction provides functions to access the firmware buffer and / or copy it to a new buffer allocated with a given allocator backend. The firmware is released once the abstraction is dropped. Signed-off-by:

[RFC PATCH 6/8] rust: drm: gem: Add GEM object abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina The DRM GEM subsystem is the DRM memory management subsystem used by most modern drivers. Add a Rust abstraction to allow Rust DRM driver implementations to use it. Signed-off-by: Asahi Lina Co-developed-by: Danilo Krummrich Signed-off-by: Danilo Krummrich ---

[RFC PATCH 5/8] rust: drm: file: Add File abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[RFC PATCH 4/8] rust: drm: implement `AsRef` for DRM device

2024-05-20 Thread Danilo Krummrich
Implement `AsRef` for `drm::device::Device` such that `dev_*` print macros can be used conveniently. Signed-off-by: Danilo Krummrich --- rust/kernel/drm/device.rs | 8 1 file changed, 8 insertions(+) diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index

[RFC PATCH 4/8] rust: drm: implement `AsRef` for DRM device

2024-05-20 Thread Danilo Krummrich
Implement `AsRef` for `drm::device::Device` such that `dev_*` print macros can be used conveniently. Signed-off-by: Danilo Krummrich --- rust/kernel/drm/device.rs | 8 1 file changed, 8 insertions(+) diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs index

[RFC PATCH 3/8] rust: drm: Add Device and Driver abstractions

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina Add abstractions for DRM drivers and devices. These go together in one commit since both are fairly tightly coupled types. A few things have been stubbed out, to be implemented as further bits of the DRM subsystem are introduced. Signed-off-by: Asahi Lina Co-developed-by:

[RFC PATCH 2/8] rust: Add a Sealed trait

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina Some traits exposed by the kernel crate may not be intended to be implemented by downstream modules. Add a Sealed trait to allow avoiding this using the sealed trait pattern. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/kernel/lib.rs | 5 + 1 file

[RFC PATCH 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-05-20 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the

[RFC PATCH 0/8] [RFC] DRM Rust abstractions and Nova

2024-05-20 Thread Danilo Krummrich
This patch series implements some basic DRM Rust abstractions and a stub implementation of the Nova GPU driver. Nova is intended to be developed upstream, starting out with just a stub driver to lift some initial required infrastructure upstream. A more detailed explanation can be found in [1].

[linux-next:master] BUILD REGRESSION 632483ea8004edfadd035de36e1ab2c7c4f53158

2024-05-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 632483ea8004edfadd035de36e1ab2c7c4f53158 Add linux-next specific files for 20240520 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202405202243.shvs2otq-...@intel.com https

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-20 Thread Alex Deucher
On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote: > > Am 17.05.24 um 03:30 schrieb Barry Kauler: > > > Armin, Yifan, Prike, > > I will top-post, so you don't have to scroll down. > > After identifying the commit that causes black screen with my gpu, I > > posted the result to you guys, on May 9.

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Doug Anderson
Hi, On Sun, May 19, 2024 at 2:01 AM Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > > Prefer the struct drm_edid based functions for reading the EDID and > > updating the connector. > > > > Simplify the flow by updating the EDID property when the EDID

Re: [PATCH v2 1/5] dt-bindings: display: panel: mipi-dbi-spi: Add a pixel format property

2024-05-20 Thread Rob Herring (Arm)
On Sun, 12 May 2024 17:25:38 +0200, Noralf Trønnes wrote: > The MIPI DBI 2.0 specification (2005) lists only two pixel formats for > the Type C Interface (SPI) and that is 3-bits/pixel RGB111 with > 2 options for bit layout. > > For Type A and B (parallel) the following formats are listed:

Re: [PATCH v4 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat Tested-by: Alexandre Mergnat On 16/05/2024 10:11, AngeloGioacchino Del Regno wrote: It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for

Re: [PATCH v4 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat Tested-by: Alexandre Mergnat On 16/05/2024 10:11, AngeloGioacchino Del Regno wrote: The display IPs in MediaTek SoCs support being interconnected with different instances of DDP IPs (for example, merge0 or merge1) and/or with different DDP IPs (for example, rdma

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
On 20/05/2024 13:55, AngeloGioacchino Del Regno wrote: Il 20/05/24 13:49, Alexandre Mergnat ha scritto: On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I

Re: [RESEND v7 00/37] Device Tree support for SH7751 based board

2024-05-20 Thread John Paul Adrian Glaubitz
Hi Yoshinori, On Mon, 2024-05-20 at 22:06 +0900, Yoshinori Sato wrote: > On Sat, 18 May 2024 18:08:30 +0900, > John Paul Adrian Glaubitz wrote: > > > > Hi Yoshinori, > > > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > > Sorry. previus mail is thread broken. > > > > > > This is

Re: [PATCH] drm/komeda: remove unused struct 'gamma_curve_segment'

2024-05-20 Thread Liviu Dudau
On Thu, May 16, 2024 at 02:37:24PM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > 'gamma_curve_segment' looks like it has never been used. > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Liviu Dudau Thanks for the clean up! Best regards, Liviu > ---

Re: [PATCH 3/3] drm/amd/display: remove unused struct 'dc_reg_sequence'

2024-05-20 Thread Alex Deucher
Applied the series. Thanks! Alex On Fri, May 17, 2024 at 8:12 PM wrote: > > From: "Dr. David Alan Gilbert" > > 'dc_reg_sequence' was added in > commit 44788bbc309b ("drm/amd/display: refactor reg_update") > > but isn't actually used. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert >

Re: [PATCH -next] drm/amd/display: Update optc35_set_odm_combine doc to match kernel-doc spec

2024-05-20 Thread Alex Deucher
On Fri, May 17, 2024 at 4:42 AM Yang Li wrote: > > This patch updates the function documentation comment for > optc35_set_odm_combine to conform to the kernel-doc specification. > > Signed-off-by: Yang Li Thanks for the patch. Srini already fixed this last week. Alex > --- >

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-05-20 Thread Sean Anderson
On 5/20/24 05:40, Christophe JAILLET wrote: > If zynqmp_dpsub_drm_init() fails, we must undo the previous > drm_bridge_add() call. > > Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") > Signed-off-by: Christophe JAILLET > --- > Compile tested only > --- >

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Andy Shevchenko
On Mon, May 20, 2024 at 07:51:24PM +0530, Devarsh Thakkar wrote: > On 20/05/24 17:52, Andy Shevchenko wrote: > > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: > >> On 18/05/24 01:44, Andy Shevchenko wrote: > >>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
On 20/05/24 17:52, Andy Shevchenko wrote: > On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: >> On 18/05/24 01:44, Andy Shevchenko wrote: >>> On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: > > [..] > [..] > Yes, and one should follow IWYU principle and not

[Bug 217607] null pointer dereference with NVIDIA installer on 5.15.118 and 5.15.119

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217607 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 218864] HP Envy x360: Graphical corruption over time without amdgpu.sg_display=0 kernel option

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218864 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Hardware|All |AMD

[Bug 218864] HP Envy x360: Graphical corruption over time without amdgpu.sg_display=0 kernel option

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218864 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Component|BIOS

Re: [PATCH v11] drm/bridge: it6505: fix hibernate to resume no display issue

2024-05-20 Thread Markus Elfring
> … This patch has been implemented to prevent … Under which circumstances will imperative wordings be applied for another improved change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94 Regards, Markus

Re: [RESEND v7 00/37] Device Tree support for SH7751 based board

2024-05-20 Thread Yoshinori Sato
On Sat, 18 May 2024 18:08:30 +0900, John Paul Adrian Glaubitz wrote: > > Hi Yoshinori, > > On Thu, 2024-04-04 at 14:14 +0900, Yoshinori Sato wrote: > > Sorry. previus mail is thread broken. > > > > This is an updated version of something I wrote about 7 years ago. > > Minimum support for

Re: [PATCH 10/11] drm/imx/tve: convert to struct drm_edid

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Dmitry Baryshkov wrote: > On Tue, May 14, 2024 at 03:55:16PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Signed-off-by: Jani Nikula >> >> --- >> >> Cc: Philipp Zabel >> Cc: Maarten

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dr. David Alan Gilbert
* Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > > On Sat, May 18, 2024 at 12:24:27AM +0100, li...@treblig.org wrote: > > > > From: "Dr. David Alan

[PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread linux
From: "Dr. David Alan Gilbert" commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") has dropped all the users of the struct bridge_init from the exynos_dp_core, while retaining unused structure definition. Later on the driver was reworked and the definition migrated to the

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Adam Ford
On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > > > Hi, > > > > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > >> > > >> Hi, > > >> > > >> On 5/20/24 06:11, Dmitry

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 15:25, Jani Nikula wrote: > > On Sun, 19 May 2024, Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > >> Prefer the struct drm_edid based functions for reading the EDID and > >> updating the connector. > >> > >> Simplify the flow by

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Jani Nikula
On Sun, 19 May 2024, Dmitry Baryshkov wrote: > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Simplify the flow by updating the EDID property when the EDID is read >> instead of

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Andy Shevchenko
On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote: > On 18/05/24 01:44, Andy Shevchenko wrote: > > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [..] > >> +#include > >> +#include > > > >> +#include > > > > Do you know why this header is included? > > It

Re: [PATCH v5 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > v1: Initial version. > v2: Add aux-wake/less info along with lobf status. [Jouni] > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++ >

[PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-05-20 Thread Dmitry Baryshkov
Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 5/7] drm/msm/dpu: rework vsync_source handling

2024-05-20 Thread Dmitry Baryshkov
The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Signed-off-by: Dmitry Baryshkov ---

[PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling

2024-05-20 Thread Dmitry Baryshkov
Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 - 1 file changed, 37 deletions(-)

[PATCH 7/7] drm/msm/dpu: support setting the TE source

2024-05-20 Thread Dmitry Baryshkov
Make the DPU driver use the TE source specified in the DT. If none is specified, the driver defaults to the first GPIO (mdp_vsync0). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 - 1 file changed, 43 insertions(+), 1

[PATCH 6/7] drm/msm/dsi: parse vsync source from device tree

2024-05-20 Thread Dmitry Baryshkov
Allow board's device tree to specify the vsync source (aka TE source). If the property is omitted, the display controller driver will use the default setting. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c| 11 +++

[PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-20 Thread Dmitry Baryshkov
Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 2 +-

[PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-20 Thread Dmitry Baryshkov
Command-mode DSI panels need to signal the display controlller when vsync happens, so that the device can start sending the next frame. Some devices (Google Pixel 3) use a non-default pin, so additional configuration is required. Add a way to specify this information in DT and handle it in the DSI

[PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-20 Thread Dmitry Baryshkov
Command mode panels provide TE signal back to the DSI host to signal that the frame display has completed and update of the image will not cause tearing. Usually it is connected to the first GPIO with the mdp_vsync function, which is the default. In such case the property can be skipped.

Re: [PATCH v5 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-20 Thread Jani Nikula
On Mon, 20 May 2024, Animesh Manna wrote: > Link Off Between Active Frames, is a new feature for eDP > that allows the panel to go to lower power state after > transmission of data. This is a feature on top of ALPM, AS SDP. > Add compute config during atomic-check phase. > > v1: RFC version. >

Re: [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges")

2024-05-20 Thread Luca Ceresoli
Hello Daniel, On Thu, 16 May 2024 15:22:01 +0200 Daniel Vetter wrote: > Apologies for missing v1 ... > > On Fri, May 10, 2024 at 09:10:36AM +0200, Luca Ceresoli wrote: > > DRM hotplug bridge driver > > = > > > > DRM natively supports pipelines whose display can be

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > Hi, > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > >> > >> Hi, > >> > >> On 5/20/24 06:11, Dmitry Baryshkov wrote: > >>> On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: >

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread AngeloGioacchino Del Regno
Il 20/05/24 13:49, Alexandre Mergnat ha scritto: On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I think this should be anyOf instead :-) I'll check later and

Re: [PATCH v4 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-05-20 Thread Alexandre Mergnat
On 20/05/2024 12:53, AngeloGioacchino Del Regno wrote: So, I don't know how you want to manage multiple display, but IMHO there are 2 ways: - removing the current "oneOf". ...eh I think this should be anyOf instead :-) I'll check later and send a v5. "anyOf" behavior works as expected

Re: DRM Accel BoF at Linux Plumbers

2024-05-20 Thread Laurent Pinchart
Hi Tomeu, On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote: > Hi, > > I would like to use the chance at the next Plumbers to discuss the > present challenges related to ML accelerators in mainline. > > I'm myself more oriented towards edge-oriented deployments, and don't > know

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Sui Jingfeng
Hi, On 5/20/24 19:13, Dmitry Baryshkov wrote: On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: Hi, On 5/20/24 06:11, Dmitry Baryshkov wrote: On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") fails to

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-20 Thread Devarsh Thakkar
Hi Andy, Daniel, On 18/05/24 01:44, Andy Shevchenko wrote: > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: [..] > >> [devarsht: Rebase to 6.9 and change license to GPL] > > I'm not sure that you may change license. It needs the author's confirmation. > As per latest

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-05-20 Thread Daniel Stone
Hi, On Mon, 20 May 2024 at 08:39, Tomeu Vizoso wrote: > On Fri, May 10, 2024 at 10:34 AM Lucas Stach wrote: > > Am Mittwoch, dem 24.04.2024 um 08:37 +0200 schrieb Tomeu Vizoso: > > > If we expose a render node for NPUs without rendering capabilities, the > > > userspace stack will offer it to

[PATCH 2/2] drm/amdgpu: Use drm_print_memory_stats helper from fdinfo

2024-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo memory stats to use the common drm_print_memory_stats helper. This achieves alignment with the common keys as documented in drm-usage-stats.rst, adding specifically drm-total- key the driver was missing until now. Additionally I made the code stop skipping

[PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the current resident buffer object memory (including shared). To prevent any confusion, document that

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > Hi, > > On 5/20/24 06:11, Dmitry Baryshkov wrote: > > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > >> fails to consider the case where

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Sui Jingfeng
Hi, On 5/20/24 06:11, Dmitry Baryshkov wrote: On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") fails to consider the case where adv7511->i2c_main->irq is zero, i.e., no interrupt requested at all. Without

Re: [PATCH v2 6/6] drm/ci: update xfails for the new testlist

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:55:02PM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Set the timeout of all i915 jobs to 1h30m since some jobs > takes more than 1 hour to complete. > > Signed-off-by: Vignesh Raman > --- > > v2:

[PATCH v5 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-05-20 Thread Animesh Manna
Set the Link Off Between Frames Enable bit in ALPM_CTL register. Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise after cmmr feature enablement. Will add enabling sequence in a separate patch. v1: Initial version. v2: Condition check

[PATCH v5 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-05-20 Thread Animesh Manna
For validation purpose add debugfs for LOBF. v1: Initial version. v2: Add aux-wake/less info along with lobf status. [Jouni] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++ drivers/gpu/drm/i915/display/intel_alpm.h | 2 +

[PATCH v5 3/6] drm/display: Add missing aux less alpm wake related bits

2024-05-20 Thread Animesh Manna
From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v5 4/6] drm/i915/alpm: Add compute config for lobf

2024-05-20 Thread Animesh Manna
Link Off Between Active Frames, is a new feature for eDP that allows the panel to go to lower power state after transmission of data. This is a feature on top of ALPM, AS SDP. Add compute config during atomic-check phase. v1: RFC version. v2: Add separate flag for auxless-alpm. [Jani] v3: -

[PATCH v5 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-05-20 Thread Animesh Manna
Move ALPM feature related code as it will be used for non-psr panel also thorugh LOBF feature. v1: Initial version. v2: Correct ordering in makefile. [Jani] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_alpm.c | 295

[PATCH v5 1/6] drm/i915/alpm: Move alpm parameters from intel_psr

2024-05-20 Thread Animesh Manna
ALPM can be enabled for non psr panel and currenly aplm-params are encapsulated under intel_psr struct, so moving out to intel_dp struct. Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 21 + drivers/gpu/drm/i915/display/intel_psr.c | 44

[PATCH v5 0/6] Link off between frames for edp

2024-05-20 Thread Animesh Manna
Link Off Between Active Frames (LOBF) allows an eDP link to be turned Off and On durning long VBLANK durations without enabling any of the PSR/PSR2/PR modes of operation. Bspec: 71477 Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise

  1   2   >