[PATCH v7 8/8] drm: Replace strcpy() with strscpy()

2024-08-16 Thread Yafang Shao
To prevent erros from occurring when the src string is longer than the dst string in strcpy(), we should use strscpy() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Acked-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thom

[PATCH v7 7/8] net: Replace strcpy() with strscpy()

2024-08-16 Thread Yafang Shao
To prevent errors from occurring when the src string is longer than the dst string in strcpy(), we should use strscpy() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: "David S. Miller" Cc: David Ahern Cc: Eric Dumazet Cc: Jakub Kicins

[PATCH v7 6/8] mm/util: Deduplicate code in {kstrdup, kstrndup, kmemdup_nul}

2024-08-16 Thread Yafang Shao
These three functions follow the same pattern. To deduplicate the code, let's introduce a common helper __kmemdup_nul(). Suggested-by: Andrew Morton Signed-off-by: Yafang Shao Cc: Simon Horman Cc: Matthew Wilcox --- mm/util.c | 67 +-- 1 fil

[PATCH v7 5/8] mm/util: Fix possible race condition in kstrdup()

2024-08-16 Thread Yafang Shao
In kstrdup(), it is critical to ensure that the dest string is always NUL-terminated. However, potential race condidtion can occur between a writer and a reader. Consider the following scenario involving task->comm: readerwriter len = strlen(s) + 1;

[PATCH v7 4/8] bpftool: Ensure task comm is always NUL-terminated

2024-08-16 Thread Yafang Shao
Let's explicitly ensure the destination string is NUL-terminated. This way, it won't be affected by changes to the source string. Signed-off-by: Yafang Shao Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/pids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/bpf/bpftool/pids.c b/

[PATCH v7 3/8] security: Replace memcpy() with get_task_comm()

2024-08-16 Thread Yafang Shao
Quoted from Linus [0]: selinux never wanted a lock, and never wanted any kind of *consistent* result, it just wanted a *stable* result. Using get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates f

[PATCH v7 2/8] auditsc: Replace memcpy() with strscpy()

2024-08-16 Thread Yafang Shao
Using strscpy() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Acked-by: Paul Moore Cc: Eric Paris --- kernel/auditsc.c | 6 +++--- 1 file chang

[PATCH v7 1/8] Get rid of __get_task_comm()

2024-08-16 Thread Yafang Shao
We want to eliminate the use of __get_task_comm() for the following reasons: - The task_lock() is unnecessary Quoted from Linus [0]: : Since user space can randomly change their names anyway, using locking : was always wrong for readers (for writers it probably does make sense : to have so

[PATCH v7 0/8] Improve the copy of task comm

2024-08-16 Thread Yafang Shao
Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the length of task comm. Changes in the task comm could result in a destination string that is overflow. Therefore, we should explicitly ensure the destination string is always NUL-terminated, regardless of the task comm. This ap

Re: [PATCH 00/12] Enable build system on macOS hosts

2024-08-16 Thread Barry Song
On Thu, Aug 8, 2024 at 2:20 AM Greg Kroah-Hartman wrote: > > On Wed, Aug 07, 2024 at 01:56:38PM +, Daniel Gomez wrote: > > On Wed, Aug 07, 2024 at 01:01:08PM GMT, Greg Kroah-Hartman wrote: > > > On Wed, Aug 07, 2024 at 01:09:14AM +0200, Daniel Gomez via B4 Relay wrote: > > > > This patch set a

RE: [PATCH v3 5/5] udmabuf: remove udmabuf_folio

2024-08-16 Thread Kasireddy, Vivek
Hi Huan, > > Currently, udmabuf handles folio by creating an unpin list to record > each folio obtained from the list and unpinning them when released. To > maintain this approach, many data structures have been established. > > However, maintaining this type of data structure requires a signifi

RE: [PATCH v3 4/5] udmabuf: codestyle cleanup

2024-08-16 Thread Kasireddy, Vivek
Hi Huan, > > There are some variables in udmabuf_create that are only used inside the > loop. Therefore, there is no need to declare them outside the scope. > This patch moved it into loop. > > It is difficult to understand the loop condition of the code that adds > folio to the unpin_list. > >

RE: [PATCH v3 3/5] fix vmap_udmabuf error page set

2024-08-16 Thread Kasireddy, Vivek
Hi Huan, > Subject: [PATCH v3 3/5] fix vmap_udmabuf error page set Please prepend a "udmabuf:" to the subject line and improve the wording. > > Currently vmap_udmabuf set page's array by each folio. > But, ubuf->folios is only contain's the folio's head page. > > That mean we repeatedly mapped

RE: [PATCH v3 1/5] udmabuf: cancel mmap page fault, direct map it

2024-08-16 Thread Kasireddy, Vivek
Hi Huan, > > The current udmabuf mmap uses a page fault to populate the vma. > > However, the current udmabuf has already obtained and pinned the folio > upon completion of the creation.This means that the physical memory has > already been acquired, rather than being accessed dynamically. The >

Re: [PATCH 2/3] drm/fourcc: define Intel Xe2 related tile4 ccs modifiers

2024-08-16 Thread Lucas De Marchi
On Fri, Aug 16, 2024 at 02:52:28PM GMT, Juha-Pekka Heikkila wrote: Add Tile4 type ccs modifiers to indicate presence of compression on Xe2. Here is defined I915_FORMAT_MOD_4_TILED_LNL_CCS which is meant for integrated graphics with igpu related limitations Here is also defined I915_FORMAT_MOD_4_T

Re: [PATCH v8 4/6] drm/ttm: Add a shrinker helper and export the LRU walker for driver use

2024-08-16 Thread Matthew Brost
On Fri, Aug 16, 2024 at 03:37:15PM +0200, Thomas Hellström wrote: > Following the design direction communicated here: > > https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/#ma918844aa8a6efe8768fdcda0c6590d5c93850c9 > > Export the LRU walker for driver shrinker use an

Re: [PATCH v3 02/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller blit engine

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:33PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller contains a blit engine for raster graphics. > It may read up to 3 source images from memory and computes one destination > image from it, which is written back to memory. > > Signed-off-by: Liu Ying > --- > v3

Re: [PATCH v3 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:32PM +0800, Liu Ying wrote: > Freescale i.MX8qxp Display Controller is implemented as construction set of > building blocks with unified concept and standardized interfaces. Document > all existing processing units. > > Signed-off-by: Liu Ying > --- > v3: > * Combin

Re: [PATCH v3 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:34PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller display engine consists of all processing units > that operate in a display clock domain. > > Signed-off-by: Liu Ying > --- > v3: > * No change. > > v2: > * Drop fsl,dc-*-id DT properties. (Krzysztof) > * Dro

Re: [PATCH v3 04/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:35PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller pixel engine consists of all processing units > that operate in the AXI bus clock domain. Command sequencer and interrupt > controller of the Display Controller work with AXI bus clock, but they are > not in pi

Re: [PATCH v3 05/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller AXI performance counter

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:36PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller contains a AXI performance counter which allows > measurement of average bandwidth and latency during operation. > > Signed-off-by: Liu Ying > --- > v3: > * New patch. (Rob) > > ...sl,imx8qxp-dc-axi-performa

Re: [PATCH v3 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer

2024-08-16 Thread Rob Herring
On Wed, Jul 24, 2024 at 05:29:37PM +0800, Liu Ying wrote: > i.MX8qxp Display Controller contains a command sequencer is designed to > autonomously process command lists. > > Signed-off-by: Liu Ying > --- > v3: > * New patch. (Rob) > > .../imx/fsl,imx8qxp-dc-command-sequencer.yaml | 67 +

Re: [PATCH] Fix warning: symbol 'dcn3_14_ip' was not declared. Should it be static? in dcn314_fpu.c

2024-08-16 Thread kernel test robot
Hi Dipendra, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.11-rc3 next-20240816] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH v2 00/11] platform/chrome: Add DT USB/DP muxing/topology support

2024-08-16 Thread Stephen Boyd
Quoting Stephen Boyd (2024-08-14 17:34:05) > > I'm thinking of working in changes so that the drm_dp_typec_bridge > registers a 'struct typec_mux_dev' as well. If that is done then we can > register a drm_dp_typec_bridge from the port manager and let the type-c > framework drive the pin assignment

Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-16 Thread Rob Herring
On Mon, Aug 12, 2024 at 03:36:26PM -0400, Frank Li wrote: > Replace additionalProperties with unevaluatedProperties because it ref to > panel-common.yaml. > > Remove properties (backlight, enable-gpios and power-supply), which defined > in panel-common.yaml. > > Fix below warning: > arch/arm64/bo

Re: [PATCH v3 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true

2024-08-16 Thread Rob Herring (Arm)
On Wed, 14 Aug 2024 15:16:56 -0400, Frank Li wrote: > Add property panel-timing: true to allow use 'panel-timing', which defined > in panel-common.yaml. > > Fix below warning: > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: > 'panel-timing' does not match any of the r

Re: [PATCH 0/3] Various prime/dumb buffer fixes

2024-08-16 Thread Maaz Mombasawala
On 8/16/24 11:32, Zack Rusin wrote: > This is the same series I've sent out earlier but with one extra patch, > that fixes the dumb buffer coherency on low mem systems. > > The second patch has also been updated to not use math functions. > > Zack Rusin (3): > drm/vmwgfx: Prevent unmapping acti

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-16 Thread Alex Deucher
On Mon, Aug 12, 2024 at 8:10 AM Thomas Zimmermann wrote: > > Hi > > Am 10.08.24 um 13:44 schrieb kernel test robot: > > Hi Alex, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on drm-misc/drm-misc-next] > > [also build test ERROR on linus/master v6.11-

Re: [PATCH] drm/meson: add check to prevent dereference of NULL

2024-08-16 Thread Martin Blumenstingl
Hello Anastasia, On Mon, Aug 12, 2024 at 11:32 AM Anastasia Belova wrote: [...] > > As an alternative to your suggested approach: could you please look > > into whether devm_drm_dev_alloc() is a suitable replacement (if not: > > just explain why - then this patch is good to be merged)? > > If I u

Re: [PATCH v8 5/6] drm/xe: Add a shrinker for xe bos

2024-08-16 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20240816] [cannot apply to drm-xe/drm-xe-next linus/master v6.11-rc3 v6.11-rc2 v6.11-rc1 v6.11-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [REGRESSION][BISECTED] vmwgfx crashes with command buffer error after update

2024-08-16 Thread Zack Rusin
On Thu, Aug 15, 2024 at 4:30 PM Andreas Piesk wrote: > > Hello, > > the bug was first reported on VMware Workstation by rdkehn. > > On my setup (archlinux text mode only VM on ESXi 8.0U3 latest) the kernel > does NOT crash, the screen just goes dark after switching the console from > > [2.745

[PATCH] drm/panthor: flush FW AS caches in slow reset path

2024-08-16 Thread Adrián Larumbe
In the off-chance that waiting for the firmware to signal its booted status timed out in the fast reset path, one must flush the cache lines for the entire FW VM address space before reloading the regions, otherwise stale values eventually lead to a scheduler job timeout. Signed-off-by: Adrián Lar

[PATCH 3/3] drm/vmwgfx: Disable coherent dumb buffers without 3d

2024-08-16 Thread Zack Rusin
Coherent surfaces make only sense if the host renders to them using accelerated apis. Without 3d the entire content of dumb buffers stays in the guest making all of the extra work they're doing to synchronize between guest and host useless. Configurations without 3d also tend to run with very low

[PATCH 1/3] drm/vmwgfx: Prevent unmapping active read buffers

2024-08-16 Thread Zack Rusin
The kms paths keep a persistent map active to read and compare the cursor buffer. These maps can race with each other in simple scenario where: a) buffer "a" mapped for update b) buffer "a" mapped for compare c) do the compare d) unmap "a" for compare e) update the cursor f) unmap "a" for update At

[PATCH 2/3] drm/vmwgfx: Fix prime with external buffers

2024-08-16 Thread Zack Rusin
Make sure that for external buffers mapping goes through the dma_buf interface instead of trying to access pages directly. External buffers might not provide direct access to readable/writable pages so to make sure the bo's created from external dma_bufs can be read dma_buf interface has to be use

[PATCH 0/3] Various prime/dumb buffer fixes

2024-08-16 Thread Zack Rusin
This is the same series I've sent out earlier but with one extra patch, that fixes the dumb buffer coherency on low mem systems. The second patch has also been updated to not use math functions. Zack Rusin (3): drm/vmwgfx: Prevent unmapping active read buffers drm/vmwgfx: Fix prime with exter

Re: [PATCH 0/7] Preemption support for A7XX

2024-08-16 Thread Rob Clark
On Thu, Aug 15, 2024 at 11:27 AM Antonino Maniscalco wrote: > > This series implements preemption for A7XX targets, which allows the GPU to > switch to an higher priority ring when work is pushed to it, reducing latency > for high priority submissions. > > This series enables L1 preemption with sk

Re: [PATCH] drm/msm: Remove unused declaraions

2024-08-16 Thread Abhinav Kumar
On 8/15/2024 4:19 AM, Zhang Zekun wrote: The definition of msm_atomic_state_clear() and msm_atomic_state_free() has been removed since commit c21c731d93e8 ("drm/msm: Don't subclass drm_atomic_state anymore"). Also, the definition of msm_dsi_host_set_src_pll() has been removed since commit 9b0

Re: [PATCH v8 3/6] drm/ttm: Use fault-injection to test error paths

2024-08-16 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240816] [also build test ERROR on v6.11-rc3] [cannot apply to drm-xe/drm-xe-next linus/master v6.11-rc3 v6.11-rc2 v6.11-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH V2 14/16] WIP: usb: dwc2: Implement recovery after PM domain off

2024-08-16 Thread Stefan Wahren
Hi Doug, Am 15.08.24 um 21:37 schrieb Doug Anderson: Hi, On Wed, Aug 14, 2024 at 2:48 PM Stefan Wahren wrote: You're saying that your registers get saved _unless_ the power domain gets turned off, right? On BCM2835 there is no need to store the registers because there is no power management

[drm-misc:topic/rust-drm 9/19] error[E0425]: cannot find function `iounmap` in crate `bindings`

2024-08-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc topic/rust-drm head: ac3b90930f007514defbf06ec63a07122b02ba8a commit: 41bf8ed78cc51e13c60dbc7ff755a74ca968b91f [9/19] rust: add `io::Io` base type config: um-randconfig-001-20240816 (https://download.01.org/0day-ci/archive/20240817

Re: [PATCH 28/86] drm/mi0283qt: Run DRM default client setup

2024-08-16 Thread Noralf Trønnes
On 8/16/24 14:22, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: "Noralf Trønnes" > --- > dri

Re: [PATCH v8 3/6] drm/ttm: Use fault-injection to test error paths

2024-08-16 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240816] [also build test ERROR on v6.11-rc3] [cannot apply to drm-xe/drm-xe-next linus/master v6.11-rc3 v6.11-rc2 v6.11-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 2/2] drm/vmwgfx: Fix prime with external buffers

2024-08-16 Thread kernel test robot
Hi Zack, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc3 next-20240816] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for

Re: [git pull] drm fixes for 6.11-rc4

2024-08-16 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Aug 2024 14:09:28 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-08-16 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/37b20e9a5810e132a21c54f858043b22671396dd Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH v3 2/2] drm/vmwgfx: Fix prime with external buffers

2024-08-16 Thread kernel test robot
Hi Zack, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc3 next-20240816] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for

Re: [PATCH 55/86] drm/hyperv_drm: Run DRM default client setup

2024-08-16 Thread Deepak Rawat
Reviewed-by: Deepak Rawat On Fri, Aug 16, 2024 at 5:54 AM Thomas Zimmermann wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmerm

Re: [PATCH net-next v19 06/13] memory-provider: dmabuf devmem memory provider

2024-08-16 Thread Jakub Kicinski
On Fri, 16 Aug 2024 08:20:44 -0400 Mina Almasry wrote: > > I'd keep the current check with a WARN_ON_ONCE(), tho. > > Given the absence of tests driver developers can use. > > Especially those who _aren't_ supporting the feature. > > Yes what I have locally is the driver setting > netdev_rx_queue-

Re: [PATCH] MAINTAINERS: qaic: Drop Pranjal as reviewer

2024-08-16 Thread Jeffrey Hugo
On 7/26/2024 9:53 AM, Jeffrey Hugo wrote: Pranjal's email address is bouncing. Signed-off-by: Jeffrey Hugo --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 71b739b40921..258f6236ac1c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18461,7 +184

[PATCH v6 2/2] drm/xe/lnl: Offload system clear page activity to GPU

2024-08-16 Thread Nirmoy Das
On LNL because of flat CCS, driver creates migrates job to clear CCS meta data. Extend that to also clear system pages using GPU. Inform TTM to allocate pages without __GFP_ZERO to avoid double page clearing by clearing out TTM_TT_FLAG_ZERO_ALLOC flag and set TTM_TT_FLAG_CLEARED_ON_FREE while freei

[PATCH v6 1/2] drm/ttm: Add a flag to allow drivers to skip clear-on-free

2024-08-16 Thread Nirmoy Das
Add TTM_TT_FLAG_CLEARED_ON_FREE, which DRM drivers can set before releasing backing stores if they want to skip clear-on-free. Cc: Matthew Auld Cc: Thomas Hellström Suggested-by: Christian König Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 18 ++

Re: [PATCH 09/86] drm/arm/malidp: Run DRM default client setup

2024-08-16 Thread Liviu Dudau
On Fri, Aug 16, 2024 at 02:22:35PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The malidp driver specifies a preferred color mod

Re: [PATCH 08/86] drm/arm/hdlcd: Run DRM default client setup

2024-08-16 Thread Liviu Dudau
On Fri, Aug 16, 2024 at 02:22:34PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The hdlcd driver specifies a preferred color mode

Re: [PATCH 07/86] drm/arm/komeda: Run DRM default client setup

2024-08-16 Thread Liviu Dudau
On Fri, Aug 16, 2024 at 02:22:33PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The komeda driver specifies a preferred color mod

Re: [PATCH v8 2/6] drm/ttm/pool: Provide a helper to shrink pages

2024-08-16 Thread Matthew Brost
On Fri, Aug 16, 2024 at 03:37:13PM +0200, Thomas Hellström wrote: > Provide a helper to shrink ttm_tt page-vectors on a per-page > basis. A ttm_backup backend could then in theory get away with > allocating a single temporary page for each struct ttm_tt. > > This is accomplished by splitting large

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The fastrpc driver uses the label to determine the domain ID and create > the device nodes. It should be "cdsp1" as this is the engine we use here. > > Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 14:29, Bartosz Golaszewski wrote: > On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski wrote: >> >> On 16/08/2024 12:23, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. >>> >>> Signed-off-by: Bart

Re: [PATCH 69/86] drm/nouveau: Run DRM default client setup

2024-08-16 Thread Danilo Krummrich
On 8/16/24 2:23 PM, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The nouveau driver specifies a preferred color mode depending on the available

Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

2024-08-16 Thread Mina Almasry
On Thu, Aug 15, 2024 at 8:48 PM Jakub Kicinski wrote: > > On Tue, 13 Aug 2024 21:13:05 + Mina Almasry wrote: > > +int dev_get_max_mp_channel(const struct net_device *dev) > > +{ > > + int i, max = -1; > > I presume the bug from yesterday is self evident once reported? :) > Yes, my apologi

[PATCH v8 6/6] drm/xe: Increase the XE_PL_TT watermark

2024-08-16 Thread Thomas Hellström
The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memo

[PATCH v8 4/6] drm/ttm: Add a shrinker helper and export the LRU walker for driver use

2024-08-16 Thread Thomas Hellström
Following the design direction communicated here: https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/#ma918844aa8a6efe8768fdcda0c6590d5c93850c9 Export the LRU walker for driver shrinker use and add a bo shrinker helper for initial use by the xe driver. v8: - Split ou

[PATCH v8 5/6] drm/xe: Add a shrinker for xe bos

2024-08-16 Thread Thomas Hellström
Rather than relying on the TTM watermark accounting add a shrinker for xe_bos in TT or system memory. Leverage the newly added TTM per-page shrinking and shmem backup support. Although xe doesn't fully support WONTNEED (purgeable) bos yet, introduce and add shrinker support for purgeable ttm_tts.

[PATCH v8 3/6] drm/ttm: Use fault-injection to test error paths

2024-08-16 Thread Thomas Hellström
Use fault-injection to test partial TTM swapout and interrupted swapin. Return -EINTR for swapin to test the callers ability to handle and restart the swapin, and on swapout perform a partial swapout to test that the swapin and release_shrunken functionality. v8: - Use the core fault-injection sys

[PATCH v8 2/6] drm/ttm/pool: Provide a helper to shrink pages

2024-08-16 Thread Thomas Hellström
Provide a helper to shrink ttm_tt page-vectors on a per-page basis. A ttm_backup backend could then in theory get away with allocating a single temporary page for each struct ttm_tt. This is accomplished by splitting larger pages before trying to back them up. In the future we could allow ttm_bac

[PATCH v8 1/6] drm/ttm: Add a virtual base class for graphics memory backup

2024-08-16 Thread Thomas Hellström
Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination using a virtual base class. Also provide a sample implementation for shmem. While when settling on a preferred backup solution, one could perhaps skip the a

[PATCH v8 0/6] TTM shrinker helpers and xe buffer object shrinker

2024-08-16 Thread Thomas Hellström
This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on a previous series, *and obsoletes that one*. https://lore.kernel.org/linux-mm/b7491378-defd-4f1c-31e2-29e4c77e2...@amd.com/T/ Where the comment about layering https://lore.kernel.org/linux-mm/b7491378-defd-

Re: [PATCH v3 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

2024-08-16 Thread kernel test robot
Hi Manikandan, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on drm-misc/drm-misc-next linus/master v6.11-rc3 next-20240816] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 38/86] drm/rockchip: Run DRM default client setup

2024-08-16 Thread Heiko Stübner
Am Freitag, 16. August 2024, 14:23:04 CEST schrieb Thomas Zimmermann: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Sandy

Re: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Hi Am 16.08.24 um 15:18 schrieb Jani Nikula: On Fri, 16 Aug 2024, Thomas Zimmermann wrote: diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 206328387150..7a28396abb25 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -17,6 +17

Re: [PATCH 83/86] drm/{i915,xe}: Run DRM default client setup

2024-08-16 Thread Jani Nikula
On Fri, 16 Aug 2024, Thomas Zimmermann wrote: > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index 206328387150..7a28396abb25 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -17,6 +17,8 @@ > #include > #include > > +

[PATCH] drm/virtio: Use XRGB8888 also for big endian systems

2024-08-16 Thread Jocelyn Falempe
Mesa doesn't support BGRX, that means most wayland compositors doesn't work on big endian guests. Also the colors are inverted when testing a s390x VM on a s390x host. So I fixed the DRM_FORMAT -> VIRTIO_GPU_FORMAT on big endian guests. It may break big-endian guest on little-endian host, but

Re: [PATCH v2 2/2] drm: use mem_is_zero() instead of !memchr_inv(s, 0, n)

2024-08-16 Thread Jani Nikula
On Thu, 15 Aug 2024, Kees Cook wrote: > On Wed, Aug 14, 2024 at 01:00:35PM +0300, Jani Nikula wrote: >> Use the mem_is_zero() helper where possible. >> >> Conversion done using cocci: >> >> | @@ >> | expression PTR; >> | expression SIZE; >> | @@ >> | >> | <... >> | ( >> | - memchr_inv(PTR, 0,

[PATCH v2 5/5] drm/log: Color the timestamp, to improve readability

2024-08-16 Thread Jocelyn Falempe
Color the timesamp prefix, similar to dmesg. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_log.c b/drivers/gpu/drm/drm_log.c index b94ce3ea48a0..effdf6ee20b1 100644

[PATCH v2 3/5] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-08-16 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. Design decisions: * It uses the drm_c

[PATCH v2 4/5] drm/log: Do not draw if drm_master is taken

2024-08-16 Thread Jocelyn Falempe
When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_log.

[PATCH v2 2/5] drm/panic: Move drawing functions to drm_draw

2024-08-16 Thread Jocelyn Falempe
Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile| 1 +

[PATCH v2 1/5] [NOT FOR REVIEW] drm/panic: Squash of pending series

2024-08-16 Thread Jocelyn Falempe
squash of the drm/panic QR code series https://patchwork.freedesktop.org/series/135944/ Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/Kconfig | 31 + drivers/gpu/drm/Makefile|1 + drivers/gpu/drm/drm_crtc_internal.h |4 + drivers/gpu/drm/drm_drv.c

[RFC PATCH v2 0/5] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-08-16 Thread Jocelyn Falempe
drm_log is a simple logger that uses the drm_client API to print the kmsg boot log on the screen. This is not a full replacement to fbcon, as it will only print the kmsg. It will never handle user input, or a terminal because this is better done in userspace. If you're curious on how it looks li

Re: [PATCH v3 5/5] udmabuf: remove udmabuf_folio

2024-08-16 Thread kernel test robot
: 033a4691702cdca3a613256b0623b8eeacb4985e patch link: https://lore.kernel.org/r/20240813090518.3252469-6-link%40vivo.com patch subject: [PATCH v3 5/5] udmabuf: remove udmabuf_folio config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240816/202408162012.cl9pnfsm-...@intel.com/config) compiler: s390-linux

[PATCH 85/86] drm/omapdrm: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH 77/86] drm/msm: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH 84/86] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-08-16 Thread Thomas Zimmermann
Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of each per DRM device, so both can be referenced directly from the omap and DRM device

[PATCH 83/86] drm/{i915,xe}: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup_with_color_mode() to run the kernel's default client setup f

[PATCH 81/86] drm/i915: Move custom restore code into separate callback

2024-08-16 Thread Thomas Zimmermann
i915's fbdev contains additional code for restoring the client that cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_restore and implement it for i915. The fbdev helpers invoke the callback after restoring the fbdev client. Signed-off-by: Thomas Zimmerman

[PATCH 80/86] drm/i915: Remove struct drm_fb_helper from struct intel_fbdev

2024-08-16 Thread Thomas Zimmermann
Store instances of drm_fb_helper and struct intel_fbdev separately. This will allow i915 to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of each per DRM device, so both can be referenced directly from the i915 and DRM device s

[PATCH 69/86] drm/nouveau: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The nouveau driver specifies a preferred color mode depending on the available video memory, with a default of 32. Adapt this

[PATCH 59/86] drm/solomon: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The solomon driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH 72/86] drm/vmwgfx: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx

[PATCH 61/86] drm/virtgpu: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The virtgpu driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out en

[PATCH 65/86] drm/amdgpu: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The amdgpu driver specifies a preferred color mode depending on the available video memory, with a default of 32. Adapt this f

[PATCH 86/86] drm/fb-helper: Remove struct drm_fb_helper.fb_probe

2024-08-16 Thread Thomas Zimmermann
The callback fb_probe in struct drm_fb_helper is unused. Remove it. New drivers should set struct drm_driver.fbdev_probe instead and call drm_client_setup() to instantiate in-kernel DRM clients. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 8 include/drm/drm_f

[PATCH 64/86] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. This change allows the common fbdev client to run on top of TTM-

[PATCH 57/86] drm/ofdrm: Use DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c | 9 +

[PATCH 82/86] drm/i915: Move custom hotplug code into separate callback

2024-08-16 Thread Thomas Zimmermann
i915's fbdev contains additional code for hotplugging a display that cannot be ported to the common fbdev client. Introduce the callback struct drm_fb_helper.fb_hotplug and implement it for i915. The fbdev helpers invoke the callback before handing the hotplug event. Signed-off-by: Thomas Zimmerma

[PATCH 79/86] drm/tegra: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH 78/86] drm/radeon: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbde

[PATCH 49/86] drm/fbdev-dma: Remove obsolete setup function

2024-08-16 Thread Thomas Zimmermann
The old setup function drm_fbdev_dma_setup() is unused. Remove it and its internal callbacks. New drivers should call drm_client_setup() instead. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_dma.c | 120 +--- include/drm/drm_fbdev_dma.h | 7 --

[PATCH 71/86] drm/vboxvideo: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The vboxvideo driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out

[PATCH 68/86] drm/loongson: Run DRM default client setup

2024-08-16 Thread Thomas Zimmermann
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The loongson driver specifies a preferred color mode of 32. As this is the default if no format has been given, leave it out e

  1   2   3   >