Re: [PATCH v2 2/4] drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message

2024-11-08 Thread Dmitry Baryshkov
On Wed, Nov 06, 2024 at 11:48:25AM +0100, Luca Ceresoli wrote: > This message reports a mismatch between new_crtc_state->enable and > has_connectors, which should be either both true or both false. However it > does not mention which one is true and which is false, which can be useful > for debuggi

Re: [PATCH v2] drm:sprd: Correct left shift operator evaluating constant expression

2024-11-08 Thread Dmitry Baryshkov
On Fri, Nov 08, 2024 at 05:11:25PM +, Karan Sanghavi wrote: > The left shift operation followed by a mask with 0xf will > always result in 0. To correctly evaluate the expression for > the bitwise OR operation, use a right shift instead. > > Reported by Coverity Scan CID: 1511468 > > Fixes: 1

Re: [PATCH v15 01/19] drm/etnaviv: Implement drm_gem_object_funcs::print_info()

2024-11-08 Thread Sui Jingfeng
Hi, On 2024/10/1 21:04, Lucas Stach wrote: Hi Sui, Am Sonntag, dem 08.09.2024 um 17:43 +0800 schrieb Sui Jingfeng: It will be called by drm_gem_print_info() if implemented, and it can provide more information about the framebuffer objects. Etnaviv GEM BOs are not framebuffer objects. Signed

Re: [PATCH v2 2/6] drm/sun4i: use drm_hdmi_connector_mode_valid()

2024-11-08 Thread Dmitry Baryshkov
On Fri, Nov 08, 2024 at 03:20:48PM +0100, Maxime Ripard wrote: > On Fri, Nov 01, 2024 at 02:25:05AM +0200, Dmitry Baryshkov wrote: > > Use new drm_hdmi_connector_mode_valid() helper instead of a > > module-specific copy. > > > > Reviewed-by: Chen-Yu Tsai > > Signed-off-by: Dmitry Baryshkov > > -

Re: [PATCH v2 1/6] drm/display: hdmi: add generic mode_valid helper

2024-11-08 Thread Dmitry Baryshkov
On Fri, Nov 08, 2024 at 03:17:22PM +0100, Maxime Ripard wrote: > Hi, > > On Fri, Nov 01, 2024 at 02:25:04AM +0200, Dmitry Baryshkov wrote: > > Add drm_hdmi_connector_mode_valid(), generic helper for HDMI connectors. > > It can be either used directly or as a part of the .mode_valid callback. > >

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-08 Thread Dmitry Baryshkov
On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2024-10-31 11:42:36) > > > > On Tue, Oct 29, 2024 at 01:15:51PM -0700, Stephen Boyd wrote:

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-08 Thread Yu Kuai
Hi, 在 2024/11/09 1:03, Liam R. Howlett 写道: * Chuck Lever III [241108 08:23]: On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote: Hi, 在 2024/11/07 22:41, Chuck Lever 写道: On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote: Hi, 在 2024/11/06 23:19, Chuck Lever III 写道: On Nov 6, 2024, at 1

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-08 Thread Yu Kuai
Hi, 在 2024/11/08 21:23, Chuck Lever III 写道: On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote: Hi, 在 2024/11/07 22:41, Chuck Lever 写道: On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote: Hi, 在 2024/11/06 23:19, Chuck Lever III 写道: On Nov 6, 2024, at 1:16 AM, Greg KH wrote: On Thu, Oc

Re: Ensure progress for dma_fence_array

2024-11-08 Thread Chia-I Wu
On Fri, Nov 8, 2024 at 1:43 AM Christian König wrote: > > Hi guys, > > as pointed out by Chia-I userspace doesn't see any progress when > signaling is not enabled and Boris noted that this is because > dma_fence_array_signaled() never returns true in this case. > > Improve this by fixing the dma_f

Re: [RFC PATCH 00/10] drm/panthor: Add user submission

2024-11-08 Thread Matthew Brost
On Tue, Sep 24, 2024 at 11:30:53AM +0200, Simona Vetter wrote: > Apologies for the late reply ... > Also late reply, just read this. > On Wed, Sep 04, 2024 at 01:34:18PM +0200, Christian König wrote: > > Hi Boris, > > > > Am 04.09.24 um 13:23 schrieb Boris Brezillon: > > > > > > > Please read u

Re: [PATCH V7 07/10] accel/amdxdna: Add command execution

2024-11-08 Thread Lizhi Hou
On 11/8/24 09:21, Matthew Brost wrote: On Thu, Nov 07, 2024 at 08:34:45PM -0800, Lizhi Hou wrote: Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c

[PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

2024-11-08 Thread Mithil Bavishi
Create a device tree for the 10 inch variants (P5100, P5110, P5113) Signed-off-by: Mithil Bavishi --- .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++ 1 file changed, 102 insertions(+) create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts diff --git a

[PATCH v3 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1

2024-11-08 Thread Mithil Bavishi
Add samsung-espresso10 codename for the 10 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yam

[PATCH v3 08/10] ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy Tab 2 7.0

2024-11-08 Thread Mithil Bavishi
Create a device tree for the 7 inch variants (P3100, P3110, P3113) Signed-off-by: Mithil Bavishi --- .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts diff --git a/ar

[PATCH v3 07/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 7.0

2024-11-08 Thread Mithil Bavishi
Add samsung-espresso7 codename for the 7 inch variant Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml

[PATCH v3 06/10] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

2024-11-08 Thread Mithil Bavishi
Create common device tree for Samsung Espresso series devices Let's create a common tree for all the variants first. Later we can device specific trees based on their screen sizes. Signed-off-by: Mithil Bavishi --- .../omap/omap4-samsung-espresso-common.dtsi | 680 ++ 1 file c

[PATCH v3 05/10] dt-bindings: display: panel-lvds: Add compatible for Samsung LTN101AL03 Panel

2024-11-08 Thread Mithil Bavishi
The LTN101AL03 is a 10.1 inch 800x1280, 24 bit, VESA Compatible, TFT display panel Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.y

Re: [git pull] drm fixes for 6.12-rc7

2024-11-08 Thread pr-tracker-bot
The pull request you sent on Sat, 9 Nov 2024 05:31:26 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-11-09 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/952a33dc08cefde50540cc82abaa2e09f37ef540 Thank you! -- Deet-doot-dot, I am a bot. ht

[PATCH v3 04/10] dt-bindings: display: panel-lvds: Add compatible for Samsung LTN070NL01 Panel

2024-11-08 Thread Mithil Bavishi
The LTN070NL01 is a 7.0 inch 1024x600, 24 bit, VESA Compatible, TFT display panel Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.ya

[PATCH v3 03/10] dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am

2024-11-08 Thread Mithil Bavishi
Add compatible strings for the Doestek DTC34LM85AM Flat Panel Display Transmitter Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yam

[PATCH v3 02/10] dt-bindings: vendor-prefixes: Add Doestek

2024-11-08 Thread Mithil Bavishi
Add vendor prefix for Doestek Co., Ltd. Link: http://www.doestek.co.kr/ Signed-off-by: Mithil Bavishi --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetre

[PATCH v3 01/10] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC

2024-11-08 Thread Mithil Bavishi
Add a dedicated DTS file for the TWL6032 PMIC (Phoenix Lite). Already has driver support with TWL6030 (Phoenix) since both of them are so similar, some nodes can be reused from TWL6030 as well. This can be included in the board files like twl6030. Example: ... &i2c1 { twl: twl@48 { reg

[PATCH v3 00/10] Initial support for Samsung Galaxy Tab 2 series

2024-11-08 Thread Mithil Bavishi
This series adds initial support for the Samsung Galaxy Tab 2 (samsung-espresso7/10) series of devices. It adds support for 6 variants (P3100, P3110, P3113, P5100, P5110, P5113). Downstream categorised them based on 3G and WiFi, but since they use different panel, touch controllers, batteries, I de

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-08 Thread David Hildenbrand
On 08.11.24 18:05, Jason Gunthorpe wrote: On Fri, Nov 08, 2024 at 04:20:30PM +, Fuad Tabba wrote: Some folios, such as hugetlb folios and zone device folios, require special handling when the folio's reference count reaches 0, before being freed. Moreover, guest_memfd folios will likely requ

[git pull] drm fixes for 6.12-rc7

2024-11-08 Thread Dave Airlie
Hi Linus, Weekly fixes, usual leaders in amdgpu and xe, then a panel quirk, and some fixes to imagination and panthor drivers. Seems around the usual level for this time and don't know of any big problems. Regards, Dave. drm-fixes-2024-11-09: drm fixes for 6.12-rc7 amdgpu: - Brightness fix - DC

Re: [PATCH v3 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-08 Thread Heiko Stübner
Hi Detlev, Am Freitag, 8. November 2024, 19:50:38 CET schrieb Detlev Casanova: > Detlev Casanova (3): > vop2: Add clock resets support > arm64: dts: rockchip: Add VOP clock resets for rk3588s > dt-bindings: display: vop2: Add VP clock resets while it isn't that important for this short seri

Re: [drm:vc4_hvs_irq_handler [vc4]] *ERROR* HVS underrun

2024-11-08 Thread Stefan Wahren
Am 26.10.24 um 15:11 schrieb Stefan Wahren: Hi, during the investigations of the recent VC4 HDMI Sink issue [1], I was able to reproduce another issue with vc4 after s2idle resume. Sometimes ( probability ~ 1 : 30 cases ) I'm able to trigger a HVS underrun and it's impact is that the HDMI display

[PATCH v2] drm:sprd: Correct left shift operator evaluating constant expression

2024-11-08 Thread Karan Sanghavi
The left shift operation followed by a mask with 0xf will always result in 0. To correctly evaluate the expression for the bitwise OR operation, use a right shift instead. Reported by Coverity Scan CID: 1511468 Fixes: 1c66496b1391 ("drm/sprd: add Unisoc's drm mipi dsi&dphy driver") Reviewed-by:

[PATCH v3 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-11-08 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Reviewed-by: Conor Dooley Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation/device

[PATCH v3 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-11-08 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-

[PATCH v3 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. This issue can be reproduced by switching modes multiple times. Depending

[PATCH v3 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-08 Thread Detlev Casanova
The clock reset must be used when the VOP is configured. Skipping it can put the VOP in an unknown state where the HDMI signal is either lost or not matching the selected mode. This adds support for rk3588(s) based SoCs. Changes since v2: - Rebase on latest master - Add details on how to reproduc

[PATCH v4 1/2] drm/display/dsc: Refactor DRM MST DSC Determination Policy

2024-11-08 Thread Fangzhi Zuo
[why] How we determine the dsc_aux used for dsc decompression in drm_dp_mst_dsc_aux_for_port() today has defects: 1. The method how we determine a connected peer device is virtual or not in drm_dp_mst_is_virtual_dpcd() is not always correct. There are DP1.4 products in the market which don'

[PATCH v4 2/2] drm/display/dsc: MST DSC Interface Change

2024-11-08 Thread Fangzhi Zuo
[why] Starting from dp2 where dsc passthrough is introduced, it is required to identify the dsc passthrough aux, apart from dsc decompression aux. Existing drm_dp_mst_port function that returns dsc_aux alone is not sufficient. [how] 1. Interface change in drm_dp_mst_dsc_aux_for_port, and depende

[PATCH v4 0/2] Refactor MST DSC Determination Policy

2024-11-08 Thread Fangzhi Zuo
The patch series is to refactor existing dsc determination policy for dsc decompression and dsc passthrough given a mst output port. Original routine was written based on different peer device types which is not accurate and shows difficulty when expanding support of products that do not fully com

Re: [PATCH V7 07/10] accel/amdxdna: Add command execution

2024-11-08 Thread Matthew Brost
On Thu, Nov 07, 2024 at 08:34:45PM -0800, Lizhi Hou wrote: > Add interfaces for user application to submit command and wait for its > completion. > > Co-developed-by: Min Ma > Signed-off-by: Min Ma > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/aie2_ctx.c | 634 +

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-08 Thread Liam R. Howlett
* Chuck Lever III [241108 08:23]: > > > > On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote: > > > > Hi, > > > > 在 2024/11/07 22:41, Chuck Lever 写道: > >> On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote: > >>> Hi, > >>> > >>> 在 2024/11/06 23:19, Chuck Lever III 写道: > > > > On

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-08 Thread Jason Gunthorpe
On Fri, Nov 08, 2024 at 04:20:30PM +, Fuad Tabba wrote: > Some folios, such as hugetlb folios and zone device folios, > require special handling when the folio's reference count reaches > 0, before being freed. Moreover, guest_memfd folios will likely > require special handling to notify it onc

Re: [PATCH v2 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
On Friday, 8 November 2024 11:39:57 EST Detlev Casanova wrote: > On Thursday, 23 May 2024 23:09:26 EST Andy Yan wrote: > > Hi Detlev, > > > > At 2024-05-23 02:57:48, "Detlev Casanova" > > wrote: > > >At the end of initialization, each VP clock needs to be reset before > > >they can be used. > >

Re: [PATCH v2 1/3] vop2: Add clock resets support

2024-11-08 Thread Detlev Casanova
On Thursday, 23 May 2024 23:09:26 EST Andy Yan wrote: > Hi Detlev, > > At 2024-05-23 02:57:48, "Detlev Casanova" wrote: > >At the end of initialization, each VP clock needs to be reset before > >they can be used. > > > >Failing to do so can put the VOP in an undefined state where the > >generate

Re: [PATCH 2/3] drm/client: Move public client header to clients/ subdirectory

2024-11-08 Thread Jocelyn Falempe
On 08/11/2024 16:42, Thomas Zimmermann wrote: Move the public header file drm_client_setup.h to the clients/ subdirectory and update all drivers. No functional changes. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amd

Re: [PATCH 3/3] drm/fbdev-client: Unexport drm_fbdev_client_setup()

2024-11-08 Thread Jocelyn Falempe
On 08/11/2024 16:42, Thomas Zimmermann wrote: DRM drivers invoke drm_client_setup() to set up in-kernel clients. No driver should call drm_fbdev_client_setup() directly. Therefore, unexport the symbol and move the declaration to the internal header drm_client_internal.h. Thanks, it looks good t

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Diederik de Haas
On Fri Nov 8, 2024 at 5:31 PM CET, Heiko Stübner wrote: > Am Freitag, 8. November 2024, 16:21:24 CET schrieb Diederik de Haas: > > On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a numbe

Re: [PATCH 1/3] drm: Move client code to clients/ subdirectory

2024-11-08 Thread Jocelyn Falempe
On 08/11/2024 16:42, Thomas Zimmermann wrote: Just move some files around to keep source code well organized. Plus fix a type in the help text of CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM. No functional changes. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmerma

Re: [PATCH 0/3] drm: Move client code into subdirectories

2024-11-08 Thread Jocelyn Falempe
On 08/11/2024 16:42, Thomas Zimmermann wrote: The drm_log client will likely be merged into DRM soon. Time to clean up some of the existing files. This series moves the existing DRM client for fbdev emulation and its build infrastructure into clients/ subdirectories. Drm_log can then be located t

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-08 Thread Parthiban
On 11/8/24 6:59 PM, John Watts wrote: > On Fri, Nov 08, 2024 at 11:53:57AM +, Andre Przywara wrote: >> Hi John, > > Hi Andre! > >> Can you say *why* this patch is needed? Is there something broken that >> needs fixing? Where does this show and why wasn't this a problem before? > > Oops, that

[PATCH v2] drm/etnaviv: add optional reset support

2024-11-08 Thread LECOINTRE Philippe
Add optional reset support which is mentioned in vivante,gc.yaml to allow the driver to work on SoCs whose reset signal is asserted by default Avoid enabling the interrupt until everything is ready Signed-off-by: Philippe Lecointre Reviewed-by: Simon Lenain --- v2: - Add missing include of irq.h

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Heiko Stübner
Am Freitag, 8. November 2024, 16:21:24 CET schrieb Diederik de Haas: > On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number > > of lines too, so convert the error prints for the dsi-driver

[RFC PATCH v1 08/10] mm: Use getters and setters to access page pgmap

2024-11-08 Thread Fuad Tabba
The pointer to pgmap in struct page is overlaid with folio owner_ops. To indicate that a page/folio has owner ops, bit 1 is set. Therefore, before we can start to using owner_ops, we need to ensure that all accesses to page pgmap sanitize the pointer value. This patch introduces the accessors, whi

[RFC PATCH v1 02/10] mm/migrate: don't call folio_putback_active_hugetlb() on dst hugetlb folio

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand We replaced a simple put_page() by a putback_active_hugepage() call in commit 3aaa76e125c1 (" mm: migrate: hugetlb: putback destination hugepage to active list"), to set the "active" flag on the dst hugetlb folio. Nowadays, we decoupled the "active" list from the flag, by

[RFC PATCH v1 05/10] mm/hugetlb: use folio->lru int demote_free_hugetlb_folios()

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand Let's avoid messing with pages. Signed-off-by: David Hildenbrand Signed-off-by: Fuad Tabba --- mm/hugetlb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index d58bd815fdf2..a64852280213 100644 --- a/mm/hugetlb.c

[RFC PATCH v1 10/10] mm: hugetlb: Use owner_ops on folio_put for hugetlb

2024-11-08 Thread Fuad Tabba
Now that we have the folio_owner_ops callback, use it for hugetlb pages instead of using a dedicated callback. Since owner_ops is overlaid with lru, we need to unset owner_ops to allow the use of lru when its isolated. At that point we know that the reference count is elevated, will not reach 0, a

[RFC PATCH v1 09/10] mm: Use owner_ops on folio_put for zone device pages

2024-11-08 Thread Fuad Tabba
Now that we have the folio_owner_ops callback, use it for zone device pages instead of using a dedicated callback. Note that struct dev_pagemap (pgmap) in struct page is overlaid with struct folio owner_ops. Therefore, make struct dev_pagemap contain an instance of struct folio_owner_ops, to handl

[RFC PATCH v1 07/10] mm: Introduce struct folio_owner_ops

2024-11-08 Thread Fuad Tabba
Introduce struct folio_owner_ops, a method table that contains callbacks to owners of folios that need special handling for certain operations. For now, it only contains a callback for folio free(), which is called immediately after the folio refcount drops to 0. Add a pointer to this struct overl

[RFC PATCH v1 04/10] mm/hugetlb-cgroup: convert hugetlb_cgroup_css_offline() to work on folios

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand Let's convert hugetlb_cgroup_css_offline() and hugetlb_cgroup_move_parent() to work on folios. hugepage_activelist contains folios, not pages. While at it, rename page_hcg simply to hcg, removing most of the "page" terminology. Signed-off-by: David Hildenbrand Signed-of

[RFC PATCH v1 06/10] mm/hugetlb: use separate folio->_hugetlb_list for hugetlb-internals

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand Let's use a separate list head in the folio, as long as hugetlb folios are not isolated. This way, we can reuse folio->lru for different purpose (e.g., owner_ops) as long as they are not isolated. Consequently, folio->lru will only be used while there is an additional fol

[RFC PATCH v1 03/10] mm/hugetlb: rename "folio_putback_active_hugetlb()" to "folio_putback_hugetlb()"

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand Now that folio_putback_hugetlb() is only called on folios that were previously isolated through folio_isolate_hugetlb(), let's rename it to match folio_putback_lru(). Add some kernel doc to clarify how this function is supposed to be used. Signed-off-by: David Hildenbran

[RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-08 Thread Fuad Tabba
Some folios, such as hugetlb folios and zone device folios, require special handling when the folio's reference count reaches 0, before being freed. Moreover, guest_memfd folios will likely require special handling to notify it once a folio's reference count reaches 0, to facilitate shared to priva

[RFC PATCH v1 01/10] mm/hugetlb: rename isolate_hugetlb() to folio_isolate_hugetlb()

2024-11-08 Thread Fuad Tabba
From: David Hildenbrand Let's make the function name match "folio_isolate_lru()", and add some kernel doc. Signed-off-by: David Hildenbrand Signed-off-by: Fuad Tabba --- include/linux/hugetlb.h | 4 ++-- mm/gup.c| 2 +- mm/hugetlb.c| 23 --- m

Re: [PATCH 2/3] dma-buf: sort fences in dma_fence_unwrap_merge

2024-11-08 Thread Tvrtko Ursulin
On 08/11/2024 14:58, Christian König wrote: Am 08.11.24 um 12:22 schrieb Tvrtko Ursulin: On 07/11/2024 16:00, Tvrtko Ursulin wrote: On 24/10/2024 13:41, Christian König wrote: The merge function initially handled only individual fences and arrays which in turn were created by the merge funct

Re: [PATCH] dma-buf: fix dma_fence_array_signaled

2024-11-08 Thread Tvrtko Ursulin
On 08/11/2024 14:18, Christian König wrote: Am 08.11.24 um 14:01 schrieb Tvrtko Ursulin: On 08/11/2024 09:42, Christian König wrote: The function silently assumed that signaling was already enabled for the dma_fence_array. This meant that without enabling signaling first we would never see

[PATCH 0/3] drm: Move client code into subdirectories

2024-11-08 Thread Thomas Zimmermann
The drm_log client will likely be merged into DRM soon. Time to clean up some of the existing files. This series moves the existing DRM client for fbdev emulation and its build infrastructure into clients/ subdirectories. Drm_log can then be located there as well. The core and helper support for i

[PATCH 3/3] drm/fbdev-client: Unexport drm_fbdev_client_setup()

2024-11-08 Thread Thomas Zimmermann
DRM drivers invoke drm_client_setup() to set up in-kernel clients. No driver should call drm_fbdev_client_setup() directly. Therefore, unexport the symbol and move the declaration to the internal header drm_client_internal.h. Signed-off-by: Thomas Zimmermann --- .../gpu/drm/clients/drm_client_in

[PATCH 2/3] drm/client: Move public client header to clients/ subdirectory

2024-11-08 Thread Thomas Zimmermann
Move the public header file drm_client_setup.h to the clients/ subdirectory and update all drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 +- drivers/gpu/drm/arm/hd

[PATCH 1/3] drm: Move client code to clients/ subdirectory

2024-11-08 Thread Thomas Zimmermann
Just move some files around to keep source code well organized. Plus fix a type in the help text of CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 72 +- drivers/gpu/drm/Makefile

[PULL] drm-xe-fixes

2024-11-08 Thread Lucas De Marchi
Hi Dave and Simona, drm-xe-fixes for 6.12-rc7. Still busier than I'd like for an rc7, but needed particularly for LNL. thanks, Lucas De Marchi drm-xe-fixes-2024-11-08: Driver Changes: - Fix ccs_mode setting for Xe2 and later (Balasubramani) - Synchronize ccs_mode setting with client creation (B

Re: [PATCH-next v3] drm/amdgpu: Cleanup shift coding style

2024-11-08 Thread Alex Deucher
Applied. Thanks! Sorry for the delay. Alex On Fri, Nov 8, 2024 at 10:11 AM Advait Dhamorikar wrote: > > Hello, > > I have addressed the previous comments, > Is there something more that I need to address in this version of the patch? > I would appreciate feedback. > > Best regards, > Advait >

Re: [PATCH 0/2] MAINTAINERS: Update with Daniel Thompson's korg address

2024-11-08 Thread Doug Anderson
Hi, On Fri, Nov 8, 2024 at 12:31 AM Daniel Thompson wrote: > > Going forward, I'll be using my kernel.org address for upstream work. > > Signed-off-by: Daniel Thompson > --- > Daniel Thompson (2): > MAINTAINERS: Use Daniel Thompson's korg address for backlight work > MAINTAINERS: Use

Re: [PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Diederik de Haas
On Fri Nov 8, 2024 at 3:44 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number > of lines too, so convert the error prints for the dsi-driver. > > Signed-off-by: Heiko Stuebner Should this have a Fixes tag? Because in

Re: [PATCH-next v3] drm/amdgpu: Cleanup shift coding style

2024-11-08 Thread Advait Dhamorikar
Hello, I have addressed the previous comments, Is there something more that I need to address in this version of the patch? I would appreciate feedback. Best regards, Advait On Wed, 9 Oct 2024 at 00:46, Advait Dhamorikar wrote: > > Improves the coding style by updating bit-shift > operations in

Re: [PATCH] dma-buf: fix dma_fence_array_signaled

2024-11-08 Thread Boris Brezillon
On Fri, 8 Nov 2024 15:18:38 +0100 Christian König wrote: > > } > > } > > > > dma_fence_array_clear_pending_error(array); > > return true; > > } > > > > Or if the optimisation to not walk the array when signalling is > > already enabled is deemed important, perhaps a less thinking ind

Re: [PATCH 2/3] dma-buf: sort fences in dma_fence_unwrap_merge

2024-11-08 Thread Christian König
Am 08.11.24 um 12:22 schrieb Tvrtko Ursulin: On 07/11/2024 16:00, Tvrtko Ursulin wrote: On 24/10/2024 13:41, Christian König wrote: The merge function initially handled only individual fences and arrays which in turn were created by the merge function. This allowed to create the new array by a

Re: [PATCH] dma-buf: fix dma_fence_array_signaled

2024-11-08 Thread Boris Brezillon
On Fri, 8 Nov 2024 10:42:56 +0100 "Christian König" wrote: > The function silently assumed that signaling was already enabled for the > dma_fence_array. This meant that without enabling signaling first we would > never see forward progress. > > Fix that by falling back to testing each individua

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Dragan Simic
On 2024-11-08 15:30, Dragan Simic wrote: On 2024-11-08 15:22, Heiko Stübner wrote: Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic: On 2024-11-08 15:09, Heiko Stübner wrote: > Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: >> On 2024-11-08 14:56, Heiko Stübner

[PATCH] drm/rockchip: dsi: convert to dev_err_probe in probe function

2024-11-08 Thread Heiko Stuebner
From: Heiko Stuebner DRM_DEV_ERROR is deprecated and using dev_err_probe saves quite a number of lines too, so convert the error prints for the dsi-driver. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 80 ++- 1 file changed, 26 insertions(+)

[PATCH 1/2] drm/etnaviv: Preallocate STLB according to CPU PAGE_SIZE

2024-11-08 Thread Sui Jingfeng
The dma_direct_alloc() allocate one page at minmium, which size is the CPU PAGE_SIZE. while the etnaviv_iommuv2_ensure_stlb() only ask for 4KiB. The rest memory space that beyond 4KiB gets wasted on bigger page size systems. For example, on 16KiB CPU page size systems, we will waste the rest 12KiB.

[PATCH 2/2] drm/etnaviv: Remove the etnaviv_iommuv2_ensure_stlb()

2024-11-08 Thread Sui Jingfeng
The etnaviv_iommuv2_ensure_stlb() function have been replaced by the etnaviv_iommuv2_ensure_stlb_new(), remove it. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c | 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv

Re: [PATCH v11 2/8] drm/ttm: Add a virtual base class for graphics memory backup

2024-11-08 Thread Christian König
Am 16.10.24 um 10:55 schrieb Thomas Hellström: Initially intended for experimenting with different backup solutions (shmem vs direct swap cache insertion), abstract the backup destination using a virtual base class. Also provide a sample implementation for shmem. It feels a bit like overkill t

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Dragan Simic
On 2024-11-08 15:22, Heiko Stübner wrote: Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic: On 2024-11-08 15:09, Heiko Stübner wrote: > Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: >> On 2024-11-08 14:56, Heiko Stübner wrote: >> > Am Freitag, 8. November 2024,

Re: [PATCH v2 6/6] drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate

2024-11-08 Thread Maxime Ripard
On Fri, 1 Nov 2024 02:25:09 +0200, Dmitry Baryshkov wrote: > Replace .mode_valid() callback with .hdmi_tmds_char_rate_valid(). It is > more generic and is used in other mode validation paths. The rate > validation for .mode_valid() will be performed by the > drm_bridge_connector code. > > > [ ...

Re: [PATCH v2 5/6] drm/bridge: lontium-lt9611: drop TMDS char rate check in mode_valid

2024-11-08 Thread Maxime Ripard
On Fri, 1 Nov 2024 02:25:08 +0200, Dmitry Baryshkov wrote: > Drop manual check of the TMDS char rate in the mode_valid callback. This > check is now being performed by the core. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Dmitry Baryshkov > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Max

Re: [PATCH v2 4/6] drm/display: bridge_connector: use drm_bridge_connector_mode_valid()

2024-11-08 Thread Maxime Ripard
On Fri, 1 Nov 2024 02:25:07 +0200, Dmitry Baryshkov wrote: > Use new drm_bridge_connector_mode_valid() helper if there is a HDMI > bridge in the bridge chain. This removes the need to perform TMDS char > rate check manually in the bridge driver. > > Reviewed-by: Chen-Yu Tsai > > [ ... ] Reviewe

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Dragan Simic
On 2024-11-08 15:09, Heiko Stübner wrote: Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: On 2024-11-08 14:56, Heiko Stübner wrote: > Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: >> Perform a few trivial code cleanups, to make one logged message a bit >> more

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Heiko Stübner
Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic: > On 2024-11-08 15:09, Heiko Stübner wrote: > > Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: > >> On 2024-11-08 14:56, Heiko Stübner wrote: > >> > Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: >

Re: [PATCH v2 2/6] drm/sun4i: use drm_hdmi_connector_mode_valid()

2024-11-08 Thread Maxime Ripard
On Fri, Nov 01, 2024 at 02:25:05AM +0200, Dmitry Baryshkov wrote: > Use new drm_hdmi_connector_mode_valid() helper instead of a > module-specific copy. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +--- > 1 file chan

Re: [PATCH 2/2] drm/rockchip: dsi: Don't log errors on deferred dphy

2024-11-08 Thread Dragan Simic
Hello Sebastian, On 2024-11-08 15:08, Sebastian Reichel wrote: On Fri, Nov 08, 2024 at 02:53:58PM +0100, Dragan Simic wrote: Deferred driver probing shouldn't result in errors or warnings being logged, because their presence in the kernel log provides no value and may actually cause false impr

Re: [PATCH] dma-buf: fix dma_fence_array_signaled

2024-11-08 Thread Christian König
Am 08.11.24 um 14:01 schrieb Tvrtko Ursulin: On 08/11/2024 09:42, Christian König wrote: The function silently assumed that signaling was already enabled for the dma_fence_array. This meant that without enabling signaling first we would never see forward progress. Fix that by falling back to

Re: [PATCH v2 1/6] drm/display: hdmi: add generic mode_valid helper

2024-11-08 Thread Maxime Ripard
Hi, On Fri, Nov 01, 2024 at 02:25:04AM +0200, Dmitry Baryshkov wrote: > Add drm_hdmi_connector_mode_valid(), generic helper for HDMI connectors. > It can be either used directly or as a part of the .mode_valid callback. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_hdm

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-08 Thread John Watts
On Fri, Nov 08, 2024 at 07:36:16PM +0530, Parthiban wrote: > To add, 0x20 will be DE0 <--> LCD0 and DE1 <--> TV0. Below note (copied from > R40) states the priority of the DE selection, which fails to work? Not sure, > may be disabling CORE1_SCLK_GATE and CORE1_HCLK_GATE in de2-clk helps. > > With

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Heiko Stübner
Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: > Hello Heiko, > > On 2024-11-08 14:56, Heiko Stübner wrote: > > Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: > >> Perform a few trivial code cleanups, to make one logged message a bit > >> more > >> consistent w

Re: [PATCH 2/2] drm/rockchip: dsi: Don't log errors on deferred dphy

2024-11-08 Thread Sebastian Reichel
Hi, On Fri, Nov 08, 2024 at 02:53:58PM +0100, Dragan Simic wrote: > Deferred driver probing shouldn't result in errors or warnings being logged, > because their presence in the kernel log provides no value and may actually > cause false impression that some issues exist. Thus, let's no longer pro

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Dragan Simic
Hello Heiko, On 2024-11-08 14:56, Heiko Stübner wrote: Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: Perform a few trivial code cleanups, to make one logged message a bit more consistent with the other logged messages by capitalizing its first word, and to avoid line wrappi

Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Heiko Stübner
Hey Dragan, Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: > Perform a few trivial code cleanups, to make one logged message a bit more > consistent with the other logged messages by capitalizing its first word, and > to avoid line wrapping by using the 100-column width better. >

[PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups

2024-11-08 Thread Dragan Simic
Perform a few trivial code cleanups, to make one logged message a bit more consistent with the other logged messages by capitalizing its first word, and to avoid line wrapping by using the 100-column width better. No intended functional changes are introduced by these code cleanups. Signed-off-by

[PATCH 2/2] drm/rockchip: dsi: Don't log errors on deferred dphy

2024-11-08 Thread Dragan Simic
Deferred driver probing shouldn't result in errors or warnings being logged, because their presence in the kernel log provides no value and may actually cause false impression that some issues exist. Thus, let's no longer produce error messages when getting the dphy results in deferred probing. T

[PATCH 0/2] No longer produce error messages when dphy is deferred

2024-11-08 Thread Dragan Simic
This is a small series that makes the deferred dphy no longer emit error messages to the kernel log, which may even be repeated multiple times, to avoid possible false impression of some issues. This series also performs a few small, rather trivial code cleanups, to make the code a bit easier to r

Re: [PATCH v7 4/7] drm/log: Do not draw if drm_master is taken

2024-11-08 Thread Jocelyn Falempe
On 08/11/2024 14:33, Thomas Zimmermann wrote: Hi Am 08.11.24 um 09:10 schrieb Jocelyn Falempe: When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe ---   drivers/gpu/drm/drm_log.c | 10 +++

Re: [PATCH v7 4/7] drm/log: Do not draw if drm_master is taken

2024-11-08 Thread Thomas Zimmermann
Hi Am 08.11.24 um 09:10 schrieb Jocelyn Falempe: When userspace takes drm_master, the drm_client buffer is no more visible, so drm_log shouldn't waste CPU cycle to draw on it. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_log.c | 10 -- 1 file changed, 8 insertions(+), 2 de

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-08 Thread John Watts
On Fri, Nov 08, 2024 at 11:53:57AM +, Andre Przywara wrote: > Hi John, Hi Andre! > Can you say *why* this patch is needed? Is there something broken that > needs fixing? Where does this show and why wasn't this a problem before? Oops, that's a good point. There is currently a bug where the L

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-08 Thread Chuck Lever III
> On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote: > > Hi, > > 在 2024/11/07 22:41, Chuck Lever 写道: >> On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote: >>> Hi, >>> >>> 在 2024/11/06 23:19, Chuck Lever III 写道: > On Nov 6, 2024, at 1:16 AM, Greg KH wrote: > > On Thu, O

  1   2   >