Re:Re: [PATCH v5 05/18] drm/rockchip: vop2: Set AXI id for rk3588

2024-12-11 Thread Andy Yan
Hi Detlev, At 2024-12-11 23:45:01, "Detlev Casanova" wrote: >On Wednesday, 11 December 2024 01:34:34 EST Andy Yan wrote: >> Hi Detlev, >> >> At 2024-12-11 02:40:14, "Detlev Casanova" >wrote: >> >Hi Andy, >> > >> >On Monday, 9 December 2024 07:29:18 EST Andy Yan wrote: >> >> From: Andy Yan >>

Re: [PATCH 0/3] virtgpu: check if P2P is possiable or not

2024-12-11 Thread Juergen Gross
On 07.12.24 11:50, Julia Zhang wrote: To implement dGPU prime feature, virtgpu needs to import/export buffer between virtio iGPU and passthrough dGPU. Before that, virtgpu should check if P2P is possible or not. But calling function pci_p2pdma_distance in guest VM will only get virtual p2pdma_dis

Re: [PATCH v9 2/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-11 Thread Dan Carpenter
This patch breaks "make oldconfig" for me. It just gets into an endless loop of: Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 Default DRM Client choice[1-0?]: 0 ... I don't have to type anything, it just spams that for

Re: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-11 Thread Chen-Yu Tsai
On Thu, Dec 12, 2024 at 1:51 PM Xin Ji wrote: > > When user enabled HDCP feature, userspace will set HDCP content > to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update > HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream > support HDCP feature. > > However once HDCP c

Re: [PATCH v2 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

2024-12-11 Thread Krzysztof Kozlowski
On 12/12/2024 04:05, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Wed, 2024-12-11 at 10:37 +0100, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On Wed, Dec

Re: [PATCH v2 2/8] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2024-12-11 Thread Krzysztof Kozlowski
On 12/12/2024 04:41, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Wed, 2024-12-11 at 10:39 +0100, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On Wed, Dec

[PATCH] drm/virtio: Fix Smatch tool warnings in virtgpu_dma_buf_free_obj()

2024-12-11 Thread Vivek Kasireddy
Fix the following issues identified by Smatch static checker: - The call to dma_buf_put(attach->dmabuf) after dma_buf_detach() leads to a UAF bug as dma_buf_detach() frees the attach object. Fix this by extracting the dmabuf object from attach and using that in the call to dma_buf_put(). - T

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Vignesh Raman
Hi Dmitry, On 12/12/24 03:09, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote: Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- v1: - Pipeline link - https://gitlab.freedesktop.org/vigneshraman/linux/-/pi

[PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-11 Thread Xin Ji
When user enabled HDCP feature, userspace will set HDCP content to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream support HDCP feature. However once HDCP content turn to DRM_MODE_CONTENT_PROTECTION_ENABLED userspace

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Vignesh Raman
Hi Helen, On 11/12/24 21:57, Helen Mae Koike Fornazier wrote: Hi Vignesh, thanks for the patch. On Wed, 11 Dec 2024 11:28:05 -0300 Vignesh Raman wrote --- > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com

RE: [PATCH v2] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-11 Thread Xin Ji
Hi Dmitry and Pin-yen Lin, thanks for the review. > -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, December 12, 2024 7:20 AM > To: Pin-yen Lin > Cc: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman > ; Jernej Skrabec ; Maarten >

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-11 Thread Pavan Kondeti
On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > On Wed, 11 Dec 2024 00:37:34 +, > Pavan Kondeti wrote: > > > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > > > +static int a6xx_switch_secure_mode(struct msm_gpu *gpu) > > > > +{ > > > > + int ret; > >

Re: [PATCH] drm/ci: add kms_cursor_legacy@torture-bo to apq8016 flakes

2024-12-11 Thread Vignesh Raman
Hi Abhinav / Helen, On 12/12/24 01:48, Abhinav Kumar wrote: Hi Helen / Vignesh On 12/4/2024 12:33 PM, Helen Mae Koike Fornazier wrote: On Wed, 04 Dec 2024 16:21:26 -0300 Abhinav Kumar  wrote ---   > Hi Helen   >   > On 12/4/2024 11:14 AM, Helen Mae Koike Fornazier wrote:   > > Hi Abh

Re: [PATCH v2 19/29] drm/xe: Add GPUSVM devic memory copy vfunc functions

2024-12-11 Thread Matthew Brost
On Mon, Dec 02, 2024 at 11:13:55AM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > > Add GPUSVM devic memory copy vfunc functions and connect to migration > > s/devic/device Yes. > > > > > layer. > > > > v2: > >  - Allow NULL device pages in xe_svm_

Re: [PATCH v2 7/8] drm/mediatek: Add programming flow for unsupported subsys ID hardware

2024-12-11 Thread 林睿祥

Re: [PATCH v2 2/8] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

2024-12-11 Thread 林睿祥

Re: [PATCH v3 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: All other submodules pass arguments directly. Drop struct msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass all data to msm_dp_panel_get() directly. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/g

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not programmed earlier. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/

Re: [PATCH v3 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Having I/O regions inside a msm_dp_catalog_private() results in extra layers of one-line wrappers for accessing the data. Move I/O region base and size to the globally visible struct msm_dp_catalog. Reviewed-by: Stephen Boyd Signed-off-by: Dmitr

Re: [PATCH v2 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

2024-12-11 Thread 林睿祥

Re: [PATCH] drm/exynos: Remove unnecessary checking

2024-12-11 Thread Inki Dae
Hi, 2024년 12월 6일 (금) 오후 8:45, Guoqing Jiang 님이 작성: > > It is not needed since drm_atomic_helper_shutdown checks it. Correct. Merged. Thanks, Inki Dae > > Signed-off-by: Guoqing Jiang > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

[PATCH -next] drm/amd/display: use swap() in update_phy_id_mapping()

2024-12-11 Thread Jiapeng Chong
Use existing swap() function rather than duplicating its implementation. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING opportunity for swap(). ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:125:53-54: WARNING opportunity for swap(). Reported-by: Abaci Robot

RE: [PATCH v2 0/3] fixes for udmabuf (memfd sealing checks and a leak)

2024-12-11 Thread Kasireddy, Vivek
Hi Jann, > Subject: [PATCH v2 0/3] fixes for udmabuf (memfd sealing checks and a leak) > > I have tested that patches 2 and 3 work using the following reproducers. > I did not write a reproducer for the issue described in patch 1. > > Reproducer for F_SEAL_FUTURE_WRITE not being respected: > ```

Re: [PATCH v3 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer for the header output, while it expects a two-element array. It performs a sizeof check which is always true on 64-bit platforms (since sizeof(u32*) is 8) and is always false

Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Rather than printing random garbage from stack and pretending that it is the default safe_to_exit_level, set the variable beforehand. Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Reported-by: kernel test robot Cl

Re: [PATCH v3 03/14] drm/msm/dp: drop msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs()

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: The msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs() are not called anywhere. If there is a necessity to dump registers, the snapshotting should be used instead. Drop these two functions. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Ba

RE: [PATCH v2 1/3] udmabuf: fix racy memfd sealing check

2024-12-11 Thread Kasireddy, Vivek
> Subject: [PATCH v2 1/3] udmabuf: fix racy memfd sealing check > > The current check_memfd_seals() is racy: Since we first do > check_memfd_seals() and then udmabuf_pin_folios() without holding any > relevant lock across both, F_SEAL_WRITE can be set in between. > This is problematic because we c

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-11 Thread Lyude Paul
On Wed, 2024-12-11 at 09:43 +0100, Simona Vetter wrote: > On Tue, Dec 10, 2024 at 06:41:52PM -0500, Lyude Paul wrote: > > On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > > > Hi Lyude, > > > > > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > > > > > + > > > > +impl Connector {

Re: [PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-11 Thread Lyude Paul
Coming in again with the good patches I see :D Apologies for not seeing these patches before, I really need to figure out a way to keep up with dri-devel outside of patches that are CC'd to me :S (if you ever need me to review something, you're more then welcome to poke me via IRC btw) For patche

[PATCH] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()

2024-12-11 Thread Karol Przybylski
This patch fixes a potential integer overflow in the zynqmp_dp_rate_get() function. The issue comes up when the expression drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 1 is evaluated using 32-bit arithmetic. Now the constant is casted to compatible u64 type. Resolves CID 1636340 and CI

Re: [PATCH v2 0/4] Add support for HDMI1 output on RK3588 SoC

2024-12-11 Thread Alexandre ARNOUD
Hello Cristian, > On 11 Dec 2024, at 12:06 AM, Cristian Ciocaltea > wrote: > > Changes in v2: > - Override hdmi1 pinctrl-0 on rock-5b as it requires hdmim0_tx1_cec > instead of hdmim2_tx1_cec (fixes a pin conflict when enabling > CONFIG_SPI_ROCKCHIP_SFC) > - Link to v1: > https://lore.kernel

[PATCH 6.1.y] drm/amd/display: fix NULL checks for adev->dm.dc in amdgpu_dm_fini()

2024-12-11 Thread jianqi.ren.cn
From: Nikita Zhandarovich [ Upstream commit 2a3cfb9a24a28da9cc13d2c525a76548865e182c ] Since 'adev->dm.dc' in amdgpu_dm_fini() might turn out to be NULL before the call to dc_enable_dmub_notifications(), check beforehand to ensure there will not be a possible NULL-ptr-deref there. Also, since c

[PATCH 6.1.y] drm/amd/display: Don't refer to dc_sink in is_dsc_need_re_compute

2024-12-11 Thread jianqi.ren.cn
From: Wayne Lin [ Upstream commit fcf6a49d79923a234844b8efe830a61f3f0584e4 ] [Why] When unplug one of monitors connected after mst hub, encounter null pointer dereference. It's due to dc_sink get released immediately in early_unregister() or detect_ctx(). When commit new state which directly

[PATCH 6.1.y] drm/amd/display: fixed integer types and null check locations

2024-12-11 Thread jianqi.ren.cn
From: Sohaib Nadeem [ Upstream commit 0484e05d048b66d01d1f3c1d2306010bb57d8738 ] [why]: issues fixed: - comparison with wider integer type in loop condition which can cause infinite loops - pointer dereference before null check Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org

[PATCH 6.1.y] drm/amd/display: Don't refer to dc_sink in is_dsc_need_re_compute

2024-12-11 Thread jianqi.ren.cn
From: Wayne Lin [ Upstream commit fcf6a49d79923a234844b8efe830a61f3f0584e4 ] [Why] When unplug one of monitors connected after mst hub, encounter null pointer dereference. It's due to dc_sink get released immediately in early_unregister() or detect_ctx(). When commit new state which directly

[PATCH 6.1.y] drm/amd/display: fix NULL checks for adev->dm.dc in amdgpu_dm_fini()

2024-12-11 Thread jianqi.ren.cn
From: Nikita Zhandarovich [ Upstream commit 2a3cfb9a24a28da9cc13d2c525a76548865e182c ] Since 'adev->dm.dc' in amdgpu_dm_fini() might turn out to be NULL before the call to dc_enable_dmub_notifications(), check beforehand to ensure there will not be a possible NULL-ptr-deref there. Also, since c

[PATCH] Revert "drm/mediatek: dsi: Correct calculation formula of PHY Timing"

2024-12-11 Thread Chun-Kuang Hu
This reverts commit 417d8c47271d5cf1a705e997065873b2a9a36fd4. With this patch the panel in the Tentacruel ASUS Chromebook CM14 (CM1402F) flickers. There are 1 or 2 times per second a black panel. Stable Kernel 6.11.5 and mainline 6.12-rc4 works only when reverse this patch. Reported-by: Jens Zill

[PATCH v3 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-12-11 Thread Dmitry Baryshkov
The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer for the header output, while it expects a two-element array. It performs a sizeof check which is always true on 64-bit platforms (since sizeof(u32*) is 8) and is always false on 32-bit platforms. It returns an error code which

[PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-11 Thread Dmitry Baryshkov
Rather than printing random garbage from stack and pretending that it is the default safe_to_exit_level, set the variable beforehand. Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/2024110

[PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-11 Thread Dmitry Baryshkov
Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not programmed earlier. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 288 +---

Re: [PATCH v6 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 03:43:20PM +0800, Liu Ying wrote: > On 12/10/2024, Dmitry Baryshkov wrote: > > On Mon, Dec 09, 2024 at 11:39:16AM +0800, Liu Ying wrote: > >> i.MX8qxp Display Controller(DC) is comprised of three main components that > >> include a blit engine for 2D graphics accelerations,

[PATCH v3 14/14] drm/msm/dp: move interrupt handling to dp_ctrl

2024-12-11 Thread Dmitry Baryshkov
It makes it easier to keep all interrupts-related code in dp_ctrl submodule. Move all functions to dp_ctrl.c. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 9 +-- drivers/gpu/drm/msm/dp/dp_aux.h | 2 +- drivers/gpu/drm/msm/dp/dp_cata

[PATCH v3 07/14] drm/msm/dp: move/inline ctrl register functions

2024-12-11 Thread Dmitry Baryshkov
Move CTRL-related functions to dp_ctrl.c, inlining one line wrappers during this process. The enable/disable functions have been split to the enable/disable or enter/exit pairs. The IRQ and HPD related functions are left in dp_catalog.c, pending later cleanup. Reviewed-by: Stephen Boyd Signed-off

[PATCH v3 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-11 Thread Dmitry Baryshkov
All other submodules pass arguments directly. Drop struct msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass all data to msm_dp_panel_get() directly. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gp

[PATCH v3 05/14] drm/msm/dp: move I/O functions to global header

2024-12-11 Thread Dmitry Baryshkov
Move msm_dp_read()/msm_write_foo() functions to the dp_catalog.h, allowing other modules to access the data directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 65 - drivers/gpu/drm/msm/dp/dp_catalog.h | 62 +

[PATCH v3 12/14] drm/msm/dp: move more AUX functions to dp_aux.c

2024-12-11 Thread Dmitry Baryshkov
Move several misnamed functions accessing AUX bus to dp_aux.c, further cleaning up dp_catalog submodule. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 94 - drivers/gpu/drm/msm/dp/dp_aux.h | 7 +++ dr

[PATCH v3 11/14] drm/msm/dp: move/inline audio related functions

2024-12-11 Thread Dmitry Baryshkov
Move audio-related functions to dp_audio.c, following up the cleanup done by the rest of the submodules. Inline functions with simple register access patterns. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 72 + driv

[PATCH v3 10/14] drm/msm/dp: drop obsolete audio headers access through catalog

2024-12-11 Thread Dmitry Baryshkov
Drop obsolete functions to access audio packet headers. The dp_audio.c now writes them using msm_dp_write_link() directly. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 2 - drivers/gpu/drm/msm/dp/dp_catalog.c | 76 -

[PATCH v3 03/14] drm/msm/dp: drop msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs()

2024-12-11 Thread Dmitry Baryshkov
The msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs() are not called anywhere. If there is a necessity to dump registers, the snapshotting should be used instead. Drop these two functions. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c |

[PATCH v3 08/14] drm/msm/dp: move/inline panel related functions

2024-12-11 Thread Dmitry Baryshkov
Move panel-related functions to dp_panel.c, following up the cleanup done by the rest of the submodules. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 192 - drivers/gpu/drm/msm/dp/dp_catalog.h | 9 -- drive

[PATCH v3 06/14] drm/msm/dp: move/inline AUX register functions

2024-12-11 Thread Dmitry Baryshkov
Move all register-level functions to dp_aux.c, inlining one line wrappers during this process. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 96 +++-- drivers/gpu/drm/msm/dp/dp_catalog.c | 96 - drive

[PATCH v3 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-11 Thread Dmitry Baryshkov
Having I/O regions inside a msm_dp_catalog_private() results in extra layers of one-line wrappers for accessing the data. Move I/O region base and size to the globally visible struct msm_dp_catalog. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.

[PATCH v3 00/14] drm/msm/dp: perform misc cleanups

2024-12-11 Thread Dmitry Baryshkov
- Fix register programming in the dp_audio module - Rework most of the register programming functions to be local to the calling module rather than accessing everything through huge dp_catalog monster. Signed-off-by: Dmitry Baryshkov --- Changes in v3: - Fixed falce -> false typo (Abhinav) -

[PULL] drm-xe-next

2024-12-11 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first Xe PR towards 6.14. It's important to highlight that in couple backmerges we had to manually solve some silent conflicts: 1. Namespace conflict issue caused by commit cdd30ebb1b9f ("module: Convert symbol namespace to string literal") and commit 0c45e76fcc62

Re: [PATCH v2] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 11:54:54PM +0800, Pin-yen Lin wrote: > Hi Dimitry, > > Thanks for the review. > > On Wed, Dec 11, 2024 at 5:44 PM Dmitry Baryshkov > wrote: > > > > On Mon, Dec 09, 2024 at 02:46:32PM +0800, Xin Ji wrote: > > > When user enabled HDCP feature, upper layer will set HDCP cont

Re: [PATCH v5 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 08:57:17AM +0100, Andrej Picej wrote: > > > On 10. 12. 24 14:59, Dmitry Baryshkov wrote: > > On Tue, Dec 10, 2024 at 02:41:01PM +0100, Andrej Picej wrote: > > > > > > > > > On 10. 12. 24 12:43, Dmitry Baryshkov wrote: > > > > On Tue, Dec 10, 2024 at 10:19:00AM +0100, And

[PATCH v3 07/11] drm/nouveau/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

[PATCH v3 10/11] drm/i915/dp_mst: Fix error handling while adding a connector

2024-12-11 Thread Imre Deak
After an error during adding an MST connector the MST port and the intel_connector object could be leaked, fix this up. Reviewed-by: Rodrigo Vivi Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) dif

[PATCH v3 06/11] drm/amd/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

[PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

2024-12-11 Thread Imre Deak
MST connectors should be initialized/registered by calling drm_connector_dynamic_init()/drm_connector_dynamic_register(). The previous patch adding these functions explains the issue with the current drm_connector_init*()/drm_connector_register() interface for MST connectors. Based on the above ad

[PATCH v3 11/11] drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in intel_dp_mst.c

2024-12-11 Thread Imre Deak
Follow the canonical way in intel_dp_mst.c, referencing a connector only via a struct intel_connector pointer and naming this pointer 'connector' instead of 'intel_connector', the only exception being the casting of a drm_connector function parameter pointer to intel_connector, calling the drm_conn

[PATCH v3 09/11] drm/tests: Add tests for drm_connector_dynamic_init()/register()

2024-12-11 Thread Imre Deak
Add kunit tests for drm_connector_dynamic_init()/drm_connector_dynamic_register() added in this patchset. Suggested-by: Maxime Ripard Signed-off-by: Imre Deak --- drivers/gpu/drm/tests/drm_connector_test.c | 463 + 1 file changed, 463 insertions(+) diff --git a/drivers/gpu/

[PATCH v3 08/11] drm/connector: Warn if a connector is registered/added incorrectly

2024-12-11 Thread Imre Deak
All the drivers should be converted now to use drm_connector_dynamic_init() for MST connectors, hence drm_connector_dynamic_register()->drm_connector_add() can WARN now if this was not the case (for instance if a driver inited an MST connector with one of the drm_connector_init*() functions incorre

[PATCH v3 05/11] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

[PATCH v3 03/11] drm/connector: Add deprication notes for drm_connector_register/unregister

2024-12-11 Thread Imre Deak
Drivers should register/unregister only dynamic (MST) connectors manually using drm_connector_dynamic_register()/unregister(). Static connectors are registered/unregistered by the DRM core automatically. Some drivers still call drm_connector_register()/ unregister() for static connectors, both of w

[PATCH v3 02/11] drm/connector: Add FIXME for GETRESOURCES ioctl wrt. uninited connectors

2024-12-11 Thread Imre Deak
The connectors enumerated by the GETRESOURCES ioctl may not be fully initialized yet wrt. to the state set up during connector registration (for instance the connector's debugfs/sysfs interfaces may not exist yet). This can happen in two ways: 1. Connectors initialized and added to the drm_mode

[PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-11 Thread Imre Deak
Atm when the connector is added to the drm_mode_config::connector_list, the connector may not be fully initialized yet. This is not a problem for static connectors initialized/added during driver loading, for which the driver ensures that look-ups via the above list are not possible until all the c

[PATCH v3 0/7] drm/connector: Expose only a properly inited connector

2024-12-11 Thread Imre Deak
This is v3 of [1], with the following changes: - Instead of the drm_connector_init_core()/drm_connector_add() add a drm_connector_dynamic_init()/drm_connector_dynamic_register() interface. Adding the connector to the connector list is now part of the registration step done by the latter func

Re: [PATCH v2 14/14] drm/msm/dp: move interrupt handling to dp_ctrl

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:44) > It makes it easier to keep all interrupts-related code in dp_ctrl > submodule. Move all functions to dp_ctrl.c. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 12/14] drm/msm/dp: move more AUX functions to dp_aux.c

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:42) > Move several misnamed functions accessing AUX bus to dp_aux.c, further > cleaning up dp_catalog submodule. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/3] drm: bridge: adv7511: remove s32 format from i2s capabilities

2024-12-11 Thread Dmitry Baryshkov
On Tue, Dec 10, 2024 at 02:42:53PM +0100, Olivier Moysan wrote: > The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for > direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format). > However the HDMI codec exposes S32_LE format as supported. > Adapt ADV7511 HDMI I2S format list

Re: [PATCH v2 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:43) > All other submodules pass arguments directly. Drop struct > msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass > all data to msm_dp_panel_get() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/3] drm: bridge: adv7511: fill i2s stream capabilities

2024-12-11 Thread Dmitry Baryshkov
On Tue, Dec 10, 2024 at 02:42:52PM +0100, Olivier Moysan wrote: > Set no_i2s_capture flag in hdmi_codec_pdata structure to report > that the ADV7511 HDMI bridge does not support i2s audio capture. > > Signed-off-by: Olivier Moysan > --- > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + > 1

Re: [PATCH v2] drm/msm/dpu: check dpu_plane_atomic_print_state() for valid sspp

2024-12-11 Thread Doug Anderson
Hi, On Wed, Dec 11, 2024 at 11:51 AM Abhinav Kumar wrote: > > Similar to the r_pipe sspp protect, add a check to protect > the pipe state prints to avoid NULL ptr dereference for cases when > the state is dumped without a corresponding atomic_check() where the > pipe->sspp is assigned. > > Fixes:

Re: [PATCH v3 2/2] drm/tests: Add test for drm_atomic_helper_commit_modeset_disables()

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 01:18:43PM -0800, Jessica Zhang wrote: > Add a subtest to check that modeset is called when the connector is > changed > > Signed-off-by: Jessica Zhang > --- > Changes in v3: > - Use BUILD_BUG_ON to check connectors and encoders array sizes (Dmitry) > - Renamed functions t

Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

2024-12-11 Thread Heiko Stuebner
On Fri, 06 Dec 2024 19:26:10 +, Piotr Zalewski wrote: > Remove color_mgmt_changed check from vop2_crtc_atomic_try_set_gamma to > allow gamma LUT rewrite during modeset when coming out of suspend. Add > a check for color_mgmt_changed directly in vop2_crtc_atomic_flush. > > This patch fixes th

Re: [PATCH] drm/rockchip: dw_hdmi_qp: Simplify clock handling

2024-12-11 Thread Heiko Stuebner
On Mon, 02 Dec 2024 22:27:34 +0200, Cristian Ciocaltea wrote: > Make use of the recently introduced devm_clk_bulk_get_all_enabled() > helper to simplify the code a bit. > > Applied, thanks! [1/1] drm/rockchip: dw_hdmi_qp: Simplify clock handling commit: 19851fa2ba9824bede16f55234f63d942

Re: [PATCH] drm/rockchip: Remove unnecessary checking

2024-12-11 Thread Heiko Stuebner
On Fri, 06 Dec 2024 19:42:33 +0800, Guoqing Jiang wrote: > It is not needed since drm_atomic_helper_shutdown checks it. > > Applied, thanks! [1/1] drm/rockchip: Remove unnecessary checking commit: 8ddc8dfb8329349d5efb0418c9f20025333e2d98 Best regards, -- Heiko Stuebner

Re: [PATCH v7 2/3] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-12-11 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 00:38, Abhinav Kumar wrote: > > > > On 12/11/2024 2:24 PM, Dmitry Baryshkov wrote: > > On Wed, Dec 11, 2024 at 01:51:51PM -0800, Abhinav Kumar wrote: > >> > >> > >> On 11/29/2024 5:55 PM, Dmitry Baryshkov wrote: > >>> Virtual wide planes give high amount of flexibility, but

Re: [PATCH v2 6/8] soc: mediatek: Add programming flow for unsupported subsys ID hardware

2024-12-11 Thread kernel test robot
Hi Jason-JH.Lin, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.13-rc2 next-20241211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v7 2/3] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-12-11 Thread Abhinav Kumar
On 12/11/2024 2:24 PM, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 01:51:51PM -0800, Abhinav Kumar wrote: On 11/29/2024 5:55 PM, Dmitry Baryshkov wrote: Virtual wide planes give high amount of flexibility, but it is not always enough: In parallel multirect case only the half of the us

Re: [PATCH v10 0/2] drm/atomic: Ease async flip restrictions

2024-12-11 Thread André Almeida
Hi Dmitry, Em 11/12/2024 16:35, Dmitry Baryshkov escreveu: On Wed, Dec 11, 2024 at 12:25:07AM -0300, André Almeida wrote: Hi, The goal of this work is to find a nice way to allow amdgpu to perform async page flips in the overlay plane as well, not only on the primary one. Currently, when using

Re: [PATCH v2 11/14] drm/msm/dp: move/inline audio related functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:41) > Move audio-related functions to dp_audio.c, following up the cleanup > done by the rest of the submodules. Inline functions with simple > register access patterns. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:39) > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > to program audio packet data. Use 0 as Packet ID, as it was not > programmed earlier. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd > diff --git a/dr

Re: [PATCH v2 10/14] drm/msm/dp: drop obsolete audio headers access through catalog

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:40) > Drop obsolete functions to access audio packet headers. The dp_audio.c > now writes them using msm_dp_write_link() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 08/14] drm/msm/dp: move/inline panel related functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:38) > Move panel-related functions to dp_panel.c, following up the cleanup > done by the rest of the submodules. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v7 2/3] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 01:51:51PM -0800, Abhinav Kumar wrote: > > > On 11/29/2024 5:55 PM, Dmitry Baryshkov wrote: > > Virtual wide planes give high amount of flexibility, but it is not > > always enough: > > > > In parallel multirect case only the half of the usual width is supported > > for t

Re: [PATCH v2 07/14] drm/msm/dp: move/inline ctrl register functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:37) > Move CTRL-related functions to dp_ctrl.c, inlining one line wrappers > during this process. The enable/disable functions have been split to the > enable/disable or enter/exit pairs. The IRQ and HPD related functions > are left in dp_catalog.c, pendin

Re: [PATCH v2 6/8] soc: mediatek: Add programming flow for unsupported subsys ID hardware

2024-12-11 Thread kernel test robot
Hi Jason-JH.Lin, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.13-rc2 next-20241211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:34) > Having I/O regions inside a msm_dp_catalog_private() results in extra > layers of one-line wrappers for accessing the data. Move I/O region base > and size to the globally visible struct msm_dp_catalog. > > Signed-off-by: Dmitry Baryshkov > --- Rev

[pull] amdgpu, amdkfd drm-fixes-6.13

2024-12-11 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.13. The following changes since commit 73dae652dcac776296890da215ee7dec357a1032: drm/amdgpu: rework resume handling for display (v2) (2024-12-03 18:19:23 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-dr

Re: [PATCH v7 2/3] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-12-11 Thread Abhinav Kumar
On 11/29/2024 5:55 PM, Dmitry Baryshkov wrote: Virtual wide planes give high amount of flexibility, but it is not always enough: In parallel multirect case only the half of the usual width is supported for tiled formats. Thus the whole width of two tiled multirect rectangles can not be greate

Re: [PATCH v2 23/29] drm/xe: Add BO flags required for SVM

2024-12-11 Thread Matthew Brost
On Mon, Dec 02, 2024 at 11:44:47AM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:25 -0700, Matthew Brost wrote: > > Add XE_BO_FLAG_SYSTEM_ALLOC to indicate BO is tied to SVM range. > > > > Add XE_BO_FLAG_SKIP_CLEAR to indicate BO does not need to cleared. > > > > v2: > >  - Take VM re

Re: [v9,1/6] drm/panic: Move drawing functions to drm_draw

2024-12-11 Thread Kees Bakker
Op 04-12-2024 om 16:45 schreef Jocelyn Falempe: Move the color conversions, blit and fill functions to drm_draw.c, so that they can be re-used by drm_log. drm_draw is internal to the drm subsystem, and shouldn't be used by gpu drivers. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmerma

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > > v1: > - Pipeline link - > https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1327810 > Will update the flake

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 13:16:56) > On Wed, 11 Dec 2024 at 23:11, Stephen Boyd wrote: > > > > It is pure DP. Maybe we can have a google,cros-ec-usbc-hdmi compatible > > string here because this is a weird design. > > Just google,cros-ec-hdmi for the corresponding connector? > Sure.

Re: [PATCH v2 03/14] drm/msm/dp: drop msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs()

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:33) > The msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs() are not > called anywhere. If there is a necessity to dump registers, the > snapshotting should be used instead. Drop these two functions. > > Signed-off-by: Dmitry Baryshkov > --- Reviewe

Re: [PATCH v2 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:32) > The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer > for the header output, while it expects a two-element array. It performs > a sizeof check which is always true on 64-bit platforms (since > sizeof(u32*) is 8) and is always fa

Re: [PATCH v2 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:31) > Rather than printing random garbage from stack and pretending that it is > the default safe_to_exit_level, set the variable beforehand. > > Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM") > Reported-by: kernel test robot

[PATCH v3 2/2] drm/tests: Add test for drm_atomic_helper_commit_modeset_disables()

2024-12-11 Thread Jessica Zhang
Add a subtest to check that modeset is called when the connector is changed Signed-off-by: Jessica Zhang --- Changes in v3: - Use BUILD_BUG_ON to check connectors and encoders array sizes (Dmitry) - Renamed functions to be more test-specific (Dmitry) - Added comment description for test (Dmitry)

  1   2   3   >