Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-03-03 Thread Sumit Garg
On Tue, Mar 04, 2025 at 08:17:23AM +0100, Jens Wiklander wrote: > Hi Daniel, > > On Fri, Feb 21, 2025 at 3:12 PM Daniel Stone wrote: > > > > Hi Sumit, > > > > On Fri, 21 Feb 2025 at 11:24, Sumit Garg wrote: > > > On Tue, 18 Feb 2025 at 21:52, Daniel Stone wrote: > > > > dma-heaps was created to

Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

2025-03-03 Thread Krzysztof Kozlowski
On 04/03/2025 08:38, Michal Wilczynski wrote: > > > On 3/3/25 18:43, Krzysztof Kozlowski wrote: >> On 03/03/2025 09:38, Michal Wilczynski wrote: >>> >>> >>> On 2/21/25 10:12, Krzysztof Kozlowski wrote: On Wed, Feb 19, 2025 at 03:02:18PM +0100, Michal Wilczynski wrote: > The LicheePi 4A b

Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

2025-03-03 Thread Michal Wilczynski
On 3/3/25 18:43, Krzysztof Kozlowski wrote: > On 03/03/2025 09:38, Michal Wilczynski wrote: >> >> >> On 2/21/25 10:12, Krzysztof Kozlowski wrote: >>> On Wed, Feb 19, 2025 at 03:02:18PM +0100, Michal Wilczynski wrote: The LicheePi 4A board, featuring the T-HEAD TH1520 SoC, includes an

Re: [PATCH] drm/sched: drm_sched_job_cleanup(): correct false doc

2025-03-03 Thread Philipp Stanner
On Mon, 2025-03-03 at 17:13 +, Tvrtko Ursulin wrote: > > On 03/03/2025 14:32, Philipp Stanner wrote: > > drm_sched_job_cleanup()'s documentation claims that calling > > drm_sched_job_arm() is a "point of no return", implying that > > afterwards > > a job cannot be cancelled anymore. > > > > T

Re: [PATCH v2 2/5] drm/scheduler: Add scheduler unit testing infrastructure and some basic tests

2025-03-03 Thread Philipp Stanner
On Mon, 2025-03-03 at 15:53 +, Tvrtko Ursulin wrote: > > On 03/03/2025 11:38, Philipp Stanner wrote: > > Sry for being late to the party, am a bit busy with defusing my own > > dynamite <.< > > > > On Fri, 2025-02-21 at 12:09 +, Tvrtko Ursulin wrote: > > > Implement a mock scheduler backe

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-03-03 Thread Jens Wiklander
Hi Daniel, On Fri, Feb 21, 2025 at 3:12 PM Daniel Stone wrote: > > Hi Sumit, > > On Fri, 21 Feb 2025 at 11:24, Sumit Garg wrote: > > On Tue, 18 Feb 2025 at 21:52, Daniel Stone wrote: > > > dma-heaps was created to solve the problem of having too many > > > 'allocate $n bytes from $specialplace'

Re:Re: [PATCH 2/6] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-03-03 Thread Andy Yan
Hi Dmitry, 在 2025-03-03 00:21:06,"Dmitry Baryshkov" 写道: >On Sun, Mar 02, 2025 at 06:34:22PM +0800, Andy Yan wrote: >> >> >> Hi Dmitry, >>Thank you for your review。 >>Please also review my inline reply. >> >> 在 2025-03-02 02:14:19,"Dmitry Baryshkov" 写道: >> >On Sun, Feb 23, 2025

RE: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-03-03 Thread Kasireddy, Vivek
Hi Jason, > Subject: Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported > through dmabuf > > On Wed, Feb 26, 2025 at 07:55:07AM +, Kasireddy, Vivek wrote: > > > > Is there any update or ETA for the v3? Are there any ways we can help? > > > I believe Leon's series is very close

[PATCH] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()

2025-03-03 Thread Wentao Liang
Add error handling to propagate amdgpu_cgs_create_device() failures to the caller. When amdgpu_cgs_create_device() fails, immediately return -EINVAL to stop further processing and prevent null pointer dereference. Signed-off-by: Wentao Liang --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c |

[PATCH] drm/ast: Support both SHMEM helper and VRAM helper

2025-03-03 Thread Huacai Chen
Commit f2fa5a99ca81ce105653 ("drm/ast: Convert ast to SHMEM") converts ast from VRAM helper to SHMEM helper. The convertion makesast support higher display resolutions, but the performance decreases significantly on platforms which don't support writecombine (fallback to uncached). This patch impl

Re: [PATCH] drm/vmwgfx: Add error path for xa_store in vmw_bo_add_detached_resource

2025-03-03 Thread Zack Rusin
On Tue, Feb 25, 2025 at 9:54 AM Keisuke Nishimura wrote: > > The xa_store() may fail due to memory allocation failure because there > is no guarantee that the index is already used. This fix introduces new > paths to handle the error. > > This patch also aligns the order of function calls by calli

Re: [PATCH] drm/vmwgfx: Add seqno waiter for sync_files

2025-03-03 Thread Zack Rusin
On Fri, Feb 28, 2025 at 3:06 PM Ian Forbes wrote: > > Because sync_files are passive waiters they do not participate in > the processing of fences like the traditional vmw_fence_wait IOCTL. > If userspace exclusively uses sync_files for synchronization then > nothing in the kernel actually process

Re: [PATCH RESEND] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2025-03-03 Thread Dan Carpenter
On Mon, Mar 03, 2025 at 08:41:06PM +0100, Danilo Krummrich wrote: > On Mon, Mar 03, 2025 at 06:49:07PM +0100, Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 5 Apr 2023 18:38:54 +0200 > > > > The label “out_prevalid” was used to jump to another pointer check > > despite of the detai

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-03 Thread Dmitry Baryshkov
On Tue, Mar 04, 2025 at 10:23:14AM +0800, Yongbang Shi wrote: > > On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: > > > > On Sat, 1 Mar 2025 at 11:54, Yongbang Shi > > > > wrote: > > > > > > On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: > > > > > > > > On Thu, Feb 27

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-03 Thread Dmitry Baryshkov
On Tue, 4 Mar 2025 at 03:44, Jessica Zhang wrote: > > > > On 3/3/2025 3:49 PM, Dmitry Baryshkov wrote: > > On Mon, Mar 03, 2025 at 10:28:00AM -0800, Jessica Zhang wrote: > >> If new CTLs are reserved by CRTC but atomic_enable() is skipped, the > >> encoders will configure the stale CTL instead of

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-03 Thread Jessica Zhang
On 3/3/2025 3:49 PM, Dmitry Baryshkov wrote: On Mon, Mar 03, 2025 at 10:28:00AM -0800, Jessica Zhang wrote: If new CTLs are reserved by CRTC but atomic_enable() is skipped, the encoders will configure the stale CTL instead of the newly reserved one. The CTLs are propagates in .atomic_mode_s

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-03 Thread Yongbang Shi
On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi wrote: On Tue, Feb 25, 2025 at 09:57:17PM +0800, Yongbang Shi wro

Re: [PATCH v3 02/16] scsi: lpfc: convert timeouts to secs_to_jiffies()

2025-03-03 Thread Martin K. Petersen
Easwar, > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies() to avoid the > multiplication Fixed compilation error and applied to 6.15/scsi-staging, thanks! --

Re: [PATCH v2 1/2] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-03-03 Thread Andy Yan
Hi Heiko, On 3/2/25 01:35, Heiko Stuebner wrote: From: Heiko Stuebner The LVDS block needs a separate pclk only on some socs, so currently requests and prepares it in the soc-specific probe function, but common code is required to unprepare it in the error path or on driver remove. While thi

Re: [PATCH v2 2/2] drm/rockchip: lvds: Hide scary error messages on probe deferral

2025-03-03 Thread Andy Yan
Hi Heiko, On 3/2/25 01:35, Heiko Stuebner wrote: From: Heiko Stuebner Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when probing defer") already started hiding scary messages that are not relevant if the requested supply just returned EPROBE_DEFER, but there are more po

[Bug 219835] amdgpu: kernel oops dc_dmub_srv_apply_idle_power_optimizations

2025-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219835 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[Bug 219834] amdgpu: kernel oops dce_aux_transfer_raw

2025-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219834 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v2 05/16] dt-bindings: display/msm: dp-controller: Add SM8750

2025-03-03 Thread Dmitry Baryshkov
On Mon, Mar 03, 2025 at 01:23:11PM -0800, Abhinav Kumar wrote: > > > On 2/24/2025 7:14 PM, Dmitry Baryshkov wrote: > > On Mon, 24 Feb 2025 at 20:59, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 2/19/2025 9:08 AM, Dmitry Baryshkov wrote: > > > > On Wed, Feb 19, 2025 at 06:02:20PM +0100

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Dmitry Baryshkov
On Mon, Mar 03, 2025 at 11:43:11AM -0500, Alyssa Rosenzweig wrote: > > > Sasha Finkelstein (5): > > >dt-bindings: display: Add Apple pre-DCP display controller > > >drm: adp: Add Apple Display Pipe driver > > >drm: panel: Add a panel driver for the Summit display > > >

Re: [PATCH v6 03/14] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-03-03 Thread Dmitry Baryshkov
On Mon, Mar 03, 2025 at 10:45:19AM -0800, Jessica Zhang wrote: > > > On 2/27/2025 7:07 AM, Dmitry Baryshkov wrote: > > On Fri, Feb 14, 2025 at 04:14:26PM -0800, Jessica Zhang wrote: > > > From: Dmitry Baryshkov > > > > > > Up to now the driver has been using encoder to allocate hardware > > > r

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-03 Thread Dmitry Baryshkov
On Mon, Mar 03, 2025 at 10:28:00AM -0800, Jessica Zhang wrote: > If new CTLs are reserved by CRTC but atomic_enable() is skipped, the > encoders will configure the stale CTL instead of the newly reserved one. The CTLs are propagates in .atomic_mode_set(), not in .atomic_enable(). > > Avoid this

RE: [PATCH v4 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Lin, Shuicheng
On Mon, Mar 03 2025 at 14:00, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed failed pagefaults from > a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it > i

[Bug 219835] New: amdgpu: kernel oops dc_dmub_srv_apply_idle_power_optimizations

2025-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219835 Bug ID: 219835 Summary: amdgpu: kernel oops dc_dmub_srv_apply_idle_power_optimizations Product: Drivers Version: 2.5 Hardware: All OS: Linux Sta

[Bug 219834] amdgpu: kernel oops dce_aux_transfer_raw

2025-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219834 --- Comment #1 from Atiq (ati...@gmail.com) --- Distro: fedora 41 Device: Asus P16 H7606WV Desktop: gnome Xorg or wayland: wayland Kernel: 6.13.5 related: https://github.com/torvalds/linux/blob/99fa936e8e4f117d62f229003c9799686f74cebc/drivers/g

Re: [PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Heiko Stuebner
On Mon, 03 Mar 2025 19:22:56 +0100, Heiko Stuebner wrote: > Commit 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") > moved per soc configuration code to the other per-soc data into > rockchip_vop2_reg.c, but forgot to also include bitfield.h for the used > FIELD_PREP macro. Ad

Re: [PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Sebastian Reichel
Hi, On Mon, Mar 03, 2025 at 07:22:56PM +0100, Heiko Stuebner wrote: > Commit 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") > moved per soc configuration code to the other per-soc data into > rockchip_vop2_reg.c, but forgot to also include bitfield.h for the used > FIELD_PREP

[PATCH v4 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Jonathan Cavitt
Add support for userspace to request a list of observed failed pagefaults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from

[PATCH v4 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-03 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/dr

[PATCH v4 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header

2025-03-03 Thread Jonathan Cavitt
Migrate the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault.h header file, along with the associated enum values. v2: Normalize names for common header (Matt Brost) Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 43 ++-- drivers/

[PATCH v4 4/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-03 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 67 +++ 1 file changed, 67 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 76a462fae05f..53617

[PATCH v4 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-03 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

[PATCH v4 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-03 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_p

[PATCH v4 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. Additionally, add a new ioctl - xe_vm_get_property_ioctl - that allows the user

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-03 Thread Jason Gunthorpe
On Mon, Mar 03, 2025 at 08:36:34PM +0100, Danilo Krummrich wrote: > > > And yes, for *device resources* it is unsound if we do not ensure that the > > > device resource is actually dropped at device unbind. > > > > Why not do a runtime validation then? > > > > It would be easy to have an atomic c

Re: [PATCH v16 0/7] VOP Support for rk3576

2025-03-03 Thread Heiko Stuebner
On Mon, 03 Mar 2025 11:44:14 +0800, Andy Yan wrote: > Here is the v16 > Patches that have already been merged in drm-misc-next are dropped. > > I test it with a 1080P/4K HDMI output with modetest and weston > output. > > If there are some one want to have a try, I have a tree based on > Linux 6

Re: [PATCH v2 05/16] dt-bindings: display/msm: dp-controller: Add SM8750

2025-03-03 Thread Abhinav Kumar
On 2/24/2025 7:14 PM, Dmitry Baryshkov wrote: On Mon, 24 Feb 2025 at 20:59, Abhinav Kumar wrote: On 2/19/2025 9:08 AM, Dmitry Baryshkov wrote: On Wed, Feb 19, 2025 at 06:02:20PM +0100, Krzysztof Kozlowski wrote: On 17/02/2025 19:58, Dmitry Baryshkov wrote: On Mon, Feb 17, 2025 at 05:41

Re: [PATCH RESEND] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2025-03-03 Thread Lyude Paul
Oh I didn't even notice this, thanks Danilo :) On Mon, 2025-03-03 at 20:41 +0100, Danilo Krummrich wrote: > On Mon, Mar 03, 2025 at 06:49:07PM +0100, Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 5 Apr 2023 18:38:54 +0200 > > > > The label “out_prevalid” was used to jump to anoth

RE: [PATCH v3 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Cavitt, Jonathan
From: Zhang, Jianxun Sent: Monday, March 3, 2025 12:23 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 6/6] drm/xe/xe_vm: Implement xe_vm_get_prop

Re: [PATCH v3 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-03 Thread Zhang, Jianxun
From: Cavitt, Jonathan Sent: Friday, February 28, 2025 10:21 AM To: intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; Cavitt, Jonathan ; joonas.lahti...@linux.intel.com ; Brost, Matthew ; Zhang, Jianxun ; dri-devel@lists.freedesktop.org Subje

Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Sven Peter
On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Since the dt-bindings are now part of drm-misc-nex

[Bug 219834] New: amdgpu: kernel oops dce_aux_transfer_raw

2025-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219834 Bug ID: 219834 Summary: amdgpu: kernel oops dce_aux_transfer_raw Product: Drivers Version: 2.5 Hardware: All OS: Linux Status: NEW Severity: normal

Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Adrian Larumbe
> On 03.03.2025 18:04, Ashley Smith wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin" > GPU specification (CS_STATUS_BLOCKED_REASON register). > > This change updates the defines to the correct values. > > Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") >

Re: [PATCH v2 01/18] lib/parity: Add __builtin_parity() fallback implementations

2025-03-03 Thread David Laight
On Mon, 3 Mar 2025 10:15:41 -0500 Yury Norov wrote: > On Mon, Mar 03, 2025 at 01:29:19AM +0800, Kuan-Wei Chiu wrote: > > Hi Yury, > > > > On Sun, Mar 02, 2025 at 11:02:12AM -0500, Yury Norov wrote: > > > On Sun, Mar 02, 2025 at 04:20:02PM +0800, Kuan-Wei Chiu wrote: > > > > Hi Yury, > > > >

Re: [PATCH RESEND] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2025-03-03 Thread Danilo Krummrich
On Mon, Mar 03, 2025 at 06:49:07PM +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 5 Apr 2023 18:38:54 +0200 > > The label “out_prevalid” was used to jump to another pointer check > despite of the detail in the implementation of the function > “nouveau_gem_ioctl_pushbuf” that it

Re: [PATCH RESEND] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2025-03-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc in a moment On Mon, 2025-03-03 at 18:49 +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 5 Apr 2023 18:38:54 +0200 > > The label “out_prevalid” was used to jump to another pointer check > despite of the detail in the implementation

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-03 Thread Danilo Krummrich
On Fri, Feb 28, 2025 at 02:55:34PM -0400, Jason Gunthorpe wrote: > On Thu, Feb 27, 2025 at 11:40:53PM +0100, Danilo Krummrich wrote: > > On Thu, Feb 27, 2025 at 06:00:13PM -0400, Jason Gunthorpe wrote: > > > On Thu, Feb 27, 2025 at 01:25:10PM -0800, Boqun Feng wrote: > > > > > > > > Most of the ca

[PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-03 Thread Jessica Zhang
If new CTLs are reserved by CRTC but atomic_enable() is skipped, the encoders will configure the stale CTL instead of the newly reserved one. Avoid this by setting mode_changed to true if new CTLs have been reserved by CRTC. Note: This patch only adds tracking for the CTL reservation, but eventua

[PATCH v4 1/2] drm/panthor: Replace sleep locks with spinlocks in fdinfo path

2025-03-03 Thread Adrián Larumbe
Commit 0590c94c3596 ("drm/panthor: Fix race condition when gathering fdinfo group samples") introduced an xarray lock to deal with potential use-after-free errors when accessing groups fdinfo figures. However, this toggles the kernel's atomic context status, so the next nested mutex lock will raise

[PATCH v4 2/2] drm/panthor: Avoid sleep locking in the internal BO size path

2025-03-03 Thread Adrián Larumbe
Commit 434e5ca5b5d7 ("drm/panthor: Expose size of driver internal BO's over fdinfo") locks the VMS xarray, to avoid UAF errors when the same VM is being concurrently destroyed by another thread. However, that puts the current thread in atomic context, which means taking the VMS' heap locks will tri

Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

2025-03-03 Thread Krzysztof Kozlowski
On 03/03/2025 09:38, Michal Wilczynski wrote: > > > On 2/21/25 10:12, Krzysztof Kozlowski wrote: >> On Wed, Feb 19, 2025 at 03:02:18PM +0100, Michal Wilczynski wrote: >>> The LicheePi 4A board, featuring the T-HEAD TH1520 SoC, includes an >>> Imagination >>> Technologies BXM-4-64 GPU. Initial su

Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Liviu Dudau
On Mon, Mar 03, 2025 at 06:04:32PM +, Ashley Smith wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin" > GPU specification (CS_STATUS_BLOCKED_REASON register). > > This change updates the defines to the correct values. > > Fixes: 2718d91816ee ("drm/panthor: Add the

[PATCH v2] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

2025-03-03 Thread Jean Delvare
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such driver

Re: [PATCH] drm/gma500: Replace deprecated strncpy() with strscpy()

2025-03-03 Thread Kees Cook
On Tue, Feb 25, 2025 at 09:39:32PM +0100, Thorsten Blum wrote: > strncpy() is deprecated for NUL-terminated destination buffers. Use > strscpy() instead and remove the manual NUL-termination. > > Compile-tested only. > > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-harden...@vger.ker

Re: [PATCH v6 03/14] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-03-03 Thread Jessica Zhang
On 2/27/2025 7:07 AM, Dmitry Baryshkov wrote: On Fri, Feb 14, 2025 at 04:14:26PM -0800, Jessica Zhang wrote: From: Dmitry Baryshkov Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id in preparation for the next step. Reviewed-by: Abhinav Ku

[PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Heiko Stuebner
Commit 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") moved per soc configuration code to the other per-soc data into rockchip_vop2_reg.c, but forgot to also include bitfield.h for the used FIELD_PREP macro. Add this missing include. Fixes: 328e6885996c ("drm/rockchip: vop2: A

[PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Ashley Smith
Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin" GPU specification (CS_STATUS_BLOCKED_REASON register). This change updates the defines to the correct values. Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") Signed-off-by: Ashley Smith --- Changes in v2: - Re

Re: [PATCH] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Ashley Smith
> Please don't reference a URL which isn't accessible to 'normal' people > ;) Something like... > > as documented in the G610 "Odin" GPU specification > (CS_STATUS_BLOCKED_REASON register) > > ...would hopefully be enough to find the relevant documentation for > those of us that have it. You are c

[PATCH RESEND] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2025-03-03 Thread Markus Elfring
From: Markus Elfring Date: Wed, 5 Apr 2023 18:38:54 +0200 The label “out_prevalid” was used to jump to another pointer check despite of the detail in the implementation of the function “nouveau_gem_ioctl_pushbuf” that it was determined already in one case that the corresponding variable contained

Re: [PATCH RESEND 07/12] drm/sti: move to devm_platform_ioremap_resource() usage

2025-03-03 Thread Anusha Srivatsa
On Wed, Feb 26, 2025 at 5:19 AM Raphael Gallais-Pou < raphael.gallais-...@foss.st.com> wrote: > > On 2/25/25 23:20, Anusha Srivatsa wrote: > > Replace platform_get_resource/_byname + devm_ioremap > > with just devm_platform_ioremap_resource() > > > > Used Coccinelle to do this change. SmPl patch:

Re: [PATCH] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Boris Brezillon
On Mon, 3 Mar 2025 15:18:37 + Ashley Smith wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented at > https://arm.pages.collabora.com/mali-docs/g610-odin-csf/register/CS_KERNEL_OUTPUT_BLOCK.htm#rp_CS_KERNEL_OUTPUT_BLOCK/CS_STATUS_BLOCKED_REASON > > This change updates the defines to

Re: [PATCH v2 3/3] Revert "drm/client: Add drm_client_modeset_check()"

2025-03-03 Thread Dr. David Alan Gilbert
* Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > On Tue, Oct 29, 2024 at 11:47:05PM +, li...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > drm_client_modeset_check() was explicitly added in 2020 by > > commit 64593f2a6fc9 ("drm/client: Add drm_client_modeset_check()")

Re: [PATCH] drm/sched: drm_sched_job_cleanup(): correct false doc

2025-03-03 Thread Tvrtko Ursulin
On 03/03/2025 14:32, Philipp Stanner wrote: drm_sched_job_cleanup()'s documentation claims that calling drm_sched_job_arm() is a "point of no return", implying that afterwards a job cannot be cancelled anymore. This is not correct, as proven by the function's code itself, which takes a previou

Re: [PATCH] drm/kmb: Remove unused const and defines

2025-03-03 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > layer_irqs[] was added in 2020 as part of > commit 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") > but isn't used. > > Remove it. > > It was the only user of the LCD_INT_VL0, LCD_INT_VL1, LCD_INT_GL0

Re: [PATCH v2 01/18] lib/parity: Add __builtin_parity() fallback implementations

2025-03-03 Thread Kuan-Wei Chiu
On Mon, Mar 03, 2025 at 10:43:28AM -0500, Yury Norov wrote: > On Mon, Mar 03, 2025 at 10:47:20AM +0800, Kuan-Wei Chiu wrote: > > > > #define parity(val) \ > > > > ({ \ > > > > __auto_type __v = (val);

Re: [PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-03-03 Thread Zack Rusin
Sorry, I didn't see this before because the email formatting got really butchered, I only found the underneath comment in it. Please let me know if there were more. On Tue, Feb 11, 2025 at 9:33 AM Martin Krastev wrote: > On Wed, Jan 15, 2025 at 6:50 AM Zack Rusin wrote: ... > > diff --git a/driv

Re: [PATCH v4 00/15] drm/bridge: Various quality of life improvements

2025-03-03 Thread Herve Codina
On Mon, 3 Mar 2025 16:00:33 +0100 Maxime Ripard wrote: > On Mon, Mar 03, 2025 at 02:34:04PM +0100, Herve Codina wrote: > > Hi Maxime, > > > > On Mon, 3 Mar 2025 14:11:05 +0100 > > Maxime Ripard wrote: > > > > > On Thu, Feb 27, 2025 at 12:00:04PM +0100, Herve Codina wrote: > > > > Hi Maxime

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Neil Armstrong
On 03/03/2025 17:43, Alyssa Rosenzweig wrote: Sasha Finkelstein (5): dt-bindings: display: Add Apple pre-DCP display controller drm: adp: Add Apple Display Pipe driver drm: panel: Add a panel driver for the Summit display arm64: dts: apple: Add touchbar screen node

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Alyssa Rosenzweig
> > Sasha Finkelstein (5): > >dt-bindings: display: Add Apple pre-DCP display controller > >drm: adp: Add Apple Display Pipe driver > >drm: panel: Add a panel driver for the Summit display > >arm64: dts: apple: Add touchbar screen nodes > >MAINTAINERS: Add en

[PATCH AUTOSEL 5.15 8/9] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH AUTOSEL 5.10 7/8] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Neil Armstrong
Hi, On 17/02/2025 12:39, Sasha Finkelstein via B4 Relay wrote: Hi. This patch series adds support for a secondary display controller present on Apple M1/M2 chips and used to drive the display of the "touchbar" touch panel present on those. Signed-off-by: Sasha Finkelstein --- Changes in v7: -

Re: [PATCH] drm/panthor: Update CS_STATUS_ defines to correct values

2025-03-03 Thread Steven Price
On 03/03/2025 15:18, Ashley Smith wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented at > https://arm.pages.collabora.com/mali-docs/g610-odin-csf/register/CS_KERNEL_OUTPUT_BLOCK.htm#rp_CS_KERNEL_OUTPUT_BLOCK/CS_STATUS_BLOCKED_REASON Please don't reference a URL which isn't accessible to

Re: [PATCH 6/6] drm/amdgpu: Remove unused pqm_get_kernel_queue

2025-03-03 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Mar 3, 2025 at 9:49 AM wrote: > > From: "Dr. David Alan Gilbert" > > pqm_get_kernel_queue() has been unused since 2022's > commit 5bdd3eb25354 ("drm/amdkfd: Remove unused old debugger > implementation") > > Remove it. > > Signed-off-by: Dr. David Alan G

Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller.

2025-03-03 Thread Rob Herring
On Tue, Feb 25, 2025 at 11:59 AM Neil Armstrong wrote: > > On 25/02/2025 12:37, Dmitry Baryshkov wrote: > > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong > > wrote: > >> > >> Hi, > >> > >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > >>> This patch series adds support for a seco

[PATCH AUTOSEL 5.4 3/4] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH v8 05/15] drm/msm/dpu: decide right side per last bit

2025-03-03 Thread Jun Nie
Currently, only one pair of mixers is supported, so a non-zero counter value is sufficient to identify the correct mixer within that pair. However, future implementations may involve multiple mixer pairs. With the current implementation, all mixers within the second pair would be incorrectly select

[PATCH AUTOSEL 6.1 8/9] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH AUTOSEL 6.6 09/11] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH AUTOSEL 6.6 05/11] drm/vkms: Round fixp2int conversion in lerp_u16

2025-03-03 Thread Sasha Levin
From: Harry Wentland [ Upstream commit 8ec43c58d3be615a71548bc09148212013fb7e5f ] fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet Link: https://patchwork.freedesktop.org/p

[PATCH AUTOSEL 6.12 14/17] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH AUTOSEL 6.12 08/17] drm/vkms: Round fixp2int conversion in lerp_u16

2025-03-03 Thread Sasha Levin
From: Harry Wentland [ Upstream commit 8ec43c58d3be615a71548bc09148212013fb7e5f ] fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet Link: https://patchwork.freedesktop.org/p

[PATCH AUTOSEL 6.13 14/17] drm/nouveau: Do not override forced connector status

2025-03-03 Thread Sasha Levin
From: Thomas Zimmermann [ Upstream commit 01f1d77a2630e774ce33233c4e6723bca3ae9daa ] Keep user-forced connector status even if it cannot be programmed. Same behavior as for the rest of the drivers. Signed-off-by: Thomas Zimmermann Signed-off-by: Lyude Paul Link: https://patchwork.freedesktop

[PATCH AUTOSEL 6.13 08/17] drm/vkms: Round fixp2int conversion in lerp_u16

2025-03-03 Thread Sasha Levin
From: Harry Wentland [ Upstream commit 8ec43c58d3be615a71548bc09148212013fb7e5f ] fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet Link: https://patchwork.freedesktop.org/p

Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-03-03 Thread Aditya Garg
> On 3 Mar 2025, at 9:15 PM, Thomas Zimmermann wrote: > > Hi > >> Am 27.02.25 um 10:42 schrieb Aditya Garg: On 27 Feb 2025, at 3:04 PM, Thomas Zimmermann wrote: >>> Hi Am 26.02.25 um 17:04 schrieb Aditya Garg: From: Kerem Karabay The Touch Bars found on x86 Macs support

Re: Include ASPEED ast-drm 1.15.1 video driver in kernel tree

2025-03-03 Thread Nicolas Baranger
Hi Thomas Great. You'll find a patch attached against the 6.13 kernel. Let me know if it doesn't apply. If it applies, please run your performance test and look at the dmesg output. It should contain warnings about shared GEM objects. Can you please report some of this output? Thanks a lot

[PATCH v3] Documentation: dma-buf: heaps: Add heap name definitions

2025-03-03 Thread Maxime Ripard
Following a recent discussion at last Plumbers, John Stultz, Sumit Sewal, TJ Mercier and I came to an agreement that we should document what the dma-buf heaps names are expected to be, and what the buffers attributes you'll get should be documented. Let's create that doc to make sure those attribu

Re: [PATCH v2 0/5] DRM scheduler kunit tests

2025-03-03 Thread Tvrtko Ursulin
On 03/03/2025 13:58, Philipp Stanner wrote: On Fri, 2025-02-21 at 12:09 +, Tvrtko Ursulin wrote: There has repeatedly been quite a bit of apprehension when any change to the DRM scheduler is proposed, with two main reasons being code base is considered fragile, not well understood and not

Re: [PATCH v2 3/5] drm/scheduler: Add a simple timeout test

2025-03-03 Thread Tvrtko Ursulin
On 03/03/2025 13:48, Philipp Stanner wrote: On Fri, 2025-02-21 at 12:09 +, Tvrtko Ursulin wrote: Add a very simple timeout test which submits a single job and verifies that the timeout handling will run if the backend failed to complete the job in time. Signed-off-by: Tvrtko Ursulin Cc:

Re: [PATCH v2 2/5] drm/scheduler: Add scheduler unit testing infrastructure and some basic tests

2025-03-03 Thread Tvrtko Ursulin
On 03/03/2025 11:38, Philipp Stanner wrote: Sry for being late to the party, am a bit busy with defusing my own dynamite <.< On Fri, 2025-02-21 at 12:09 +, Tvrtko Ursulin wrote: Implement a mock scheduler backend and add some basic test to exercise the core scheduler code paths. Mock bac

Re: [PATCH 1/2] drm/sched: Fix outdated comments referencing thread

2025-03-03 Thread Danilo Krummrich
On Mon, Mar 03, 2025 at 04:48:36PM +0100, Philipp Stanner wrote: > On Tue, 2025-02-25 at 14:53 +0100, Danilo Krummrich wrote: > > On Tue, Feb 25, 2025 at 02:13:32PM +0100, Philipp Stanner wrote: > > > > - * is parked at which point it's safe. > > > + * drm_sched_cleanup_jobs. It

Re: [PATCH v2 01/18] lib/parity: Add __builtin_parity() fallback implementations

2025-03-03 Thread Yury Norov
On Mon, Mar 03, 2025 at 10:47:20AM +0800, Kuan-Wei Chiu wrote: > > > #define parity(val) \ > > > ({\ > > > __auto_type __v = (val);\ > > > bool __ret;

Re: [PATCH 5/9] drm/panthor: Implement support for multiple power domains

2025-03-03 Thread Marek Vasut
On 2/28/25 11:10 AM, Alexander Stein wrote: Hi, diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c index 51ee9cae94504..4348b7e917b64 100644 --- a/drivers/gpu/drm/panthor/panthor_device.c +++ b/drivers/gpu/drm/panthor/panthor_device.c @@ -75,6 +75,

Re: [PATCH 1/2] drm/sched: Fix outdated comments referencing thread

2025-03-03 Thread Philipp Stanner
On Tue, 2025-02-25 at 14:53 +0100, Danilo Krummrich wrote: > On Tue, Feb 25, 2025 at 02:13:32PM +0100, Philipp Stanner wrote: > > The GPU scheduler's comments refer to a "thread" at various places. > > Those are leftovers stemming from a rework in which the scheduler > > was > > Maybe "leftovers f

Re: [PATCH v7 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-03-03 Thread Thomas Zimmermann
Hi Am 27.02.25 um 10:42 schrieb Aditya Garg: On 27 Feb 2025, at 3:04 PM, Thomas Zimmermann wrote: Hi Am 26.02.25 um 17:04 schrieb Aditya Garg: From: Kerem Karabay The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and

Re: [PATCH v2 01/18] lib/parity: Add __builtin_parity() fallback implementations

2025-03-03 Thread Yury Norov
On Sun, Mar 02, 2025 at 07:09:54PM +, David Laight wrote: > > #define parity(val) \ > > ({ \ > > __auto_type __v = (val);\ > > bool __ret; \ > >

  1   2   3   >