Hi Dave,
Just regression fixes.
- Fix build warning and error without PM configuration
- Fix no display issue on Snow board reported by Michal Suchanek,
http://www.spinics.net/lists/dri-devel/msg99473.html
Plese, kindly let me know if there is any problem.
Thanks,
Inki Dae
it to PM since original auther, Gustavo Padovan,
posted runtime pm support.
However, it seems missing this one.
Thanks,
Inki Dae
> -static int exynos_mixer_suspend(struct device *dev)
> +static int __maybe_unused exynos_mixer_suspend(struct device *dev)
> {
> struct mixer_co
right thing in all cases and
>> also looks nicer.
>>
>> Signed-off-by: Arnd Bergmann
>> Fixes: ("drm/exynos: add pm_runtime to Mixer")
>
> Dear Inki,
>
> Ping? On 4.5-rc1 this is still broken. Can you apply this for fixes
> for cur
2016ë
01ì 18ì¼ 19:12ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 01/18/2016 10:54 AM, Inki Dae wrote:
>>
>> 2016ë
01ì 18ì¼ 08:45ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
>>> On 14.01.2016 19:49, Inki Dae wrote:
>>>> + Rob Herring
>
2016ë
01ì 18ì¼ 08:45ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
> On 14.01.2016 19:49, Inki Dae wrote:
>> + Rob Herring
>>
>> 2016ë
01ì 14ì¼ 19:36ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
>>> It seems this patch and 04/1
ive me acked-by?
Thanks,
Inki Dae
>
> Regards
> Andrzej
>
> On 10/26/2015 12:59 PM, Andrzej Hajda wrote:
>> DECON-TV(Display and Enhancement Controller for TV) is a variation
>> of DECON IP. Its main purpose is to produce video stream for HDMI IP.
>>
>> S
2016ë
01ì 14ì¼ 16:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 01/14/2016 07:25 AM, Inki Dae wrote:
>> Hi Andrzej,
>>
>> This patch series incurred merge conflicts at severial patches so I had to
>> merge them manually.
>> It looks good to me but it seems to
Dae
2016ë
01ì 14ì¼ 13:54ì Inki Dae ì´(ê°) ì´ ê¸:
> Hi Andrzej,
>
> Really sorry for missing this.
> I will merge them soon.
>
> Thanks,
> Inki Dae
>
> 2016ë
01ì 13ì¼ 23:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>> Hi Inki,
>>
>> Ping.
&g
; - DRM_ERROR("failed to get clock 'sclk_hdmi'\n");
> - ret = PTR_ERR(hdata->sclk_hdmi);
> - goto fail;
> - }
> - hdata->sclk_pixel = devm_clk_get(dev, "sclk_pixel");
> - if (IS_ERR(hdata->sclk_pixel)) {
> -
Hi Andrzej,
Really sorry for missing this.
I will merge them soon.
Thanks,
Inki Dae
2016ë
01ì 13ì¼ 23:01ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> Ping.
>
> Regards
> Andrzej
>
> On 11/02/2015 02:16 PM, Andrzej Hajda wrote:
>> Hi Inki, Krzysztof,
&g
Hi Daniel,
2016ë
01ì 12ì¼ 04:00ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 8 January 2016 at 08:46, Inki Dae wrote:
>> Changelog v3:
>> - initialize only device specific things. Each page flip event object
>> is created by DRM core so DRM core should r
Hi Daniel,
It seems your patch is exactly same as below my one I posted before,
http://www.spinics.net/lists/dri-devel/msg97922.html
Anyway, it's ok if this patch can go to mainline.
Acked-by: Inki Dae
2016ë
01ì 12ì¼ 06:41ì Daniel Vetter ì´(ê°) ì´ ê¸:
> The core takes c
n set of planes,
> - well defined semantics: planes are sorted by zpos values and then plane
> id value if zpos equals.
>
> Patches 2/4 and 3/4 are fixes for Exynos DRM driver, which are required
Picked them up. Especially, 2/4 is a good patch.
Thanks,
Inki Dae
> to properly i
event space.
Signed-off-by: Inki Dae
Reviewed-by: Daniel Stone
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 15 +++
drivers/gpu/drm/exynos/exynos_drm_crtc.h | 3 +++
drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 +
3 files changed, 23 insertions(+)
diff --git a/drivers/gpu/drm
These events will be freed by drm_events_release of DRM core so
it doesn't need to free these events in SoC specific driver.
This patch removes relevant codes from Exynos DRM driver.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 ---
1 file changed, 11
+ Rob Clark,
Hi Daniel and Rob,
2016ë
01ì 05ì¼ 20:08ì Daniel Vetter ì´(ê°) ì´ ê¸:
> On Tue, Jan 05, 2016 at 07:55:52PM +0900, Inki Dae wrote:
>> Hi Daniel,
>>
>> 2016ë
01ì 05ì¼ 05:24ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
&
Hi Daniel,
2016ë
01ì 05ì¼ 05:24ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 4 January 2016 at 12:57, Inki Dae wrote:
>> 2015ë
12ì 24ì¼ 22:32ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> On 24 December 2015 at 09:10, Inki Dae wrote:
>>>> +void exy
event objects belonging to the request process,
increment event space and decrease pending_update when cancelling
the event
Signed-off-by: Inki Dae
Reviewed-by: Daniel Stone
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 18 ++
drivers/gpu/drm/exynos/exynos_drm_crtc.h | 4
Hi Marek,
2015ë
12ì 28ì¼ 21:34ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> Hello,
>
> On 2015-12-24 09:15, Inki Dae wrote:
>> Seems this patch could be more cleaned up.
>>
>> Each ctx object of each crtc driver has its own plane config object which
>> includes
Hi Daniel,
2015ë
12ì 24ì¼ 22:32ì Daniel Stone ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 24 December 2015 at 09:10, Inki Dae wrote:
>> +void exynos_drm_crtc_cancel_page_flip(struct drm_crtc *crtc)
>> +{
>> + struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc
flip if the drm_file
object was removed by drm_release and there was a pended page
flip event which was already committed to hardware.
So this patch makes the pended page flip event to be cancelled by
preclose callback which is called at front of drm_release function.
Signed-off-by: Inki Dae
This patch removes exynos_drm_crtc_complete_scanout function call
which makes sure for overlay data to be updated to real hardware
when drm driver is released.
With atomic modeset support, it doesn't need the function anymore
because atomic modeset interface makes sure that.
Signed-off-by: Inki
> set_bit(BIT_WIN_UPDATED, >flags);
> @@ -502,7 +502,7 @@ static int decon_bind(struct device *dev, struct device
> *master, void *data)
> ctx->configs[win].zpos = win;
> ctx->configs[win].type = decon_win_types[tmp];
>
> - ret = exynos_plane_init(drm_dev, >planes[win],
> + ret = exynos_plane_init(drm_dev, >planes[win], i,
'i' isn't declared so you have to use win instead.
Please, post the patch set at least after build test.
Thanks,
Inki Dae
index, 0, false);
+ mixer_cfg_layer(mixer_ctx, plane->config->index, 0, false);
mixer_vsync_set_update(mixer_ctx, true);
spin_unlock_irqrestore(>reg_slock, flags);
@@ -1189,7 +1189,7 @@ static int mixer_bind(struct device *dev, struct device
*manager, void *data)
Hi Marek,
2015ë
12ì 14ì¼ 18:15ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 2015-12-11 15:52, Inki Dae wrote:
>> 2015-12-11 20:27 GMT+09:00 Marek Szyprowski :
>>> On 2015-12-11 10:57, Inki Dae wrote:
>>>> 2015ë
12ì 11ì¼ 18:2
which will integrate existing IPP functions with DRM KMS part so that
these can be transparent to userspace. For other portion of the patch
series, we will have more times for the review.
Plese, kindly let know if there is any problem.
Thanks,
Inki Dae
The following changes since
>
>>
>> The patch fixes the issue I reported. The display mode is correctly set
>> with and without a HDMI monitor plugged. So on an Exynos5800 Peach Pi:
>>
>> Tested-by: Javier Martinez Canillas
>>
>
> This patch was never picked but fixes and im
Hi Marek,
2015-12-11 20:27 GMT+09:00 Marek Szyprowski :
> Hi Inki,
>
>
> On 2015-12-11 10:57, Inki Dae wrote:
>>
>> Hi Marek,
>>
>> 2015ë
12ì 11ì¼ 18:26ì Marek Szyprowski ì´(ê°) ì´ ê¸:
>>>
>>> Hi Inki,
>>>
>>> On
Hi Marek,
2015ë
12ì 11ì¼ 18:26ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> Hi Inki,
>
> On 2015-12-11 10:02, Inki Dae wrote:
>> Hi Marek,
>>
>> I found out why NULL point access happened. That was incurred by below your
>> patch,
>> [PATCH] drm/exynos: mo
2015ë
12ì 10ì¼ 21:59ì Marek Szyprowski ì´(ê°) ì´ ê¸:
> Hello,
>
> On 2015-12-10 12:35, Inki Dae wrote:
>> Hi Marek,
>>
>> 2015ë
11ì 30ì¼ 22:53ì Marek Szyprowski ì´(ê°) ì´ ê¸:
>>> This patch fixes trashed display of buffers cropped
ned out.
Anyway, I can fix it like below if you are ok.
Thanks,
Inki Dae
--- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
@@ -137,7 +137,7 @@ static void vidi_update_plane(struct exynos_drm_crtc *crtc,
if (ctx->suspended)
cept.
- cleanup part of IPP enhancement patch series.
Now while I'm reviewing the cleanup part of IPP enhancement patch series, I
found out a critical issue so as soon as I and original author resolve it, I
will requst GIT PULL at least within next Monday.
Thanks,
Inki Dae
>
> I expect th
ing a connection sysfs file, vidi driver
tries modeset binding by calling drm_fb_helper_hotplug_event.
However, at this time it seems there is a case that plan->state->crtc exists
but plane->fb is NULL, which would be related to vidi driver.
I just looked into this issue roughly so we wo
< ctx->pipe, type, formats,
> - ARRAY_SIZE(formats), zpos);
> + plane_config.pixel_formats = formats;
> + plane_config.num_pixel_formats = ARRAY_SIZE(formats);
> +
> + for (i = 0; i < WINDOWS_NR; i++) {
> + plane_
his patch is different from above description. I think below
patch is just cleanup,
which passes each member necessary instead of passing a drm_framebuffer object.
Thanks,
Inki Dae
>
> Signed-off-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24
CCing Mr. Kukjin and Krzysztof
Hi Kukjin and Krzysztof,
Below patch includes dt binding about gsc device but it'd be nice this patch to
exynos drm tree with others.
So could you give me Acked-by so that I can merge it to exynos drm tree?
Thanks,
Inki Dae
2015ë
11ì 30ì¼ 22:53ì Marek
2015ë
12ì 08ì¼ 10:47ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
> On 08.12.2015 10:33, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote:
>>> On 07.12.2015 21:52, Inki Dae wrote:
>>>> From:
2015ë
12ì 08ì¼ 09:48ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
> On 08.12.2015 00:36, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas > osg.samsung.com>:
>>> Hello Inki,
>>>
>>> On 12/07/201
Hi Javier,
2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 12/07/2015 09:52 AM, Inki Dae wrote:
>> From: Javier Martinez Canillas
>>
>
> Thanks a lot for posting this patch.
>
>> The DT binding for the Exynos DRM Display Port (
This patch just removes unused variables, i and ret.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index edfd6e3
ch Pit that has a eDP to LVDS chip and uses OF graph too.
Signed-off-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Reviewed-by: Inki Dae
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/bo
-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
.../bindings/display/exynos/exynos_dp.txt | 41 +++---
1 file changed, 37 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
b/Documentation/devicetree/bindings
if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index
.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
and Javier.
- update description about eDP device.
Thanks,
Inki Dae
Inki Dae (3):
drm/exynos: dp: add of_graph dt binding support for panel
drm/exynos: dp: fix wrong return type
dt-bindings: exynos-dp: update ports node binding for panel
Javier Martinez Canillas (1):
ARM: dts: Use OF graph
Hi Javier,
2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas :
>
> Hello Inki,
>
> On 12/02/2015 11:11 PM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
12ì 03ì¼ 00:04ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> Hello Inki,
>>>
>>>
Hi Javier,
2015-12-04 21:38 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 12/04/2015 06:00 AM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
12ì 03ì¼ 22:55ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> Hello Inki,
>>>
>>> I fo
Hi Rob,
2015ë
12ì 04ì¼ 08:38ì Rob Herring ì´(ê°) ì´ ê¸:
> On Thu, Dec 03, 2015 at 06:30:10PM +0900, Inki Dae wrote:
>> This patch updates a ports node binding for panel.
>>
>> With this, dp node can have a ports node which describes
>> a remote endpoint
Hi Javier,
2015ë
12ì 03ì¼ 22:29ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On 12/03/2015 06:30 AM, Inki Dae wrote:
>> This patch updates a ports node binding for panel.
>>
>> With this, dp node can have a ports node which describes
>>
ed and
tested patches will be merged to exynos-drm-next.
>
> On 12/03/2015 06:30 AM, Inki Dae wrote:
>> This patch adds of_graph dt binding support for panel device
>> and also keeps the backward compatibility.
>>
>> i.e.,
>> The dts file for Exynos5800 based
This patch updates a ports node binding for panel.
With this, dp node can have a ports node which describes
a remote endpoint node that can be connected to panel or bridge
node.
Signed-off-by: Inki Dae
---
.../bindings/display/exynos/exynos_dp.txt | 28 ++
1 file
if getting a port node failed.
Signed-off-by: Inki Dae
Reviewed-by: Javier Martinez Canillas
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index
.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos
on google.com so couldn't link it.
Thanks,
Inki Dae
[1] [PATCH 0/2] drm/exynos: dp: add of_graph dt binding for panel device
Inki Dae (3):
drm/exynos: dp: add of_graph dt binding support for panel
drm/exynos: dp: fix wrong return type
dt-bindings: exynos-dp: update ports node binding for panel
It seems that below patch should be modifed for only one of two outbound nodes
- panel
and bridge - to be bound because in case of using bridge device, the bridge
driver will
bind the panel. I will fix and post it again.
Thanks,
Inki Dae
2015ë
12ì 02ì¼ 20:57ì Inki Dae ì´(ê°) ì´ ê
This patch makes it to return -EINVAL instead of -ENXIO
when getting a port or endpoint node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu
Hi Javier,
2015ë
12ì 03ì¼ 00:04ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On 12/02/2015 08:57 AM, Inki Dae wrote:
>> This patch adds of_graph dt binding support for panel device
>> and also keeps the backward compatibility.
>>
>
&g
if getting a port node failed.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 0b53045..c77fb83 100644
--- a/drivers
-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 94f02a0..0b53045 100644
--- a/drivers/gpu/drm/exynos
Hi Javier,
2015ë
11ì 26ì¼ 22:35ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> [adding Ajay Kumar who added the bridge support]
>
> Hello Inki,
>
> On 11/26/2015 09:47 AM, Inki Dae wrote:
>> This patch fixes wrong return type when dt binding of bridge device
>&g
off-by: Andrzej Hajda
> ---
> Hi Inki,
>
> This is the patch I have promised during our discussion about
> PM callbcks in components.
Thanks for your patch. I will check it.
Thanks,
Inki Dae
>
> Regards
> Andrzej
>
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 76
This patch fixes wrong return type when dt binding of bridge device
failed.
If a board has a bridge device then of_graph_get_remote_port_parent
function shouldn't be NULL. So this patch will return a proper error
type so that the deferred probe isn't triggered.
Signed-off-by: Inki Dae
This patch adds of_graph dt binding support for panel device
and also keeps the backward compatibility.
i.e.,
The dts file for Exynos5800 based peach pi board
has a panel property so we need to keep the backward compatibility.
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c
This patch series adds of_graph dt binding for panel device
and fixes wrong return type when the dt binding of bridge device failed.
Inki Dae (2):
drm/exynos: dp: add of_graph dt binding support for panel
drm/exynos: dp: fix wrong return type
drivers/gpu/drm/exynos/exynos_dp_core.c | 27
change
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_mixer.c | 106 --
1 file changed, 64 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index d
Mofidy CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 49 +---
1 file changed, 40 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exyn
Remove unnecessary changes which removed commit callback from decon drivers
and modify CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 54 ++--
1 file changed, 37 insertions(+), 17
ed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 51 +++--
1 file changed, 48 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index e4d32a1..9
_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 93 ++
1 file changed, 55 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
b/drivers/gpu/d
2015-11-24 2:44 GMT+09:00 Tobias Jakobi :
> Hey Inki,
>
>
> Inki Dae wrote:
>> Hi Tobias,
>>
>> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>>> First step in allowing a more generic way to setup complex
>>> blending for the differ
2015-11-24 2:44 GMT+09:00 Tobias Jakobi :
> Hey Inki,
>
>
> Inki Dae wrote:
>>
>>
>> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>>> This analyses the current layer configuration (which layers
>>> are enabled, which have alpha-pixelf
2015-11-24 2:44 GMT+09:00 Tobias Jakobi :
> Hey Inki,
>
>
> Inki Dae wrote:
>>
>>
>> 2015ë
11ì 23ì¼ 01:09ì Tobias Jakobi ì´(ê°) ì´ ê¸:
>>> This updates the blending setup when the layer configuration
>>> changes (triggered by mixer_wi
Hi Javier,
2015-11-24 22:19 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 11/23/2015 11:28 PM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
11ì 24ì¼ 03:38ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> Hello Inki,
>>>
>>> On 1
Hi Javier,
2015ë
11ì 24ì¼ 03:38ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
> Hello Inki,
>
> On 11/23/2015 01:47 PM, Inki Dae wrote:
>> 2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas > osg.samsung.com>:
>>> Hello,
>>>
>>> On 11/
2015-11-23 21:25 GMT+09:00 Javier Martinez Canillas :
> Hello,
>
> On 11/21/2015 11:59 AM, Inki Dae wrote:
>> Hi Daniel,
>>
>>
>> 2015-11-21 22:40 GMT+09:00 Daniel Stone :
>>> Hi Inki,
>>>
>>> On 21 November 2015 at 09:38, Inki Dae wr
if (cfg->index == 2) {
val = 0;
mixer_reg_write(res, MXR_VIDEO_CFG, val);
} else {
mixer_general_layer(ctx, >layer_cfg[i]);
}
It'd be better to use a macro - i.e., VIDEO_
gt; + */
> + ctx->layer_state = new_layer_state;
It may be trivial but I think it'd be better to move above line to most bottom
of this function.
> +
> switch (win) {
> case 0:
> mixer_reg_writemask(res, MXR_CFG, val, MXR_CFG_GRP0_ENABLE);
> @@ -520,6 +555,8 @@ static void mixer_cfg_layer(struct mixer_context *ctx,
> unsigned int win,
> }
> break;
> }
> +
> + mixer_layer_blending(ctx);
Here.
Thanks,
Inki Dae
> }
>
> static void mixer_run(struct mixer_context *ctx)
>
= 0;
> + unsigned int i, priority;
> +
> + for (i = 0; i < ctx->num_layer; ++i) {
> + priority = ctx->layer_cfg[i].priority;
> + BUG_ON(priority > 15);
What doesn constant, 15 mean? You need to clarify the meaning
and
yungwon Hwang
Acked-by: Inki Dae
Thanks,
Inki Dae
>
> BRs,
> Hyungwon Hwang
>
> On Sun, 22 Nov 2015 19:48:30 +0100
> Tobias Jakobi wrote:
>
>> Hello,
>>
>> this series mostly touches G2D code. It introduces the following:
>>
>> (1) drmHandl
Hi Daniel,
2015-11-21 22:40 GMT+09:00 Daniel Stone :
> Hi Inki,
>
> On 21 November 2015 at 09:38, Inki Dae wrote:
>> 2015-11-21 1:44 GMT+09:00 Javier Martinez Canillas > osg.samsung.com>:
>>> On 11/20/2015 08:13 AM, Inki Dae wrote:
>>>> The boot log sa
2015-11-21 1:23 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 11/20/2015 07:59 AM, Inki Dae wrote:
>> Hi Javier,
>>
>> 2015ë
11ì 20ì¼ 00:51ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>>> On 11/19/2015 11:55 AM, Javier Martinez Canillas w
Hi Javier,
2015-11-21 1:44 GMT+09:00 Javier Martinez Canillas :
> Hello Inki,
>
> On 11/20/2015 08:13 AM, Inki Dae wrote:
>>
>>
>> 2015ë
11ì 20ì¼ 19:59ì Inki Dae ì´(ê°) ì´ ê¸:
>>> Hi Javier,
>>>
>>> 2015ë
11ì 20ì¼ 00:51ì Ja
2015ë
11ì 20ì¼ 19:59ì Inki Dae ì´(ê°) ì´ ê¸:
> Hi Javier,
>
> 2015ë
11ì 20ì¼ 00:51ì Javier Martinez Canillas ì´(ê°) ì´ ê¸:
>> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote:
>>>>>
>>>>
>>>> This series ca
n? I have no Exynos5800 Peach Pi board. :(
For this, I pushed it to below exynos-drm/for-next branch,
https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm/for-next=e84f43e2b2c3388694b0b3a58c2c4447f1fbae7c
If the issue is resolved by the change then I will modify other patches for
DECON series. And if really so, there may be a corner case we missed.
Thanks,
Inki Dae
>
> Best regards,
>
;
>> drm_gem_create_mmap_offset internally checks whether it's been already
>> (protected by locks), so this code is perfectly fine. I don't see any
>> justification for this change (but only noticed it because rockchip
>> cargo-culted this change).
>
> I think it'd be good
This patch adds runtime pm interfaces to dsi driver.
Each sub driver should control not only its own clocks and
regulator but also its power domain.
For this, it removes existing exynos_dsi_poweron/poweroff interfaces
and uses runtime pm interfaces instead.
Signed-off-by: Inki Dae
---
drivers
2015ë
11ì 04ì¼ 19:13ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 11/04/2015 08:56 AM, Inki Dae wrote:
>>
>> 2015ë
11ì 04ì¼ 16:24ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>> On 11/03/2015 04:38 PM, Inki Dae wrote:
>>>>
>>>> 2015-11-03 2
2015ë
11ì 04ì¼ 16:24ì Andrzej Hajda ì´(ê°) ì´ ê¸:
> On 11/03/2015 04:38 PM, Inki Dae wrote:
>>
>> 2015-11-03 22:24 GMT+09:00 Andrzej Hajda > <mailto:a.hajda at samsung.com>>:
>>> Hi Inki,
>>>
>>> On 11/03/2015 11:47 AM, Inki Dae
2015-11-03 22:24 GMT+09:00 Andrzej Hajda :
> Hi Inki,
>
> On 11/03/2015 11:47 AM, Inki Dae wrote:
>> This patch series adds pm runtime support for Exynos drm.
>>
>> Originally, this patch was posted by Gustavo but there was no any
>> answer about some comment
igned-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 125 -
1 file changed, 53 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index ead2b16..3119aba 100644
--- a/driver
igned-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 54 +++
1 file changed, 39 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index fbe1b31..edfd6e3 100644
---
rivers
and modify CONFIG_PM_SLEEP -> CONFIG_PM
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 91 +---
1 file changed, 37 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/driver
From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
Let pm_runtime handle the enabling/disabling of the device with proper
refcnt instead of rely on specific flags to track the enabled state.
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_m
igned-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 56
1 file changed, 38 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 57b6755..d0362af 100644
--- a/drivers/gpu/d
From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
Let pm_runtime handle the enabling/disabling of the device with
proper refcnt instead of rely on specific flags to track the enabled
state.
Changelog v2:
- no change
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drive
From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
The DP device will be properly enabled at the enable() call just
after the bind call finishes.
Changelog v2:
- no change
Signed-off-by: Gustavo Padovan
Signed-off-by: Inki Dae
---
drivers/gpu/drm/exynos/exynos_dp_core.c
This patch series adds pm runtime support for Exynos drm.
Originally, this patch was posted by Gustavo but there was no any
answer about some comments. So I rebased this patch series on top of
exynos-drm-next, removed unnecessary patches and modified wrong macro.
Changelog v2:
- Remove patch 5
Hi Daniel,
2015ë
10ì 28ì¼ 21:37ì Inki Dae ì´(ê°) ì´ ê¸:
> Hi Daniel,
>
> 2015ë
10ì 28ì¼ 20:52ì Daniel Stone ì´(ê°) ì´ ê¸:
>> Hi Inki,
>>
>> On 28 October 2015 at 11:16, Inki Dae wrote:
>>> 2015ë
10ì 28ì¼ 20:00ì Daniel Stone
of the Tizen consists of Wayland or Xorg, libtbm and its backend
specific to Hardware. The libtbm backend uses libdrm.
So we are wait for the libtbm backend uses DRM_EXYNOS_GEM_MAP interface.
Please kindly let me know if there is any problem.
Thanks,
Inki Dae
[1] http://www.spinics.net
Hi Dave,
2015ë
11ì 03ì¼ 08:10ì Dave Airlie ì´(ê°) ì´ ê¸:
> On 28 October 2015 at 22:37, Inki Dae wrote:
>> Hi Daniel,
>>
>> 2015ë
10ì 28ì¼ 20:52ì Daniel Stone ì´(ê°) ì´ ê¸:
>>> Hi Inki,
>>>
>>> On 28 October 2015 at 11:16,
601 - 700 of 2980 matches
Mail list logo