[PATCH v9 11/11] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v9 01/11] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v9 00/11] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v9 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v9 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v9 03/11] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v9 10/11] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v9 07/11] drm: Handle aspect-ratio info in getblob

From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v9 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v8 11/11] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v8 10/11] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v8 09/11] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v8 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v8 07/11] drm: Handle aspect-ratio info in getblob

From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v8 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v8 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v8 06/11] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v8 05/11] video/hdmi: Reject illegal picture aspect ratios

From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v8 03/11] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v8 01/11] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v8 00/11] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

Re: [PATCH v7 5/9] drm: Handle aspect-ratio info in getblob

On 3/9/2018 6:40 PM, Ville Syrjälä wrote: On Fri, Mar 09, 2018 at 11:07:14AM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect

[PATCH v7 5/9] drm: Handle aspect-ratio info in getblob

From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v6 9/9] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v6 5/9] drm: Handle aspect-ratio info in getblob

From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v6 7/9] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v6 6/9] drm: Handle aspect ratio info in legacy and atomic modeset paths

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v6 8/9] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v6 3/9] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v6 1/9] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v6 4/9] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v6 2/9] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v6 0/9] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

Re: [PATCH v5 8/9] drm: Add aspect ratio parsing in DRM layer

On 2/23/2018 8:24 PM, Ville Syrjälä wrote: On Thu, Feb 15, 2018 at 05:51:01PM +0530, Nautiyal, Ankit K wrote: From: "Sharma, Shashank" <shashank.sha...@intel.com> Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel

Re: [PATCH v5 7/9] drm: Expose modes with aspect ratio, only if requested

On 2/23/2018 8:06 PM, Ville Syrjälä wrote: On Thu, Feb 15, 2018 at 05:51:00PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, reg

Re: [PATCH v5 6/9] drm: Handle aspect ratio info in legacy and atomic modeset paths

Hi Ville, I agree to all the comments here, and will correct the required things in the next patch-set. On 2/23/2018 7:58 PM, Ville Syrjälä wrote: On Thu, Feb 15, 2018 at 05:50:59PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user-spac

Re: [PATCH v5 5/9] drm: Handle aspect-ratio info in getblob

Hi Ville, Thanks for your time for the review and the suggestions. Please find my comments inline: On 2/23/2018 7:52 PM, Ville Syrjälä wrote: On Thu, Feb 15, 2018 at 05:50:58PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user space

[PATCH v5 9/9] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v5 8/9] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v5 6/9] drm: Handle aspect ratio info in legacy and atomic modeset paths

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v5 7/9] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v5 1/9] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v5 5/9] drm: Handle aspect-ratio info in getblob

From: Ankit Nautiyal If the user space does not support aspect-ratio, then getblob called with the blob id of a user mode, should clear the aspect ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores user

[PATCH v5 4/9] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v5 3/9] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v5 2/9] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v5 0/9] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

wrote: On Tue, Feb 13, 2018 at 09:53:53PM +0530, Nautiyal, Ankit K wrote: Hi Ville, Thanks yet again to look into this. I am still skeptical about rejecting the mode, if aspect ratio cap is not set. Perhaps I am not aware with the userspace expectations. Please find my response inline: On 2/13

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

+0530, Nautiyal, Ankit K wrote: Hi Ville, As per our last discussion, following points were discussed: 1. To suppress the aspect-ratio info from getblob ioctl to a user that does not support it: i. A new flag must be added to drm_blob_property to mark if the blob has mode data. ii

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

suggestions on how to handle this situation? Regards, Ankit On 2/8/2018 9:59 AM, Nautiyal, Ankit K wrote: Hi Ville, I still have some queries regarding the handling of aspect ratio flags in getblob ioctl. Please find below my responses inline. On 2/1/2018 6:24 PM, Ville Syrjälä wrote: On Thu

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

Hi Ville, I still have some queries regarding the handling of aspect ratio flags in getblob ioctl. Please find below my responses inline. On 2/1/2018 6:24 PM, Ville Syrjälä wrote: On Thu, Feb 01, 2018 at 04:35:22PM +0530, Nautiyal, Ankit K wrote: Hi Ville, Appreciate your time

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

Hi Ville, Appreciate your time and the suggestions. Please find my response inline: On 1/31/2018 6:39 PM, Ville Syrjälä wrote: On Wed, Jan 31, 2018 at 12:04:52PM +0530, Nautiyal, Ankit K wrote: On 1/30/2018 12:23 AM, Ville Syrjälä wrote: On Fri, Jan 12, 2018 at 11:51:33AM +0530, Nautiyal

Re: [PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested

Hi Ville, Thanks for the comments and suggestions. Please find my response inline: On 1/30/2018 12:28 AM, Ville Syrjälä wrote: On Fri, Jan 12, 2018 at 11:51:34AM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> We parse the EDID and add all the

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

On 1/30/2018 12:23 AM, Ville Syrjälä wrote: On Fri, Jan 12, 2018 at 11:51:33AM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user mode does not support aspect-ratio, and requests for a modeset, then the flag bits representing aspect

[PATCH v4 4/8] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect-ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect-ratio information. To avoid this, a new drm

Re: [PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio

Nautiyal, Ankit K: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> A new drm client cap is required to enable user-space to advertise if it supports modes with aspect-ratio. Based on this cap value, the kernel will take a call on exposing the aspect ratio information in modes or not. This

[PATCH v3 8/8] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of if user space requested this information or not. This patch prunes the modes with aspect-ratio information,

[PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

From: Ankit Nautiyal If the user mode does not support aspect-ratio, and requests for a modeset, then the flag bits representing aspect ratio in the given user-mode must be rejected. Similarly, while preparing a user-mode from kernel mode, the aspect-ratio info must

[PATCH v3 2/8] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v3 1/8] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 134

[PATCH v3 3/8] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v3 7/8] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v3 4/8] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal A new drm client cap is required to enable user-space to advertise if it supports modes with aspect-ratio. Based on this cap value, the kernel will take a call on exposing the aspect ratio information in modes or not. This patch adds the client

[PATCH v3 0/8] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

Re: [REBASE 2/5] drm: Handle aspect ratio in modeset paths

Hi Ville, Thanks for the suggestions. Please find my response inline On 11/21/2017 10:41 PM, Ville Syrjälä wrote: On Fri, Nov 17, 2017 at 03:00:29PM +0530, Shashank Sharma wrote: From: Ankit Nautiyal If the user mode does not support aspect-ratio, and requests

Re: DRM Client capability for aspect ratio

n set_mode_for_crtc() check if bit field aspect_ratio_allowed, is set for the drm_atomic_state. I am currently testing this and am open to suggestions and feedback on this approach. Regards, Ankit On 10/19/2017 9:17 PM, Daniel Stone wrote: Hi Ankit, On 17 October 2017 at 12:08

DRM Client capability for aspect ratio

Hi All, I am working for adding the DRM Client cap for the aspect ratio support as part of the series: https://patchwork.freedesktop.org/series/10850/ : /Picture aspect ratio support in DRM layer/ by Shashank Sharma. I have an open as to how to go about it. I was going through the

DRM Client Capability for aspect ratio

Hi All, I am working for adding the DRM Client cap for the aspect ratio support as part of the series: https://patchwork.freedesktop.org/series/10850/ : /Picture aspect ratio support in DRM layer/ by Shashank Sharma. I have an open as to how to go about it. I was going through the

<    1   2   3