Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-13 Thread Russell King - ARM Linux admin
On Mon, May 10, 2021 at 06:05:21PM +0200, Daniel Vetter wrote: > Entirely aside, but an s/master/aggregate/ or similar over the entire > component.c codebase would help a pile in making it easier to understand > which part does what. Or at least I'm always terribly confused about which > bind

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Russell King - ARM Linux admin
On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > Within the component device framework this usually isn't that bad > because the real driver work is done at bind time via > component{,master}_ops::bind(). It becomes a problem when the driver > core, or host driver, wants to operate

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-04 Thread Russell King - ARM Linux admin
On Thu, Feb 04, 2021 at 05:56:50PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 04, 2021 at 04:52:24PM +0000, Russell King - ARM Linux admin > wrote: > > On Tue, Feb 02, 2021 at 03:06:05PM +0100, Greg Kroah-Hartman wrote: > > > I'm glad to take this through my char/misc

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-04 Thread Russell King - ARM Linux admin
On Tue, Feb 02, 2021 at 03:06:05PM +0100, Greg Kroah-Hartman wrote: > I'm glad to take this through my char/misc tree, as that's where the > other coresight changes flow through. So if no one else objects, I will > do so... Greg, did you end up pulling this after all? If not, Uwe produced a v2.

Re: [PATCH v3 0/5] amba: minor fix and various cleanups

2021-02-02 Thread Russell King - ARM Linux admin
On Tue, Jan 26, 2021 at 05:58:30PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > Hello, > > Changes since v2 sent with Message-Id: > 20201124133139.3072124-1-...@kleine-koenig.org: > > - Rebase to v5.11-rc1 (which resulted in a few conflicts in >drivers/hwtracing). > - Add

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-26 Thread Russell King - ARM Linux admin
On Tue, Jan 26, 2021 at 06:56:52PM +0100, Uwe Kleine-König wrote: > I'm surprised to see that the remove callback introduced in 2952ecf5df33 > ("coresight: etm4x: Refactor probing routine") has an __exit annotation. In general, remove callbacks should not have an __exit annotation. __exit _can_

Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

2020-11-08 Thread Russell King - ARM Linux admin
On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being

Re: [PATCH] gpu/drm/armada: fix unused parameter warning

2020-10-12 Thread Russell King - ARM Linux admin
On Mon, Oct 12, 2020 at 04:57:24AM -0700, Bernard Zhao wrote: > Functions armada_drm_crtc_atomic_flush & > armada_drm_crtc_atomic_enable don`t use the second parameter. > So we may get warning like : > warning: unused parameter ‘***’ [-Wunused-parameter]. > This change is to fix the compile

Re: [PATCH v2 02/21] drm/armada: Introduce GEM object functions

2020-09-15 Thread Russell King - ARM Linux admin
On Tue, Sep 15, 2020 at 04:59:39PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in armada. > > Signed-off-by: Thomas Zimmermann Acked-by:

Re: [PATCH] drm/etnaviv: always start/stop scheduler in timeout processing

2020-08-24 Thread Russell King - ARM Linux admin
On Mon, Aug 24, 2020 at 01:02:48PM +0200, Lucas Stach wrote: > The drm scheduler currently expects that the stop/start sequence is always > executed in the timeout handling, as the job at the head of the hardware > execution list is always removed from the ring mirror before the driver > function

Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Russell King - ARM Linux admin
On Sun, Aug 23, 2020 at 09:10:25PM +0200, Christian Gmeiner wrote: > Hi > > > I have formally tested the patch with 5.7.10 - and it doesn't resolve > > the issue - sadly :( > > > > From my testing, the reads on > > VIVS_HI_CHIP_PRODUCT_ID > > VIVS_HI_CHIP_ECO_ID > > need to be conditional - while

Re: [PATCH 1/2] drm/imx: fix use after free

2020-06-11 Thread Russell King - ARM Linux admin
On Thu, Jun 11, 2020 at 02:43:31PM +0200, Marco Felsch wrote: > From: Philipp Zabel > > Component driver structures allocated with devm_kmalloc() in bind() are > freed automatically after unbind(). Since the contained drm structures > are accessed afterwards in drm_mode_config_cleanup(), move

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-20 Thread Russell King - ARM Linux admin
On Wed, May 20, 2020 at 04:04:39PM +0200, Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > > Yes. This means that in fact "core" is the only required clock for all > > implementations of vivante,gc and the common binding needs to be updated > > to reflect

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-14 Thread Russell King - ARM Linux admin
On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > admin: > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrote: > > > Am Mittwoch, den 13.05.2020, 23:41 -0300 schrieb Fabio Es

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-14 Thread Russell King - ARM Linux admin
On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrote: > Am Mittwoch, den 13.05.2020, 23:41 -0300 schrieb Fabio Estevam: > > On Wed, May 13, 2020 at 2:09 PM Fabio Estevam wrote: > > > > > The binding doc Documentation/devicetree/bindings/gpu/vivante,gc.yaml > > > says that only the 'reg'

Re: decruft the vmalloc API

2020-04-08 Thread Russell King - ARM Linux admin
On Wed, Apr 08, 2020 at 01:58:58PM +0200, Christoph Hellwig wrote: > Hi all, > > Peter noticed that with some dumb luck you can toast the kernel address > space with exported vmalloc symbols. > > I used this as an opportunity to decruft the vmalloc.c API and make it > much more systematic. This

Re: [PATCH] Update my email address in various drivers

2020-03-30 Thread Russell King - ARM Linux admin
On Mon, Mar 30, 2020 at 08:04:44PM +0200, Sam Ravnborg wrote: > Hi Russell. > > On Sun, Mar 29, 2020 at 11:19:10AM +0100, Russell King wrote: > > Globally update my email address in six files scattered through the > > tree. > > > > Signed-off-by: Russell King > > --- > >

Re: [PATCH 18/51] drm/: Use drmm_add_final_kfree

2020-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 21, 2020 at 10:02:46PM +0100, Daniel Vetter wrote: > These are the leftover drivers that didn't have a ->release hook that > needed to be updated. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov > Cc: Russell King > Cc: Hans de

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-22 Thread Russell King - ARM Linux admin
On Wed, Jan 22, 2020 at 11:30:34AM +0100, Guido Günther wrote: > Hi, > On Tue, Jan 21, 2020 at 08:05:27PM +0100, Arnd Bergmann wrote: > > On Tue, Jan 21, 2020 at 5:10 PM Lucas Stach wrote: > > > > > > Hi Guido, > > > > > > On Di, 2020-01-21 at 13:55 +0100, Guido Günther wrote: > > > > Hi, > > > >

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-21 Thread Russell King - ARM Linux admin
On Tue, Jan 21, 2020 at 01:55:46PM +0100, Guido Günther wrote: > Hi, > On Tue, Jan 21, 2020 at 12:45:25PM +0100, Arnd Bergmann wrote: > > As Guido Günther reported, get_abs_timeout() in the etnaviv user space > > sometimes passes timeouts with nanosecond values larger than 10, > > which

Re: [PATCH for-5.6 0/2] drm/bridge: dw-hdmi: PCM API updates

2020-01-09 Thread Russell King - ARM Linux admin
On Thu, Jan 09, 2020 at 10:10:09AM +0100, Takashi Iwai wrote: > On Tue, 10 Dec 2019 16:45:34 +0100, > Takashi Iwai wrote: > > > > Hi, > > > > this is a patch set for updating ALSA PCM API usages in dw-hdmi > > driver. I already tried to "fix" the driver some time ago but it was > > utterly

Re: [PATCH 00/30] drm/bridge: Add device links for lifetime control

2019-11-26 Thread Russell King - ARM Linux admin
What happened with the patches I posted doing exactly this? On Tue, Nov 26, 2019 at 01:15:58PM +, Mihail Atanassov wrote: > Hi all, > > This series adds device links support to drm_bridge. The motivation > behind it is that a drm_bridge in a module could get removed under the > feet of the

Re: [PATCH 05/15] drm/armada: Delete dma_buf->k(un)map implemenation

2019-11-25 Thread Russell King - ARM Linux admin
On Mon, Nov 25, 2019 at 10:44:43PM +0100, Daniel Vetter wrote: > On Mon, Nov 18, 2019 at 11:35:26AM +0100, Daniel Vetter wrote: > > It's a dummy anyway. > > > > Signed-off-by: Daniel Vetter > > Cc: Russell King > > I merged the entire series except this one and the final patch, sill > waiting

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Russell King - ARM Linux admin
On Tue, Nov 05, 2019 at 05:44:26PM +0100, Takashi Iwai wrote: > On Tue, 05 Nov 2019 17:33:44 +0100, > Takashi Iwai wrote: > > > > On Tue, 05 Nov 2019 17:02:15 +0100, > > Russell King - ARM Linux admin wrote: > > > > > > On Tue, Nov 05, 2019 at 09:07:43

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Russell King - ARM Linux admin
On Tue, Nov 05, 2019 at 09:07:43AM +0100, Neil Armstrong wrote: > Hi, > > On 05/11/2019 08:55, Takashi Iwai wrote: > > Hi, > > > > while recently working on the ALSA memory allocator API cleanup, I > > noticed that dw-hdmi bridge driver seems doing weird about the buffer > > management. It

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 03:42:07PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Oct 22, 2019 at 10:50:42AM +0200, Daniel Vetter wrote: > > On Tue, Oct 22, 2019 at 10:48 AM Russell King - ARM Linux admin > > wrote: > > > I had a patches, which is why I raised t

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 10:50:42AM +0200, Daniel Vetter wrote: > On Tue, Oct 22, 2019 at 10:48 AM Russell King - ARM Linux admin > wrote: > > I had a patches, which is why I raised the problem with the core: > > > > 6961edfee26d bridge hacks using device links > >

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 10:42:10AM +0200, Daniel Vetter wrote: > On Thu, Oct 17, 2019 at 12:41:37PM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote: > > > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote: > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian wang (Arm Technology > China) wrote: > > On Thu, Oct 17, 2019 at 08:20:56AM +, Brian Starkey wrote: > > > On Thu, Oct 17, 2019 at 03:07:59AM +, james qian wang (Arm

Re: [PATCHv8 2/2] drm: tda998x: set the connector info

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 11:26:38AM +0200, Dariusz Marcinkiewicz wrote: > Hi Russel. > > On Wed, Oct 16, 2019 at 6:22 PM Russell King - ARM Linux admin > wrote: > > > ... > > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > > +++ b/drivers/gpu/drm/i2c/tda998x_d

Re: [PATCHv9 2/2] drm: tda998x: set the connector info

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 09:28:42AM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Fill in the cec_connector_info when calling cec_notifier_conn_register(). > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv8 2/2] drm: tda998x: set the connector info

2019-10-16 Thread Russell King - ARM Linux admin
On Wed, Oct 16, 2019 at 03:39:16PM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Fill in the cec_connector_info when calling cec_notifier_conn_register(). > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv8 1/2] drm: tda998x: use cec_notifier_conn_(un)register

2019-10-16 Thread Russell King - ARM Linux admin
On Wed, Oct 16, 2019 at 03:39:15PM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil Please explain

Re: [PATCH v2] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-08 Thread Russell King - ARM Linux admin
On Thu, Sep 05, 2019 at 05:43:25PM +0800, Cheng-Yi Chiang wrote: > From: Yakir Yang > > When transmitting IEC60985 linear PCM audio, we configure the > Aduio Sample Channel Status information of all the channel > status bits in the IEC60958 frame. > Refer to 60958-3 page 10 for frequency,

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Russell King - ARM Linux admin
On Wed, Sep 04, 2019 at 05:45:20PM +0800, Cheng-yi Chiang wrote: > On Wed, Sep 4, 2019 at 5:28 PM Neil Armstrong wrote: > > > > Hi, > > > > On 04/09/2019 11:09, Cheng-yi Chiang wrote: > > > Hi, > > > > > > On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong > > > wrote: > > >> > > >> Hi, > > >> > >

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Russell King - ARM Linux admin
On Wed, Sep 04, 2019 at 05:09:29PM +0800, Cheng-yi Chiang wrote: > Hi, > > On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong wrote: > > > > Hi, > > > > On 03/09/2019 07:51, Cheng-Yi Chiang wrote: > > > From: Yakir Yang > > > > > > When transmitting IEC60985 linear PCM audio, we configure the > > >

Re: [PATCH v6 3/8] tda9950: use cec_notifier_cec_adap_(un)register

2019-08-13 Thread Russell King - ARM Linux admin
On Tue, Aug 13, 2019 at 01:02:35PM +0200, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_cec_adap_(un)register() functions to > (un)register the notifier for the CEC adapter. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil > Tested-by: Hans Verkuil > --- >

Re: [PATCH v6 4/8] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-13 Thread Russell King - ARM Linux admin
On Tue, Aug 13, 2019 at 01:02:36PM +0200, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill > in the cec_connector_info. > > Changes since v2: > - cec_notifier_phys_addr_invalidate where

Re: [PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-12 Thread Russell King - ARM Linux admin
On Fri, Jul 12, 2019 at 06:04:39PM +0800, Cheng-Yi Chiang wrote: > Add an op in hdmi_codec_ops so codec driver can register callback > function to handle plug event. > > Driver in DRM can use this callback function to report connector status. > > Signed-off-by: Cheng-Yi Chiang > --- >

Re: [PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-12 Thread Russell King - ARM Linux admin
On Fri, Jul 12, 2019 at 06:04:40PM +0800, Cheng-Yi Chiang wrote: > Allow codec driver register callback function for plug event. > > The callback registration flow: > dw-hdmi <--- hw-hdmi-i2s-audio <--- hdmi-codec > > dw-hdmi-i2s-audio implements hook_plugged_cb op > so codec driver can register

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Russell King - ARM Linux admin
On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > These GENMASK uses are inverted argument order and the > > actual masks produced are incorrect. Fix them. > > > > Add checkpatch tests to help avoid more misuses too. > > >

Re: [GIT PULL] ARM (for-airlie-armada branch)

2019-07-02 Thread Russell King - ARM Linux admin
The subject should've been "Armada updates for merge window". Sorry. On Tue, Jul 02, 2019 at 10:13:13AM +0100, Russell King wrote: > Hi David, > > The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd: > > Linux 5.1 (2019-05-05 17:42:58 -0700) > > are available in the

Re: [PATCH] drm/armada: fix debugfs link error

2019-06-28 Thread Russell King - ARM Linux admin
On Fri, Jun 28, 2019 at 12:33:40PM +0200, Arnd Bergmann wrote: > Debugfs can be disabled at compile time, causing a link error > with the newly restructured code: > > drivers/gpu/drm/armada/armada_crtc.o: In function > `armada_drm_crtc_late_register': > armada_crtc.c:(.text+0x974): undefined

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 04:49:30PM +0200, Lucas Stach wrote: > Am Donnerstag, den 27.06.2019, 15:32 +0100 schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 27, 2019 at 11:04:17AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Thu, Jun 27, 2019 at 11

Re: [PATCH] drm/etnaviv: add missing failure path to destroy suballoc

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 04:44:38PM +0200, Lucas Stach wrote: > When something goes wrong in the GPU init after the cmdbuf suballocator > has been constructed, we fail to destory it properly. This causes havok > later when the GPU is unbound due to a module unload or similar. > > Signed-off-by:

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 11:04:17AM +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 27, 2019 at 11:20:15AM +0200, Lucas Stach wrote: > > Am Samstag, den 22.06.2019, 17:16 +0100 schrieb Russell King - ARM Linux > > admin: > > > While updating my various systems f

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 11:20:15AM +0200, Lucas Stach wrote: > Am Samstag, den 22.06.2019, 17:16 +0100 schrieb Russell King - ARM Linux > admin: > > While updating my various systems for the TCP SACK issue, I notice > > that while most platforms are happy, the Cubox-i4 is not

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 04:07:55PM +0200, Daniel Vetter wrote: > Otherwise I like this. Biggest problem I'm seeing here is rolling this out > everywhere, this is a lot of work. And without widespread adoptions it's > not terribly useful for userspace. There will be cases where it's not possible,

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 12:14:27PM +0200, Andrzej Pietrasiewicz wrote: > Hi Russell, > > W dniu 25.06.2019 o 12:03, Russell King - ARM Linux admin pisze: > > On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: > > > It is difficult for a user to know w

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l

[REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-22 Thread Russell King - ARM Linux admin
While updating my various systems for the TCP SACK issue, I notice that while most platforms are happy, the Cubox-i4 is not. During boot, we get: [0.00] cma: Reserved 256 MiB at 0x3000 ... [0.00] Kernel command line: console=ttymxc0,115200n8 console=tty1

Re: [PATCH v1 1/2] drm/i2c: tda998x: access chip registers via a regmap

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 05:13:33PM -0400, Sven Van Asbroeck wrote: > On Fri, Jun 21, 2019 at 11:15 AM Russell King - ARM Linux admin > wrote: > > > > Another con is the need to keep the functions that detail the register > > properties up to date, which if they're wrong

Re: [PATCH v1 2/2] drm/i2c: tda998x: remove indirect reg_read/_write() calls

2019-06-21 Thread Russell King - ARM Linux admin
On Mon, May 27, 2019 at 03:15:52PM -0400, Sven Van Asbroeck wrote: > -static void > -reg_set(struct tda998x_priv *priv, u16 reg, u8 val) > +static int > +reg_set(struct regmap *regmap, u16 reg, u8 val) I don't see the point of making this return an 'int' - you don't modify any of the callsites to

Re: [PATCH v1 1/2] drm/i2c: tda998x: access chip registers via a regmap

2019-06-21 Thread Russell King - ARM Linux admin
On Mon, May 27, 2019 at 03:15:51PM -0400, Sven Van Asbroeck wrote: > The tda988x i2c chip registers are accessed through a > paged register scheme. The kernel regmap abstraction > supports paged accesses. Replace this driver's > dedicated i2c access functions with a standard i2c > regmap. > >

Re: [PATCH v2 00/13] tda998x updates

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 03:51:06PM -0400, Sven Van Asbroeck wrote: > On Thu, Jun 13, 2019 at 10:29 AM Russell King - ARM Linux admin > wrote: > > > > This series represents development work collected over the last six > > months to improve the TDA998x driver, particularl

Re: [PATCH v2 01/13] drm/i2c: tda998x: introduce tda998x_audio_settings

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 02:48:47PM -0400, Sven Van Asbroeck wrote: > Nit: checkpatch.pl appears unhappy with this patch: > > WARNING: line over 80 characters > #222: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1011: > + audio.params.config = priv->audio_port[i].config; > > WARNING: line over 80

Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 06:01:14PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is

[PATCH 00/18] Armada DRM updates

2019-06-13 Thread Russell King - ARM Linux admin
Hi, This series updates Armada DRM: - Fix interlace support. - use __drm_atomic_helper_plane_reset in overlay reset. - since the overlay and video planes use essentially the same format registers, precompute their values while validating. - fix a long-standing deficiency with overlay planes

Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Please don't merge this patch - I have a

[PATCH v2 00/13] tda998x updates

2019-06-13 Thread Russell King - ARM Linux admin
This series represents development work collected over the last six months to improve the TDA998x driver, particularly for the audio side. These patches can be found in my "drm-tda998x-devel" branch at git://git.armlinux.org.uk/~rmk/linux-arm.git - Introduce an audio_settings structure so we can

Re: [PATCH 00/13] tda998x updates

2019-06-13 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:40:43AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:01 AM Russell King - ARM Linux admin > wrote: > > > > This series represents development work collected over the last six > > months to improve the TDA998x driver, particularl

Re: [PATCH 12/13] drm/i2c: tda998x: add bridge timing information

2019-06-13 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:38:06AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:04 AM Russell King > wrote: > > > > Add bridge timing information so that bridge users can figure out the > > timing parameters that are necessary for TDA998x. > > > > Signed-off-by: Russell King > >

Re: [PATCH 01/13] drm/i2c: tda998x: introduce tda998x_audio_settings

2019-06-13 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:24:46AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:01 AM Russell King > wrote: > > > > Introduce a structure to hold the register values to be programmed while > > programming the TDA998x audio settings. This is currently a stub > > structure, which

Re: [PATCH 04/13] drm/i2c: tda998x: derive CTS_N value from aclk sample rate ratio

2019-06-12 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 12:37:57PM -0400, Sven Van Asbroeck wrote: > On Wed, Jun 12, 2019 at 12:28 PM Russell King - ARM Linux admin > wrote: > > > > The platform data path has never supported the HDMI codec way of doing > > things, so that really isn't a concern here

Re: [PATCH 08/13] drm/i2c: tda998x: move audio routing configuration

2019-06-12 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:36:59AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:02 AM Russell King > wrote: > > > > Move the mux and clocking selection out of tda998x_configure_audio() > > into the parent functions, so we can validate this when parameters > > are set outside of

Re: [PATCH 04/13] drm/i2c: tda998x: derive CTS_N value from aclk sample rate ratio

2019-06-12 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:27:16AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:02 AM Russell King > wrote: > > > > The TDA998x derives the CTS value using the supplied I2S bit clock > > (ACLK, in TDA998x parlence) rather than 128·fs. TDA998x uses two > > constants named m and k

Re: [PATCH 03/13] drm/i2c: tda998x: improve programming of audio divisor

2019-06-12 Thread Russell King - ARM Linux admin
On Wed, Jun 12, 2019 at 11:25:59AM -0400, Sven Van Asbroeck wrote: > On Tue, Jun 11, 2019 at 7:02 AM Russell King > wrote: > > > > Improve the selection of the audio clock divisor so that more modes > > and sample rates work. > > > > Signed-off-by: Russell King > > --- > > +static u8

[PATCH 00/13] tda998x updates

2019-06-11 Thread Russell King - ARM Linux admin
This series represents development work collected over the last six months to improve the TDA998x driver, particularly for the audio side. These patches can be found in my "drm-tda998x-devel" branch at git://git.armlinux.org.uk/~rmk/linux-arm.git - Introduce an audio_settings structure so we can

Re: [PATCH] drm/etnaviv: lock MMU while dumping core

2019-05-24 Thread Russell King - ARM Linux admin
On Wed, May 22, 2019 at 11:55:14AM +0200, Lucas Stach wrote: > The devcoredump needs to operate on a stable state of the MMU while > it is writing the MMU state to the coredump. The missing lock > allowed both the userspace submit, as well as the GPU job finish > paths to mutate the MMU state

Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

2019-05-22 Thread Russell King - ARM Linux admin
On Wed, May 22, 2019 at 12:04:27PM +0200, Lucas Stach wrote: > Hi Russell, > > Am Samstag, den 18.05.2019, 22:37 +0100 schrieb Russell King - ARM > Linux admin: > > On Sat, May 18, 2019 at 06:04:42PM -0300, Fabio Estevam wrote: > > > Hi Russell, > > > &

Re: [PATCH] drm/etnaviv: lock MMU while dumping core

2019-05-22 Thread Russell King - ARM Linux admin
Hi Lucas, Seems I'm not getting a reply, so I'm hijacking one of your more recent patches in the hope of attracting your attention. A while back I sent a fix for a regression that recently occurred with etnaviv, where the kernel spat out a warning when importing buffers into etnaviv. You

Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

2019-05-18 Thread Russell King - ARM Linux admin
On Sat, May 18, 2019 at 06:04:42PM -0300, Fabio Estevam wrote: > Hi Russell, > > On Sat, May 18, 2019 at 2:51 PM Russell King - ARM Linux admin > wrote: > > > > Ping. > > This patch is present in Lucas' pull request: > https://lists.freedesktop.org/archives/

Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

2019-05-18 Thread Russell King - ARM Linux admin
Ping. On Mon, Feb 25, 2019 at 10:54:23AM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 25, 2019 at 10:51:30AM +, Russell King wrote: > > During boot, I get this kernel warning: > > > > WARNING: CPU: 0 PID: 19001 at kernel/dma/debug.c:1301 > > d

Re: [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-04-30 Thread Russell King - ARM Linux admin
On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: > Add a structure for the parameters of dma_buf_attach, this makes it much > easier > to add new parameters later on. I don't understand this reasoning. What are the "new parameters" that are being proposed, and why do we need to

Re: remove NULL struct device support in the DMA API

2019-04-03 Thread Russell King - ARM Linux admin
On Thu, Mar 21, 2019 at 03:52:28PM -0700, Christoph Hellwig wrote: > We still have a few drivers which pass a NULL struct device pointer > to DMA API functions, which generally is a bad idea as the API > implementations rely on the device not only for ops selection, but > also the dma mask and

Re: [PATCH] drm: etnaviv: fix strncpy sizeof argument

2019-03-19 Thread Russell King - ARM Linux admin
On Mon, Mar 18, 2019 at 10:57:55PM -0400, Bo YU wrote: > Calling strncpy with a maximum size argument of 64 bytes on destination > array "domain->name" of size 64 bytes might leave the destination string > unterminated. > > Detected by CoverityScan, CID# 1443992: Memory - illegal accesses >

Re: [TWO BUGs] etnaviv crashes overnight

2019-03-06 Thread Russell King - ARM Linux admin
On Tue, Feb 26, 2019 at 11:02:48AM +0100, Lucas Stach wrote: > Hi Russell, > > Am Dienstag, den 26.02.2019, 09:24 + schrieb Russell King - ARM Linux > admin: > > I'm not sure when this happened, only that it happened sometime > > overnight.  It was left running an

Re: [PATCH 0/5] tda998x updates

2019-02-27 Thread Russell King - ARM Linux admin
On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin wrote: > Hi, > > This series adds support for programming the SPD and vendor infoframes. > > It also adds support for pixel repeated modes - we were not rejecting > these modes, but we also didn't have

Re: [RFC PATCH 1/2] ASoC: simple-card: add support for bclk_ratio

2019-02-26 Thread Russell King - ARM Linux admin
On Tue, Feb 26, 2019 at 11:31:15AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 26, 2019 at 10:45 AM Russell King - ARM Linux admin > wrote: > > > > > > I can't see how you'd extend a single I2S setup to support multi- > > channel audio without either adding

Re: [RFC PATCH 1/2] ASoC: simple-card: add support for bclk_ratio

2019-02-26 Thread Russell King - ARM Linux admin
On Tue, Feb 26, 2019 at 09:53:22AM -0500, Sven Van Asbroeck wrote: > I notice that hdmi-codec.c supports up to 8 channels in hdmi multi-channel > playback mode. If we had a _theoretical_ hdmi xmitter with 8chan support, > would the bclk_ratio not be 8 x slot_size - or 8 x 32 if using an fsl_ssi >

[TWO BUGs] etnaviv crashes overnight

2019-02-26 Thread Russell King - ARM Linux admin
I'm not sure when this happened, only that it happened sometime overnight. It was left running an Xfce desktop having only logged in, but with the monitor disconnected. Fedora 23 plus xf86-video-armada. I don't have any more information than that and the kernel messages below. [51328.909729]

Re: [RFC PATCH 1/2] ASoC: simple-card: add support for bclk_ratio

2019-02-26 Thread Russell King - ARM Linux admin
On Tue, Feb 26, 2019 at 09:35:47AM +0900, Kuninori Morimoto wrote: > > @@ -97,7 +98,7 @@ static int asoc_simple_card_hw_params(struct > > snd_pcm_substream *substream, > > struct simple_card_data *priv = snd_soc_card_get_drvdata(rtd->card); > > struct simple_dai_props *dai_props = > >

Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-25 Thread Russell King - ARM Linux admin
On Mon, Feb 25, 2019 at 03:28:51PM +0200, Peter Ujfalusi wrote: > hi Russell, > > On 22/02/2019 23.27, Russell King wrote: > > Add support for the left and right justified I2S formats as well as the > > more tranditional "Philips" I2S format. > > First of all, thank you for the patch, it works.

Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

2019-02-25 Thread Russell King - ARM Linux admin
On Mon, Feb 25, 2019 at 10:51:30AM +, Russell King wrote: > During boot, I get this kernel warning: > > WARNING: CPU: 0 PID: 19001 at kernel/dma/debug.c:1301 > debug_dma_map_sg+0x284/0x3dc > etnaviv etnaviv: DMA-API: mapping sg segment longer than device claims to > support [len=3145728]

Re: [PATCH 1/2] drm/i2c: tda998x: adjust CTS_N audio pre-divider calculation

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 04:18:33PM -0500, Sven Van Asbroeck wrote: > Russell, thank you so much for your patience, help and explanation, I really > appreciate it ! > > Yes, that would keep the current users in business without them having to > change anything. > > Of course, poor souls like

[PATCH RFC 0/3] tda998x updates for DAI formats and bclk_ratio

2019-02-22 Thread Russell King - ARM Linux admin
This series addresses two issues with TDA998x that have been identified: 1) Peter found that the I2S format was not being explicitly set, and retains its value from whatever was previously running on the platform. Work around this by implementing support for setting the I2S format from

Re: [PATCH 1/2] drm/i2c: tda998x: adjust CTS_N audio pre-divider calculation

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 04:27:35PM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 22, 2019 at 10:47:35AM -0500, Sven Van Asbroeck wrote: > > The config structure which you need to fill in to init the audio has a > > "i2s qualifier" field, where you have the

Re: [RESEND] drm/i2c: tda998x: Reset the I2S_FORMAT (Page0, Reg 0xfc) to it's default

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 03:27:43PM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 22, 2019 at 05:20:15PM +0200, Peter Ujfalusi wrote: > > Hi Russell, > > > > On 22/02/2019 16.35, Russell King - ARM Linux admin wrote: > > > It would also be good to

Re: [PATCH 1/2] drm/i2c: tda998x: adjust CTS_N audio pre-divider calculation

2019-02-22 Thread Russell King - ARM Linux admin
(Adding Mark, ASoC maintainer.) On Fri, Feb 22, 2019 at 10:47:35AM -0500, Sven Van Asbroeck wrote: > On Fri, Feb 22, 2019 at 8:21 AM Russell King - ARM Linux admin > wrote: > > > > On Thu, Feb 21, 2019 at 01:18:13PM -0500, Sven Van Asbroeck wrote: > > > > &g

Re: [RESEND] drm/i2c: tda998x: Reset the I2S_FORMAT (Page0, Reg 0xfc) to it's default

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 05:20:15PM +0200, Peter Ujfalusi wrote: > > and I think we should implement at least setting the I2S > > register format from the hdmi_codec_daifmt data. > > Yes, that needs to be done for sure, but without data sheet with > register descriptions I would not attempt to do

Re: [RESEND] drm/i2c: tda998x: Reset the I2S_FORMAT (Page0, Reg 0xfc) to it's default

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 05:20:15PM +0200, Peter Ujfalusi wrote: > Hi Russell, > > On 22/02/2019 16.35, Russell King - ARM Linux admin wrote: > > On Fri, Feb 22, 2019 at 03:47:14PM +0200, Peter Ujfalusi wrote: > >> Hi, > >> > >> the origin

Re: [RESEND] drm/i2c: tda998x: Reset the I2S_FORMAT (Page0, Reg 0xfc) to it's default

2019-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 22, 2019 at 03:47:14PM +0200, Peter Ujfalusi wrote: > Hi, > > the original version was sent 14.04.2018: > https://patchwork.kernel.org/patch/10344403/ > > Changes since then: > - rebased on currentl drm/next > > The reset value of the register is 0, the soft reset does not reset

Re: [PATCH 1/2] drm/i2c: tda998x: adjust CTS_N audio pre-divider calculation

2019-02-22 Thread Russell King - ARM Linux admin
On Thu, Feb 21, 2019 at 01:18:13PM -0500, Sven Van Asbroeck wrote: > My cpu dai driving the tda998x in master mode outputs > SNDRV_PCM_FORMAT_S24_LE, i2s left justified, two channels: > > [SNDRV_PCM_FORMAT_S24_LE] = { > .width = 24, .phys = 32, .le = 1, .signd = 1, >

Re: [PATCH 2/4] components: multiple components for a device

2019-02-08 Thread Russell King - ARM Linux admin
On Fri, Feb 08, 2019 at 12:27:57AM +0100, Daniel Vetter wrote: > Component framework is extended to support multiple components for > a struct device. These will be matched with different masters based on > its sub component value. > > We are introducing this, as I915 needs two different

Re: [PATCH] component: Add documentation

2019-02-05 Thread Russell King - ARM Linux admin
On Tue, Feb 05, 2019 at 05:21:07PM +0100, Daniel Vetter wrote: > Someone owes me a beer ... I find that deeply offensive - it is clearly directed at me personally as author of the component helper. There are double-standards in the kernel ecosystem with respect to documentation - there are

Re: [PATCH 5/5] drm/i2c: tda998x: improve correctness of quantisation range

2019-01-30 Thread Russell King - ARM Linux admin
On Wed, Jan 30, 2019 at 03:53:04PM +, Brian Starkey wrote: > Hi Russell, > > On Fri, Jan 25, 2019 at 09:43:29AM +, Russell King wrote: > > CEA-861 says: "A Source shall not send a non-zero Q value that does > > not correspond to the default RGB Quantization Range for the > > transmitted

Re: [PATCH 3/5] drm/i2c: tda998x: add support for writing SPD

2019-01-30 Thread Russell King - ARM Linux admin
On Wed, Jan 30, 2019 at 03:41:04PM +, Brian Starkey wrote: > Hi Russell, > > These did eventually reach me on Saturday evening. > > On Fri, Jan 25, 2019 at 09:43:19AM +, Russell King wrote: > > Add support for writing the SPD infoframe to the TDA998x. Identify us > > as "Generic" vendor

Re: [PATCH 0/5] tda998x updates

2019-01-25 Thread Russell King - ARM Linux admin
(Removed what I assume is a typo on the Cc line - n...@arm.com) On Fri, Jan 25, 2019 at 11:45:10AM +, Brian Starkey wrote: > Hi Russell, > > On Fri, Jan 25, 2019 at 09:40:38AM +, Russell King - ARM Linux admin > wrote: > > Hi, > > > > This series adds s

[PATCH 0/5] tda998x updates

2019-01-25 Thread Russell King - ARM Linux admin
Hi, This series adds support for programming the SPD and vendor infoframes. It also adds support for pixel repeated modes - we were not rejecting these modes, but we also didn't have the implementation to support them. As their implementation is simple, add it rather than rejecting the modes.

Re: [PATCH] drm/armada: add mmp2 support

2019-01-22 Thread Russell King - ARM Linux admin
On Mon, Jan 21, 2019 at 07:03:49AM +0100, Lubomir Rintel wrote: > Heavily based on the Armada 510 (Dove) support. Like with 510 support, this > also just supports a single source clock -- the "Display 1" clock as > generated by the APMU. This one was chosen because the OLPC XO 1.75 laptop > uses

  1   2   >