[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-19 Thread Yakir Yang
Hi Thierry When I'm preparing v3 series, I meet some trobules from your comment, wish you could give some advise? ;) 在 2015/8/10 18:00, Thierry Reding 写道: > On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: > [...] >> edp: edp at ff97 { > [...] >>

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-11 Thread Yakir Yang
Hi Thierry, 在 2015/8/10 21:17, Thierry Reding 写道: > On Mon, Aug 10, 2015 at 08:59:44PM +0800, Yakir Yang wrote: >> Hi Thierry, >> >> 在 2015/8/10 18:00, Thierry Reding 写道: >>> On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: >>> [...] edp: edp at ff97 { >>>

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Yakir Yang
Hi Heiko, 在 2015/8/10 20:08, Heiko Stübner 写道: > Hi Yakir, > > Am Samstag, 8. August 2015, 11:54:38 schrieb Yakir Yang: +static int rockchip_dp_init(struct rockchip_dp_device *dp) +{ + struct device *dev = dp->dev; + struct device_node *np = dev->of_node; + int

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Yakir Yang
Hi Thierry, 在 2015/8/10 18:00, Thierry Reding 写道: > On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: > [...] >> edp: edp at ff97 { > [...] >> hsync-active-high = <0>; >> vsync-active-high = <0>; >> interlaced = <0>;

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Thierry Reding
On Mon, Aug 10, 2015 at 08:59:44PM +0800, Yakir Yang wrote: > Hi Thierry, > > 在 2015/8/10 18:00, Thierry Reding 写道: > >On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: > >[...] > >> edp: edp at ff97 { > >[...] > >> hsync-active-high = <0>; > >>

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Heiko Stübner
Hi Yakir, Am Samstag, 8. August 2015, 11:54:38 schrieb Yakir Yang: > >> +static int rockchip_dp_init(struct rockchip_dp_device *dp) > >> +{ > >> + struct device *dev = dp->dev; > >> + struct device_node *np = dev->of_node; > >> + int ret; > >> + > >> + dp->grf =

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-10 Thread Thierry Reding
On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: [...] > edp: edp at ff97 { [...] > hsync-active-high = <0>; > vsync-active-high = <0>; > interlaced = <0>; These look like they should come from the display mode definition

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-08 Thread Yakir Yang
Hi Hekio, 在 2015/8/8 6:46, Heiko Stübner 写道: > Hi Yakir, > > > I think this Rockchip portion is missing a devicetree binding. Oh, thanks, I would complete it in next ;) > You have the ability to power down the actual edp phy by using > grf_edp_iddq_en from GRF_SOC_CON12. This is similar

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-08 Thread Heiko Stübner
Hi Yakir, I think this Rockchip portion is missing a devicetree binding. You have the ability to power down the actual edp phy by using grf_edp_iddq_en from GRF_SOC_CON12. This is similar to how the rk3288 usb-phy gets put into a deeper state. So maybe you could provide a phy driver

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-07 Thread Yakir Yang
Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by: Yakir Yang --- Changes in v2: None drivers/gpu/drm/rockchip/Kconfig| 10 + drivers/gpu/drm/rockchip/Makefile