Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

2017-06-18 Thread Christoph Hellwig
On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote: > dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what > the compiler is already generating and will save a few lines of code > so what you end up with is something like: Honestly wanted to touch the code as little

Re: [PATCH 42/44] powerpc/cell: use the dma_supported method for ops switching

2017-06-18 Thread Christoph Hellwig
On Sun, Jun 18, 2017 at 06:50:27AM +1000, Benjamin Herrenschmidt wrote: > What is your rationale here ? (I have missed patch 0 it seems). Less code duplication, more modular dma_map_ops insteance. > dma_supported() was supposed to be pretty much a "const" function > simply informing whether a

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
On 2017-06-16 12:01, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 11:12:25 +0200 > Peter Rosin wrote: > >> All layers of chips support this, the only variable is the base address >> of the lookup table in the register map. >> >> Signed-off-by: Peter Rosin

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
On 2017-06-17 07:36, Boris Brezillon wrote: > Le Sat, 17 Jun 2017 00:46:12 +0200, > Peter Rosin a écrit : > >> Hm, it's probably too late to do it here. Planes have already been >> enabled and the engine may have started to fetch data and do the >> composition. You

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
On 2017-06-16 18:15, Boris Brezillon wrote: > Hi Peter, > > On Fri, 16 Jun 2017 17:54:04 +0200 > Peter Rosin wrote: > >> On 2017-06-16 12:01, Boris Brezillon wrote: >>> Hi Peter, >>> >>> On Fri, 16 Jun 2017 11:12:25 +0200 >>> Peter Rosin wrote: >>> All

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
On 2017-06-16 23:12, Peter Rosin wrote: > On 2017-06-16 18:15, Boris Brezillon wrote: >> To be very clear, I'd like you to test it through DRM ioctls, not only >> through the fbdev emulation layer. > > ...so yeah, right, I couldn't agree more. Any pointers to code w/o a bunch > of complex library

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
Hm, it's probably too late to do it here. Planes have already been enabled and the engine may have started to fetch data and do the composition. You could do that in ->update_plane() [1], and make it a per-plane thing. I'm not sure, but I think you can get the new

[RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
All layers of chips support this, the only variable is the base address of the lookup table in the register map. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 48 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 13

Re: Color lookup support for the atmel-hlcdc driver

2017-06-18 Thread Peter Rosin
On 2017-06-16 01:01, Peter Rosin wrote: > So, is this below better? I'll follow-up with a patch I need for the > fbdev emulation to work. Without adding gamma callbacks in drm_fb_helper_funcs I hit /* * The driver really shouldn't advertise pseudo/directcolor * visuals

[PATCH] drm: exynos: dsi: fix to return -ENODEV when DSI_PORT_OUT is not found

2017-06-18 Thread Shuah Khan
Fix exynos_dsi_parse_dt() to return -ENODEV when of_graph_get_remote_node() doesn't find DSI_PORT_OUT. -ENODEV is the correct error code to return and this change makes exynos behavior consistent with rest of the drm drivers. Signed-off-by: Shuah Khan ---

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-18 Thread Shuah Khan
On 06/16/2017 08:16 AM, Shuah Khan wrote: > Hi Inki, > > On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote: >> It doesn't need to try to find a bridge if bridge node doesn't exist. >> >> Signed-off-by: Inki Dae >> --- >>

Re: [PATCH v3] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-06-18 Thread Sanchayan Maity
Hello Marek, On 17-06-15 19:57:35, Stefan Agner wrote: > On 2017-06-15 10:26, Marek Vasut wrote: > > On 06/15/2017 05:12 PM, Fabio Estevam wrote: > >> Hi Marek, > >> > >> On Mon, Jun 5, 2017 at 9:08 AM, Marek Vasut wrote: > >> > >>> I'm currently on vacation, try one more time and

[PATCH][RESEND] drm: dw-hdmi-i2s: add .get_dai_id callback for ALSA SoC

2017-06-18 Thread Kuninori Morimoto
From: Kuninori Morimoto ALSA SoC needs to know connected DAI ID for probing. It is not a big problem if device/driver was only for sound, but getting DAI ID will be difficult if device includes both Video/Sound, like HDMI. To solve this issue, this patch adds

Re: Color lookup support for the atmel-hlcdc driver

2017-06-18 Thread Peter Rosin
On 2017-06-16 01:03, Peter Rosin wrote: > On 2017-06-16 01:01, Peter Rosin wrote: >> So, is this below better? I'll follow-up with a patch I need for the >> fbdev emulation to work. > > Without adding gamma callbacks in drm_fb_helper_funcs I hit > > /* >* The driver really

Re: [PATCH v2 3/4] ARM: dts: exynos: Fix the active of reset gpios from rinato dts

2017-06-18 Thread Krzysztof Kozlowski
On Thu, Jun 15, 2017 at 07:03:29PM +0900, Hoegeun Kwon wrote: > This reset gpios is active low, therefore fix from active high to low. > > Signed-off-by: Hoegeun Kwon > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v3] drm: mxsfb_crtc: Reset the eLCDIF controller

2017-06-18 Thread Marek Vasut
On 06/15/2017 10:02 PM, Sean Paul wrote: > On Thu, Jun 15, 2017 at 01:53:15PM -0400, Sean Paul wrote: >> On Fri, May 05, 2017 at 03:01:41PM -0300, Fabio Estevam wrote: >>> According to the eLCDIF initialization steps listed in the MX6SX >>> Reference Manual the eLCDIF block reset is mandatory.

Re: [PATCH] drm: exynos: dsi: fix to return -ENODEV when DSI_PORT_OUT is not found

2017-06-18 Thread Inki Dae
Hi Shuah, 2017년 06월 17일 07:56에 Shuah Khan 이(가) 쓴 글: > Fix exynos_dsi_parse_dt() to return -ENODEV when of_graph_get_remote_node() > doesn't find DSI_PORT_OUT. -ENODEV is the correct error code to return and > this change makes exynos behavior consistent with rest of the drm drivers. For this,

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-18 Thread Inki Dae
Hi Shuah, 2017년 06월 17일 05:16에 Shuah Khan 이(가) 쓴 글: > On 06/16/2017 08:16 AM, Shuah Khan wrote: >> Hi Inki, >> >> On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote: >>> It doesn't need to try to find a bridge if bridge node doesn't exist. >>> >>> Signed-off-by: Inki Dae

Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

2017-06-18 Thread Alexander Duyck
On Fri, Jun 16, 2017 at 11:10 AM, Christoph Hellwig wrote: > DMA_ERROR_CODE is not a public API and will go away. Instead properly > unwind based on the loop counter. > > Signed-off-by: Christoph Hellwig > Acked-by: Dave Jiang > Acked-By: Vinod

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-18 Thread Shuah Khan
Hi Inki, On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote: > It doesn't need to try to find a bridge if bridge node doesn't exist. > > Signed-off-by: Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 +--- > 1 file changed, 5

[RFC PATCH v2 2/3] drm/fb-cma-helper: expose more of fb cma guts

2017-06-18 Thread Peter Rosin
DRM drivers supporting clut may want a convenient way to only use non-default .gamma_set and .gamma_get ops in the drm_fb_helper_funcs in order to avoid the following /* * The driver really shouldn't advertise pseudo/directcolor * visuals if it can't deal with the

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-18 Thread Aaro Koskinen
Hi, On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > On 15/06/17 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > Are you sure it doesn't probe? It fails the omapdss_stack_is_ready() > check? If that's

Re: [Freedreno] [PATCH] fixup! drm/msm: Separate locking of buffer resources from struct_mutex

2017-06-18 Thread Sushmita Susheelendra
Sounds good. On 2017-06-16 15:44, Rob Clark wrote: On Fri, Jun 16, 2017 at 5:32 PM, wrote: Hi Rob, This looks good to me! Just one nit: msm_gem_vunmap becomes very shrinker specific as it holds the msm_obj->lock with the shrinker class. Should we have the caller

[RFC PATCH v2 3/3] drm: atmel-hlcdc: add clut support for legacy fbdev

2017-06-18 Thread Peter Rosin
The clut is not synchronized with the drm gamma_lut state. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 53 ++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 12 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h |

[RFC PATCH v2 1/3] drm: atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-18 Thread Peter Rosin
All layers of all supported chips support this, the only variable is the base address of the lookup table in the register map. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 13

[RFC PATCH 0/3] drm: atmel-hlcdc: clut support

2017-06-18 Thread Peter Rosin
Hi! This series adds support for an 8-bit clut mode in the atmel-hlcdc driver. For various reasons I have only tested it with the fbdev interface, and am therefore not really sure if it works w/o patch 2 and 3. Also, when using it with the fbdev emulation layer, something seems to allocate the

[RFC PATCH v2 0/3] drm: atmel-hlcdc: clut support

2017-06-18 Thread Peter Rosin
Hi! This series adds support for an 8-bit clut mode in the atmel-hlcdc driver. I have only tested it with the fbdev interface, and am therefore not really sure if it works w/o patch 2 and 3. One significant reason for that is that the modetest test program in libdrm does not support clut modes

Re: [Freedreno] [PATCH] fixup! drm/msm: Separate locking of buffer resources from struct_mutex

2017-06-18 Thread ssusheel
Hi Rob, This looks good to me! Just one nit: msm_gem_vunmap becomes very shrinker specific as it holds the msm_obj->lock with the shrinker class. Should we have the caller i.e. msm_gem_shrinker_vmap hold it instead? Or change it's name to msm_gem_vunmap_shrinker or something like that...?

[RFC PATCH 2/3] drm/fb-cma-helper: expose more of fb cma guts

2017-06-18 Thread Peter Rosin
DRM drivers supporting clut may want a convenient way to only use non-default .gamma_set and .gamma_get ops in the drm_fb_helper_funcs in order to avoid the following /* * The driver really shouldn't advertise pseudo/directcolor * visuals if it can't deal with the

[RFC PATCH 3/3] atmel-hlcdc: add clut support for legacy fbdev

2017-06-18 Thread Peter Rosin
The clut is also synchronized with the drm gamma_lut state. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 49 ++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 12 +-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-06-18 Thread Aaro Koskinen
Hi, On Thu, Jun 15, 2017 at 10:28:31AM +0300, Peter Ujfalusi wrote: > On 2017-06-15 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > > > Bisected to: > > > > a09d2bc1503508c17ef3a71c6b1905e3660f3029 is the first bad

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101294 Fabian Maurer changed: What|Removed |Added CC|

[Bug 100306] System randomly freezes or crashes to the login screen, glitches until rebooted

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100306 --- Comment #30 from MirceaKitsune --- Created attachment 132030 --> https://bugs.freedesktop.org/attachment.cgi?id=132030=edit Photo of the corrupt image on the screen I have discovered some very

[Bug 196117] amdgpu - RX 480 (polaris) - freeze during boot

2017-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196117 --- Comment #2 from Michel Dänzer (mic...@daenzer.net) --- Sounds like maybe some files under /lib/firmware/amdgpu/ are missing in the initrd. In order to get more information, try booting with modprobe.blacklist=amdgpu on the kernel command

[Bug 101492] Git repo ~agd5f/linux has problem: badTimezone: invalid author/committer line - bad time zone

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101492 Bug ID: 101492 Summary: Git repo ~agd5f/linux has problem: badTimezone: invalid author/committer line - bad time zone Product: DRI Version: DRI git Hardware: All

[Bug 101492] Git repo ~agd5f/linux has problem: badTimezone: invalid author/committer line - bad time zone

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101492 Yurii Kolesnykov changed: What|Removed |Added QA Contact|

[Bug 196117] New: amdgpu RC 480 (polaris) freeze after initramfs, before kernel load

2017-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196117 Bug ID: 196117 Summary: amdgpu RC 480 (polaris) freeze after initramfs, before kernel load Product: Drivers Version: 2.5 Kernel Version: 4.11.6 Hardware: x86-64

[Bug 196117] amdgpu RC 480 (polaris) freeze after initramfs, before kernel load

2017-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196117 --- Comment #1 from Paul K. Gerke (paulkge...@craftware.nl) --- I just realized that while trying to be concise, I deprived this bug report of a lot of information: The very short version: The AMDGPU driver somehow causes the system to hang

[Bug 196117] amdgpu - RX 480 (polaris) - freeze during boot

2017-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196117 Paul K. Gerke (paulkge...@craftware.nl) changed: What|Removed |Added Summary|amdgpu RC 480 (polaris) |amdgpu - RX 480

[Bug 101491] Can't wake up the dedicated graphics card unless power management is disabled

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101491 Bug ID: 101491 Summary: Can't wake up the dedicated graphics card unless power management is disabled Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

[Bug 101491] Can't wake up the dedicated graphics card unless power management is disabled

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101491 --- Comment #1 from drkdf...@rocketmail.com --- Created attachment 132032 --> https://bugs.freedesktop.org/attachment.cgi?id=132032=edit lspci -k output -- You are receiving this mail because: You are the assignee for the

[Bug 101224] texelFetch(usampler) returns black color

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101224 --- Comment #6 from Roland Scheidegger --- This is certainly not the first time it came up fwiw, especially since there's binary drivers which will just ignore the incomplete texture since obviously that sampler state isn't

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101294 --- Comment #6 from Fabian Maurer --- Bisected to commit 2769dadb0fafdbafc98630fdf96924a3bb209ab7 Author: Marek Olšák Date: Thu Apr 13 23:46:59 2017 +0200 gallium/radeon: always flush

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101294 Fabian Maurer changed: What|Removed |Added Keywords||bisected -- You

[Bug 101478] Display not working after a certain commit

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101478 --- Comment #2 from John --- Oops, sorry about that. And thank you for the quick reply! -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 101478] Display not working after a certain commit

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101478 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 101475] Max Core Profile for OpenGL showing 0.0

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101475 vinf...@gmail.com changed: What|Removed |Added Severity|normal |minor --- Comment #8 from

Re: [PATCH 42/44] powerpc/cell: use the dma_supported method for ops switching

2017-06-18 Thread Benjamin Herrenschmidt
On Sun, 2017-06-18 at 00:13 -0700, Christoph Hellwig wrote: > On Sun, Jun 18, 2017 at 06:50:27AM +1000, Benjamin Herrenschmidt wrote: > > What is your rationale here ? (I have missed patch 0 it seems). > > Less code duplication, more modular dma_map_ops insteance. > > > dma_supported() was

[Bug 101479] shader display problems Unreal 4 Engine

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101479 vinf...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability

2017-06-18 Thread Rob Herring
On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote: > The explanation for the endpoint ID numbering scheme is convoluted > and hard to understand. > > This patch aims to improve the readability of it by combining the > existing two paragraphs, while also providing a diagram example, >

[Bug 100070] Rocket League: grass gets rendered incorrectly

2017-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100070 --- Comment #7 from Nicolai Hähnle --- Hmm, I'm afraid that looks a bit tricky to analyze. I wonder if the game actually does something slightly different on NVidia cards? Would be nice if somebody could replay the trace on