Re: [PATCH 5/5] drm/amdgpu: Don't force BOs into visible VRAM for page faults

2017-06-28 Thread Michel Dänzer
On 28/06/17 11:33 AM, John Brooks wrote: > There is no need for page faults to force BOs into visible VRAM if it's > full, and the time it takes to do so is great enough to cause noticeable > stuttering. Add GTT as a possible placement so that if visible VRAM is > full, page faults move BOs to GTT

Re: [PATCH 3/8] drm/amd/amdgpu: Added a dwc quirk for Stoney platform

2017-06-28 Thread Mark Brown
On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote: > + if (adev->asic_type == CHIP_STONEY) { > + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET | > + DW_I2S_QUIRK_COMP_PARAM1 | > + DW_I2S_QUIRK_16BIT_IDX_OVERRIDE; > + }

Re: [PATCH v2] Visible VRAM Management Improvements

2017-06-28 Thread Michel Dänzer
On 28/06/17 11:33 AM, John Brooks wrote: > Changes in this version: > - Dropped former patch 1 ("Separate placements and busy placements") as it was > no longer necessary > - Dropped former patch 4 ("Don't force BOs into visible VRAM if they can go to > GTT instead") as it was unnecessary and

[Bug 196197] [drm:r600_ring_test [radeon]] *ERROR* radeon: ring 0 test failed (scratch(0x8504)=0xCAFEDEAD)

2017-06-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196197 --- Comment #3 from Michel Dänzer (mic...@daenzer.net) --- (In reply to Andreas Brogle from comment #2) > # git bisect log > git bisect start > # bad: [c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201] Linux 4.11-rc1 > git bisect bad

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

2017-06-28 Thread Archit Taneja
On 06/28/2017 01:28 AM, Eric Anholt wrote: When a mipi_dsi_host is registered, the DT is walked to find any child nodes with compatible strings. Those get registered as DSI devices, and most DSI panel drivers are mipi_dsi_drivers that attach to those nodes. There is one special case

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

2017-06-28 Thread Michel Dänzer
On 29/06/17 08:26 AM, John Brooks wrote: > On Wed, Jun 28, 2017 at 03:05:32PM +0200, Christian König wrote: >> Am 28.06.2017 um 04:33 schrieb John Brooks: >>> When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, >>> it should only be treated as a hint to initially place a BO

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

2017-06-28 Thread Michel Dänzer
On 28/06/17 11:33 AM, John Brooks wrote: > When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, > it should only be treated as a hint to initially place a BO somewhere CPU > accessible, rather than having a permanent effect on BO placement. > > Instead of the flag being set

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Chris Wilson
Quoting Sean Paul (2017-06-28 17:47:24) > On Wed, Jun 28, 2017 at 05:00:20PM +0100, Chris Wilson wrote: > > Quoting Sean Paul (2017-06-28 16:51:11) > > > Protect against long-running processes from overflowing the timeline > > > and creating fences that go back in time. While we're at it, avoid >

[Bug 101631] [amd-staging] RX480 system hang; spamming errors in dc_surface

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101631 --- Comment #1 from Denys --- Created attachment 132313 --> https://bugs.freedesktop.org/attachment.cgi?id=132313=edit dmesg(same config, but another session with disabled xdm) -- You are receiving this mail because:

[Bug 101633] [amd-staging] MST monitor, strange behaviour in terminal

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101633 --- Comment #1 from Denys --- Created attachment 132316 --> https://bugs.freedesktop.org/attachment.cgi?id=132316=edit Good state -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] drm: adv7511_audio: Add .get_dai_id callback to map port number to dai id

2017-06-28 Thread Mark Brown
On Mon, Jun 26, 2017 at 09:31:34AM -0700, John Stultz wrote: > Hey Mark, > Just wanted to check on this to make sure it didn't slip by. I've > not seen it show up in -next yet. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday,

Applied "drm: dw-hdmi-i2s: add .get_dai_id callback for ALSA SoC" to the asoc tree

2017-06-28 Thread Mark Brown
The patch drm: dw-hdmi-i2s: add .get_dai_id callback for ALSA SoC has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

[Bug 101633] [amd-staging] MST monitor, strange behaviour in terminal

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101633 Bug ID: 101633 Summary: [amd-staging] MST monitor, strange behaviour in terminal Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux

[PATCH v3 1/6] drm/atomic: initial support for asynchronous plane update

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan In some cases, like cursor updates, it is interesting to update the plane in an asynchronous fashion to avoid big delays. The current queued update could be still waiting for a fence to signal and thus block any subsequent update until its

[PATCH v3 2/6] drm/i915: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v3: - set correct vma to new state for cleanup

[PATCH v3 4/6] drm/msm: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what mdp5_update_cursor_plane_legacy() did but through atomic. v4: add missing atomic async commit call to

[PATCH v3 0/6] drm: add asynchrounous plane update

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Hi, This is just a rebase on top of latest drm-misc-next. Last iteration can be found here: https://www.spinics.net/lists/intel-gfx/msg130582.html Please review! Thanks, Gustavo --- Gustavo Padovan (6): drm/atomic: initial

[PATCH v3 3/6] drm/i915: remove intel_cursor_plane_funcs

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter Signed-off-by: Gustavo Padovan ---

[Bug 101631] [amd-staging] RX480 system hang; spamming errors in dc_surface

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101631 Bug ID: 101631 Summary: [amd-staging] RX480 system hang; spamming errors in dc_surface Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS:

[Bug 101631] [amd-staging] RX480 system hang; spamming errors (dc_surface)

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101631 Denys changed: What|Removed |Added Summary|[amd-staging] RX480 system |[amd-staging] RX480

[Bug 101633] [amd-staging] MST monitor, strange behaviour in terminal

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101633 --- Comment #2 from Denys --- Created attachment 132317 --> https://bugs.freedesktop.org/attachment.cgi?id=132317=edit dmesg In dmesg: 121sec - display off 138sec - display on -- You are receiving this mail because:

[PATCH v3 5/6] drm/msm: remove mdp5_cursor_plane_funcs

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark Cc: Archit Taneja Signed-off-by: Gustavo Padovan

[PATCH v3 6/6] drm/vc4: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support for async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what vc4_update_plane() did but through atomic. v5: add missing call to vc4_plane_atomic_check() (Eric Anholt) v4: add

[PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-06-28 Thread Laurent Pinchart
Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC start to CRTC resume") changed the order of the plane commit and CRTC enable operations to accommodate the runtime PM requirements. However, this introduced corruption in the first displayed frame, as the CRTC is now enabled

Re: [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code

2017-06-28 Thread Mark Brown
On Fri, Jun 23, 2017 at 12:35:02PM -0400, Alex Deucher wrote: > Reviewed-by: Alex Deucher > index dcbf997..e48ae5d 100644 > --- a/sound/soc/amd/acp-pcm-dma.c > +++ b/sound/soc/amd/acp-pcm-dma.c > @@ -34,6 +34,8 @@ > > #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE *

Re: [git pull] drm fixes for 4.12-rc8

2017-06-28 Thread Linus Torvalds
On Wed, Jun 28, 2017 at 12:18 AM, Dave Airlie wrote: > > git://people.freedesktop.org/~airlied/linux drm-fixes-for-v4.12-rc8 That tag does not exist. However: > for you to fetch changes up to 9ff1beb1d19ffe2b26bf9cd2d33e6073d4f4b5fe: That commit 9ff1beb1d19f _is_ the head

Applied "ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver" to the asoc tree

2017-06-28 Thread Mark Brown
The patch ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Re: [GIT PULL] etnaviv-fixes urgent for 4.12

2017-06-28 Thread Dave Airlie
> Adding Linus, I think Dave is already on vacation. Linus, can you > please pull this directly, not much point in shovelling this through a > drm tree first. It's fixes for the ANDROID_native_sync gl extension > afaics. > -Daniel Yup started vacation, so not going to be near a git tree,

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
On Wed, Jun 28, 2017 at 08:45:55PM +0100, Chris Wilson wrote: > Quoting Sean Paul (2017-06-28 17:47:24) > > On Wed, Jun 28, 2017 at 05:00:20PM +0100, Chris Wilson wrote: > > > Quoting Sean Paul (2017-06-28 16:51:11) > > > > Protect against long-running processes from overflowing the timeline > > >

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-06-28 Thread Geert Uytterhoeven
On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > start to CRTC resume") changed the order of the plane commit and CRTC > enable operations to accommodate the runtime PM

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-06-28 Thread Laurent Pinchart
Hi Geert, On Wednesday 28 Jun 2017 20:52:53 Geert Uytterhoeven wrote: > On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations

Re: [PATCH v4] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Hi Maxime, On 27 June 2017 at 05:05, Maxime Ripard wrote: > On Sat, Jun 24, 2017 at 04:10:54PM +1000, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case the DDC bus is accessible by the

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Alexey Brodkin
Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent

[PATCH v6] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: "As in the general case the DDC bus is accessible by the kernel at the I2C level, drivers must make all reasonable efforts to expose it as an I2C adapter and use drm_get_edid() instead of abusing this function." Exposing

[PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: "As in the general case the DDC bus is accessible by the kernel at the I2C level, drivers must make all reasonable efforts to expose it as an I2C adapter and use drm_get_edid() instead of abusing this function." Exposing

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

2017-06-28 Thread Tony Lindgren
* Jyri Sarha [170627 02:47]: > There is no real volume on HDMI audio output as it is a digital > interface, but it should be possible to provide some volume control > using TV's volume trough CEC. OK great! Tony ___ dri-devel mailing

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

2017-06-28 Thread Tony Lindgren
* Hans Verkuil [170627 01:39]: > On 26/06/17 13:07, Tony Lindgren wrote: > > Tomi, > > > > * Tomi Valkeinen [170428 04:15]: > >> On 14/04/17 13:25, Hans Verkuil wrote: > >>> From: Hans Verkuil > >>> > >>> The CEC pin was always

[PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: "As in the general case the DDC bus is accessible by the kernel at the I2C level, drivers must make all reasonable efforts to expose it as an I2C adapter and use drm_get_edid() instead of abusing this function." Exposing

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Michael Thayer
Hello Hans, 26.06.2017 18:06, Hans de Goede wrote: > Hi, > > On 23-06-17 11:31, Daniel Vetter wrote: >> On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote: [vboxvideo driver submission information to staging.] >> >> In the end it's up to you, but our experience in drm with -staging

[PATCH] drm: tilcdc: tilcdc_tfp410: fsl_raid: make of_device_ids const.

2017-06-28 Thread Arvind Yadav
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by work with const of_device_ids. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1496 592 02088 828

Re: [PATCH 1/8] drm: arcpgu: Remove CRTC .commit() helper operation

2017-06-28 Thread Alexey Brodkin
Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The CRTC helper .commit() operation is legacy code, the atomic helpers > prefer the .enable() operation. As the arcpgu driver implements the > .enable() operation, .commit() is never used and can be removed. > >

[PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

2017-06-28 Thread Kuninori Morimoto
From: Kuninori Morimoto Now, we can use of_graph_get_remote_endpoint(). Let's use it. Signed-off-by: Kuninori Morimoto --- based on 4c9c3d595f1bad021cc126d20879df4016801736 ("of_graph: add of_graph_get_remote_endpoint()")

[PATCH v2] drm: tilcdc: tilcdc_panel: make of_device_ids const.

2017-06-28 Thread Arvind Yadav
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by work with const of_device_ids. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1531 592 02123 84b

[PATCH] drm/i915: Fix an error checking test

2017-06-28 Thread Christophe JAILLET
'dma_buf_vmap' returns NULL on error, not an error pointer. Fixes: 6cca22ede8a4 ("drm/i915: Add some mock tests for dmabuf interop") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c | 6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH 3/5] drm/amdgpu: Track time of last page fault and last CS move in struct amdgpu_bo

2017-06-28 Thread John Brooks
On Wed, Jun 28, 2017 at 03:06:47PM +0200, Christian König wrote: > Am 28.06.2017 um 04:33 schrieb John Brooks: > >Signed-off-by: John Brooks > >--- > > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++ > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 + > >

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

2017-06-28 Thread John Brooks
On Wed, Jun 28, 2017 at 03:05:32PM +0200, Christian König wrote: > Am 28.06.2017 um 04:33 schrieb John Brooks: > >When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, > >it should only be treated as a hint to initially place a BO somewhere CPU > >accessible, rather than

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread kbuild test robot
Hi Jonathan, [auto build test WARNING on next-20170627] [cannot apply to v4.12-rc7 v4.12-rc6 v4.12-rc5 v4.12-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] drm: tilcdc: tilcdc_panel: fsl_raid: make of_device_ids const.

2017-06-28 Thread Arvind Yadav
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by work with const of_device_ids. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1531 592 02123 84b

[gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1198635 I ran into the following piece of code at drivers/gpu/drm/radeon/vce_v2_0.c:107: 107void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) 108{ 109bool sw_cg = false; 110 111if (enable && (rdev->cg_flags &

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

2017-06-28 Thread Tony Lindgren
* Hans Verkuil [170627 02:27]: > On 27/06/17 11:14, Tony Lindgren wrote: > > Adding Jyri to Cc, hopefully the CEC support allows also setting the > > HDMI audio volume level on devices implementing it? Or am I too > > optimistic? :) > > I'm not quite sure what you mean. Do

[PATCH] drm: arcpgu: Allow some clock deviation in crtc->mode_valid() callback

2017-06-28 Thread Jose Abreu
Currently we expect that clock driver produces the exact same value as we are requiring. There can, and will, be some deviation however so we need to take into account that instead of rejecting the mode. According to HDMI spec we have a max of +-0.5% for the pixel clock frequency variation. Lets

[PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const.

2017-06-28 Thread Arvind Yadav
of_device_ids are not supposed to change at runtime. All functions working with of_device_ids provided by work with const of_device_ids. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1496 592 02088 828

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Hi Maxime, On 28 June 2017 at 19:20, Maxime Ripard wrote: > On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: >> +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ >> + SUN4I_HDMI_DDC_INT_STATUS_ILLEGAL_FIFO_OPERATION | \ >> +

Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Gustavo A. R. Silva
Hi Alex, Quoting "Deucher, Alexander" : -Original Message- From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] Sent: Wednesday, June 28, 2017 10:22 AM To: Deucher, Alexander; Koenig, Christian; David Airlie Cc: amd-...@lists.freedesktop.org;

Re: [PATCH 2/8] drm: arcpgu: Remove CRTC .prepare() helper operation

2017-06-28 Thread Alexey Brodkin
Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The CRTC helper .prepare() operation is legacy code, the atomic helpers > prefer the .disable() operation. As the arcpgu driver implements the > .disable() and .prepare() operations identicallly, .prepare() can be > removed.

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

2017-06-28 Thread Alexey Brodkin
Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The CRTC .disable() helper operation is deprecated for atomic drivers, > the new .atomic_disable() helper operation being preferred. Convert all > atomic drivers to .atomic_disable() to avoid cargo-cult use of > .disable()

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Dominik Behr
I think the kernel has problems with Android fences which were slowly broken as they were de-staged: 1. They allowed for fence/timeline value/seqno to overflow/rollover and that would break only if delta between timeline and earlier unsignaled fence exceeded 2^31 or so. Android relies on that

[PATCH] dim: Fixes/polish for cherry-pick

2017-06-28 Thread Daniel Vetter
- Subcommands without subshell is nice, except it can break worktree setups: Branch specific commands want to run in the worktree, general commands like dim_cite switch back to the main directory. Tears ensue (or well, some cryptic complaint from git that cherry-pick --abort failed because

Re: [PATCH] drm: atomic-helper: make CRTC .atomic_enable() operation truly optional

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 11:23:44AM +0300, Laurent Pinchart wrote: > The CRTC .atomic_enable() helper operation is documented as optional, > but if not provided the helpers will call the .commit() operation > unconditionally, which is marked as deprecated for atomic drivers. Make > the

Re: [PATCH] drm/hdlcd: remove drm_vblank_cleanup, rise of the zoombies edition

2017-06-28 Thread Liviu Dudau
On Wed, Jun 28, 2017 at 11:11:41AM +0200, Daniel Vetter wrote: > This was accidentally restored in > > commit de5cc8155cd250a31da67dea49aff7637ce98887 > Author: Liviu Dudau > Date: Tue Jun 6 15:05:21 2017 +0100 > > drm/arm: hdlcd: Set the CRTC's port before binding

Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Alan Cox
On Wed, 28 Jun 2017 12:36:35 +0200 Daniel Vetter wrote: > There's a bunch of folks who're trying to make printk less > contended and faster, but there's a problem: printk uses the > console_lock, and the console lock has become the BKL for all things > fbdev/fbcon, which

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Maxime Ripard
On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: > +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ > + SUN4I_HDMI_DDC_INT_STATUS_ILLEGAL_FIFO_OPERATION | \ > + SUN4I_HDMI_DDC_INT_STATUS_DDC_RX_FIFO_UNDERFLOW | \ > + SUN4I_HDMI_DDC_INT_STATUS_DDC_TX_FIFO_OVERFLOW | \ > +

Re: [PATCH] drm/imx: fix typo in ipu_plane_formats[]

2017-06-28 Thread Philipp Zabel
On Wed, 2017-06-28 at 12:31 +0300, Laurentiu Palcu wrote: > The BGRA appears twice in the ipu_plane_formats[] list. The > duplicate should be BGRX. > > The original commit is: > > commit 59d6b7189a96 ("drm/imx: ipuv3-plane: enable support for RGBX > and RGBA pixel formats") > >

Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-28 Thread Maarten Lankhorst
Op 27-06-17 om 17:01 schreef Daniel Vetter: > On Tue, Jun 27, 2017 at 04:29:44PM +0200, Maarten Lankhorst wrote: >> Op 27-06-17 om 09:37 schreef Daniel Vetter: >>> On Mon, Jun 26, 2017 at 03:44:07PM -0400, Harry Wentland wrote: On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote: > Problem :

[bug report] gma500: initial medfield merge

2017-06-28 Thread Dan Carpenter
Hello Kirill A. Shutemov, The patch 026abc333205: "gma500: initial medfield merge" from Mar 8, 2012, leads to the following static checker warning: drivers/gpu/drm/gma500/mdfld_intel_display.c:102 mdfldWaitForPipeEnable() warn: masked condition '(temp & (1 << 30)) == 1' is

[PATCH] drm/fb-helper: Support deferred setup

2017-06-28 Thread Daniel Vetter
FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matching mode. The fallback is in place

Re: [GIT PULL] etnaviv-fixes urgent for 4.12

2017-06-28 Thread Daniel Vetter
Adding Linus, I think Dave is already on vacation. Linus, can you please pull this directly, not much point in shovelling this through a drm tree first. It's fixes for the ANDROID_native_sync gl extension afaics. -Daniel On Wed, Jun 28, 2017 at 11:04 AM, Lucas Stach

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Dan Carpenter
On Mon, Jun 26, 2017 at 04:55:46PM +0200, Hans de Goede wrote: > >> +int vbox_dumb_create(struct drm_file *file, > >> + struct drm_device *dev, struct drm_mode_create_dumb *args) > >> +{ > >> + int ret; > >> + struct drm_gem_object *gobj; > >> + u32 handle; > >> + > >> +

[PATCH] drm/imx: fix typo in ipu_plane_formats[]

2017-06-28 Thread Laurentiu Palcu
The BGRA appears twice in the ipu_plane_formats[] list. The duplicate should be BGRX. The original commit is: commit 59d6b7189a96 ("drm/imx: ipuv3-plane: enable support for RGBX and RGBA pixel formats") Signed-off-by: Laurentiu Palcu ---

Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult

2017-06-28 Thread Emil Velikov
Hi Laurent, On 27 June 2017 at 21:38, Laurent Pinchart wrote: > Hello, > > The atomic helpers favour the .enable() and .atomic_disable() CRTC helper > operations, but still support the legacy .prepare(), .commit(), .disable() and > .dpms() operations.

[PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
There's a bunch of folks who're trying to make printk less contended and faster, but there's a problem: printk uses the console_lock, and the console lock has become the BKL for all things fbdev/fbcon, which in turn pulled in half the drm subsystem under that lock. That's awkward. There reasons

Re: [PATCH] drm/hdlcd: remove drm_vblank_cleanup, rise of the zoombies edition

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 10:30:11AM +0100, Liviu Dudau wrote: > On Wed, Jun 28, 2017 at 11:11:41AM +0200, Daniel Vetter wrote: > > This was accidentally restored in > > > > commit de5cc8155cd250a31da67dea49aff7637ce98887 > > Author: Liviu Dudau > > Date: Tue Jun 6 15:05:21

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Laurent Pinchart
Hi Daniel, On Wednesday 28 Jun 2017 09:42:54 Daniel Vetter wrote: > On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > > diff --git a/include/drm/drm_modeset_helper_vtables.h > > b/include/drm/drm_modeset_helper_vtables.h index > > 474a1029ec79..d74a2cafc3de 100644 > > ---

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

2017-06-28 Thread Christian König
Am 28.06.2017 um 04:33 schrieb John Brooks: When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, it should only be treated as a hint to initially place a BO somewhere CPU accessible, rather than having a permanent effect on BO placement. Instead of the flag being set in

Re: [PATCH v4] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 2:46 PM, Hans de Goede wrote: > On 27-06-17 06:25, kbuild test robot wrote: >> >> Hi Hans, >> >> [auto build test ERROR on staging/staging-testing] >> [also build test ERROR on v4.12-rc7 next-20170626] >> [if your patch is applied to the wrong git

Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 1:00 PM, Alan Cox wrote: > On Wed, 28 Jun 2017 12:36:35 +0200 > Daniel Vetter wrote: > >> There's a bunch of folks who're trying to make printk less >> contended and faster, but there's a problem: printk uses the >>

[PATCH 2/2] drm/atomic: Wait indefinitely and interruptibly for hw_done.

2017-06-28 Thread Maarten Lankhorst
Without waiting for hw_done, previous atomic updates may dereference the wrong state and cause a lot of confusion. The real fix is fixing all obj->state to use the accessor macros, but for now wait indefinitely and interruptibly. Cc: Boris Brezillon Cc: David

[PATCH 1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error.

2017-06-28 Thread Maarten Lankhorst
We want to change swap_state to wait indefinitely, but to do this swap_state should wait interruptibly. This requires propagating the error to each driver. All drivers have changes to deal with the clean up. In order to allow easy reverting, the commit that changes behavior is separate so someone

Re: [PATCH v4] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Hans de Goede
Hi Michael, On 27-06-17 06:25, kbuild test robot wrote: Hi Hans, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/5] drm/amdgpu: Track time of last page fault and last CS move in struct amdgpu_bo

2017-06-28 Thread Christian König
Am 28.06.2017 um 04:33 schrieb John Brooks: Signed-off-by: John Brooks --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ 3 files changed, 10 insertions(+)

Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult

2017-06-28 Thread Laurent Pinchart
Hi Emil, On Wednesday 28 Jun 2017 12:27:06 Emil Velikov wrote: > On 27 June 2017 at 21:38, Laurent Pinchart wrote: > > Hello, > > > > The atomic helpers favour the .enable() and .atomic_disable() CRTC helper > > operations, but still support the legacy .prepare(), .commit(), .disable() > > and

[PATCH] drm: vmwgfx: Remove the legacy CRTC .prepare() helper operations

2017-06-28 Thread Laurent Pinchart
The CRTC .prepare() helper operation is legacy code, drivers should use the .atomic_disable() operation instead. When a CRTC is temporarily disabled prior to a mode set, the atomic helpers call the .prepare() operation if provided instead of the .atomic_disable() operation. In order to avoid

[PATCH] drm/gma500: remove an unneeded NULL check

2017-06-28 Thread Dan Carpenter
"connector" is the list iterator and it can't be NULL. It causes a static checker warning because we dereference the iterator to get the next item in the list. Let's remove this check. Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Liviu Dudau
On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > The old state is useful for drivers that need to perform operations at > enable time that depend on the transition between the old and new > states. > > While at it, rename the operation to .atomic_enable() to be consistent >

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Laurent Pinchart
Hi Liviu, On Wednesday 28 Jun 2017 14:41:49 Liviu Dudau wrote: > On Wed, Jun 28, 2017 at 12:16:20AM +0300, Laurent Pinchart wrote: > > The old state is useful for drivers that need to perform operations at > > enable time that depend on the transition between the old and new > > states. > > > >

Re: [PATCH v2 3/4] drm/tinydrm: Add tinydrm_xrgb8888_to_gray8() helper

2017-06-28 Thread Noralf Trønnes
Den 26.06.2017 11.43, skrev Daniel Vetter: On Thu, Jun 08, 2017 at 05:14:34PM +0200, Noralf Trønnes wrote: Drm has no monochrome or greyscale support so add a conversion from the common format XR24. Also reorder includes into the common order. Signed-off-by: Noralf Trønnes

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread dri-devel-bounces
,Thierry Reding ,Thomas Hellstrom ,Tomi Valkeinen ,VMware Graphics ,Vincent Abriou ,Xinliang Liu ,Xinwei Kong

Re: [PATCH v2 4/4] drm/tinydrm: Add RePaper e-ink driver

2017-06-28 Thread Noralf Trønnes
Den 26.06.2017 11.49, skrev Daniel Vetter: On Thu, Jun 08, 2017 at 05:14:35PM +0200, Noralf Trønnes wrote: This adds support for the Pervasive Displays RePaper branded displays. The controller code is taken from the userspace driver available through repaper.org. Only the V231 film is

Re: [PATCH v2 3/4] drm/tinydrm: Add tinydrm_xrgb8888_to_gray8() helper

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 04:26:23PM +0200, Noralf Trønnes wrote: > > Den 26.06.2017 11.43, skrev Daniel Vetter: > > On Thu, Jun 08, 2017 at 05:14:34PM +0200, Noralf Trønnes wrote: > > > Drm has no monochrome or greyscale support so add a conversion > > > from the common format XR24. > > > > > >

Re: xilinx_drm and atomic modesetting

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 12:07:28PM -0400, Jean-Francois Dagenais wrote: > Hi Hyun, > > > On Jun 27, 2017, at 20:53, Hyun Kwon wrote: > > > > > > As you noted, the Xilinx DRM driver in Xilinx tree is missing many mainline > > features including the atomic mode setting and

Re: [PATCH] drm/gma500: remove an unneeded NULL check

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 03:41:01PM +0300, Dan Carpenter wrote: > "connector" is the list iterator and it can't be NULL. It causes a > static checker warning because we dereference the iterator to get the > next item in the list. Let's remove this check. > > Signed-off-by: Dan Carpenter

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
On Wed, Jun 28, 2017 at 05:00:20PM +0100, Chris Wilson wrote: > Quoting Sean Paul (2017-06-28 16:51:11) > > Protect against long-running processes from overflowing the timeline > > and creating fences that go back in time. While we're at it, avoid > > overflowing while we're incrementing the

[Bug 101384] [Hero Siege] si_shader: segfault in libLLVM-5.0.so.1

2017-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101384 --- Comment #10 from Christian Lanig --- Sorry that it took so long. I have been able to compile Mesa from git and noticed that the patch has already been applied. Unfortunately Hero Siege still doesn't run without

Re: [PATCH] drm/fb-helper: Support deferred setup

2017-06-28 Thread Liviu Dudau
On Wed, Jun 28, 2017 at 01:32:01PM +0200, Daniel Vetter wrote: > FB helper code falls back to a 1024x768 mode if no outputs are connected > or don't report back any modes upon initialization. This can be annoying > because outputs that are added to FB helper later on can't be used with > FB helper

Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 5:08 PM, Steven Rostedt wrote: > On Wed, 28 Jun 2017 12:36:35 +0200 > Daniel Vetter wrote: > >> There's a bunch of folks who're trying to make printk less >> contended and faster, but there's a problem: printk uses the >>

RE: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Deucher, Alexander
> -Original Message- > From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] > Sent: Wednesday, June 28, 2017 10:22 AM > To: Deucher, Alexander; Koenig, Christian; David Airlie > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org >

[PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Sean Paul
Protect against long-running processes from overflowing the timeline and creating fences that go back in time. While we're at it, avoid overflowing while we're incrementing the timeline. Signed-off-by: Sean Paul --- drivers/dma-buf/sw_sync.c | 7 ++- 1 file changed, 6

Re: [PATCH] dma-buf/sw_sync: Fix timeline/pt overflow cases

2017-06-28 Thread Chris Wilson
Quoting Sean Paul (2017-06-28 16:51:11) > Protect against long-running processes from overflowing the timeline > and creating fences that go back in time. While we're at it, avoid > overflowing while we're incrementing the timeline. > > Signed-off-by: Sean Paul > --- >

Re: xilinx_drm and atomic modesetting

2017-06-28 Thread Jean-Francois Dagenais
Hi Hyun, > On Jun 27, 2017, at 20:53, Hyun Kwon wrote: > > > As you noted, the Xilinx DRM driver in Xilinx tree is missing many mainline > features including the atomic mode setting and needs some restructuring. > Please feel free to send patches to Xilinx git-dev, but

Re: [PATCH 1/8] drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data

2017-06-28 Thread Mark Brown
On Fri, Jun 23, 2017 at 01:05:37PM -0400, Alex Deucher wrote: > On Fri, Jun 23, 2017 at 12:43 PM, Christian König > > Have the painkillers jellyfied my brain or are you setting a pointer in the > > amdgpu device structure to some variable on the stack? > > If it's just for initialization then

  1   2   >