Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-10-08 Thread David Miller
From: Ville Syrjälä Date: Fri, 24 Aug 2018 14:58:52 +0300 > But yeah, given the V2CLK thing /5 seems like a perfectly good > value to use here. Patch applied. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[Bug 108272] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 --- Comment #1 from jamespharve...@gmail.com --- Created attachment 141932 --> https://bugs.freedesktop.org/attachment.cgi?id=141932=edit glxinfo output -- You are receiving this mail because: You are the assignee for the

[Bug 108272] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 Bug ID: 108272 Summary: opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580 Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: All

Re: [PATCH 2/3] mach64: fix image corruption due to reading accelerator registers

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/27/2018 02:55 PM, Ville Syrjälä wrote: > On Sat, Aug 25, 2018 at 03:51:52PM -0400, Mikulas Patocka wrote: >> Reading the registers without waiting for engine idle returns >> unpredictable values. These unpredictable values result in display >> corruption - if atyfb_imageblit reads the

Re: [PATCH 3/3] mach64: optimize wait_for_fifo

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/27/2018 02:55 PM, Ville Syrjälä wrote: > On Sat, Aug 25, 2018 at 03:54:17PM -0400, Mikulas Patocka wrote: >> This is a simple optimization for fifo waiting that improves scrolling >> performance by 5%. If the queue has more free entries that what we >> consume, we can skip the costly

[PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-08 Thread Linus Walleij
The Samsung S6D16D0 is a simple comman mode only DSI display that is used on the ST-Ericsson Ux500 reference design TVK1281618 user interface board (UIB). Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile| 1

[PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0

2018-10-08 Thread Linus Walleij
This adds the device tree bindings for the Samsung S6D16D0 panel. This is a command mode only panel using DSI. Signed-off-by: Linus Walleij --- .../display/panel/samsung,s6d16d0.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644

Re: [PATCH v2 01/29] dt-bindings: bus: add H6 DE3 bus binding

2018-10-08 Thread Maxime Ripard
On Sun, Oct 07, 2018 at 11:38:37AM +0200, Jernej Skrabec wrote: > From: Icenowy Zheng > > The Allwinner H6 DE3 bus is similar to the A64 DE2 one. > > Add its compatible string with the A64 string as fallback to the > binding. > > Some description of the binding is modified to make it more

Re: [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Maxime Ripard
On Sun, Oct 07, 2018 at 11:39:01AM +0200, Jernej Skrabec wrote: > From: Icenowy Zheng > > Some SoCs, such as H6, doesn't have a full-featured TCON TOP. > > Add quirks support for TCON TOP. > > Currently the presence of TCON_TV1 and DSI is controlled via the quirks > structure. > >

[PATCH 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2018-10-08 Thread Sravanthi Kollukuduru
The interconnect framework is designed to provide a standard kernel interface to control the settings of the interconnects on a SoC. The interconnect API uses a consumer/provider-based model, where the providers are the interconnect buses and the consumers could be various drivers. MDSS is one

[PATCH 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

2018-10-08 Thread Sravanthi Kollukuduru
Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Signed-off-by: Sravanthi Kollukuduru --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c| 157 ++-

[PATCH 3/3] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2018-10-08 Thread Sravanthi Kollukuduru
Add interconnect properties such as interconnect provider specifier , the edge source and destination ports which are required by the interconnect API to configure interconnect path for MDSS. Signed-off-by: Sravanthi Kollukuduru --- Documentation/devicetree/bindings/display/msm/dpu.txt | 8

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-08 Thread Alexandru-Cosmin Gheorghe
Hi Daniel, Thanks for having a look. On Fri, Oct 05, 2018 at 04:51:48PM +0200, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 09:26:47AM +, Alexandru-Cosmin Gheorghe wrote: > > For some pixel formats .cpp structure in drm_format info it's not > > enough to describe the peculiarities of the

[Bug 108262] Unable to open intel_gpu_top (sudo): Test assertion failure function init_instdone_definitions, file instdone.c:599

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108262 Petri Latvala changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/19/2018 12:36 PM, Ville Syrjälä wrote: > On Fri, Aug 17, 2018 at 03:19:37PM -0400, Mikulas Patocka wrote: >> On Sun Ultra 5, it happens that the dot clock is not set up properly for >> some videomodes. For example, if we set the videomode "r1024x768x60" in >> the firmware, Linux would

Re: [PATCH] fbdev: Convert to using %pOFn instead of device_node.name

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/28/2018 03:52 AM, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org >

Re: [PATCH 1/2] fbdev: sbuslib: use checked version of put_user()

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/31/2018 10:09 AM, Dan Carpenter wrote: > I'm not sure why the code assumes that only the first put_user() needs > an access_ok() check. I have made all the put_user() and get_user() > calls checked. > > Signed-off-by: Dan Carpenter Patch queued for 4.20, thanks. Best regards, --

Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/25/2018 08:23 PM, Sam Ravnborg wrote: > When a device tree set a display-timing using native-mode > then according to the bindings doc this should: > > native-mode: > The native mode for the display, in case multiple > modes are provided. > When omitted, assume the first

Re: [PATCH v3 0/6] Add method to describe tile/bit_level_packed formats

2018-10-08 Thread Alexandru-Cosmin Gheorghe
On Fri, Oct 05, 2018 at 04:58:38PM +0200, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 09:26:43AM +, Alexandru-Cosmin Gheorghe wrote: > > There has been some discussion about extending drm core to handle > > linear tile formats, in the series sent by me here [1] and how to > > handle formats

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-08 Thread Michel Dänzer
On 2018-10-05 7:48 p.m., Kazlauskas, Nicholas wrote: > On 10/05/2018 12:56 PM, Michel Dänzer wrote: >> On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: >>> On 10/05/2018 04:10 AM, Pekka Paalanen wrote: I also believe that it would be useful to expose vmin/vmax to userspace as

[PATCH -next] drm/vmwgfx: Remove set but not used variable 'file_priv'

2018-10-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/vmwgfx/vmwgfx_fence.c: In function 'vmw_event_fence_action_seq_passed': drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:909:19: warning: variable 'file_priv' set but not used [-Wunused-but-set-variable] struct drm_file *file_priv; It not

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Souptick Joarder
On Fri, Oct 5, 2018 at 4:19 PM Miguel Ojeda wrote: > > Hi Souptick, > > On Fri, Oct 5, 2018 at 12:01 PM Souptick Joarder wrote: > > > > The final goal is to remove vm_insert_page by converting it to > > vmf_insert_page. But to do that we have to first introduce the > > new API which is similar

[PATCH v2 00/29] Allwinner H6 DE3 and HDMI support

2018-10-08 Thread Jernej Skrabec
This series adds support for Display Engine 3.0 and HDMI 2.0a, which can be found on H6 SoC. Display Engine 3.0 in comparison to 2.0 mostly adds features needed for displaying and processing 10-bit and AFBC formats, which are not yet supported by this series. This series is based on linux-next

[PATCH v2 29/29] arm64: dts: allwinner: h6: Enable HDMI output on Pine H64 board

2018-10-08 Thread Jernej Skrabec
Pine H64 board has HDMI type A connector. Signed-off-by: Jernej Skrabec --- .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 25 +++ 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts

Re: [PATCH 12/27] drm/sun4i: Add basic support for DE3

2018-10-08 Thread Jernej Škrabec
Dne sobota, 22. september 2018 ob 15:19:12 CEST je Chen-Yu Tsai napisal(a): > On Sun, Sep 2, 2018 at 3:27 PM Jernej Skrabec wrote: > > Display Engine 3 is an upgrade of DE2 with new features like support for > > 10 bit color formats and support for AFBC. > > > > Most of DE2 code works with DE3,

[PATCH v2 03/29] clk: sunxi-ng: Use u64 for calculation of NM rate

2018-10-08 Thread Jernej Skrabec
Allwinner H6 SoC has multiplier N range between 1 and 254. Since parent rate is 24MHz, intermediate result when calculating final rate easily overflows 32 bit variable. Because of that, introduce function for calculating clock rate which uses 64 bit variable for intermediate result. Fixes:

[PATCH v2 13/29] drm/sun4i: Add basic support for DE3

2018-10-08 Thread Jernej Skrabec
Display Engine 3 is an upgrade of DE2 with new features like support for 10 bit color formats and support for AFBC. Most of DE2 code works with DE3, except some small details. Implement basic support for DE3. Support for 10 bit colort formats and AFBC, among others missing features, will be

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Souptick Joarder
On Fri, Oct 5, 2018 at 2:22 PM Miguel Ojeda wrote: > > Hi Souptick, > > On Fri, Oct 5, 2018 at 7:51 AM Souptick Joarder wrote: > > > > On Fri, Oct 5, 2018 at 1:16 AM Miguel Ojeda > > wrote: > > > > > > > > > Also, not sure if you saw my comments/review: if the interface is not > > > going to

Re: [Intel-gfx] [PATCH] dim: Add range-diff convenience wrapper

2018-10-08 Thread Lucas De Marchi
On Thu, Oct 4, 2018 at 4:00 AM Daniel Vetter wrote: > > range-diff is awesome, but the interface is a bit silly. Add a bunch > of shortcuts, inspired by what git diff does. > > v2: Add it to the developer commmands list. With this dim range-diff > is useable on any git repo, not just a dim

[PATCH v2 18/29] drm/sun4i: dw-hdmi: Add quirk for setting TMDS clock

2018-10-08 Thread Jernej Skrabec
It turns out that H6 HDMI BSP kernel driver doesn't change TMDS rate at all. At this point it is not clear whether it is just not necessary or it would cause some kind of issues. Add a quirk for it. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec ---

[PATCH v2 26/29] dt-bindings: display: sun4i-drm: document H6 TCON TOP

2018-10-08 Thread Jernej Skrabec
From: Icenowy Zheng Allwinner H6 SoC has a cut down version of TCON TOP. Add binding documentation for it. Reviewed-by: Rob Herring Signed-off-by: Icenowy Zheng [expanded description] Signed-off-by: Jernej Skrabec --- .../bindings/display/sunxi/sun4i-drm.txt | 14 --

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Miguel Ojeda
On Sat, Oct 6, 2018 at 7:11 AM Souptick Joarder wrote: > > On Fri, Oct 5, 2018 at 11:39 PM Miguel Ojeda > wrote: > > They are not supposed to be "steps". You did it with 70+ commits (!!) > > over the course of several months. Why a tree wasn't created, stuff > > developed there, and when done,

[PATCH v2 17/29] drm/sun4i: dw-hdmi: Make mode_valid function configurable

2018-10-08 Thread Jernej Skrabec
Since it is not possible to access sun8i-dw-hdmi driver private data inside mode_valid function, make it configurable. That way different versions of HDMI controllers can set different function, depending on it's limitations. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec ---

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Souptick Joarder
On Fri, Oct 5, 2018 at 11:39 PM Miguel Ojeda wrote: > > On Fri, Oct 5, 2018 at 2:11 PM Souptick Joarder wrote: > > > > On Fri, Oct 5, 2018 at 4:19 PM Miguel Ojeda > > wrote: > > > > > > 1. Introduce the vmf_* API > > > 2. Change all PF-users users to that (leaving all non-PF ones > > >

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Miguel Ojeda
Hi Souptick, On Fri, Oct 5, 2018 at 7:51 AM Souptick Joarder wrote: > > On Fri, Oct 5, 2018 at 1:16 AM Miguel Ojeda > wrote: > > > > > > Also, not sure if you saw my comments/review: if the interface is not > > going to change, why the name change? Why can't we simply keep using > >

[PATCH v2 08/29] drm/sun4i: Add compatible for H6 display engine

2018-10-08 Thread Jernej Skrabec
H6 is first Allwinner SoC which supports 10 bit colors, HDR and AFBC. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 1e41c3f5fd6d..1ca7b70cbbfa

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Miguel Ojeda
Hi Souptick, On Fri, Oct 5, 2018 at 12:01 PM Souptick Joarder wrote: > > The final goal is to remove vm_insert_page by converting it to > vmf_insert_page. But to do that we have to first introduce the > new API which is similar to vm_insert_page (for non #PF). I tried this by > introducing

[PATCH v2 23/29] drm/sun4i: Add support for H6 HDMI PHY

2018-10-08 Thread Jernej Skrabec
H6 has Synopsys DWC HDMI 2.0 TX PHY. There is no freely available documentation for it, only code found in BSP kernel. However, judging by the code, PHY is very similar to older Synopsys HDMI PHY described in i.MX6 documentation. Most registers seem to be the same. According to i.MX6

[PATCH v2 14/29] drm/sun4i: Add support for H6 DE3 mixer 0

2018-10-08 Thread Jernej Skrabec
Mixer 0 has 1 VI and 3 UI planes, scaler on all planes and can output 4K image @60Hz. It also support 10 bit colors, which are not yet implemented. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 13 + 1 file changed, 13

[PATCH v2 02/29] clk: sunxi-ng: Adjust MP clock parent rate when allowed

2018-10-08 Thread Jernej Skrabec
Currently MP clocks don't consider adjusting parent rate even if they are allowed to do so. Such behaviour considerably lowers amount of possible rates, which is very inconvenient when such clock is used for pixel clock, for example. In order to improve the situation, adjusting parent rate is

[PATCH v2 27/29] drm: sun4i: add support for H6 TCON TOP

2018-10-08 Thread Jernej Skrabec
From: Icenowy Zheng The TCON TOP on Allwinner H6 SoC is a cut down version of the R40 TCON TOP, which dropped TCON_TV1 and DSI (which do not exist on H6). Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 8 1 file changed, 8 insertions(+)

[PATCH v2 24/29] drm/sun4i: Initialize registers in tcon-top driver

2018-10-08 Thread Jernej Skrabec
It turns out that TCON TOP registers in H6 SoC have non-zero reset value. This may cause issues if bits are not changed during configuration. To prevent that, initialize registers to 0. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 7 +++ 1 file changed, 7

[PATCH v2 05/29] dt-bindings: clock: sun8i-de2: Add H6 DE3 clock description

2018-10-08 Thread Jernej Skrabec
This commit adds necessary description and dt includes for H6 DE3 clock. It is very similar to others, but memory region has some additional registers not found in DE2. Reviewed-by: Rob Herring Signed-off-by: Jernej Skrabec --- Documentation/devicetree/bindings/clock/sun8i-de2.txt | 5 +++--

[PATCH v2 20/29] drm/sun4i: Add support for H6 DW HDMI controller

2018-10-08 Thread Jernej Skrabec
H6 has DW HDMI 2.0b controller v2.12a. It supports 4K at 60 Hz and HDCP 2.2. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c

[PATCH v2 28/29] arm64: dts: allwinner: h6: Add HDMI pipeline

2018-10-08 Thread Jernej Skrabec
This commit adds all entries needed for HDMI to function properly. Signed-off-by: Jernej Skrabec [added DE3 bus] Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 201 +++ 1 file changed, 201 insertions(+) diff --git

[PATCH v2 21/29] drm/sun4i: dw-hdmi-phy: Reorder quirks by family

2018-10-08 Thread Jernej Skrabec
Currently, quirks and compatibles are sorted alphabetically. However, they should be sorted by family release date and then alphabetically. Fix that by moving A64 quirks and compatible to bottom. No functional change is made. Signed-off-by: Jernej Skrabec ---

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Christian König
Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:   In function ‘gmc_v8_0_process_interrupt’:

[Bug 108272] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 --- Comment #3 from jamespharve...@gmail.com --- Created attachment 141934 --> https://bugs.freedesktop.org/attachment.cgi?id=141934=edit gdb backtrace of luxmark with opencl-mesa 18.2.2 Arch binary (not debug, no symbols) -- You are

[Bug 108272] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 --- Comment #2 from jamespharve...@gmail.com --- Created attachment 141933 --> https://bugs.freedesktop.org/attachment.cgi?id=141933=edit gdb backtrace of luxmark with opencl-mesa 18.2.2 in debug mode -- You are receiving this mail because:

[Bug 108272] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 --- Comment #4 from jamespharve...@gmail.com --- Created attachment 141935 --> https://bugs.freedesktop.org/attachment.cgi?id=141935=edit gdb backtrace of IndigoBenchmark -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 1/3] mach64: fix display corruption on big endian machines

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/27/2018 02:54 PM, Ville Syrjälä wrote: > On Sat, Aug 25, 2018 at 03:51:00PM -0400, Mikulas Patocka wrote: >> The code for manual bit triple is not endian-clean. It builds the variable >> "hostdword" using byte accesses, therefore we must read the variable with >> "le32_to_cpu". >> >> The

[PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a

2018-10-08 Thread Jernej Skrabec
It turns out that even new DW HDMI controllers exhibits same magenta line issues as older versions. Enable workaround for v2.12a. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 22/29] drm/sun4i: Add support for Synopsys HDMI PHY

2018-10-08 Thread Jernej Skrabec
Currently sun8i-hdmi-phy driver supports only custom PHYs connected to DW HDMI controller. Since newest Allwinner SoCs have unmodified Synopsys PHY, driver has to be reorganized to support them. Variant structure is expanded to allow differentiation between custom and Sysnopsys PHYs and to hold

[PATCH -next] drm/omap: remove set but not used variable 'plane'

2018-10-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/omapdrm/omap_fb.c: In function 'omap_framebuffer_update_scanout': drivers/gpu/drm/omapdrm/omap_fb.c:130:16: warning: variable 'plane' set but not used [-Wunused-but-set-variable] struct plane *plane = _fb->planes[0]; After

[PATCH -next] drm/msm/dpu: remove duplicated include from dpu_hw_lm.c

2018-10-08 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c index acb8dc8..5d5dea8 100644 ---

[PATCH v2 06/29] clk: sunxi-ng: Add support for H6 DE3 clocks

2018-10-08 Thread Jernej Skrabec
Support for mixer0, mixer1, writeback and rotation units is added. Signed-off-by: Jernej Skrabec Signed-off-by: Icenowy Zheng --- drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 71 ++-- drivers/clk/sunxi-ng/ccu-sun8i-de2.h | 4 +- 2 files changed, 71 insertions(+), 4

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function ‘gmc_v8_0_process_interrupt’: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10:

Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page

2018-10-08 Thread Miguel Ojeda
On Fri, Oct 5, 2018 at 2:11 PM Souptick Joarder wrote: > > On Fri, Oct 5, 2018 at 4:19 PM Miguel Ojeda > wrote: > > > > 1. Introduce the vmf_* API > > 2. Change all PF-users users to that (leaving all non-PF ones > > untouched!) -- if this is too big, you can split this patch into > >

[PATCH v2 19/29] dt-bindings: display: sunxi: add DT binding for Allwinner H6 DW HDMI

2018-10-08 Thread Jernej Skrabec
From: Icenowy Zheng The Allwinner H6 SoC uses a v2.12a DesignWare HDMI controller, with dedicated CEC and HDCP clocks added; the PHY connected is a standard DesignWare HDMI PHY. Add binding for it. Reviewed-by: Rob Herring Signed-off-by: Icenowy Zheng [added HDCP clock and reset]

[PATCH v2 01/29] dt-bindings: bus: add H6 DE3 bus binding

2018-10-08 Thread Jernej Skrabec
From: Icenowy Zheng The Allwinner H6 DE3 bus is similar to the A64 DE2 one. Add its compatible string with the A64 string as fallback to the binding. Some description of the binding is modified to make it more generic. Reviewed-by: Rob Herring Signed-off-by: Icenowy Zheng ---

Re: [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Chen-Yu Tsai
On Mon, Oct 8, 2018 at 4:51 PM Maxime Ripard wrote: > > On Sun, Oct 07, 2018 at 11:39:01AM +0200, Jernej Skrabec wrote: > > From: Icenowy Zheng > > > > Some SoCs, such as H6, doesn't have a full-featured TCON TOP. > > > > Add quirks support for TCON TOP. > > > > Currently the presence of

Re: [PATCH] atyfb: fix debugging printks

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/17/2018 09:26 PM, Mikulas Patocka wrote: > This patch fixes the debugging printks. Use pr_cont, so that the lines are > not broken up. Use printk when starting a new line (a long string of > pr_cont's without any printks causes missing characters in the console > output on sparc). > >

Re: [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Chen-Yu Tsai
On Mon, Oct 8, 2018 at 6:20 PM Maxime Ripard wrote: > > On Mon, Oct 08, 2018 at 05:06:45PM +0800, Chen-Yu Tsai wrote: > > On Mon, Oct 8, 2018 at 4:51 PM Maxime Ripard > > wrote: > > > > > > On Sun, Oct 07, 2018 at 11:39:01AM +0200, Jernej Skrabec wrote: > > > > From: Icenowy Zheng > > > > > >

Re: [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 09/20/2018 10:22 PM, Nathan Chancellor wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] > } else

Re: [PATCH] mach64: detect the dot clock divider correctly on sparc

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 10/08/2018 07:56 AM, David Miller wrote: > From: Ville Syrjälä > Date: Fri, 24 Aug 2018 14:58:52 +0300 > >> But yeah, given the V2CLK thing /5 seems like a perfectly good >> value to use here. > > Patch applied. Fine with me if you also need it in sparc tree. Best regards, -- Bartlomiej

Re: [PATCH] fbdev: fix broken menu dependencies

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 09/23/2018 12:43 AM, Randy Dunlap wrote: > From: Randy Dunlap > > The framebuffer options and devices menu is unintentionally split > or broken because some items in it do not depend on FB (including > several under omap and mmp). > Fix this by moving FB_CMDLINE, FB_NOTIFY, and

Re: [linux-sunxi] [PATCH v2 00/29] Allwinner H6 DE3 and HDMI support

2018-10-08 Thread Jernej Škrabec
Dne nedelja, 07. oktober 2018 ob 11:38:36 CEST je Jernej Skrabec napisal(a): > This series adds support for Display Engine 3.0 and HDMI 2.0a, which > can be found on H6 SoC. > > Display Engine 3.0 in comparison to 2.0 mostly adds features needed for > displaying and processing 10-bit and AFBC

[PATCH v2 09/29] drm/sun4i: Rework DE2 register defines

2018-10-08 Thread Jernej Skrabec
Most, if not all, registers found in DE2 still exists in DE3. However, units are on different base addresses. To prepare for addition of DE3 support, registers macros are reworked so they take base address as parameter. Signed-off-by: Jernej Skrabec [rebased] Signed-off-by: Icenowy Zheng ---

Re: [PATCH v2 18/29] drm/sun4i: dw-hdmi: Add quirk for setting TMDS clock

2018-10-08 Thread Maxime Ripard
Hi, On Sun, Oct 07, 2018 at 11:38:54AM +0200, Jernej Skrabec wrote: > It turns out that H6 HDMI BSP kernel driver doesn't change TMDS rate at > all. At this point it is not clear whether it is just not necessary or > it would cause some kind of issues. > > Add a quirk for it. > > Reviewed-by:

[PATCH 0/3] Use interconnect API in MDSS on SDM845

2018-10-08 Thread Sravanthi Kollukuduru
The interconnect API provides an interface for consumer drivers to express their bandwidth needs in the SoC. This data is aggregated and the on-chip interconnect hardware is configured to the appropriate power/performance profile. MDSS is one of the interconnect consumers which uses the

Re: [PATCH] udlfb: handle unplug properly

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 07/30/2018 12:32 PM, Mikulas Patocka wrote: > The udlfb driver maintained an open count and cleaned up itself when the > count reached zero. But the console is also counted in the reference count > - so, if the user unplugged the device, the open count would not drop to > zero and the driver

Re: [PATCH] video: fbdev: add the dependency of broadsheetfb in Kconfig

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 07/27/2018 10:12 AM, Jia-Ju Bai wrote: > broadsheetfb is a platform driver and it should not be used on x86. > It should be used only by single ARM PXA board, so adding the > dependency in Kconfig. > > Signed-off-by: Jia-Ju Bai Patch queued for 4.20, thanks. Best regards, -- Bartlomiej

Re: [PATCH v2 10/29] drm/sun4i: Rename DE2 registers related macros

2018-10-08 Thread Maxime Ripard
Hi, On Sun, Oct 07, 2018 at 11:38:46AM +0200, Jernej Skrabec wrote: > In preparation to introduce DE3 support, change prefix from "SUN8I_" to > "DE2_". Current prefix suggest that it's valid only for one family, > whereas in reality, DE2 unit is used also on sun50i family. > Additionally, it will

Re: [PATCH v4] video: fbdev: omapfb: lcd_ams_delta: use GPIO lookup table

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 10/03/2018 03:03 PM, Janusz Krzysztofik wrote: > Now as Amstrad Delta board - the only user of this driver - provides > GPIO lookup tables, switch from GPIO numbers to GPIO descriptors and > use the table to locate required GPIO pins. > > Declare static variables for storing GPIO descriptors

Re: [PATCH 2/2] fbdev: sbuslib: integer overflow in sbusfb_ioctl_helper()

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 08/31/2018 10:09 AM, Dan Carpenter wrote: > The "index + count" addition can overflow. Both come directly from the > user. This bug leads to an information leak. > > Signed-off-by: Dan Carpenter Patch queued for 4.20, thanks. > --- > Btw, commit 250c6c49e3b6 ("fbdev: Fixing arbitrary

[PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0

2018-10-08 Thread Linus Walleij
This adds the device tree bindings for the Samsung S6D16D0 panel. This is a command mode only panel using DSI. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../display/panel/samsung,s6d16d0.txt | 30 +++ 1 file changed, 30 insertions(+) create mode

[PATCH v2 04/29] clk: sunxi-ng: h6: Set video PLLs limits

2018-10-08 Thread Jernej Skrabec
Video PLL factors can be set in a way that final PLL rate is outside stable range. H6 user manual specifically says that N factor should not be below 12. While it doesn't says anything about maximum stable rate, it is clear that PLL doesn't work at 6.096 GHz (254 * 24 MHz). Set minimum allowed

[PATCH v2 10/29] drm/sun4i: Rename DE2 registers related macros

2018-10-08 Thread Jernej Skrabec
In preparation to introduce DE3 support, change prefix from "SUN8I_" to "DE2_". Current prefix suggest that it's valid only for one family, whereas in reality, DE2 unit is used also on sun50i family. Additionally, it will be easier to distinguish DE3 specific macros by using "DE3_" prefix. No

[PATCH v2 12/29] drm/sun4i: Disable unused DE2 sub-engines

2018-10-08 Thread Jernej Skrabec
Some sub-engines are unused. Disable them explicitly. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 8 drivers/gpu/drm/sun4i/sun8i_mixer.h | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c

[PATCH -next] drm/arm/malidp: remove set but not used variable 'afbc_superblock_size'

2018-10-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/arm/malidp_drv.c: In function 'malidp_verify_afbc_framebuffer_size': drivers/gpu/drm/arm/malidp_drv.c:318:6: warning: variable 'afbc_superblock_size' set but not used [-Wunused-but-set-variable] u32 afbc_superblock_size = 0,

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-10-08 Thread Bjorn Andersson
On Wed 12 Sep 08:08 PDT 2018, Arnd Bergmann wrote: [..] > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index a76b963a7e50..02aefb2b2d47 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -285,7 +285,7 @@ static const struct file_operations

[PATCH v2 07/29] dt-bindings: display: sun4i-drm: Add H6 display engine compatibles

2018-10-08 Thread Jernej Skrabec
This commit adds compatibles used in H6 display pipeline, namely for display engine, mixer and TV TCON. H6 display engine is somewhat similar to R40, just less TCONs and mixer support more features. Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec ---

[PATCH v2 16/29] drm/sun4i: Not all DW HDMI controllers has scrambled addresses

2018-10-08 Thread Jernej Skrabec
Currently supported Allwinner SoCs with DW HDMI controller have scrambled addresses and read lock. However, that is not true in general. For example, A80 and H6 have normal addresses and normal read access. Move code for unscrambling addresses and unlocking read access to it's own function and

[PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Jernej Skrabec
From: Icenowy Zheng Some SoCs, such as H6, doesn't have a full-featured TCON TOP. Add quirks support for TCON TOP. Currently the presence of TCON_TV1 and DSI is controlled via the quirks structure. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 43

[PATCH v2 11/29] drm/sun4i: Fix DE2 mixer size

2018-10-08 Thread Jernej Skrabec
DE2 mixer is always 0x6000 bytes in size on all known SoCs. While at it, introduce a macro for that. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- drivers/gpu/drm/sun4i/sun8i_mixer.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 12/21] drm/sti: Use drm_atomic_helper_shutdown

2018-10-08 Thread Benjamin Gaignard
Le ven. 5 oct. 2018 à 16:25, Daniel Vetter a écrit : > > On Fri, Oct 5, 2018 at 12:14 PM Benjamin Gaignard > wrote: > > > > From: Daniel Vetter > > > > drm_plane_helper_disable is a non-atomic drivers only function, and > > will blow up (since no one passes the locking context it needs). > > >

Re: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-08 Thread Maxime Ripard
On Fri, Oct 05, 2018 at 11:59:51PM +0200, Giulio Benetti wrote: > If tcon->panel pointer is NULL, trying to dereference from it > (i.e. tcon->panel->connector) will cause a null pointer dereference. > > Add tcon->panel null pointer check before calling > sun4i_tcon0_mode_set_dithering(). > >

[Bug 108262] Unable to open intel_gpu_top (sudo): Test assertion failure function init_instdone_definitions, file instdone.c:599

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108262 Petri Latvala changed: What|Removed |Added Component|DRM/Intel |IGT QA

Re: [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Maxime Ripard
On Mon, Oct 08, 2018 at 05:06:45PM +0800, Chen-Yu Tsai wrote: > On Mon, Oct 8, 2018 at 4:51 PM Maxime Ripard > wrote: > > > > On Sun, Oct 07, 2018 at 11:39:01AM +0200, Jernej Skrabec wrote: > > > From: Icenowy Zheng > > > > > > Some SoCs, such as H6, doesn't have a full-featured TCON TOP. > > >

Re: [PATCH] video: fbdev: arcfb: mark expected switch fall-through

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 10/03/2018 01:50 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 115017 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.20, thanks.

Re: [PATCH -next] pxa168fb: remove set but not used variables 'mi'

2018-10-08 Thread Bartlomiej Zolnierkiewicz
On 09/28/2018 04:16 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/pxa168fb.c: In function 'pxa168fb_set_par': > drivers/video/fbdev/pxa168fb.c:408:29: warning: > variable 'mi' set but not used [-Wunused-but-set-variable] > > Signed-off-by:

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Tomi Valkeinen
On 08/10/18 15:55, Hans Verkuil wrote: > On 10/08/2018 02:45 PM, Tomi Valkeinen wrote: >> Hi Hans, >> >> On 04/10/18 12:08, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> The TX FIFO has to be cleared if the transmit failed due to e.g. >>> a NACK condition, otherwise the hardware will keep

Re: [PATCH 1/4] drm/v3d: Fix a use-after-free race accessing the scheduler's fences.

2018-10-08 Thread Boris Brezillon
On Fri, 28 Sep 2018 16:21:23 -0700 Eric Anholt wrote: > Once we push the job, the scheduler could run it and free it. So, if > we want to reference their fences, we need to grab them before then. > I haven't seen this happen in many days of conformance test runtime, > but let's still close the

Re: [v2 4/7] drm/msm/adreno: Add registers in the GPU CX domain

2018-10-08 Thread Sharat Masetty
On 10/5/2018 8:31 PM, Jordan Crouse wrote: On Fri, Oct 05, 2018 at 06:38:32PM +0530, Sharat Masetty wrote: Add the registers needed for configuring the system cache slice info and other parameters in the GPU. This would conflict with msm-next or at least with the latest update from the

[PATCH] omapdrm/dss/hdmi4_cec.c: simplify clear_tx/rx_fifo functions

2018-10-08 Thread Hans Verkuil
Use REG_GET to avoid the temp variable. Add pr_err_once if hdmi_cec_clear_tx_fifo() fails in hdmi4_cec_irq(). Signed-off-by: Hans Verkuil --- Note: the FIFOs are cleared almost immediately (after just one try), so adding delays is overkill. --- diff --git

Re: [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP

2018-10-08 Thread Maxime Ripard
On Mon, Oct 08, 2018 at 06:50:44PM +0800, Chen-Yu Tsai wrote: > On Mon, Oct 8, 2018 at 6:20 PM Maxime Ripard > wrote: > > > > On Mon, Oct 08, 2018 at 05:06:45PM +0800, Chen-Yu Tsai wrote: > > > On Mon, Oct 8, 2018 at 4:51 PM Maxime Ripard > > > wrote: > > > > > > > > On Sun, Oct 07, 2018 at

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Tomi Valkeinen
On 05/10/18 17:13, Hans Verkuil wrote: > Tomi, > > Can you review this patch and the next? They should go to 4.20. > This patch in particular is a nasty one, hard to reproduce. > > This patch should also be Cc-ed to stable for 4.15 and up. Done. There's no dependency from the omapdrm patches

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:45 PM, Tomi Valkeinen wrote: > Hi Hans, > > On 04/10/18 12:08, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The TX FIFO has to be cleared if the transmit failed due to e.g. >> a NACK condition, otherwise the hardware will keep trying to >> transmit the message. >> >> An

[Bug 108260] [Regression?] [powerplay] Failed to retrieve minimum clocks. 4.19-rc6+

2018-10-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108260 --- Comment #1 from taij...@posteo.de --- I just checked: This problem remains with 4.19-rc7 but does not exist with 4.18.12. Also: # lspci -tvv -[:00]-+-00.0 Intel Corporation Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 15:33 schrieb Guenter Roeck: > On 10/08/2018 01:00 AM, Christian König wrote: >> Am 05.10.2018 um 10:38 schrieb Guenter Roeck: >>> On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: > Hi, > > On Fri, Sep 14, 2018 at

  1   2   3   >