Re: [Intel-gfx] [PATCH] drm/i915/fence: Do not use TIMER_IRQSAFE

2019-02-28 Thread Chris Wilson
Quoting Thomas Gleixner (2019-02-28 10:09:26) > On Thu, 28 Feb 2019, Chris Wilson wrote: > > > Quoting Sebastian Andrzej Siewior (2019-02-26 16:00:38) > > > On 2019-02-12 17:28:57 [+0100], To linux-ker...@vger.kernel.org wrote: > > > > The timer is initialized with TIMER_IRQSAFE flag. It does

Re: [PATCH v3 41/50] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2019-02-28 Thread Tomi Valkeinen
Hi Laurent, On 11/02/2019 11:46, Laurent Pinchart wrote: > + /* Get the sampling edge from the endpoint. */ > + of_property_read_u32(ep, "pclk-sample", _sample); > + of_node_put(ep); > + > + timings->input_bus_flags = DRM_BUS_FLAG_DE_HIGH; > + > + switch (pclk_sample) { > +

Re: [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-28 Thread Hans de Goede
Hi, On 28-02-19 10:15, Heikki Krogerus wrote: On Wed, Feb 27, 2019 at 04:45:32PM +0100, Hans de Goede wrote: Hi, On 27-02-19 12:16, Jani Nikula wrote: On Wed, 27 Feb 2019, Heikki Krogerus wrote: One thing that this series does not consider is the DP lane count problem. The GPU drivers

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Ville Syrjälä
On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > vkms_crc_work_handle needs the value of the actual frame to > > schedule the workqueue that calls periodically the vblank > > handler and the destroy state

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > I merged some fixes into drm-fixes, pushed it out, then saw tip > breaking, but I'm needed elsewhere, so if anyone can fix tip up or > tell me why I got a super messy commit, I'll owe you. Chris already patched it up it seems, I guess

[tiL4.19-AD PATCH 2/2] drm/tilcdc: Remove obsolete crtc_mode_valid() hack

2019-02-28 Thread Jyri Sarha
Earlier there were no mode_valid() helper for crtc and tilcdc had a hack to over come this limitation. But now the mode_valid() helper is there (has been since v4.13), so it is about time to get rid of that hack. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 28

[tiL4.19-AD PATCH 0/2] drm/tilcdc: a cleanup and a fix

2019-02-28 Thread Jyri Sarha
Jyri Sarha (2): drm/tilcdc: Check drm_fb_cma_get_gem_obj() return value drm/tilcdc: Remove obsolete crtc_mode_valid() hack drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 30 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 - drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 -

[tiL4.19-AD PATCH 1/2] drm/tilcdc: Check drm_fb_cma_get_gem_obj() return value

2019-02-28 Thread Jyri Sarha
drm_fb_cma_get_gem_obj() may return NULL. The return value needs to be checked before dereferencing the returned pointer. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c

Re: [PATCH] xen, fbfront: mark expected switch fall-through

2019-02-28 Thread Oleksandr Andrushchenko
+Xen-devel list On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:

Re: AFBC versions modifiers

2019-02-28 Thread Daniel Vetter
On Wed, Feb 27, 2019 at 03:41:35PM +, Ayan Halder wrote: > Hi Neil, > > AFBC 1.0 does not support (ignoring common prefix AFBC_FORMAT_MOD_) > BLOCK_SIZE_32x8, BLOCK_SIZE_64x4, BLOCK_SIZE_32x8_64x4 > CBR, TILED, SC, DB and BCH modifiers. > > AFBC 1.2 does not support BLOCK_SIZE_64x4,

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-28 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 09:34:09AM +0100, Gerd Hoffmann wrote: > On Fri, Feb 22, 2019 at 06:20:11PM +0100, Daniel Vetter wrote: > > On Fri, Feb 22, 2019 at 12:03 PM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > - /* > > > > > -* WARNING: Apparently we must kick fbdev drivers before

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > vkms_crc_work_handle needs the value of the actual frame to > schedule the workqueue that calls periodically the vblank > handler and the destroy state functions. However, the frame > value returned from vkms_vblank_simulate is

Re: [PATCHv11 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

2019-02-28 Thread Daniel Vetter
On Mon, Feb 11, 2019 at 10:11:10AM +0800, Hean-Loong, Ong wrote: > From: Ong, Hean Loong > > Signed-off-by: Ong, Hean Loong Per-patch changelog is missing here, would be good to include that to help reviewers. I've done a very quick scroll through, looks like a nice driver. Acked-by: Daniel

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-28 09:49:51) > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > I merged some fixes into drm-fixes, pushed it out, then saw tip > > breaking, but I'm needed elsewhere, so if anyone can fix tip up or > > tell me why I got a super messy commit, I'll owe you.

[Bug 109695] qemu using spice gl and sandbox resourcecontrol=deny crashes with SIGSYS on radeonsi

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109695 Timo Aaltonen changed: What|Removed |Added Blocks||109535 CC|

Re: [PATCH 1/2] drm/hibmc: Drop best_encoder

2019-02-28 Thread Noralf Trønnes
Den 21.02.2019 16.58, skrev Daniel Vetter: > This is the default for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Neil Armstrong > Cc: Luc Van Oostenryck > Cc: Rodrigo Vivi > --- Acked-by: Noralf Trønnes >

Re: [PATCH 1/2] drm/hibmc: Drop best_encoder

2019-02-28 Thread Gerd Hoffmann
On Thu, Feb 21, 2019 at 04:58:56PM +0100, Daniel Vetter wrote: > This is the default for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Neil Armstrong > Cc: Luc Van Oostenryck > Cc: Rodrigo Vivi Acked-by: Gerd Hoffmann

[Bug 109695] qemu using spice gl and sandbox resourcecontrol=deny crashes with SIGSYS on radeonsi

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109695 --- Comment #8 from Michel Dänzer --- (In reply to Marek Olšák from comment #7) > An even better solution would be to have a virtual thread affinity that only > the application can see and change, which should be silently masked by >

Re: [PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-28 Thread Gerd Hoffmann
> > > stolen memory is where the fb physically resides. the pci bar is how > > > you access it (as long as you take all the pci bars). From a quick > > > look i915 and pci version of remove_conflicting_fb matched. > > > > Well, it is > > > > ap->ranges[0].base = ggtt->gmadr.start; > >

Re: [PULL] topic/mei-hdcp for char-misc-next

2019-02-28 Thread Greg KH
On Tue, Feb 26, 2019 at 10:17:10PM +0100, Daniel Vetter wrote: > Hi Greg > > topic/mei-hdcp-2019-02-26: > mei-hdcp driver > > mei driver for the me hdcp client, for use by drm/i915. > > Including the following prep work: > - whitelist hdcp client in mei bus > - merge to include char-misc-next

Re: [Intel-gfx] [PULL] topic/mei-hdcp for char-misc-next

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 1:00 PM Greg KH wrote: > > On Tue, Feb 26, 2019 at 10:17:10PM +0100, Daniel Vetter wrote: > > Hi Greg > > > > topic/mei-hdcp-2019-02-26: > > mei-hdcp driver > > > > mei driver for the me hdcp client, for use by drm/i915. > > > > Including the following prep work: > > -

Re: [Intel-gfx] [PATCH] drm/i915/fence: Do not use TIMER_IRQSAFE

2019-02-28 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-02-26 16:00:38) > On 2019-02-12 17:28:57 [+0100], To linux-ker...@vger.kernel.org wrote: > > The timer is initialized with TIMER_IRQSAFE flag. It does look like the > > timer callback requires this flag at all. Its sole purpose is to ensure > >

Re: [PATCH v3 41/50] drm/bridge: ti-tfp410: Report input bus config through bridge timings

2019-02-28 Thread Tomi Valkeinen
On 28/02/2019 12:27, Tomi Valkeinen wrote: > Hi Laurent, > > On 11/02/2019 11:46, Laurent Pinchart wrote: > >> +/* Get the sampling edge from the endpoint. */ >> +of_property_read_u32(ep, "pclk-sample", _sample); >> +of_node_put(ep); >> + >> +timings->input_bus_flags =

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Dan Carpenter
On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > you could do: > > if (IS_ERR_OR_NULL(ptr)) { > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > return; > } It's best to not mix error pointers and NULL but when we do mix them, it means that NULL is a

[PATCH AUTOSEL 4.20 50/81] drm/amdgpu: Implement doorbell self-ring for NBIO 7.4

2019-02-28 Thread Sasha Levin
From: Jay Cornwall [ Upstream commit 12292519d919ecde92e7e7c8acbcdb9f0c7c6013 ] Fixes doorbell reflection on Vega20. Change-Id: I0495139d160a9032dff5977289b1eec11c16f781 Signed-off-by: Jay Cornwall Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.20 32/81] drm/amdgpu: Add missing power attribute to APU check

2019-02-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit dc14eb12f6bb3e779c5461429c1889a339c67aab ] Add missing power_average to visible check for power attributes for APUs. Was missed before. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.20 52/81] drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init

2019-02-28 Thread Sasha Levin
From: Paul Kocialkowski [ Upstream commit b14e945bda8ae227d1bf2b1837c0c4a61721cd1a ] When initializing clocks, a reference to the TCON channel 0 clock is obtained. However, the clock is never prepared and enabled later. Switching from simplefb to DRM actually disables the clock (that was

[PATCH AUTOSEL 4.20 72/81] drm/omap: dsi: Fix crash in DSI debug dumps

2019-02-28 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit 4df04ac9b37f278c48bb696289aff8f81226af4b ] Reading any of the DSI debugfs files results in a crash, as wrong pointer is passed to the dump functions, and the dump functions use a wrong pointer. This patch fixes DSI debug dumps. Fixes: f3ed97f9ae7d

[PATCH AUTOSEL 4.20 51/81] drm/amdgpu: fix the incorrect external id for raven series

2019-02-28 Thread Sasha Levin
From: Huang Rui [ Upstream commit 7e4545d372b560df10fa47281ef0783a479ce435 ] This patch fixes the incorrect external id that kernel reports to user mode driver. Raven2's rev_id is starts from 0x8, so its external id (0x81) should start from rev_id + 0x79 (0x81 - 0x8). And Raven's rev_id should

Re: [PATCH 1/2] drm/edid: If no preferred mode is found assume the first mode is preferred

2019-02-28 Thread Adam Jackson
On Wed, 2019-02-27 at 23:03 +0200, Ville Syrjälä wrote: > So instead of putting this logic into the EDID parser I guess we > could just put it into the i915 fixed mode code. But then I suppose > we should also fix EDID_QUIRK_FIRST_DETAILED_PREFERRED (assuming it > exists for a good reason). I

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Chris Wilson
Quoting Alex Deucher (2019-02-28 17:25:41) > On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2019-02-28 09:49:51) > > > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > > > > > I merged some fixes into drm-fixes, pushed it out, then saw tip > > > >

[PATCH AUTOSEL 4.9 06/19] drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init

2019-02-28 Thread Sasha Levin
From: Paul Kocialkowski [ Upstream commit b14e945bda8ae227d1bf2b1837c0c4a61721cd1a ] When initializing clocks, a reference to the TCON channel 0 clock is obtained. However, the clock is never prepared and enabled later. Switching from simplefb to DRM actually disables the clock (that was

[Bug 109692] deadlock occurs during GPU reset

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109692 --- Comment #17 from mikhail.v.gavri...@gmail.com --- (In reply to Michel Dänzer from comment #16) > The "suspicious RCU usage" looks related to the igb ethernet driver, not > amdgpu. Quite likely it's already fixed in later 5.0-rc releases.

Re: [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-28 Thread Hans de Goede
Hi Heikki, On 28-02-19 15:47, Heikki Krogerus wrote: Hi Hans, On Thu, Feb 28, 2019 at 12:24:25PM +0100, Hans de Goede wrote: Hi, On 28-02-19 10:15, Heikki Krogerus wrote: I've been thinking about this... Do we actually need to link the correct drm_connector to the Type-C connector?

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Alex Deucher
On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-02-28 09:49:51) > > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > > > I merged some fixes into drm-fixes, pushed it out, then saw tip > > > breaking, but I'm needed elsewhere, so if anyone can fix

[PATCH AUTOSEL 4.20 73/81] drm/omap: dsi: Fix OF platform depopulate

2019-02-28 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit 0940c52742de0d2f70ba687bfd5fe8aa38c5f27d ] Commit edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind to probe") moved the of_platform_populate() call from dsi_bind() to dsi_probe(), but failed to move the corresponding

[PATCH AUTOSEL 4.20 71/81] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-02-28 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0a5f49cbf9d6ad3721c16f8a6d823363ea7a160f ] amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, we should use irq version spin_lock to avoid deadlock. Signed-off-by: Philip Yang Reviewed-by: Christian König Signed-off-by:

[PATCH AUTOSEL 4.19 25/64] drm/radeon: check if device is root before getting pci speed caps

2019-02-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit afeff4c16edaa6275b903f82b0561406259aa3a3 ] Check if the device is root rather before attempting to see what speeds the pcie port supports. Fixes a crash with pci passthrough in a VM. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109366 Reviewed-by:

[PATCH AUTOSEL 4.19 24/64] drm/amdgpu: Add missing power attribute to APU check

2019-02-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit dc14eb12f6bb3e779c5461429c1889a339c67aab ] Add missing power_average to visible check for power attributes for APUs. Was missed before. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.20 74/81] drm/omap: dsi: Hack-fix DSI bus flags

2019-02-28 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit 6297388e1eddd2f1345cea5892156223995bcf2d ] Since commit b4935e3a3cfa ("drm/omap: Store bus flags in the omap_dss_device structure") video mode flags are managed by the omapdss (and later omapdrm) core based on bus flags stored in omap_dss_device. This

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-28 01:03:24) > On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > > > when they need to abort and then the test runner would detect that error > > via the return value from the 'run test' function. That would be a more > > direct approach, but also more

[Bug 109749] FreeSync stutters if framerate is less than refresh rate and vsync/flipping is on

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109749 --- Comment #4 from Nicholas Kazlauskas --- It technically isn't in amd-staging-drm-next directly yet, but it is in the fixes branch. It'll make its way to staging and 5.1 eventually. Like Michel said, feel free to mark as resolved when you

[PATCH AUTOSEL 4.14 20/36] drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init

2019-02-28 Thread Sasha Levin
From: Paul Kocialkowski [ Upstream commit b14e945bda8ae227d1bf2b1837c0c4a61721cd1a ] When initializing clocks, a reference to the TCON channel 0 clock is obtained. However, the clock is never prepared and enabled later. Switching from simplefb to DRM actually disables the clock (that was

[PATCH AUTOSEL 4.19 57/64] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-02-28 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0a5f49cbf9d6ad3721c16f8a6d823363ea7a160f ] amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, we should use irq version spin_lock to avoid deadlock. Signed-off-by: Philip Yang Reviewed-by: Christian König Signed-off-by:

Re: [PATCH v7 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-02-28 Thread Jagan Teki
Hi Thierry, On Tue, Feb 19, 2019 at 1:57 AM Sam Ravnborg wrote: > > Hi Thierry > > > Pleas let me know if you any further comments on this? > No further comments from my side, and I consider it > ready to apply. Would you please pick this? Jagan. ___

[PATCH AUTOSEL 4.19 28/64] drm/amdgpu: Transfer fences to dmabuf importer

2019-02-28 Thread Sasha Levin
From: Chris Wilson [ Upstream commit 6e11ea9de9576a644045ffdc2067c09bc2012eda ] amdgpu only uses shared-fences internally, but dmabuf importers rely on implicit write hazard tracking via the reservation_object.fence_excl. For example, the importer use the write hazard for timing a page flip to

[PATCH AUTOSEL 4.19 39/64] drm/sun4i: tcon: Prepare and enable TCON channel 0 clock at init

2019-02-28 Thread Sasha Levin
From: Paul Kocialkowski [ Upstream commit b14e945bda8ae227d1bf2b1837c0c4a61721cd1a ] When initializing clocks, a reference to the TCON channel 0 clock is obtained. However, the clock is never prepared and enabled later. Switching from simplefb to DRM actually disables the clock (that was

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

2019-02-28 Thread Andrew F. Davis
On 2/27/19 3:55 PM, John Stultz wrote: > On Wed, Feb 27, 2019 at 8:38 AM Andrew F. Davis wrote: >> >> On 2/26/19 5:40 PM, John Stultz wrote: >>> On Tue, Feb 26, 2019 at 11:21 AM John Stultz wrote: >>> I've updated the patches here: >>> kernel: >>>

[PATCH 6/7] drm/atomic: Wire file_priv through for property changes

2019-02-28 Thread Daniel Vetter
We need this to make sure lessees can only connect their plane/connectors to crtc objects they own. And note that this is irrespective of whether the lessor is atomic or not, lessor cannot prevent lessees from enabling atomic. Cc: sta...@vger.kernel.org Cc: Keith Packard Signed-off-by: Daniel

[PATCH 4/7] drm/lease: Check for lessor outside of locks

2019-02-28 Thread Daniel Vetter
The lessor is invariant over a lifetime of a lease, we don't have to grab any locks for that. Speeds up the common case of not being a lease. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 7/7] drm/atomic: -EACCESS for lease-denied crtc lookup

2019-02-28 Thread Daniel Vetter
With the previous patch drm_crtc_find will return NULL when the crtc isn't in our lease, which will then disable the plane/connector. No longer an issue since the lessor can't escape their lease terms anymore, but not quite great semantics yet either. Catch this and return -EACCES, so that at

[PATCH 5/7] drm/lease: Make sure implicit planes are leased

2019-02-28 Thread Daniel Vetter
If userspace doesn't enable universal planes, then we automatically add the primary and cursor planes. But for universal userspace there's no such check (and maybe we only want to give the lessee one plane, maybe not even the primary one), hence we need to check for the implied plane. v2: don't

[PATCH 3/7] drm/leases: Don't init to 0 in drm_master_create

2019-02-28 Thread Daniel Vetter
We kzalloc. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_auth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c index 1669c42c40ed..bcf0a5a1018f 100644 --- a/drivers/gpu/drm/drm_auth.c +++

[PATCH 2/7] drm/lease: Drop recursive leads checks

2019-02-28 Thread Daniel Vetter
We disallow subleasing, so no point checking whether the master holds all the leases - it will. Spotted while typing exhaustive igt coverage for all these corner cases. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-02-28 Thread Daniel Vetter
Not exactly sure what's the aim here, but the canonical nil object has id == 0, we don't use negative object ids for anything. Plus all object_id are valided by the object_idr, there's nothing we need to do on top of that ENOENT check a bit further down. Spotted while typing exhaustive igt

[PATCH 0/7] some cleanups and uapi clarification for leases

2019-02-28 Thread Daniel Vetter
[resend with the right mailing lists] Hi all, Nothing too major, only things I did find in all my igt test extending for drm lease is some corner cases around implicit planes and atomic target crtcs. Review and comments very much appreciated. Cheers, Daniel Test-with:

[PATCH 4/7] drm/lease: Check for lessor outside of locks

2019-02-28 Thread Daniel Vetter
The lessor is invariant over a lifetime of a lease, we don't have to grab any locks for that. Speeds up the common case of not being a lease. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 2/7] drm/lease: Drop recursive leads checks

2019-02-28 Thread Daniel Vetter
We disallow subleasing, so no point checking whether the master holds all the leases - it will. Spotted while typing exhaustive igt coverage for all these corner cases. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lease.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 5/7] drm/lease: Make sure implicit planes are leased

2019-02-28 Thread Daniel Vetter
If userspace doesn't enable universal planes, then we automatically add the primary and cursor planes. But for universal userspace there's no such check (and maybe we only want to give the lessee one plane, maybe not even the primary one), hence we need to check for the implied plane. v2: don't

[PATCH 0/7] some cleanups and uapi clarification for leases

2019-02-28 Thread Daniel Vetter
Hi all, Nothing too major, only things I did find in all my igt test extending for drm lease is some corner cases around implicit planes and atomic target crtcs. Review and comments very much appreciated. Cheers, Daniel Test-with: 20190228141918.26043-1-daniel.vet...@ffwll.ch Daniel Vetter

[PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-02-28 Thread Daniel Vetter
Not exactly sure what's the aim here, but the canonical nil object has id == 0, we don't use negative object ids for anything. Plus all object_id are valided by the object_idr, there's nothing we need to do on top of that ENOENT check a bit further down. Spotted while typing exhaustive igt

[PATCH 6/7] drm/atomic: Wire file_priv through for property changes

2019-02-28 Thread Daniel Vetter
We need this to make sure lessees can only connect their plane/connectors to crtc objects they own. And note that this is irrespective of whether the lessor is atomic or not, lessor cannot prevent lessees from enabling atomic. Cc: sta...@vger.kernel.org Cc: Keith Packard Signed-off-by: Daniel

[PATCH 3/7] drm/leases: Don't init to 0 in drm_master_create

2019-02-28 Thread Daniel Vetter
We kzalloc. Cc: Keith Packard Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_auth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c index 1669c42c40ed..bcf0a5a1018f 100644 --- a/drivers/gpu/drm/drm_auth.c +++

[PATCH 7/7] drm/atomic: -EACCESS for lease-denied crtc lookup

2019-02-28 Thread Daniel Vetter
With the previous patch drm_crtc_find will return NULL when the crtc isn't in our lease, which will then disable the plane/connector. No longer an issue since the lessor can't escape their lease terms anymore, but not quite great semantics yet either. Catch this and return -EACCES, so that at

[PATCH AUTOSEL 4.20 33/81] drm/radeon: check if device is root before getting pci speed caps

2019-02-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit afeff4c16edaa6275b903f82b0561406259aa3a3 ] Check if the device is root rather before attempting to see what speeds the pcie port supports. Fixes a crash with pci passthrough in a VM. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109366 Reviewed-by:

[PATCH AUTOSEL 4.20 37/81] drm/amdgpu: Transfer fences to dmabuf importer

2019-02-28 Thread Sasha Levin
From: Chris Wilson [ Upstream commit 6e11ea9de9576a644045ffdc2067c09bc2012eda ] amdgpu only uses shared-fences internally, but dmabuf importers rely on implicit write hazard tracking via the reservation_object.fence_excl. For example, the importer use the write hazard for timing a page flip to

[Bug 109649] [bisected][raven] gfx ring timeout when running clover apps

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109649 --- Comment #3 from Jan Vesely --- The bug is still present in 5.0.0-rc8. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[Bug 109692] deadlock occurs during GPU reset

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109692 --- Comment #18 from mikhail.v.gavri...@gmail.com --- Created attachment 143497 --> https://bugs.freedesktop.org/attachment.cgi?id=143497=edit "amd-staging-drm-next" + commits 3741540, 222b5f0 and 5936131 is reverted -- You are receiving

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

2019-02-28 Thread Daniel Vetter
On Wed, Feb 27, 2019 at 04:36:06PM -0800, Hyun Kwon wrote: > Hi Daniel, > > On Wed, 2019-02-27 at 06:13:45 -0800, Daniel Vetter wrote: > > On Tue, Feb 26, 2019 at 11:20 PM Hyun Kwon wrote: > > > > > > Hi Daniel, > > > > > > Thanks for the comment. > > > > > > On Tue, 2019-02-26 at 04:06:13

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > vkms_crc_work_handle needs the value of the actual frame to > > schedule the workqueue that calls periodically the vblank > > handler and the destroy state

[PATCH] drm: Slightly quieten bad EDID messages

2019-02-28 Thread Chris Wilson
Bad EDID are a fact of life when dealing with random monitors. We only spam the logs when debugging is enabled, but we only need to raise notice and not set off the warning bells. Signed-off-by: Chris Wilson Cc: Maarten Lankhorst --- drivers/gpu/drm/drm_edid.c | 11 +-- 1 file changed,

Re: [Intel-gfx] [PATCH] drm: Slightly quieten bad EDID messages

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 01:42:33PM +, Chris Wilson wrote: > Bad EDID are a fact of life when dealing with random monitors. We only > spam the logs when debugging is enabled, but we only need to raise > notice and not set off the warning bells. > > Signed-off-by: Chris Wilson > Cc: Maarten

Re: [PATCH 1/2] drm/hibmc: Drop best_encoder

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 02:16:03PM +0100, Noralf Trønnes wrote: > > > Den 21.02.2019 16.58, skrev Daniel Vetter: > > This is the default for atomic drivers. > > > > Signed-off-by: Daniel Vetter > > Cc: Daniel Vetter > > Cc: Sam Ravnborg > > Cc: Neil Armstrong > > Cc: Luc Van Oostenryck > >

[PATCH 3/5] drm/rockchip: Use the helpers for PSR

2019-02-28 Thread Sean Paul
From: Sean Paul Instead of rolling our own implementation for tracking when PSR should be [in]active, use the PSR helpers to do the heavy lifting. Cc: Zain Wang Cc: Tomasz Figa Signed-off-by: Sean Paul --- .../drm/bridge/analogix/analogix_dp_core.c| 205 -

[PATCH 5/5] drm/rockchip: Use drm_atomic_helper_commit_tail_rpm

2019-02-28 Thread Sean Paul
From: Sean Paul Now that we use the drm psr helpers, we no longer need to hand-roll our atomic_commit_tail implementation. So use the helper Cc: Zain Wang Cc: Tomasz Figa Signed-off-by: Sean Paul --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 21 + 1 file changed, 1

[PATCH 4/5] drm/rockchip: Don't fully disable vop on PSR

2019-02-28 Thread Sean Paul
From: Sean Paul Instead of fully disabling and re-enabling the vop on PSR transitions, only disable the active windows. This will speed up PSR exits substantially and is still a power-savings win. This patch integrates portions of Zain's patch from here:

[PATCH 1/5] drm: Add helpers to kick off PSR enable/disable

2019-02-28 Thread Sean Paul
From: Sean Paul This patch adds a new drm helper library to help drivers implement PSR. Drivers choosing to use it will register connectors with PSR-capable displays connected and will receive callbacks when it's time to enter or exit PSR. In its current form, it has a timer which will trigger

[PATCH 2/5] drm/rockchip: Check for fast link training before enabling psr

2019-02-28 Thread Sean Paul
From: Sean Paul Once we start shutting off the link during PSR, we're going to want fast training to work. If the display doesn't support fast training, don't enable psr. Cc: Zain Wang Cc: Tomasz Figa Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 9

[PATCH 0/5] drm: Add PSR helpers

2019-02-28 Thread Sean Paul
From: Sean Paul Hey all, Here's a set to add some helpers for drivers looking to implement PSR. I've converted rockchip as a proof of concept, and will likely do the work for msm dsi sometime in the coming months. PTAL, Sean Sean Paul (5): drm: Add helpers to kick off PSR enable/disable

Re: [PATCH v2] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-02-28 Thread Rob Herring
On Tue, Feb 12, 2019 at 05:38:38PM +0100, Neil Armstrong wrote: > Add the bindings for the Bifrost family of ARM Mali GPUs. > > The Bifrost GPU architecture is similar to the Midgard family, > but with a different Shader Core & Execution Engine structures. > > Bindings are based on the Midgard

Re: [PATCH 0/7] add LCD support for SAM9X60

2019-02-28 Thread Sam Ravnborg
Hi Claudiu On Wed, Feb 27, 2019 at 04:24:11PM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > Hi, > > These patches adds support for SAM9X60's LCD controller. Can you elaborate a little more which chips that are relevant. To be able to look into the right data-sheet,

Re: [PATCH 1/5] drm: Add helpers to kick off PSR enable/disable

2019-02-28 Thread Souza, Jose
On Thu, 2019-02-28 at 16:09 -0500, Sean Paul wrote: > From: Sean Paul > > This patch adds a new drm helper library to help drivers implement > PSR. Drivers choosing to use it will register connectors with > PSR-capable displays connected and will receive callbacks when it's > time > to enter or

Re: [PATCH 1/7] drm: atmel-hlcdc: add config option for clock selection

2019-02-28 Thread Sam Ravnborg
Hi Claudiu On Wed, Feb 27, 2019 at 04:24:16PM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > SAM9x60 LCD Controller has no option to select clock source as previous > controllers have. To be able to use the same driver even for this LCD > controller add a config option to

[Bug 201763] amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0!

2019-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201763 --- Comment #5 from Rogério Brito (rbr...@ime.usp.br) --- Dear Michel, First of all, sorry for the late reply. I had really a really bad start of the year (death in family, complications caused by that, health problems, fire at home and also

Re: [PATCH 0/7] add LCD support for SAM9X60

2019-02-28 Thread Sam Ravnborg
Hi Alexandre. > > > > > > These patches adds support for SAM9X60's LCD controller. > > Can you elaborate a little more which chips that are relevant. > > To be able to look into the right data-sheet, while reviewing. > > Link to data-sheet would be nice too. > > > > sam9x60 is the chip name

Re: [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero

2019-02-28 Thread Sam Ravnborg
On Wed, Feb 27, 2019 at 04:24:21PM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > Remove cfg initialization with zero and read state with > drm_crtc_state_to_atmel_hlcdc_crtc_state() so that cfg to be initialized > with state's output_mode. > > Signed-off-by: Claudiu

Re: [PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization.

2019-02-28 Thread Sam Ravnborg
Hi Claudiu On Wed, Feb 27, 2019 at 04:24:40PM +, claudiu.bez...@microchip.com wrote: > From: Sandeep Sheriker Mallikarjun > > For SAM9X60 SoC, sys_clk is through lcd_gclk clock source and this > needs to be enabled before enabling lcd_clk. We have "ownership" of the clocks in the mfd

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

2019-02-28 Thread Hyun Kwon
Hi Daniel, On Thu, 2019-02-28 at 02:01:46 -0800, Daniel Vetter wrote: > On Wed, Feb 27, 2019 at 04:36:06PM -0800, Hyun Kwon wrote: > > Hi Daniel, > > > > On Wed, 2019-02-27 at 06:13:45 -0800, Daniel Vetter wrote: > > > On Tue, Feb 26, 2019 at 11:20 PM Hyun Kwon wrote: > > > > > > > > Hi Daniel,

[Bug 201763] amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0!

2019-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201763 --- Comment #6 from Rogério Brito (rbr...@ime.usp.br) --- Oh, I forgot to say that the kernel that I am using is currently identified as: Linux zatz 4.19.0-2-amd64 #1 SMP Debian 4.19.16-1 (2019-01-17) x86_64 GNU/Linux I can report the

Re: [PATCH] drm/virtio: Allow userspace to mmap() framebuffer

2019-02-28 Thread Gerd Hoffmann
On Thu, Feb 28, 2019 at 10:47:41AM -0600, Joshua Watt wrote: > Reports the size of the virtgpu framebuffer to userspace and installs > the deferred I/O handlers so that userspace can mmap() and write to it. Fixed already, as side effect of switching virtio to the generic fbdev emulation. Patches

[git pull] drm fixes for 5.0 final

2019-02-28 Thread Dave Airlie
Hi Linus, Three final fixes, one for a feature that is new in this kernel, one bochs fix for qemu riscv and one atomic modesetting fix. I've left a few of the other late fixes until next as I didn't want to throw in anything that wasn't really necessary. Dave. drm-fixes-2019-03-01: drm amdgfx,

linux-next: manual merge of the drm tree with the drm-fixes tree

2019-02-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c between commit: d63716658ac1 ("drm/amd/display: Use vrr friendly pageflip throttling in DC.") from the drm-fixes tree and commits: 8a48b44cd00f ("drm/amd/display: Call

Re: [PATCH 1/7] drm: atmel-hlcdc: add config option for clock selection

2019-02-28 Thread Sam Ravnborg
Hi Claudiu One more reply to this patch... On Wed, Feb 27, 2019 at 04:24:16PM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > SAM9x60 LCD Controller has no option to select clock source as previous > controllers have. To be able to use the same driver even for this LCD >

[Bug 109749] FreeSync stutters if framerate is less than refresh rate and vsync/flipping is on

2019-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109749 bmil...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH 0/7] add LCD support for SAM9X60

2019-02-28 Thread Claudiu.Beznea
From: Claudiu Beznea Hi, These patches adds support for SAM9X60's LCD controller. First patches add option to specify if controller clock source is fixed. Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). The 3rd one adds specific bindings for SAM9X60 LCD

[PATCH 4/7] mfd: atmel-hlcdc: add compatible for SAM9X60 HLCD controller

2019-02-28 Thread Claudiu.Beznea
From: Claudiu Beznea Add compatible for SAM9X60 HLCD controller. Signed-off-by: Claudiu Beznea --- drivers/mfd/atmel-hlcdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index e82543bcfdc8..35a9e16f9902 100644 ---

[PATCH 6/7] drm: atmel-hlcdc: enable sys_clk during initalization.

2019-02-28 Thread Claudiu.Beznea
From: Sandeep Sheriker Mallikarjun For SAM9X60 SoC, sys_clk is through lcd_gclk clock source and this needs to be enabled before enabling lcd_clk. Signed-off-by: Sandeep Sheriker Mallikarjun [claudiu.bez...@microchip.com: add fixed_clksrc checks] Signed-off-by: Claudiu Beznea ---

[PATCH 3/7] dt-bindings: mfd: add bindings for SAM9X60 HLCD controller

2019-02-28 Thread Claudiu.Beznea
From: Claudiu Beznea Add new compatible string for the HLCD controller on SAM9X60 SoC. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt

Re: [PATCH v1] drm/tegra: plane: Remove format-modifier checking

2019-02-28 Thread Dmitry Osipenko
24.02.2019 18:34, Dmitry Osipenko пишет: > Tiling modifier can't be applied to YV12 video overlay because all tiling > modifiers are filtered out for multi-plane formats. AFAIK, all modifiers > should work with all of formats, hence the checking is incorrect and > simply not needed. > > Fixes:

[PATCH 7/7] drm: atmel-hlcdc: add sam9x60 LCD controller

2019-02-28 Thread Claudiu.Beznea
From: Sandeep Sheriker Mallikarjun Add the LCD controller for SAM9X60. Signed-off-by: Sandeep Sheriker Mallikarjun [claudiu.bez...@microchip.com: add fixed_clksrc option to atmel_hlcdc_dc_sam9x60] Signed-off-by: Claudiu Beznea --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 101

  1   2   >