[PATCH] drm/doc: Drop "content type" from the legacy kms property table

2019-03-26 Thread Daniel Vetter
We want new stuff documented in more verbose form, this table is deprecated. "content type" is already documented properly. Fixes: 50525c332b55 ("drm: content-type property for HDMI connector") Cc: Hans Verkuil Cc: Daniel Vetter Cc: Stanislav Lisovskiy Cc: Ville Syrjälä Signed-off-by: Daniel

Re: [PATCH] drm/doc: Drop "content type" from the legacy kms property table

2019-03-26 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 10:05:55AM +0100, Daniel Vetter wrote: > We want new stuff documented in more verbose form, this table is > deprecated. "content type" is already documented properly. > > Fixes: 50525c332b55 ("drm: content-type property for HDMI connector") > Cc: Hans Verkuil > Cc: Daniel

[PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'

2019-03-26 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: variable 'vgdev' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/virtio/virtgpu_ttm.c: In function

[PATCH 2/2] drm/i915: Associate ACPI connector nodes with connector entries

2019-03-26 Thread Heikki Krogerus
On Intel platforms we know that the ACPI connector device node order will follow the order the driver (i915) decides. The decision is made using the custom Intel ACPI OpRegion (intel_opregion.c), though the driver does not actually know that the values it sends to ACPI there are used for

Re: [PATCH v13 14/20] drm/amdgpu, arm64: untag user pointers in amdgpu_ttm_tt_get_user_pages

2019-03-26 Thread Kevin Brodsky
On 22/03/2019 15:59, Catalin Marinas wrote: On Wed, Mar 20, 2019 at 03:51:28PM +0100, Andrey Konovalov wrote: This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments.

Re: CEC blocks idle on omap4

2019-03-26 Thread Tony Lindgren
* Hans Verkuil [190325 16:12]: > On 3/25/19 4:55 PM, Laurent Pinchart wrote: > >> The reality is that HDMI CEC and HDMI video are really independent of > >> one another. So I wonder if it isn't better to explain the downsides > >> of enabling CEC for the omap4 in the CONFIG_OMAP4_DSS_HDMI_CEC >

[PATCH v2] gpu: radeon: fix a potential NULL-pointer dereference

2019-03-26 Thread Kangjie Lu
In case alloc_workqueue fails, the fix frees memory and returns -ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- v2: use radeon_crtc_destroy to properly clean up resources as suggested by Michel Dänzer --- drivers/gpu/drm/radeon/radeon_display.c | 15

CEC blocks idle on omap4

2019-03-26 Thread Tony Lindgren
Hi Hans, Looks like CONFIG_OMAP4_DSS_HDMI_CEC=y blocks SoC core retention idle on omap4 if selected. Should we maybe move hdmi4_cec_init() to hdmi_display_enable() and hdmi4_cec_uninit() to hdmi_display_disable()? Or add some enable/disable calls in addtion to the init and uninit calls that can

[PATCH] [v7,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-26 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V7: - Add the information of the reviewer - Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek) - Merge the same data structures, like

Re: [PATCH v13 09/20] net, arm64: untag user pointers in tcp_zerocopy_receive

2019-03-26 Thread Kevin Brodsky
On 22/03/2019 12:04, Catalin Marinas wrote: On Wed, Mar 20, 2019 at 03:51:23PM +0100, Andrey Konovalov wrote: This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments.

[PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM

2019-03-26 Thread Tony Lindgren
If CONFIG_OMAP4_DSS_HDMI_CEC is enabled in .config, deeper SoC idle states are blocked because the CEC clock gets always enabled on init. Let's fix the issue by moving the CEC clock handling to happen later in hdmi_cec_adap_enable() as suggested by Hans Verkuil . This way the CEC clock gets only

[PATCH 07/11] drm/fbdevdrm: Add DRM <-> fbdev pixel-format conversion

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/Makefile | 1 + drivers/gpu/drm/fbdevdrm/fbdevdrm_format.c | 441 + drivers/gpu/drm/fbdevdrm/fbdevdrm_format.h | 26 ++ 3 files changed, 468 insertions(+) create mode 100644

[PATCH 09/11] drm/fbdevdrm: Add primary plane

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/Makefile | 1 + drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c | 42 ++ drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.h | 7 + drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c | 9 +- drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.h |

[PATCH 11/11] drm/fbdevdrm: Detect and validate display modes

2019-03-26 Thread Thomas Zimmermann
Mode detection currently reports the modes listed in fb_info::modelist. The list is either build from EDID information or, more often, a list of previously set modes. A later update to the mode detection could also take into account the modes in fb_monspecs::modedb or test pre-defined VESA modes.

[PATCH 03/11] drm/fbdevdrm: Add memory management

2019-03-26 Thread Thomas Zimmermann
Memory management in fbdevdrm is provided by TTM. Fbdev implements page flipping via display pan operations, which require scanout buffers to be aligned at scanline boundaries. At the same time memory-mapping operations of individual buffers requires page alignment of each buffer. Fbdevdrm ensures

[PATCH 04/11] drm/fbdevdrm: Add file operations

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c b/drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c index 5be902094dc6..4a6ba6c85c5c 100644

[PATCH 08/11] drm/fbdevdrm: Add mode conversion DRM <-> fbdev

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/Makefile | 1 + drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c | 153 ++ drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.h | 46 +++ 3 files changed, 200 insertions(+) create mode 100644

[RFC][PATCH 00/11] DRM driver for fbdev devices

2019-03-26 Thread Thomas Zimmermann
Hi, this RFC patch set implements fbdevdrm, a DRM driver on top of fbdev drivers. I'd appreciate feedback on the code and the idea in general. The fbdev subsystem is considered legacy and will probably be removed at some point. This would mean the loss of a signifanct number of drivers. Some of

[PATCH 01/11] drm/fbdevdrm: Add driver skeleton

2019-03-26 Thread Thomas Zimmermann
The fbdevdrm driver runs DRM on top of fbdev framebuffer drivers. It allows for using legacy drivers with modern userspace and gives a template for converting fbdev drivers to DRM. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile

[PATCH 02/11] drm/fbdevdrm: Add fbdevdrm device

2019-03-26 Thread Thomas Zimmermann
There's an fbdevdrm device for each supported fbdev device. The fbdevdrm driver listens for fb events, and creates and destroys fbdevdrm devices accordingly. Only hardware-specific fbdev drivers are supported. Generic drivers, such as vga16fb or vesafb are not handled. DRM-based fbdev drivers are

[PATCH 10/11] drm/fbdevdrm: Add CRTC

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c | 150 +++- 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c b/drivers/gpu/drm/fbdevdrm/fbdevdrm_modeset.c index 3473b85acbf1..87f56ec76edf

[PATCH 06/11] drm/fbdevdrm: Add modesetting infrastructure

2019-03-26 Thread Thomas Zimmermann
Modesetting for fbdevdrm supports a single display pipeline with CRTC, primary plane, encoder and connector. The fbdev device would have been an ideal candidate for using |struct drm_simple_display_pipe|. To better illustrate the conversion from fbdev to DRM drivers, fbdevdrm used the regular DRM

[PATCH 05/11] drm/fbdevdrm: Add GEM and dumb interfaces

2019-03-26 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c | 77 + 1 file changed, 77 insertions(+) diff --git a/drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c b/drivers/gpu/drm/fbdevdrm/fbdevdrm_drv.c index 4a6ba6c85c5c..4724e3df6ace 100644 ---

[PATCHv2 18/22] drm/bridge: tc358767: remove tc_connector_best_encoder

2019-03-26 Thread Tomi Valkeinen
As far as I know, drm_connector_helper_funcs.best_encoder is not needed in a trivial case as we have here. So remove tc_connector_best_encoder. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCHv2 08/22] drm/bridge: tc358767: split stream enable/disable

2019-03-26 Thread Tomi Valkeinen
It is nicer to have enable/disable functions instead of set(bool enable) style function. Split tc_main_link_stream into tc_stream_enable and tc_stream_disable. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 81 +-- 1 file changed, 45

[PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-03-26 Thread Tomi Valkeinen
The current link training code does unnecessary retry-loops, and does extra writes to the registers. It is easier to follow the flow and ensure it's similar to Toshiba's documentation if we deal with LT inside tc_main_link_enable() function. This patch adds tc_wait_link_training() which handles

[PATCHv2 14/22] drm/bridge: tc358767: cleanup LT result check

2019-03-26 Thread Tomi Valkeinen
The driver has a loop after ending link training, where it reads the DPCD link status and prints an error if that status is not ok. The loop is unnecessary, as far as I can understand from DP specs, so let's remove it. We can also print the more specific errors to help debugging. Signed-off-by:

[PATCHv2 21/22] drm/bridge: tc358767: add IRQ and HPD support

2019-03-26 Thread Tomi Valkeinen
Add support for interrupt and hotplug handling. Both are optional. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 157 ++ 1 file changed, 139 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c

[PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-03-26 Thread Tomi Valkeinen
DP always uses ANSI 8B10B encoding. Some monitors (old?) may not have the ANSI 8B10B bit set in DPCD, even if it should always be set. The tc358767 driver currently respects that flag, and turns the encoding off if the monitor does not have the bit set, which then results in the monitor not

[PATCHv2 07/22] drm/bridge: tc358767: move video stream setup to tc_main_link_stream

2019-03-26 Thread Tomi Valkeinen
The driver currently sets the video stream registers in tc_main_link_setup. One should be able to establish the DP link without any video stream, so a more logical place is to configure the stream in the tc_main_link_stream. So move them there. Signed-off-by: Tomi Valkeinen ---

[PATCHv2 09/22] drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable

2019-03-26 Thread Tomi Valkeinen
We set up the PXL PLL inside tc_main_link_setup. This is unnecessary, and makes tc_main_link_setup depend on the video-mode, which should not be the case. As PXL PLL is used only for the video stream (and only when using the HW test pattern), let's move the PXL PLL setup into tc_stream_enable.

[PATCHv2 11/22] drm/bridge: tc358767: ensure DP is disabled before LT

2019-03-26 Thread Tomi Valkeinen
Link training will sometimes fail if the DP link is, for some whatever reason, enabled when tc_main_link_enable() is called. Ensure that the DP link is disabled by setting DP0CTL to 0 as the first thing. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 2 ++ 1 file

[PATCHv2 01/22] drm/bridge: tc358767: fix tc_aux_get_status error handling

2019-03-26 Thread Tomi Valkeinen
tc_aux_get_status() does not report AUX_TIMEOUT correctly, as it only checks the AUX_TIMEOUT if aux is still busy. Fix this by always checking for AUX_TIMEOUT. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)

[PATCHv2 02/22] drm/bridge: tc358767: reset voltage-swing & pre-emphasis

2019-03-26 Thread Tomi Valkeinen
We need to reset DPCD voltage-swing & pre-emphasis before starting the link training, as otherwise tc358767 will use the previous values as minimums. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCHv2 04/22] drm/bridge: tc358767: cleanup spread & scrambler_dis

2019-03-26 Thread Tomi Valkeinen
Minor cleanups: - Use bool for boolean fields - Use DP_MAX_DOWNSPREAD_0_5 instead of BIT(0) - debug print down-spread and scrambler status Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCHv2 05/22] drm/bridge: tc358767: remove unused swing & preemp

2019-03-26 Thread Tomi Valkeinen
swing and preemp fields are not used. Remove them. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 8e53073f0e35..7ef8d754b4ff 100644 ---

[PATCHv2 06/22] drm/bridge: tc358767: cleanup aux_link_setup

2019-03-26 Thread Tomi Valkeinen
Modify aux_link_setup so that it does not use tc->link, and thus makes aux setup independent of the link probing. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c

[PATCHv2 00/22] drm/bridge: tc358767: DP support

2019-03-26 Thread Tomi Valkeinen
Hi, tc358767 bridge was originally implemented for eDP use with an embedded panel. I've been working to add DP and HPD support, and this series is the result. I did have a lot of issues with link training, but with these, it's been working reliably with my devices. Compared to v1, I dropped the

[PATCH] MAINTAINERS: Fix pattern for Documentation path for Arm Mali Komeda

2019-03-26 Thread Liviu Dudau
The Device Tree bindings documentation file is in a simplified path that doesn't match the MAINTAINERS entry. Reported-by: Joe Perches Signed-off-by: Liviu Dudau --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCHv2 10/22] drm/bridge: tc358767: add link disable function

2019-03-26 Thread Tomi Valkeinen
Currently we have tc_main_link_setup(), which configures and enabled the link, but we have no counter-part for disabling the link. Add tc_main_link_disable, and rename tc_main_link_setup to tc_main_link_enable. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 27

Re: [PATCH V2] drm/atomic-helper: Make atomic_enable/disable crtc callbacks optional

2019-03-26 Thread Daniel Vetter
On Mon, Mar 25, 2019 at 08:29:06AM -0300, Rodrigo Siqueira wrote: > On 03/15, Daniel Vetter wrote: > > On Thu, Mar 14, 2019 at 03:48:45PM -0300, Rodrigo Siqueira wrote: > > > Allow atomic_enable and atomic_disable operations from > > > drm_crtc_helper_funcs struct optional. With this, the target

Re: [PATCH] fbdev: fix divide error in fb_var_to_videomode

2019-03-26 Thread Shile Zhang
Hi, Bartlomiej, Fredrik, Daniel, Could you please help to have a look at this patch? Many thanks! -Shile On 2019/3/19 20:20, shile.zh...@linux.alibaba.com wrote: From: Shile Zhang To fix following divide-by-zero error found by Syzkaller: divide error: [#1] SMP PTI CPU: 7 PID:

[PATCH] [v7, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-03-26 Thread Jerry Han
The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and connected to DSI using four lanes. V7: - Add the information of the reviewer V6: - Add the information of the reviewer V5: - Added changelog V4: - None V3: - None V2: - Add compatible device "boe,himax8279d10p" (Sam) - Add

[PATCH 1/2] drm: Add fwnode member to the struct drm_connector

2019-03-26 Thread Heikki Krogerus
If the system firmware supplies nodes that represent the connectors, they need to be associated with the connector entries. ACPI tables at least always supply a device node for every connector on integrated video hardware - this is explained in ACPI specification's ch. "Appendix B Video

Re: CEC blocks idle on omap4

2019-03-26 Thread Tony Lindgren
* Hans Verkuil [190325 15:52]: > Hi Tony, > > On 3/25/19 4:32 PM, Tony Lindgren wrote: > > Hi Hans, > > > > Looks like CONFIG_OMAP4_DSS_HDMI_CEC=y blocks SoC core retention > > idle on omap4 if selected. > > > > Should we maybe move hdmi4_cec_init() to hdmi_display_enable() > > and

Re: [RFC v2 1/3] dma-buf: give each buffer a full-fledged inode

2019-03-26 Thread Joel Fernandes
On Mon, Mar 25, 2019 at 12:34:59PM -0700, Chenbo Feng wrote: [snip] > > > > Also what is the benefit of having st_blocks from stat? AFAIK, that is > > > > the > > > > same as the buffer's size which does not change for the lifetime of the > > > > buffer. In your patch you're doing this when

Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'

2019-03-26 Thread Mukesh Ojha
On 3/25/2019 2:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: variable 'vgdev' set but not used [-Wunused-but-set-variable]

Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth'

2019-03-26 Thread Mukesh Ojha
On 3/23/2019 8:16 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init': drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:645:29: warning: variable 'fb_offset' set but not used [-Wunused-but-set-variable]

[PATCH 0/2] drm: connector firmware nodes

2019-03-26 Thread Heikki Krogerus
Hi, If the system firmware supplies device nodes representing the display connectors on integrated video hardware, those nodes should probable always be associated with the display connector entries (struct drm_connector). With the USB Type-C DisplayPort alt mode, we will need a way to inform

[PATCH] drm/ttm: properly unmap dma page upon failure

2019-03-26 Thread Yu Zhao
dma_unmap_page() must be called with exactly the same dma address and size returned by dma_map_page(). Otherwise, the function may fail. This is at least the case for debug_dma_unmap_page() and AMD iommu unmap_page callback. Signed-off-by: Yu Zhao --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11

Re: [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'

2019-03-26 Thread YueHaibing
On 2019/3/25 17:02, Daniel Vetter wrote: > On Wed, Mar 20, 2019 at 02:03:08AM +, YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': >> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: >>

Re: [PATCH v13 17/20] media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get

2019-03-26 Thread Kevin Brodsky
On 22/03/2019 16:07, Catalin Marinas wrote: On Wed, Mar 20, 2019 at 03:51:31PM +0100, Andrey Konovalov wrote: This patch is a part of a series that extends arm64 kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments.

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-26 Thread Knut Omang
On Mon, 2019-03-25 at 15:32 -0700, Brendan Higgins wrote: > On Fri, Mar 22, 2019 at 12:11 AM Knut Omang wrote: > > On Thu, 2019-03-21 at 18:41 -0700, Brendan Higgins wrote: > > > On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand > > > wrote: > > > > On 2/27/19 11:42 PM, Brendan Higgins wrote: > > >

Re: CEC blocks idle on omap4

2019-03-26 Thread Tony Lindgren
* Hans Verkuil [190325 16:28]: > On 3/25/19 5:21 PM, Tony Lindgren wrote: > > * Hans Verkuil [190325 16:12]: > >> On 3/25/19 4:55 PM, Laurent Pinchart wrote: > The reality is that HDMI CEC and HDMI video are really independent of > one another. So I wonder if it isn't better to explain

Re: [RFC v2 1/3] dma-buf: give each buffer a full-fledged inode

2019-03-26 Thread Chenbo Feng
On Sun, Mar 24, 2019 at 1:45 PM Joel Fernandes wrote: > > Hi Sandeep, > > On Sun, Mar 24, 2019 at 10:56:33AM -0700, Sandeep Patil wrote: > > On Fri, Mar 22, 2019 at 11:02:55AM -0400, Joel Fernandes wrote: > > > On Thu, Mar 21, 2019 at 07:51:33PM -0700, Chenbo Feng wrote: > > > > From: Greg

Re: [PATCH v2] gpu: radeon: fix a potential NULL-pointer dereference

2019-03-26 Thread Michel Dänzer
On 2019-03-25 10:05 p.m., Kangjie Lu wrote: > In case alloc_workqueue fails, the fix frees memory and > returns -ENOMEM to avoid potential NULL pointer dereference. > > Signed-off-by: Kangjie Lu > --- > v2: use radeon_crtc_destroy to properly clean up resources as > suggested by Michel Dänzer >

Re: [PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM

2019-03-26 Thread Hans Verkuil
On 3/26/19 12:47 AM, Tony Lindgren wrote: > If CONFIG_OMAP4_DSS_HDMI_CEC is enabled in .config, deeper SoC idle > states are blocked because the CEC clock gets always enabled on init. > > Let's fix the issue by moving the CEC clock handling to happen later in > hdmi_cec_adap_enable() as suggested

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
Hi Andrzej, 19. 3. 25. 오후 4:13에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > GSCALERs in Exynos SoCs support conversion between wide range of image > formats, > plus scaling and rotation. > Driver already supports mem2mem mode - via ExynosDRM IPP framework. > This patchset adds support for mem to

[PATCHv2 12/22] drm/bridge: tc358767: remove unnecessary msleep

2019-03-26 Thread Tomi Valkeinen
For some reason the driver has a msleep(100) after writing to DP_PHY_CTRL. Toshiba's documentation doesn't suggest any delay is needed, and I have not seen any issues with the sleep removed. Drop it, as msleep(100) is a rather big one. Signed-off-by: Tomi Valkeinen ---

[PATCHv2 13/22] drm/bridge: tc358767: use more reliable seq when finishing LT

2019-03-26 Thread Tomi Valkeinen
At the end of the link training, two steps have to be taken: 1) tc358767's LT mode is disabled by a write to DP0_SRCCTRL, and 2) Remove LT flag in DPCD 0x102. Toshiba's documentation tells to first write the DPCD, then modify DP0_SRCCTRL. In my testing this often causes issues, and the link

[PATCHv2 20/22] drm/bridge: tc358767: add GPIO & interrupt registers

2019-03-26 Thread Tomi Valkeinen
Add GPIO and interrupt related registers for HPD work. Mark INTSTS_G and GPIOI as volatile. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c

[PATCHv2 19/22] drm/bridge: tc358767: copy the mode data, instead of storing the pointer

2019-03-26 Thread Tomi Valkeinen
In tc_bridge_mode_set callback, we store the pointer to the given drm_display_mode, and use the mode later. Storing a pointer in such a way looks very suspicious to me, and I have observed odd issues where the timings were apparently (at least mostly) zero. Do a copy of the drm_display_mode

[PATCHv2 22/22] dt-bindings: tc358767: add IRQ & HPD support

2019-03-26 Thread Tomi Valkeinen
Add DT properties needed for IRQ and HPD support. Signed-off-by: Tomi Valkeinen Cc: devicet...@vger.kernel.org Cc: Rob Herring --- A quick summary of tc358767's HPD/GPIO support: tc358767 has two pins that can be used as GPIOs. Those can be used for HPD by configuring the pin as input.

[PATCHv2 17/22] drm/bridge: tc358767: use bridge mode_valid

2019-03-26 Thread Tomi Valkeinen
We have tc_connector_mode_valid() to filter out videomdoes that the tc358767 cannot support. As it is a bridge limitation, change the code to use drm_bridge_funcs's mode_valid instead. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 8 1 file changed, 4

[PATCHv2 16/22] drm/bridge: tc358767: remove check for video mode in link enable

2019-03-26 Thread Tomi Valkeinen
tc_main_link_enable() checks if videomode has been set, and fails if there's no videomode. As tc_main_link_enable() no longer depends on the videomode, we can drop the check. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled

2019-03-26 Thread james qian wang (Arm Technology China)
On Mon, Mar 25, 2019 at 05:01:14PM +, Liviu Dudau wrote: > We don't call this function if CONFIG_DEBUG_FS is not defined, but we > should not be compiling it either, as the declaration of the debugfs > core functions is not included. > > Reported by the kbuild test robot. > > Signed-off-by:

RE: [PATCHv15 1/3] ARM:dt-bindings:display Intel FPGA Video and Image Processing Suite

2019-03-26 Thread Ong, Hean Loong
Hi, May I know of the patches would be integrated into drm-misc ? BR Hean Loong Internal Global Dial: 2 701 6773 Direct Line: +60 4 636 6773 >-Original Message- >From: Rob Herring >Sent: Tuesday, March 26, 2019 3:32 AM >To: Ong, Hean Loong >Cc: Daniel Vetter ; Randy Dunlap >;

[radeon-alex:amd-staging-drm-next 377/447] drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1007 amdgpu_ras_add_bad_pages() warn: variable dereferenced before check 'con' (see line 1003)

2019-03-26 Thread Dan Carpenter
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: c9115f8904eef0f880d3b4f8306f553b1bb1c532 commit: ef3da5cab664c16ca25a8d479fac95a7f04080e3 [377/447] drm/amdgpu: add amdgpu_ras.c to support ras smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1007

[radeon-alex:drm-next-5.2-wip 230/300] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:514 dce_aux_transfer_with_retries() error: uninitialized symbol 'operation_result'.

2019-03-26 Thread Dan Carpenter
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-5.2-wip head: 940d104240cd069a88f089f91299ac9bf4a154d1 commit: 2bec3b50c9c5be65ac4800d57ace6fc3b2d82136 [230/300] drm/amd/display: Respect aux return values smatch warnings:

Re: [PATCH] drm/panel: rm68200: no error msg if probe deferred

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Philippe :-) On 3/21/19 9:05 AM, Yannick Fertré wrote: > Do not print an error message if the regulator framework > returns EPROBE_DEFER. > > Signed-off-by: Yannick Fertré > --- >

Re: [PATCH 03/21] drm/fb_helper: set info->par in fill_info()

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > The fbdev emulation helpers pretty much assume that this is set. > Let's do it for everyone. > > Reviewed-by: Sam Ravnborg > Cc: Sam Ravnborg > Signed-off-by: Daniel Vetter > --- Reviewed-by: Noralf Trønnes

Re: [PATCH 07/21] drm/cirrus: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > Should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Gerd Hoffmann > --- > drivers/gpu/drm/cirrus/cirrus_drv.h | 2 +- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 8 +--- > 2 files changed, 2 insertions(+),

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #2 from Emil Velikov --- Some food for thought: The old autotools build did not have this problem since it: - was creating a static libigt library - yet ^^ would lead to slightly longer build times and overall larger bundle - ^^

Re: [PATCH 09/21] drm/gma500: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > This will change the fb name from "psbdrmfb" to "gma500drmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Patrik Jakobsson > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 Bug ID: 110249 Summary: IGT command line tools load redundant GUI libraries Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity:

Re: [PATCH] drm/doc: Drop "content type" from the legacy kms property table

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 12:59:20PM +0200, Ville Syrjälä wrote: > On Tue, Mar 26, 2019 at 10:05:55AM +0100, Daniel Vetter wrote: > > We want new stuff documented in more verbose form, this table is > > deprecated. "content type" is already documented properly. > > > > Fixes: 50525c332b55 ("drm:

Re: [PATCH 10/21] drm/hibmc: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > Should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: Junwei Zhang > Cc: Xinliang Liu > Cc: "Christian König" > Cc: Ajit Negi > Cc: Souptick Joarder > Cc: Daniel Vetter > Cc: John Garry >

X.Org GSoC 2019 - Student Application Period

2019-03-26 Thread Trevor Woerner
I'm happy to announce that the X.Org Foundation has been chosen to participate in this year's GSoC program! Students have from now until April 9th to submit their proposals. Students will be looking at https://www.x.org/wiki/SummerOfCodeIdeas/ and https://www.x.org/wiki/ToDo/ for ideas. Please

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This will change the fb name from "msm" to "msmdrmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freedesktop.org > --- Reviewed-by: Noralf Trønnes

Re: [PATCH] drm/stm: dw_mipi_dsi-stm: add sleep power management

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Acked-by: Philippe Cornu Philippe :-) On 3/21/19 9:13 AM, Yannick Fertré wrote: > Implements system sleep power management ops. > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 28 > 1

Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 3/21/19 9:04 AM, Yannick Fertré wrote: > Do not print an error message if the regulator framework > returns EPROBE_DEFER. > > Signed-off-by: Yannick Fertré > --- >

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 15.42, skrev Noralf Trønnes: > > > Den 26.03.2019 14.20, skrev Daniel Vetter: >> This will change the fb name from "msm" to "msmdrmfb". >> >> v2: Rebase >> >> Signed-off-by: Daniel Vetter >> Cc: Rob Clark >> Cc: linux-arm-...@vger.kernel.org >> Cc:

[PATCH 19/21] drm/udl: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This should not result in any changes. v2: Rebase Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Sean Paul Cc: Mikulas Patocka Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Emil Lundmark --- drivers/gpu/drm/udl/udl_fb.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH 20/21] drm/vboxvideo: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This should not result in any changes. v2: Rebase over vbox changes - vbox gained it's own line to fill fix.id. v3: Rebase Reviewed-by: Greg Kroah-Hartman (v2) Signed-off-by: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Hans de Goede Cc: Daniel Vetter Cc: Alexander Kapshuk Cc: Bartlomiej

[PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
Another driver that didn't set fbinfo->fix.id before. v2: Fix subject and rebase Acked-by: Thierry Reding Signed-off-by: Daniel Vetter Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This will set an fb name for the first time! v2: Rebase Reviewed-by: Heiko Stuebner Signed-off-by: Daniel Vetter Cc: Sandy Huang Cc: "Heiko Stübner" Cc: linux-arm-ker...@lists.infradead.org Cc: linux-rockc...@lists.infradead.org --- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +--- 1

[PATCH 10/21] drm/hibmc: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
Should not result in any changes. v2: Rebase Signed-off-by: Daniel Vetter Cc: Alex Deucher Cc: Junwei Zhang Cc: Xinliang Liu Cc: "Christian König" Cc: Ajit Negi Cc: Souptick Joarder Cc: Daniel Vetter Cc: John Garry --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 +-

[PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This will change the fb name from "msm" to "msmdrmfb". v2: Rebase Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org --- drivers/gpu/drm/msm/msm_fbdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 15/21] drm/omap: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This changes the fb name from "omapdrm" to "omapdrmfb". v2: Rebase Signed-off-by: Daniel Vetter Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c

[PATCH 16/21] drm/radeon: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This should not result in any changes. v2: Rebase Signed-off-by: Daniel Vetter Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_fb.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

[PATCH 14/21] drm/nouveau: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
This changes the fb name from "nouveaufb" to "nouveaudrmfb". Aside: I wonder whether the in_interrupt() check is good enough for the nouveau acceleration. Cargo-cult says drm_can_sleep() is needed, which isn't actually working if you pick a .config without PREEMPT. For the generic fbdev defio

[PATCH 21/21] drm/fb-helper: Unexport fill_{var,info}

2019-03-26 Thread Daniel Vetter
Not used by drivers anymore. v2: Rebase Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 38 + include/drm/drm_fb_helper.h | 4 2 files changed, 5 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c

[PATCH 12/21] drm/mga200g: Use drm_fb_helper_fill_info

2019-03-26 Thread Daniel Vetter
Should not result in any changes. v2: Rebase Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Alex Deucher Cc: "Christian König" Cc: Junwei Zhang Cc: Daniel Vetter --- drivers/gpu/drm/mgag200/mgag200_drv.h | 2 +- drivers/gpu/drm/mgag200/mgag200_fb.c | 8 +--- 2 files changed, 2

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Andrzej Hajda
On 26.03.2019 09:45, Inki Dae wrote: > Hi Andrzej, > > 19. 3. 25. 오후 4:13에 Andrzej Hajda 이(가) 쓴 글: >> Hi Inki, >> >> GSCALERs in Exynos SoCs support conversion between wide range of image >> formats, >> plus scaling and rotation. >> Driver already supports mem2mem mode - via ExynosDRM IPP

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #3 from Chris Wilson --- The autotools build doesn't have this problem because in there intel-gpu-top is not linked against libigt.la, as nothing outside of tests/ should be. It looks like a bit of carelessness introduced the extra

Re: [RFC][PATCH 00/11] DRM driver for fbdev devices

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 10:17:33AM +0100, Thomas Zimmermann wrote: > Hi, > > this RFC patch set implements fbdevdrm, a DRM driver on top of fbdev > drivers. I'd appreciate feedback on the code and the idea in general. > > The fbdev subsystem is considered legacy and will probably be removed at >

Re: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This will set an fb name for the first time! > > v2: Rebase > > Reviewed-by: Heiko Stuebner > Signed-off-by: Daniel Vetter > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: linux-arm-ker...@lists.infradead.org > Cc:

Re: [PATCH 16/21] drm/radeon: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: amd-...@lists.freedesktop.org > --- Acked-by: Noralf Trønnes

Re: [PATCH] drm/panel: otm8009a: add delay at the end of initialization

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Best regards, Philippe On 3/21/19 9:04 AM, Yannick Fertré wrote: > At the end of initialization, a delay is required by the panel. > Without this delay, the panel could received a frame early & >

Re: [PATCH 09/11] drm/fbdevdrm: Add primary plane

2019-03-26 Thread Thomas Zimmermann
Hi Am 26.03.19 um 14:33 schrieb Mathieu Malaterre: > A simple compile/test here leads to: > > ... > ../drivers/gpu/drm/fbdevdrm/fbdevdrm_modes.c:174:2: note: in expansion > of macro 'do_div' > do_div(width, cpp); > ^~ > In file included from

  1   2   3   >