Re: [PATCH 32/59] drm/tve2000: Drop drm_gem_prime_export/import

2019-06-15 Thread Linus Walleij
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by: Linus Walleij When you write "Would be really nice to switch

Re: [PATCH 32/59] drm/tve2000: Drop drm_gem_prime_export/import

2019-06-15 Thread Daniel Vetter
On Sat, Jun 15, 2019 at 10:35 AM Linus Walleij wrote: > > On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote: > > > They're the default. > > > > Aside: Would be really nice to switch the others over to > > drm_gem_object_funcs. > > > > Signed-off-by: Daniel Vetter > > Cc: Linus Walleij > >

Re: [PATCH v4 05/12] drm/modes: Rewrite the command line parser

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > From: Maxime Ripard > > Rewrite the command line parser in order to get away from the state machine > parsing the video mode lines. > > Hopefully, this will allow to extend it more easily to support named modes > and / or properties set directly on

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #46 from Richard Thier --- (In reply to Marek Olšák from comment #45) > The problem might be in the kernel. See function rs400_gpu_init. I think it > should call r300_gpu_init instead of r420_pipes_init. I will put some logging

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

2019-06-15 Thread Daniel Vetter
On Fri, Jun 14, 2019 at 10:30 PM Daniel Vetter wrote: > > On Fri, Jun 14, 2019 at 08:51:11PM +0200, Christian König wrote: > > Am 14.06.19 um 20:24 schrieb Daniel Vetter: > > > > > > On Fri, Jun 14, 2019 at 8:10 PM Christian König > > > wrote: > > > > [SNIP] > > > > WW_MUTEX_LOCK_BEGIN() > > >

[Bug 202657] amdgpu.dc=0 coupled with amdgpu.audio=0 causes fullscreen flickering with dvi-d to vga monitor setup (Polaris)

2019-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202657 siyia (eutychio...@gmail.com) changed: What|Removed |Added Severity|normal |enhancement -- You are

Re: [PATCH 18/59] drm/mcde: Drop drm_gem_prime_export/import

2019-06-15 Thread Linus Walleij
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 43/59] drm/lima: Drop resv argument from lima_bo_create_struct

2019-06-15 Thread Qiang Yu
Looks good for me, patch is: Reviewed-by: Qiang Yu Regards, Qiang On Sat, Jun 15, 2019 at 4:37 AM Daniel Vetter wrote: > > It was only used for prime import, which is now handled by > drm_prime.c. > > Signed-off-by: Daniel Vetter > Cc: Qiang Yu > Cc: l...@lists.freedesktop.org > --- >

Re: [PATCH 03/59] drm/prime: Update docs

2019-06-15 Thread Sam Ravnborg
Hi Daniel Better and more consistent docs - good! With relevant comments addressed: Reviewed-by: Sam Ravnborg > +/** > + * DOC: overview and lifetime rules > + * > + * Similar to GEM global names, PRIME file descriptors are also used to share > + * buffer objects across processes. They offer

Re: [PATCH v4 12/12] drm/vc4: hdmi: Set default state margin at reset

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > Now that the TV margins are properly parsed and filled into > drm_cmdline_mode, we just need to initialise the first state at reset to > get those values and start using them. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Noralf Trønnes

Re: [PATCH 58/59] drm/todo: Add new debugfs todo

2019-06-15 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > Greg is busy already, but maybe he won't do everything ... > > Cc: Greg Kroah-Hartman > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Greg Kroah-Hartman

Re: [PATCH v4 04/12] drm/client: Change drm_client_panel_rotation name

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > The drm_client_panel_rotation function has been used so far to set the > default rotation based on the panel orientation. > > However, we can have more sources of information to make that decision, > starting with the command line that we will

Re: [PATCH v4 08/12] drm/connector: Introduce a TV margins structure

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > The TV margins has been defined as a structure inside the > drm_connector_state structure so far. However, we will need it in other > structures as well, so let's move that structure definition so that it can > be reused. > > Signed-off-by: Maxime

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > The drm_client_modeset_commit_atomic function uses two times the > plane_state variable in inner blocks of code, but the variable has a scope > global to this function. > > This will lead to inadvertent devs to reuse the variable in the second >

Re: [PATCH v4 01/12] drm/connector: Add documentation for drm_cmdline_mode

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > The struct drm_cmdline_mode holds the result of the command line parsers. > However, it wasn't documented so far, so let's do that. > > Signed-off-by: Maxime Ripard > --- > include/drm/drm_connector.h | 86 +- >

Re: [PATCH] drm/bridge: dw-hdmi: Use automatic CTS generation mode when using non-AHB audio

2019-06-15 Thread Jernej Škrabec
Dne sreda, 12. junij 2019 ob 10:51:47 CEST je Neil Armstrong napisal(a): > When using an I2S source using a different clock source (usually the I2S > audio HW uses dedicated PLLs, different from the HDMI PHY PLL), fixed > CTS values will cause some frequent audio drop-out and glitches as >

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #51 from moregin...@warpmail.net --- Also cannot boot without nomodeset or modprobe.blacklist=amdgpu. With the latter, I get a black screen if I run `modprobe amdgpu`. I have Ryzen 2400G. The trick with moving raven_dmcu.bin (as

[Bug 203679] Revert 8059add0478e29cb641936011a8fcc9ce9fd80be for stable 5.1.x

2019-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203679 Dmitry (nrn...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #48 from Richard Thier --- Btw I saw that mesa codes handle my RC410 as one having RV350 (is_rv350 is true), but unlike R400 family chip. I have no idea if that is right, but if the kernel part do differently than the userland part

Re: [PATCH v4 09/12] drm/atomic: Add a function to reset connector TV properties

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > During the connector reset, if that connector has a TV property, it needs > to be reset to the value provided on the command line. > > Provide a helper to do that. > > Signed-off-by: Maxime Ripard > --- This patch uses drm_cmdline_mode->tv_margins

Re: [PATCH v4 03/12] drm/client: Restrict the rotation check to the rotation itself

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > The drm_client_rotation has a check on the rotation value, but the > reflections are also stored in the same variable, and the check doesn't > take this into account. > > Therefore, even though we might have a valid rotation, if we're also using > a

[Bug 110924] Alien: Isolation - Flashing squares in upper half of screen when HDAO enabled

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110924 Bug ID: 110924 Summary: Alien: Isolation - Flashing squares in upper half of screen when HDAO enabled Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [PATCH v4 10/12] drm/modes: Parse overscan properties

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > Properly configuring the overscan properties might be needed for the > initial setup of the framebuffer for display that still have overscan. > Let's allow for more properties on the kernel command line to setup each > margin. This also needs to be

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #38 from Tom B --- Created attachment 144554 --> https://bugs.freedesktop.org/attachment.cgi?id=144554=edit 5.1.9 dmesg -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

2019-06-15 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 07:32:28PM -0700, Shobhit Kukreti wrote: > Cleaned up code to resolve the checkpatch error > ERROR: space prohibited before that close parenthesis ')' > from the file: > > fbtft/fbtft-bus.c > > Signed-off-by: Shobhit Kukreti > --- > drivers/staging/fbtft/fbtft-bus.c |

Re: [PATCH] staging: android: fix style problem

2019-06-15 Thread Greg KH
On Sat, Jun 15, 2019 at 01:11:56AM +0530, Saiyam Doshi wrote: > checkpatch reported "WARNING: line over 80 characters". This > patch fixes it by aligning function arguments. > > Signed-off-by: Saiyam Doshi > --- > drivers/staging/android/ion/ion_chunk_heap.c | 4 +++- > 1 file changed, 3

[Bug 110795] Unable to install on latest Ubuntu (19.04)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110795 --- Comment #22 from Andrew Shark --- Created attachment 144555 --> https://bugs.freedesktop.org/attachment.cgi?id=144555=edit Script to modify packages to be able to use with ubuntu 19.04 Now script automatically installs all pro components

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #49 from Richard Thier --- Hmmm. There are a lot of FIXMEs in the kernel at this part saying things are not pretty sure. I think I am running into an other code path I should be taking, but if this was always like this then maybe

[Bug 104437] RX480 + SME = amdgpu init failed + null dereference

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104437 --- Comment #1 from Nick Sarnie --- Created attachment 144553 --> https://bugs.freedesktop.org/attachment.cgi?id=144553=edit dmesg_sme.txt Same issue using 5.1.9, RX Vega 64 and Ryzen 2700x. [ 19.998488] [drm:amdgpu_device_init.cold

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #37 from Tom B --- 5.1.9 makes this bug even worse. It now crashes as soon as the display server is started. Running sensors now gives an error: ERROR: Can't get value of subfeature fan1_input: I/O error ERROR: Can't get value of

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #51 from Richard Thier --- (In reply to cosiekvfj from comment #17) >*-display > description: VGA compatible controller > product: RC410M [Mobility Radeon Xpress 200M] >

Re: dev_pagemap related cleanups

2019-06-15 Thread Dan Williams
On Sat, Jun 15, 2019 at 1:34 AM Christoph Hellwig wrote: > > On Fri, Jun 14, 2019 at 06:14:45PM -0700, Dan Williams wrote: > > On Thu, Jun 13, 2019 at 11:14 PM Christoph Hellwig wrote: > > > > > > On Thu, Jun 13, 2019 at 11:27:39AM -0700, Dan Williams wrote: > > > > It also turns out the nvdimm

Re: [PATCH v1] staging: android: fix style problem

2019-06-15 Thread Greg KH
On Sun, Jun 16, 2019 at 12:16:05AM +0530, Saiyam Doshi wrote: > checkpatch reported "WARNING: line over 80 characters". > This patch fixes it by aligning function arguments. > > Signed-off-by: Saiyam Doshi > --- > Changes in v1: > * Updated as per review comment. Now function arguments > uses

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #50 from Richard Thier --- " Also there is this "RS400" asic listed in the above switch case and it is still an other candidate maybe but surely not the rs400_asic. " I mean my card should be surely not rs420_asic. The rs_400 I

[Bug 110795] Unable to install on latest Ubuntu (19.04)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110795 Andrew Shark changed: What|Removed |Added Attachment #144539|0 |1 is obsolete|

[PATCH v1] staging: android: fix style problem

2019-06-15 Thread Saiyam Doshi
checkpatch reported "WARNING: line over 80 characters". This patch fixes it by aligning function arguments. Signed-off-by: Saiyam Doshi --- Changes in v1: * Updated as per review comment. Now function arguments uses two lines, one less line than previous submission.

[Bug 203905] New: amdgpu:actual_brightness has unreal/wrong value

2019-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 Bug ID: 203905 Summary: amdgpu:actual_brightness has unreal/wrong value Product: Drivers Version: 2.5 Kernel Version: 5.1.9 Hardware: All OS: Linux Tree:

Re: [linux-sunxi] [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-15 Thread Chen-Yu Tsai
On Sat, Jun 15, 2019 at 12:44 AM Jagan Teki wrote: > > TCON TOP have clock gates for TV0, TV1, dsi and right > now these are register during bind call. > > Of which, dsi clock gate would required during DPHY probe > but same can miss to get since tcon top is not bound at > that time. > > To

[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #5 from Owen --- Hi, I believe I am experiencing the same issue, what can I do to help fix it? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel

Re: [PATCH v4 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > Rotations and reflections setup are needed in some scenarios to initialise > properly the initial framebuffer. Some drivers already had a bunch of > quirks to deal with this, such as either a private kernel command line > parameter (omapdss) or on the

[Bug 110866] Revert 8059add0478e29cb641936011a8fcc9ce9fd80be for stable 5.1.x

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110866 Dmitry Derevyanko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #47 from Richard Thier --- Created attachment 144552 --> https://bugs.freedesktop.org/attachment.cgi?id=144552=edit grepping around init functions in kernel / drm Hmmm... I see that this got printed out in dmesg: [ 17.669902]

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #53 from Dieter Nützel --- (In reply to Richard Thier from comment #52) > (In reply to Marek Olšák from comment #45) > > The problem might be in the kernel. See function rs400_gpu_init. I think it > > should call r300_gpu_init

Re: [RESEND PATCH v2 1/2] drm/dp/mst: Reprobe EDID for MST ports on resume

2019-06-15 Thread Sasha Levin
On Fri, Jun 14, 2019 at 06:10:20PM -0400, Lyude Paul wrote: uh, Sasha not sure if you're a bot or not but this patch isn't even upstream This is indeed a bot, and that's indeed it's purpose :) We tend to get less responses if we wait for weeks for a patch to get upstream and queued for

[Bug 110671] Regression: DP outputs out of sync on dual-DP tiled 5k screen

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110671 --- Comment #8 from Denys --- Still no luck with 5.1.10 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #52 from Richard Thier --- (In reply to Marek Olšák from comment #45) > The problem might be in the kernel. See function rs400_gpu_init. I think it > should call r300_gpu_init instead of r420_pipes_init. Aaaah Am I this

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #39 from Chris Hodapp --- The fact that amdgpu is getting less functional over time with this high-end part _is_ definitely annoying, but let's all keep in mind that this is not an official support channel from AMD, it's the issue

Re: [PATCH 27/59] drm/rockchip: Drop drm_gem_prime_export/import

2019-06-15 Thread Heiko Stuebner
Am Freitag, 14. Juni 2019, 22:35:43 CEST schrieb Daniel Vetter: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: linux-arm-ker...@lists.infradead.org > Cc: