Controllers with several interface options - one or more drivers?

2019-07-26 Thread Sam Ravnborg
Hi Josef, Daniel et al. The driver that triggered this reply is a driver that adds parallel support to ili9341 in a dedicated panel driver. The issue here is that we already have a tiny driver that supports the ili9341 controller - but with a slightly different configuration. The ili9341

Re: [PATCH v2] drm/panel: check failure cases in the probe func

2019-07-26 Thread Sam Ravnborg
Hi Navid. On Wed, Jul 24, 2019 at 02:55:34PM -0500, Navid Emamdoost wrote: > The following function calls may fail and return NULL, so the null check > is added. > of_graph_get_next_endpoint > of_graph_get_remote_port_parent > of_graph_get_remote_port > > Update: Thanks to Sam Ravnborg, for

Re: [PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

2019-07-26 Thread Sam Ravnborg
Hi Jeffrey. On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote: > The Lenovo Miix 630 laptop can be found with one of two panels - a BOE > or Sharp option. This likely provides options during manufacturing. > > These panels connect via eDP, however they sit behind a DSI to eDP >

Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

2019-07-26 Thread Daniel Thompson
On Fri, Jul 26, 2019 at 01:27:25PM +0200, Sam Ravnborg wrote: > Hi Daniel. > > On Fri, Jul 26, 2019 at 10:50:16AM +0100, Daniel Thompson wrote: > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > >

Re: [PATCH] drm/komeda: Adds internal bpp computing for arm afbc only format YU08 YU10

2019-07-26 Thread Liviu Dudau
Hi Lowry, On Fri, Jul 26, 2019 at 07:51:02AM +, Lowry Li (Arm Technology China) wrote: > The drm_format_info doesn't have any cpp or block_size (both are zero) > information for arm only afbc format YU08/YU10. we need to compute it > by ourselves. > > Signed-off-by: Lowry Li (Arm Technology

[PATCH v2 4/4] drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently

2019-07-26 Thread Guido Günther
We were already using the generic functions in our debugfs code, do the same in jh057n_shutdown. This was suggested by Sam Ravnborg. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare

2019-07-26 Thread Guido Günther
If the panel is wrapped in a panel_bridge it gets prepar()ed before the upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks are not enabled yet). To avoid this move the panel's first DSI access to enable() so the upstream bridge can prepare the DSI host controller in it's

[PATCH v2 1/4] drm/panel: jh057n00900: Move panel DSI init to enable()

2019-07-26 Thread Guido Günther
If the panel is wrapped in a panel_bridge it gets prepar()ed before the upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks are not enabled yet). To avoid this move the panel's first DSI access to enable() so the upstream bridge can prepare the DSI host controller in it's

[PATCH v2 2/4] drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()

2019-07-26 Thread Guido Günther
This makes it symmetric with the panel init happening in enable(). Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c

[PATCH v2 3/4] drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s

2019-07-26 Thread Guido Günther
Most of them had these already but two mere missing. This eases debugging. Signed-off-by: Guido Günther Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v7 2/4] drm/panel: set display info in panel attach

2019-07-26 Thread Sam Ravnborg
Hi Derek. On Wed, Jul 24, 2019 at 03:15:19PM -0700, dbasehore . wrote: > Hi Sam, thanks for pointing out the potential conflict. > > On Tue, Jul 23, 2019 at 2:19 AM Sam Ravnborg wrote: > > > > Hi Derek. > > > > On Tue, Jul 09, 2019 at 07:16:57PM -0700, Derek Basehore wrote: > > > Devicetree

Re: [PATCH] drm/komeda: Initialize and enable output polling on Komeda

2019-07-26 Thread Liviu Dudau
On Fri, Jul 26, 2019 at 08:00:29AM +, Lowry Li (Arm Technology China) wrote: > Initialize and enable output polling on Komeda. > > Signed-off-by: Lowry Li (Arm Technology China) > --- > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [PATCH 0/3] drm/panel: jh057n00900: Move dsi init sequence to prepare

2019-07-26 Thread Guido Günther
Hi Sam, On Fri, Jul 26, 2019 at 12:25:29PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Fri, Jul 26, 2019 at 11:21:40AM +0200, Guido Günther wrote: > > If the panel is wrapped in a panel_bridge it gets prepar()ed before the > > upstream DSI bridge which can cause hangs (e.g. with imx-nwl since

Re: [PATCH 06/60] drm/bridge: simple-bridge: Add support for enable GPIO

2019-07-26 Thread Stefan Agner
On 2019-07-07 20:18, Laurent Pinchart wrote: > If an enable GPIO is declared in the firmware, assert it when enabling > the bridge and deassert it when disabling it. > > Signed-off-by: Laurent Pinchart This also comes in handy for the ADV7123, which has a power save pin. Looks good to me.

Patch "dma-buf: balance refcount inbalance" has been added to the 5.2-stable tree

2019-07-26 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf: balance refcount inbalance to the 5.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "dma-buf: balance refcount inbalance" has been added to the 4.14-stable tree

2019-07-26 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf: balance refcount inbalance to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "dma-buf: balance refcount inbalance" has been added to the 5.1-stable tree

2019-07-26 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf: balance refcount inbalance to the 5.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH 05/60] drm/bridge: simple-bridge: Add support for non-VGA bridges

2019-07-26 Thread Stefan Agner
On 2019-07-07 20:18, Laurent Pinchart wrote: > Create a new simple_bridge_info structure that stores information about > the bridge model, and store the bridge timings in there, along with the > connector type. Use that new structure for of_device_id data. This > enables support for non-VGA

Patch "dma-buf: balance refcount inbalance" has been added to the 4.19-stable tree

2019-07-26 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf: balance refcount inbalance to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH RESEND] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-26 Thread Rob Herring
On Wed, Jul 24, 2019 at 9:53 PM Yue Hu wrote: > > From: Yue Hu > > Since governor name is defined by DEVFREQ framework internally, use the > macro definition instead of using the name directly. > > Signed-off-by: Yue Hu > --- > drivers/gpu/drm/msm/msm_gpu.c | 3 ++- >

Re: [PATCH 1/7] docs: fix broken doc references due to renames

2019-07-26 Thread Rob Herring
On Fri, Jul 26, 2019 at 5:47 AM Mauro Carvalho Chehab wrote: > > Some files got renamed but probably due to some merge conflicts, > a few references still point to the old locations. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Wolfram Sang # I2C part > Reviewed-by: Jerry Hoemann #

[PATCH AUTOSEL 5.2 85/85] drm/nouveau/dmem: missing mutex_lock in error path

2019-07-26 Thread Sasha Levin
From: Ralph Campbell [ Upstream commit d304654bd79332ace9ac46b9a3d8de60acb15da3 ] In nouveau_dmem_pages_alloc(), the drm->dmem->mutex is unlocked before calling nouveau_dmem_chunk_alloc() as shown when CONFIG_PROVE_LOCKING is enabled: [ 1294.871933] = [

[PATCH AUTOSEL 4.19 47/47] drm/nouveau: fix memory leak in nouveau_conn_reset()

2019-07-26 Thread Sasha Levin
From: Yongxin Liu [ Upstream commit 09b90e2fe35faeace2488234e2a7728f2ea8ba26 ] In nouveau_conn_reset(), if connector->state is true, __drm_atomic_helper_connector_destroy_state() will be called, but the memory pointed by asyc isn't freed. Memory leak happens in the following function

[PATCH AUTOSEL 4.14 37/37] drm/nouveau: fix memory leak in nouveau_conn_reset()

2019-07-26 Thread Sasha Levin
From: Yongxin Liu [ Upstream commit 09b90e2fe35faeace2488234e2a7728f2ea8ba26 ] In nouveau_conn_reset(), if connector->state is true, __drm_atomic_helper_connector_destroy_state() will be called, but the memory pointed by asyc isn't freed. Memory leak happens in the following function

[PATCH AUTOSEL 5.2 83/85] drm/nouveau: fix memory leak in nouveau_conn_reset()

2019-07-26 Thread Sasha Levin
From: Yongxin Liu [ Upstream commit 09b90e2fe35faeace2488234e2a7728f2ea8ba26 ] In nouveau_conn_reset(), if connector->state is true, __drm_atomic_helper_connector_destroy_state() will be called, but the memory pointed by asyc isn't freed. Memory leak happens in the following function

[PATCH AUTOSEL 5.2 40/85] drm/amd/display: Expose audio inst from DC to DM

2019-07-26 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 5fdb7c4c7f2691efd760b0b0dc00da4a3699f1a6 ] [Why] In order to give pin notifications to the sound driver from DM we need to know whether audio is enabled on a stream and what pin it's using from DC. [How] Expose the instance via stream status if it's

[Bug 111227] Mesa trunk 3.9

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111227 Bug ID: 111227 Summary: Mesa trunk 3.9 Product: Mesa Version: 19.0 Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Bug 111211] Kernel 5.2.2 introduced tearing, corruption and freezes with Raven Ridge 2500U

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111211 --- Comment #2 from Bráulio Barros de Oliveira --- Created attachment 144871 --> https://bugs.freedesktop.org/attachment.cgi?id=144871=edit dmesg dmesg attached, see amdgpu stacktrace in it -- You are receiving this mail because: You are

[Bug 111211] Kernel 5.2.2 introduced tearing, corruption and freezes with Raven Ridge 2500U

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111211 --- Comment #3 from Bráulio Barros de Oliveira --- Created attachment 144872 --> https://bugs.freedesktop.org/attachment.cgi?id=144872=edit Xorg.0.log -- You are receiving this mail because: You are the assignee for the

[Bug 111211] Kernel 5.2.2 introduced tearing, corruption and freezes with Raven Ridge 2500U

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111211 --- Comment #4 from Bráulio Barros de Oliveira --- I'm using latest KDE from Archlinux BTW, Kernel 5.2.1 was fine -- You are receiving this mail because: You are the assignee for the bug.___

[PATCH] drm/mst: Fix sphinx warnings in drm_dp_msg_connector register functions

2019-07-26 Thread Sean Paul
From: Sean Paul Fixes the following warnings: ../drivers/gpu/drm/drm_dp_mst_topology.c:1593: warning: Excess function parameter 'drm_connector' description in 'drm_dp_mst_connector_late_register' ../drivers/gpu/drm/drm_dp_mst_topology.c:1613: warning: Excess function parameter 'drm_connector'

Re: [PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

2019-07-26 Thread Jeffrey Hugo
On Fri, Jul 26, 2019 at 6:36 AM Sam Ravnborg wrote: > > Hi Jeffrey. > > On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote: > > The Lenovo Miix 630 laptop can be found with one of two panels - a BOE > > or Sharp option. This likely provides options during manufacturing. > > > > These

Re: [PATCH] drm/tegra: return with probe defer if GPIO subsystem is not ready

2019-07-26 Thread Dmitry Osipenko
26.07.2019 17:23, Stefan Agner пишет: > Hi Thierry, Hi Dave, > > On 2018-09-07 01:31, Stefan Agner wrote: >> On 26.07.2018 06:36, Stefan Agner wrote: >>> If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER >>> instead of silently continuing without HPD. >>> >>> Reported-by:

Re: [PATCH] drm/tegra: return with probe defer if GPIO subsystem is not ready

2019-07-26 Thread Dmitry Osipenko
26.07.2019 17:57, Stefan Agner пишет: > On 2019-07-26 16:46, Dmitry Osipenko wrote: >> 26.07.2019 17:23, Stefan Agner пишет: >>> Hi Thierry, Hi Dave, >>> >>> On 2018-09-07 01:31, Stefan Agner wrote: On 26.07.2018 06:36, Stefan Agner wrote: > If the GPIO subsystem is not ready make sure to

[PATCH 4.19 36/50] dma-buf: balance refcount inbalance

2019-07-26 Thread Greg Kroah-Hartman
From: Jérôme Glisse commit 5e383a9798990c69fc759a4930de224bb497e62c upstream. The debugfs take reference on fence without dropping them. Signed-off-by: Jérôme Glisse Cc: Christian König Cc: Daniel Vetter Cc: Sumit Semwal Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org

Re: [PATCH] video: Demote panel timing not found error message

2019-07-26 Thread Sam Ravnborg
Hi Bartlomiej Zolnierkiewicz > > Hi Sam, > > On 7/26/19 1:36 PM, Sam Ravnborg wrote: > > Hi Thierry. > > > > On Fri, Jul 26, 2019 at 12:18:49PM +0200, Thierry Reding wrote: > >> From: Thierry Reding > >> > >> Failing to find a panel-timing node is not an error in all cases, so do > >> not

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #22 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- Thanks for the log! I can reproduce the issue now by emulating the sequence using IGT. It doesn't seem to show up in desktop usage for me. -- You are receiving this

Re: Controllers with several interface options - one or more drivers?

2019-07-26 Thread Sam Ravnborg
Hi Daniel. Added Noralf - somehow I missed him on the original mail. On Fri, Jul 26, 2019 at 05:06:03PM +0200, Daniel Vetter wrote: > Also probably should add a few more (drm_bridge) people, I think > that's also somewhat relevant here. > -Daniel > > On Fri, Jul 26, 2019 at 4:55 PM Daniel

Re: [PATCH v2] drm: Set crc->opened to false before setting crc source to NULL.

2019-07-26 Thread Kazlauskas, Nicholas
On 7/26/19 12:02 PM, David (Dingchen) Zhang wrote: > From: Dingchen Zhang > > to terminate the while-loop in drm_dp_aux_crc_work when > drm_dp_start/stop_crc are called in the hook to set crc source. > > v2: Move spin_lock around entire crc->opened use (Daniel) > > Cc: Daniel Vetter > Cc:

Re: [PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-26 Thread Mark Brown
On Tue, Jul 23, 2019 at 11:18:33PM +0100, Suzuki K Poulose wrote: > Introduce wrappers for {bus/driver/class}_find_device() to > locate devices by its of_node. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] drm/tegra: return with probe defer if GPIO subsystem is not ready

2019-07-26 Thread Stefan Agner
Hi Thierry, Hi Dave, On 2018-09-07 01:31, Stefan Agner wrote: > On 26.07.2018 06:36, Stefan Agner wrote: >> If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER >> instead of silently continuing without HPD. >> >> Reported-by: Marcel Ziswiler >> Signed-off-by: Stefan Agner > >

[Bug 109073] AMDGPU Radeon RX540 system freezes and/or crashes; poor performance with ac adapter plugged in

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109073 Utku Helvacı (tuxutku) changed: What|Removed |Added Resolution|--- |WORKSFORME

Re: [PATCH] drm/komeda: Skips the invalid writeback job

2019-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2019 at 4:44 PM Brian Starkey wrote: > > On Fri, Jul 26, 2019 at 04:23:56PM +0200, Daniel Vetter wrote: > > On Fri, Jul 26, 2019 at 08:13:00AM +, Lowry Li (Arm Technology China) > > wrote: > > > Current DRM-CORE accepts the writeback_job with a empty fb, but that > > > is an

[PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- 1 file changed, 106 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c

[PATCH 5.2 47/66] dma-buf: balance refcount inbalance

2019-07-26 Thread Greg Kroah-Hartman
From: Jérôme Glisse commit 5e383a9798990c69fc759a4930de224bb497e62c upstream. The debugfs take reference on fence without dropping them. Signed-off-by: Jérôme Glisse Cc: Christian König Cc: Daniel Vetter Cc: Sumit Semwal Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org

[PATCH 5.1 43/62] dma-buf: balance refcount inbalance

2019-07-26 Thread Greg Kroah-Hartman
From: Jérôme Glisse commit 5e383a9798990c69fc759a4930de224bb497e62c upstream. The debugfs take reference on fence without dropping them. Signed-off-by: Jérôme Glisse Cc: Christian König Cc: Daniel Vetter Cc: Sumit Semwal Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org

[PATCH v2] drm: Set crc->opened to false before setting crc source to NULL.

2019-07-26 Thread David (Dingchen) Zhang
From: Dingchen Zhang to terminate the while-loop in drm_dp_aux_crc_work when drm_dp_start/stop_crc are called in the hook to set crc source. v2: Move spin_lock around entire crc->opened use (Daniel) Cc: Daniel Vetter Cc: Harry Wentland Cc: Nick Kazlauskas Signed-off-by: Dingchen Zhang ---

Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

2019-07-26 Thread Bartlomiej Zolnierkiewicz
On 7/25/19 4:32 PM, Sam Ravnborg wrote: > There was no users left - so drop the code to support EARLY_FB_BLANK. > This patch removes the support in backlight, > and drop the notifier in fbmem. > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > >

Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

2019-07-26 Thread Sam Ravnborg
Hi Lee. On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > This patch removes the support in

[Bug 204331] New: amdgpu audio parameter not functional

2019-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204331 Bug ID: 204331 Summary: amdgpu audio parameter not functional Product: Drivers Version: 2.5 Kernel Version: 5.2.2 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH v2 2/7] mm/hmm: a few more C style and comment clean ups

2019-07-26 Thread Ralph Campbell
On 7/25/19 11:23 PM, Christoph Hellwig wrote: Note: it seems like you've only CCed me on patches 2-7, but not on the cover letter and patch 1. I'll try to find them later, but to make Ccs useful they should normally cover the whole series. Otherwise this looks fine to me: Reviewed-by:

Re: [PATCH] drm/mst: Fix sphinx warnings in drm_dp_msg_connector register functions

2019-07-26 Thread Lyude Paul
lgtm Reviewed-by: Lyude Paul On Fri, 2019-07-26 at 10:20 -0400, Sean Paul wrote: > From: Sean Paul > > Fixes the following warnings: > > ../drivers/gpu/drm/drm_dp_mst_topology.c:1593: warning: Excess function > parameter 'drm_connector' description in > 'drm_dp_mst_connector_late_register' >

Re: [PATCH v2 6/7] drm/panfrost: Add support for GPU heap allocations

2019-07-26 Thread Rob Herring
On Fri, Jul 26, 2019 at 3:15 AM Steven Price wrote: > > On 25/07/2019 22:11, Rob Herring wrote: > > On Thu, Jul 25, 2019 at 7:08 AM Robin Murphy wrote: > >> > >> Hi Rob, > >> > >> On 25/07/2019 02:10, Rob Herring wrote: > >> [...] > >>> @@ -328,6 +427,18 @@ static irqreturn_t

[PATCH v6 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index

[PATCH v6 08/24] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index

[PATCH v6 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

[PATCH v6 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c

Re: [PATCH] drm/komeda: Skips the invalid writeback job

2019-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2019 at 08:13:00AM +, Lowry Li (Arm Technology China) wrote: > Current DRM-CORE accepts the writeback_job with a empty fb, but that > is an invalid job for HW, so need to skip it when commit it to HW. > > Signed-off-by: Lowry Li (Arm Technology China) Hm, this sounds a bit

Re: [PATCH] video: Demote panel timing not found error message

2019-07-26 Thread Bartlomiej Zolnierkiewicz
Hi Sam, On 7/26/19 1:36 PM, Sam Ravnborg wrote: > Hi Thierry. > > On Fri, Jul 26, 2019 at 12:18:49PM +0200, Thierry Reding wrote: >> From: Thierry Reding >> >> Failing to find a panel-timing node is not an error in all cases, so do >> not output an error message in that case. Instead turn it

Re: [PATCH] drm/tegra: return with probe defer if GPIO subsystem is not ready

2019-07-26 Thread Stefan Agner
On 2019-07-26 16:46, Dmitry Osipenko wrote: > 26.07.2019 17:23, Stefan Agner пишет: >> Hi Thierry, Hi Dave, >> >> On 2018-09-07 01:31, Stefan Agner wrote: >>> On 26.07.2018 06:36, Stefan Agner wrote: If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER instead of silently

Re: Controllers with several interface options - one or more drivers?

2019-07-26 Thread Daniel Vetter
Also probably should add a few more (drm_bridge) people, I think that's also somewhat relevant here. -Daniel On Fri, Jul 26, 2019 at 4:55 PM Daniel Vetter wrote: > > On Fri, Jul 26, 2019 at 02:25:10PM +0200, Sam Ravnborg wrote: > > Hi Josef, Daniel et al. > > > > The driver that triggered this

[Bug 111077] link_shader and deserialize_glsl_program suddenly consume huge amount of RAM

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111077 --- Comment #14 from Matt Turner --- (In reply to rol...@rptd.ch from comment #13) > I checked out the 18.2 branch which I assume should work (if the theory is > correct). > > Modifying files won't work with bisecting, right? You'll probably

[PATCH v6 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c

[PATCH v6 00/24] Associate ddc adapters with connectors

2019-07-26 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42

[PATCH v6 03/24] drm/exynos: Provide ddc symlink in connector's sysfs

2019-07-26 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index

[PATCH v6 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-26 Thread Andrzej Pietrasiewicz
Allow passing ddc adapter pointer to the init function. Even if drm_connector_init() sometime in the future decides to e.g. memset() all connector fields to zeros, the newly added function ensures that at its completion the ddc member of connector is correctly set. Signed-off-by: Andrzej

[PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector

2019-07-26 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This

[PATCH v6 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c

[PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index

[PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index

[PATCH v6 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH v6 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index

[PATCH v6 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH v6 24/24] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c

[PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 ++- 1 file changed, 70 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

[Bug 204331] amdgpu audio parameter not functional

2019-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204331 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH] drm/komeda: Skips the invalid writeback job

2019-07-26 Thread Brian Starkey
On Fri, Jul 26, 2019 at 04:23:56PM +0200, Daniel Vetter wrote: > On Fri, Jul 26, 2019 at 08:13:00AM +, Lowry Li (Arm Technology China) > wrote: > > Current DRM-CORE accepts the writeback_job with a empty fb, but that > > is an invalid job for HW, so need to skip it when commit it to HW. > > >

Re: Controllers with several interface options - one or more drivers?

2019-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2019 at 02:25:10PM +0200, Sam Ravnborg wrote: > Hi Josef, Daniel et al. > > The driver that triggered this reply is a driver that adds parallel > support to ili9341 in a dedicated panel driver. > The issue here is that we already have a tiny driver that supports the > ili9341

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-07-26 Thread David Zhang
On 2019-06-21 11:46 a.m., Daniel Vetter wrote: > On Fri, Jun 21, 2019 at 02:21:43PM +, Harry Wentland wrote: >> On 2019-06-05 1:06 p.m., Dingchen Zhang wrote: >>> to terminate the while-loop in drm_dp_aux_crc_work when >>> drm_dp_start/stop_crc >>> are called in the hook to set crc source.

Re: [PATCH] video: Demote panel timing not found error message

2019-07-26 Thread Bartlomiej Zolnierkiewicz
On 7/26/19 5:32 PM, Sam Ravnborg wrote: > Hi Bartlomiej Zolnierkiewicz >> >> Hi Sam, >> >> On 7/26/19 1:36 PM, Sam Ravnborg wrote: >>> Hi Thierry. >>> >>> On Fri, Jul 26, 2019 at 12:18:49PM +0200, Thierry Reding wrote: From: Thierry Reding Failing to find a panel-timing node is

[Bug 111211] Kernel 5.2.2 introduced tearing, corruption and freezes with Raven Ridge 2500U

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111211 Michel Dänzer changed: What|Removed |Added Attachment #144871|text/x-log |text/plain mime type|

[Bug 110719] Crash in radeonsi_drv_video.so when attempting to convert rgb video data

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110719 Scott Moreau changed: What|Removed |Added Summary|Crash in|Crash in

Re: [PATCH v6 00/24] Associate ddc adapters with connectors

2019-07-26 Thread Sam Ravnborg
Hi Andezej. On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > >

Re: [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare

2019-07-26 Thread Sam Ravnborg
Hi Guido. On Fri, Jul 26, 2019 at 03:14:35PM +0200, Guido Günther wrote: > > If the panel is wrapped in a panel_bridge it gets prepar()ed before the > upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks > are not enabled yet). To avoid this move the panel's first DSI access

Re: [PATCH 05/11] video/fbdev: Drop JZ4740 driver

2019-07-26 Thread Sam Ravnborg
Hi Paul. On Thu, Jul 25, 2019 at 06:02:09PM -0400, Paul Cercueil wrote: > The JZ4740 fbdev driver has been replaced with the ingenic-drm driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > --- > drivers/video/fbdev/Kconfig | 9 - > drivers/video/fbdev/Makefile| 1 -

Re: [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:29 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- > 1 file changed, 106

[PULL] drm-fixes

2019-07-26 Thread Daniel Vetter
Hi Linus, Dave seems to collect an entire streak of things happening, so again me typing pull summary. Nothing nefarious here, most of the fixes are for new stuff or things users won't see. The amd-display patches are a bit different, and very much look like they should have at least some cc:

My penguin has blue feets (aka: RGB versus BGR troubles)

2019-07-26 Thread Sam Ravnborg
Hi all. The Atmel at91sam9263 has a nice LCDC IP core that supports several formats: DRM_FORMAT_XBGR, DRM_FORMAT_BGR888, DRM_FORMAT_BGR565 (It also supports a palletized C8 format, but thats for later). The formats are all BGR formats - and some boards actually reverse Blue and Red when

Re: My penguin has blue feets (aka: RGB versus BGR troubles)

2019-07-26 Thread Ilia Mirkin
On Fri, Jul 26, 2019 at 4:36 PM Sam Ravnborg wrote: > > Hi all. > > The Atmel at91sam9263 has a nice LCDC IP core that supports several > formats: > DRM_FORMAT_XBGR, DRM_FORMAT_BGR888, DRM_FORMAT_BGR565 > > (It also supports a palletized C8 format, but thats for later). > > The formats

Re: [PATCH] drm/i810: Use CONFIG_PREEMPTION

2019-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2019 at 10:25 PM Thomas Gleixner wrote: > > CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by > CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same > functionality which today depends on CONFIG_PREEMPT. > > Change the Kconfig dependency of i810 to

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Thomas Gleixner
On Fri, 26 Jul 2019, Chris Wilson wrote: > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > Objtool reports: > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > > .altinstr_replacement+0x36: redundant UACCESS

Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz wrote: > > Hi Alex, > > > W dniu 26.07.2019 o 21:28, Alex Deucher pisze: > > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >> > >> Signed-off-by: Andrzej

[RFC PATCH] drm: add Atmel LCDC display controller support

2019-07-26 Thread Sam Ravnborg
This is the current state of the driver for the at91sam* LCDC IP. Notice that it needs some other companion drivers and I posted this code-drop only to support the request for help on the BGR versus RGB issue. That said - any review feedback will be appreciated! Sam From

[Bug 105251] [Vega10] GPU lockup on boot: VMC page fault

2019-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105251 --- Comment #79 from deltasquared --- OK, have managed to get an unrelated crash from starting minetest now with the mentioned patch so at this point I think that case is unrelated. (Certainly seems to be more subtle, this MT crash has never

Review required [Was: Associate ddc adapters with connectors]

2019-07-26 Thread Sam Ravnborg
Hi all. Andrzej have done a good job following up on feedback and this series is now ready. We need ack on the patches touching the individual drivers before we can proceed. Please check your drivers and get back. Sam > Hi Andezej. > > On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej

Re: [PATCH 07/11] mtd: rawnand: Drop obsolete JZ4740 NAND driver

2019-07-26 Thread Miquel Raynal
Hi Paul, Paul Cercueil wrote on Thu, 25 Jul 2019 18:02:11 -0400: > It has been replaced with the newer Ingenic NAND driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > --- Acked-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-25 22:55:45) > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > Objtool reports: > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x36: redundant UACCESS disable > > > > __copy_from_user() already does both

Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Note that this only covers the legacy display code. The new DC display code also needs to be converted. See:

Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support

2019-07-26 Thread Fabio Estevam
Hi Guido, Thanks for your work on this driver! On Wed, Jul 24, 2019 at 12:52 PM Guido Günther wrote: > --- /dev/null > +++ b/drivers/gpu/drm/bridge/imx-nwl/Kconfig > @@ -0,0 +1,15 @@ > +config DRM_IMX_NWL_DSI > + tristate "Support for Northwest Logic MIPI DSI Host controller" > +

[PATCH v3 1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-26 Thread Sam Ravnborg
DRM_WAIT_ON() is from the deprecated drm_os_linux header and the modern replacement is the wait_event_*. The return values differ, so a conversion is needed to keep the original interface towards userspace. Introduced a switch/case to make code obvious. Analysis from Michel Dänzer: The waiting

<    1   2   3   >