[PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
Just like all the other variants, this one passes invalid compile-time options with clang after the new code got merged: clang: error: unknown argument: '-mpreferred-stack-boundary=4' scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o'

[PATCH 2/6] drm/amdgpu: hide another #warning

2019-10-02 Thread Arnd Bergmann
An earlier patch of mine disabled some #warning statements that get in the way of build testing, but then another instance was added around the same time. Remove that as well. Fixes: b5203d16aef4 ("drm/amd/amdgpu: hide #warning for missing DC config") Fixes: e1c14c43395c ("drm/amdgpu: Enable DC

[PATCH 3/6] drm/amdgpu: display_mode_vba_21: remove uint typedef

2019-10-02 Thread Arnd Bergmann
The type definition for 'uint' clashes with the generic kernel headers: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:43:22: error: redefinition of typedef 'uint' is a C11 feature [-Werror,-Wtypedef-redefinition] include/linux/types.h:92:23: note: previous definition

[PATCH 5/6] [RESEND] drm/amd/display: hide an unused variable

2019-10-02 Thread Arnd Bergmann
Without CONFIG_DEBUG_FS, we get a warning for an unused variable: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6020:33: error: unused variable 'source' [-Werror,-Wunused-variable] Hide the variable in an #ifdef like its only users. Fixes: 14b2584636c6 ("drm/amd/display: add

[PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Arnd Bergmann
Code in the amdgpu driver triggers a bug when using clang to build an arm64 kernel: /tmp/sdma_v4_0-f95fd3.s: Assembler messages: /tmp/sdma_v4_0-f95fd3.s:44: Error: selected processor does not support `bfc w0,#1,#5' I expect this to be fixed in llvm soon, but we can also work around it by

[PATCH] drm/omap: fix max fclk divider for omap36xx

2019-10-02 Thread Tomi Valkeinen
The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not correct, and using divider of 32 breaks DSS with a flood or underflows and sync losts. Dividers up to 31 seem to work fine. There is another patch to the DT

[PATCH] drivers: video: hdmi: log ext colorimetry applicability

2019-10-02 Thread Johan Korsnes
When logging the AVI InfoFrame, clearly indicate whether or not the extended colorimetry attribute is active. This is only the case when the AVI InfoFrame colorimetry attribute is set to extended. [0] [0] CTA-861-G section 6.4 page 57 Signed-off-by: Johan Korsnes --- drivers/video/hdmi.c | 8

Re: Ack to merge through DRM? WAS Re: [PATCH v2 1/5] mm: Add write-protect and clean utilities for address space ranges

2019-10-02 Thread Kirill A. Shutemov
On Wed, Oct 02, 2019 at 11:21:01AM +0200, Thomas Hellström (VMware) wrote: > On 9/26/19 10:16 PM, Linus Torvalds wrote: > > On Thu, Sep 26, 2019 at 1:09 PM Thomas Hellström (VMware) > > wrote: > > > That said, if people are OK with me modifying the assert in > > > pud_trans_huge_lock() and make

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 111021] [kernel >=5.2.x][amdgpu][CIK] BUG: KASAN: null-ptr-deref in amdgpu_ib_schedule+0x82/0x790 [amdgpu]

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Bug 111881] [kernel 5.4-rc1][amdgpu][CIK]: FW bug: No PASID in KFD interrupt

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111881 erhar...@mailbox.org changed: What|Removed |Added OS|All |Linux (All) See Also|

Re: Ack to merge through DRM? WAS Re: [PATCH v2 1/5] mm: Add write-protect and clean utilities for address space ranges

2019-10-02 Thread VMware
On 10/2/19 3:18 PM, Kirill A. Shutemov wrote: On Wed, Oct 02, 2019 at 11:21:01AM +0200, Thomas Hellström (VMware) wrote: On 9/26/19 10:16 PM, Linus Torvalds wrote: On Thu, Sep 26, 2019 at 1:09 PM Thomas Hellström (VMware) wrote: That said, if people are OK with me modifying the assert in

[Bug 111881] [kernel 5.4-rc1][amdgpu][CIK]: FW bug: No PASID in KFD interrupt

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111881 Bug ID: 111881 Summary: [kernel 5.4-rc1][amdgpu][CIK]: FW bug: No PASID in KFD interrupt Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: All

Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI 2.0

2019-10-02 Thread Ville Syrjälä
On Tue, Sep 24, 2019 at 01:26:21PM +0800, Wayne Lin wrote: > In HDMI 1.4 defines 4k modes without specific aspect ratio. > However, in HDMI 2.0, adds aspect ratio attribute to distinguish different > 4k modes. > > According to Appendix E of HDMI 2.0 spec, source should use VSIF to > indicate VIC

[PATCH 1/6] drm/amdgpu: make pmu support optional, again

2019-10-02 Thread Arnd Bergmann
When CONFIG_PERF_EVENTS is disabled, we cannot compile the pmu portion of the amdgpu driver: drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:48:38: error: no member named 'hw' in 'struct perf_event' struct hw_perf_event *hwc = >hw; ~ ^

[PATCH 0/6] amdgpu build fixes

2019-10-02 Thread Arnd Bergmann
Here are a couple of build fixes from my backlog in the randconfig tree. It would be good to get them all into linux-5.4. Arnd Arnd Bergmann (6): drm/amdgpu: make pmu support optional, again drm/amdgpu: hide another #warning drm/amdgpu: display_mode_vba_21: remove uint typedef

Re: [PATCH v4] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host

2019-10-02 Thread Sasha Levin
On Fri, Sep 13, 2019 at 06:38:42AM +, Dexuan Cui wrote: From: Michael Kelley Sent: Thursday, September 5, 2019 7:06 AM From: Wei Hu Sent: Thursday, September 5, 2019 2:12 AM > > Beginning from Windows 10 RS5+, VM screen resolution is obtained from host. > The "video=hyperv_fb" boot time

Re: [PATCH 10/60] drm/bridge: Add bridge driver for display connectors

2019-10-02 Thread Tomi Valkeinen
On 01/10/2019 23:08, Laurent Pinchart wrote: Many drivers print an info message at probe time when everything goes fine, to inform about the device that has been succesfully probed. Do you think this is overkill and a dev_dbg() would be better ? Ah, I didn't realize this is a "probed"

Re: [PATCH v1 2/2] drm/panel: simple: add display timings for logic technologies displays

2019-10-02 Thread Philippe Schenker
On Tue, 2019-10-01 at 17:05 -0500, Rob Herring wrote: > On Fri, Sep 20, 2019 at 09:54:11AM +0200, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > Add display timings for the following 3 display panels manufactured > > by > > Logic Technologies Limited: > > > > - LT161010-2NHC e.g. as

Re: [PATCH 0/3] drm/sun4i: dsi: misc timing fixes

2019-10-02 Thread Maxime Ripard
Hi, On Tue, Oct 01, 2019 at 04:02:50PM +0800, Icenowy Zheng wrote: > This patchset fixes some portion of timing calculation in sun6i_mipi_dsi > driver according to the BSP driver. > > Two of the patches are reverting, one is fixing some misread of the BSP > source code, another is fixing a wrong

[Bug 111881] [kernel 5.4-rc1][amdgpu][CIK]: FW bug: No PASID in KFD interrupt

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111881 --- Comment #1 from erhar...@mailbox.org --- Created attachment 145613 --> https://bugs.freedesktop.org/attachment.cgi?id=145613=edit kernel.config (5.4-rc1) -- You are receiving this mail because: You are the assignee for the

Re: [PATHC v6] video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver

2019-10-02 Thread Sasha Levin
On Wed, Oct 02, 2019 at 08:09:41AM +, Dexuan Cui wrote: -Original Message- From: Sasha Levin Sent: Tuesday, October 1, 2019 11:48 AM On Fri, Sep 20, 2019 at 05:26:34PM +, Michael Kelley wrote: >From: Michael Kelley Sent: Wednesday, September 18, 2019 2:48 PM >> > >> > Without

Re: [PATCH v4 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-02 Thread Daniel Thompson
On Tue, Oct 01, 2019 at 02:58:37PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The probe function in the gpio-backlight driver is quite short. If we > pull gpio_backlight_initial_power_state() into probe we can drop two > more fields from struct gpio_backlight and shrink

Re: [PATCH v4 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-02 Thread Bartosz Golaszewski
śr., 2 paź 2019 o 12:33 Daniel Thompson napisał(a): > > On Tue, Oct 01, 2019 at 02:58:37PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The probe function in the gpio-backlight driver is quite short. If we > > pull gpio_backlight_initial_power_state() into probe we can

[Bug 201957] amdgpu: ring gfx timeout

2019-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 lekto (le...@o2.pl) changed: What|Removed |Added CC||le...@o2.pl --- Comment #11 from

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jani Nikula
On Wed, 02 Oct 2019, Daniel Thompson wrote: > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: >> On Tue, 01 Oct 2019, Mat King wrote: >> > Resending in plain text mode >> > >> > I have been looking into adding Linux support for electronic privacy >> > screens which is a feature on

Re: [PATCH v3 0/5] drm/ast: Place cursor BOs at VRAM high-end

2019-10-02 Thread Thomas Zimmermann
Hi Am 02.10.19 um 10:59 schrieb Gerd Hoffmann: On Fri, Sep 27, 2019 at 11:03:04AM +0200, Thomas Zimmermann wrote: (was: drm/ast/mgag200: Place cursor BOs at VRAM high-end) This patchset cleans up the memory management of HW cursors in ast. It further moves the allocated cursor BOs to the of

Re: [PATCH] drm/omap: fix max fclk divider for omap36xx

2019-10-02 Thread Adam Ford
On Wed, Oct 2, 2019 at 7:25 AM Tomi Valkeinen wrote: > > The OMAP36xx and AM/DM37x TRMs say that the maximum divider for DSS fclk > (in CM_CLKSEL_DSS) is 32. Experimentation shows that this is not > correct, and using divider of 32 breaks DSS with a flood or underflows > and sync losts. Dividers

Re: [PATCH 1/2] arm64: dts: juno: add GPU subsystem

2019-10-02 Thread Sudeep Holla
On Mon, Sep 30, 2019 at 12:46:33PM -0500, Rob Herring wrote: > On Mon, Sep 30, 2019 at 10:25 AM Robin Murphy wrote: > > > > Since we now have bindings for Mali Midgard GPUs, let's use them to > > describe Juno's GPU subsystem, if only because we can. Juno sports a > > Mali-T624 integrated behind

Re: [PATCH RFC v4 07/16] drm, cgroup: Add total GEM buffer allocation limit

2019-10-02 Thread Michal Koutný
Hello. On Thu, Aug 29, 2019 at 02:05:24AM -0400, Kenny Ho wrote: > drm.buffer.default > A read-only flat-keyed file which exists on the root cgroup. > Each entry is keyed by the drm device's major:minor. > > Default limits on the total GEM buffer allocation in bytes.

[PATCH v4] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Navid Emamdoost
In acp_hw_init there are some allocations that needs to be released in case of failure: 1- adev->acp.acp_genpd should be released if any allocation attemp for adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. 2- all of those allocations should be released if mfd_add_hotplug_devices or

Re: [PATCH] drm/amd/display: memory leak

2019-10-02 Thread Navid Emamdoost
Would you please review this patch? Thanks, Navid. On Mon, Sep 16, 2019 at 10:21 PM Navid Emamdoost wrote: > > In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated > clk_src needs release. > > Signed-off-by: Navid Emamdoost > --- >

[PATCH] drm/amdgpu: Drop unused variable and statement

2019-10-02 Thread Austin Kim
Even though 'smu8_smu' is declared, it is not used after below statement. smu8_smu = hwmgr->smu_backend; So 'unused variable' could be safely removed to stop warning message as below: drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu8_smumgr.c:180:22: warning: variable ‘smu8_smu’ set

Re: [PATCH v4] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Markus Elfring
> --- Why did you omit the patch change log at this place? > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 34 - > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > @@ -189,7 +189,7 @@ static int acp_hw_init(void *handle) … > + struct i2s_platform_data *i2s_pdata = NULL;

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Tue, Oct 1, 2019 at 10:27 AM Greg KH wrote: > > On Tue, Oct 01, 2019 at 10:09:46AM -0600, Mat King wrote: > > Resending in plain text mode > > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > >

Re: [PATCH RFC v4 02/16] cgroup: Introduce cgroup for drm subsystem

2019-10-02 Thread Michal Koutný
Hi. On Thu, Aug 29, 2019 at 02:05:19AM -0400, Kenny Ho wrote: > +struct cgroup_subsys drm_cgrp_subsys = { > + .css_alloc = drmcg_css_alloc, > + .css_free = drmcg_css_free, > + .early_init = false, > + .legacy_cftypes = files, Do you really want to expose the DRM

RE: [PATCH v5] video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver

2019-10-02 Thread Dexuan Cui
> From: Sasha Levin > Sent: Tuesday, October 1, 2019 11:45 AM > To: Wei Hu > > On Fri, Sep 13, 2019 at 06:02:55AM +, Wei Hu wrote: > >Without deferred IO support, hyperv_fb driver informs the host to refresh > >the entire guest frame buffer at fixed rate, e.g. at 20Hz, no matter there > >is

[Bug 205069] Black screen when starting graphical environment

2019-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205069 --- Comment #6 from Michel Dänzer (mic...@daenzer.net) --- Was Mesa built against LLVM 9, not an older version? It looks like the problem occurs when the Xorg driver tries loading glamor, so a Mesa/LLVM issue is most likely. -- You are

[Bug 111228] PRIME output screen stays black on 1002:15d8 with 128MB VRAM

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111228 --- Comment #7 from Maik Freudenberg --- Updating with info from other users with the same amd gpu with 128MB VRAM: - one user was able to switch to VT and start a second Xserver which then worked fine. - another user found out that connecting

Re: [PATCH v3 0/7] drm/mgag200: Place cursor BOs at VRAM high-end

2019-10-02 Thread Gerd Hoffmann
On Fri, Sep 27, 2019 at 11:12:54AM +0200, Thomas Zimmermann wrote: > (was: drm/ast/mgag200: Place cursor BOs at VRAM high-end) > > This patchset cleans up the memory management of HW cursors in mgag200. It > further moves the allocated cursor BOs to the of the video RAM to reduce > memory

Re: [PATCH] backlight: pwm_bl: Don't assign levels table repeatedly

2019-10-02 Thread Daniel Thompson
On Tue, Oct 01, 2019 at 04:29:24PM -0700, Matthias Kaehlcke wrote: > pwm_backlight_probe() re-assigns pb->levels for every brightness > level. This is not needed and was likely not intended, since > neither side of the assignment changes during the loop. Assign > the field only once. > >

Re: Ack to merge through DRM? WAS Re: [PATCH v2 1/5] mm: Add write-protect and clean utilities for address space ranges

2019-10-02 Thread VMware
On 9/26/19 10:16 PM, Linus Torvalds wrote: On Thu, Sep 26, 2019 at 1:09 PM Thomas Hellström (VMware) wrote: That said, if people are OK with me modifying the assert in pud_trans_huge_lock() and make __walk_page_range non-static, it should probably be possible to make it work, yes. I don't

Re: New sysfs interface for privacy screens

2019-10-02 Thread Daniel Thompson
On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Mat King wrote: > > Resending in plain text mode > > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-02 Thread Rafael J. Wysocki
On Tue, Oct 1, 2019 at 9:34 PM Bjorn Helgaas wrote: > > On Tue, Oct 01, 2019 at 06:21:28PM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > > On Mon, Sep 30, 2019 at 6:30 PM Mika

RE: [PATHC v6] video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver

2019-10-02 Thread Dexuan Cui
> -Original Message- > From: Sasha Levin > Sent: Tuesday, October 1, 2019 11:48 AM > > On Fri, Sep 20, 2019 at 05:26:34PM +, Michael Kelley wrote: > >From: Michael Kelley Sent: Wednesday, > September 18, 2019 2:48 PM > >> > > >> > Without deferred IO support, hyperv_fb driver

[Bug 111228] PRIME output screen stays black on 1002:15d8 with 128MB VRAM

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111228 --- Comment #8 from Maik Freudenberg --- A note on amdgpu the amount of VRAM amdgpu is reporting: This is the amount of system memory dedicated to the iGPU. Strange enough, this doesn't seem to be bios configurable, which would be an easy

Re: [PATCH 1/2] drm/virtgpu: plumb fix for virtgpu_drm.h / virtio_gpu.h discrepancy

2019-10-02 Thread Gerd Hoffmann
On Tue, Oct 01, 2019 at 06:49:34PM -0700, Gurchetan Singh wrote: > virglrenderer has logic to validate both stride and layer_stride, > but both are always zero. The fallback for that case is: > > stride = width * bytes_per_pixel > layer_stride = stride * num_layers > > However, this assumption

Re: [PATCH v4] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Koenig, Christian
Am 02.10.19 um 05:46 schrieb Navid Emamdoost: > In acp_hw_init there are some allocations that needs to be released in > case of failure: > > 1- adev->acp.acp_genpd should be released if any allocation attemp for > adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. > 2- all of those

Re: [PATCH 2/2] [RFC] drm/virtgpu: modify uapi with stride/layer_stride fix

2019-10-02 Thread Gerd Hoffmann
On Tue, Oct 01, 2019 at 06:49:35PM -0700, Gurchetan Singh wrote: > This doesn't really break userspace, since it always passes down > 0 for stride/layer_stride currently. We could: > > (1) modify UAPI now and add a VIRTGPU_PARAM_STRIDE_FIX feature This I think. But IMO it's not a fix, it is an

Re: [PATCH v3 0/5] drm/ast: Place cursor BOs at VRAM high-end

2019-10-02 Thread Gerd Hoffmann
On Fri, Sep 27, 2019 at 11:03:04AM +0200, Thomas Zimmermann wrote: > (was: drm/ast/mgag200: Place cursor BOs at VRAM high-end) > > This patchset cleans up the memory management of HW cursors in ast. It > further moves the allocated cursor BOs to the of the video RAM to reduce > memory

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jani Nikula
On Tue, 01 Oct 2019, Mat King wrote: > Resending in plain text mode > > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a > physical

Re: [PATCH v3] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Navid Emamdoost
On Tue, Oct 1, 2019 at 7:19 AM Koenig, Christian wrote: > > Am 30.09.19 um 23:26 schrieb Navid Emamdoost: > > In acp_hw_init there are some allocations that needs to be released in > > case of failure: > > > > 1- adev->acp.acp_genpd should be released if any allocation attemp for > >

Re: [PATCH RFC v4 11/16] drm, cgroup: Add per cgroup bw measure and control

2019-10-02 Thread Michal Koutný
Hi. On Thu, Aug 29, 2019 at 02:05:28AM -0400, Kenny Ho wrote: > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -1256,6 +1257,12 @@ int ttm_bo_validate(struct ttm_buffer_object *bo, > [...] > + move_delay /= 2000; /* check every half period in ms*/ >

Re: [PATCH 1/2] arm64: dts: juno: add GPU subsystem

2019-10-02 Thread Sudeep Holla
On Tue, Oct 01, 2019 at 01:45:30PM +0100, Robin Murphy wrote: > On 01/10/2019 09:59, Sudeep Holla wrote: > > On Mon, Sep 30, 2019 at 12:46:33PM -0500, Rob Herring wrote: > > > On Mon, Sep 30, 2019 at 10:25 AM Robin Murphy > > > wrote: > > > > > > > > Since we now have bindings for Mali Midgard

Re: [PATCH v3] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Markus Elfring
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c > @@ -184,12 +184,12 @@ static struct device *get_mfd_cell_dev(const char > *device_name, int r) … > + struct i2s_platform_data *i2s_pdata = NULL; … I propose to reconsider this update suggestion. > @@ -231,20 +231,21 @@ static int

Re: [PATCH 1/4] dma-buf: change DMA-buf locking convention

2019-10-02 Thread Koenig, Christian
Hi Daniel, once more a ping on this. Any more comments or can we get it comitted? Thanks, Christian. Am 24.09.19 um 11:50 schrieb Christian König: > Am 17.09.19 um 16:56 schrieb Daniel Vetter: >> [SNIP]   +    /* When either the importer or the exporter can't

Re: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault

2019-10-02 Thread Christian König
Just a gentle ping on this. Everybody on XDC, or can we get this comitted? Am 27.09.19 um 14:34 schrieb Christian König: That is needed by at least a cleanup in radeon. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 ++- include/drm/ttm/ttm_bo_api.h| 2 ++ 2

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 10:51 AM Arnd Bergmann wrote: > > On Wed, Oct 2, 2019 at 4:17 PM Alex Deucher wrote: > > > > I'm getting an error with gcc with this patch: > > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o > >

Re: [PATCH] drm: add fb max width/height fields to drm_mode_config

2019-10-02 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 02:20:55PM -0700, Jeykumar Sankaran wrote: > On 2019-09-30 03:39, Ville Syrjälä wrote: > > On Fri, Sep 27, 2019 at 06:28:51PM -0700, Jeykumar Sankaran wrote: > >> The mode_config max width/height values determine the maximum > >> resolution the pixel reader can handle. > >

Re: [PATCH] drm/amdgpu: remove set but not used variable 'pipe'

2019-10-02 Thread Alex Deucher
On Mon, Sep 30, 2019 at 3:03 AM yu kuai wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function > ‘amdgpu_gfx_graphics_queue_acquire’: > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning: > variable ‘pipe’ set but not used

Re: [PATCH] drm/amd/display: memory leak

2019-10-02 Thread Alex Deucher
On Tue, Oct 1, 2019 at 5:00 PM Navid Emamdoost wrote: > > Would you please review this patch? > Applied. thanks! Alex > > Thanks, > Navid. > > On Mon, Sep 16, 2019 at 10:21 PM Navid Emamdoost > wrote: > > > > In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated > >

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 8:03 AM Arnd Bergmann wrote: > > Just like all the other variants, this one passes invalid > compile-time options with clang after the new code got > merged: > > clang: error: unknown argument: '-mpreferred-stack-boundary=4' > scripts/Makefile.build:265: recipe for target

Re: drm_sched with panfrost crash on T820

2019-10-02 Thread Neil Armstrong
Hi Andrey, On 02/10/2019 16:40, Grodzovsky, Andrey wrote: > > On 9/30/19 10:52 AM, Hillf Danton wrote: >> On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote: >>> Did a new run from 5.3: >>> >>> [ 35.971972] Call trace: >>> [ 35.974391] drm_sched_increase_karma+0x5c/0xf0 >>>

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
On Wed, Oct 2, 2019 at 4:17 PM Alex Deucher wrote: > > I'm getting an error with gcc with this patch: > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In > function ‘calculate_wm_set_for_vlevel’: >

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Wed, Oct 2, 2019 at 4:46 AM Jani Nikula wrote: > > On Wed, 02 Oct 2019, Daniel Thompson wrote: > > On Wed, Oct 02, 2019 at 12:30:05PM +0300, Jani Nikula wrote: > >> On Tue, 01 Oct 2019, Mat King wrote: > >> > Resending in plain text mode > >> > > >> > I have been looking into adding Linux

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
On Wed, Oct 2, 2019 at 5:12 PM Alex Deucher wrote: > On Wed, Oct 2, 2019 at 10:51 AM Arnd Bergmann wrote: > > > > Nothing should really change with regards to the -msse flag here, only > > the stack alignment flag changed. Maybe there was some other change > > in your Makefile that conflicts

Re: [PATCH] drm/amdgpu: Drop unused variable and statement

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 3:19 AM Austin Kim wrote: > > Even though 'smu8_smu' is declared, it is not used after below statement. > >smu8_smu = hwmgr->smu_backend; > > So 'unused variable' could be safely removed > to stop warning message as below: > >

Re: [PATCH v7 1/5] leds: populate the device's of_node when possible

2019-10-02 Thread Jean-Jacques Hiblot
Hi Jacek, On 24/09/2019 23:03, Jacek Anaszewski wrote: Hi Jean, Thank you for rebasing the set On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote: If initialization data is available and its fwnode is actually a of_node, store this information in the led device's structure. This will allow the

[PATCH V6] drm/drm_vblank: Change EINVAL by the correct errno

2019-10-02 Thread Rodrigo Siqueira
For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the

[PATCH v2 2/5] drm/imx: compile imx directory by default

2019-10-02 Thread Laurentiu Palcu
Currently the drm/imx/ directory is compiled only if DRM_IMX is set. Adding a new IMX related IP in the same directory would need DRM_IMX to be set, which would bring in also IPUv3 core driver... The current patch would allow adding new IPs in the imx/ directory without needing to set DRM_IMX.

[PATCH v2 4/5] dt-bindings: display: imx: add bindings for DCSS

2019-10-02 Thread Laurentiu Palcu
Add bindings for iMX8MQ Display Controller Subsystem. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml diff

[PATCH v2 0/5] Add support for iMX8MQ Display Controller Subsystem

2019-10-02 Thread Laurentiu Palcu
Hi, This patchset adds initial DCSS support for iMX8MQ chip. Initial support includes only graphics plane support (no video planes), no HDR10 capabilities, no graphics decompression (only linear, tiled and super-tiled buffers allowed). Support for the rest of the features will be added

Re: [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-02 Thread Jani Nikula
On Tue, 24 Sep 2019, Jani Nikula wrote: > drm/print: move drm_debug variable to drm_print.[ch] > drm/print: add drm_debug_enabled() > drm/etnaviv: use drm_debug_enabled() to check for debug categories > drm/i2c/sil164: use drm_debug_enabled() to check for debug categories > drm/msm: use

[PATCH 2/2] drm/mcde: Fix Sphinx formatting

2019-10-02 Thread Jonathan Neuschäfer
- Format the pipe diagram as a monospace block. - Fix formatting of the list. Without the empty line, the first dash is not parsed as a bullet point. Signed-off-by: Jonathan Neuschäfer --- drivers/gpu/drm/mcde/mcde_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 1/2] drm/mcde: Fix reference to DOC comment

2019-10-02 Thread Jonathan Neuschäfer
The :doc: reference did not match the DOC comment's name. Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Jonathan Neuschäfer --- Documentation/gpu/mcde.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gpu/mcde.rst

Re: [PATCH] drm/amdgpu: Initialize variable before use

2019-10-02 Thread Alex Deucher
On Mon, Sep 30, 2019 at 4:09 PM Siqueira, Rodrigo wrote: > > The 'debug_data' variable gets printed in debug statements without a > prior initialization in the function > hubbub1_verify_allow_pstate_change_high, as reported when building with > gcc 9.1.0: > > warning: ‘debug_data’ may be used

Re: [PATCH v4 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe

2019-10-02 Thread Daniel Thompson
On Wed, Oct 02, 2019 at 01:46:17PM +0200, Bartosz Golaszewski wrote: > śr., 2 paź 2019 o 12:33 Daniel Thompson > napisał(a): > > > > On Tue, Oct 01, 2019 at 02:58:37PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > The probe function in the gpio-backlight driver

Re: drm_sched with panfrost crash on T820

2019-10-02 Thread Grodzovsky, Andrey
On 9/30/19 10:52 AM, Hillf Danton wrote: > On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote: >> Did a new run from 5.3: >> >> [ 35.971972] Call trace: >> [ 35.974391] drm_sched_increase_karma+0x5c/0xf0 >> 10667f3810667F94 >>

Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init

2019-10-02 Thread Gustavo A. R. Silva
On 10/1/19 17:21, Liu, Leo wrote: OK. So, maybe we can add a comment pointing that out? >>> That could be better. >>> >> Great. I'm glad it's not a bug. I'll write a patch for that so other >> people don't waste time taking a look. > > Thanks, just sent two patches to add comment, and

[PATCH v2 3/5] drm/imx: Add initial support for DCSS on iMX8MQ

2019-10-02 Thread Laurentiu Palcu
This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include: * 4K@60fps; * HDR10; * one graphics and 2 video pipelines; * on-the-fly decompression of compressed video and graphics; The reference manual can be found here:

[pull] ttm drm-fixes-5.4

2019-10-02 Thread Christian König
Hi Dave, Daniel, we had some problems this cycle sending out TTM fixes because of lack of time to rebase amd-staging-drm-next. Because of this Alex and I decided that I'm going to send out TTM pull requests separately now. So this is the first small bunch of fixes for 5.4. The following

[PATCH] drm: Fix comment doc for format_modifiers

2019-10-02 Thread Andrzej Pietrasiewicz
To human readers "array of struct drm_format modifiers" is almost indistinguishable from "array of struct drm_format_modifiers", especially given that struct drm_format_modifier does exist. And indeed the parameter passes an array of uint64_t rather than an array of structs, but the first words

Re: New sysfs interface for privacy screens

2019-10-02 Thread Jonathan Corbet
On Tue, 1 Oct 2019 10:09:46 -0600 Mat King wrote: > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a > physical privacy filter. In

[PATCH v2 2/3] dt-bindings: power: Convert Samsung Exynos Power Domain bindings to json-schema

2019-10-02 Thread Krzysztof Kozlowski
Convert Samsung Exynos Soc Power Domain bindings to DT schema format using json-schema. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Indent example with four spaces (more readable), 2. Remove unneeded types, 3. Add missing address in example and fix the name. ---

[PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

2019-10-02 Thread Krzysztof Kozlowski
Convert Generic Power Domain bindings to DT schema format using json-schema. The consumer bindings are split to separate file. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Select all nodes for consumers, 2. Remove from consumers duplicated properties with dt-schema, 3. Fix

[PATCH v2 3/3] ARM: dts: exynos: Rename power domain nodes to "power-domain" in Exynos4

2019-10-02 Thread Krzysztof Kozlowski
The device node name should reflect generic class of a device so rename power domain nodes to "power-domain". No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4.dtsi| 14 +++--- arch/arm/boot/dts/exynos4210.dtsi | 2 +-

[PATCH v3 1/2] dt-bindings: pwm: Convert PWM bindings to json-schema

2019-10-02 Thread Krzysztof Kozlowski
Convert generic PWM bindings to DT schema format using json-schema. The consumer bindings are split to separate file. Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. Change also pwm-sprd.txt Changes since v1: 1. Indent example with four spaces (more readable), 2. Change pattern

[PATCH v3 2/2] dt-bindings: pwm: Convert Samsung PWM bindings to json-schema

2019-10-02 Thread Krzysztof Kozlowski
Convert Samsung PWM (S3C, S5P and Exynos SoCs) bindings to DT schema format using json-schema. Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. Add additionalProperties: false. Changes since v1: 1. Indent example with four spaces (more readable), 2. Fix samsung,pwm-outputs after

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #64 from Marko Popovic --- (In reply to Pierre-Eric Pelloux-Prayer from comment #33) > Created attachment 145323 [details] [review] > wip patch > > You can give a try to the attached kernel patch which hopefully could > prevent

Re: drm_sched with panfrost crash on T820

2019-10-02 Thread Grodzovsky, Andrey
On 9/30/19 5:17 AM, Neil Armstrong wrote: > Hi Andrey, > > On 27/09/2019 22:55, Grodzovsky, Andrey wrote: >> Can you please use addr2line or gdb to pinpoint where in >> drm_sched_increase_karma you hit the NULL ptr ? It looks like the guilty >> job, but to be sure. > Did a new run from 5.3: > > [

[Bug 110968] Allow ubuntu users to install on other ubuntu versions

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110968 Jeremy Newton changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #4 from Jeremy

Re: New sysfs interface for privacy screens

2019-10-02 Thread Mat King
On Wed, Oct 2, 2019 at 9:46 AM Jonathan Corbet wrote: > > On Tue, 1 Oct 2019 10:09:46 -0600 > Mat King wrote: > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display and allows users to turn

[Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111402 Jeremy Newton changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Jeremy

RE: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault

2019-10-02 Thread Huang, Ray
Ahh.  Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, October 2, 2019 4:38 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault Just a gentle ping on

Re: [PATCH] drm: Fix comment doc for format_modifiers

2019-10-02 Thread Sam Ravnborg
Hi Andrzej Always good to have clear documentation. On Wed, Oct 02, 2019 at 05:43:49PM +0200, Andrzej Pietrasiewicz wrote: > To human readers > > "array of struct drm_format modifiers" is almost indistinguishable from > "array of struct drm_format_modifiers", especially given that > struct

Re: [PATCH] drm: Fix comment doc for format_modifiers

2019-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2019 at 05:43:49PM +0200, Andrzej Pietrasiewicz wrote: > To human readers > > "array of struct drm_format modifiers" is almost indistinguishable from > "array of struct drm_format_modifiers", Unless I'm blind those two *are* indistinguishable :P > especially given that > struct

[Bug 109440] Radeon RX 580 fails to initialize

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109440 Jeremy Newton changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included]

2019-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111402 Jeremy Newton changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |jeremy.new...@amd.com

[PATCH v9 2/5] dma-buf: heaps: Add heap helpers

2019-10-02 Thread John Stultz
Add generic helper dmabuf ops for dma heaps, so we can reduce the amount of duplicative code for the exported dmabufs. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others!

[PATCH v9 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-10-02 Thread John Stultz
This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin

  1   2   >