In amdgpu_bo_list_ioctl when idr_alloc fails
don't return without freeing bo list entry.
Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO lists in CS ioctl v3")
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Ville Syrjälä
Sent: Thursday, October 3, 2019 21:29
To: Lin, Wayne
Cc: dri-devel@lists.freedesktop.org ;
amd-...@lists.freedesktop.org ; Li, Sun peng
(Leo) ; Kazlauskas, Nicholas
Subject: Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI
On 10/4/19 12:44 PM, Koenig, Christian wrote:
> First of all please send mails regarding amdgpu to the amd-gfx mailing
> list and not lkml/dri-devel.
Okay.
> Am 04.10.19 um 12:17 schrieb Nirmoy Das:
>> In amdgpu_bo_list_ioctl when idr_alloc fails
>> don't return without freeing bo list entry.
>>
It is possible for one HDMI connector to have multiple CEC adapters. The
typical real-world scenario is that where one adapter is used when the device
is in standby, and one that's better/smarter when the device is powered up.
The cec-notifier changes were made with that in mind, but I missed
On 03/10/2019 22:00, Chris Wilson wrote:
If we unwind the active requests, and on resubmission discover that we
intend to preempt the active context with itself, simply skip the ELSP
submission.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 17 -
1
Make dma_fence_enable_sw_signaling() behave like its
dma_fence_add_callback() and dma_fence_default_wait() counterparts and
perform the test to enable signaling under the fence->lock, along with
the action to do so. This ensure that should an implementation be trying
to flush the cb_list (by
On 03/10/2019 22:27, Jacek Anaszewski wrote:
On 10/3/19 9:41 PM, Mark Brown wrote:
On Thu, Oct 03, 2019 at 09:21:06PM +0200, Jacek Anaszewski wrote:
On 10/3/19 8:35 PM, Mark Brown wrote:
On Thu, Oct 03, 2019 at 07:43:17PM +0200, Jacek Anaszewski wrote:
On 10/3/19 2:47 PM, Jean-Jacques
First of all please send mails regarding amdgpu to the amd-gfx mailing
list and not lkml/dri-devel.
Am 04.10.19 um 12:17 schrieb Nirmoy Das:
> In amdgpu_bo_list_ioctl when idr_alloc fails
> don't return without freeing bo list entry.
>
> Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO
Hi Thierry,
Just a reminder: this patch hasn't been merged yet for v5.5.
Thanks!
Hans
On 8/28/19 1:54 PM, Thierry Reding wrote:
> On Wed, Aug 28, 2019 at 12:06:34PM +0200, Hans Verkuil wrote:
>> On 8/28/19 11:38 AM, Thierry Reding wrote:
>>> On Wed, Aug 28, 2019 at 10:09:30AM +0200,
Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
> The generic tree tree really wants [a, b) intervals, not fully closed.
> As such convert it to use the new interval_tree_gen.h. Most of the
> conversions are straightforward, with the exception of perhaps
> radeon_vm_bo_set_addr(), but semantics have
Am 03.10.19 um 23:52 schrieb Colin King:
> From: Colin Ian King
>
> The boolean variable pasid_mapping_needed is not initialized and
> there are code paths that do not assign it any value before it is
> is read later. Fix this by initializing pasid_mapping_needed to
> false.
>
>
On 03/10/2019 22:00, Chris Wilson wrote:
A straightforward conversion of assignment and checking of the boolean
state flags (allocated, scanned) into non-atomic bitops. The caller
remains responsible for all locking around the drm_mm and its nodes.
Signed-off-by: Chris Wilson
---
On 03/10/2019 22:01, Chris Wilson wrote:
A few callers need to serialise the destruction of their drm_mm_node and
ensure it is removed from the drm_mm before freeing. However, to be
completely sure that any access from another thread is complete before
we free the struct, we require the RELEASE
Le jeu. 3 oct. 2019 à 17:46, Ville Syrjälä
a écrit :
>
> On Thu, Oct 03, 2019 at 05:37:15PM +0200, Benjamin Gaignard wrote:
> > Le jeu. 3 oct. 2019 à 17:05, Ville Syrjälä
> > a écrit :
> > >
> > > On Thu, Oct 03, 2019 at 04:46:54PM +0200, Benjamin Gaignard wrote:
> > > > Le jeu. 3 oct. 2019 à
Quoting Tvrtko Ursulin (2019-10-04 10:15:20)
>
> On 03/10/2019 22:01, Chris Wilson wrote:
> > A few callers need to serialise the destruction of their drm_mm_node and
> > ensure it is removed from the drm_mm before freeing. However, to be
> > completely sure that any access from another thread is
Hi,
On Sun, Sep 29, 2019 at 10:24 PM Pintu Agarwal wrote:
>
> >
> > On Mon, Sep 23, 2019 at 1:28 PM Pintu Agarwal wrote:
> > >
> > > Dear Philipp,
> > >
> > > I have a iMX6dl custom board with custom Linux Kernel 4.8.
> > > I have both LCD and HDMI connected to the board.
> > > And we are using
On 04/10/2019 11:11, Chris Wilson wrote:
Make dma_fence_enable_sw_signaling() behave like its
dma_fence_add_callback() and dma_fence_default_wait() counterparts and
perform the test to enable signaling under the fence->lock, along with
the action to do so. This ensure that should an
On Thu, Oct 03, 2019 at 01:18:49PM -0700, Davidlohr Bueso wrote:
> +/* \
> + * Iterate over intervals intersecting [start;end) \
> + *
Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
> The amdgpu_vm interval tree really wants [a, b) intervals,
NAK, we explicitly do need an [a, b[ interval here.
Regards,
Christian.
> not fully closed ones. As such convert it to use the new
> interval_tree_gen.h, and also rename the 'last'
From: Colin Ian King
In other places of the driver the string hdmi_rejection_pll is
used instead of the truncated hdmi_rejec_pll, so use this string
instead to be consistent.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 03/10/2019 22:00, Chris Wilson wrote:
In preparation for rearranging the booleans into a flags field, ensure
all the current users are using the inline helpers and not directly
accessing the members.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_mm.c | 19
On 03/10/2019 22:00, Chris Wilson wrote:
Make dma_fence_enable_sw_signaling() behave like its
dma_fence_add_callback() and dma_fence_default_wait() counterparts and
perform the test to enable signaling under the fence->lock, along with
the action to do so. This ensure that should an
Hi Laurent,
Are you happy with this patch? Please let me know.
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=180271
regards,
Biju
> Subject: [PATCH 0/4] Add RZ/G2N DU support
>
> This patch series aims to add binding/driver support for R8A774B1(a.k.a
> RZ/G2N) DU (which
On Wed, Oct 2, 2019 at 2:24 PM Alex Deucher wrote:
>
> On Wed, Oct 2, 2019 at 5:19 PM Nick Desaulniers
> wrote:
> >
> > Alex, do you know why the AMDGPU driver uses a different stack
> > alignment (16B) than the rest of the x86 kernel? (see
> > arch/x86/Makefile which uses 8B stack alignment).
https://bugs.freedesktop.org/show_bug.cgi?id=111900
Andre Klapper changed:
What|Removed |Added
Resolution|--- |INVALID
Status|ASSIGNED
https://bugs.freedesktop.org/show_bug.cgi?id=111902
Andre Klapper changed:
What|Removed |Added
Resolution|--- |INVALID
Status|ASSIGNED
On Thu, 2019-10-03 at 10:59 -0500, Rob Herring wrote:
> On Wed, Oct 2, 2019 at 5:27 AM Philippe Schenker
> wrote:
> > On Tue, 2019-10-01 at 17:05 -0500, Rob Herring wrote:
> > > On Fri, Sep 20, 2019 at 09:54:11AM +0200, Marcel Ziswiler wrote:
> > > > From: Marcel Ziswiler
> > > >
> > > > Add
Am 03.10.19 um 23:40 schrieb Colin King:
> From: Colin Ian King
>
> There is a return statement that is not reachable and a variable that
> is not used. Remove them.
>
> Addresses-Coverity: ("Structurally dead code")
> Fixes: de7b45babd9b ("drm/amdgpu: cleanup creating BOs at fixed location
>
Hi Yizhuo,
Thank you for the patch.
On Sun, Sep 29, 2019 at 09:45:02PM -0700, Yizhuo wrote:
> In function sii902x_connector_detect(), variable "status" could be
> initialized if regmap_read() fails. However, "status" is used to
I assume you meant "could be uninitialized" ?
> decide the return
Hi Biju,
Thank you for the patches;
On Mon, Sep 30, 2019 at 10:15:01AM +0100, Biju Das wrote:
> This patch series aims to add binding/driver support for
> R8A774B1(a.k.a RZ/G2N) DU (which is very similar to the R8A77965 DU);
> it has one RGB output, one LVDS output and one HDMI output.
>
> Biju
Hi Tomi,
Thank you for the patch.
On Mon, Sep 30, 2019 at 01:38:35PM +0300, Tomi Valkeinen wrote:
> Avoid unnecessary copy in mgr_fld_read/write by taking a pointer to the
> reg_resc and using that.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
> ---
>
Hi Biju,
Thank you for the patch.
On Mon, Sep 30, 2019 at 10:28:51AM +0100, Biju Das wrote:
> Document RZ/G2N (R8A774B1) SoC bindings.
>
> Signed-off-by: Biju Das
I really like how your RZ patches are simple, they're painless to
review, it's all very pleasurable :-)
Reviewed-by: Laurent
On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built
Linux wrote:
> > Apparently this bug is still present in both the released clang-9
> > and the current development version of clang-10.
> > I was hoping we would not need a workaround in clang-9+, but
> > it seems that
Hey Linus,
Been offline for 3 days, got back and had some fixes queued up,
nothing too major, the i915 dp-mst fix is important, and amdgpu has a
bulk move speedup fix and some regressions, but nothing too insane for
an rc2 pull. The intel fixes are also 2 weeks worth, they missed the
boat last
Hi Tomi,
Thank you for the patch.
On Mon, Sep 30, 2019 at 01:38:40PM +0300, Tomi Valkeinen wrote:
> If use_mclk is false, mclk_mode is written to a register without
> initialization. This doesn't cause any ill effects as the written value
> is not used when use_mclk is false.
>
> To fix this,
Am 04.10.19 um 08:57 schrieb Christian König:
> Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
>> The generic tree tree really wants [a, b) intervals, not fully closed.
>> As such convert it to use the new interval_tree_gen.h. Most of the
>> conversions are straightforward, with the exception of
> Apparently this bug is still present in both the released clang-9
> and the current development version of clang-10.
> I was hoping we would not need a workaround in clang-9+, but
> it seems that we do.
I think I'd rather:
1. mark AMDGPU BROKEN if CC_IS_CLANG. There are numerous other issues
dcn20_resource.c:2636:9: error: missing braces around initializer
[-Werror=missing-braces]
struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES]
= {0};
^
Fixes: 7ed4e6352c16f ("drm/amd/display: Add DCN2 HW Sequencer and Resource")
Signed-off-by: Raul E Rangel
śr., 2 paź 2019 o 16:40 Daniel Thompson napisał(a):
>
> On Wed, Oct 02, 2019 at 01:46:17PM +0200, Bartosz Golaszewski wrote:
> > śr., 2 paź 2019 o 12:33 Daniel Thompson
> > napisał(a):
> > >
> > > On Tue, Oct 01, 2019 at 02:58:37PM +0200, Bartosz Golaszewski wrote:
> > > > From: Bartosz
Convert the STM32 display binding to DT schema format using json-schema.
Split the original bindings in two yaml files:
- one for display controller (ltdc)
- one for DSI controller
Signed-off-by: Benjamin Gaignard
---
.../devicetree/bindings/display/st,stm32-dsi.yaml | 130 +++
Hi Laurent,
Thanks for the feedback.
> Subject: Re: [PATCH] dt-bindings: display: renesas: Add r8a774b1 support
>
> Hi Biju,
>
> Thank you for the patch.
>
> On Mon, Sep 30, 2019 at 10:28:51AM +0100, Biju Das wrote:
> > Document RZ/G2N (R8A774B1) SoC bindings.
> >
> > Signed-off-by: Biju Das
On Wed, Oct 2, 2019 at 5:03 AM Arnd Bergmann wrote:
>
> Just like all the other variants, this one passes invalid
> compile-time options with clang after the new code got
> merged:
>
> clang: error: unknown argument: '-mpreferred-stack-boundary=4'
> scripts/Makefile.build:265: recipe for target
On Thu, 3 Oct 2019 09:45:55 +0300 Jaak Ristioja wrote:
> On 30.09.19 16:29, Frediano Ziglio wrote:
> > Why didn't you update bug at
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813620?
> > I know it can seem tedious but would help tracking it.
>
> I suppose the lack on
On Wed, Oct 2, 2019 at 10:07 AM Nathan Chancellor
wrote:
>
> On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built
> Linux wrote:
> > > Apparently this bug is still present in both the released clang-9
> > > and the current development version of clang-10.
> > > I was
The amdgpu_vm interval tree really wants [a, b) intervals,
not fully closed ones. As such convert it to use the new
interval_tree_gen.h, and also rename the 'last' endpoint
in the node to 'end', which is both a more suitable name
for the half closed interval and also reduces the chances
of missing
On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
>
> On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
> > > However, if I encourage arbitrary tests/improvements into my KUnit
> > > branch, it further diverges away from torvalds/master, and is more
> > > likely that there will be a
https://bugzilla.kernel.org/show_bug.cgi?id=204241
a...@tutanota.com changed:
What|Removed |Added
CC||a...@tutanota.com
--- Comment #14
On 10/4/19 6:33 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:57 PM shuah wrote:
On 10/4/19 5:52 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
However, if I encourage arbitrary
On Fri, Oct 4, 2019 at 4:57 PM shuah wrote:
>
> On 10/4/19 5:52 PM, Brendan Higgins wrote:
> > On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
> >>
> >> On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
> However, if I encourage arbitrary tests/improvements into my KUnit
>
On Fri, Oct 4, 2019 at 5:49 PM shuah wrote:
>
> On 10/4/19 6:33 PM, Brendan Higgins wrote:
> > On Fri, Oct 4, 2019 at 4:57 PM shuah wrote:
> >>
> >> On 10/4/19 5:52 PM, Brendan Higgins wrote:
> >>> On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
>
> On Fri, Oct 04, 2019 at
On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
> > However, if I encourage arbitrary tests/improvements into my KUnit
> > branch, it further diverges away from torvalds/master, and is more
> > likely that there will be a merge conflict or issue that is not related
> > to the core KUnit
Hi Daniel, Gerd,
On Tue, Sep 17, 2019 at 10:23 PM Daniel Vetter wrote:
>
> On Thu, Sep 12, 2019 at 06:41:21PM +0900, Tomasz Figa wrote:
> > This patch is an early RFC to judge the direction we are following in
> > our virtualization efforts in Chrome OS. The purpose is to start a
> > discussion
On Thu, Oct 3, 2019 at 5:15 PM Maxime Ripard wrote:
> > > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> > > > Signed-off-by: Jonathan Neuschäfer
> > >
> > > Both patches applied!
> >
> > ...but I can't push the changes:
> >
> > $ dim push-branch drm-misc-next
> >
On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
> On 10/4/19 3:42 PM, Linus Torvalds wrote:
> > On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
> > >
> > > This question is primarily directed at Shuah and Linus
> > >
> > > What's the current status of the kunit series now that
On 10/4/19 4:27 PM, Brendan Higgins wrote:
On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
On 10/4/19 3:42 PM, Linus Torvalds wrote:
On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
This question is primarily directed at Shuah and Linus
What's the current status of the
On Fri, Oct 4, 2019 at 3:47 PM shuah wrote:
>
> On 10/4/19 4:27 PM, Brendan Higgins wrote:
> > On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
> >> On 10/4/19 3:42 PM, Linus Torvalds wrote:
> >>> On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
>
> This question is
On 10/4/19 5:10 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 3:47 PM shuah wrote:
On 10/4/19 4:27 PM, Brendan Higgins wrote:
On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote:
On 10/4/19 3:42 PM, Linus Torvalds wrote:
On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote:
This
On 10/4/19 5:52 PM, Brendan Higgins wrote:
On Fri, Oct 4, 2019 at 4:30 PM Theodore Y. Ts'o wrote:
On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote:
However, if I encourage arbitrary tests/improvements into my KUnit
branch, it further diverges away from torvalds/master, and is more
On Thu, Oct 03, 2019 at 02:35:02PM -0700, Matthias Kaehlcke wrote:
> Add curly braces to an 'else' branch in pwm_backlight_update_status()
> to match the corresponding 'if' branch.
>
> Signed-off-by: Matthias Kaehlcke
Reviewed-by: Daniel Thompson
> ---
>
> drivers/video/backlight/pwm_bl.c |
The "used" variables here come from the user in the ioctl and it can be
negative. It could result in an out of bounds write.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i810/i810_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i810/i810_dma.c
From: Raymond Smith
Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to
denote the 16x16 block u-interleaved format used in Arm Utgard and
Midgard GPUs.
Changes from v1:-
1. Reserved the upper four bits (out of the 56 bits assigned to each vendor)
to denote the category of Arm
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^/\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. Fix also DRM_AMD_DC_HDCP (new arrival since v1).
---
drivers/gpu/drm/Kconfig
Convert Samsung S3C/S5P/Exynos Serial/UART bindings to DT schema format
using json-schema.
Signed-off-by: Krzysztof Kozlowski
---
.../bindings/mfd/samsung,exynos5433-lpass.txt | 2 +-
.../bindings/serial/samsung_uart.txt | 58 ---
.../bindings/serial/samsung_uart.yaml |
The clkoutN names of clocks must be unique because they represent
unique inputs of clock multiplexer.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Array elements under 'items' should be indented.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
On 04/10/2019 16:03, Neil Armstrong wrote:
> On 04/10/2019 16:53, Grodzovsky, Andrey wrote:
>>
>> On 10/3/19 4:34 AM, Neil Armstrong wrote:
>>> Hi Andrey,
>>>
>>> Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit :
On 9/30/19 10:52 AM, Hillf Danton wrote:
> On Mon, 30 Sep 2019 11:17:45
Am 04.10.19 um 17:27 schrieb Steven Price:
> On 04/10/2019 16:03, Neil Armstrong wrote:
>> On 04/10/2019 16:53, Grodzovsky, Andrey wrote:
>>> On 10/3/19 4:34 AM, Neil Armstrong wrote:
Hi Andrey,
Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit :
> On 9/30/19 10:52 AM, Hillf
On 04/10/2019 16:34, Koenig, Christian wrote:
> Am 04.10.19 um 17:27 schrieb Steven Price:
>> On 04/10/2019 16:03, Neil Armstrong wrote:
>>> On 04/10/2019 16:53, Grodzovsky, Andrey wrote:
On 10/3/19 4:34 AM, Neil Armstrong wrote:
> Hi Andrey,
>
> Le 02/10/2019 à 16:40, Grodzovsky,
From: Colin Ian King
The pointer disable_done is being initialized with a value that
is never read and is being re-assigned a little later on. The
assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
On Fri, Oct 04, 2019 at 02:12:38PM +, Ayan Halder wrote:
> From: Raymond Smith
>
> Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to
> denote the 16x16 block u-interleaved format used in Arm Utgard and
> Midgard GPUs.
>
> Changes from v1:-
> 1. Reserved the upper four bits
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^/\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski
---
arch/Kconfig | 4 ++--
arch/alpha/Kconfig | 2 +-
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^/\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski
---
certs/Kconfig | 14 ++---
init/Kconfig | 28 +-
On Fri, Oct 04, 2019 at 06:15:11AM -0700, Michel Lespinasse wrote:
> My take is that this (Davidlohr's) patch series does not necessarily
> need to be applied all at once - we could get the first change in
> (adding the interval_tree_gen.h header), and convert the first few
> users, without
https://bugs.freedesktop.org/show_bug.cgi?id=111599
Chris Wilson changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Quoting Dan Carpenter (2019-10-04 11:22:51)
> The "used" variables here come from the user in the ioctl and it can be
> negative. It could result in an out of bounds write.
>
> Signed-off-by: Dan Carpenter
> ---
> drivers/gpu/drm/i810/i810_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
To support transmitters other than the tda998x, we need to allow
non-component framework bridges to be attached to a dummy drm_encoder in
our driver.
For the existing supported encoder (tda998x), keep the behaviour as-is,
since there's no way to unbind if a drm_bridge module goes away under
our
struct komeda_drv has two pointer members only, and both
it and its members get allocated separately. Since both
members' types are in scope, there's not a lot to gain by
keeping the indirection around.
To avoid double-free issues, provide a barebones ->release()
hook for the driver.
Greetings,
This series attempts to add support for endpoints (in the DT sense)
whose drivers only have a drm_bridge interface, unlike the tda998x,
which uses the component framework and provides all of drm_encoder,
drm_bridge, drm_connector.
1 & 2 should be fairly non-contentious, and I believe
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
> From: Tomi Valkeinen
>
> This patch adds a led-backlight driver (led_bl), which is similar to
> pwm_bl except the driver uses a LED class driver to adjust the
> brightness in the HW. Multiple LEDs can be used for a single backlight.
>
>
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
> Add DT binding for led-backlight.
>
> Signed-off-by: Jean-Jacques Hiblot
> Reviewed-by: Daniel Thompson
> ---
> .../bindings/leds/backlight/led-backlight.txt | 28 +++
> 1 file changed, 28 insertions(+)
> create mode 100644
>
On Fri, Oct 04, 2019 at 03:33:13PM +0200, Jean-Jacques Hiblot wrote:
> On 04/10/2019 13:39, Mark Brown wrote:
> > Consumers should just be able to request a regulator without having to
> > worry about how that's being provided - they should have no knowledge at
> > all of firmware bindings or
On 04/10/2019 16:53, Grodzovsky, Andrey wrote:
>
> On 10/3/19 4:34 AM, Neil Armstrong wrote:
>> Hi Andrey,
>>
>> Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit :
>>> On 9/30/19 10:52 AM, Hillf Danton wrote:
On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote:
> Did a new run from
On 04/10/2019 16:40, Mark Brown wrote:
On Fri, Oct 04, 2019 at 03:33:13PM +0200, Jean-Jacques Hiblot wrote:
On 04/10/2019 13:39, Mark Brown wrote:
Consumers should just be able to request a regulator without having to
worry about how that's being provided - they should have no knowledge at
On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote:
> This panel (manufacturer is SDC, product ID is 0x4141)
> used manufacturer defined DPCD register to control brightness
> that not defined in eDP spec so far. This change follow panel
> vendor's instruction to support brightness adjustment.
Hi Lee,
On 04/10/2019 16:39, Lee Jones wrote:
On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
From: Tomi Valkeinen
This patch adds a led-backlight driver (led_bl), which is similar to
pwm_bl except the driver uses a LED class driver to adjust the
brightness in the HW. Multiple LEDs can be
On 04/10/2019 17:58, Mark Brown wrote:
On Fri, Oct 04, 2019 at 05:13:13PM +0200, Jean-Jacques Hiblot wrote:
On 04/10/2019 16:40, Mark Brown wrote:
Why is the LED core populating anything? Is the LED core copying bits
out of the struct device for the actual device into a synthetic device
Hi guys,
I'm Lorrany Azevedo, and I'm participating in the application phase for the
outreachy internships. I'm interested in making a contribution to VKMS, and
I would like to ask for tips on how I can do this, I'm new to the
community and I never made any contribution to the FOSS.
From: Ville Syrjälä
Extract the logic to compute the final CEA VIC to a small helper.
We'll reorder it a bit to make future modifications more
straightforward. No function changes.
Cc: Wayne Lin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 53
From: Ville Syrjälä
I think this should provide most of necessary logic for
adding aspecr ratios to the HDMI 4k modes.
Cc: Wayne Lin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 37 +++--
1 file changed, 31 insertions(+), 6 deletions(-)
diff
From: Ville Syrjälä
drm_get_cea_aspect_ratio() is not used outside drm_edid.c.
Make it static.
Cc: Wayne Lin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 10 +-
include/drm/drm_edid.h | 1 -
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git
From: Ville Syrjälä
Extract drm_mode_hdmi_vic() to correctly calculate the final HDMI
VIC for us. Currently this is being done a bit differently between
the AVI and HDMI infoframes. Let's get both to agree on this.
We need to allow the case where a mode is both 3D and has a HDMI
VIC. Currently
On Fri, Oct 04, 2019 at 10:41:20AM +, Lin, Wayne wrote:
>
>
>
> From: Ville Syrjälä
> Sent: Thursday, October 3, 2019 21:29
> To: Lin, Wayne
> Cc: dri-devel@lists.freedesktop.org ;
> amd-...@lists.freedesktop.org ; Li, Sun peng
> (Leo) ; Kazlauskas,
Some fields of komeda_drv members will be useful very early
in probe code, so make sure an instance is available.
Signed-off-by: Mihail Atanassov
---
.../gpu/drm/arm/display/komeda/komeda_drv.c | 30 +++
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git
devm_regulator_get() is used to populate pfdev->regulator which ensures
that this cannot be NULL (a dummy regulator will be returned if
necessary). So remove the check in panfrost_devfreq_target().
Signed-off-by: Steven Price
---
This looks like it was accidentally reintroduced by the merge from
On 10/3/19 4:34 AM, Neil Armstrong wrote:
> Hi Andrey,
>
> Le 02/10/2019 à 16:40, Grodzovsky, Andrey a écrit :
>> On 9/30/19 10:52 AM, Hillf Danton wrote:
>>> On Mon, 30 Sep 2019 11:17:45 +0200 Neil Armstrong wrote:
Did a new run from 5.3:
[ 35.971972] Call trace:
[
On Fri, Oct 4, 2019 at 11:08 AM Randy Dunlap wrote:
>
> On 10/3/19 10:59 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20191003:
> >
>
> on x86_64:
> CONFIG_DRM_AMDGPU=y
> # CONFIG_DRM_AMDGPU_SI is not set
> # CONFIG_DRM_AMDGPU_CIK is not set
> CONFIG_DRM_AMDGPU_USERPTR=y
>
On Fri, Oct 04, 2019 at 05:13:13PM +0200, Jean-Jacques Hiblot wrote:
> On 04/10/2019 16:40, Mark Brown wrote:
> > Why is the LED core populating anything? Is the LED core copying bits
> > out of the struct device for the actual device into a synthetic device
> > rather than passing the actual
Quoting Chris Wilson (2019-10-04 15:08:57)
> Quoting Dan Carpenter (2019-10-04 11:22:51)
> > The "used" variables here come from the user in the ioctl and it can be
> > negative. It could result in an out of bounds write.
> >
> > Signed-off-by: Dan Carpenter
> > ---
> >
On Thu, Oct 03, 2019 at 10:27:26PM +0200, Jacek Anaszewski wrote:
> On 10/3/19 9:41 PM, Mark Brown wrote:
> > Why would we want to do that? We'd continue to support only DT systems,
> > just with code that's less obviously DT only and would need to put
> > checks in. I'm not seeing an upside
Quoting Zbigniew Kempczyński (2019-10-04 13:16:52)
> Remove dead code, likely overseened during review process.
Hint: It's not dead.
-Chris
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
1 - 100 of 164 matches
Mail list logo