Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Hans de Goede
Hi, On 11-11-2019 10:25, Daniel Vetter wrote: On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching a video= argument over calculating our own timings for the user specified mode using CVT or GTF. But userspace code

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2019 at 10:50 AM Hans de Goede wrote: > > Hi, > > On 11-11-2019 10:25, Daniel Vetter wrote: > > On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: > >> > >> drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > >> a video= argument over calculating our own

[PATCH] drm/amd/powerplay: remove set but not used variable 'threshold', 'state'

2019-11-11 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c: In function fiji_populate_single_graphic_level: drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c:943:11: warning: variable threshold set but not used [-Wunused-but-set-variable]

[PATCH 1/2] drm/amd/powerplay: remove set but not used variable 'vbios_version', 'data'

2019-11-11 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function smu7_check_mc_firmware: drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:4215:11: warning: variable vbios_version set but not used [-Wunused-but-set-variable]

[PATCH 0/2] remove some set but not used variables in hwmgr

2019-11-11 Thread zhengbin
zhengbin (2): drm/amd/powerplay: remove set but not used variable 'vbios_version','data' drm/amd/powerplay: remove set but not used variable 'data' drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 -- 2 files changed, 6

Re: [BACKPORT 4.14.y 04/18] usb: dwc3: Allow disabling of metastability workaround

2019-11-11 Thread Greg KH
On Wed, Sep 11, 2019 at 08:01:40AM -0600, Mathieu Poirier wrote: > On Tue, 10 Sep 2019 at 08:36, Greg KH wrote: > > > > On Thu, Sep 05, 2019 at 10:17:45AM -0600, Mathieu Poirier wrote: > > > From: Roger Quadros > > > > > > commit 42bf02ec6e420e541af9a47437d0bdf961ca2972 upstream > > > > > > Some

Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table

2019-11-11 Thread Lee Jones
On Fri, 18 Oct 2019, Arnd Bergmann wrote: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc:

[Bug 112243] Micro stuttering in RocketLeague

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112243 --- Comment #1 from Matthias Heinz --- Created attachment 145933 --> https://bugs.freedesktop.org/attachment.cgi?id=145933=edit Shader clock and fps after setting performance level to high -- You are receiving this mail because: You are the

[Bug 112243] Micro stuttering in RocketLeague

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112243 Bug ID: 112243 Summary: Micro stuttering in RocketLeague Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Hans de Goede
Hi Daniel, On 11-11-2019 11:26, Daniel Vetter wrote: On Mon, Nov 11, 2019 at 10:50 AM Hans de Goede wrote: Hi, On 11-11-2019 10:25, Daniel Vetter wrote: On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching a video=

Re: [PATCH 15/16] drm/etnaviv: use ktime_t for timeouts

2019-11-11 Thread Lucas Stach
On Sa, 2019-11-09 at 13:12 +0100, Arnd Bergmann wrote: > On Sat, Nov 9, 2019 at 12:03 AM Lucas Stach wrote: > > Am Freitag, den 08.11.2019, 22:32 +0100 schrieb Arnd Bergmann: > > > struct timespec is being removed from the kernel because it often leads > > > to code that is not y2038-safe. > > >

Patch "ASoC: davinci-mcasp: Fix an error handling path in 'davinci_mcasp_probe()'" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled ASoC: davinci-mcasp: Fix an error handling path in 'davinci_mcasp_probe()' to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "ASoC: tlv320aic31xx: Handle inverted BCLK in non-DSP modes" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled ASoC: tlv320aic31xx: Handle inverted BCLK in non-DSP modes to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "ASoC: davinci-mcasp: Handle return value of devm_kasprintf" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled ASoC: davinci-mcasp: Handle return value of devm_kasprintf to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "ASoC: davinci: Kill BUG_ON() usage" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled ASoC: davinci: Kill BUG_ON() usage to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[Bug 112243] Micro stuttering in RocketLeague

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112243 --- Comment #2 from Matthias Heinz --- Created attachment 145934 --> https://bugs.freedesktop.org/attachment.cgi?id=145934=edit Shader clock and fps after setting performance level back to auto -- You are receiving this mail because: You

[PATCH 2/2] drm/amd/powerplay: remove set but not used variable 'data'

2019-11-11 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c: In function vega10_get_performance_level: drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c:5217:23: warning: variable data set but not used [-Wunused-but-set-variable] 'data' is introduced by

[Bug 112242] amdgpu [RX Vega 56]: ring sdma0 timeout

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112242 Bug ID: 112242 Summary: amdgpu [RX Vega 56]: ring sdma0 timeout Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Patch "i2c: omap: Trigger bus recovery in lockup case" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled i2c: omap: Trigger bus recovery in lockup case to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "mtd: spi-nor: cadence-quadspi: add a delay in write sequence" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled mtd: spi-nor: cadence-quadspi: add a delay in write sequence to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "PCI: dra7xx: Add shutdown handler to cleanly turn off clocks" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled PCI: dra7xx: Add shutdown handler to cleanly turn off clocks to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "usb: dwc3: Allow disabling of metastability workaround" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled usb: dwc3: Allow disabling of metastability workaround to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled mailbox: reset txdone_method TXDONE_BY_POLL if client knows_txdone to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "ASoC: tlv320dac31xx: mark expected switch fall-through" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled ASoC: tlv320dac31xx: mark expected switch fall-through to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "misc: pci_endpoint_test: Fix BUG_ON error during pci_disable_msi()" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled misc: pci_endpoint_test: Fix BUG_ON error during pci_disable_msi() to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "mfd: palmas: Assign the right powerhold mask for tps65917" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled mfd: palmas: Assign the right powerhold mask for tps65917 to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "misc: pci_endpoint_test: Prevent some integer overflows" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled misc: pci_endpoint_test: Prevent some integer overflows to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "mtd: spi-nor: enable 4B opcodes for mx66l51235l" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled mtd: spi-nor: enable 4B opcodes for mx66l51235l to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "cpufreq: ti-cpufreq: add missing of_node_put()" has been added to the 4.14-stable tree

2019-11-11 Thread gregkh
This is a note to let you know that I've just added the patch titled cpufreq: ti-cpufreq: add missing of_node_put() to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v7 0/9] backlight: gpio: simplify the driver

2019-11-11 Thread Lee Jones
On Tue, 22 Oct 2019, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > While working on my other series related to gpio-backlight[1] I noticed > that we could simplify the driver if we made the only user of platform > data use GPIO lookups and device properties. This series tries to do

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #229 from Marko Popovic --- (In reply to Shmerl from comment #228) > (In reply to John H from comment #227) > > > > specific one I can reproduce EVERY. SINGLE. TIME. was when playing Unreal > > Tournament 3 via Steam proton. The

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Daniel Vetter
On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: > > drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > a video= argument over calculating our own timings for the user specified > mode using CVT or GTF. > > But userspace code which is auto-configuring the mode may want

Re: [PATCH V10 8/8] backlight: qcom-wled: Add auto string detection logic

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > The auto string detection algorithm checks if the current WLED > sink configuration is valid. It tries enabling every sink and > checks if the OVP fault is observed. Based on this information > it detects and enables the valid sink configuration. > Auto

Re: [PATCH V10 5/8] backlight: qcom-wled: Restructure the driver for WLED3.

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > Restructure the driver to add the support for new WLED > peripherals. > > Signed-off-by: Kiran Gunda > Acked-by: Daniel Thompson > --- > drivers/video/backlight/qcom-wled.c | 373 > ++-- > 1 file changed, 234

Re: [PATCH V10 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > pm8941-wled.c driver is supporting the WLED peripheral > on pm8941. Rename it to qcom-wled.c so that it can support > WLED on multiple PMICs. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Acked-by: Rob Herring > Acked-by: Daniel

Re: [PATCH V10 6/8] backlight: qcom-wled: Add support for WLED4 peripheral.

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > WLED4 peripheral is present on some PMICs like pmi8998 and > pm660l. It has a different register map and configurations > are also different. Add support for it. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Reviewed-by: Daniel

Re: [PATCH V10 7/8] backlight: qcom-wled: add support for short circuit handling.

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > Handle the short circuit interrupt and check if the short circuit > interrupt is valid. Re-enable the module to check if it goes > away. Disable the module altogether if the short circuit event > persists. > > Signed-off-by: Kiran Gunda > Reviewed-by:

Re: [PATCH V10 3/8] backlight: qcom-wled: Add new properties for PMI8998.

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > Update the bindings with the new properties used for > PMI8998. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Reviewed-by: Rob Herring > Acked-by: Daniel Thompson > --- > .../bindings/leds/backlight/qcom-wled.txt | 74 >

Re: [PATCH V10 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > Rename the PM8941* references as WLED3 to make the driver > generic and have WLED support for other PMICs. Also rename > "i_boost_limit" and "i_limit" variables to "boost_i_limit" > and "string_i_limit" respectively to resemble the corresponding >

Re: [PATCH V10 2/8] backlight: qcom-wled: restructure the qcom-wled bindings.

2019-11-11 Thread Lee Jones
On Fri, 01 Nov 2019, Kiran Gunda wrote: > Restructure the qcom-wled bindings for the better readability. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Reviewed-by: Rob Herring > Acked-by: Daniel Thompson > Acked-by: Pavel Machek > --- >

[Bug 111329] [CI][SHARDS] igt@gem_ctx_isolation@vcs1-nonpriv - fail - igt@gem_ctx_isolation@vcs1-nonpriv - fail - Failed assertion: num_errors == 0, registers mistached between nonpriv read/writes

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111329 Francesco Balestrieri changed: What|Removed |Added Assignee|intel-gfx-bugs@lists.freede |dri-devel@lists.freedesktop

[Bug 193651] Amdgpu error messages at boot with Amd RX460

2019-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 jacky (jackysen...@gmail.com) changed: What|Removed |Added CC||jackysen...@gmail.com

[PATCH 3/4] drm/ttm: rework BO delayed delete.

2019-11-11 Thread Christian König
This patch reworks the whole delayed deletion of BOs which aren't idle. Instead of having two counters for the BO structure we resurrect the BO when we find that a deleted BO is not idle yet. This has many advantages, especially that we don't need to increment/decrement the BOs reference counter

[PATCH 2/4] drm/ttm: cleanup ttm_buffer_object_transfer

2019-11-11 Thread Christian König
The function is always called with deleted BOs. While at it cleanup the indentation as well. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 1/4] drm/ttm: refine ghost BO resv criteria

2019-11-11 Thread Christian König
Ghost BOs need to stick with the resv object only when the origin is imported. This is a low hanging fruit to avoid OOM situations on evictions. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] drm/ttm: replace dma_resv object on deleted BOs

2019-11-11 Thread Christian König
When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: Drm: mgag200. Video adapter issue with 5.4.0-rc3 ; no graphics

2019-11-11 Thread Thomas Zimmermann
Hi John Am 08.11.19 um 19:07 schrieb John Donnelly: > > >> On Nov 8, 2019, at 9:06 AM, Thomas Zimmermann wrote: >> >> Hi >> >> Am 08.11.19 um 13:55 schrieb John Donnelly: >>> >>> On Nov 8, 2019, at 1:46 AM, Thomas Zimmermann wrote: Hi John Am 07.11.19 um 23:14 schrieb

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Ville Syrjälä
On Mon, Nov 11, 2019 at 10:50:42AM +0100, Hans de Goede wrote: > Hi, > > On 11-11-2019 10:25, Daniel Vetter wrote: > > On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: > >> > >> drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching > >> a video= argument over calculating

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2019-11-11 Thread Jacopo Mondi
Hello, On Mon, Nov 11, 2019 at 11:21:28AM +, Kalakodima Venkata Rajesh (RBEI/ECF3) wrote: > Hi Jacopo, > > Please find comments below. > > Best regards, > > Rajesh Kv > RBEI/ECF3 > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf

Re: [PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity

2019-11-11 Thread Liviu Dudau
On Thu, Nov 07, 2019 at 11:42:28AM +, Mihail Atanassov wrote: > Named 'err_verbosity', currently with only 1 active bit in that > replicates the existing level - print error events once per flip. > > Reviewed-by: James Qian Wang (Arm Technology China) > Signed-off-by: Mihail Atanassov

Re: [PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-11 Thread Steven Price
On 04/11/2019 17:37, Daniel Vetter wrote: > Full audit of everyone: > > - i915, radeon, amdgpu should be clean per their maintainers. > > - vram helpers should be fine, they don't do command submission, so > really no business holding struct_mutex while doing copy_*_user. But > I haven't

Re: [PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2019 at 2:11 PM Steven Price wrote: > > On 04/11/2019 17:37, Daniel Vetter wrote: > > Full audit of everyone: > > > > - i915, radeon, amdgpu should be clean per their maintainers. > > > > - vram helpers should be fine, they don't do command submission, so > > really no business

Re: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity

2019-11-11 Thread Liviu Dudau
On Thu, Nov 07, 2019 at 11:42:44AM +, Mihail Atanassov wrote: > It's possible to get multiple events in a single frame/flip, so add an > option to print them all. > > Reviewed-by: James Qian Wang (Arm Technology China) > Signed-off-by: Mihail Atanassov For the whole series: Acked-by:

Re: [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution"

2019-11-11 Thread Kazlauskas, Nicholas
On 2019-11-09 2:49 p.m., Colin King wrote: From: Colin Ian King There are spelling mistakes in a DC_ERROR message and a comment. Fix these. Signed-off-by: Colin Ian King Reviewed-by: Nicholas Kazlauskas Thanks! Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c

Re: [PATCH] drm/amd/display: remove duplicated comparison expression

2019-11-11 Thread Kazlauskas, Nicholas
On 2019-11-09 10:49 a.m., Colin King wrote: From: Colin Ian King There is comparison expression that is duplicated and hence one of the expressions can be removed. Remove it. Addresses-Coverity: ("Same on both sides") Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual

Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

2019-11-11 Thread Ville Syrjälä
On Mon, Nov 11, 2019 at 01:43:52AM +, allen.c...@ite.com.tw wrote: > Hi Ville Syrjälä > > Thanks for your suggestion and I have replied two comments below. > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, November 07, 2019 11:42 PM > To: Allen Chen (陳柏宇) >

Re: [PATCH 09/12] drm/modes: parse_cmdline: Add support for specifying panel_orientation

2019-11-11 Thread Maxime Ripard
Hi Hans, Thanks for this series (and thanks for bouncing the mails too). All the previous patches are Acked-by: Maxime Ripard On Sun, Nov 10, 2019 at 04:40:58PM +0100, Hans de Goede wrote: > Sometimes we want to override a connector's panel_orientation from the > kernel commandline. Either for

[PULL] topic/drm-mipi-dsi-dsc-updates

2019-11-11 Thread Jani Nikula
Hi Sean, Maarten and Maxime - Here's the topic branch about DSI changes as I wrote in [1]. Once you've pulled this in drm-misc, I'll follow suit in i915. Thanks, Jani. [1] http://marc.info/?i=87sgmz6cw0@intel.com topic/drm-mipi-dsi-dsc-updates-2019-11-11: Core Changes: - Update DSI

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2019 at 12:06 PM Hans de Goede wrote: > > Hi Daniel, > > On 11-11-2019 11:26, Daniel Vetter wrote: > > On Mon, Nov 11, 2019 at 10:50 AM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 11-11-2019 10:25, Daniel Vetter wrote: > >>> On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede

Re: [PATCH] staging: fbtft: Remove set but not used variable 'ret'

2019-11-11 Thread Greg KH
On Sun, Nov 10, 2019 at 06:57:07PM +0800, Zheng Yongjun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/staging/fbtft/fb_ili9320.c: In function read_devicecode: > drivers/staging/fbtft/fb_ili9320.c:25:6: warning: variable ret set but not > used [-Wunused-but-set-variable] >

[radeon-alex:amd-mainline-dkms-5.2 2104/2834] drivers/gpu/drm/ttm/ttm_bo_manager.c:60:36: error: 'DRM_MM_SEARCH_BEST' undeclared

2019-11-11 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2 head: a48b0cc1cdf3900e3e73801f9de64afbb70dc193 commit: 769e4dc19ad658720b779070764db2fc10a0bbac [2104/2834] drm/amdkcl: Test whether drm_mm_insert_mode is available config: x86_64-randconfig-a004-201944 (attached as

[PATCH 1/2] drm/etnaviv: reject timeouts with tv_nsec >= NSEC_PER_SEC

2019-11-11 Thread Arnd Bergmann
Most kernel interfaces that take a timespec require normalized representation with tv_nsec between 0 and NSEC_PER_SEC. Passing values larger than 0x1ull further behaves differently on 32-bit and 64-bit kernels, and can cause the latter to spend a long time counting seconds in

[PATCH 2/2] [v2] drm/etnaviv: avoid deprecated timespec

2019-11-11 Thread Arnd Bergmann
struct timespec is being removed from the kernel because it often leads to code that is not y2038-safe. In the etnaviv driver, monotonic timestamps are used, which do not suffer from overflow, but the usage of timespec here gets in the way of removing the interface completely. Pass down the

Re: [PATCH 15/16] drm/etnaviv: use ktime_t for timeouts

2019-11-11 Thread Arnd Bergmann
On Mon, Nov 11, 2019 at 10:55 AM Lucas Stach wrote: > > > > > If that's the case then we should never encounter a genuine 0 timeout > > > and this change would be okay. > > > > That's quite likely, I'd say any program passing {0,0} as a timeout without > > ETNA_WAIT_NONBLOCK is already broken,

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

2019-11-11 Thread Adam Ford
On Fri, Nov 1, 2019 at 2:57 AM Laurent Pinchart wrote: > > On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote: > > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford wrote: > > > > > > Previously, there was an omap panel-dpi driver that would > > > read generic timings from the device tree and set

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Hans de Goede
Hi, On 11-11-2019 15:11, Ville Syrjälä wrote: On Mon, Nov 11, 2019 at 10:50:42AM +0100, Hans de Goede wrote: Hi, On 11-11-2019 10:25, Daniel Vetter wrote: On Sun, Nov 10, 2019 at 7:41 PM Hans de Goede wrote: drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching a video=

[Bug 205185] amdgpu compile failure

2019-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205185 Stijn Tintel (stijn+b...@linux-ipv6.be) changed: What|Removed |Added Kernel Version|5.3.5 - 5.3.6 |5.3.5 - 5.3.10

Re: [PATCH] drm/amd/display: remove duplicated comparison expression

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas wrote: > > On 2019-11-09 10:49 a.m., Colin King wrote: > > From: Colin Ian King > > > > There is comparison expression that is duplicated and hence one > > of the expressions can be removed. Remove it. > > > >

Re: Drm: mgag200. Video adapter issue with 5.4.0-rc3 ; no graphics

2019-11-11 Thread John Donnelly
On 11/11/19 9:57 AM, Thomas Zimmermann wrote: Hi John Am 08.11.19 um 19:07 schrieb John Donnelly: On Nov 8, 2019, at 9:06 AM, Thomas Zimmermann wrote: Hi Am 08.11.19 um 13:55 schrieb John Donnelly: On Nov 8, 2019, at 1:46 AM, Thomas Zimmermann wrote: Hi John Am 07.11.19 um 23:14

[PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Gustavo A. R. Silva
Currenly, the error check below on variable *vcpi_slots* is always false because it is a uint64_t type variable, hence, the values this variable can hold are never less than zero: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 4870 if (dm_new_connector_state->vcpi_slots < 0) { 4871

[Bug 111922] amdgpu fails to resume on 5.2 kernel [regression]

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111922 --- Comment #9 from Marek Olšák --- Userspace doesn't know when suspend/resume is happening, so it can't hang on suspend/resume. My guess is it's something in DAL. -- You are receiving this mail because: You are the assignee for the

[PATCH 1/2] drm: replace incorrect Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions

2019-11-11 Thread Bjorn Helgaas
From: Bjorn Helgaas Add definitions for these PCIe Link Control 2 register fields: Enter Compliance Transmit Margin and use them in amdgpu and radeon. NOTE: This is a functional change because "7 << 9" was apparently a typo. That mask included the high order bit of Transmit Margin, the

[PATCH v2 0/2] drm: replace magic numbers

2019-11-11 Thread Bjorn Helgaas
From: Bjorn Helgaas amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register, some of it using hard-coded magic numbers. The idea here is to replace those with #defines. I don't intend the Target Link Speed patch to change anything, so it should be straightforward to review.

[PATCH 2/2] drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2 definitions

2019-11-11 Thread Bjorn Helgaas
From: Bjorn Helgaas Replace hard-coded magic numbers with the descript PCI_EXP_LNKCTL2 definitions. No functional change intended. Signed-off-by: Bjorn Helgaas Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/cik.c | 8 drivers/gpu/drm/amd/amdgpu/si.c | 8

Re: [PATCH] drm/amd/display: Use static const, not const static

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 9:11 AM zhengbin wrote: > > Move the static keyword to the front of declarations. > > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[radeon-alex:amd-mainline-dkms-5.2 2158/2834] drivers/gpu/drm/ttm/ttm_bo_vm.c:128:6: error: 'vma' undeclared

2019-11-11 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2 head: a48b0cc1cdf3900e3e73801f9de64afbb70dc193 commit: 607b18ba116eb1642b01fb9d38a164cc492e9044 [2158/2834] drm/amdkcl: Test whether vm_fault->{address/vma} is available config: x86_64-randconfig-a004-201944 (attached

[radeon-alex:amd-mainline-dkms-5.2 2114/2834] drivers/gpu/drm/ttm/ttm_bo_manager.c:170:2: error: implicit declaration of function 'drm_mm_debug_table'

2019-11-11 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2 head: a48b0cc1cdf3900e3e73801f9de64afbb70dc193 commit: 57d7e98d0257bd9795dd3f438d19aa5476554685 [2114/2834] drm/amdkcl: Test whether drm_{mm_print/debug_printer} is available config: x86_64-randconfig-a004-201944

Re: [PATCH][next] drm/amd/display: fix spelling mistake "exeuction" -> "execution"

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 8:37 AM Kazlauskas, Nicholas wrote: > > On 2019-11-09 2:49 p.m., Colin King wrote: > > From: Colin Ian King > > > > There are spelling mistakes in a DC_ERROR message and a comment. > > Fix these. > > > > Signed-off-by: Colin Ian King > >

Re: [PATCH 0/2] remove some set but not used variables in hwmgr

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Nov 10, 2019 at 11:04 PM Quan, Evan wrote: > > Series is reviewed-by: Evan Quan > > > -Original Message- > > From: zhengbin > > Sent: Monday, November 11, 2019 11:46 AM > > To: rex@amd.com; Quan, Evan ; Deucher, > > Alexander ; Koenig, Christian > >

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'bpc'

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Nov 10, 2019 at 9:30 PM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function > get_pbn_from_timing: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:2364:11:

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Gustavo A. R. Silva
On 11/11/19 11:46, Mikita Lipski wrote: > > Thanks for catching it! > Glad to help out. :) > Reviewed-by: Mikita Lipski > Thanks -- Gustavo > > On 11.11.2019 12:25, Gustavo A. R. Silva wrote: >> Currenly, the error check below on variable*vcpi_slots*  is always >> false because it is a

[Bug 205185] amdgpu compile failure

2019-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205185 --- Comment #2 from Stijn Tintel (stijn+b...@linux-ipv6.be) --- Thanks. Enabling that symbol fixes the compile failure. This wasn't a problem in 5.3.0 - 5.3.4, so there's a regression introduced in 5.3.5, which should still be fixed. Probably

Re: [PATCH] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

2019-11-11 Thread Hans de Goede
Hi, On 11-11-2019 16:40, Daniel Vetter wrote: On Mon, Nov 11, 2019 at 12:06 PM Hans de Goede wrote: Hi Daniel, On 11-11-2019 11:26, Daniel Vetter wrote: On Mon, Nov 11, 2019 at 10:50 AM Hans de Goede wrote: Hi, On 11-11-2019 10:25, Daniel Vetter wrote: On Sun, Nov 10, 2019 at 7:41 PM

[PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-11 Thread Arnd Bergmann
ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Change the only driver that still references ioremap_uc() to only do so on x86-32/ia64 in order to

Re: [PATCH] drm/amd/powerplay: remove set but not used variable 'threshold', 'state'

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 3:07 AM zhengbin wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c: In function > fiji_populate_single_graphic_level: > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c:943:11:

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'ds_port'

2019-11-11 Thread Alex Deucher
Applied. thanks! Alex On Sun, Nov 10, 2019 at 9:29 PM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function > dp_wa_power_up_0010FA: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2320:35:

Re: [PATCH 09/12] drm/modes: parse_cmdline: Add support for specifying panel_orientation

2019-11-11 Thread Hans de Goede
Hi, On 11-11-2019 13:53, Maxime Ripard wrote: Hi Hans, Thanks for this series (and thanks for bouncing the mails too). All the previous patches are Acked-by: Maxime Ripard Thank you for the review. On Sun, Nov 10, 2019 at 04:40:58PM +0100, Hans de Goede wrote: Sometimes we want to

[Bug 111922] amdgpu fails to resume on 5.2 kernel [regression]

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111922 --- Comment #8 from Alex Deucher --- (In reply to Pierre Ossman from comment #7) > I finally got a build environment set up, and the winner is: > > > df8368be1382b442384507a5147c89978cd60702 is the first bad commit > > commit

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Mikita Lipski
Thanks for catching it! Reviewed-by: Mikita Lipski On 11.11.2019 12:25, Gustavo A. R. Silva wrote: Currenly, the error check below on variable*vcpi_slots* is always false because it is a uint64_t type variable, hence, the values this variable can hold are never less than zero:

[Bug 205185] amdgpu compile failure

2019-11-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205185 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'bpc'

2019-11-11 Thread Alex Deucher
On Mon, Nov 11, 2019 at 1:01 PM Alex Deucher wrote: > > Applied. Thanks! I've dropped this as it leads to a warning in the code since get_color_depth is no longer used. Care to fix that up as well? Thanks! Alex > > Alex > > On Sun, Nov 10, 2019 at 9:30 PM YueHaibing wrote: > > > > Fixes

[PATCH v3 01/23] mm/gup: pass flags arg to __gup_device_* functions

2019-11-11 Thread John Hubbard
A subsequent patch requires access to gup flags, so pass the flags argument through to the __gup_device_* functions. Also placate checkpatch.pl by shortening a nearby line. Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Cc: Kirill A. Shutemov Signed-off-by: John Hubbard --- mm/gup.c | 28

[PATCH v3 03/23] mm/gup: move try_get_compound_head() to top, fix minor issues

2019-11-11 Thread John Hubbard
An upcoming patch uses try_get_compound_head() more widely, so move it to the top of gup.c. Also fix a tiny spelling error and a checkpatch.pl warning. Signed-off-by: John Hubbard --- mm/gup.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git

[PATCH v3 05/23] goldish_pipe: rename local pin_user_pages() routine

2019-11-11 Thread John Hubbard
1. Avoid naming conflicts: rename local static function from "pin_user_pages()" to "pin_goldfish_pages()". An upcoming patch will introduce a global pin_user_pages() function. Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Signed-off-by: John Hubbard ---

[PATCH v3 06/23] IB/umem: use get_user_pages_fast() to pin DMA pages

2019-11-11 Thread John Hubbard
And get rid of the mmap_sem calls, as part of that. Note that get_user_pages_fast() will, if necessary, fall back to __gup_longterm_unlocked(), which takes the mmap_sem as needed. Reviewed-by: Ira Weiny Cc: Jason Gunthorpe Signed-off-by: John Hubbard --- drivers/infiniband/core/umem.c | 17

[PATCH v3 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

2019-11-11 Thread John Hubbard
As it says in the updated comment in gup.c: current FOLL_LONGTERM behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the FS DAX check requirement on vmas. However, the corresponding restriction in get_user_pages_remote() was slightly stricter than is actually required: it forbade all

variable refresh rate API

2019-11-11 Thread Jacob Lifshay
Not sure if this was suggested before -- I couldn't find any relevant threads from a google search: One solution to the problem of applications submitting a frame scheduled a long ways into the future then immediately after that getting user input and wanting to present a new frame right away is

Re: [PATCH v2 04/18] media/v4l2-core: set pages dirty upon releasing DMA buffers

2019-11-11 Thread John Hubbard
On 11/10/19 2:10 AM, Hans Verkuil wrote: > On 11/3/19 10:17 PM, John Hubbard wrote: >> After DMA is complete, and the device and CPU caches are synchronized, >> it's still required to mark the CPU pages as dirty, if the data was >> coming from the device. However, this driver was just issuing a >>

[Bug 112234] [REGRESSION] navi10: writing to pp_table fails (5.4-rc6 = working)

2019-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112234 Matt Coffin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 2:44 PM Gustavo A. R. Silva wrote: > > > > On 11/11/19 11:46, Mikita Lipski wrote: > > > > Thanks for catching it! > > > > Glad to help out. :) > > > Reviewed-by: Mikita Lipski > > > > Thanks > -- > Gustavo > > > > > On 11.11.2019 12:25, Gustavo

  1   2   >