Re: [PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-05-31 Thread Sidong Yang
On Sun, May 24, 2020 at 07:42:25AM +1000, David Airlie wrote: > On Sun, May 24, 2020 at 2:02 AM Sidong Yang wrote: > > > > Hi, Dave. > > > > I'm a newbie kernel developer interested in qxl driver. And I want to > > participate in > > contributing for QXL module. > > I wrote some simple patch for

[PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Asus T101HA panel

2020-05-31 Thread Hans de Goede
Like the Asus T100HA the Asus T101HA also uses a panel which has been mounted 90 degrees rotated, add a quirk for this. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 2/2] drm: panel-orientation-quirks: Use generic orientation-data for Acer S1003

2020-05-31 Thread Hans de Goede
The Acer S1003 has proper DMI strings for sys-vendor and product-name, so we do not need to match by BIOS-date. This means that the Acer S1003 can use the generic lcd800x1280_rightside_up drm_dmi_panel_orientation_data struct which is also used by other quirks. Signed-off-by: Hans de Goede ---

Current drm-tip doesn’t build with gcc10 - error in amdgpu_amdkfd_gpuvm.c

2020-05-31 Thread Yurii Kolesnykov
Originally reported by jghodd[1] in linux-drm-tip-git AUR package [2], also reported on drm/amd on Freedesktop GitLab [3]. drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function ‘amdgpu_amdkfd_gpuvm_free_memory_of_gpu’: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1357:2: error:

Re: next-20200515: Xorg killed due to "OOM"

2020-05-31 Thread Pavel Machek
On Thu 2020-05-28 14:07:50, Michal Hocko wrote: > On Thu 28-05-20 14:03:54, Pavel Machek wrote: > > On Thu 2020-05-28 11:05:17, Michal Hocko wrote: > > > On Tue 26-05-20 11:10:54, Pavel Machek wrote: > > > [...] > > > > [38617.276517] oom_reaper: reaped process 31769 (chromium), now > > > >

[PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Sidong Yang
Optimize looping pixels in compute_crc() and blend(). Calculate src_offset in start of looping horizontally and increase it. It's better than calculating in every pixels. Cc: Rodrigo Siqueira Cc: David Airlie Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by:

[Bug 205827] drm:drm_atomic_helper_wait_for_dependencies - drm_kms_helper - flip_done timed out

2020-05-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205827 --- Comment #1 from sander44 (ionut_n2...@yahoo.com) --- Hi Kernel Team, I retested with new version kernel, and this issue appear. dmesg | grep drm [4.080480] [drm] DMA map mode: Caching DMA mappings. [4.080866] [drm] Capabilities: [

Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Asus T101HA panel

2020-05-31 Thread Emil Velikov
On Sun, 31 May 2020 at 10:30, Hans de Goede wrote: > > Like the Asus T100HA the Asus T101HA also uses a panel which has been > mounted 90 degrees rotated, add a quirk for this. > Reading the commit message, made me wonder: If it's similar why it doesn't use the same quirk? Something like the

RE: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-05-31 Thread Venkateshwar Rao Gannavarapu
Hi Laurent & Hyun, Thanks for the review. >-Original Message- >From: Laurent Pinchart >Sent: Sunday, May 24, 2020 8:38 AM >To: Venkateshwar Rao Gannavarapu >Cc: Hyun Kwon ; Hyun Kwon ; dri- >de...@lists.freedesktop.org; airl...@linux.ie; dan...@ffwll.ch; linux- >ker...@vger.kernel.org;

Re: [PATCH] Documentation: Fix typo error in todo.rst

2020-05-31 Thread Sam Ravnborg
Hi Sidong On Fri, May 29, 2020 at 02:21:59AM +0900, Sidong Yang wrote: > Change wrong function name drm_modest_lock_all() to drm_modeset_lock_all() > > Signed-off-by: Sidong Yang Thanks, applied to drm-misc-next. Sam > --- > Documentation/gpu/todo.rst | 2 +- > 1 file changed, 1

Re: [PATCH v1 1/2] drm/vblank: use drm_* functions for logging

2020-05-31 Thread Sam Ravnborg
Hi Thomas. On Mon, May 25, 2020 at 01:07:29PM +0200, Thomas Zimmermann wrote: > Hi > > Am 23.05.20 um 09:12 schrieb Sam Ravnborg: > > Replace all DRM_* logging functions with their drm_ counterparts. > > checkpatch emits a few "quoted string split across lines", > > which is left as is. The

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-05-31 Thread Sam Ravnborg
Hi John. On Thu, May 21, 2020 at 09:15:04PM -0700, John Hubbard wrote: > Hi, > > Note that I have only compile-tested this series, although that does > also include cross-compiling for a few other arches. I'm hoping that > this posting will lead to some run-time testing. > > Also: the proposed

Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string

2020-05-31 Thread Sam Ravnborg
Hi Colin/Greg. On Thu, May 21, 2020 at 02:50:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently HSD20_IPS is defined as "true" and will always result in a > non-zero result even if it is defined as "false" because it is an array > and that will never be zero. Fix this by

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-05-31 Thread John Hubbard
On 2020-05-31 13:58, Sam Ravnborg wrote: ... Thanks, patches are now applied to drm-misc-next. They will hit -next soon, but you will have to wait until next (not the upcoming) merge window before they hit mainline linux. Sam Great! That will work out just fine. thanks, -- John

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-05-31 Thread Andy Shevchenko
On Monday, June 1, 2020, John Hubbard wrote: > On 2020-05-31 13:58, Sam Ravnborg wrote: > ... > >> Thanks, patches are now applied to drm-misc-next. >> They will hit -next soon, but you will have to wait >> until next (not the upcoming) merge window before they hit >> mainline linux. >> >>

Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new

2020-05-31 Thread Ben Skeggs
On Sat, 30 May 2020 at 19:42, Dinghao Liu wrote: > > When gk20a_clk_ctor() returns an error code, pointer "clk" > should be released. It's the same when gm20b_clk_new() > returns from elsewhere following this call. This shouldn't be necessary. If a subdev constructor fails, and returns a

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-05-31 Thread John Hubbard
On 2020-05-31 14:11, Andy Shevchenko wrote: ... JFYI, we have history.git starting from v0.01. OK, thanks for that note. According to that history.git [1], then: drivers/video/pvr2fb.c had get_user_pages_fast() support added to pvr2fb_write() back in 2004, but only for CONFIG_SH_DMA, as

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-05-31 Thread Emil Velikov
HI Laurent, >From a quick glance the series looks really good and neat. Then again, I don't know much about the hardware to provide meaningful review. A couple of small ideas below. On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote: > +#define LCDC_AS_BUF0x220 >

Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Emil Velikov
On Sun, 31 May 2020 at 14:12, Sidong Yang wrote: > > Optimize looping pixels in compute_crc() and blend(). Calculate > src_offset in start of looping horizontally and increase it. > It's better than calculating in every pixels. > When you say "optimize" have you observed any actual benefits of

Re: [PATCH] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-31 Thread Rob Clark
On Thu, May 14, 2020 at 1:11 PM Daniel Vetter wrote: > > I honestly don't exactly understand what's going on here, but the > current code is wrong for sure: It calls dma_buf_vunmap without ever > calling dma_buf_vmap. > > What I'm not sure about is whether the WARN_ON is correct: > - msm imports

Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Rodrigo Siqueira
Hi, First of all, thanks a lot for all your patch. And thanks Emil for your feedback. I have a suggestion here: Emil: Could you give me your Acked-by or maybe Reviewed-by for the writeback series? With that, I can finally apply the series. Sidong: Secondly, after applying the writeback series,

Re: Dynamically change enumeration list of DRM enumeration property

2020-05-31 Thread Yogish Kulkarni
Hi, For letting DRM clients to select output encoding: Sink can support certain display timings with high output bit-depths using multiple output encodings, e.g. sink can support a particular timing with RGB 10-bit, YCbCr422 10-bit and YCbCr420 10-bit. So DRM client may want to select YCbCr422

Re: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new

2020-05-31 Thread Ben Skeggs
On Mon, 1 Jun 2020 at 13:27, wrote: > > > Hi Ben, > > > > When gk20a_clk_ctor() returns an error code, pointer "clk" > > > should be released. It's the same when gm20b_clk_new() > > > returns from elsewhere following this call. > > This shouldn't be necessary. If a subdev constructor fails, and

Re: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new

2020-05-31 Thread Ben Skeggs
On Mon, 1 Jun 2020 at 13:37, Ben Skeggs wrote: > > On Mon, 1 Jun 2020 at 13:27, wrote: > > > > > > Hi Ben, > > > > > > When gk20a_clk_ctor() returns an error code, pointer "clk" > > > > should be released. It's the same when gm20b_clk_new() > > > > returns from elsewhere following this call. > >