Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Thomas Zimmermann
Hi Am 22.07.20 um 17:08 schrieb Philipp Zabel: > Hi Thomas, > > thank you for your comment. > > On Wed, 2020-07-22 at 16:43 +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 22.07.20 um 15:25 schrieb Philipp Zabel: >>> Add a drm_simple_encoder_init() variant that registers >>>

Re: [PATCH v8 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-23 Thread Jim Quinlan
On Tue, Jul 21, 2020 at 8:51 AM Christoph Hellwig wrote: > > On Wed, Jul 15, 2020 at 10:35:11AM -0400, Jim Quinlan wrote: > > The new field 'dma_range_map' in struct device is used to facilitate the > > use of single or multiple offsets between mapping regions of cpu addrs and > > dma addrs. It

[v7, PATCH 5/7] arm64: dts: add display nodes for mt8183

2020-07-23 Thread Yongqiang Niu
This patch add display nodes for mt8183 Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 98 1 file changed, 98 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index

Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-07-23 Thread Vinod Koul
Hi Sam, Laurent, On 22-07-20, 16:14, Laurent Pinchart wrote: > > > +static int lt9611_bridge_attach(struct drm_bridge *bridge, > > > + enum drm_bridge_attach_flags flags) > > > +{ > > > + struct lt9611 *lt9611 = bridge_to_lt9611(bridge); > > > + int ret; > > > + > > > + if

Re: linux-next: manual merge of the amdgpu tree with Linus' tree

2020-07-23 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 6:34 AM Stephen Rothwell wrote: > > Hi all, > > [I can't find a previous email about this, sorry ...] > > There is a semantic conflict between Linus' tree and the amdgpu tree > between commit > > d7a6634a4cfb ("drm/amdgpu/atomfirmware: fix vram_info fetching for renoir")

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #2 from Shannon Gaines (iknstu...@protonmail.com) --- Update: nvidia-legacy-390xx driver allows me to change the backlight via acpi_video0, however nouveau doesn't under any circumstances. No clue why. -- You are receiving this mail

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 --- Comment #1 from Shannon Gaines (iknstu...@protonmail.com) --- Created attachment 290477 --> https://bugzilla.kernel.org/attachment.cgi?id=290477=edit acpidump.txt -- You are receiving this mail because: You are watching the assignee of

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Thomas Zimmermann
Hi I have meanwhile seen your imx patchset where this would be useful. I still think you should try to pre-allocated all encoders up to a limit, so that an extra drmm_kzalloc() is not required. But see my comments below. Am 22.07.20 um 15:25 schrieb Philipp Zabel: > Add a

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Thomas Zimmermann
Hi Am 23.07.20 um 11:05 schrieb Daniel Vetter: > On Thu, Jul 23, 2020 at 9:36 AM Thomas Zimmermann wrote: >> >> Hi >> >> I have meanwhile seen your imx patchset where this would be useful. >> >> I still think you should try to pre-allocated all encoders up to a >> limit, so that an extra

[PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Christian König
We can't pipeline that during eviction because the memory needs to be available immediately. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Daniel Vetter
On Thu, Jul 23, 2020 at 11:13 AM Thomas Zimmermann wrote: > > Hi > > Am 23.07.20 um 11:05 schrieb Daniel Vetter: > > On Thu, Jul 23, 2020 at 9:36 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> I have meanwhile seen your imx patchset where this would be useful. > >> > >> I still think

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Enric Balletbo Serra
Hi Yongqian Niu, Thank you for your patch Missatge de Yongqiang Niu del dia dj., 23 de jul. 2020 a les 4:05: > > move ddp component defint into mtk_mmsys.h > There is a typo, should be "defines". But why you should move these defines to mtk-mmsys? > Signed-off-by: Yongqiang Niu > --- >

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-23 Thread Enric Balletbo Serra
Hi Yongqiang Niu, Thank you for your patch. Missatge de Yongqiang Niu del dia dj., 23 de jul. 2020 a les 4:05: > > add mmsys private data > I think this change requires a better explanation of what you are doing. Although I'm really uncomfortable with this change, why you need to create a new

[PATCH -resend] Documentation: fb, fix path to modedb.c

2020-07-23 Thread Jiri Slaby
modedb.c was moved twice since the modedb documentation was written. Update the path to the current one. Signed-off-by: Jiri Slaby Cc: Bartlomiej Zolnierkiewicz Cc: Jonathan Corbet Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Cc: linux-...@vger.kernel.org ---

[PATCH -next] dma-fence: Make symbol 'dma_fence_lockdep_map' static

2020-07-23 Thread Wei Yongjun
The sparse tool complains as follows: drivers/dma-buf/dma-fence.c:249:25: warning: symbol 'dma_fence_lockdep_map' was not declared. Should it be static? This variable is not used outside of dma-fence.c, so this commit marks it static. Fixes: 5fbff813a4a3 ("dma-fence: basic lockdep

[v7, PATCH 4/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-07-23 Thread Yongqiang Niu
Update device tree binding document for rdma_fifo_size Signed-off-by: Yongqiang Niu --- .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt

[PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-07-23 Thread Swapnil Jakhade
Add a new DRM bridge driver for Cadence MHDP DPTX IP used in TI J721e SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards. It integrates uCPU running the embedded Firmware (FW) interfaced over APB interface. Basically, it takes a

[PATCH -next 1/2] drm: Remove redundant NULL check

2020-07-23 Thread Li Heng
Fix below warnings reported by coccicheck: ./drivers/gpu/drm/drm_drv.c:819:2-7: WARNING: NULL check before some freeing functions is not needed. Fixes: 5dad34f3c444 ("drm: Cleanups after drmm_add_final_kfree rollout") Signed-off-by: Li Heng --- drivers/gpu/drm/drm_drv.c | 3 +-- 1 file

[PATCH v2 2/5] drm: rockchip: add missing registers for RK3188

2020-07-23 Thread Alex Bee
Add dither_up, dsp_lut_en and data_blank registers to enable their respective functionality for RK3188's VOP. Signed-off-by: Alex Bee --- Changes in v2: - drop the not yet upstreamed dsp_data_swap and rephrase the commit message according drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 3 +++

[v7, PATCH 6/7] drm/mediatek: add fifo_size into rdma private data

2020-07-23 Thread Yongqiang Niu
the fifo size of rdma in mt8183 is different. rdma0 fifo size is 5k rdma1 fifo size is 2k Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c

[PATCH v2 4/5] drm: rockchip: set alpha_en to 0 if it is not used

2020-07-23 Thread Alex Bee
alpha_en should be set to 0 if it is not used, i.e. to disable alpha blending if it was enabled before and should be disabled now. Fixes: 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") Signed-off-by: Alex Bee --- Changes in v2: - capitalize "F" of "Fixes" in the

[PATCH v2 5/5] drm: rockchip: use overlay windows as such

2020-07-23 Thread Alex Bee
As stated in the comment for rk3288_vop_win_data windows that are supposed to be an overlay window are missused as HWC windows due to the missing implementation of that window type in the VOP driver. This also applies to VOPs RK3036, RK3126, RK3188 and RK3228, which all have at least one (1)

[PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-23 Thread Alex Bee
Hi, this series mainly ports existining functionality to older SoCs - most importantly enables alpha blending for RK3036, RK3066, RK3126 and RK3188. Besides that, it also changes the window type from DRM_PLANE_TYPE_CURSOR to DRM_PLANE_TYPE_OVERLAY for VOPs that have only one (1) overlay window.

[PATCH v7 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-07-23 Thread Swapnil Jakhade
This patch series adds new DRM bridge driver for Cadence MHDP DPI/DP bridge. The Cadence Display Port IP is also referred as MHDP (Mobile High Definition Link, High-Definition Multimedia Interface, Display Port). Cadence Display Port complies with VESA DisplayPort (DP) and embedded Display Port

[v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-23 Thread Yongqiang Niu
add mmsys private data Feature: drm/mediatek Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mmsys/Makefile | 2 + drivers/soc/mediatek/mmsys/mt2701-mmsys.c | 250 +++ drivers/soc/mediatek/mtk-mmsys.c

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-23 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 02:24:19PM -0400, Lyude Paul wrote: > On Tue, 2020-07-21 at 12:00 -0400, Lyude Paul wrote: > > On Tue, 2020-07-21 at 18:27 +0300, Mika Westerberg wrote: > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > > > > Sure thing. Also, feel free to let me know if

[PATCH v2 3/5] drm: rockchip: add alpha support for RK3036, RK3066, RK3126 and RK3188

2020-07-23 Thread Alex Bee
With commit 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") alpha support was introduced for PX30's VOP. RK3036, RK3066, RK3126 and RK3188 VOPs support alpha blending in the same manner. With the exception of RK3066 all of them support pre-multiplied alpha. Lets add

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-23 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > >> Sure thing. Also, feel free to let me know if you'd like access to one of > >> the > >> systems we saw breaking

Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-23 Thread Markus Elfring
… > and in kfd_create_vcrat_image_cpu(), the acpi_table is only used to > get the OEM info, so those table mappings need to be release after … 1. Please avoid a typo for this change description. 2. An imperative wording can be preferred here, can't it? 3. Will the tag “Fixes” become helpful for

[PATCH v2 1/5] drm: rockchip: add scaling for RK3036 win1

2020-07-23 Thread Alex Bee
Add the registers needed to make scaling work on RK3036's win1. Signed-off-by: Alex Bee --- Changes in v2: - rephrase commit message drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[v7, PATCH 0/7] add drm support for MT8183

2020-07-23 Thread Yongqiang Niu
This series are based on 5.8-rc1 and provide 7 patch to support mediatek SOC MT8183 Change since v6 - move ddp component define into mtk_mmsys.h - add mmsys private data to support different ic path connection - add mt8183-mmsys.c to support 8183 path connection - fix reviewed issue in v6 Change

[PATCH v7 3/3] drm: bridge: cdns-mhdp: Add j721e wrapper

2020-07-23 Thread Swapnil Jakhade
Add j721e wrapper for mhdp, which sets up the clock and data muxes. Signed-off-by: Jyri Sarha Signed-off-by: Yuti Amonkar Signed-off-by: Swapnil Jakhade Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/Kconfig | 13

[PATCH v7 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-07-23 Thread Swapnil Jakhade
From: Yuti Amonkar Document the bindings used for the Cadence MHDP DPI/DP bridge in yaml format. Signed-off-by: Yuti Amonkar Signed-off-by: Swapnil Jakhade Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/cdns,mhdp.yaml| 127 ++ 1

[v7, PATCH 3/7] mtk-mmsys: add mt8183 mmsys support

2020-07-23 Thread Yongqiang Niu
add mt8183 mmsys support Feature: drm/mediatek Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 161 ++ drivers/soc/mediatek/mtk-mmsys.c | 1 + 3 files changed, 163

[v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-23 Thread Yongqiang Niu
This patch add support for mediatek SOC MT8183 1.ovl_2l share driver with ovl 2.rdma1 share drive with rdma0, but fifo size is different 3.add mt8183 mutex private data, and mmsys private data 4.add mt8183 main and external path module for crtc create Signed-off-by: Yongqiang Niu ---

[v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Yongqiang Niu
move ddp component defint into mtk_mmsys.h Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 34 + drivers/soc/mediatek/mtk-mmsys.c| 4 +--- include/linux/soc/mediatek/mtk-mmsys.h | 33 3

[PATCH -next 2/2] drm: Remove redundant NULL check

2020-07-23 Thread Li Heng
Fix below warnings reported by coccicheck: ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c:557:2-7: WARNING: NULL check before some freeing functions is not needed. Fixes: 4d55b0dd1cdd ("drm/amd/display: Add DCN3 CLK_MGR") Signed-off-by: Li Heng ---

[PATCH] drm: bridge: adv7511: Add missing bridge type

2020-07-23 Thread Vinod Koul
Add bridge type as DRM_MODE_CONNECTOR_HDMIA Signed-off-by: Vinod Koul --- I found this when testing Dragon-board 410c which uses this bridge [6.671913] msm 1a0.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22 [6.678879] msm

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-23 Thread Greg Kroah-Hartman
On Wed, Jul 22, 2020 at 10:07:06AM +0200, Daniel Vetter wrote: > On Tue, Jul 21, 2020 at 6:08 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Jul 16, 2020 at 08:27:21PM +0900, Tetsuo Handa wrote: > > > On 2020/07/16 19:00, Daniel Vetter wrote: > > > > On Thu, Jul 16, 2020 at 12:29:00AM +0900,

Re: pages pinned for BO lifetime and security

2020-07-23 Thread Intel
On 2020-07-22 09:46, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 9:19 AM Christian König wrote: Am 22.07.20 um 02:22 schrieb Gurchetan Singh: Of the desktop GPU drivers, i915's shrinker certainly supports purging to swap. TTM is a bit hard to follow. I can't really tell if amdgpu or

[PATCH 2/2] drm/meson: overlay: fix Amlogic Compressed Framebuffer modifier layout extract

2020-07-23 Thread Neil Armstrong
The bitwise operation worked because the result is casted in a lower bits integer, and was not changed after the modifier defines rework. Use the correct operation as already used in meson_overlay_atomic_update(). Fixes: e860785d5730 ("drm/meson: overlay: setup overlay for Amlogic FBC")

[PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro

2020-07-23 Thread Neil Armstrong
Fix the Amlogic Video Framebuffer Compression modifier macro to correctly add the layout options, a pair of parenthesis was missing. Fixes: d6528ec88309 ("drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression") Signed-off-by: Neil Armstrong ---

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Daniel Vetter
On Thu, Jul 23, 2020 at 9:36 AM Thomas Zimmermann wrote: > > Hi > > I have meanwhile seen your imx patchset where this would be useful. > > I still think you should try to pre-allocated all encoders up to a > limit, so that an extra drmm_kzalloc() is not required. But see my > comments below. Uh

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-23 Thread Felipe Balbi
Nicolas Boichat writes: > trace_printk should not be used in production code, replace it > call with dev_dbg. > > Signed-off-by: Nicolas Boichat > > --- > > Unclear why a trace_printk was used in the first place, it's > possible that some rate-limiting is necessary here. > >

Re: linux-next: manual merge of the amdgpu tree with Linus' tree

2020-07-23 Thread Alex Deucher
On Thu, Jul 23, 2020 at 4:01 AM Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 6:34 AM Stephen Rothwell > wrote: > > > > Hi all, > > > > [I can't find a previous email about this, sorry ...] > > > > There is a semantic conflict between Linus' tree and the amdgpu tree > > between commit > > >

Re: [PATCH -next 2/2] drm: Remove redundant NULL check

2020-07-23 Thread Alex Deucher
On Thu, Jul 23, 2020 at 12:11 AM Li Heng wrote: > > Fix below warnings reported by coccicheck: > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c:557:2-7: > WARNING: NULL check before some freeing functions is not needed. > > Fixes: 4d55b0dd1cdd ("drm/amd/display: Add DCN3

Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-07-23 Thread Vinod Koul
On 23-07-20, 13:39, Sam Ravnborg wrote: > On Thu, Jul 23, 2020 at 04:11:51PM +0530, Vinod Koul wrote: > > Hi Sam, Laurent, > > > > On 22-07-20, 16:14, Laurent Pinchart wrote: > > > > > +static int lt9611_bridge_attach(struct drm_bridge *bridge, > > > > > + enum

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-23 Thread Nicolas Boichat
On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote: > > Nicolas Boichat writes: > > > trace_printk should not be used in production code, replace it > > call with dev_dbg. > > > > Signed-off-by: Nicolas Boichat > > > > --- > > > > Unclear why a trace_printk was used in the first place, it's > >

Re: [PATCH] drm: bridge: adv7511: Add missing bridge type

2020-07-23 Thread Laurent Pinchart
Hi Vinod, Thank you for the patch. On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote: > Add bridge type as DRM_MODE_CONNECTOR_HDMIA > > Signed-off-by: Vinod Koul This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.pa...@oss.nxp.com/ >

Re: [PATCH] drm: of: Fix double-free bug

2020-07-23 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Thu, Jul 23, 2020 at 12:10:54PM +0100, Biju Das wrote: > Fix double-free bug in the error path. > > Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") > Reported-by: Pavel Machek > Signed-off-by: Biju Das > Cc:

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread philip yang
On 2020-07-23 7:02 p.m., Felix Kuehling wrote: Am 2020-07-23 um 5:00 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- 1 file

[PATCH] drm/amd/display: remove redundant initialization of variable result

2020-07-23 Thread Colin King
From: Colin Ian King The variable result is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-

[PATCH v2 1/2] drm: add drmm_encoder_init()

2020-07-23 Thread Philipp Zabel
Add a drm_encoder_init() variant that allocates an encoder with drmm_kzalloc() and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- New in v2 --- drivers/gpu/drm/drm_encoder.c | 101 ++ include/drm/drm_encoder.h

[PATCH v2 2/2] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Philipp Zabel
Add a drm_simple_encoder_init() variant that allocates an encoder with drmm_kzalloc() and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- Changes since v1: - based on drmm_encoder_init - use AE initialize spelling - fold allocation into

[Bug 208661] Backlight doesn't work with both nv_backlight and acpi_video

2020-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 Ilia Mirkin (imir...@alum.mit.edu) changed: What|Removed |Added CC||imir...@alum.mit.edu

[PATCH v6 2/3] dt-bindings: display: bridge: Add documentation for LT9611

2020-07-23 Thread Vinod Koul
Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports and I2S port as input and one HDMI port as output Reviewed-by: Rob Herring Tested-by: John Stultz Signed-off-by: Vinod Koul --- .../display/bridge/lontium,lt9611.yaml| 176 ++ 1 file changed, 176

[PATCH v6 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-07-23 Thread Vinod Koul
Lontium Lt9611 is a DSI to HDMI bridge which supports two DSI ports and I2S port as an input and HDMI port as output Co-developed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Co-developed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla Tested-by: John Stultz Signed-off-by:

[PATCH v6 0/3] Add LT9611 DSI to HDMI bridge

2020-07-23 Thread Vinod Koul
Hi, This series adds driver and bindings for Lontium LT9611 bridge chip which takes MIPI DSI as input and HDMI as output. This chip can be found in 96boards RB3 platform [1] commonly called DB845c. [1]: https://www.96boards.org/product/rb3-platform/ Changes in v6: - Drop msm/dsi patch as we

[PATCH v6 1/3] dt-bindings: vendor-prefixes: Add Lontium vendor prefix

2020-07-23 Thread Vinod Koul
Add prefix for Lontium Semiconductor Corporation Acked-by: Rob Herring Tested-by: John Stultz Signed-off-by: Vinod Koul --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Philipp Zabel
Hi Thomas, On Thu, 2020-07-23 at 09:35 +0200, Thomas Zimmermann wrote: > Hi > > I have meanwhile seen your imx patchset where this would be useful. > > I still think you should try to pre-allocated all encoders up to a > limit, so that an extra drmm_kzalloc() is not required. But see my >

[PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-23 Thread Christian König
Instead use a boolean field in the memory manager structure. Also invert the meaning of the field since the use of a TT structure is the special case here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 4 +--- drivers/gpu/drm/drm_gem_vram_helper.c | 1 -

[PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-23 Thread Christian König
Instead of repeating that in each driver. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 --- drivers/gpu/drm/qxl/qxl_ttm.c | 3 ---

[PATCH 9/9] drm/ttm: remove the init_mem_type callback

2020-07-23 Thread Christian König
It is a very strange concept to call a function which just calls back the caller for the functions parameters. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 7 --- drivers/gpu/drm/drm_gem_vram_helper.c | 7 --- drivers/gpu/drm/nouveau/nouveau_bo.c

[PATCH 7/9] drm/qxl: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_ttm.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c

[PATCH 5/9] drm/vmwgfx: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c| 18 +++ drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 27 -- 2 files changed, 18 insertions(+), 27

[PATCH 4/9] drm/amdgpu: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 96 +++-- 1 file changed, 43 insertions(+), 53 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 8/9] drm/vram-helper: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c

[PATCH 3/9] drm/radeon: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 70 ++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c

[PATCH 6/9] drm/nouveau: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 48 - drivers/gpu/drm/nouveau/nouveau_ttm.c | 61 +-- 2 files changed, 57 insertions(+), 52

Re: [v7, PATCH 1/7] drm/mediatek: move ddp component defint into mtk_mmsys.h

2020-07-23 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年7月23日 週四 下午6:06寫道: > > On Thu, 2020-07-23 at 11:34 +0200, Enric Balletbo Serra wrote: > > Hi Yongqian Niu, > > > > Thank you for your patch > > > > Missatge de Yongqiang Niu del dia dj., 23 > > de jul. 2020 a les 4:05: > > > > > > move ddp component defint into mtk_mmsys.h >

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 5:00 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > Signed-off-by: Christian König Looks good to me. Reviewed-by: Felix Kuehling Alex, in this case the synchronous ttm_bo_wait would be

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-23 Thread Philipp Zabel
Hi Daniel, On Thu, 2020-07-23 at 00:22 +0200, dan...@ffwll.ch wrote: [...] > Yeah the drmm_ versions of these need to check that the ->cleanup hook is > NULL. > > Also there's not actually a double-free, since drm_foo_cleanup removes it > from the lists, which means drm_mode_config_cleanup won't

Re: [v7, PATCH 5/7] arm64: dts: add display nodes for mt8183

2020-07-23 Thread Matthias Brugger
On 23/07/2020 04:03, Yongqiang Niu wrote: This patch add display nodes for mt8183 In comparison, DTS patches should go last in a series as you will need the driver patches to make it work. Regards, Matthias Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi |

Re: [v7, PATCH 4/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-07-23 Thread Matthias Brugger
On 23/07/2020 04:03, Yongqiang Niu wrote: Update device tree binding document for rdma_fifo_size Please explain better what you are doing in the patch. Also DT binding patches should normally go as the first of a series, as this helps Rob to review them. Regards, Matthias

[PATCH 2/9] drm/ttm: remove TTM_MEMTYPE_FLAG_FIXED

2020-07-23 Thread Christian König
Instead use a boolean field in the memory manager structure. Also invert the meaning of the field since the use of a TT structure is the special case here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 4 +--- drivers/gpu/drm/drm_gem_vram_helper.c | 1 -

[PATCH 1/9] drm/ttm: initialize the system domain with defaults

2020-07-23 Thread Christian König
Instead of repeating that in each driver. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 --- drivers/gpu/drm/drm_gem_vram_helper.c | 3 --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 --- drivers/gpu/drm/qxl/qxl_ttm.c | 3 ---

[PATCH 3/9] drm/radeon: stop implementing init_mem_type

2020-07-23 Thread Christian König
Instead just initialize the memory type parameters before calling ttm_bo_init_mm. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 70 ++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c

More TTM cleanups

2020-07-23 Thread Christian König
Just another round of random TTM cleanups. Please review and/or comment. Thanks, Christian. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v7 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-07-23 Thread Rob Herring
On Wed, Jul 22, 2020 at 09:40:38AM +0200, Swapnil Jakhade wrote: > From: Yuti Amonkar > > Document the bindings used for the Cadence MHDP DPI/DP bridge in > yaml format. > > Signed-off-by: Yuti Amonkar > Signed-off-by: Swapnil Jakhade > Reviewed-by: Rob Herring > Reviewed-by: Laurent

Re: [PATCH v7 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-07-23 Thread Rob Herring
On Wed, 22 Jul 2020 09:40:38 +0200, Swapnil Jakhade wrote: > From: Yuti Amonkar > > Document the bindings used for the Cadence MHDP DPI/DP bridge in > yaml format. > > Signed-off-by: Yuti Amonkar > Signed-off-by: Swapnil Jakhade > Reviewed-by: Rob Herring > Reviewed-by: Laurent Pinchart >

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-23 Thread Matthias Brugger
On 23/07/2020 04:03, Yongqiang Niu wrote: This patch add support for mediatek SOC MT8183 1.ovl_2l share driver with ovl 2.rdma1 share drive with rdma0, but fifo size is different 3.add mt8183 mutex private data, and mmsys private data 4.add mt8183 main and external path module for crtc create

[PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

2020-07-23 Thread Colin King
From: Colin Ian King The pixclock is being set locally because it is being passed as a pass-by-value argument rather than pass-by-reference, so the computed pixclock is never being set in var->pixclock. Fix this by passing by reference. [This dates back to 2002, I found the offending commit

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-23 Thread Rob Herring
On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 > and 6.18 inches size. It is found in some of the Poco F1 phones. > > Signed-off-by: Sumit Semwal > Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16

[PATCH 3/3] drm/i915/gem: Serialise debugfs i915_gem_objects with ctx->mutex

2020-07-23 Thread Chris Wilson
Since the debugfs may peek into the GEM contexts as the corresponding client/fd is being closed, we may try and follow a dangling pointer. However, the context closure itself is serialised with the ctx->mutex, so if we hold that mutex as we inspect the state coupled in the context, we know the

[PATCH 1/3] drm: Restore driver.preclose() for all to use

2020-07-23 Thread Chris Wilson
An unfortunate sequence of events, but it turns out there is a valid usecase for being able to free/decouple the driver objects before they are freed by the DRM core. In particular, if we have a pointer into a drm core object from inside a driver object, that pointer needs to be nerfed *before* it

[PATCH 2/3] drm/i915/gem: Move context decoupling from postclose to preclose

2020-07-23 Thread Chris Wilson
Since the GEM contexts refer to other GEM state, we need to nerf those pointers before that state is freed during drm_gem_release(). We need to move i915_gem_context_close() from the postclose callback to the preclose. In particular, debugfs likes to peek into the GEM contexts, and from there

RE: [PATCH 2/3] drm/i915/gem: Move context decoupling from postclose to preclose

2020-07-23 Thread Chris Wilson
Quoting Tang, CQ (2020-07-23 18:44:08) > > > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 23, 2020 10:21 AM > > To: intel-...@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org; Chris Wilson > > ; > > Tang, CQ ; Vetter, Daniel ; > >

Re: [v7, PATCH 4/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-07-23 Thread Rob Herring
On Thu, Jul 23, 2020 at 10:03:15AM +0800, Yongqiang Niu wrote: > Update device tree binding document for rdma_fifo_size > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 14 > ++ > 1 file changed, 14 insertions(+) > > diff --git

RE: [PATCH 2/3] drm/i915/gem: Move context decoupling from postclose to preclose

2020-07-23 Thread Tang, CQ
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 23, 2020 10:21 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Chris Wilson ; > Tang, CQ ; Vetter, Daniel ; > sta...@vger.kernel.org > Subject: [PATCH 2/3] drm/i915/gem: Move context

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-23 Thread Kazlauskas, Nicholas
On 2020-07-23 5:10 p.m., Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is running, causing a race condition where state (and then dm_state) is sometimes freed while

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-23 Thread Kees Cook
On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: > When amdgpu_dm_atomic_commit_tail is running in the workqueue, > drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is > running, causing a race condition where state (and then dm_state) is > sometimes freed while

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 5:00 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >

Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-07-23 Thread Sam Ravnborg
On Thu, Jul 23, 2020 at 04:11:51PM +0530, Vinod Koul wrote: > Hi Sam, Laurent, > > On 22-07-20, 16:14, Laurent Pinchart wrote: > > > > +static int lt9611_bridge_attach(struct drm_bridge *bridge, > > > > + enum drm_bridge_attach_flags flags) > > > > +{ > > > > +

Re: [Nouveau] [PATCH v2] drm/nouveau: Accept 'legacy' format modifiers

2020-07-23 Thread Ben Skeggs
On Sat, 18 Jul 2020 at 13:34, James Jones wrote: > > Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() > family of modifiers to handle broken userspace > Xorg modesetting and Mesa drivers. Existing Mesa > drivers are still aware of only these older > format modifiers which do not differentiate >

[git pull] drm fixes for 5.8-rc7

2020-07-23 Thread Dave Airlie
Quiet fixes, I may have a single regression fix follow up to this for nouveau, but it might be next week, Ben was testing it a bit more . Otherwise two amdgpu fixes, one lima and one sun4i. Dave. drm-fixes-2020-07-24: drm fixes for 5.6-rc7 amdgpu: - Fix crash when overclocking VegaM - Fix

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 9:58 p.m. schrieb philip yang: > > On 2020-07-23 7:02 p.m., Felix Kuehling wrote: >> Am 2020-07-23 um 5:00 a.m. schrieb Christian König: >>> We can't pipeline that during eviction because the memory needs >>> to be available immediately. >>> >>> Signed-off-by: Christian König

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-23 Thread Sumit Semwal
Hi Rob, Thanks for the review! On Thu, 23 Jul 2020 at 23:25, Rob Herring wrote: > > On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > > 1080x2246 > > and 6.18 inches size. It is found in some of the Poco F1

Re: [PATCH] drm: bridge: adv7511: Add missing bridge type

2020-07-23 Thread Vinod Koul
On 24-07-20, 04:30, Laurent Pinchart wrote: > Hi Vinod, > > Thank you for the patch. > > On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote: > > Add bridge type as DRM_MODE_CONNECTOR_HDMIA > > > > Signed-off-by: Vinod Koul > > This has already been submitted: >

Re: [PATCH] drm/bridge/adv7511: set the bridge type properly

2020-07-23 Thread Vinod Koul
On 22-07-20, 15:15, Laurent Pinchart wrote: > Hi Laurentiu, > > Thank you for the patch. > > On Mon, Jul 20, 2020 at 03:42:27PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > After the drm_bridge_connector_init() helper function has been added, the > > ADV > > driver has been

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-23 Thread Dave Airlie
On Tue, 14 Jul 2020 at 18:56, Thomas Zimmermann wrote: > > Hi > > Am 14.07.20 um 10:41 schrieb Daniel Vetter: > > On Tue, Jul 14, 2020 at 08:41:58AM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 13.07.20 um 18:21 schrieb Daniel Vetter: > >>> On Fri, Jul 10, 2020 at 08:28:16AM +0200, Thomas

  1   2   >