Re: [PATCH 2/4] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Matthew Auld
On Fri, 18 Sep 2020 at 19:22, Daniel Vetter wrote: > > On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld > wrote: > > > > On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote: > > > > > > The big change is device_add so that device_del can auto-cleanup > > > devres resources. This allows us to use

Re: [PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-18 Thread Navare, Manasi
On Fri, Sep 18, 2020 at 02:40:16PM +0300, Jani Nikula wrote: > Add the subheadings from the DP spec. No functional changes. > > Signed-off-by: Jani Nikula Looks good to me Reviewed-by: Manasi Navare Manasi > --- > include/drm/drm_dp_helper.h | 22 ++ > 1 file changed,

[GIT PULL] cdns-mhdp bridge for 5.10

2020-09-18 Thread Tomi Valkeinen
Hi Dave, Daniel, Here's a pull requests for Cadence MHDP DisplayPort bridge driver. It's almost -rc6, but I'd like to see this merged in 5.10 to make it easier to get the last bits (mainly dts files) merged in 5.11. The MHDP driver compile-time-depends on two PHY patches (queued in phy tree),

[PULL] drm-intel-next

2020-09-18 Thread Rodrigo Vivi
Hi Dave and Daniel, here goes our last pull request targeting 5.10. drm-intel-next-2020-09-17: Driver Changes: - Reduce INTEL_DISPLAY_ENABLED to just removed outputs treating it as disconnected (Ville) - Introducing new AUX, DVO, and TC ports and refactoring code around hot plug interrupts

[PATCH] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Daniel Vetter
To avoid having to create all the device and driver scaffolding we just manually create and destroy a devres_group. v2: Rebased v3: use devres_open/release_group so we can use devm without real hacks in the driver core or having to create an entire fake bus for testing drivers. Might want to

[pull] amdgpu, amdkfd, radeon, scheduler drm-next-5.10

2020-09-18 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 5.10. The following changes since commit 818280d5adf1d80e78f95821815148abe9407e14: Merge v5.9-rc5 into drm-next (2020-09-14 17:19:11 +0200) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux

Re: [PATCH 2/4] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld wrote: > > On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote: > > > > The big change is device_add so that device_del can auto-cleanup > > devres resources. This allows us to use devm_drm_dev_alloc, which > > removes the last user of drm_dev_init. > >

Re: [PATCH 2/4] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 8:31 PM Matthew Auld wrote: > > On Fri, 18 Sep 2020 at 19:22, Daniel Vetter wrote: > > > > On Fri, Sep 18, 2020 at 7:50 PM Matthew Auld > > wrote: > > > > > > On Fri, 18 Sep 2020 at 14:25, Daniel Vetter > > > wrote: > > > > > > > > The big change is device_add so that

Re: [PATCH 2/4] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Matthew Auld
On Fri, 18 Sep 2020 at 14:25, Daniel Vetter wrote: > > The big change is device_add so that device_del can auto-cleanup > devres resources. This allows us to use devm_drm_dev_alloc, which > removes the last user of drm_dev_init. > > v2: Rebased > > v3: use devres_open/release_group so we can use

Re: [PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-18 Thread Navare, Manasi
On Fri, Sep 18, 2020 at 02:40:17PM +0300, Jani Nikula wrote: > Prepare for future with DP 2.0 DPCD definitions, with a couple of > related drive-by cleanups. No functional changes. > > v2: Send the version that actually builds. > > Signed-off-by: Jani Nikula Verified the below DP 2.0 DPCD

Re: [PATCH v9 8/8] drm/i915: Enable async flips in i915

2020-09-18 Thread Ville Syrjälä
On Wed, Sep 16, 2020 at 08:38:24PM +0530, Karthik B S wrote: > Enable asynchronous flips in i915 for gen9+ platforms. > > v2: -Async flip enablement should be a stand alone patch (Paulo) > > v3: -Move the patch to the end of the series (Paulo) > > v4: -Rebased. > > v5: -Rebased. > > v6:

[PATCH] drm/bridge/synopsys: dsi: fix initialization sequence

2020-09-18 Thread Yannick Fertre
The current driver calls drm_bridge_add(), to add the dsi bridge to the global bridge list, in dw_mipi_dsi_host_attach(). Thus, it relies on the probing of panel or bridge sub-nodes to trigger the execution of dsi host attach() that will, in turn, call dw_mipi_dsi_host_attach(). This causes an

[PATCH] drm/panel: otm8009a: remove hack to force commands in HS

2020-09-18 Thread Yannick Fertre
From: Antonio Borneo The panel is able to receive commands in LP. The current hack to force backlight commands in HS was due to workaround an incorrect settings on DSI controller that prevents sending LP commands while video out was active. Remove the hack that forces HS commands.

Re: [PATCH v1] fbdev: aty: remove CONFIG_PM container

2020-09-18 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 05:23:14PM +0530, Vaibhav Gupta wrote: > The changes made in below mentioned commit removed CONFIG_PM containers > from drivers/video/fbdev/aty/atyfb_base.c but not from > drivers/video/fbdev/aty/atyfb.h for respective callbacks. > > This resulted in error for implicit

[PATCH] drm/panel: rm68200: allow using non-continuous dsi clock

2020-09-18 Thread Yannick Fertre
The panel is able to work when dsi clock is non-continuous, thus the system power consumption can be reduced using such feature. Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. Signed-off-by: Antonio Borneo Signed-off-by: Yannick Fertre ---

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-18 Thread Sumit Semwal
Hello Thomas, On Mon, 14 Sep 2020 at 16:55, Thomas Zimmermann wrote: > > Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings > of dma-buf memory in kernel address space. The functions operate with plain > addresses and the assumption is that the memory can be accessed with

Re: [PATCH] drm/vc4: hvs: Pull the state of all the CRTCs prior to PV muxing

2020-09-18 Thread Hoegeun Kwon
Hi Maxime, On 9/17/20 9:16 PM, Maxime Ripard wrote: > The vc4 display engine has a first controller called the HVS that will > perform the composition of the planes. That HVS has 3 FIFOs and can > therefore compose planes for up to three outputs. The timings part is > generated through a

RE: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-18 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Hi @Sasha Levin @Deucher, Alexander, The following changes need to be applied also. Otherwise, you may see unexpected shutdown on stress gpu loading on Vega10. drm/amd/pm: avoid false alarm due to confusing softwareshutdowntemp setting

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
On 2020/9/18 1:36, Nick Desaulniers wrote: On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng wrote: Remove the superfuous break, as there is a 'return' before it. superfluous (missed "l") Thanks for correcting! Signed-off-by: Jing Xiangfeng Reviewed-by: Nick Desaulniers Thanks

[PATCH v2] fbcon: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
Remove the superfluous break, as there is a 'return' before it. Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") Signed-off-by: Jing Xiangfeng Reviewed-by: Nick Desaulniers Reviewed-by: Gustavo A. R. Silva --- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2

RE: [PATCH v3] drm/bridge: add it6505 driver

2020-09-18 Thread allen.chen
It has been about two weeks since I posted v3 and haven't heard anything. Consider this a gentle ping. If there is something need to fix. I will fix and upstream again. Thanks. -Original Message- From: Allen Chen (陳柏宇) Sent: Friday, September 04, 2020 10:10 AM Cc: Allen Chen (陳柏宇);

[PATCH] drm/msm/dp: Sleep properly in dp_hpd_handler kthread

2020-09-18 Thread Stephen Boyd
We shouldn't be waiting for an event here with a timeout of 100ms when we're not in the 'timeout' arm of the if condition. Instead we should be sleeping in the interruptible state (S) until something happens and we need to wakeup. Right now this kthread is running almost all the time because it

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
On 2020/9/18 2:52, Gustavo A. R. Silva wrote: On 9/17/20 08:15, Jing Xiangfeng wrote: Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng Reviewed-by: Gustavo A. R. Silva Also, the following Fixes tag should be included in the changelog text:

Re: [PATCH] drm/msm/dp: Sleep properly in dp_hpd_handler kthread

2020-09-18 Thread khsieh
On 2020-09-17 15:44, Stephen Boyd wrote: We shouldn't be waiting for an event here with a timeout of 100ms when we're not in the 'timeout' arm of the if condition. Instead we should be sleeping in the interruptible state (S) until something happens and we need to wakeup. Right now this kthread

[PATCH v10 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-18 Thread Karthik B S
This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. v7: -Plane ctl needs bits from skl_plane_ctl_crtc as well. (Ville) -Add a vfunc for skl_program_async_surface_address

[PATCH 3/3] fbdev: sbuslib: remove compat_alloc_user_space usage

2020-09-18 Thread Arnd Bergmann
This is one of the last users of compat_alloc_user_space() and copy_in_user(). The actual handler is implemented in the same file and could be shared, but as I couldn't test this properly I leave the native case alone and just make a straight copy of it for the compat case, with a minimum set of

[PATCH 1/3] fbdev: simplify fb_getput_cmap()

2020-09-18 Thread Arnd Bergmann
This function is one of the remaining users of compat_alloc_user_space() and copy_in_user(). Clean it up by copying to a local data structure copy instead, which also leads to more readable code. Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/core/fbmem.c | 44

Re: [PATCH v9 6/8] drm/i915: WA for platforms with double buffered address update enable bit

2020-09-18 Thread Ville Syrjälä
On Wed, Sep 16, 2020 at 08:38:22PM +0530, Karthik B S wrote: > In Gen 9 and Gen 10 platforms, async address update enable bit is > double buffered. Due to this, during the transition from async flip > to sync flip we have to wait until this bit is updated before continuing > with the normal commit

Re: [PATCH v10 5/8] drm/i915: Add dedicated plane hook for async flip case

2020-09-18 Thread Ville Syrjälä
On Fri, Sep 18, 2020 at 12:30:45PM +0530, Karthik B S wrote: > This hook is added to avoid writing other plane registers in case of > async flips, so that we do not write the double buffered registers > during async surface address update. > > v7: -Plane ctl needs bits from skl_plane_ctl_crtc as

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote: > > > On 2020/9/18 2:52, Gustavo A. R. Silva wrote: > > > > > > On 9/17/20 08:15, Jing Xiangfeng wrote: > > > Remove the superfuous break, as there is a 'return' before it. > > > > > > Signed-off-by: Jing Xiangfeng > > > >

Re: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-18 Thread Greg KH
On Fri, Sep 18, 2020 at 07:17:10AM +, Quan, Evan wrote: > [AMD Official Use Only - Internal Distribution Only] That didn't work :) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v10 3/8] drm/i915: Add checks specific to async flips

2020-09-18 Thread Karthik B S
If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject async flip. v2: -Replace DRM_ERROR (Paulo) -Add check for changes in OFFSET, FBC, RC(Paulo) v3:

Re: [PATCH] dmabuf: fix NULL pointer dereference in dma_buf_release()

2020-09-18 Thread Christian König
Am 18.09.20 um 12:32 schrieb Charan Teja Reddy: NULL pointer dereference is observed while exporting the dmabuf but failed to allocate the 'struct file' which results into the dropping of the allocated dentry corresponding to this file in the dmabuf fs, which is ending up in dma_buf_release()

Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema

2020-09-18 Thread Tomi Valkeinen
On 18/09/2020 04:18, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote: >> Add assigned-clocks, assigned-clock-parents and dma-coherent optional >> properties. >> >> Signed-off-by: Tomi Valkeinen >> Reviewed-by:

Re: [PATCH] drm/ttm: update kernel-doc line comments

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 06:44:25PM +0800, Huang Rui wrote: > On Fri, Sep 18, 2020 at 05:52:58PM +0800, Tian Tao wrote: > > Update kernel-doc line comments to fix warnings reported by make W=1. > > > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > > member 'glob' not

Re: [PATCH] drm/panel: otm8009a: remove hack to force commands in HS

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 01:47:18PM +0200, Yannick Fertre wrote: > From: Antonio Borneo > > The panel is able to receive commands in LP. The current hack to > force backlight commands in HS was due to workaround an incorrect > settings on DSI controller that prevents sending LP commands while >

[PATCH 2/3] fbdev: sbuslib: remove unused FBIOSCURSOR32 helper

2020-09-18 Thread Arnd Bergmann
No driver implements FBIOSCURSOR, so this function has no purpose and can be removed. Apparently it was added in linux-2.1.44 to handle compatibility for drivers/sbus/char/sunfb.c but lost its purpose when that driver got rewritten in linux-2.5.63. Signed-off-by: Arnd Bergmann ---

[PATCH 0/3] fbdev: stop using compat_alloc_user_space

2020-09-18 Thread Arnd Bergmann
The fbdev code uses compat_alloc_user_space in a few of its compat_ioctl handlers, which tends to be a bit more complicated and error-prone than calling the underlying handlers directly, so I would like to remove it completely. This modifies two such functions in fbdev, and removes another one

[PULL] drm-misc-fixes

2020-09-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-09-18: drm-misc-fixes for v5.9-rc6: - Fill asoc card owner in vc4. - Program secondary CSC correctly in sun4i, and extend register mapping to cover secondary CSC registers. The following changes since commit fc7f148feb8975784bd40e41fff875d33f698be8: drm/virtio: drop

[PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-18 Thread Jani Nikula
Prepare for future with DP 2.0 DPCD definitions, with a couple of related drive-by cleanups. No functional changes. v2: Send the version that actually builds. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 52 - 1 file changed, 45

[PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-18 Thread Jani Nikula
Add the subheadings from the DP spec. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index

Re: [PATCH v10 3/8] drm/i915: Add checks specific to async flips

2020-09-18 Thread Ville Syrjälä
On Fri, Sep 18, 2020 at 02:32:34PM +0530, Karthik B S wrote: > If flip is requested on any other plane, reject it. > > Make sure there is no change in fbc, offset and framebuffer modifiers > when async flip is requested. > > If any of these are modified, reject async flip. > > v2: -Replace

Re: [PATCH v2] fbcon: Remove the superfluous break

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 09:05:21AM +0800, Jing Xiangfeng wrote: > Remove the superfluous break, as there is a 'return' before it. > > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") > Signed-off-by: Jing Xiangfeng > Reviewed-by: Nick Desaulniers > Reviewed-by: Gustavo A. R.

Re: [PATCH] dma-fence: add get_signaled_timestamp to fence ops

2020-09-18 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 02:45:38PM -0700, Veera Sundaram Sankaran wrote: > Add an optional fence ops to allow drivers to be able to set the > timestamp for a fence. Some drivers have hardware capability to get > the precise timestamp of certain events based on which the fences > are triggered.

Re: [PATCH] drm/ttm: update kernel-doc line comments

2020-09-18 Thread Christian König
Am 18.09.20 um 14:46 schrieb Daniel Vetter: On Fri, Sep 18, 2020 at 06:44:25PM +0800, Huang Rui wrote: On Fri, Sep 18, 2020 at 05:52:58PM +0800, Tian Tao wrote: Update kernel-doc line comments to fix warnings reported by make W=1. drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-18 Thread Sumit Semwal
Hi Thomas, On Fri, 18 Sep 2020 at 11:36, Sumit Semwal wrote: > > Hello Thomas, > > On Mon, 14 Sep 2020 at 16:55, Thomas Zimmermann wrote: > > > > Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings > > of dma-buf memory in kernel address space. The functions operate with

Re: [PATCH] drm/ttm: update kernel-doc line comments

2020-09-18 Thread Huang Rui
On Fri, Sep 18, 2020 at 05:52:58PM +0800, Tian Tao wrote: > Update kernel-doc line comments to fix warnings reported by make W=1. > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > member 'glob' not described in 'ttm_shrink' > drivers/gpu/drm/ttm/ttm_memory.c:271: warning:

[PATCH] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

2020-09-18 Thread Yannick Fertre
Don't print error when probe deferred error is returned. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index

Re: [PATCH] dmabuf: fix NULL pointer dereference in dma_buf_release()

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 01:16:16PM +0200, Christian König wrote: > Am 18.09.20 um 12:32 schrieb Charan Teja Reddy: > > NULL pointer dereference is observed while exporting the dmabuf but > > failed to allocate the 'struct file' which results into the dropping of > > the allocated dentry

Re: [PATCH 0/3] fbdev: stop using compat_alloc_user_space

2020-09-18 Thread Daniel Vetter
On Fri, Sep 18, 2020 at 12:08:10PM +0200, Arnd Bergmann wrote: > The fbdev code uses compat_alloc_user_space in a few of its > compat_ioctl handlers, which tends to be a bit more complicated > and error-prone than calling the underlying handlers directly, > so I would like to remove it completely.

Re: [PATCH v9 7/8] Documentation/gpu: Add asynchronous flip documentation for i915

2020-09-18 Thread Ville Syrjälä
On Wed, Sep 16, 2020 at 08:38:23PM +0530, Karthik B S wrote: > Add the details of the implementation of asynchronous flips for i915. > > v7: -Rebased. > > v8: -Rebased. > > v9: -Rebased. > > Signed-off-by: Karthik B S > Signed-off-by: Vandita Kulkarni > --- > Documentation/gpu/i915.rst | 6

[PATCH] drm/panel: otm8009a: allow using non-continuous dsi clock

2020-09-18 Thread Yannick Fertre
From: Antonio Borneo The panel is able to work when dsi clock is non-continuous, thus the system power consumption can be reduced using such feature. Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c |

Re: [Intel-gfx] [PATCH 0/4] managed drm_device, absolute final leftover bits

2020-09-18 Thread Rodrigo Vivi
On Fri, Sep 18, 2020 at 11:03:12AM -0400, Alex Deucher wrote: > On Fri, Sep 18, 2020 at 9:25 AM Daniel Vetter wrote: > > > > Hi all, > > > > These are the leftovers of the leftovers of my initial drmm series to > > manage drm_device. > > > > Changes: > > - bugfixed i915 selftests > > - patch from

Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode

2020-09-18 Thread Colin Ian King
On 18/09/2020 17:22, Guido Günther wrote: > Hi, > On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently a null pointer check on pointer mode is passing mode to >> function drm_mode_vrefresh and this causes a null pointer dereference >> on mode. Fix

[PATCH 2/4] drm/i915/selftests: align more to real device lifetimes

2020-09-18 Thread Daniel Vetter
The big change is device_add so that device_del can auto-cleanup devres resources. This allows us to use devm_drm_dev_alloc, which removes the last user of drm_dev_init. v2: Rebased v3: use devres_open/release_group so we can use devm without real hacks in the driver core or having to create an

[PATCH 1/4] drm/i915/selftest: Create mock_destroy_device

2020-09-18 Thread Daniel Vetter
Just some prep work before we rework the lifetime handling, which requires replacing all the drm_dev_put in selftests by something else. v2: Don't go with a static inline, upsets the header tests and separation. Reviewed-by: Maarten Lankhorst Signed-off-by: Daniel Vetter ---

[PATCH 4/4] drm/dev: Remove drm_dev_init

2020-09-18 Thread Daniel Vetter
We can now also delete drm_dev_init, now that vkms, vgem and i915 selftests are resolved. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 41 +++--- drivers/gpu/drm/drm_internal.h | 1 + drivers/gpu/drm/drm_managed.c | 13 ---

[PATCH 0/4] managed drm_device, absolute final leftover bits

2020-09-18 Thread Daniel Vetter
Hi all, These are the leftovers of the leftovers of my initial drmm series to manage drm_device. Changes: - bugfixed i915 selftests - patch from Luben to finalize the admgpu conversion Alex & i915 maintainers, pls ack for merging this all through drm-misc-next since otherwise the final patch

[PATCH 3/4] drm/amdgpu: Convert to using devm_drm_dev_alloc() (v2)

2020-09-18 Thread Daniel Vetter
From: Luben Tuikov Convert to using devm_drm_dev_alloc(), as drm_dev_init() is going away. v2: Remove drm_dev_put() since a) devres doesn't do refcounting, see Documentation/driver-api/driver-model/devres.rst, Section 4, paragraph 1; and since b) devres acts as garbage collector

Re: [PATCH 4/4] drm/dev: Remove drm_dev_init

2020-09-18 Thread Thomas Zimmermann
Am 18.09.20 um 15:25 schrieb Daniel Vetter: > We can now also delete drm_dev_init, now that vkms, vgem and i915 > selftests are resolved. > > Signed-off-by: Daniel Vetter Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_drv.c | 41 +++--- >

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-18 Thread Dave Stevenson
Hi Maxime Thanks for the patch. On Fri, 18 Sep 2020 at 15:59, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > through a mux. > > However, changing that FIFO requires that we disable and then enable the > pixelvalve, so we want to assign FIFOs

Re: [PATCH 0/4] managed drm_device, absolute final leftover bits

2020-09-18 Thread Alex Deucher
On Fri, Sep 18, 2020 at 9:25 AM Daniel Vetter wrote: > > Hi all, > > These are the leftovers of the leftovers of my initial drmm series to > manage drm_device. > > Changes: > - bugfixed i915 selftests > - patch from Luben to finalize the admgpu conversion > > Alex & i915 maintainers, pls ack for

Re: [PATCH 00/18] Convert arch/arm to use iommu-dma

2020-09-18 Thread Marek Szyprowski
Hi all, On 24.08.2020 13:40, Marek Szyprowski wrote: > On 20.08.2020 17:08, Robin Murphy wrote: >> After 5 years or so of intending to get round to this, finally the >> time comes! The changes themselves actualy turn out to be relatively >> mechanical; the bigger concern appears to be how to get

Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode

2020-09-18 Thread Guido Günther
Hi, On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote: > From: Colin Ian King > > Currently a null pointer check on pointer mode is passing mode to > function drm_mode_vrefresh and this causes a null pointer dereference > on mode. Fix this by not calling drm_mode_vrefresh since the

[PATCH][next] drm/panel: fix null pointer dereference on pointer mode

2020-09-18 Thread Colin King
From: Colin Ian King Currently a null pointer check on pointer mode is passing mode to function drm_mode_vrefresh and this causes a null pointer dereference on mode. Fix this by not calling drm_mode_vrefresh since the call is only required for error reporting. Addresses-Coverity: ("Dereference

Re: [PATCH 2/2] drm/vc4: crtc: Keep the previously assigned HVS FIFO

2020-09-18 Thread Dave Stevenson
Hi Maxime Thanks for the patch - it makes mode switching reliable for me! :-) On Fri, 18 Sep 2020 at 15:59, Maxime Ripard wrote: > > The HVS FIFOs are currently assigned each time we have an atomic_check > for all the enabled CRTCs. > > However, if we are running multiple outputs in parallel

Re: [PATCH] drm/vc4: hvs: Pull the state of all the CRTCs prior to PV muxing

2020-09-18 Thread Dave Stevenson
Hi Maxime On Thu, 17 Sep 2020 at 13:16, Maxime Ripard wrote: > > The vc4 display engine has a first controller called the HVS that will > perform the composition of the planes. That HVS has 3 FIFOs and can > therefore compose planes for up to three outputs. The timings part is > generated

Re: [PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-18 Thread Alex Deucher
On Fri, Sep 18, 2020 at 3:17 AM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Hi @Sasha Levin @Deucher, Alexander, > > The following changes need to be applied also. > Otherwise, you may see unexpected shutdown on stress gpu loading on Vega10. > > drm/amd/pm:

Re: [PATCH 14/18] drm/exynos: Consolidate IOMMU mapping code

2020-09-18 Thread Marek Szyprowski
Hi Robin, On 20.08.2020 17:08, Robin Murphy wrote: > Now that arch/arm is wired up for default domains and iommu-dma, we can > consolidate the shared mapping code onto the generic IOMMU API version, > and retire the arch-specific implementation. > > Signed-off-by: Robin Murphy > > --- > This is

[PATCH 2/2] drm/ttm: stop dangerous caching attribute change

2020-09-18 Thread Christian König
When we swapout/in a BO we try to change the caching attributes of the pages before/after doing the copy. On x86 this is done by calling set_pages_uc(), set_memory_wc() or set_pages_wb() for not highmem pages to update the linear mapping of the page. On all other platforms we do exactly nothing.

[PATCH 1/2] drm/ttm: remove nonsense AGP handling

2020-09-18 Thread Christian König
map_page_into_agp() and unmap_page_from_agp() are only defined on x86. On all other platforms they are defined as noops. So this code doesn't has any effect at all. Signed-off-by: Christian König --- include/drm/ttm/ttm_set_memory.h | 44 1 file changed, 44