Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 9:20 PM Suren Baghdasaryan wrote: > > On Wed, Feb 3, 2021 at 12:52 AM Daniel Vetter wrote: > > > > On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox wrote: > > > > > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > > > Replace BUG_ON(vma->vm_flags &

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2021-02-03 Thread Kenny Ho
Daniel, I will have to get back to you later on the details of this because my head is currently context switched to some infrastructure and Kubernetes/golang work, so I am having a hard time digesting what you are saying. I am new to the bpf stuff so this is about my own learning as well as a

Re: [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-02-03 Thread Rob Clark
On Wed, Feb 3, 2021 at 2:10 AM Daniel Vetter wrote: > > On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote: > > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote: > > > > > > On Mon, Jan 25, 2021 at 03:49:01PM -0800, Stephen Boyd wrote: > > > > Lockdep complains about an AA deadlock when

Re: [PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-02-03 Thread Akhil P Oommen
On 2/3/2021 4:22 AM, Bjorn Andersson wrote: On Fri 08 Jan 12:15 CST 2021, Akhil P Oommen wrote: Please align the $subject prefix with other changes in the same file. I fixed it up while picking up the patch this time. Will take of this in future. Thanks, Bjorn. -Akhil. Regards, Bjorn Add

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

2021-02-03 Thread Heiko Stübner
Hi Sebastian, Am Mittwoch, 3. Februar 2021, 19:14:22 CET schrieb Sebastian Fricke: > Hey Heiko, > > I have tested your patch set on my nanoPC-T4, here is a complete log > with: > - relevant kernel log entries > - system information > - media ctl output > - sysfs entry information > >

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2021-02-03 Thread Michael Tretter
On Mon, 01 Feb 2021 17:33:14 +0100, Michael Tretter wrote: > On Tue, 15 Sep 2020 21:40:40 +0200, Andrzej Hajda wrote: > > W dniu 14.09.2020 o 23:19, Andrzej Hajda pisze: > > > On 14.09.2020 22:01, Michael Tretter wrote: > > >> On Mon, 14 Sep 2020 14:31:19 +0200, Marek Szyprowski wrote: > > >>> On

[PATCH] RFC: dma-buf: Require VM_SPECIAL vma for mmap

2021-02-03 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident

Re: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 5:57 PM Xiong, Jianxin wrote: > > > -Original Message- > > From: Leon Romanovsky > > Sent: Tuesday, February 02, 2021 10:03 PM > > To: Daniel Vetter > > Cc: Xiong, Jianxin ; Jason Gunthorpe > > ; Gal Pressman ; Yishai Hadas > > ; linux-rdma ; Edward > > Srouji ;

Re: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support

2021-02-03 Thread Emil Velikov
On Wed, 3 Feb 2021 at 17:58, Xiong, Jianxin wrote: > > > -Original Message- > > From: Daniel Vetter > > Sent: Wednesday, February 03, 2021 9:53 AM > > To: Xiong, Jianxin > > Cc: Leon Romanovsky ; Jason Gunthorpe ; Gal > > Pressman ; Yishai Hadas > > ; linux-rdma ; Edward > > Srouji ;

Re: [PATCH 3/3] [RFC] drm/exynos: Add basic i.MX8MM support code

2021-02-03 Thread Michael Tretter
On Mon, 05 Oct 2020 15:42:50 +0200, Marek Vasut wrote: > This adds basic i.MX8MM glue code for the Samsung DSIM PHY. > There are still a couple of items which need to be sorted out > in drivers/gpu/drm/bridge/samsung-dsim.c before this can even > be merged, specifically: > > - The dsi->out_bridge

RE: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support

2021-02-03 Thread Xiong, Jianxin
> -Original Message- > From: Daniel Vetter > Sent: Wednesday, February 03, 2021 9:53 AM > To: Xiong, Jianxin > Cc: Leon Romanovsky ; Jason Gunthorpe ; Gal > Pressman ; Yishai Hadas > ; linux-rdma ; Edward Srouji > ; dri-devel de...@lists.freedesktop.org>; Christian Koenig ; > Doug

Re: [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-03 Thread Rodrigo Vivi
On Mon, Jan 25, 2021 at 07:10:30PM -0500, Lyude Paul wrote: > Since we're about to implement eDP backlight support in nouveau using the > standard protocol from VESA, we might as well just take the code that's > already written for this and move it into a set of shared DRM helpers. > > Note that

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 6:14 PM Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 5:42 PM Alex Deucher wrote: > > > > On Wed, Feb 3, 2021 at 9:42 AM Daniel Vetter wrote: > > > > > > On Wed, Feb 3, 2021 at 3:33 PM Bridgman, John > > > wrote: > > > > > > > > ‎>>Uh, that doesn't work. If you want

[Bug 211501] Kernel freeze when waking monitor from blanking / DPMS (AMDGPU / DC)

2021-02-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211501 --- Comment #2 from Jasen Borisov (borisovja...@protonmail.com) --- OK, it just happened again. More info: The secondary monitor lights up, but just shows a black screen with the mouse cursor, but the primary monitor does not. This makes me

Re: [PATCH] drm/nouveau: fix dma syncing warning with debugging on.

2021-02-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Let me know when this has been pushed somewhere On Mon, 2021-02-01 at 11:01 +1000, Dave Airlie wrote: > From: Dave Airlie > > Since I wrote the below patch if you run a debug kernel you can a > dma debug warning like: > nouveau :1f:00.0: DMA-API: device driver

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 9:29 PM Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 9:20 PM Suren Baghdasaryan wrote: > > > > On Wed, Feb 3, 2021 at 12:52 AM Daniel Vetter > > wrote: > > > > > > On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox wrote: > > > > > > > > On Tue, Feb 02, 2021 at 04:31:33PM

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 5:42 PM Alex Deucher wrote: > > On Wed, Feb 3, 2021 at 9:42 AM Daniel Vetter wrote: > > > > On Wed, Feb 3, 2021 at 3:33 PM Bridgman, John wrote: > > > > > > ‎>>Uh, that doesn't work. If you want infinite compute queues you need the > > > amdkfd model with preempt-ctx

Re: [Intel-gfx] [PATCH 1/4] drm/dp_mst: Don't report ports connected if nothing is attached to them

2021-02-03 Thread Imre Deak
On Mon, Feb 01, 2021 at 02:01:42PM +0200, Imre Deak wrote: > Reporting a port as connected if nothing is attached to them leads to > any i2c transactions on this port trying to use an uninitialized i2c > adapter, fix this. > > Let's account for this case even if branch devices have no good reason

Re: [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-03 Thread Lyude Paul
On Wed, 2021-02-03 at 15:58 -0500, Rodrigo Vivi wrote: > On Mon, Jan 25, 2021 at 07:10:30PM -0500, Lyude Paul wrote: > > Since we're about to implement eDP backlight support in nouveau using the > > standard protocol from VESA, we might as well just take the code that's > > already written for

[PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-03 Thread Ville Syrjala
From: Ville Syrjälä drm_vblank_restore() exists because certain power saving states can clobber the hardware frame counter. The way it does this is by guesstimating how many frames were missed purely based on the difference between the last stored timestamp vs. a newly sampled timestamp. If we

Re: [PATCH 2/3] iommu/io-pgtable-arm: Add IOMMU_LLC page protection flag

2021-02-03 Thread Rob Clark
On Wed, Feb 3, 2021 at 1:46 PM Will Deacon wrote: > > On Tue, Feb 02, 2021 at 11:56:27AM +0530, Sai Prakash Ranjan wrote: > > On 2021-02-01 23:50, Jordan Crouse wrote: > > > On Mon, Feb 01, 2021 at 08:20:44AM -0800, Rob Clark wrote: > > > > On Mon, Feb 1, 2021 at 3:16 AM Will Deacon wrote: > > >

Re: [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly

2021-02-03 Thread Masahiro Yamada
On Thu, Feb 4, 2021 at 12:23 AM Petr Mladek wrote: > > On Tue 2021-02-02 09:44:22, John Ogness wrote: > > On 2021-02-02, Masahiro Yamada wrote: > > > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of > > > CONFIG_CONSOLE_LOGLEVEL_DEFAULT. > > > > > > When you change

Re: [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-02-03 Thread Rob Clark
On Wed, Feb 3, 2021 at 1:58 PM Stephen Boyd wrote: > > Quoting Rob Clark (2021-02-03 09:29:09) > > On Wed, Feb 3, 2021 at 2:10 AM Daniel Vetter wrote: > > > > > > On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote: > > > > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote: > > > > > > >

Re: [PATCH 2/3] iommu/io-pgtable-arm: Add IOMMU_LLC page protection flag

2021-02-03 Thread Will Deacon
On Tue, Feb 02, 2021 at 11:56:27AM +0530, Sai Prakash Ranjan wrote: > On 2021-02-01 23:50, Jordan Crouse wrote: > > On Mon, Feb 01, 2021 at 08:20:44AM -0800, Rob Clark wrote: > > > On Mon, Feb 1, 2021 at 3:16 AM Will Deacon wrote: > > > > On Fri, Jan 29, 2021 at 03:12:59PM +0530, Sai Prakash

[GIT PULL] mediatek drm next for 5.12

2021-02-03 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Decouple Mediatek DRM sub driver 2. Share mtk mutex driver for both DRM and MDP 3. Add support for SoC MT8183 Regards, Chun-Kuang. The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800)

Re: [RFC PATCH 7/9] drmcg: Add initial support for tracking gpu time usage

2021-02-03 Thread Brian Welty
On 2/3/2021 5:25 AM, Joonas Lahtinen wrote: > Quoting Brian Welty (2021-01-26 23:46:24) >> Single control below is added to DRM cgroup controller in order to track >> user execution time for GPU devices. It is up to device drivers to >> charge execution time to the cgroup via

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-02-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 --- Comment #16 from Shawn Anastasio (sh...@anastas.io) --- Created attachment 295063 --> https://bugzilla.kernel.org/attachment.cgi?id=295063=edit kernel log I have encountered the same issue on 5.10.10 which contains the revert. Attached is

[PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-02-03 Thread Ankit Nautiyal
DP-HDMI2.1 PCON has DSC encoder caps defined in registers 0x92-0x9E. Do not read the registers if DPCD rev < 1.4. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/2868 Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 2/3] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-02-03 Thread Ankit Nautiyal
Currently the FRL training mode (Concurrent, Sequential) and training type (Normal, Extended) are not defined properly and are passed as bool values in drm_helpers for pcon configuration for FRL training. This patch: -Defines FRL training type and link bring up sequence mode as enum. -Fixes the

[PATCH 3/3] i915/display: Remove FRL related code from disable DP sequence for older platforms

2021-02-03 Thread Ankit Nautiyal
Remove code for resetting frl related members from intel_disable_dp, as this is not applicable for older platforms. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

Re: [GIT PULL] mediatek drm next for 5.12

2021-02-03 Thread Dave Airlie
On Thu, 4 Feb 2021 at 09:22, Chun-Kuang Hu wrote: > > Hi, Dave & Daniel: > > This includes: > > 1. Decouple Mediatek DRM sub driver > 2. Share mtk mutex driver for both DRM and MDP > 3. Add support for SoC MT8183 Hi Chun-Kuang, dim: e83421b9acad ("drm/mediatek: Fix aal size config"): Subject

linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

2021-02-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drivers-x86 tree got a conflict in: drivers/gpu/drm/gma500/Kconfig drivers/gpu/drm/gma500/mdfld_device.c drivers/gpu/drm/gma500/mdfld_dsi_output.c drivers/gpu/drm/gma500/mdfld_output.c drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c between commits:

[PATCH 0/3] HDMI2.1 PCON Misc Fixes

2021-02-03 Thread Ankit Nautiyal
Patch1: fixes gitlab issue: https://gitlab.freedesktop.org/drm/intel/-/issues/2868 Patch2: Tweaks the drm_helpers for PCON configuration Patch3: Removes unwanted code not applicable for older platforms. Ankit Nautiyal (3): i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

[pull] amdgpu, amdkfd drm-fixes-5.11

2021-02-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit e0ecafede87eb1a3d1e708f0365fad0d59489285: Merge tag 'amd-drm-fixes-5.11-2021-01-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-01-29 11:36:38 +1000) are available in the Git repository at:

[pull] amdgpu, amdkfd drm-next-5.12

2021-02-03 Thread Alex Deucher
Hi Dave, Daniel, More fixes for 5.12. Same PR from last week with the issue Felix reported fixed and a few more additional fixes on top. The following changes since commit a6b8720c2f85143561c3453e1cf928a2f8586ac0: Merge tag 'amd-drm-next-5.12-2021-01-20' of

Re: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-02-03 Thread John Hubbard
On 12/15/20 1:27 PM, Jianxin Xiong wrote: This patch series adds dma-buf importer role to the RDMA driver in attempt to support RDMA using device memory such as GPU VRAM. Dma-buf is chosen for a few reasons: first, the API is relatively simple and allows a lot of flexibility in implementing the

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Christian König
Am 03.02.21 um 21:20 schrieb Suren Baghdasaryan: [SNIP] If there is a reason to set this flag other than historical use of carveout memory then we wanted to catch such cases and fix the drivers that moved to using dmabuf heaps. However maybe there are other reasons and if so I would be very

Re: [amdgpu] deadlock

2021-02-03 Thread Alex Deucher
On Wed, Feb 3, 2021 at 9:42 AM Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 3:33 PM Bridgman, John wrote: > > > > ‎>>Uh, that doesn't work. If you want infinite compute queues you need the > > amdkfd model with preempt-ctx dma_fence. If you allow normal cs ioctl to > > run forever, you just

RE: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support

2021-02-03 Thread Xiong, Jianxin
> -Original Message- > From: Leon Romanovsky > Sent: Tuesday, February 02, 2021 10:03 PM > To: Daniel Vetter > Cc: Xiong, Jianxin ; Jason Gunthorpe > ; Gal Pressman ; Yishai Hadas > ; linux-rdma ; Edward Srouji > ; dri-devel de...@lists.freedesktop.org>; Christian Koenig ; > Doug

Re: [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm

2021-02-03 Thread Christian König
Am 03.02.21 um 03:02 schrieb Suren Baghdasaryan: On Tue, Feb 2, 2021 at 5:39 PM Minchan Kim wrote: On Tue, Feb 02, 2021 at 04:31:34PM -0800, Suren Baghdasaryan wrote: Currently system heap maps its buffers with VM_PFNMAP flag using remap_pfn_range. This results in such buffers not being

[PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

2021-02-03 Thread Jagan Teki
Usual I2C configured DSI bridge drivers have drm_bridge_add in probe and mipi_dsi_attach in bridge attach functions. With, this approach the drm pipeline is unable to find the dsi bridge in stm drm drivers since the dw-mipi-dsi bridge is adding drm bridge during bridge attach operations instead

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Simon Ser
On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov wrote: > As summed in the commit message the burden is only applicable when all > of the following are set: > - non-linux > - force DRM_FOURCC_STANDALONE > - c99 -pedantic > > Even then, we're talking about a compilation warning. So

Re: [RFC][PATCH 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-02-03 Thread Daniel Vetter
On Tue, Feb 02, 2021 at 09:56:14PM -0800, John Stultz wrote: > On Tue, Feb 2, 2021 at 6:04 AM Daniel Vetter wrote: > > > > On Fri, Jan 22, 2021 at 05:28:32PM -0800, John Stultz wrote: > > > On Mon, Dec 21, 2020 at 2:09 PM Daniel Vetter wrote: > > > > > > > > On Fri, Dec 18, 2020 at 05:16:56PM

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 2:41 PM Andy Shevchenko wrote: > > Hi guys, > > This is first part of Intel MID outdated platforms removal. It's collected > into > immutable branch with a given tag, please pull to yours subsystems. > > (All changes are tagged by the respective maintainers) Bart, can

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Emil Velikov
On Wed, 3 Feb 2021 at 09:27, Simon Ser wrote: > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov > emil.l.veli...@gmail.com wrote: > > > As summed in the commit message the burden is only applicable when all > > of the following are set: > > - non-linux > > - force

[amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
Hi all, I have a deadlock with the amdgpu mainline driver when running in parallel two OpenCL applications. So far, we've been able to replicate it easily by executing clinfo and MatrixMultiplication (from AMD opencl-samples). It's quite old the opencl-samples so, if you have any other suggestion

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 9:36 AM Christian König wrote: > > Hi Daniel, > > this is not a deadlock, but rather a hardware lockup. Are you sure? Ime getting stuck in dma_fence_wait has generally good chance of being a dma_fence deadlock. GPU hang should never result in a forever stuck dma_fence.

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
On Wed, 3 Feb 2021 at 09:51, Christian König wrote: > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > wrote: > >> Hi Daniel, > >> > >> this is not a deadlock, but rather a hardware lockup. > > Are you sure? Ime getting stuck in dma_fence_wait

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-02-03 Thread Hans Verkuil
Hi Sam, Are you able to work on a v4? I haven't heard from you for some time now. I would be willing to take over this series if it wasn't for the fact that I do not have any hardware to test this with. Regards, Hans On 01/02/2021 22:56, Lyude Paul wrote: > On Wed, 2020-09-23 at 12:13

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Geert Uytterhoeven
Hi Rob, On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote: > Properties in if/then schemas weren't getting checked by the meta-schemas. > Enabling meta-schema checks finds several errors. > > The use of an 'items' schema (as opposed to the list form) is wrong in > some cases as it applies to all

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-02-03 Thread Thomas Zimmermann
Hi Am 15.01.21 um 09:06 schrieb Geert Uytterhoeven: Hi Daniel, On Thu, Jan 14, 2021 at 5:11 PM Daniel Vetter wrote: On Thu, Jan 14, 2021 at 4:56 PM Geert Uytterhoeven wrote: On Tue, Jan 12, 2021 at 5:00 PM Daniel Vetter wrote: On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds wrote: On

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread Simon Ser
On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov emil.l.veli...@gmail.com wrote: > As summed in the commit message the burden is only applicable when all > of the following are set: > - non-linux > - force DRM_FOURCC_STANDALONE > - c99 -pedantic Oh, and FWIW, this is not a

Re: [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-02-03 Thread Daniel Vetter
On Tue, Feb 02, 2021 at 08:51:25AM -0800, Rob Clark wrote: > On Tue, Feb 2, 2021 at 7:46 AM Daniel Vetter wrote: > > > > On Mon, Jan 25, 2021 at 03:49:01PM -0800, Stephen Boyd wrote: > > > Lockdep complains about an AA deadlock when rebooting the device. > > > > > >

Re: [PATCH 11/13] module: move struct symsearch to module.c

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > struct symsearch is only used inside of module.h, so move the definition > out of module.h. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel mailing list

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 02/02/21 19:45, Rob Clark ha scritto: On Tue, Feb 2, 2021 at 6:32 AM AngeloGioacchino Del Regno wrote: Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark

[PATCH v1] drm/qxl: do not run release if qxl failed to init

2021-02-03 Thread Tong Zhang
if qxl_device_init() fail, drm device will not be registered, in this case, do not run qxl_drm_release() [5.258534] == [5.258931] BUG: KASAN: user-memory-access in qxl_destroy_monitors_object+0x42/0xa0 [qxl] [5.259388]

Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

2021-02-03 Thread Viresh Kumar
On 02-02-21, 20:43, Uwe Kleine-König wrote: > My build tests failed to catch that amba driver that would have needed > adaption in commit 3fd269e74f2f ("amba: Make the remove callback return > void"). Change the remove function to make the driver build again. > > Reported-by: kernel test robot >

[PATCH] drm/msm/dpu: remove unneeded semicolon

2021-02-03 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:752:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol

2021-02-03 Thread Miroslav Benes
On Mon, 1 Feb 2021, Christoph Hellwig wrote: > On Mon, Feb 01, 2021 at 02:37:12PM +0100, Miroslav Benes wrote: > > > > This change is not needed. (objname == NULL) means that we are > > > > interested only in symbols in "vmlinux". > > > > > > > > module_kallsyms_on_each_symbol(klp_find_callback,

[PATCH] gpu/drm/msm: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 1826 pr_err is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

[PATCH] amd/display: remove unneeded variable: "pattern"

2021-02-03 Thread Bernard Zhao
Remove unneeded variable: "pattern". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Stephen Boyd
Quoting Bernard Zhao (2021-02-02 04:32:03) > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH] drm/hisilicon: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 852 DRM_ERROR is redundant because memory alloc already prints an error when failed. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

[PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "rc". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index d1780bcac8cc..9cc816663668 100644 ---

[PATCH] video: udlfb: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/video/fbdev/udlfb.c:1452:8-16: WARNING: use scnprintf or sprintf. ./drivers/video/fbdev/udlfb.c:1444:8-16: WARNING: use scnprintf or sprintf. ./drivers/video/fbdev/udlfb.c:1436:8-16: WARNING: use scnprintf or sprintf.

[PATCH] drm/msm/dp: remove unneeded semicolon

2021-02-03 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/msm/dp/dp_ctrl.c:1161:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c

Re: [PATCH 2/3] fix the out-of-bounds access of dramsr13

2021-02-03 Thread FUZZ DR
The patch in previous email is a stupid mistake, please ignore it. Thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Matthew Wilcox
On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > WARN_ON_ONCE and returning an error. This is to ensure users of the > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > and get an

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Daniel Vetter
On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set

Re: [amdgpu] deadlock

2021-02-03 Thread Daniel Gomez
On Wed, 3 Feb 2021 at 10:17, Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 9:51 AM Christian König > wrote: > > > > Am 03.02.21 um 09:48 schrieb Daniel Vetter: > > > On Wed, Feb 3, 2021 at 9:36 AM Christian König > > > wrote: > > >> Hi Daniel, > > >> > > >> this is not a deadlock, but

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-02-03 Thread Andy Shevchenko
On Tue, Jan 26, 2021 at 4:23 PM Hans de Goede wrote: > On 1/26/21 1:38 PM, Andy Shevchenko wrote: > > Hi guys, > > > > This is first part of Intel MID outdated platforms removal. It's collected > > into > > immutable branch with a given tag, please pull to yours subsystems. > > > > (All changes

Re: [PATCH] drm/vc4: hvs: Fix buffer overflow with the dlist handling

2021-02-03 Thread Maxime Ripard
On Fri, Jan 29, 2021 at 05:06:47PM +0100, Maxime Ripard wrote: > Commit 0a038c1c29a7 ("drm/vc4: Move LBM creation out of > vc4_plane_mode_set()") changed the LBM allocation logic from first > allocating the LBM memory for the plane to running mode_set, > adding a gap in the LBM, and then running

Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

2021-02-03 Thread Miaohe Lin
Hi: On 2021/2/3 8:31, Suren Baghdasaryan wrote: > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > WARN_ON_ONCE and returning an error. This is to ensure users of the > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > and get an indication of an error

Re: [PATCH 07/13] module: mark module_mutex static

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > Except for two lockdep asserts module_mutex is only used in module.c. > Remove the two asserts given that the functions they are in are not > exported and just called from the module code, and mark module_mutex > static. > > Signed-off-by: Christoph

Re: [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly

2021-02-03 Thread John Ogness
On 2021-02-02, Masahiro Yamada wrote: > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of > CONFIG_CONSOLE_LOGLEVEL_DEFAULT. > > When you change CONFIG_CONSOLE_LOGLEVEL_DEFAULT from Kconfig, almost > all objects are rebuilt because CONFIG_CONSOLE_LOGLEVEL_DEFAULT is > used in , which

Re: [PATCH 08/13] module: remove each_symbol_in_section

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_in_section just contains a trivial loop over its arguments. > Just open code the loop in the two callers. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel

Re: [PATCH 3/5] drm/msm/dsi_pll_10nm: Fix bad VCO rate calculation and prescaler

2021-02-03 Thread AngeloGioacchino Del Regno
Il 01/02/21 18:31, Rob Clark ha scritto: On Mon, Feb 1, 2021 at 9:18 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 9:05 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 7:47 AM Rob Clark wrote: On Mon, Feb 1, 2021 at 2:11 AM AngeloGioacchino Del Regno wrote: Il 31/01/21 20:50, Rob Clark ha

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread James Park
On Tue, Feb 2, 2021 at 2:47 PM Emil Velikov wrote: > > Currently, the drm_fourcc.h header depends on drm.h for __u32 and __u64. > At the same time drm.h pulls a lot of unneeded symbols. > > Add new guard DRM_FOURCC_STANDALONE, which when set will use local > declaration of said symbols. > > When

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-03 Thread FUZZ DR
Sorry about the missing description, I have a description at my local commit. But the commit description disappeared when I used git send-email to submit this patch. backlight: pcf50633: pdata may be a null pointer, null pointer dereference causes crash pdata has been checked at line 120 before

[PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-03 Thread Oliver Graute
Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD to panel-simple. The panel spec from Variscite can be found at: https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf Signed-off-by: Oliver Graute Cc: Marco Felsch Cc: Fabio Estevam --- v3: - added flags

Re: [PATCH 09/13] module: merge each_symbol_section into find_symbol

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_section is only called by find_symbol, so merge the two > functions. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M ___ dri-devel mailing list

Re: [PATCH v4 2/2] arm: dts: sc7180: Add support for gpu fuse

2021-02-03 Thread Bjorn Andersson
On Fri 08 Jan 12:15 CST 2021, Akhil P Oommen wrote: Please align the $subject prefix with other changes in the same file. I fixed it up while picking up the patch this time. Regards, Bjorn > Add support for gpu fuse to help identify the supported opps. > > Signed-off-by: Akhil P Oommen > ---

[PATCH] drm/amdgpu: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:207:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:185:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:163:8-16: WARNING: use

Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol

2021-02-03 Thread Miroslav Benes
> void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); >

[PATCH] drm/vc4: remove unneeded variable: "ret"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/vc4/vc4_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index b641252939d8..445d3bab89e0 100644 ---

[PATCH] drm/tegra: remove unneeded variable: "ret"

2021-02-03 Thread Bernard Zhao
remove unneeded variable: "ret". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/dpaux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 105fb9cdbb3b..b8abd55f3ef8 100644 ---

Re: [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol when required

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > kallsyms_on_each_symbol and module_kallsyms_on_each_symbol are only used > by the livepatching code, so don't build them if livepatching is not > enabled. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M

[PATCH] drm/msm/adreno: fix debugfs_simple_attr.cocci warnings

2021-02-03 Thread Tian Tao
fixed the below warning: ./drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:141:0-23: WARNING: reset_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Signed-off-by: Tian Tao --- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 13/13] module: remove EXPORT_UNUSED_SYMBOL*

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > EXPORT_UNUSED_SYMBOL* is not actually used anywhere. Remove the > unused functionality as we generally just remove unused code anyway. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-02-03 Thread Phillip Susi
Daniel Vetter writes: > Just a quick comment on this: Since most framebuffers are write-combining, > and reads from that tend to be ~3 orders of magnitude slower than writes > (at least on the pile of machines I looked at here, there's big > differences, and some special streaming cpu

[PATCH] drm/amdgpu: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-03 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:220:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:249:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

Re: [PATCH] drm/vc4: remove unneeded variable: "ret"

2021-02-03 Thread Maxime Ripard
On Tue, Feb 02, 2021 at 04:23:38AM -0800, Bernard Zhao wrote: > remove unneeded variable: "ret". > > Signed-off-by: Bernard Zhao Applied, thanks maxime signature.asc Description: PGP signature ___ dri-devel mailing list

Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard

2021-02-03 Thread James Park
On Tue, Feb 2, 2021 at 4:57 PM Emil Velikov wrote: > On Tue, 2 Feb 2021 at 23:25, James Park > wrote: > > > > On Tue, Feb 2, 2021 at 2:47 PM Emil Velikov > wrote: > > > > > > Currently, the drm_fourcc.h header depends on drm.h for __u32 and > __u64. > > > At the same time drm.h pulls a lot of

[PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed

2021-02-03 Thread Bernard Zhao
Line 1590 DRM_ERROR is redundant because devm_kzalloc() already prints an error. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

2021-02-03 Thread James Park
I'm not sure what your suggestion is. Move which #ifdef block where? I don't think everyone is of the opinion that adding drm.h and pulling in unnecessary kernel structures is fine. If I'm not mistaken, the reason people are making me jump through hoops in the first place is to avoid that. I

Re: [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE

2021-02-03 Thread Miroslav Benes
On Tue, 2 Feb 2021, Christoph Hellwig wrote: > As far as I can tell this has never been used at all, and certainly > not any time recently. Right, I've always wondered about this one. > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-03 Thread Lukasz Luba
On 2/2/21 1:01 AM, Qiang Yu wrote: Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy for only one poll periodic, in this case 50ms, right? Not exactly. Driver sets the polling interval to 50ms (in this case) because it

Re: [Linux-graphics-maintainer] [PATCH 2/3] drm/ttm: move memory accounting into vmwgfx v3

2021-02-03 Thread Christian König
Hi Zack, thanks I can take over again from here on. Quite busy today, but I think I can go over the code once more tomorrow. Thanks for the help, Christian. Am 03.02.21 um 03:45 schrieb Zack Rusin: Just had a quick peek. The issue is that you can’t attach to the drm device (card0) because

Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init

2021-02-03 Thread Thomas Zimmermann
Applied to drm-misc-next. Thanks for the patch! Am 23.01.21 um 02:30 schrieb Ye Bin: Fix follow warning: drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable] struct pci_dev *pdev; ^~~~ Reported-by: Hulk

Re: [amdgpu] deadlock

2021-02-03 Thread Christian König
Hi Daniel, this is not a deadlock, but rather a hardware lockup. Which OpenCl stack are you using? Regards, Christian. Am 03.02.21 um 09:33 schrieb Daniel Gomez: Hi all, I have a deadlock with the amdgpu mainline driver when running in parallel two OpenCL applications. So far, we've been

  1   2   >