Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Martin Sebor wrote: > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of -Wstringop-overflow. > GCC 11 breaks it out as a separate warning to make it easier to > control. Both

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Michal Hocko
On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: > > > Am 20.03.21 um 14:17 schrieb Daniel Vetter: > > > > On Sat, Mar 20, 2021 at 10:04 AM Christian König > > > >

[PATCH] drm: rcar-du: Shutdown the display on system shutdown

2021-03-22 Thread Laurent Pinchart
When the system shuts down or warm reboots, the display may be active, with the hardware accessing system memory. Upon reboot, the DDR will not be accessible, which may cause issues. Implement the platform_driver .shutdown() operation and shut down the display to fix this. Signed-off-by: Laurent

Re: [PATCH] drm/amd: Fix a typo in two different sentences

2021-03-22 Thread Randy Dunlap
On 3/22/21 2:06 PM, Bhaskar Chowdhury wrote: > > s/defintion/definition/ .two different places. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/amd/include/atombios.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about using string operations on pointers that are > defined at compile time as offsets from a NULL pointer. Unfortunately > that also happens on the result of fix_to_virt(), which is a > compile-time constant for a constantn

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Rodrigo Vivi
On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > Hi, > > On 3/1/21 4:43 PM, Hans de Goede wrote: > > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > > Predia Basic tablet would no

[PATCH] drm/amd: Fix a typo in two different sentences

2021-03-22 Thread Bhaskar Chowdhury
s/defintion/definition/ .two different places. Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/amd/include/atombios.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atombios.h b/drivers/gpu/drm/amd/include/atombios.h index

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Ville Syrjälä
On Mon, Mar 22, 2021 at 10:28:06PM +0100, Hans de Goede wrote: > Hi, > > On 3/22/21 9:59 PM, Ville Syrjälä wrote: > > On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: > >> On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 3/1/21 4:43 PM, Hans de

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 11:09 PM Martin Sebor wrote: > On 3/22/21 2:29 PM, Ingo Molnar wrote: > > * Arnd Bergmann wrote: > > > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Matthias Kaehlcke
On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > From: Kalyan Thota > > DPU runtime resume will request for a min vote on the AXI bus as > it is a necessary step before turning ON the AXI clock. > > The change does below > 1) Move the icc path set before requesting runtime

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Hans de Goede
Hi, On 3/22/21 9:59 PM, Ville Syrjälä wrote: > On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: >> On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: >>> Hi, >>> >>> On 3/1/21 4:43 PM, Hans de Goede wrote: After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Ville Syrjälä
On Mon, Mar 22, 2021 at 04:51:47PM -0400, Rodrigo Vivi wrote: > On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > > Hi, > > > > On 3/1/21 4:43 PM, Hans de Goede wrote: > > > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > > > displays gracefully on reboot"),

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Martin Sebor
On 3/22/21 2:29 PM, Ingo Molnar wrote: * Arnd Bergmann wrote: From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time

[Bug 212397] New: Resume from suspend (S3) does not bring back video anymore

2021-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212397 Bug ID: 212397 Summary: Resume from suspend (S3) does not bring back video anymore Product: Drivers Version: 2.5 Kernel Version: 5.11.7 Hardware: All

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 9:29 PM Ingo Molnar wrote: > * Arnd Bergmann wrote: > > From: Arnd Bergmann > This is indeed rather ugly - and the other patch that removes a debug > check seems counterproductive as well. > > Do we know how many genuine bugs -Wstringop-overread-warning has > caught or

Re: [PATCH] video: mmp: Few typo fixes

2021-03-22 Thread Randy Dunlap
On 3/22/21 6:02 AM, Bhaskar Chowdhury wrote: > > s/configed/configured/ > s/registed/registered/ > s/defintions/definitions/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > include/video/mmp_disp.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2021-03-22 Thread Laurent Pinchart
Hi Stephen, On Mon, Nov 02, 2020 at 05:15:24PM -0800, Stephen Boyd wrote: > Quoting Sam Ravnborg (2020-11-01 09:37:41) > > Hi Stephen. > > > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > > This patch series cleans up the DDC code a little bit so that > > > it is more

[PATCH 1/2] drm: rcar-du: Don't put reference to drm_device in rcar_du_remove()

2021-03-22 Thread Laurent Pinchart
The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by:

[PATCH 2/2] drm: rcar-du: Shutdown the display on remove

2021-03-22 Thread Laurent Pinchart
When the device is unbound from the driver (the DU being a platform device, this occurs either when removing the DU module, or when unbinding the device manually through sysfs), the display may be active. Make sure it gets shut down. Signed-off-by: Laurent Pinchart ---

[PATCH] gpu: drm: amd: Remove duplicate includes

2021-03-22 Thread Wan Jiabing
../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included at line 32, so remove them. Signed-off-by: Wan Jiabing --- .../gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce110.c| 4 1 file changed, 4 deletions(-) diff --git

[PATCH v3 2/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-22 Thread Dario Binacchi
The tilcdc_pclk_diff() compares the requested pixel clock rate to the real one, so passing it clk_rate instead of clk_rate / clkdiv caused it to fail even if the clk_rate was properly set. Adding the real_pclk_rate variable makes the code more readable. Signed-off-by: Dario Binacchi --- (no

[PATCH v3 1/3] drm/tilcdc: rename req_rate to pclk_rate

2021-03-22 Thread Dario Binacchi
The req_rate name is a little misleading, so let's rename to pclk_rate (pixel clock rate). Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - The patch has been added in version 2. drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 ++-- 1 file changed, 6 insertions(+),

[PATCH v3 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-22 Thread Dario Binacchi
The series was born from a patch to fix the LCD pixel clock setting. Two additional patches have been added to this. One renames a misleading variable name that was probably the cause of the bug and the other fixes a warning message. Changes in v3: - Replace calculated with requested in the

[PATCH v3 3/3] drm/tilcdc: fix pixel clock setting warning message

2021-03-22 Thread Dario Binacchi
The warning message did not printed the LCD pixel clock rate but the LCD clock divisor input rate. As a consequence, the required and real pixel clock rates are now passed to the tilcdc_pclk_diff(). Signed-off-by: Dario Binacchi --- Changes in v3: - Replace calculated with requested in the

Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Rob Clark
On Mon, Mar 22, 2021 at 5:44 PM Matthias Kaehlcke wrote: > > On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > > From: Kalyan Thota > > > > DPU runtime resume will request for a min vote on the AXI bus as > > it is a necessary step before turning ON the AXI clock. > > > > The

[PATCH] drm/etnaviv: Remove redundant NULL check

2021-03-22 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL check before some freeing functions is not needed.

[V2][PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers

2021-03-22 Thread quanyang . wang
From: Quanyang Wang When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the error log as below: root@xilinx-zynqmp:~# insmod zynqmp-dpsub.ko [ 88.391289] [drm] Initialized zynqmp-dpsub 1.0.0 20130509 for fd4a.display on minor 0 [ 88.529906] Console: switching to colour

[PATCH] drm/bridge/lontium-lt9611uxc: Convert sysfs sprintf/snprintf family to sysfs_emit

2021-03-22 Thread Tian Tao
Fix the following coccicheck warning: drivers/gpu//drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Tian Tao --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/i915: A typo fix

2021-03-22 Thread Bhaskar Chowdhury
s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:23 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > > The RGB pixels

Re: [PATCH] drm/msm/dp: Fixed couple of typos

2021-03-22 Thread Stephen Boyd
Quoting Bhaskar Chowdhury (2021-03-17 23:26:50) > s/modueles/modules/ two different places > > Signed-off-by: Bhaskar Chowdhury > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH] gpu: drm: amd: Remove duplicate include of dce110_resource.h

2021-03-22 Thread Wan Jiabing
dce110/dce110_resource.h has been included at line 58, so remove the duplicate include at line 64. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2021-03-22 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-03-17 17:20:43) > Hi Stephen, > > Reviving a bit of an old thread, for a question. > > On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote: > > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector > > *connector) > > static int

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:34 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > > v5->v6: > > * No change. > > > >

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Liu Ying
Hi Marcel, On Tue, 2021-03-23 at 00:38 +, Marcel Ziswiler wrote: > On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > > This patch adds bindings for i.MX8qm/qxp display pixel link. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Liu Ying > > --- > > v5->v6: > > * No change. > > > >

[PATCH v4 0/2] gpu: drm: add driver for ili9361 panel

2021-03-22 Thread Daniel Mack
This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file Daniel Mack (2): dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF

[PATCH v4 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-03-22 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../bindings/display/ilitek,ili9163.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.yaml

[PATCH v4 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-03-22 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224

Re: [PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Randy Dunlap
On 3/22/21 5:06 AM, Bhaskar Chowdhury wrote: > > s/poiner/pointer/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h >

Re: [PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Randy Dunlap
On 3/21/21 11:27 PM, Bhaskar Chowdhury wrote: > > s/struture/structure/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 11:59 AM Daniel Vetter wrote: > > On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself,

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-22 Thread Christian König
Am 22.03.21 um 18:02 schrieb Daniel Vetter: On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: On Sun, Mar 21, 2021 at 03:18:28PM +0100, Christian König wrote: Am 20.03.21 um

Re: [PATCH v2] drm/radeon: don't evict if not initialized

2021-03-22 Thread Christian König
Am 21.03.21 um 16:19 schrieb Tong Zhang: TTM_PL_VRAM may not initialized at all when calling radeon_bo_evict_vram(). We need to check before doing eviction. [2.160837] BUG: kernel NULL pointer dereference, address: 0020 [2.161212] #PF: supervisor read access in kernel mode [

RE: [PATCH v3 3/3] drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available

2021-03-22 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Tuesday, March 9, 2021 10:09 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; ville.syrj...@linux.intel.com; Shankar, > Uma > ; airl...@linux.ie; jani.nik...@linux.intel.com > Subject: [PATCH v3 3/3]

Re: [PATCH 3/3] drm/ttm: switch to per device LRU lock

2021-03-22 Thread Huang Rui
On Fri, Mar 19, 2021 at 08:10:21PM +0800, Christian König wrote: > Am 19.03.21 um 05:32 schrieb Huang Rui: > > On Thu, Mar 18, 2021 at 08:47:19PM +0800, Christian König wrote: > >> Instead of having a global lock. > >> > >> Signed-off-by: Christian König > >> --- > >>

Re: [PATCH v2 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-22 Thread Tomi Valkeinen
On 21/03/2021 21:08, Jyri Sarha wrote: On 2021-03-21 10:31, Dario Binacchi wrote: The series was born from a patch to fix the LCD pixel clock setting. Two additional patches have been added to this. One renames a misleading variable name that was probably the cause of the bug and the other

Re: [RFC PATCH 2/2] mm,drm/ttm: Use VM_PFNMAP for TTM vmas

2021-03-22 Thread Christian König
Am 21.03.21 um 19:45 schrieb Thomas Hellström (Intel): To block fast gup we need to make sure TTM ptes are always special. With MIXEDMAP we, on architectures that don't support pte_special, insert normal ptes, but OTOH on those architectures, fast is not supported. At the same time, the function

[PATCH] drm/msm/dpu: Fix a typo

2021-03-22 Thread Bhaskar Chowdhury
s/struture/structure/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h index

[PATCH v4 3/3] drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available

2021-03-22 Thread Ankit Nautiyal
Add the check if source control mode is supported by the PCON, before starting configuring PCON for FRL training, as per spec VESA DP2.0-HDMI2.1 PCON Draft-1 Sec-7. v2: Added spec details for the change. (Uma) Signed-off-by: Ankit Nautiyal Reviewed-by: Uma Shankar ---

Re: [PATCH v2 3/3] drm/tilcdc: fix pixel clock setting warning message

2021-03-22 Thread Tomi Valkeinen
On 21/03/2021 10:31, Dario Binacchi wrote: The warning message did not printed the LCD pixel clock rate but the LCD clock divisor input rate. As a consequence, the required and real pixel clock rates are now passed to the tilcdc_pclk_diff(). Signed-off-by: Dario Binacchi --- Changes in v2: -

[PATCH v3 0/2] gpu: drm: add driver for ili9361 panel

2021-03-22 Thread Daniel Mack
This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format Daniel Mack (2): dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF .../bindings/display/ilitek,ili9163.yaml | 70 ++

Re: [RFC PATCH 01/11] dt-bindings: drm/bridge: ti-sn65dsi8: Make enable GPIO optional

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > The SN65DSI86 EN pin can be hardwired to a high level, or connected to a > global reset signal, not controllable by the kernel. Make it optional in > those cases. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Jagan Teki

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Christian König
Hi Daniel, Am 22.03.21 um 10:38 schrieb Daniel Gomez: On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: This caused a regression in kfdtest in a large-buffer stress test after memory allocation for user pages fails: I'm sorry to hear that. BTW, I guess you meant amdgpu leak patch and not

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Drop the CONTEXT_CLONE API

2021-03-22 Thread Tvrtko Ursulin
On 19/03/2021 22:38, Jason Ekstrand wrote: This API allows one context to grab bits out of another context upon creation. It can be used as a short-cut for setparam(getparam()) for things like I915_CONTEXT_PARAM_VM. However, it's never been used by any real userspace. It's used by a few IGT

[PATCH] drm/ttm: stop warning on TT shrinker failure v2

2021-03-22 Thread Christian König
Don't print a warning when we fail to allocate a page for swapping things out. v2: only stop the warning Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c

Re: [PATCH] drm/fourcc: add Vivante TS modifiers

2021-03-22 Thread Christian Gmeiner
Am Sa., 20. März 2021 um 20:11 Uhr schrieb Daniel Vetter : > > On Sat, Mar 20, 2021 at 10:28 AM Christian Gmeiner > wrote: > > > > Hi Lucas > > > > Am Fr., 19. März 2021 um 20:06 Uhr schrieb Lucas Stach > > : > > > > > > Vivante TS (tile-status) buffer modifiers. They can be combined with all >

[v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Kalyan Thota
From: Kalyan Thota DPU runtime resume will request for a min vote on the AXI bus as it is a necessary step before turning ON the AXI clock. The change does below 1) Move the icc path set before requesting runtime get_sync. 2) remove the dependency of hw catalog for min ib vote as it is

Re: [PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2021-03-22 Thread Laurent Pinchart
Hi Marek, (CC'ing Ron and the DT mailing list for the DT discussion) On Mon, Mar 22, 2021 at 11:29:04AM +0100, Marek Vasut wrote: > On 3/22/21 2:14 AM, Laurent Pinchart wrote: > > Hi Marek, > > Hi, > > [...] > > >> diff --git > >>

[PATCH 32/44] drm/amdkfd: multiple gpu migrate vram to vram

2021-03-22 Thread Felix Kuehling
If prefetch range to gpu with acutal location is another gpu, or GPU retry fault restore pages to migrate the range with acutal location is gpu, then migrate from one gpu to another gpu. Use system memory as bridge because sdma engine may not able to access another gpu vram, use sdma of source

[PATCH 43/44] drm/amdkfd: Correct locking during migration and mapping

2021-03-22 Thread Felix Kuehling
This fixes potential race conditions between any code that validates and maps SVM ranges and MMU notifiers. The whole sequence is encapsulated in svm_range_validate_and_map. The page_addr and hmm_range structures are not useful outside that function, so they were removed from struct svm_range.

[PATCH 41/44] drm/amdkfd: Remove broken deferred mapping

2021-03-22 Thread Felix Kuehling
Mapping without validation is broken. Also removed saving the pages from the last migration. They may be invalidated without an MMU notifier to catch it, so let the next proper validation take care of it. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 14

[PATCH 38/44] drm/amdkfd: Simplify split_by_granularity

2021-03-22 Thread Felix Kuehling
svm_range_split_by_granularity always added the parent range and only the parent range to the update list for the caller to add it to the deferred work list. So just do that in the caller unconditionally and eliminate the update_list parameter. Split the range so that the original prange is

[PATCH 42/44] drm/amdkfd: Allow invalid pages in migration.src

2021-03-22 Thread Felix Kuehling
This can happen when syste memory page were never allocated. Skip them during the migration. 0-initialize the BO. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git

[PATCH 39/44] drm/amdkfd: Point out several race conditions

2021-03-22 Thread Felix Kuehling
There are several race conditions with XNACK enabled. For now just some FIXME comments with ideas how to fix it. Change-Id: If0abab6dcb8f4e95c9d8820f6c569263eda29a89 Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 5 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c |

[PATCH 33/44] drm/amdkfd: Add SVM API support capability bits

2021-03-22 Thread Felix Kuehling
From: Philip Yang SVMAPISupported property added to HSA_CAPABILITY, the value match HSA_CAPABILITY defined in Thunk spec: SVMAPISupported: it will not be supported on older kernels that don't have HMM or on systems with GFXv8 or older GPUs without support for 48-bit virtual addresses.

[PATCH 35/44] drm/amdkfd: Call mutex_destroy

2021-03-22 Thread Felix Kuehling
Destroy SVM-related mutexes correctly. Change-Id: I85da30b1b0dce72433e6d3b507cb0b55b83b433c Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c

[PATCH 44/44] drm/amdkfd: Nested locking and invalidation of child ranges

2021-03-22 Thread Felix Kuehling
This allows validation of child ranges, so the GPU page fault handler can be more light-weight. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 40 +--- 2 files changed, 37 insertions(+), 11

[PATCH 34/44] drm/amdkfd: Fix dma unmapping

2021-03-22 Thread Felix Kuehling
Don't dma_unmap in unmap_from_gpu. The dma_addr arrays are protected by the migrate_mutex, which we cannot hold when unmapping in MMU notifiers. Instead dma_unmap and free dma_addr arrays whenever the pages_array is invalidated: when migrating to VRAM and when re-validating RAM. Freeing dma_addr

Re: [RFC PATCH 2/2] mm,drm/ttm: Use VM_PFNMAP for TTM vmas

2021-03-22 Thread Intel
Hi! On 3/22/21 8:47 AM, Christian König wrote: Am 21.03.21 um 19:45 schrieb Thomas Hellström (Intel): To block fast gup we need to make sure TTM ptes are always special. With MIXEDMAP we, on architectures that don't support pte_special, insert normal ptes, but OTOH on those architectures, fast

Re: [PATCH] drm/imx/dcss: Use device_get_match_data()

2021-03-22 Thread Ying Liu
Hi Fabio, On Mon, Mar 15, 2021 at 8:38 PM Fabio Estevam wrote: > > The retrieval of driver data can be a bit simplified by using > device_get_match_data(), so switch to it. > > Signed-off-by: Fabio Estevam > --- > drivers/gpu/drm/imx/dcss/dcss-dev.c | 9 + > 1 file changed, 1

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Daniel Gomez
On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: > > This caused a regression in kfdtest in a large-buffer stress test after > memory allocation for user pages fails: I'm sorry to hear that. BTW, I guess you meant amdgpu leak patch and not this one. Just some background for the mem leak patch

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Daniel Gomez
On Mon, 22 Mar 2021 at 11:34, Christian König wrote: > > Hi Daniel, > > Am 22.03.21 um 10:38 schrieb Daniel Gomez: > > On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: > >> This caused a regression in kfdtest in a large-buffer stress test after > >> memory allocation for user pages fails: > >

[PATCH 04/44] drm/amdkfd: register svm range

2021-03-22 Thread Felix Kuehling
From: Philip Yang svm range structure stores the range start address, size, attributes, flags, prefetch location and gpu bitmap which indicates which GPU this range maps to. Same virtual address is shared by CPU and GPUs. Process has svm range list which uses both interval tree and list to

[PATCH 08/44] drm/amdkfd: deregister svm range

2021-03-22 Thread Felix Kuehling
From: Philip Yang When application explicitly call unmap or unmap from mmput when application exit, driver will receive MMU_NOTIFY_UNMAP event to remove svm range from process svms object tree and list first, unmap from GPUs (in the following patch). Split the svm ranges to handle partial

[PATCH 09/44] drm/amdgpu: export vm update mapping interface

2021-03-22 Thread Felix Kuehling
From: Philip Yang It will be used by kfd to map svm range to GPU, because svm range does not have amdgpu_bo and bo_va, cannot use amdgpu_bo_update interface, use amdgpu vm update interface directly. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling ---

[PATCH 07/44] drm/amdkfd: validate svm range system memory

2021-03-22 Thread Felix Kuehling
From: Philip Yang Use HMM to get system memory pages address, which will be used to map to GPUs or migrate to vram. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 103 ++- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 4

[PATCH 12/44] drm/amdkfd: add xnack enabled flag to kfd_process

2021-03-22 Thread Felix Kuehling
From: Alex Sierra This flag is useful at cpu invalidation page table decision. Between select queue eviction or page fault. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 4 +++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 36

[PATCH 06/44] drm/amdgpu: add common HMM get pages function

2021-03-22 Thread Felix Kuehling
From: Philip Yang Move the HMM get pages function from amdgpu_ttm and to amdgpu_mn. This common function will be used by new svm APIs. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 83 +

[PATCH 00/44] Add HMM-based SVM memory manager to KFD v2

2021-03-22 Thread Felix Kuehling
Since the last patch series I sent on Jan 6 a lot has changed. Patches 1-33 are the cleaned up, rebased on amd-staging-drm-next 5.11 version from about a week ago. The remaining 11 patches are current work-in-progress with further cleanup and fixes. MMU notifiers and CPU page faults now can split

[PATCH 01/44] drm/amdgpu: replace per_device_list by array

2021-03-22 Thread Felix Kuehling
From: Alex Sierra Remove per_device_list from kfd_process and replace it with a kfd_process_device pointers array of MAX_GPU_INSTANCES size. This helps to manage the kfd_process_devices binded to a specific kfd_process. Also, functions used by kfd_chardev to iterate over the list were removed,

[PATCH 10/44] drm/amdkfd: map svm range to GPUs

2021-03-22 Thread Felix Kuehling
Use amdgpu_vm_bo_update_mapping to update GPU page table to map or unmap svm range system memory pages address to GPUs. Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 395 +--

[PATCH] drm/amd/pm/powerplay/smumgr/smu7_smumgr: Fix some typo error

2021-03-22 Thread samirweng1979
From: wengjianfeng change 'addres' to 'address' Signed-off-by: wengjianfeng --- drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c

[PATCH] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-22 Thread Yang Li
fixed the following coccicheck: ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Reported-by: Abaci Robot Signed-off-by: Yang Li ---

Re: [PATCH] drm/fourcc: add Vivante TS modifiers

2021-03-22 Thread Lucas Stach
Hi Christian, Am Montag, dem 22.03.2021 um 09:54 +0100 schrieb Christian Gmeiner: > Am Sa., 20. März 2021 um 20:11 Uhr schrieb Daniel Vetter : > > > > On Sat, Mar 20, 2021 at 10:28 AM Christian Gmeiner > > wrote: > > > > > > Hi Lucas > > > > > > Am Fr., 19. März 2021 um 20:06 Uhr schrieb

Re: [PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers

2021-03-22 Thread quanyang.wang
Hi Laurent, On 3/21/21 4:08 AM, Laurent Pinchart wrote: Hi Quanyang, Thank you for the patch. On Sat, Mar 20, 2021 at 04:37:39PM +0800, quanyang.w...@windriver.com wrote: From: Quanyang Wang When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the error log as below:

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-22 Thread Jagan Teki
On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart wrote: > > To simplify interfacing with the panel, wrap it in a panel-bridge and > let the DRM bridge helpers handle chaining of operations. > > This also prepares for support of DRM_BRIDGE_ATTACH_NO_CONNECTOR, which > requires all components in

Re: [PATCH v6 5/8] mm: Device exclusive memory access

2021-03-22 Thread Alistair Popple
On Monday, 15 March 2021 6:42:45 PM AEDT Christoph Hellwig wrote: > > +Not all devices support atomic access to system memory. To support atomic > > +operations to a shared virtual memory page such a device needs access to that > > +page which is exclusive of any userspace access from the CPU.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE

2021-03-22 Thread Matthew Auld
On Sat, 20 Mar 2021 at 14:48, Jason Ekstrand wrote: > > On Fri, Mar 19, 2021 at 5:39 PM Jason Ekstrand wrote: > > > > This reverts commit 88be76cdafc7e60e2e4ed883bfe7e8dd7f35fa3a. This API > > has never been used by any real userspace. > > After further digging, there is a compute-runtime PR

[PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann Building with 'make W=1' shows a few harmless warnings: drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]

[PATCH 2/2] vgaarb: avoid -Wempty-body warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann Building with W=1 shows a few warnings for an empty macro: drivers/gpu/drm/qxl/qxl_drv.c: In function 'qxl_pci_probe': drivers/gpu/drm/qxl/qxl_drv.c:131:50: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 131 |

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-22 Thread Lee Jones
On Fri, 19 Mar 2021, Daniel Vetter wrote: > On Fri, Mar 19, 2021 at 08:24:07AM +, Lee Jones wrote: > > On Thu, 18 Mar 2021, Daniel Vetter wrote: > > > > > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > > > > > > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > > > > > >

Re: [PATCH] drm/imx/dcss: Use device_get_match_data()

2021-03-22 Thread Laurentiu Palcu
Hi Fabio, On Mon, Mar 15, 2021 at 09:38:11AM -0300, Fabio Estevam wrote: > The retrieval of driver data can be a bit simplified by using > device_get_match_data(), so switch to it. > > Signed-off-by: Fabio Estevam Reviewed-by: Laurentiu Palcu > --- > drivers/gpu/drm/imx/dcss/dcss-dev.c | 9

Re: [PATCH v6 1/8] mm: Remove special swap entry functions

2021-03-22 Thread Alistair Popple
On Monday, 15 March 2021 6:27:57 PM AEDT Christoph Hellwig wrote: > On Fri, Mar 12, 2021 at 07:38:44PM +1100, Alistair Popple wrote: > > Remove the migration and device private entry_to_page() and > > entry_to_pfn() inline functions and instead open code them directly. > > This results in shorter

Re: [PATCH v6 2/5] drm/bridge: anx7625: fix not correct return value

2021-03-22 Thread Robert Foss
Hey Xin, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:33, Xin Ji wrote: > > At some time, the original code may return non zero value, force return 0 > if operation finished. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 4

[Bug 206475] amdgpu under load drop signal to monitor until hard reset

2021-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206475 Marco (rodomar...@protonmail.com) changed: What|Removed |Added Status|REOPENED|RESOLVED

[PATCH v3 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-03-22 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../bindings/display/ilitek,ili9163.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.yaml

[PATCH v3 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-03-22 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224

Re: [PATCH] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-22 Thread Dmitry Baryshkov
On Fri, 19 Mar 2021 at 19:25, Fabio Estevam wrote: > > On Fri, Mar 19, 2021 at 12:13 PM Fabio Estevam wrote: > > > Thanks for the feedback. > > I will follow the same approach for fixing the suspend/resume path then. > > > > Let me test it and then I will re-submit Dmitry's patch and the one > >

[PATCH v5 1/2] dt-bindings: display: bridge: Add Chipone ICN6211 bindings

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produces RGB565, RGB666, RGB888 output format. Add dt-bingings for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss Reviewed-by: Rob Herring --- Changes for v5: -

[PATCH v5 2/2] drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB bridge

2021-03-22 Thread Jagan Teki
ICN6211 is MIPI-DSI to RGB Converter bridge from Chipone. It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format. Add bridge driver for it. Signed-off-by: Jagan Teki Reviewed-by: Robert Foss --- Changes for v5: - rebase drm-misc-next -

  1   2   3   >