RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread David Laight
From: Xiaomeng Tong > Sent: 03 March 2022 07:27 > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's container_of pointer

Re: [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning

2022-03-03 Thread Helge Deller
On 3/2/22 04:44, Yihao Han wrote: > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Signed-off-by: Yihao Han applied to the fbdev for-next git tree. Thanks! Helge >

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 09:35 schrieb Neil Armstrong : > > Hi, > > On 02/03/2022 23:24, H. Nikolaus Schaller wrote: >> Hi Neil, >>> Am 02.03.2022 um 15:34 schrieb Neil Armstrong : >>> >>> Hi, >>> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) >>> >>> I

Re: [PATCH v5 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case:

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread Neil Armstrong
On 03/03/2022 11:40, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 09:35 schrieb Neil Armstrong : Hi, On 02/03/2022 23:24, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 15:34 schrieb Neil Armstrong : Hi, (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #4 from Erhard F. (erhar...@mailbox.org) --- No I don't use an initrd. The kernel to boot the Talos is on a boot partition, modules are loaded from root partition. Which worked in 5.16 and before. Now I am getting this "could not

Re: [Kgdb-bugreport] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Daniel Thompson
On Thu, Mar 03, 2022 at 03:26:57PM +0800, Xiaomeng Tong wrote: > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's

Re: [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case:

[GIT PULL FOR v5.18] R-Car DU misc improvements

2022-03-03 Thread Laurent Pinchart
/du-next-20220303 for you to fetch changes up to 8ba3c7bd4dca7ac358e834eabf840012d9564356: drm: rcar-du: Don't restart group when enabling plane on Gen3 (2022-03-03 14:06:04 +0200) - R-Car LVDS support for M3-W+ (R8A77961) SoC - R

[PULL] drm-intel-fixes

2022-03-03 Thread Tvrtko Ursulin
Hi Dave, Daniel, Two small fixes for -rc7. GuC SLPC is for future platform work and other one is fixing misidentification of Ice Lake MacBook Pro's. Regards, Tvrtko drm-intel-fixes-2022-03-03: - Fix GuC SLPC unset command. (Vinay Belgaumkar) - Fix misidentification of some Apple MacBook

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Matthew Auld
On Tue, 22 Feb 2022 at 13:32, wrote: > > From: Xiaoke Wang > > kstrdup() is a memory allocation function which can return NULL when > some internaly memory errors happen. It is better to check the return > value of it to prevent further wrong memory access. > > Signed-off-by: Xiaoke Wang

Re: [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: From: Sujaritha Sundaresan This patch adds the following new sysfs frequency attributes; - punit_req_freq_mhz - throttle_reason_status - throttle_reason_pl1 - throttle_reason_pl2 - throttle_reason_pl4 -

[PATCH v2] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-03 Thread Vinod Polimera
- Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and in the scaler possibilities. Changes in

Re: [PATCH 1/2] drm: rcar-du: Don't select VSP1 sink on Gen3

2022-03-03 Thread Kieran Bingham
Quoting Laurent Pinchart (2022-02-21 17:13:39) > The VSP1 sink selection through register DEFR8 is only available on Gen2 > hardware. Skip it on Gen3. aha, interesting, and I see how this leads into the second patch. Looks fine on it's own too though: Reviewed-by: Kieran Bingham > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Xiaoke Wang
Matthew Auld wrote: > Scratch that. it looks like the for() already accounts for this, as > pointed out by Chris. Yes, you are right. I rechecked and found this one is indeed an ordinary code smell. Thank you for taking the time. Xiaoke Wang

Re: [PATCH] video: fbdev: sm712fb: Fix crash in smtcfb_write()

2022-03-03 Thread Helge Deller
On 3/3/22 02:34, Zheyu Ma wrote: > Hi, > > On Thu, Mar 3, 2022 at 12:49 AM Helge Deller wrote: >> >> On 3/2/22 15:33, Zheyu Ma wrote: >>> When the sm712fb driver writes three bytes to the framebuffer, the >>> driver will crash: >>> >>> BUG: unable to handle page fault for address:

Re: Mandatory Test Suite for KMS Drivers?

2022-03-03 Thread Rodrigo Vivi
On Thu, Mar 03, 2022 at 10:05:07AM +0100, Maxime Ripard wrote: > Hi, > > Back at XDC we floated the idea of creating a test suite for IGT that we > expect any KMS driver to pass, similar to what v4l2-compliance and > cec-compliance provide for v4l2 and CEC respectively. > > I was looking at the

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Matthew Auld
On Thu, 3 Mar 2022 at 10:53, Matthew Auld wrote: > > On Tue, 22 Feb 2022 at 13:32, wrote: > > > > From: Xiaoke Wang > > > > kstrdup() is a memory allocation function which can return NULL when > > some internaly memory errors happen. It is better to check the return > > value of it to prevent

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:42 schrieb Neil Armstrong : > >> So how can we get that merged? IMHO your proposal should be before we add >> ingenic-dw-hdmi. >> If you have a version with proper commit message I can add it to the >> beginning of my >> seried and include it in a v17. Or if you

Re: [PATCH v9] drm/amdgpu: add drm buddy support to amdgpu

2022-03-03 Thread Christian König
Am 01.03.22 um 21:38 schrieb Arunpravin: - Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function -

[PATCH] drm: Drop commas after SoC match table sentinels

2022-03-03 Thread Geert Uytterhoeven
It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 18/24] dma-buf: add enum dma_resv_usage v3

2022-03-03 Thread Christian König
Am 02.03.22 um 18:55 schrieb Jason Ekstrand: On Wed, Dec 22, 2021 at 4:00 PM Daniel Vetter wrote: On Tue, Dec 07, 2021 at 01:34:05PM +0100, Christian König wrote: > This change adds the dma_resv_usage enum and allows us to specify why a > dma_resv object is queried for its

Re: [PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

2022-03-03 Thread Hellstrom, Thomas
On Wed, 2022-03-02 at 10:37 +, Tvrtko Ursulin wrote: > > + Thomas, Matt > > On 02/03/2022 06:19, Jiasheng Jiang wrote: > > As the potential failure of the i915_gem_object_trylock(), > > it should be better to check it and return error if fails. > > > > Fixes: 94ce0d65076c ("drm/i915/gt:

Re: [PATCH 3/5] drm/i915/dsi: Add some debug logging to mipi_exec_i2c

2022-03-03 Thread Jani Nikula
On Fri, 25 Feb 2022, Hans de Goede wrote: > Add some debug logging to mipi_exec_i2c, to make debugging various > issues seen with it easier. > > Signed-off-by: Hans de Goede > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-03 Thread Maxime Ripard
On Wed, Mar 02, 2022 at 04:17:04PM +0100, Marek Vasut wrote: > On 3/2/22 11:01, Maxime Ripard wrote: > > On Thu, Feb 17, 2022 at 01:25:22AM +0100, Marek Vasut wrote: > > > The driver currently hard-codes DSI lane count to two, however the chip > > > is capable of operating in 1..4 DSI lanes mode.

Re: [PATCH 20/24] dma-buf: add DMA_RESV_USAGE_KERNEL

2022-03-03 Thread Christian König
Am 02.03.22 um 19:11 schrieb Jason Ekstrand: On Wed, Dec 22, 2021 at 4:05 PM Daniel Vetter wrote: On Tue, Dec 07, 2021 at 01:34:07PM +0100, Christian König wrote: > Add an usage for kernel submissions. Waiting for those > are mandatory for dynamic DMA-bufs. > >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > This won't help the current issue (because it doesn't exist and might > never), but just in case some compiler people are listening, I'd like to > have some sort of way to tell the compiler "treat this variable as > uninitialized

Re: [PATCH 2/2] drm: rcar-du: Don't restart group when enabling plane on Gen3

2022-03-03 Thread Kieran Bingham
Quoting Laurent Pinchart (2022-02-21 17:13:40) > On Gen3 hardware enabling a VSP plane doesn't change any register that > requires DRES to take effect. Avoid a group restart in that case. This also makes it clear that the need_restart is due to the change occuring in the VSP1 sink, so I think

[PATCH] drm/ingenic: Use resource_size function on resource object

2022-03-03 Thread Jiapeng Chong
Clean up the following coccicheck warning: ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1110:35-38: WARNING: Suspicious code. resource_size is maybe missing with res. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- 1 file changed, 1

Re: [PATCH v2 4/4] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-03 Thread Hellstrom, Thomas
On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > When we are swapping out the local memory obj on flat-ccs capable > platform, > we need to capture the ccs data too along with main meory and we need > to > restore it when we are swapping in the content. > > When lmem object is swapped

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread Neil Armstrong
Hi, On 02/03/2022 23:24, H. Nikolaus Schaller wrote: Hi Neil, Am 02.03.2022 um 15:34 schrieb Neil Armstrong : Hi, (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) I don't understand what's wrong, can you try to make the logic select MEDIA_BUS_FMT_YUV8_1X24

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Liu Ying
On Thu, 2022-03-03 at 09:19 +0100, Lucas Stach wrote: > Am Donnerstag, dem 03.03.2022 um 10:54 +0800 schrieb Liu Ying: > > On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > > > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach

Re: [PATCH 3/3] dt-bindings: display: bridge: renesas, lvds: Document r8a77961 bindings

2022-03-03 Thread Laurent Pinchart
On Wed, Mar 02, 2022 at 06:00:08PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 29, 2021 at 5:47 PM Laurent Pinchart wrote: > > On Fri, Dec 24, 2021 at 08:23:09AM +0300, Nikita Yushchenko wrote: > > > Document the R-Car M3-W+ (R8A77961) SoC in the R-Car LVDS encoder > > > bindings. > > > > > >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-03 Thread Tvrtko Ursulin
On 02/03/2022 18:22, John Harrison wrote: On 3/2/2022 01:49, Tvrtko Ursulin wrote: On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point

[PULL] drm-misc-fixes

2022-03-03 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the drm-misc-fixes PR for this week. Best regards Thomas drm-misc-fixes-2022-03-03: * drm/arm: Select DRM_GEM_CMEA_HELPER for HDLCD * drm/bridge: ti-sn65dsi86: Properly undo autosuspend * drm/vrr: Fix potential NULL-pointer deref The following changes since commit

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Lucas Stach
Am Donnerstag, dem 03.03.2022 um 10:54 +0800 schrieb Liu Ying: > On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100

Re: [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates

2022-03-03 Thread Dmitry Baryshkov
On Thu, 3 Mar 2022 at 11:08, Vinod Polimera wrote: > > *** BLURB HERE *** Description, dependencies, etc? > > Vinod Polimera (3): > arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk > arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk >

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-03 Thread Byungchul Park
On Thu, Mar 03, 2022 at 08:03:21AM +, Hyeonggon Yoo wrote: > On Thu, Mar 03, 2022 at 09:18:13AM +0900, Byungchul Park wrote: > > Hi Hyeonggon, > > > > Dept also allows the following scenario when an user guarantees that > > each lock instance is different from another at a different depth: >

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-03 Thread Tvrtko Ursulin
On 02/03/2022 17:55, John Harrison wrote: I was assuming 2.5s tP is enough and basing all calculation on that. Heartbeat or timeslicing regardless. I thought we established neither of us knows how long is enough. Are you now saying 2.5s is definitely not enough? How is that usable for a

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Jan Kara
On Thu 03-03-22 10:00:33, Byungchul Park wrote: > On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote: > > On Mon 28-02-22 18:28:26, Byungchul Park wrote: > > > case 1. Code with an actual circular dependency, but not deadlock. > > > > > >A circular dependency can be broken by a rescue

[PATCH] drm: Remove redundant code

2022-03-03 Thread Jiapeng Chong
Clean up the following smatch warning: drivers/gpu/drm/radeon/atom.c:400 atom_skip_src_int() warn: ignoring unreachable code. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/radeon/atom.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Lucas Stach
Am Donnerstag, dem 03.03.2022 um 04:14 +0100 schrieb Marek Vasut: > On 3/2/22 10:23, Lucas Stach wrote: > > [...] > > > > > > I tend to agree with Marek on this one. We have an instance where the > > > > > blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, > > > > > but

Mandatory Test Suite for KMS Drivers?

2022-03-03 Thread Maxime Ripard
Hi, Back at XDC we floated the idea of creating a test suite for IGT that we expect any KMS driver to pass, similar to what v4l2-compliance and cec-compliance provide for v4l2 and CEC respectively. I was looking at the list of tests, and it's fairly massive, so it's not clear to me what tests we

Re: [Intel-gfx] [PATCH 06/15] drm/i915: enforce min GTT alignment for discrete cards

2022-03-03 Thread Jani Nikula
On Sat, 19 Feb 2022, Ramalingam C wrote: > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h > b/drivers/gpu/drm/i915/gt/intel_gtt.h > index 8073438b67c8..6cd518a3277c 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gtt.h > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.h > @@ -29,6 +29,8 @@ > #include

Re: [PATCH][next] drm: ssd130x: remove redundant initialization of pointer mode

2022-03-03 Thread Javier Martinez Canillas
On 3/2/22 19:29, Javier Martinez Canillas wrote: > Hello Colin, > > Thanks for the patch. > > On Wed, Mar 2, 2022 at 6:53 PM Colin Ian King wrote: >> >> Pointer mode is being assigned a value that is never read, it is >> being re-assigned later with a new value. The initialization is >>

[PULL] drm-misc-next

2022-03-03 Thread Maarten Lankhorst
drm-misc-next-2022-03-03: drm-misc-next for v5.18: UAPI Changes: Cross-subsystem Changes: - Improve performance of some fbdev ops, in some cases up to 6x faster. Core Changes: - Some small DP fixes. - Find panels in subnodes of OF devices, and add of_get_drm_panel_display_mode to retrieve

[PATCH v4 3/4] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: 08c2a076d1("arm64: dts: qcom: sdm845:

[PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate

[PATCH v4 2/4] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: a3db7ad1af("arm64: dts: qcom: sc7180:

[PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: 7c1dffd471("arm64: dts: qcom:

[PATCH v4 0/4] Update mdp clk to max supported value to support higher refresh rates

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > The problem is the mis-use of iterator outside the loop on exit, and > > the iterator will be the HEAD's container_of pointer which pointers > > to a type-confused struct. Sidenote: The

Re: [PATCH v3 00/21] DEPT(Dependency Tracker)

2022-03-03 Thread Hyeonggon Yoo
On Thu, Mar 03, 2022 at 09:18:13AM +0900, Byungchul Park wrote: > On Wed, Mar 02, 2022 at 04:53:41AM +, Hyeonggon Yoo wrote: > > On Wed, Mar 02, 2022 at 04:36:38AM +, Hyeonggon Yoo wrote: > > > On Mon, Feb 28, 2022 at 06:56:39PM +0900, Byungchul Park wrote: > > > > I didn't want to bother

Re: [PATCH 04/24] dma-buf: add dma_resv_get_singleton v2

2022-03-03 Thread Jason Ekstrand
On Mon, Jan 17, 2022 at 5:26 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 14.01.22 um 17:31 schrieb Daniel Vetter: > > On Mon, Jan 03, 2022 at 12:13:41PM +0100, Christian König wrote: > >> Am 22.12.21 um 22:21 schrieb Daniel Vetter: > >>> On Tue, Dec 07, 2021 at 01:33:51PM

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
> I think this would make sense, it would mean you only assign the containing > element on valid elements. > > I was thinking something along the lines of: > > #define list_for_each_entry(pos, head, member) > \ > for (struct list_head *list =

Re: [PATCH 18/24] dma-buf: add enum dma_resv_usage v3

2022-03-03 Thread Jason Ekstrand
On Wed, Dec 22, 2021 at 4:00 PM Daniel Vetter wrote: > On Tue, Dec 07, 2021 at 01:34:05PM +0100, Christian König wrote: > > This change adds the dma_resv_usage enum and allows us to specify why a > > dma_resv object is queried for its containing fences. > > > > Additional to that a

RE: [PATCH v2 2/2] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table

2022-03-03 Thread Vinod Polimera
> -Original Message- > From: Stephen Boyd > Sent: Friday, February 25, 2022 11:43 PM > To: quic_vpolimer ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > freedr...@lists.freedesktop.org; linux-arm-...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org;

Re: [PATCH 20/24] dma-buf: add DMA_RESV_USAGE_KERNEL

2022-03-03 Thread Jason Ekstrand
On Wed, Dec 22, 2021 at 4:05 PM Daniel Vetter wrote: > On Tue, Dec 07, 2021 at 01:34:07PM +0100, Christian König wrote: > > Add an usage for kernel submissions. Waiting for those > > are mandatory for dynamic DMA-bufs. > > > > Signed-off-by: Christian König > > Again just skipping to the doc

[PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

2022-03-03 Thread Aashish Sharma
Fix this kernel test robot error: drivers/gpu/drm/drm_nomodeset.c:8:6: error: no previous prototype for 'drm_firmware_drivers_only' Including drm_drv.h in drm_nomodeset.c which contains drm_firmware_drivers_only's declaration. Signed-off-by: Aashish Sharma --- drivers/gpu/drm/drm_nomodeset.c

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Mon, 28 Feb 2022 16:41:04 -0800, Linus Torvalds wrote: > > But basically to _me_, the important part is that the end result is > maintainable longer-term. I couldn't agree more. And because of that, I stick with the following approach because it's maintainable longer-term than "type(pos) pos"

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Wed, 2 Mar 2022 14:04:06 +, David Laight wrote: > I think that it would be better to make any alternate loop macro > just set the variable to NULL on the loop exit. > That is easier to code for and the compiler might be persuaded to > not redo the test. No, that would lead to a NULL

RE: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Robby Cai
>-Original Message- >From: Marek Vasut >Sent: 2022年3月2日 10:50 >To: Robby Cai ; Lucas Stach ; >Adam Ford >Cc: Ying Liu (OSS) ; dri-devel >; devicetree ; >Peng Fan ; Alexander Stein >; Rob Herring ; >Laurent Pinchart ; Sam Ravnborg > >Subject: Re: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb:

Re: [PATCH v1 07/10] drm/msm/adreno: Retry on gpu resume failure

2022-03-03 Thread AngeloGioacchino Del Regno
Il 02/03/22 18:27, Akhil P Oommen ha scritto: Retry infinitely on resume failure because there is nothing much we can do if GPU is not ON. Also, this helps us to avoid checking for the return value of pm_runtime_get() to see if GPU is ON. Signed-off-by: Akhil P Oommen ---

[PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT

2022-03-03 Thread Matthew Auld
Currently this will enforce both 2M alignment and padding for any LMEM pages inserted into the GGTT. However, this was only meant to be applied to the compact-pt layout with the ppGTT. For the GGTT we can reduce the alignment and padding to 64K. Bspec: 45015 Fixes: 87bd701ee268 ("drm/i915:

[PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates

2022-03-03 Thread Vinod Polimera
*** BLURB HERE *** Vinod Polimera (3): arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH v3 1/3] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate

[PATCH v3 2/3] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: a3db7ad1af("arm64: dts: qcom: sc7180:

[PATCH v3 3/3] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Fixes: 08c2a076d1("arm64: dts: qcom: sdm845:

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 12:07:04PM -0800, Kees Cook wrote: > On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > > This won't help the current issue (because it doesn't exist and might > > never), but just in case some compiler people are listening, I'd like to > > have some sort

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread Paul Cercueil
Hi Neil, Any feedback on the other patches? They look fine to me, but I still need an ack to merge them in drm-misc-next. Cheers, -Paul Le jeu., mars 3 2022 at 12:42:02 +0100, Neil Armstrong a écrit : On 03/03/2022 11:40, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 09:35

Aw: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-03 Thread Frank Wunderlich
Tested this Series on my rk3568 Bananapi R2 Pro v00 Tested-by: Frank Wunderlich regards Frank

Re: [PATCH v3 RESEND 21/24] drm/exynos/decon5433: add local path support

2022-03-03 Thread Krzysztof Kozlowski
On 03/03/2022 17:11, Marek Szyprowski wrote: > Hi Krzysztof, > > On 03.03.2022 17:03, Krzysztof Kozlowski wrote: >> On 02/03/2022 02:00, Inki Dae wrote: >>> 22. 2. 7. 01:51에 Krzysztof Kozlowski 이(가) 쓴 글: On 25/03/2019 08:13, Andrzej Hajda wrote: > GSCALERs in Exynos5433 have local path

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread Paul Cercueil
Hi Nikolaus, [snip] Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do have access to the main drm_device in the ingenic_drm_bind() function, so you can add it there (with a cleanup function calling drm_kms_helper_poll_fini() registered with drmm_add_action_or_reset()).

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-03 Thread Theodore Ts'o
On Thu, Mar 03, 2022 at 02:23:33PM +0900, Byungchul Park wrote: > I totally agree with you. *They aren't really locks but it's just waits > and wakeups.* That's exactly why I decided to develop Dept. Dept is not > interested in locks unlike Lockdep, but fouces on waits and wakeup > sources itself.

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 12:42 schrieb Neil Armstrong : >> >>> So how can we get that merged? IMHO your proposal should be before we add >>> ingenic-dw-hdmi. >>> If you have a version with proper commit message I can

[PATCH] i2c: at91: use dma safe buffers

2022-03-03 Thread Michael Walle
The supplied buffer might be on the stack and we get the following error message: [3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if necessary. Cc: sta...@vger.kernel.org Signed-off-by: Michael Walle

Re: [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:23 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >> so that specialization drivers like ingenic-dw-hdmi can enable polling. >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9

[PATCH v6 6/6] drm: exynos: dsi: Switch to atomic funcs

2022-03-03 Thread Jagan Teki
The new support drm bridges are moving towards atomic functions. Replace atomic version of functions to continue the transition to the atomic API. Signed-off-by: Jagan Teki --- Changes for v6, v5, v4, v3: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 25 - 1 file

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul, > Am 03.03.2022 um 17:51 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., mars 3 2022 at 17:43:05 +0100, H. Nikolaus Schaller > a écrit : >> Hi Neil, >>> Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : >>> Hi Neil, Am 03.03.2022 um 17:23 schrieb Neil Armstrong :

[PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c

2022-03-03 Thread Gustavo A. R. Silva
Fix the following Wstringop-overflow warnings when building with GCC-11: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Remove the vm open count

2022-03-03 Thread Matthew Auld
On Wed, 2 Mar 2022 at 10:22, Thomas Hellström wrote: > > vms are not getting properly closed. Rather than fixing that, > Remove the vm open count and instead rely on the vm refcount. > > The vm open count existed solely to break the strong references the > vmas had on the vms. Now instead make

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread Neil Armstrong
Hi, On 03/03/2022 16:37, H. Nikolaus Schaller wrote: Hi Neil, Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : Hi Neil, Am 03.03.2022 um 12:42 schrieb Neil Armstrong : So how can we get that merged? IMHO your proposal should be before we add ingenic-dw-hdmi. If you have a version

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-03 Thread Abhinav Kumar
On 3/2/2022 10:31 AM, Laurent Pinchart wrote: Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: On 2/28/2022 5:42 AM, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula

[PATCH v2 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. v2: check if the source and destination memory address is from local memory or system memory and initialize the iosys_map

[PATCH v6 3/6] exynos: drm: dsi: Attach in_bridge in MIC driver

2022-03-03 Thread Jagan Teki
MIC drivers in the Exynos5433 display pipeline are already registered as bridge drivers and it is more advisable to attach the downstream bridge on the bridge attach call instead of doing the same in the DSI driver. This makes bridge attachment more meaningful and avoids the races during bridge

[PATCH v6 4/6] drm: exynos: dsi: Use drm panel_bridge API

2022-03-03 Thread Jagan Teki
Replace the manual panel handling code by a drm panel_bridge via devm_drm_of_get_bridge(). Adding panel_bridge handling, - Drops drm_connector and related operations as drm_bridge_attach creates connector during attachment. - Drops panel pointer and iterate the bridge, so-that it can operate

[PATCH v6 1/6] drm: bridge: tc358764: Use drm panel_bridge API

2022-03-03 Thread Jagan Teki
Replace the manual panel handling code by a drm panel_bridge via devm_drm_of_get_bridge(). Adding panel_bridge handling, - Drops drm_connector and related operations as drm_bridge_attach creates connector during attachment. - Drops panel pointer and panel healpers. This simplifies the driver

[PATCH v6 5/6] drm: exynos: dsi: Convert to bridge driver

2022-03-03 Thread Jagan Teki
Convert the encoders to bridge drivers in order to standardize on a single API with built-in dumb encoder support for compatibility with existing component drivers. Driver bridge conversion will help to reuse the same bridge on different platforms as exynos dsi driver can be used as a Samsung

[PATCH v6 2/6] drm: bridge: panel: Reset the connector state pointer

2022-03-03 Thread Jagan Teki
Trigger hotplug event with drm_kms_helper_hotplug_event might fail if the connector state pointer is NULL. BUG observed in exynos dsi driver where drm_bridge_attach is trying to register a connector in panel_bridge before the hotplug event is triggered, WARNING: CPU: 1 PID: 1 at

[PATCH v2 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-03-03 Thread Balasubramani Vivekanandan
drm_memcpy_from_wc() performs fast copy from WC memory type using non-temporal instructions. Now there are two similar implementations of this function. One exists in drm_cache.c as drm_memcpy_from_wc() and another implementation in i915/i915_memcpy.c as i915_memcpy_from_wc(). drm_memcpy_from_wc()

[PATCH v2 7/7] drm/i915: Avoid dereferencing io mapped memory

2022-03-03 Thread Balasubramani Vivekanandan
Pointer passed to zlib_deflate() for compression could point to io mapped memory and might end up in direct derefencing. io mapped memory is copied to a temporary buffer, which is then shared to zlib_deflate(), only for the case where platform supports fast copy using non-temporal instructions. If

[PATCH v2 1/7] drm: Relax alignment constraint for destination address

2022-03-03 Thread Balasubramani Vivekanandan
There is no need for the destination address to be aligned to 16 byte boundary to be able to use the non-temporal instructions while copying. Non-temporal instructions are used only for loading from the source address which has alignment constraints. We only need to take care of using the right

[PATCH v2 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-03-03 Thread Balasubramani Vivekanandan
Fast copy using non-temporal instructions for x86 currently exists at two locations. One is implemented in i915 driver at i915/i915_memcpy.c and another copy at drm_cache.c. The plan is to remove the duplicate implementation in i915 driver and use the functions from drm_cache.c. A variant of

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #5 from Erhard F. (erhar...@mailbox.org) --- Ok, changed my config to include the firmware via CONFIG_EXTRA_FIRMWARE="radeon/R520_cp.bin" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" With CONFIG_DRM_RADEON=y the machine boots now as

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 17:23 schrieb Neil Armstrong : >> >> Hi, >> >> On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >>> so that specialization drivers like ingenic-dw-hdmi can enable polling. >>> Signed-off-by: H.

[PATCH drm-misc-next 1/2] drm/simple-kms: Drop format_mod_supported function

2022-03-03 Thread José Expósito
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c

[PATCH drm-misc-next 0/2] Use default drm_plane_funcs.format_mod_supported

2022-03-03 Thread José Expósito
Hi everyone, This series is a follow up to [1]. Some of the patches were merged in "drm-misc-next", however a couple of them, included in this series, are pending. I rebased the pending patches on top of "drm-misc-next" and added the reviewed by tags. Thanks, José Expósito [1]

Re: [PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c

2022-03-03 Thread Kees Cook
On Thu, Mar 03, 2022 at 11:25:03AM -0600, Gustavo A. R. Silva wrote: > Fix the following Wstringop-overflow warnings when building with GCC-11: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: > ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 >

[PATCH v2 6/7] drm/i915/gt: Avoid direct dereferencing of io memory

2022-03-03 Thread Balasubramani Vivekanandan
io mapped memory should not be directly dereferenced to ensure portability. io memory should be read/written/copied using helper functions. i915_memcpy_from_wc() function was used to copy the data from io memory to a temporary buffer and pointer to the temporary buffer was passed to CRC

Re: [PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c

2022-03-03 Thread Gustavo A. R. Silva
On Thu, Mar 03, 2022 at 09:43:28AM -0800, Kees Cook wrote: > On Thu, Mar 03, 2022 at 11:25:03AM -0600, Gustavo A. R. Silva wrote: > > Fix the following Wstringop-overflow warnings when building with GCC-11: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: > > warning:

  1   2   3   >