Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-13 Thread Dmitry Osipenko
On 4/13/22 01:59, Erico Nunes wrote: > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > wrote: >> >> >> On 2022-04-12 14:20, Dmitry Osipenko wrote: >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like

Re: [PATCH v18 03/10] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-04-13 Thread Dan Carpenter
Hi "jason-jh.lin", url: https://github.com/intel-lab-lkp/linux/commits/jason-jh-lin/Add-Mediatek-Soc-DRM-vdosys0-support-for-mt8195/20220412-183359 base: git://anongit.freedesktop.org/drm/drm drm-next config: arc-randconfig-m031-20220411 (https://download.01.org/0day-ci/archiv

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > This patch allows LVDS PHYs to be configured through > the generic functions and through a custom structure > added to the generic union. > > The parameters added here are based on common LVDS PHY > implementation practices. The set of parameters > should

Re: [PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports > either a MIPI DSI display or a LVDS display. The PHY mode is controlled > by SCU firmware and the driver would call a SCU firmware function to > configure the PHY mode. The single LVDS

Re: [PATCH] gpu/host1x: remove useless if(ptr) check to kfree

2022-04-13 Thread Mikko Perttunen
On 4/13/22 09:39, Bernard Zhao wrote: This patch remove useless if(ptr) check to kfree. Signed-off-by: Bernard Zhao --- drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c index

[PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
I messed up the delayed takover path in the locking conversion in 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). Fix it by re-extracting the lockless function and using it in the delayed takeover path, where we need to hold the lock already to iterate over the list of

[PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Matthew Auld
It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689 Fixes: 8bb31587820a ("drm/ttm: remove bo->moving") Cc: Christian König Cc: Daniel Vetter

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-13 Thread Simon Ser
On Wednesday, April 13th, 2022 at 10:32, Daniel Vetter wrote: > Inflicting hotplug complications on all userspace (including uevent > handling for this hotpluggable backlight and everything) just because > fixing the old crap systems is work is imo really not a good idea. Much > better if we get

Re: [PATCH v2] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Christian König
Am 13.04.22 um 10:51 schrieb Matthew Auld: It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. v2(Daniel): - Simplify the function tail Closes:

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 4/13/22 10:21, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Maybe a

[PATCH] gpu/host1x: remove useless if(ptr) check to kfree

2022-04-13 Thread Bernard Zhao
This patch remove useless if(ptr) check to kfree. Signed-off-by: Bernard Zhao --- drivers/gpu/host1x/fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c index ecab72882192..05b36bfc8b74 100644 ---

[PATCH] drm/tegra: remove useless if check before kfree

2022-04-13 Thread Bernard Zhao
This patch remove useless if check before kfree. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/submit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index 6d6dd8c35475..54ac31bc80f6 100644 ---

Re: [PATCH] drm/tegra: remove useless if check before kfree

2022-04-13 Thread Mikko Perttunen
On 4/13/22 09:46, Bernard Zhao wrote: This patch remove useless if check before kfree. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/submit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index

Re: [PATCH v3 14/17] fbcon: Move console_lock for register/unlink/unregister

2022-04-13 Thread Daniel Vetter
On Mon, Apr 11, 2022 at 03:27:47PM -0700, Nathan Chancellor wrote: > Hi Daniel, > > On Tue, Apr 05, 2022 at 11:03:32PM +0200, Daniel Vetter wrote: > > Ideally console_lock becomes an implementation detail of fbcon.c and > > doesn't show up anywhere in fbmem.c. We're still pretty far from that, >

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 09:21:33AM +0100, Matthew Auld wrote: > It looks like we still need to call dma_fence_put() on the man->move, > otherwise we just end up leaking it, leading to fireworks later. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689 > Fixes: 8bb31587820a

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 10:43:02AM +0200, Christian König wrote: > Am 13.04.22 um 10:21 schrieb Matthew Auld: > > It looks like we still need to call dma_fence_put() on the man->move, > > otherwise we just end up leaking it, leading to fireworks later. > > > > Closes: > >

[PATCH v2] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Matthew Auld
It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. v2(Daniel): - Simplify the function tail Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5689 Fixes: 8bb31587820a ("drm/ttm: remove bo->moving") Cc:

[PATCH] drm/ttm: fix kerneldoc for ttm_lru_bulk_move

2022-04-13 Thread Christian König
Update the kerneldoc for the members as well. Signed-off-by: Christian König Fixes: b0e2c9ea5afc ("drm/ttm: allow bulk moves for all domains") --- include/drm/ttm/ttm_resource.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_resource.h

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Javier Martinez Canillas
Hello Daniel, On 4/13/22 10:21, Daniel Vetter wrote: > I messed up the delayed takover path in the locking conversion in > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > Maybe a few more words of what the issue is ? Something like the following: If

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Christian König
Am 13.04.22 um 10:44 schrieb Daniel Vetter: On Wed, Apr 13, 2022 at 09:21:33AM +0100, Matthew Auld wrote: It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes:

Re: [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-13 Thread Jani Nikula
On Fri, 08 Apr 2022, "Wang, Zhi A" wrote: > Hi Jani: > > Thanks so much for the help. Can you generate a new tag on > drm-intel-next? I noticed that there was one patch moving the DMC > related registers into display/intel_dmc_regs.h, which is not included > in the latest tag on drm-intel-next.

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-04-13 Thread AngeloGioacchino Del Regno
Il 12/04/22 11:46, Guillaume Ranquet ha scritto: On Mon, 28 Mar 2022 11:14, AngeloGioacchino Del Regno wrote: Il 28/03/22 00:39, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-13 Thread AngeloGioacchino Del Regno
Il 13/04/22 09:03, allen-kh.cheng ha scritto: Hi Nicolas, On Tue, 2022-04-12 at 10:48 -0400, Nicolas Dufresne wrote: Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a écrit : Hi Nicolas, On Thu, 2022-03-31 at 16:48 -0400, Nicolas Dufresne wrote: Hi Yunfei, thanks for the

Re: [PATCH -next] drm/solomon: Make DRM_SSD130X depends on MMU

2022-04-13 Thread Daniel Vetter
On Mon, Apr 11, 2022 at 03:49:38PM +0200, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Mar 15, 2022 at 12:28 PM Javier Martinez Canillas > wrote: > > On 3/12/22 07:34, YueHaibing wrote: > > > WARNING: unmet direct dependencies detected for DRM_GEM_SHMEM_HELPER > > > Depends on [n]:

Re: [PATCH] drm/ttm: fixup ttm_bo_add_move_fence

2022-04-13 Thread Christian König
Am 13.04.22 um 10:21 schrieb Matthew Auld: It looks like we still need to call dma_fence_put() on the man->move, otherwise we just end up leaking it, leading to fireworks later. Closes:

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-13 Thread Hans de Goede
Hi, On 4/13/22 10:32, Daniel Vetter wrote: > On Fri, Apr 08, 2022 at 12:26:24PM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/8/22 12:16, Simon Ser wrote: >>> Would it be an option to only support the KMS prop for Good devices, >>> and continue using the suboptimal existing sysfs API for Bad

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-13 Thread Erico Nunes
On Wed, Apr 13, 2022 at 8:05 AM Dmitry Osipenko wrote: > > On 4/13/22 01:59, Erico Nunes wrote: > > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > > wrote: > >> > >> > >> On 2022-04-12 14:20, Dmitry Osipenko wrote: > >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: > On 2022-04-11 18:15,

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Paul Menzel
Dear Richard, Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using

Re: [PATCH v2] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-04-13 Thread Vinod Koul
On 28-03-22, 16:52, AngeloGioacchino Del Regno wrote: > Use the dev_err_probe() helper to simplify error handling during probe. Applied, thanks -- ~Vinod

Re: [PATCH] phy: mediatek: phy-mtk-hdmi: Simplify with dev_err_probe()

2022-04-13 Thread Vinod Koul
On 28-03-22, 13:10, AngeloGioacchino Del Regno wrote: > Use the dev_err_probe() helper to simplify error handling during probe. Applied, thanks -- ~Vinod

Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-13 Thread Geert Uytterhoeven
Hi Javier, On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas wrote: > The Solomon SSD130x OLED displays can either have an I2C or SPI interface, > add to the schema the properties and examples for OLED devices under SPI. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Mark Brown

Re: linux-next: build warning after merge of the drm-misc tree

2022-04-13 Thread Christian König
Am 13.04.22 um 10:23 schrieb Daniel Vetter: On Wed, Apr 13, 2022 at 10:04:48AM +1000, Stephen Rothwell wrote: Hi all, On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell wrote: After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning:

Re: [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-13 Thread Joonas Lahtinen
(+ Tvrtko and Jani) Quoting Ramalingam C (2022-04-02 06:02:38) > On 2022-04-01 at 16:31:19 +0200, Christian König wrote: > > I would be nicer to push this through drm-misc-next, but the intel branch > > works for me as well. > Hi Christian > > I have pushed this patch into drm-misc-next. I've

Re: [RFC] drm/kms: control display brightness through drm_connector properties

2022-04-13 Thread Daniel Vetter
On Fri, Apr 08, 2022 at 12:26:24PM +0200, Hans de Goede wrote: > Hi, > > On 4/8/22 12:16, Simon Ser wrote: > > Would it be an option to only support the KMS prop for Good devices, > > and continue using the suboptimal existing sysfs API for Bad devices? > > > > (I'm just throwing ideas around to

Re: [PATCH] drm/ttm: fix kerneldoc for ttm_lru_bulk_move

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 11:12:42AM +0200, Christian König wrote: > Update the kerneldoc for the members as well. > > Signed-off-by: Christian König > Fixes: b0e2c9ea5afc ("drm/ttm: allow bulk moves for all domains") Acked-by: Daniel Vetter > --- > include/drm/ttm/ttm_resource.h | 3 +-- > 1

[PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Thomas Zimmermann
Create a platform device for each OF-declared framebuffer and have offb bind to these devices. Allows for real hot-unplugging and other drivers besides offb. Originally, offb created framebuffer devices while initializing its module by parsing the OF device tree. No actual Linux device was set

[PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Thomas Zimmermann
A workaround makes fbdev hot-unplugging work for framebuffers without device. The only user for this feature was offb. As each OF framebuffer now has an associated platform device, the workaround is no longer needed. Remove it. Effectively reverts commit 0f525289ff0d ("fbdev: Fix unregistering of

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > I messed up the delayed takover path in the locking conversion in > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > Fix it by re-extracting the lockless function and using it in the > delayed takeover

[PATCH 0/2] of: Register platform device for each framebuffer

2022-04-13 Thread Thomas Zimmermann
Move the detection of OF framebuffers from fbdev into of platform code and register a Linux platform device for each framebuffer. Allows for DRM-based OF drivers and real hot-unplugging of the framebuffer. This patchset has been tested with qemu's ppc64le emulation, which provides a framebuffer

Re: [PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it

2022-04-13 Thread André Almeida
Hi Tales, Às 20:38 de 11/04/22, Tales Lelo da Aparecida escreveu: > Fix a copypasta error, which resulted in checking repeatedly if the > primary_composer->map[0] was null, instead of checking each > plane_composer while composing planes. > > Signed-off-by: Tales Lelo da Aparecida Reviewed-by:

Re: linux-next: build warning after merge of the drm-misc tree

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 10:04:48AM +1000, Stephen Rothwell wrote: > Hi all, > > On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell > wrote: > > > > After merging the drm-misc tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/drm/ttm/ttm_resource.h:226:

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 11:21, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> On 4/13/22 10:21, Daniel Vetter wrote: >>> I messed up the delayed takover path in the locking conversion in >>> 6e7da3af008b ("fbcon: Move console_lock for

Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-13 Thread Javier Martinez Canillas
Hello Geert, On 4/13/22 10:04, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas > wrote: >> The Solomon SSD130x OLED displays can either have an I2C or SPI interface, >> add to the schema the properties and examples for OLED devices under SPI.

Re: [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-13 Thread Wang, Zhi A
Hi Jani: Previously when I sent a pull request, it will be top of a tag in drm-intel-next. The following patches move the DMC related registers, which is used by GVT-g into intel_dmc_regs.h and it is not included in the latest tag. commit 9c67d9e84c7d4a3a2371a54ee2dddc4699002000 Author: Jani

commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread François Valenduc
Commit 15512021eb3975a8c2366e3883337e252bb0eee5 (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots to appears on the right upper corner of all console screens (see https://drive.google.com/file/d/13GabEvOIKSAj5yox6ybAZEDu3Ixncw5Q/view). git-bisect shows that this is the

Re: [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, "Wang, Zhi A" wrote: > Hi Jani: > > Previously when I sent a pull request, it will be top of a tag in > drm-intel-next. The following patches move the DMC related registers, which > is used by GVT-g into intel_dmc_regs.h and it is not included in the latest > tag. > >

Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-13 Thread Geert Uytterhoeven
Hi Javier, On Wed, Apr 13, 2022 at 11:44 AM Javier Martinez Canillas wrote: > On 4/13/22 10:04, Geert Uytterhoeven wrote: > > On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas > > wrote: > >> The Solomon SSD130x OLED displays can either have an I2C or SPI interface, > >> add to the

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Javier Martinez Canillas
Hello Thomas, Thanks for working on this. On 4/13/22 11:24, Thomas Zimmermann wrote: > Create a platform device for each OF-declared framebuffer and have > offb bind to these devices. Allows for real hot-unplugging and other > drivers besides offb. > > Originally, offb created framebuffer

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Thomas Zimmermann
Hi Am 13.04.22 um 12:45 schrieb Javier Martinez Canillas: Hello Thomas, Thanks for working on this. On 4/13/22 11:24, Thomas Zimmermann wrote: Create a platform device for each OF-declared framebuffer and have offb bind to these devices. Allows for real hot-unplugging and other drivers

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Vinod Koul
On 13-04-22, 18:04, Liu Ying wrote: > Hi Vinod, > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > > On 02-04-22, 13:24, Liu Ying wrote: > > > This patch allows LVDS PHYs to be configured through > > > the generic functions and through a custom structure > > > added to the generic union.

Re: [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Andy Shevchenko
On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote: > These are declared in the ssd130x-i2c transport driver but the information > is not I2C specific, and could be used by other SSD130x transport drivers. > > Move them to the ssd130x core driver and just set the OF device

Re: [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Javier Martinez Canillas
Hello Andy, On 4/13/22 12:46, Andy Shevchenko wrote: > On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote: >> These are declared in the ssd130x-i2c transport driver but the information >> is not I2C specific, and could be used by other SSD130x transport drivers. >> >> Move

[bug report] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2022-04-13 Thread Dan Carpenter
Hello Thomas Hellström, The patch 3bf3710e3718: "drm/ttm: Add a generic TTM memcpy move for page-based iomem" from Jun 2, 2021, leads to the following Smatch static checker warning: ./include/drm/ttm/ttm_bo_driver.h:259 ttm_bo_move_sync_cleanup() error: NULL dereference inside

Re: [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-13 Thread Ramalingam C
On 2022-04-13 at 11:28:28 +0300, Joonas Lahtinen wrote: > (+ Tvrtko and Jani) > > Quoting Ramalingam C (2022-04-02 06:02:38) > > On 2022-04-01 at 16:31:19 +0200, Christian König wrote: > > > I would be nicer to push this through drm-misc-next, but the intel branch > > > works for me as well. > >

Re: [PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Liu Ying
Hi Vinod, On Wed, 2022-04-13 at 11:51 +0530, Vinod Koul wrote: > On 02-04-22, 13:24, Liu Ying wrote: > > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which > > supports > > either a MIPI DSI display or a LVDS display. The PHY mode is > > controlled > > by SCU firmware and the driver

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-13 Thread Daniel Vetter
On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar wrote: > > Hi Daniel > > On 4/8/2022 9:04 PM, Abhinav Kumar wrote: > > > > > > On 4/7/2022 4:12 PM, Rob Clark wrote: > >> On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar > >> wrote: > >>> > >>> Hi Rob and Daniel > >>> > >>> On 4/7/2022 3:51 PM, Rob Clark

Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 07:57:17AM +0200, Christoph Hellwig wrote: > > - extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn, > > + extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long > > *user_pfn, > > int npage, int prot,

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote: > On 13-04-22, 18:04, Liu Ying wrote: > > Hi Vinod, > > > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > > > On 02-04-22, 13:24, Liu Ying wrote: > > > > This patch allows LVDS PHYs to be configured through > > > > the generic

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-13 Thread Steven Price
On 11/04/2022 23:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > mutex when job is released, and thus, that code can sleep. This results > into "BUG: scheduling while atomic" if locks are contented while job is > freed. There is no good reason

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
Hi Vinod, On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > On 02-04-22, 13:24, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the generic union. > > > > The parameters added here are based on

Re: [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 11:24, Thomas Zimmermann wrote: > A workaround makes fbdev hot-unplugging work for framebuffers without > device. The only user for this feature was offb. As each OF framebuffer > now has an associated platform device, the workaround is no longer > needed. Remove it. Effectively reverts

Re: [bug report] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2022-04-13 Thread Thomas Hellström
Hello Dan Carpenter. Thanks for the report. On 4/13/22 13:11, Dan Carpenter wrote: Hello Thomas Hellström, The patch 3bf3710e3718: "drm/ttm: Add a generic TTM memcpy move for page-based iomem" from Jun 2, 2021, leads to the following Smatch static checker warning:

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Jani Nikula
On Mon, 11 Apr 2022, Christoph Hellwig wrote: > On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: >> > Up to you but I usually sort these lists >> >> Yeah, please do. Otherwise matches what I sent, so ack. > > Let's just merge your 2 patch series ASAP and I'll rebase on top of > that.

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Rob Herring
On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann wrote: > > Create a platform device for each OF-declared framebuffer and have > offb bind to these devices. Allows for real hot-unplugging and other > drivers besides offb. > > Originally, offb created framebuffer devices while initializing its >

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Alex Deucher
On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: > > Dear Richard, > > > Thank you for sending out v4. > > Am 12.04.22 um 23:50 schrieb Richard Gong: > > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > > There are some AMD GFX cards (such as WX3200 and RX640) that

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 07:55:24AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:28PM -0300, Jason Gunthorpe wrote: > > All callers have a struct vfio_device trivially available, pass it in > > directly and avoid calling the expensive vfio_group_get_from_dev(). > > Instead of

RE: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Limonciello, Mario
[Public] > On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel > wrote: > > > > Dear Richard, > > > > > > Thank you for sending out v4. > > > > Am 12.04.22 um 23:50 schrieb Richard Gong: > > > Active State Power Management (ASPM) feature is enabled since kernel > 5.14. > > > There are some AMD GFX

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:33 PM, Jani Nikula wrote: > On Mon, 11 Apr 2022, Christoph Hellwig wrote: >> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: Up to you but I usually sort these lists >>> >>> Yeah, please do. Otherwise matches what I sent, so ack. >> >> Let's just merge your 2 patch

Re: [PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:01:10AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:31PM -0300, Jason Gunthorpe wrote: > > Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no > > reason to use a group interface here, kvmgt has easy access to a > > vfio_device.

Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:00:08AM +0200, Christoph Hellwig wrote: > This looks good execept the extern nitpick: > > Reviewed-by: Christoph Hellwig > > However I'd move this before the previous patch. More of the explanation > there. Yes, that looks good, done Thanks, Jason

[PATCH] dt-bindings: display: panel-timing: Define a single type for properties

2022-04-13 Thread Rob Herring
It's not good practice to define multiple types for the same property, so factor out the type reference making the properties always an uint32-array with a length of 1 or 3 items. Signed-off-by: Rob Herring --- .../bindings/display/panel/panel-timing.yaml | 42 --- 1 file

Re: [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote: > > + if (WARN_ON(!READ_ONCE(vdev->open_count))) > > + return -EINVAL; > > I think all the WARN_ON()s in this patch need to be WARN_ON_ONCE, >

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > >> It seems Jani's makefile clean patch has already included this one, I can >> just simply drop this one so that Christoph won't need to re-send everything. >> >> For the branch to move

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 02:26:23PM +, Wang, Zhi A wrote: > On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > > > >> It seems Jani's makefile clean patch has already included this one, I can > >> just simply drop this one so that

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > It seems Jani's makefile clean patch has already included this one, I can > just simply drop this one so that Christoph won't need to re-send everything. > > For the branch to move on, I am merging the patches and will re-generate

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
On 4/11/22 2:13 PM, Christoph Hellwig wrote: > Hi all, > > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-13 Thread Robert Foss
On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote: > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > Change bus-type define for DPI. > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > >

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 06:06:01PM +0200, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 08:39:52AM -0300, Jason Gunthorpe wrote: > > I already looked into that for a while, it is a real mess too because > > of how the notifiers are used by the current drivers, eg gvt assumes > > the notifier

[RFC] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-04-13 Thread Hans de Goede
Hi All, As discussed in the "[RFC] drm/kms: control display brightness through drm_connector properties" thread, step 1 of the plan is to stop registering multiple /sys/class/backlight devs for a single display. On x86 there can be multiple firmware + direct-hw-access methods for controlling the

[PATCH v4 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-13 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain both an "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver and also that are for devices that can be accessed over an I2C bus. But a DT is supposed to describe the hardware and not Linux implementation

[PATCH v4 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.

2022-04-13 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain an "fb" and "-i2c" suffixes. These have been deprecated and more correct ones were added, that don't encode a subsystem or bus used to interface the devices. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown

[PATCH v4 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-13 Thread Javier Martinez Canillas
The Solomon SSD130x OLED displays can either have an I2C or SPI interface, add to the schema the properties and examples for OLED devices under SPI. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown Reviewed-by: Geert Uytterhoeven --- Changes in v4: - Add a description for the

[PATCH v4 5/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-13 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over SPI. There is a difference in the communication protocol when using 4-wire SPI instead of I2C. For the latter, a control byte that contains a D/C# field

[PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Javier Martinez Canillas
These are declared in the ssd130x-i2c transport driver but the information is not I2C specific, and could be used by other SSD130x transport drivers. Move them to the ssd130x core driver and just set the OF device entries to an ID that could be used to lookup the correct device info from an

[PATCH v4 0/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-13 Thread Javier Martinez Canillas
Hello, This series adds a ssd130x-spi driver that provides a 4-wire SPI transport support for SSD130x OLED controllers that can be accessed over a SPI bus. The driver is quite similar to existing ssd130x-i2c driver that is used by I2C controllers, but there is a difference in the protocol used

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Nathan Chancellor
Hi Richard, On Tue, Apr 12, 2022 at 04:50:00PM -0500, Richard Gong wrote: > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD GFX cards (such as WX3200 and RX640) that won't work > with ASPM-enabled Intel Alder Lake based systems. Using these GFX

[PULL] drm-intel-next

2022-04-13 Thread Jani Nikula
Hi Dave & Daniel - The first drm/i915 pull for v5.19. BR, Jani. drm-intel-next-2022-04-13-1: drm/i915 feature pull for v5.19: Features and functionality: - Add support for new Tile 4 format on DG2 (Stan) - Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka) - Add

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote: >> > the GVT code in the i915 is a bit of a mess right now due to strange >> > abstractions and lots of indirect calls. This series refactors various >> > bits to clean that up. The main

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Nathan Chancellor
On Wed, Apr 13, 2022 at 11:25:02AM +0200, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Fix it by

Re: [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 12:50:50PM +0200, Javier Martinez Canillas wrote: > On 4/13/22 11:24, Thomas Zimmermann wrote: > > A workaround makes fbdev hot-unplugging work for framebuffers without > > device. The only user for this feature was offb. As each OF framebuffer > > now has an associated

[PATCH] drm/bochs: Explicitly include linux/module.h

2022-04-13 Thread Michel Dänzer
From: Michel Dänzer Instead of relying on it getting pulled in indirectly. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/tiny/bochs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index ed971c8bb446..4f8bf86633df 100644 ---

[PATCH] drm/radeon: Add build directory to include path

2022-04-13 Thread Michel Dänzer
From: Michel Dänzer Fixes compile errors with out-of-tree builds, e.g. ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or directory 38 | #include "r420_reg_safe.h" | ^ Signed-off-by: Michel Dänzer ---

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens (see >

Re: [PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 19:02, Andy Shevchenko wrote: > On Wed, Apr 13, 2022 at 06:23:57PM +0200, Javier Martinez Canillas wrote: >> These are declared in the ssd130x-i2c transport driver but the information >> is not I2C specific, and could be used by other SSD130x transport drivers. >> >> Move them to the

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes with spots in console screeens.

2022-04-13 Thread Jani Nikula
On Mon, 11 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens see the > attached photo). git-bisect shows that this is the

Re: [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Thomas Zimmermann
Hi Am 13.04.22 um 18:05 schrieb Daniel Vetter: On Wed, Apr 13, 2022 at 12:50:50PM +0200, Javier Martinez Canillas wrote: On 4/13/22 11:24, Thomas Zimmermann wrote: A workaround makes fbdev hot-unplugging work for framebuffers without device. The only user for this feature was offb. As each OF

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Rob Herring
eOn Wed, Apr 13, 2022 at 1:46 PM Rob Herring wrote: > > On Wed, Apr 13, 2022 at 12:58 PM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 13.04.22 um 14:51 schrieb Rob Herring: > > > On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann > > > wrote: > > >> > > >> Create a platform device for

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >

Re: [PATCH v4,1/3] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-04-13 Thread Rob Herring
On Sat, Apr 09, 2022 at 05:11:52PM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format > > Signed-off-by: Xinlei Lee > --- > .../display/mediatek/mediatek,dsi.txt | 62 - > .../display/mediatek/mediatek,dsi.yaml

Re: [PATCH v4,2/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186

2022-04-13 Thread Rob Herring
On Sat, 09 Apr 2022 17:11:53 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add dt-binding documentation of dsi for MediaTek MT8186 SoC. > > Signed-off-by: Xinlei Lee > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Rex-BC Chen > --- >

  1   2   >