Re: [PATCH 2/5] drm/amdgpu: stop resubmitting jobs for bare metal reset

2022-10-27 Thread Christian König
Hi Shaoyun, yes, absolutely. If you say that this is ok then I'm fine with that as well. Thanks, Christian. Am 26.10.22 um 20:13 schrieb Liu, Shaoyun: [AMD Official Use Only - General] The SRIOV already has its own reset routine amdgpu_device_reset_sriov, we try to put the sriov specific

Re: [PATCH v1 1/2] dma-buf: Make locking consistent in dma_buf_detach()

2022-10-27 Thread Christian König
Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: The dma_buf_detach() locks attach->dmabuf->resv and then unlocks dmabuf->resv, which could be a two different locks from a static code checker perspective. In particular this triggers Smatch to report the "double unlock" error. Make the locking

[PATCH] MAINTAINERS: Update GPU Scheduler email

2022-10-27 Thread Luben Tuikov
Update GPU Scheduler maintainer email. Cc: Alex Deucher Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Cc: AMD Graphics Cc: Direct Rendering Infrastructure - Development Signed-off-by: Luben Tuikov Acked-by: Christian König --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v1 2/2] drm/gem: Check whether object is NULL in drm_gem_vunmap()

2022-10-27 Thread Christian König
Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: The drm_gem_vunmap() will crash with a NULL dereference if the passed object pointer is NULL. It wasn't a problem before we added the locking support to drm_gem_vunmap function because the mapping argument was always NULL together with the object.

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Luben Tuikov
On 2022-10-25 13:50, Luben Tuikov wrote: > Looking... > > Regards, > Luben > > On 2022-10-25 09:35, Alex Deucher wrote: >> + Luben >> >> On Tue, Oct 25, 2022 at 2:55 AM brolerliew wrote: >>> >>> When entity move from one rq to another, current_entity will be set to NULL >>> if it is the moving

Re: [PATCH] dma-buf: cma_heap: Fix typo in comment

2022-10-27 Thread AngeloGioacchino Del Regno
Il 27/10/22 09:26, Mark-PK Tsai ha scritto: Fix typo in comment. Signed-off-by: Mark-PK Tsai Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread broler Liew
It's very nice of you-all to finger it out that it may crash when it is the last entity in the list. Absolutely I made a mistake about that. But I still cannot understand why we need to restart the selection from the list head when the current entity is removed from rq. In

Re: [PATCH] drm/i915: stop abusing swiotlb_max_segment

2022-10-27 Thread Tvrtko Ursulin
On 20/10/2022 12:03, Christoph Hellwig wrote: From: Robert Beckett swiotlb_max_segment used to return either the maximum size that swiotlb could bounce, or for Xen PV PAGE_SIZE even if swiotlb could bounce buffer larger mappings. This made i915 on Xen PV work as it bypasses the coherency

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Christian König
Am 27.10.22 um 11:00 schrieb broler Liew: It's very nice of you-all to finger it out that it may crash when it is the last entity in the list.   Absolutely I made a mistake about that. But I still cannot understand why we need to restart the selection from the list head when the current entity

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 10:32, Marco Felsch wrote: Hi, diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Matthew Garrett
On Thu, Oct 27, 2022 at 10:51:45AM +0200, Hans de Goede wrote: > In their backlight register paths and this has been present since > circa 2015. > > So both before and after my 6.1 refactor vendor is only preferred > on devices which don't implement the ACPI video bus control method. Sorry,

[PATCH v3] drm/ttm: rework on ttm_resource to use size_t type

2022-10-27 Thread Somalapuram Amaranath
Change ttm_resource structure from num_pages to size_t size in bytes. v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages v1 -> v2: change bo->resource->size to bo->base.size at some places v1 -> v2: remove the local variable v1 -> v2: cleanup cmp_size_smaller_first() v2 -> v3: adding missing

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-10-27 Thread Jacek Lawrynowicz
Hi, Thanks for an in-depth review. My responses are inline. On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: > On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and > > "It allows

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-10-27 Thread Maxime Ripard
Hi Mateusz, On Thu, Oct 27, 2022 at 12:02:24AM +0200, Mateusz Kwiatkowski wrote: > First of all, nice idea with the helper function that can be reused by > different drivers. This is neat! Yeah, it looked to me that given how complex it is, we don't want to duplicate it in each and every driver.

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
On 27/10/2022 19.13, Hector Martin wrote: > Until now, simpledrm unconditionally advertised all formats that can be > supported natively as conversions. However, we don't actually have a > full conversion matrix of helpers. Although the list is arguably > provided to userspace in precedence order,

Re: [pull] amdgpu, amdkfd drm-fixes-6.1

2022-10-27 Thread Alex Deucher
On Thu, Oct 27, 2022 at 1:42 AM Chen, Guchun wrote: > > Hello Alex, > > Regarding below patch, I guess we need to pick "8eb402f16d5b drm/amdgpu: Fix > uninitialized warning in mmhub_v2_0_get_clockgating()" together, otherwise, > build will possibly fail. Is it true? > I squashed that fix into

Re: [PATCH printk v2 38/38] printk, xen: fbfront: create/use safe function for forcing preferred

2022-10-27 Thread Petr Mladek
On Wed 2022-10-19 17:02:00, John Ogness wrote: > With commit 9e124fe16ff2("xen: Enable console tty by default in domU > if it's not a dummy") a hack was implemented to make sure that the > tty console remains the console behind the /dev/console device. The > main problem with the hack is that,

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Liu Ying
On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > On 10/27/22 07:45, Liu Ying wrote: > > Hi, > > [...] > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > index a5302006c02cd..aee7babb5fa5c 100644 > > > ---

Re: [PATCH v5 5/7] drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code

2022-10-27 Thread Dave Stevenson
On Thu, 27 Oct 2022 at 13:53, Maxime Ripard wrote: > > In order to support higher HDMI frequencies, users have to set the > hdmi_enable_4kp60 parameter in their config.txt file. > > This will have the side-effect of raising the maximum of the core clock, > tied to the HVS, and managed by the HVS

Re: [PATCH 1/2] drm/ofdrm: Cast PCI IDs to u32 for comparing

2022-10-27 Thread Thomas Zimmermann
Hi Am 27.10.22 um 15:07 schrieb Alexander Stein: Hello Thomas, Am Donnerstag, 27. Oktober 2022, 13:57:06 CEST schrieb Thomas Zimmermann: Properties of 32-bit integers are returned from the OF device tree as type __be32. Cast PCI vendor and device IDs from __be32 to u32 before comparing them

Re: [RFC][PATCH v2 13/31] timers: drm: Use del_timer_shutdown() before freeing timer

2022-10-27 Thread Steven Rostedt
[ quilt mail --send still can't handle unicode characters. Here's the patch again ] From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: "Noralf Trønnes" Cc: David

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-27 Thread Ville Syrjälä
On Thu, Oct 27, 2022 at 09:37:52AM -0600, jim.cro...@gmail.com wrote: > On Thu, Oct 27, 2022 at 9:08 AM Jason Baron wrote: > > > > > > > > On 10/21/22 05:18, Jani Nikula wrote: > > > On Thu, 20 Oct 2022, Ville Syrjälä wrote: > > >> On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote: > > >>>

Re: [PATCH] drm/bridge: it6505: Fix return value check for pm_runtime_get_sync

2022-10-27 Thread Neil Armstrong
Hi, On Thu, 27 Oct 2022 11:21:49 +0800, Pin-yen Lin wrote: > `pm_runtime_get_sync` may return 1 on success. Fix the `if` statement > here to make the code less confusing, even though additional calls to > `it6505_poweron` doesn't break anything when it's already powered. > > This was reported by

[PATCH 2/2] drm/ofdrm: Cast error pointers to void __iomem *

2022-10-27 Thread Thomas Zimmermann
Cast error pointers when returning them as void __iomem *. Fixes a number of Sparse warnings, such as the ones shown below. ../drivers/gpu/drm/tiny/ofdrm.c:439:31: warning: incorrect type in return expression (different address spaces) ../drivers/gpu/drm/tiny/ofdrm.c:439:31:expected void

[PATCH 1/2] drm/ofdrm: Cast PCI IDs to u32 for comparing

2022-10-27 Thread Thomas Zimmermann
Properties of 32-bit integers are returned from the OF device tree as type __be32. Cast PCI vendor and device IDs from __be32 to u32 before comparing them to constants. Fixes sparse warnings shown below. drivers/gpu/drm/tiny/ofdrm.c:237:17: warning: restricted __be32 degrades to integer

[PATCH 0/2] drm/ofdrm: Fix sparse warnings

2022-10-27 Thread Thomas Zimmermann
Fix two types of sparse warnings in ofdrm. Reported by the LKP bot. Thomas Zimmermann (2): drm/ofdrm: Cast PCI IDs to u32 for comparing drm/ofdrm: Cast error pointers to void __iomem * drivers/gpu/drm/tiny/ofdrm.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-)

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Rafael J. Wysocki
On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote: > > Hi, > > On 10/27/22 11:52, Matthew Garrett wrote: > > On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: > > > >> The *only* behavior which actually is new in 6.1 is the native GPU > >> drivers now doing the equivalent of: > >>

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Rafael J. Wysocki
On Thu, Oct 27, 2022 at 2:17 PM Hans de Goede wrote: > > Hi, > > On 10/27/22 14:09, Rafael J. Wysocki wrote: > > On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 10/27/22 11:52, Matthew Garrett wrote: > >>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
On 27/10/2022 20.08, Thomas Zimmermann wrote: > We currently have two DRM drivers that call drm_fb_build_fourcc_list(): > simpledrm and ofdrm. I've been very careful to keep the format selection > in sync between them. (That's the reason why the helper exists at all.) > If the drivers start to

Re: [igt-dev] Must-Pass Test Suite for KMS drivers

2022-10-27 Thread Maxime Ripard
On Mon, Oct 24, 2022 at 06:58:09PM +0300, Ville Syrjälä wrote: > On Mon, Oct 24, 2022 at 08:48:15AM -0700, Rob Clark wrote: > > On Mon, Oct 24, 2022 at 5:43 AM wrote: > > > > > > Hi, > > > > > > I've discussing the idea for the past year to add an IGT test suite that > > > all well-behaved KMS

Re: Must-Pass Test Suite for KMS drivers

2022-10-27 Thread Rob Clark
On Wed, Oct 26, 2022 at 1:17 AM wrote: > > Hi Rob, > > On Mon, Oct 24, 2022 at 08:48:15AM -0700, Rob Clark wrote: > > On Mon, Oct 24, 2022 at 5:43 AM wrote: > > > I've discussing the idea for the past year to add an IGT test suite that > > > all well-behaved KMS drivers must pass. > > > > > >

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-27 Thread Jason Baron
On 10/21/22 05:18, Jani Nikula wrote: > On Thu, 20 Oct 2022, Ville Syrjälä wrote: >> On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote: >>> On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote: hi Greg, Dan, Jason, DRM-folk, heres follow-up to V6: rebased on

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-27 Thread jim . cromie
On Thu, Oct 27, 2022 at 9:08 AM Jason Baron wrote: > > > > On 10/21/22 05:18, Jani Nikula wrote: > > On Thu, 20 Oct 2022, Ville Syrjälä wrote: > >> On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote: > >>> On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote: > hi Greg, Dan,

[PATCH v5 6/7] drm/vc4: hdmi: Add more checks for 4k resolutions

2022-10-27 Thread Maxime Ripard
From: Dom Cobley At least the 4096x2160@60Hz mode requires some overclocking that isn't available by default, even if hdmi_enable_4kp60 is enabled. Let's add some logic to detect whether we can satisfy the core clock requirements for that mode, and prevent it from being used otherwise.

[PATCH v5 5/7] drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code

2022-10-27 Thread Maxime Ripard
In order to support higher HDMI frequencies, users have to set the hdmi_enable_4kp60 parameter in their config.txt file. This will have the side-effect of raising the maximum of the core clock, tied to the HVS, and managed by the HVS driver. However, we are querying this in the HDMI driver by

[PATCH v5 7/7] drm/vc4: Make sure we don't end up with a core clock too high

2022-10-27 Thread Maxime Ripard
Following the clock rate range improvements to the clock framework, trying to set a disjoint range on a clock will now result in an error. Thus, we can't set a minimum rate higher than the maximum reported by the firmware, or clk_set_min_rate() will fail. Thus we need to clamp the rate we are

[PATCH v5 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-27 Thread Maxime Ripard
The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Acked-by: Stephen Boyd Reviewed-by: Florian Fainelli Signed-off-by:

[PATCH v5 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-10-27 Thread Maxime Ripard
We'll need the clock IDs in more drivers than just the clock driver from now on, so let's move them in the firmware header. Reviewed-by: Florian Fainelli Acked-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 19 ---

Re: [PATCH 1/2] drm/ofdrm: Cast PCI IDs to u32 for comparing

2022-10-27 Thread Alexander Stein
Hello Thomas, Am Donnerstag, 27. Oktober 2022, 13:57:06 CEST schrieb Thomas Zimmermann: > Properties of 32-bit integers are returned from the OF device tree > as type __be32. Cast PCI vendor and device IDs from __be32 to u32 > before comparing them to constants. Fixes sparse warnings shown below.

[PATCH] [next] drm/amdgpu: clean up unused constants, macros and includes

2022-10-27 Thread Paulo Miguel Almeida
Remove include directives in which header is already included via another header (atombios.h -> atom.h). Remove unused constants and macros. Signed-off-by: Paulo Miguel Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 1 -

[PATCH] dma-buf: cma_heap: Fix typo in comment

2022-10-27 Thread Mark-PK Tsai
Fix typo in comment. Signed-off-by: Mark-PK Tsai --- drivers/dma-buf/heaps/cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c index 28fb04eccdd0..cd386ce639f3 100644 ---

[PATCH v2] drm/format-helper: Only advertise supported formats for conversion

2022-10-27 Thread Hector Martin
drm_fb_build_fourcc_list() currently returns all emulated formats unconditionally as long as the native format is among them, even though not all combinations have conversion helpers. Although the list is arguably provided to userspace in precedence order, userspace can pick something out-of-order

Re: [PATCH v5 0/7] drm/vc4: Fix the core clock behaviour

2022-10-27 Thread Maxime Ripard
Hi Florian, On Thu, Oct 27, 2022 at 02:52:40PM +0200, Maxime Ripard wrote: > Hi, > > Those patches used to be part of a larger clock fixes series: > https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ > > However, that series doesn't seem to be getting anywhere, so

Re: [PATCH v3 1/2] drm/msm: move domain allocation into msm_iommu_new()

2022-10-27 Thread Dmitry Baryshkov
On 27/10/2022 18:48, Rob Clark wrote: On Tue, Oct 25, 2022 at 1:04 PM Dmitry Baryshkov wrote: After the msm_iommu instance is created, the IOMMU domain is completely handled inside the msm_iommu code. Move the iommu_domain_alloc() call into the msm_iommu_new() to simplify callers code.

RE: [PATCH v8 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-10-27 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Monday, October 24, 2022 8:52 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org;

Re: [PATCH] drm/amd/display: don't print messages that contain %f in dml

2022-10-27 Thread Rodrigo Siqueira
On 10/24/22 06:04, Christian König wrote: Am 21.10.22 um 18:34 schrieb Hamza Mahfooz: Unfortunately, printk() doesn't currently support the printing of %f entries. So, print statements that contain "%f" should be removed. However, since DC is used on other OSes that can still benefit from

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Luben Tuikov
So, I started fixing this, including the bug taking the next element as an entity, but it could be actually the list_head... a la your patch being fixed, and then went down the rabbit whole of also fixing drm_sched_rq_select_entity(), but the problem is that at that point we don't know if we

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Hans de Goede
Hi, On 10/27/22 14:09, Rafael J. Wysocki wrote: > On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote: >> >> Hi, >> >> On 10/27/22 11:52, Matthew Garrett wrote: >>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: >>> The *only* behavior which actually is new in 6.1 is the

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Pekka Paalanen
On Thu, 27 Oct 2022 13:08:24 +0200 Thomas Zimmermann wrote: > Hi > > Am 27.10.22 um 12:13 schrieb Hector Martin: > > Until now, simpledrm unconditionally advertised all formats that can be > > supported natively as conversions. However, we don't actually have a > > full conversion matrix of

Re: [PATCH printk v2 38/38] printk, xen: fbfront: create/use safe function for forcing preferred

2022-10-27 Thread Petr Mladek
On Thu 2022-10-27 15:41:23, John Ogness wrote: > On 2022-10-27, Petr Mladek wrote: > >> - if (c) { > >> - unregister_console(c); > >> - c->flags |= CON_CONSDEV; > >> - c->flags &= ~CON_PRINTBUFFER; /* don't print again */ > >> - register_console(c); > >> - }

Re: [PATCH 2/2] drm/vc4: hdmi: Fix outdated function name in comment

2022-10-27 Thread Javier Martinez Canillas
On 10/24/22 11:36, max...@cerno.tech wrote: > A comment introduced by commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link > on hotplug") mentions a drm_atomic_helper_connector_hdmi_reset_link() > function that was part of the earlier versions but got moved internally > and is now named

[RFC][PATCH v2 13/31] timers: drm: Use del_timer_shutdown() before freeing timer

2022-10-27 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: "Noralf Trønnes" Cc: David Airlie Cc: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc:

[RFC][PATCH v2 12/31] timers: dma-buf: Use del_timer_shutdown() before freeing timer

2022-10-27 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc:

Re: [RFC][PATCH v2 12/31] timers: dma-buf: Use del_timer_shutdown() before freeing timer

2022-10-27 Thread Steven Rostedt
[ quilt mail --send still can't handle unicode characters. Here's the patch again ] From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: Sumit Semwal Cc:

Re: [PATCH] dma-buf: cma_heap: Fix typo in comment

2022-10-27 Thread Bagas Sanjaya
On Thu, Oct 27, 2022 at 03:26:38PM +0800, Mark-PK Tsai wrote: > Fix typo in comment. > Comment on what function? I had to see the diff context. > Signed-off-by: Mark-PK Tsai > --- > drivers/dma-buf/heaps/cma_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH v5 0/7] drm/vc4: Fix the core clock behaviour

2022-10-27 Thread Maxime Ripard
Hi, Those patches used to be part of a larger clock fixes series: https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ However, that series doesn't seem to be getting anywhere, so I've split out these patches that fix a regression that has been there since 5.18 and that

[PATCH v5 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()

2022-10-27 Thread Maxime Ripard
A significant number of RaspberryPi drivers using the firmware don't have a phandle to it, so end up scanning the device tree to find a node with the firmware compatible. That code is duplicated everywhere, so let's introduce a helper instead. Acked-by: Florian Fainelli Signed-off-by: Maxime

[PATCH v5 4/7] drm/vc4: hdmi: Fix hdmi_enable_4kp60 detection

2022-10-27 Thread Maxime Ripard
In order to support higher HDMI frequencies, users have to set the hdmi_enable_4kp60 parameter in their config.txt file. We were detecting this so far by calling clk_round_rate() on the core clock with the frequency we're supposed to run at when one of those modes is enabled. Whether or not the

Re: [PATCH printk v2 38/38] printk, xen: fbfront: create/use safe function for forcing preferred

2022-10-27 Thread John Ogness
On 2022-10-27, Petr Mladek wrote: >> -if (c) { >> -unregister_console(c); >> -c->flags |= CON_CONSDEV; >> -c->flags &= ~CON_PRINTBUFFER; /* don't print again */ >> -register_console(c); >> -} >> +if (c) >> +

Re: [PATCH v3 1/2] drm/msm: move domain allocation into msm_iommu_new()

2022-10-27 Thread Rob Clark
On Tue, Oct 25, 2022 at 1:04 PM Dmitry Baryshkov wrote: > > After the msm_iommu instance is created, the IOMMU domain is completely > handled inside the msm_iommu code. Move the iommu_domain_alloc() call > into the msm_iommu_new() to simplify callers code. > > Reported-by: kernel test robot >

Re: (subset) [PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-10-27 Thread Lorenzo Pieralisi
On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door

Re: [PATCH 1/2] drm/vc4: hdmi: Take our lock to reset the link

2022-10-27 Thread Javier Martinez Canillas
Hello Maxime, On 10/24/22 11:36, max...@cerno.tech wrote: > We access some fields protected by our internal mutex in > vc4_hdmi_reset_link() (saved_adjusted_mode, output_bpc, output_format) > and are calling functions that need to have that lock taken > (vc4_hdmi_supports_scrambling()). > >

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Thomas Zimmermann
Hi Am 27.10.22 um 12:13 schrieb Hector Martin: Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually have a full conversion matrix of helpers. Although the list is arguably provided to userspace in precedence order,

Re: [PATCH v6 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-10-27 Thread Maxime Ripard
Hi, On Thu, Oct 27, 2022 at 12:32:50AM +0200, Mateusz Kwiatkowski wrote: > I've seen that you've incorporated my PAL60 patch. Thanks! > > I still yet need to test your v6 changes, but looking at this code with just > my > mental static analysis, it seems to me that the

Re: Try to address the DMA-buf coherency problem

2022-10-27 Thread Christian König
Am 20.10.22 um 14:13 schrieb Christian König: Hi guys, after finding that we essentially have two separate worlds for coherent sharing of buffer through DMA-buf I thought I will tackle that problem a bit and at least allow the framework to reject attachments which won't work. So those patches

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Thomas Zimmermann
Hi Am 27.10.22 um 14:22 schrieb Pekka Paalanen: On Thu, 27 Oct 2022 13:08:24 +0200 Thomas Zimmermann wrote: Hi Am 27.10.22 um 12:13 schrieb Hector Martin: Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually

Re: [PATCH v2] drm/vc4: hdmi: Fix HSM clock too low on Pi4

2022-10-27 Thread Javier Martinez Canillas
On 10/21/22 15:13, max...@cerno.tech wrote: > Commit ae71ab585c81 ("drm/vc4: hdmi: Enforce the minimum rate at > runtime_resume") reintroduced the call to clk_set_min_rate in an attempt > to fix the boot without a monitor connected on the RaspberryPi3. > > However, that introduced a regression

Re: [PATCH v1 1/7] vfio/ccw: create a parent struct

2022-10-27 Thread Eric Farman
On Wed, 2022-10-19 at 18:21 +0200, Eric Farman wrote: > Move the stuff associated with the mdev parent (and thus the > subchannel struct) into its own struct, and leave the rest in > the existing private structure. > > The subchannel will point to the parent, and the parent will point > to the

[PATCH 5/5] drm/i915/mtl: don't expose GSC command streamer to the user

2022-10-27 Thread Daniele Ceraolo Spurio
There is no userspace user for this CS yet, we only need it for internal kernel ops (e.g. HuC, PXP), so don't expose it. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 1/5] drm/i915/mtl: add initial definitions for GSC CS

2022-10-27 Thread Daniele Ceraolo Spurio
Starting on MTL, the GSC is no longer managed with direct MMIO access, but we instead have a dedicated command streamer for it. As a first step for adding support for this CS, add the required definitions. Note that, although it is now a CS, the GSC retains its old class:instance value

[PATCH 2/5] drm/i915/mtl: pass the GSC CS info to the GuC

2022-10-27 Thread Daniele Ceraolo Spurio
We need to tell the GuC that the GSC CS is there. The GuC interface swaps COMPUTE and OTHER class, so we also need to handle that. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 11 +-- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h

[PATCH 3/5] drm/i915/mtl: add GSC CS interrupt support

2022-10-27 Thread Daniele Ceraolo Spurio
The GSC CS re-uses the same interrupt bits that the GSC used in older platforms. This means that we can now have an engine interrupt coming out of OTHER_CLASS, so we need to handle that appropriately. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper ---

[PATCH 4/5] drm/i915/mtl: add GSC CS reset support

2022-10-27 Thread Daniele Ceraolo Spurio
The GSC CS has its own dedicated bit in the GDRST register. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + 2 files changed, 2 insertions(+) diff --git

linux-next: manual merge of the amdgpu tree with the drm tree

2022-10-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c between commit: 7c99616e3fe7 ("drm: Remove drm_mode_config::fb_base") from the drm tree and commit: 887e8cec55f2 ("drm/amdgpu: set fb_modifiers_not_supported in vkms") from

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 19:47, Marco Felsch wrote: On 22-10-27, Liu Ying wrote: On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: On 10/27/22 07:45, Liu Ying wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c

[PATCH v2] dma-buf: cma_heap: Fix typo in comment

2022-10-27 Thread Mark-PK Tsai
Remove duplicated "by" from comment in cma_heap_allocate(). Signed-off-by: Mark-PK Tsai --- drivers/dma-buf/heaps/cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c index 28fb04eccdd0..cd386ce639f3

Re: [PATCH v5 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-27 Thread Krzysztof Kozlowski
On 26/10/2022 00:03, Pin-yen Lin wrote: >>> + - minItems: 4 >>> +maxItems: 4 >>> +uniqueItems: true >>> +items: >>> + enum: >>> +- 0 >>> +- 1 >>> +

[PATCH] drm/virtio: fix the black screen error when waking

2022-10-27 Thread liweishi
Mainline: NA Category: Bugfix CVE: NA When the system wakes up from sleeping, all virtio devices will be reset. However, restting virtio gpu device will delete the virtqueue and resources saved on the virtio gpu backend, making it impossible for the virtio gpu driver to communicate with the

Re: [PATCH 1/2] drm/msm/dsi: add a helper method to compute the dsi byte clk

2022-10-27 Thread Abhinav Kumar
On 10/27/2022 10:35 AM, Dmitry Baryshkov wrote: On 22/09/2022 03:49, Abhinav Kumar wrote: Re-arrange the dsi_calc_pclk method to two helpers, one to compute the DSI byte clk and the other to compute the pclk. This makes the separation of the two clean and also allows clients to compute and

Re: [PATCH 2/3] drm/prime: set the dma_coherent flag for export

2022-10-27 Thread Rob Clark
On Thu, Oct 20, 2022 at 7:57 AM Christian König wrote: > > Am 20.10.22 um 16:43 schrieb Rob Clark: > > On Thu, Oct 20, 2022 at 5:13 AM Christian König > > wrote: > >> When a device driver is snooping the CPU cache during access we assume > >> that all importers need to be able to snoop the CPU

Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

2022-10-27 Thread Krzysztof Kozlowski
On 26/10/2022 23:01, allen wrote: > From: allen chen > > Add properties to restrict dp output data-lanes and clock. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Liu Ying
On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote: > On 10/27/22 19:47, Marco Felsch wrote: > > On 22-10-27, Liu Ying wrote: > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > > > On 10/27/22 07:45, Liu Ying wrote: > > > > > > > > Hi, > > > > > > > > [...] > > > > > > > > > >

[PATCH 0/5] Introduce the GSC CS

2022-10-27 Thread Daniele Ceraolo Spurio
Starting on MTL, the GSC microcontroller resides inside the media GT and the driver can communicate with it via a new Command Streamer, the GSC CS. As a first step in supporting the GSC integration within the media GT, this series adds the required defines and basic support for this CS. Note that,

Re: [PATCH 1/5] drm/i915/mtl: add initial definitions for GSC CS

2022-10-27 Thread Matt Roper
On Thu, Oct 27, 2022 at 03:15:50PM -0700, Daniele Ceraolo Spurio wrote: > Starting on MTL, the GSC is no longer managed with direct MMIO access, > but we instead have a dedicated command streamer for it. As a first step > for adding support for this CS, add the required definitions. > Note that,

Re: [PATCH 3/5] drm/i915/mtl: add GSC CS interrupt support

2022-10-27 Thread Matt Roper
On Thu, Oct 27, 2022 at 03:15:52PM -0700, Daniele Ceraolo Spurio wrote: > The GSC CS re-uses the same interrupt bits that the GSC used in older > platforms. This means that we can now have an engine interrupt coming > out of OTHER_CLASS, so we need to handle that appropriately. > > Signed-off-by:

Re: [PATCH 4/5] drm/i915/mtl: add GSC CS reset support

2022-10-27 Thread Matt Roper
On Thu, Oct 27, 2022 at 03:15:53PM -0700, Daniele Ceraolo Spurio wrote: > The GSC CS has its own dedicated bit in the GDRST register. > > Signed-off-by: Daniele Ceraolo Spurio > Cc: Matt Roper Bspec: 52549 Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + >

Re: [PATCH 2/5] drm/i915/mtl: pass the GSC CS info to the GuC

2022-10-27 Thread Matt Roper
On Thu, Oct 27, 2022 at 03:15:51PM -0700, Daniele Ceraolo Spurio wrote: > We need to tell the GuC that the GSC CS is there. The GuC interface > swaps COMPUTE and OTHER class, so we also need to handle that. When I first read the second sentence here, I thought you were saying that the GuC

Re: (subset) [PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-10-27 Thread Dmitry Torokhov
Hi Lorenzo, On Thu, Oct 27, 2022 at 03:38:11PM +0200, Lorenzo Pieralisi wrote: > On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit. We can do that by switching drivers >

Re: [PATCH] MAINTAINERS: Update GPU Scheduler email

2022-10-27 Thread Alex Deucher
On Thu, Oct 27, 2022 at 2:19 AM Luben Tuikov wrote: > > Update GPU Scheduler maintainer email. > > Cc: Alex Deucher > Cc: Christian König > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: AMD Graphics > Cc: Direct Rendering Infrastructure - Development > > Signed-off-by: Luben Tuikov >

Re: [PATCH v5 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-27 Thread Florian Fainelli
On 10/27/2022 5:52 AM, Maxime Ripard wrote: The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Acked-by: Stephen Boyd

Re: [PATCH v5 0/7] drm/vc4: Fix the core clock behaviour

2022-10-27 Thread Florian Fainelli
On 10/27/2022 7:59 AM, Maxime Ripard wrote: Hi Florian, On Thu, Oct 27, 2022 at 02:52:40PM +0200, Maxime Ripard wrote: Hi, Those patches used to be part of a larger clock fixes series: https://lore.kernel.org/linux-clk/20220715160014.2623107-1-max...@cerno.tech/ However, that series

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
On 22-10-27, Liu Ying wrote: > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote: > > On 10/27/22 07:45, Liu Ying wrote: > > > > Hi, > > > > [...] > > > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > > index a5302006c02cd..aee7babb5fa5c

Re: [Freedreno] [PATCH v3] drm/msm/mdp5: stop overriding drvdata

2022-10-27 Thread Dmitry Baryshkov
On 27/10/2022 21:30, Abhinav Kumar wrote: On 10/24/2022 8:26 AM, Dmitry Baryshkov wrote: The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do not override the mdp5's drvdata. Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-10-27 Thread jim . cromie
On Thu, Oct 27, 2022 at 9:59 AM Ville Syrjälä wrote: > > On Thu, Oct 27, 2022 at 09:37:52AM -0600, jim.cro...@gmail.com wrote: > > On Thu, Oct 27, 2022 at 9:08 AM Jason Baron wrote: > > > > > > > > > > > > On 10/21/22 05:18, Jani Nikula wrote: > > > > On Thu, 20 Oct 2022, Ville Syrjälä > > > >

[PATCH 6.0 01/94] [PATCH v2] video/aperture: Call sysfb_disable() before removing PCI devices

2022-10-27 Thread Greg Kroah-Hartman
From: Thomas Zimmermann Call sysfb_disable() from aperture_remove_conflicting_pci_devices() before removing PCI devices. Without, simpledrm can still bind to simple-framebuffer devices after the hardware driver has taken over the hardware. Both drivers interfere with each other and results are

Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

2022-10-27 Thread Andi Shyti
Hi Nathan, pushed in drm-intel-gt-next. Thanks! Andi On Thu, Oct 13, 2022 at 01:59:10PM -0700, Nathan Chancellor wrote: > When booting with CONFIG_CFI_CLANG, there are numerous violations when > accessing the files under > /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: > > $ cd

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-10-27 Thread Jeffrey Hugo
On 10/27/2022 3:14 AM, Jacek Lawrynowicz wrote: Hi, Thanks for an in-depth review. My responses are inline. On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: VPU Memory Management Unit is based on ARM MMU-600. It allows to create multiple virtual

[PATCH v3] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2022-10-27 Thread Won Chung
Create a symlink pointing to USB Type-C connector for DRM connectors when they are created. The link will be created only if the firmware is able to describe the connection beween the two connectors. Signed-off-by: Won Chung Acked-by: Heikki Krogerus --- Changes from v2: - Resending the patch

Re: [PATCH 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2022-10-27 Thread Dmitry Baryshkov
On 22/09/2022 03:49, Abhinav Kumar wrote: Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether an opp table entry exists. For devices which

Re: [PATCH v8 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-10-27 Thread Dmitry Baryshkov
On 27/10/2022 16:34, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Monday, October 24, 2022 8:52 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc:

  1   2   >