[PATCH 3/5] drm/amdgpu: stop resubmittting jobs in amdgpu_pci_resume

2022-11-09 Thread Christian König
As far as I can see this is not really recoverable since a PCI reset clears VRAM. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

RE: [PATCH 2/2] drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code

2022-11-09 Thread Lin, Wayne
[AMD Official Use Only - General] Hi Lyude, It LGTM. Feel free to add Reviewed-by: Wayne Lin > -Original Message- > From: Lyude Paul > Sent: Saturday, November 5, 2022 7:59 AM > To: amd-...@lists.freedesktop.org > Cc: sta...@vger.kernel.org; David Airlie ; Daniel Vetter > ; Jani

[PATCH 5/5] drm/scheduler: deprecate drm_sched_resubmit_jobs

2022-11-09 Thread Christian König
This interface is not working as it should. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index

Re: [PATCH v4 4/4] drm: panel: Add Jadard JD9365DA-H3 DSI panel

2022-11-09 Thread Linus Walleij
On Tue, Nov 8, 2022 at 6:31 PM Jagan Teki wrote: > Jadard JD9365DA-H3 is WXGA MIPI DSI panel and it support TFT > dot matrix LCD with 800RGBx1280 dots at maximum. > > Add support for it. > > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jagan Teki > --- > Changes for v4: > - add delay

RE: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-09 Thread Lin, Wayne
[Public] Thanks, Lyude! Comments inline. > -Original Message- > From: Lyude Paul > Sent: Saturday, November 5, 2022 7:59 AM > To: amd-...@lists.freedesktop.org > Cc: Wentland, Harry ; sta...@vger.kernel.org; > Li, Sun peng (Leo) ; Siqueira, Rodrigo > ; Deucher, Alexander > ; Koenig,

[PATCH v4] drm: mediatek: Modify dpi power on/off sequence.

2022-11-09 Thread xinlei.lee
From: Xinlei Lee Modify dpi power on/off sequence so that the first gpio operation will take effect. Fixes: 6bd4763fd532 ("drm/mediatek: set dpi pin mode to gpio low to avoid leakage current") Signed-off-by: Xinlei Lee --- change note: v3: Moved pull-down pin control after mtk_dpi_power_off.

Re: [PATCH] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-09 Thread Chunyou Tang
Hi, drm_gem_object_init() will do these before failed: void drm_gem_private_object_init(struct drm_device *dev, struct drm_gem_object *obj, size_t size) { BUG_ON((size & (PAGE_SIZE - 1)) != 0); obj->dev = dev; obj->filp = NULL;

[PATCH] drm/virtio: Fix memory leak in virtio_gpu_object_create()

2022-11-09 Thread Xiu Jianfeng
The virtio_gpu_object_shmem_init() will alloc memory and save it in @ents, so when virtio_gpu_array_alloc() fails, this memory should be freed, this patch fixes it. Fixes: e7fef0923303 ("drm/virtio: Simplify error handling of virtio_gpu_object_create()") Signed-off-by: Xiu Jianfeng ---

RE: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Tian, Kevin
every mail in this series is shown thrice in lore: https://lore.kernel.org/all/0-v2-65016290f146+33e-vfio_iommufd_...@nvidia.com/ not sure what caused it but it's annoying to check the conversation there. the iommufd series doesn't have this problem. > From: Jason Gunthorpe > Sent: Tuesday,

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH 1/5] drm/amd/amdgpu revert "implement tdr advanced mode"

2022-11-09 Thread Christian König
This reverts commit e6c6338f393b74ac0b303d567bb918b44ae7ad75. This feature basically re-submits one job after another to figure out which one was the one causing a hang. This is obviously incompatible with gang-submit which requires that multiple jobs run at the same time. It's also absolutely

[PATCH 4/5] drm/scheduler: cleanup define

2022-11-09 Thread Christian König
Remove some not implemented function define Signed-off-by: Christian König --- include/drm/gpu_scheduler.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 156601fd7053..73a2327d6b00 100644 --- a/include/drm/gpu_scheduler.h +++

[PATCH 2/5] drm/amdgpu: stop resubmitting jobs for GPU reset v2

2022-11-09 Thread Christian König
Re-submitting IBs by the kernel has many problems because pre- requisite state is not automatically re-created as well. In other words neither binary semaphores nor things like ring buffer pointers are in the state they should be when the hardware starts to work on the IBs again. Additional to

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Pekka Paalanen
On Tue, 8 Nov 2022 23:01:47 +0100 Sebastian Wick wrote: > On Tue, Nov 8, 2022 at 7:51 PM Simon Ser wrote: > > > > cc'ing Pekka and wayland-devel for userspace devs feedback on the new uAPI. Hi all, thanks! Comments below. > > > > On Saturday, October 29th, 2022 at 14:08, Dmitry Baryshkov >

[PATCH] drm/bridge: it6505: Guard bridge power in IRQ handler

2022-11-09 Thread Pin-yen Lin
Add a pair of pm_runtime_get_if_in_use and pm_runtime_put_sync in the interrupt handler to make sure the bridge won't be powered off during the interrupt handlings. Also remove the irq_lock mutex because it's not guarding anything now. Fixes: ab28896f1a83 ("drm/bridge: it6505: Improve

[PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2022-11-09 Thread Andi Shyti
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that

[PATCH 1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-09 Thread Andi Shyti
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the

[PATCH 3/3] drm/i915: Refine VT-d scanout workaround

2022-11-09 Thread Andi Shyti
From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses will wrap around the ends of the GGTT.

Re: [syzbot] memory leak in drm_vma_node_allow

2022-11-09 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:f141df371335 Merge tag 'audit-pr-20221107' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=123bdcd188 kernel config:

Re: [PATCH v8 4/7] drm/shmem-helper: Add memory shrinker

2022-11-09 Thread Dmitry Osipenko
Hello Thomas, On 11/9/22 13:28, Thomas Zimmermann wrote: >> +int drm_gem_shmem_set_evictable(struct drm_gem_shmem_object *shmem) >> +{ >> +    dma_resv_lock(shmem->base.resv, NULL); >> + >> +    if (shmem->madv < 0) { >> +    dma_resv_unlock(shmem->base.resv); >> +    return -ENOMEM; > >

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Leo Li
On 11/9/22 13:20, Hamza Mahfooz wrote: Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are

Re: [PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Thomas Hellström
Hi, Andi, This has been on the list before (three times I think) and at that point it (the guard pages) was NAK'd by Daniel as yet another complication, and a VT-d scanout workaround was implemented and pushed using a different approach, initially outlined by Daniel. Patch is 2ef6efa79fecd.

Re: [PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Andi Shyti
Hi Thomas, On Wed, Nov 09, 2022 at 07:03:03PM +0100, Thomas Hellström wrote: > Hi, Andi, > > This has been on the list before (three times I think) and at that > point it (the guard pages) was NAK'd by Daniel as yet another > complication, and a VT-d > scanout workaround was implemented and

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-09 Thread Alex Williamson
On Tue, 8 Nov 2022 21:05:21 -0400 Jason Gunthorpe wrote: > On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > > > head in the sand that such platforms exists and can still be useful > > > > given

[PATCH v2 2/2] drm/msm/dp: add support of max dp link rate

2022-11-09 Thread Kuogee Hsieh
Since it is not every platform supports HBR3 link rate, this patch limit the DP link rate at max link rate if it is specified at DTS file. Otherwise, the max dp link rate will be limited at HBR2 as before. Changes in v2: -- add max link rate from dtsi Signed-off-by: Kuogee Hsieh ---

[PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Kuogee Hsieh
This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi

[PATCH v2 0/2] Add DP max link rate support

2022-11-09 Thread Kuogee Hsieh
dd DP link-frequencies property to DTS file and support function to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed drm/msm/dp: add support of max dp link rate arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 +

Re: [PATCH v2] drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid

2022-11-09 Thread Kees Cook
On Tue, Nov 08, 2022 at 05:14:25PM -0700, Nathan Chancellor wrote: > From: Nathan Huckleberry > > The mode_valid field in drm_bridge_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_bridge *bridge, > struct

Re: [PATCH v2] drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid

2022-11-09 Thread Laurent Pinchart
Hi Nathan, Thank you for the patch. On Tue, Nov 08, 2022 at 05:14:25PM -0700, Nathan Chancellor wrote: > From: Nathan Huckleberry > > The mode_valid field in drm_bridge_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_bridge *bridge, >

[GIT PULL FOR v6.2] Renesas and Xilinx changes

2022-11-09 Thread Laurent Pinchart
/media.git tags/drm-next-20221109 for you to fetch changes up to cec9e59cae6071e58140baf54e47c00aaa39851b: drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid (2022-11-09 16:50:21 +0200) - Renesas RZ/G2L DSI support - Renesas

Re: [PATCH v3] drm/vmwgfx: Fix race issue calling pin_user_pages

2022-11-09 Thread Martin Krastev (VMware)
From: Martin Krastev Looks great! Reviewed-by: Martin Krastev Regards, Martin On 9.11.22 г. 17:37 ч., Dawei Li wrote: pin_user_pages() is unsafe without protection of mmap_lock, fix it by calling pin_user_pages_fast(). Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware

Re: [PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-09 Thread Karol Herbst
On Fri, Nov 4, 2022 at 11:04 PM Antonio Gomes wrote: > > From: antoniospg > > Summary: > > * Add support to turn on/off backlight when changing values in bl_power > file. This is achieved by using function backlight_get_brightness() > in nva3_set_intensity to get current brightness. > > Test

Re: [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Iddamsetty, Aravind
On 31-10-2022 23:16, Matt Roper wrote: > On Mon, Oct 31, 2022 at 06:01:11PM +0530, Aravind Iddamsetty wrote: >> On XE_LPM+ platforms the media engines are carved out into a separate >> GT but have a common GGTMMADR address range which essentially makes >> the GGTT address space to be shared

Re: [PATCH 3/4] drm/msm/disp/dpu1: helper function to determine if encoder is virtual

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Add a helper function to determine if an encoder is of type virtual. Please use commit messages to describe why you are doing something, not what you are doing. In this case I can predict, why do you need this API without going to patch 4.

Re: [v8] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:14, Kalyan Thota wrote: Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org;

Re: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:39, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Wednesday, November 9, 2022 6:02 PM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc:

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 --- Comment #3 from Stanislav Modrak (stanislav.mod...@gmail.com) --- (In reply to Artem S. Tashkinov from comment #2) > https://gitlab.freedesktop.org is where it should be anyways. Can you please explain why it belongs there and not here? Thx!

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > wrote: > > > On 29/10/2022 01:59, Jessica Zhang wrote: > > > > > Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for > > > drm_plane. In addition, add support

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: > On 09/11/2022 16:52, Daniel Vetter wrote: > > On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > > > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > > > wrote: > > > > > > > On 29/10/2022 01:59, Jessica

Re: [PATCH] drm/tidss: Set max DMA segment size

2022-11-09 Thread Andrew Davis
On 8/22/22 7:16 PM, Andrew Davis wrote: We have no segment size limitations. Set to unlimited. Signed-off-by: Andrew Davis --- Ping, still valid. Andrew drivers/gpu/drm/tidss/tidss_dispc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c

[PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Andi Shyti
Hi, This series adds guards around vma's but setting a pages at the beginning and at the end that work as padding. The first user of the vma guard are scanout objects which don't need anymore to add scratch to all the unused ggtt's and speeding up up considerably the boot and resume by several

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-09 Thread John Harrison
On 11/9/2022 03:05, Tvrtko Ursulin wrote: On 08/11/2022 20:15, John Harrison wrote: On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio,

[PATCH] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Hamza Mahfooz
Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-09 Thread Matthew Auld
On Mon, 7 Nov 2022 at 08:53, Niranjana Vishwanathapura wrote: > > Asynchronously unbind the vma upon vm_unbind call. > Fall back to synchronous unbind if backend doesn't support > async unbind or if async unbind fails. > > No need for vm_unbind out fence support as i915 will internally > handle

[PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Hamza Mahfooz
Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are only useful for debugging PSR (and confusing

Re: [PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 21:34, Kuogee Hsieh wrote: This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v8 4/7] drm/shmem-helper: Add memory shrinker

2022-11-09 Thread Thomas Zimmermann
Hi Am 06.11.22 um 00:27 schrieb Dmitry Osipenko: Introduce common drm-shmem shrinker for DRM drivers. To start using drm-shmem shrinker drivers should do the following: 1. Implement evict() callback of shmem object where driver should check whether object is purgeable or evictable and

[PATCH v3] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert some usages of legacy DRM logging macros into versions which tell us on which device have the events occurred. v2: * Don't have struct drm_device as local. (Jani, Ville) v3: * Store gt, not i915, in workaround list. (John) Signed-off-by: Tvrtko Ursulin

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Maxime Ripard
On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > > Maxime Ripard writes: > > > Hi, > > > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > >> > >> Maxime Ripard writes: > >> > >> > Hi Paul, > >> > > >> > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul

Re: [PATCH] drm/qxl: Fix missing free_irq

2022-11-09 Thread liwei (GF)
On 2022/11/9 0:06, Daniel Vetter wrote: > On Tue, Nov 08, 2022 at 11:16:01PM +0800, Wei Li wrote: >> When doing "cat /proc/interrupts" after qxl.ko is unloaded, an oops occurs: >> >> BUG: unable to handle page fault for address: c0274769 >> PGD 2a0d067 P4D 2a0d067 PUD 2a0f067 PMD

Re: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 09:03:52AM +, Tian, Kevin wrote: > every mail in this series is shown thrice in lore: > > https://lore.kernel.org/all/0-v2-65016290f146+33e-vfio_iommufd_...@nvidia.com/ > > not sure what caused it but it's annoying to check the conversation there. It is sort of a

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org;

Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources

2022-11-09 Thread Liviu Dudau
On Tue, Nov 08, 2022 at 08:57:55PM +0100, Danilo Krummrich wrote: > Hi Liviu, Hi, > > > The only issue that I'm seeing that is not critical is that at > > reboot/shutdown time > > I'm getting an "Unexpected global fault, this could be serious" from the > > smmu: > > > > [ 6893.467910]

Re: [PATCH v2] drm: fix crash in drm_minor_alloc_release

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 07:38:23PM +0100, Stanislaw Gruszka wrote: > If drm_sysfs_minor_alloc() fail in drm_minor_alloc() we can end up > freeing invalid minor->kdev pointer and drm_minor_alloc_release() > will crash like below: > > RIP: 0010:kobject_put+0x19/0x1c0 > RSP: 0018:bc7001637c38

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Maxime Ripard
Hi Paul, On Sat, Nov 05, 2022 at 10:33:54AM +, Paul Cercueil wrote: > Hi Maxime, > > Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a > écrit : > > Hi Paul, > > > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > > > Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-09 Thread Tvrtko Ursulin
On 08/11/2022 19:37, John Harrison wrote: On 11/8/2022 01:08, Tvrtko Ursulin wrote: On 07/11/2022 19:45, John Harrison wrote: On 11/7/2022 06:09, Tvrtko Ursulin wrote: On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison

[PATCH 3/4] drm/msm/disp/dpu1: helper function to determine if encoder is virtual

2022-11-09 Thread Kalyan Thota
Add a helper function to determine if an encoder is of type virtual. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 6 ++ 2 files changed, 17 insertions(+) diff --git

[PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalogue Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 15 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 6

[PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-09 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 +- 1 file changed, 5

[PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external

2022-11-09 Thread Kalyan Thota
DRM encoder type is same for eDP and DP (DRM_MODE_ENCODER_TMDS) populate is_external information in the disp_info so as to differentiate between eDP and DP on the DPU encoder side. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 20 +---

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 03:21:29AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, November 9, 2022 9:05 AM > > > > On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > > > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > >

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 16:52, Daniel Vetter wrote: On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: On 29/10/2022 01:59, Jessica Zhang wrote: Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for drm_plane. In

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-09 Thread Tvrtko Ursulin
On 08/11/2022 20:15, John Harrison wrote: On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio, Daniele wrote: On 11/4/2022 10:25 AM,

Re: [PATCH v2 34/65] clk: ux500: prcmu: Add a determine_rate hook

2022-11-09 Thread Maxime Ripard
Hi Linus, On Tue, Nov 08, 2022 at 02:25:04PM +0100, Linus Walleij wrote: > On Fri, Nov 4, 2022 at 2:32 PM Maxime Ripard wrote: > > > The UX500 PRCMU "clkout" clock implements a mux with a set_parent hook, > > but doesn't provide a determine_rate implementation. > > > > This is a bit odd, since

Re: [PATCH v13,0/3] Add dpi output format control for MT8186

2022-11-09 Thread Matthias Brugger
Hi Xinlei, On 09/11/2022 03:40, Xinlei Lee (李昕磊) wrote: On Tue, 2022-11-08 at 19:27 +0100, Matthias Brugger wrote: Hi Xinlei, Somehow b4 broke with your thread but I was able to apply patch 1 and 2 by hand. Thanks Matthias On 24/10/2022 04:04, xinlei@mediatek.com wrote: > From: Xinlei

Re: [PATCH v2 0/7] drm: Review of mode copies

2022-11-09 Thread Ville Syrjälä
On Tue, Nov 08, 2022 at 05:13:37PM -0500, Alex Deucher wrote: > On Tue, Nov 8, 2022 at 10:54 AM Daniel Vetter wrote: > > > > On Mon, Nov 07, 2022 at 09:25:38PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Repost of the stragglers from > > >

Re: [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-11-09 Thread Matthias Brugger
On 27/09/2022 17:27, Jason-JH.Lin wrote: After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, mmsys header can remove the useless DDP_COMPONENT_DITHER enum. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Acked-by: Matthias Brugger

Re: [PATCH v5 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-11-09 Thread Matthias Brugger
On 05/10/2022 09:08, Jason-JH.Lin wrote: Hi Matthias, Do you have any comment for this binding? Can you help us review the soc/mediatek related patches? Patches 1-3 applied now. Sorry for the late answer. Matthias Regards, Jason-JH.Lin On Wed, 2022-09-28 at 10:14 +0200,

Re: [PATCH v4] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 06:50:04PM +, Won Chung wrote: > Create a symlink pointing to USB Type-C connector for DRM connectors > when they are created. The link will be created only if the firmware is > able to describe the connection beween the two connectors. > > Currently, even if a display

Re: [Nouveau] [PATCH v7 00/23] drm: Analog TV Improvements

2022-11-09 Thread Lukas Satin
One can switch from NTSC to PAL now using (on vc4) modetest -M vc4 -s 53:720x480i -w 53:'TV mode':1 # NTSC modetest -M vc4 -s 53:720x576i -w 53:'TV mode':4 # PAL NTSC should be 640x480i, not 720. It will probably work on most TV's, but NTSC by the spec is 640x480i. On Mon, Nov 7, 2022 at

Re: [Nouveau] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-09 Thread Lukas Satin
They are important for retrogaming and connecting TV out to CRT TV or using emulator. I have PS1 that is using PAL-60 for example. Can you add 240p and 288p non-interlaced modes for NTSC and PAL, please? Lukas On Mon, Nov 7, 2022 at 3:19 PM Maxime Ripard wrote: > From: Mateusz Kwiatkowski >

Re: [Nouveau] [PATCH v7 06/23] drm/modes: Add a function to generate analog display modes

2022-11-09 Thread Lukas Satin
Hi, your statement: "However, analog display usually have fairly loose timings requirements, the only discrete parameters being the total number of lines and pixel clock frequency." Please do not make it as a rule. You said yourself: "usually". Arcade CRT have more loose timings, but

[PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread Alaa Mohamed
change min cursor size of vkms driver from 20 to 10, to increase the IGT test coverage of vkms by enabling 32x10 cursor size subtests in kms_cursor_crc Signed-off-by: Alaa Mohamed --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: delete the duplicate .set_odm_bypass initialization in dcn314_tg_funcs

2022-11-09 Thread Liu Jian
Fix below sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:244:18: warning: Initializer entry defined twice drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:257:18: also defined here Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")

Re: [PATCH v28 04/11] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2022-11-09 Thread Matthias Brugger
On 08/11/2022 20:10, Nícolas F. R. A. Prado wrote: On Tue, Nov 08, 2022 at 06:46:54PM +0100, Matthias Brugger wrote: On 07/11/2022 08:22, Nancy.Lin wrote: [..] --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -80,6 +80,12 @@ static const struct

Re: [PATCH v7 15/23] drm/modes: Introduce more named modes

2022-11-09 Thread Maxime Ripard
On Tue, Nov 08, 2022 at 10:27:17PM +0100, Mateusz Kwiatkowski wrote: > Hi Noralf, > > W dniu 8.11.2022 o 10:38, Noralf Trønnes pisze: > > > > Den 07.11.2022 19.03, skrev Noralf Trønnes: > >> > >> Den 07.11.2022 15.16, skrev Maxime Ripard: > >>> Now that we can easily extend the named modes list,

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Paul Cercueil
Hi Maxime, Le mer. 9 nov. 2022 à 11:53:01 +0100, Maxime Ripard a écrit : Hi Paul, On Sat, Nov 05, 2022 at 10:33:54AM +, Paul Cercueil wrote: Hi Maxime, Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a écrit : > Hi Paul, > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul

Re: [PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: DRM encoder type is same for eDP and DP (DRM_MODE_ENCODER_TMDS) populate is_external information in the disp_info so as to differentiate between eDP and DP on the DPU encoder side. Signed-off-by: Kalyan Thota ---

RE: [EXT] Re: [v2 06/10] drm: bridge: cadence: Add MHDP HDMI driver for i.MX8MQ

2022-11-09 Thread Sandor Yu
Thanks for your comments. > -Original Message- > From: Alexander Stein > Sent: 2022年11月8日 21:17 > To: jo...@kwiboo.se; Sandor Yu > Cc: dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; >

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Jani Nikula
On Wed, 09 Nov 2022, Aravind Iddamsetty wrote: > On XE_LPM+ platforms the media engines are carved out into a separate > GT but have a common GGTMMADR address range which essentially makes > the GGTT address space to be shared between media and render GT. As a > result any updates in GGTT shall

[PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread Alaa Emad
change min cursor size of vkms driver from 20 to 10, to increase the IGT test coverage of vkms by enabling 32x10 cursor size subtests in kms_cursor_crc Signed-off-by: Alaa Emad --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread Alaa Emad
From: Alaa Mohamed change min cursor size of vkms driver from 20 to 10, to increase the IGT test coverage of vkms by enabling 32x10 cursor size subtests in kms_cursor_crc Signed-off-by: Alaa Emad --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[v8] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-09 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few

Re: [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Signed-off-by: Kalyan Thota ---

Re: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Add color management support for the crtc provided there are enough dspps that can be allocated from the catalogue Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 15 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h

[PATCH v2] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Aravind Iddamsetty
On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. As a result any updates in GGTT shall invalidate TLB of GTs sharing it and similarly any

Re: [PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread aemad
Sorry, for the noise. I had some issues in my git send-email setup. Please, consider this version. - Alaa On 2022-11-09 12:39, Alaa Emad wrote: > change min cursor size of vkms driver from 20 to 10, to increase the IGT test > coverage of vkms by enabling 32x10 cursor size subtests in

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-09 Thread Laurent Pinchart
Hi Randy, Thank you for the patch. On Tue, Oct 18, 2022 at 11:18:28AM -0700, Randy Dunlap wrote: > When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls > from the builtin driver to the mipi driver fail due to linker > errors. > Since the RCAR_MIPI_DSI driver is not always required,

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-09 Thread Deepak R Varma
On Fri, Nov 04, 2022 at 08:12:11PM +0530, Deepak R Varma wrote: > On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > > > > I took a look, but it's pretty complex. You could take the code and > > >

[PATCH 0/3] add guard patting around i915_vma

2022-11-09 Thread Andi Shyti
Hi, This patch series adds a padding around i915_vma's reducing consequently the need to add scratch to the unused GGTT. This speeds up considerably the boot and resume by several hundreds of milliseconds up to over a full second in slower machines. Andi Chris Wilson (3): drm/i915: Wrap all

Re: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 11:18:03PM +0800, Yi Liu wrote: > On 2022/11/8 17:19, Nicolin Chen wrote: > > On Mon, Nov 07, 2022 at 08:52:44PM -0400, Jason Gunthorpe wrote: > > > > > This is on github: > > > https://github.com/jgunthorpe/linux/commits/vfio_iommufd > > [...] > > > v2: > > > - Rebase

[GIT PULL FOR v6.1] R-Car DU fixes

2022-11-09 Thread Laurent Pinchart
/pinchartl/media.git tags/drm-fixes-20221109 for you to fetch changes up to a830a15678593948f3271a5a398c9b67d8beedb9: drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI (2022-11-09 16:32:46 +0200) R-Car DSI Kconfig

Re: [PATCH 16/26] drm: panfrost: Remove #ifdef guards for PM related functions

2022-11-09 Thread Steven Price
On 07/11/2022 17:52, Paul Cercueil wrote: > Use the EXPORT_GPL_RUNTIME_DEV_PM_OPS() and pm_ptr() macros to handle > the PM callbacks. > > These macros allow the PM functions to be automatically dropped by the > compiler when CONFIG_PM is disabled, without having to use #ifdef > guards. > > This

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Kalyan Thota >Sent: Wednesday, November 9, 2022 6:53 PM >To: dmitry.barysh...@linaro.org; Kalyan Thota (QUIC) >; dri-devel@lists.freedesktop.org; linux-arm- >m...@vger.kernel.org; freedr...@lists.freedesktop.org; >devicet...@vger.kernel.org >Cc:

Re: [PATCH v7 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-09 Thread Maxime Ripard
Hi Noralf, On Mon, Nov 07, 2022 at 07:11:27PM +0100, Noralf Trønnes wrote: > > > Den 07.11.2022 15.16, skrev Maxime Ripard: > > From: Noralf Trønnes > > > > Most of the TV connectors will need a similar get_modes implementation > > that will, depending on the drivers' capabilities, register

[PULL] drm-misc-fixes

2022-11-09 Thread Maarten Lankhorst
Hey Daniel & Dave, Another small pull request. Various small assorted fixes. drm-misc-fixes-2022-11-09: drm-misc-fixes for v6.1-rc5: - HDMI fixes to vc4. - Make panfrost's uapi header compile with C++. - Add rotation quirks for 2 panels. - Fix s/r in amdgpu_vram_mgr_new - Handle 1 gb

Re: [PATCH 0/3] add guard patting around i915_vma

2022-11-09 Thread Andi Shyti
Please ignore, this series is rebased on the wrong branch. Andi On Wed, Nov 09, 2022 at 05:49:10PM +0100, Andi Shyti wrote: > Hi, > > This patch series adds a padding around i915_vma's reducing > consequently the need to add scratch to the unused GGTT. > > This speeds up considerably the boot

Re: [PATCH v7 15/23] drm/modes: Introduce more named modes

2022-11-09 Thread Noralf Trønnes
Den 07.11.2022 15.16, skrev Maxime Ripard: > Now that we can easily extend the named modes list, let's add a few more > analog TV modes that were used in the wild, and some unit tests to make > sure it works as intended. > > Signed-off-by: Maxime Ripard > > --- > Changes in v6: > - Renamed

  1   2   >