Re: [Freedreno] [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-09-22 Thread Jessica Zhang
On 8/29/2023 1:22 AM, Pekka Paalanen wrote: On Mon, 28 Aug 2023 17:05:13 -0700 Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam

Re: [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K

Re: [PATCH] drm/mst: check connector state before dereference

2023-09-22 Thread Lyude Paul
(sorry if there's been discussion on the gitlab about this or related issues, I've been trying to let amd folks handle more issues like this) Warnings would be fine but - I'm pretty sure the solution to this is already mentioned in the documentation for these functions. Explanations below On

Re: [PATCH 8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by

2023-09-22 Thread Zack Rusin
On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

[PATCH 8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr

2023-09-22 Thread Shyam Sundar S K
Make amd_pmf_set_dram_addr() as non-static so that same function can be used across files. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 14 -- drivers/platform/x86/amd/pmf/pmf.h | 1 + 2 files changed, 9 insertions(+), 6

[PATCH 01/15] platform/x86/amd/pmf: Add PMF TEE interface

2023-09-22 Thread Shyam Sundar S K
AMD PMF driver loads the PMF TA (Trusted Application) into the AMD ASP's (AMD Security Processor) TEE (Trusted Execution Environment). PMF Trusted Application is a secured firmware placed under /lib/firmware/amdtee gets loaded only when the TEE environment is initialized. Add the initial code

[PATCH 02/15] platform/x86/amd/pmf: Add support PMF-TA interaction

2023-09-22 Thread Shyam Sundar S K
PMF TA (Trusted Application) loads via the TEE environment into the AMD ASP. PMF-TA supports two commands: 1) Init: Initialize the TA with the PMF Smart PC policy binary and start the policy engine. A policy is a combination of inputs and outputs, where; - the inputs are the changing dynamics of

[PATCH 00/15] Introduce PMF Smart PC Solution Builder Feature

2023-09-22 Thread Shyam Sundar S K
Smart PC Solutions Builder allows for OEM to define a large number of custom system states to dynamically switch to. The system states are referred to as policies, and multiple policies can be loaded onto the system at any given time, however only one policy can be active at a given time. Policy

[PATCH] video: fbdev: mmp: Annotate struct mmphw_ctrl with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH] video: mmp: Annotate struct mmp_path with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Lyude Paul
Oh! wow thank you for catching this: Reviewed-by: Lyude Paul I will go and push this to drm-misc-next in just a moment On Fri, 2023-09-15 at 10:24 +0530, Ramya SR wrote: > Modeset mutex unlock is missing in drm_dp_mst_detect_port function. > This will lead to deadlock if calling the function

Re: [PATCH][V3] drm/amd/display: Remove unwanted drm edid references

2023-09-22 Thread Harry Wentland
On 2023-09-18 09:04, Alex Hung wrote: [WHY] edid_override and drm_edid_override_connector_update, according to drm documentation, should not be referred outside drm_edid. [HOW] Remove and replace them accordingly. This can tested by IGT's kms_hdmi_inject test. Signed-off-by: Alex Hung

Re: [PATCH 3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

Re: [PATCH v3 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-22 Thread Kuogee Hsieh
On 9/15/2023 5:29 PM, Dmitry Baryshkov wrote: On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() which ties irq registration to the DPU device's life cycle, while depending on resources that are released as the DP

Re: [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-09-22 Thread Lyude Paul
actually very glad to see this because I think I've seen one bug in the wild as a result of things not getting shut down :) Reviewed-by: Lyude Paul Tested-by: Lyude Paul On Thu, 2023-09-21 at 12:26 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-22 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-19 02:50:12) > On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: > > > > > > On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: > > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh > > > wrote: > > >> Add pm_runtime_force_suspend()/resume() to complete incorporating

Re: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-22 Thread Randy Dunlap
Hi Geert, On 9/22/23 00:23, Geert Uytterhoeven wrote: > Hi Randy, > > On Thu, Sep 21, 2023 at 10:43 PM Randy Dunlap wrote: >> Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: >> >> sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': >> sh7760fb.c:(.text+0x374):

Re: [PATCH 2/9] dma-heap: Add proper kref handling on dma-buf heaps

2023-09-22 Thread T.J. Mercier
On Mon, Sep 11, 2023 at 2:49 AM Christian König wrote: > > Am 11.09.23 um 04:30 schrieb Yong Wu: > > From: John Stultz > > > > Add proper refcounting on the dma_heap structure. > > While existing heaps are built-in, we may eventually > > have heaps loaded from modules, and we'll need to be > >

Re: [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 14:04, Mario Limonciello wrote: On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-22 Thread Abhinav Kumar
Hi Stephen On 9/22/2023 2:54 PM, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2023-09-19 02:50:12) On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: Add pm_runtime_force_suspend()/resume()

[PATCH] drm/amd: Fix the size of a buffer in amdgpu_vcn_idle_work_handler()

2023-09-22 Thread Christophe JAILLET
In order to be sure that fw_name is not truncated, this buffer should be at least 41 bytes long. Let the compiler compute the correct length by itself. When building with W=1, this fixes the following warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c: In function ‘amdgpu_vcn_early_init’:

[PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Shyam Sundar S K
PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary size and the address which has to be passed to

[PATCH 08/15] platform/x86/amd/pmf: Add support to update system state

2023-09-22 Thread Shyam Sundar S K
PMF driver based on the output actions from the TA can request to update the system states like entering s0i3, lock screen etc. by generating an uevent. Based on the udev rules set in the userspace the event id matching the uevent shall get updated accordingly using the systemctl. Sample udev

[PATCH 09/15] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-09-22 Thread Shyam Sundar S K
PMF driver sends constant inputs to TA which its gets via the other subsystems in the kernel. To debug certain TA issues knowing what inputs being sent to TA becomes critical. Add debug facility to the driver which can isolate Smart PC and TA related issues. Reviewed-by: Mario Limonciello

[PATCH 10/15] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-09-22 Thread Shyam Sundar S K
A policy binary is OS agnostic, and the same policies are expected to work across the OSes. At times it becomes difficult to debug when the policies inside the policy binaries starts to misbehave. Add a way to sideload such policies independently to debug them via a debugfs entry. Reviewed-by:

[PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-09-22 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K ---

[PATCH 07/15] platform/x86/amd/pmf: Add support update p3t limit

2023-09-22 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++

[PATCH 12/15] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-09-22 Thread Shyam Sundar S K
In order to provide GPU inputs to TA for the Smart PC solution to work, we need to have interface between the PMF driver and the AMDGPU driver. Add the initial code path for get interface from AMDGPU. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam

[PATCH 05/15] platform/x86/amd/pmf: change debugfs init sequence

2023-09-22 Thread Shyam Sundar S K
amd_pmf_dbgfs_register() needs to be called before amd_pmf_init_features(). Hence change the sequence. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Shyam Sundar S K
Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even before sending that to TA. Signed-off-by: Shyam

Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-22 Thread Andrew Davis
On 9/22/23 12:57 PM, Adam Jackson wrote: On Wed, Sep 6, 2023 at 5:57 AM Sarah Walker mailto:sarah.wal...@imgtec.com>> wrote: + *    :BYPASS_CACHE: There are very few situations where this flag is useful. Could you also expand on what these few useful situations are? Andrew + *   

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Imre Deak
On Fri, Sep 22, 2023 at 03:02:23PM -0400, Lyude Paul wrote: > > Oh! wow thank you for catching this: > > Reviewed-by: Lyude Paul > > I will go and push this to drm-misc-next in just a moment > > On Fri, 2023-09-15 at 10:24 +0530, Ramya SR wrote: > > Modeset mutex unlock is missing in

Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-22 Thread Adam Jackson
On Wed, Sep 6, 2023 at 5:57 AM Sarah Walker wrote: > > + *:BYPASS_CACHE: There are very few situations where this flag is > useful. > + * By default, the device flushes its memory caches after every job. > Presumably BYPASS_CACHE does something other than "after every job". Is that

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Lyude Paul
…ugh, thanks for catching that :| yes you're completely right - NAK on this patch then On Fri, 2023-09-22 at 22:22 +0300, Imre Deak wrote: > On Fri, Sep 22, 2023 at 03:02:23PM -0400, Lyude Paul wrote: > > > > Oh! wow thank you for catching this: > > > > Reviewed-by: Lyude Paul > > > > I will

[PATCH 1/3] drm/i915/guc: Support new and improved engine busyness

2023-09-22 Thread John . C . Harrison
From: John Harrison The GuC has been extended to support a much more friendly engine busyness interface. So partition the old interface into a 'busy_v1' space and add 'busy_v2' support alongside. And if v2 is available, use that in preference to v1. Note that v2 provides extra features over and

[PATCH 0/3] Engine busyness v2

2023-09-22 Thread John . C . Harrison
From: John Harrison The latest GuC implements a new and improved scheme for tracking engine busyness. So make use of it. Note that this change comes along with a new set of PMU counters. The old counters have a fundamental problem that they are defined in terms of wall time but the sampling is

[PATCH 3/3] drm/i915/mtl: Add counters for engine busyness ticks

2023-09-22 Thread John . C . Harrison
From: Umesh Nerlige Ramappa In new version of GuC engine busyness, GuC provides engine busyness ticks as a 64 bit counter. Add a new counter to relay this value to the user as is. Signed-off-by: Umesh Nerlige Ramappa Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_engine.h

[PATCH 2/3] drm/i915/mtl: Add a PMU counter for total active ticks

2023-09-22 Thread John . C . Harrison
From: Umesh Nerlige Ramappa Current engine busyness interface exposed by GuC has a few issues: - The busyness of active engine is calculated using 2 values provided by GuC and is prone to race between CPU reading those values and GuC updating them. Any sort of HW synchronization would be at

[PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 0/9] drm: Annotate structs with __counted_by

2023-09-22 Thread Kees Cook
Hi, This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

[PATCH 3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 7/9] drm/virtio: Annotate struct virtio_gpu_object_array with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

Re: [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Alex Deucher
On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Alex Deucher
On Fri, Sep 22, 2023 at 1:33 PM Kees Cook wrote: > > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

[PATCH 9/9] drm/v3d: Annotate struct v3d_perfmon with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH] accel/ivpu: Annotate struct ivpu_job with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

Re: [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via

Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even

Re: [PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

[PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-09-22 Thread Shyam Sundar S K
For the Smart PC Solution to fully work, it has to enact to the actions coming from TA. Add the initial code path for set interface to AMDGPU. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 21

[PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by:

[PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

Re: [PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

[Bug 201957] amdgpu: ring gfx timeout

2023-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 KC (kco...@gmail.com) changed: What|Removed |Added CC||kco...@gmail.com --- Comment #91

Re: [PATCH v4 5/7] drm: ci: Update xfails

2023-09-22 Thread Helen Koike
Hi o/ On 14/09/2023 05:54, Vignesh Raman wrote: Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the

Re: [git pull] drm fixes for 6.6-rc3

2023-09-22 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Sep 2023 16:14:46 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b41b28366d3b176c8297961de4f095f2e392402d Thank you! -- Deet-doot-dot, I am a bot.

[PATCH v2 0/2] drm/ci: Update Mesa and Introduce VKMS Support

2023-09-22 Thread Helen Koike
This patchset offers two enhancements to drm/ci: 1. Mesa Version Update. drm/ci re-uses components from Mesa project. A recent bug in MesaCI was fixed. The first patch updates drm/ci Mesa's version, re-allowing containers rebuilds when uncached, essencial for new runs. 2. VKMS Driver Testing,

[PATCH v2 2/2] drm/ci: add tests on vkms

2023-09-22 Thread Helen Koike
Add job that runs igt on top of vkms. Signed-off-by: Helen Koike --- See pipeline: https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/990494 v2: - do not mv modules to /lib/modules in the job definition, leave it to crosvm-runner.sh --- MAINTAINERS

[PATCH v2 1/2] drm/ci: uprev mesa version - fix container build

2023-09-22 Thread Helen Koike
When building containers, some rust packages were installed without locking the dependencies version, which got updated and started giving errors like: error: failed to compile `bindgen-cli v0.62.0`, intermediate artifacts can be found at `/tmp/cargo-installkNKRwf` Caused by: package `rustix

Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection

2023-09-22 Thread Jani Nikula
On Tue, 19 Sep 2023, Chen-Yu Tsai wrote: > On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula wrote: >> >> On Fri, 15 Sep 2023, Chen-Yu Tsai wrote: >> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula wrote: >> >> >> >> The sads returned by drm_edid_to_sad() needs to be freed. >> >> >> >> Fixes:

Re: [PATCH v6 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:53, Tvrtko Ursulin wrote: > >On 20/09/2023 00:34, Adrián Larumbe wrote: >> Some BO's might be mapped onto physical memory chunkwise and on demand, >> like Panfrost's tiler heap. In this case, even though the >> drm_gem_shmem_object page array might already be allocated, only a

Re: [PATCH drm-misc-next v4 7/8] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:40 +0200 Danilo Krummrich wrote: > + /** > + * @DRM_GPUVM_RESV_PROTECTED: GPUVM is protected externally by the > + * GPUVM's _resv lock I think we need to be more specific, and list the fields/operations that need to be externally protected when

Re: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-22 Thread Maxime Ripard
On Thu, Sep 21, 2023 at 10:41:43AM +0300, Jani Nikula wrote: > On Wed, 13 Sep 2023, Mitul Golani > wrote: > > From: Ankit Nautiyal > > > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > > > > Signed-off-by: Ankit Nautiyal > > Maarten, Maxime, Thomas, ack for merging

Re: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-22 Thread Jani Nikula
On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: > On 21-Sep-23 5:44 PM, Jani Nikula wrote: >> On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: >>> On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: > From: Swati Sharma > > DSC_Sink_BPP_Precision

Re: Decrypting tt maps in ttm

2023-09-22 Thread Christian König
Am 21.09.23 um 09:12 schrieb Thomas Hellström: On 9/21/23 05:51, Zack Rusin wrote: On Wed, 2023-09-20 at 21:22 +0200, Thomas Hellström wrote: !! External Email On 9/20/23 20:24, Zack Rusin wrote: On Wed, 2023-09-20 at 19:17 +0200, Thomas Hellström wrote: !! External Email Hi, Zack On

Re: [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:40, Tvrtko Ursulin wrote: >On 20/09/2023 00:34, Adrián Larumbe wrote: >> The drm-stats fdinfo tags made available to user space are drm-engine, >> drm-cycles, drm-max-freq and drm-curfreq, one per job slot. >> >> This deviates from standard practice in other DRM drivers, where a

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Tvrtko Ursulin
On 22/09/2023 09:48, Iddamsetty, Aravind wrote: On 21-09-2023 17:18, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory

Re: [PATCH drm-misc-next v4 6/8] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:39 +0200 Danilo Krummrich wrote: > void drm_gpuvm_init(struct drm_gpuvm *gpuvm, struct drm_device *drm, > - const char *name, > + const char *name, enum drm_gpuva_flags flags, s/drm_gpuva_flags/drm_gpuvm_flags/gc

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Andi Shyti
Hi Tvrtko, On Thu, Sep 21, 2023 at 12:48:52PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the newly added drm_print_memory_stats helper to show memory > utilisation of our objects in drm/driver specific fdinfo output. > > To collect the stats we walk the per memory regions

Re: [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-22 Thread Adrián Larumbe
On 21.09.2023 11:14, Tvrtko Ursulin wrote: > >On 20/09/2023 16:32, Tvrtko Ursulin wrote: >> >> On 20/09/2023 00:34, Adrián Larumbe wrote: >> > The current implementation will try to pick the highest available size >> > display unit as soon as the BO size exceeds that of the previous >> >

Re: [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:32, Tvrtko Ursulin wrote: > >On 20/09/2023 00:34, Adrián Larumbe wrote: >> The current implementation will try to pick the highest available size >> display unit as soon as the BO size exceeds that of the previous >> multiplier. That can lead to loss of precision in contexts of

[PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
For the no-interrupt design (sink device is panel, polling HPD status when chip power on), anx7625 FW has more than 200ms HPD de-bounce time in FW, for the safety to get HPD status, driver better to wait 200ms before HPD detection after OS resume back. Signed-off-by: Xin Ji ---

Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks

2023-09-22 Thread Javier Martinez Canillas
"Maxime Ripard" writes: > On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote: >> The driver uses a naming convention where functions for struct drm_*_funcs >> callbacks are named ssd130x_$object_$operation, while the callbacks for >> struct drm_*_helper_funcs are named

RE: [PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-22 Thread Ying Liu
On Friday, September 22, 2023 4:03 AM Lucas Stach wrote: > drm_atomic_helper_commit_tail_rpm makes it hard for drivers to follow > the documented encoder/bridge enable flow, as it commits all CRTC enables > before the planes are fully set up, so drivers that can't enable the > display link

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-22 Thread H. Nikolaus Schaller
Hi, I have tested this on an OMAP5 Pyra. > Am 21.09.2023 um 12:50 schrieb Tomi Valkeinen > : > > It's been reported that DSI host driver's detach can be called without > the attach ever happening: > > https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ > This patch works

Re: [PATCH drm-misc-next v4 6/8] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:39 +0200 Danilo Krummrich wrote: > +/** > + * enum drm_gpuvm_flags - flags for struct drm_gpuvm > + */ > +enum drm_gpuvm_flags { > + /** > + * @DRM_GPUVM_USERBITS: user defined bits > + */ > + DRM_GPUVM_USERBITS = (1 << 0), Nit: I tried declaring

drm fixes for 6.6-rc3 (resend with one more patch)

2023-09-22 Thread Dave Airlie
Hi Linus (again), It's been one of those weeks, and I somehow managed to forget the actual newsworthy item in this fixes pull. Ben Skeggs is stepping away from nouveau and Red Hat for personal reasons, he'll be missed and we intend to fill the gaps in the upcoming time with Danilo and Lyude

[PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

2023-09-22 Thread Wolfram Sang
Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device core"), we can rely on device core for setting the default pins. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH v5 1/5] fbdev: Avoid file argument in fb_pgprotect()

2023-09-22 Thread Thomas Zimmermann
Only PowerPC's fb_pgprotect() needs the file argument, although the implementation in either phys_mem_access_prot() or pci_phys_mem_access_prot() does not use it. Pass NULL to the internal helper in preparation of further updates. A later patch will remove the file parameter from fb_pgprotect().

[PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-09-22 Thread Thomas Zimmermann
Clean up and rename fb_pgprotect() to work without struct file. Then refactor the implementation for PowerPC. This change has been discussed at [1] in the context of refactoring fbdev's mmap code. The first two patches update fbdev and replace fbdev's fb_pgprotect() with pgprot_framebuffer() on

[PATCH v5 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()

2023-09-22 Thread Thomas Zimmermann
Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). The helper sets VMA page-access flags for framebuffers in device I/O memory. Also clean up the helper's parameters and return value. Instead of the VMA instance, pass the individial parameters separately: existing page-access

[PATCH v5 3/5] arch/powerpc: Remove trailing whitespaces

2023-09-22 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Philippe Mathieu-Daudé --- arch/powerpc/include/asm/machdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/include/asm/machdep.h

[PATCH v5 4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code

2023-09-22 Thread Thomas Zimmermann
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot and its implementation in pci_phys_mem_access_prot(). The file is not used on PowerPC. By removing it, a later patch can simplify fbdev's mmap code, which uses phys_mem_access_prot() on PowerPC. Signed-off-by: Thomas

RE: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
Hi Laurent Pinchart, thanks for reviewing, I'll update the new patch, thanks! Xin > -Original Message- > From: Laurent Pinchart > Sent: Thursday, September 21, 2023 8:13 PM > To: Jani Nikula > Cc: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Jonas Karlman ; Jernej Skrabec

Re: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-22 Thread Geert Uytterhoeven
Hi Randy, On Thu, Sep 21, 2023 at 10:43 PM Randy Dunlap wrote: > Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: > > sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': > sh7760fb.c:(.text+0x374): undefined reference to `framebuffer_alloc' > sh2-linux-ld:

Re: [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect()

2023-09-22 Thread Thomas Zimmermann
Hi Javier Am 20.09.23 um 10:01 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Only PowerPC's fb_pgprotect() needs the file argument, although the implementation does not use it. Pass NULL to the internal Can you please mention the function that's the

Re: WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-22 Thread Rafał Miłecki
On 21.09.2023 21:52, Deucher, Alexander wrote: backporting commit 187916e6ed9d ("drm/amdgpu: install stub fence into potential unused fence pointers") to stable kernels resulted in lots of WARNINGs on some devices. In my case I was getting 3 WARNINGs per second (~150 lines logged every second).

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Iddamsetty, Aravind
On 21-09-2023 17:18, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the newly added drm_print_memory_stats helper to show memory > utilisation of our objects in drm/driver specific fdinfo output. > > To collect the stats we walk the per memory regions object lists > and accumulate

Re: [PATCH v5 04/11] PM / QoS: Decouple request alloc from dev_pm_qos_mtx

2023-09-22 Thread kernel test robot
e at: https://download.01.org/0day-ci/archive/20230922/202309221426.fb0fe750-oliver.s...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Laurentiu Palcu
Hi, On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be

RE: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
Hi Jani Nikula, thanks for reviewing, I'll use msleep instead, thanks! Xin > -Original Message- > From: Jani Nikula > Sent: Thursday, September 21, 2023 8:09 PM > To: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman > ; Jernej Skrabec ; David

Re: [PATCH v2] drm: renesas: rcar-du: use proper naming for R-Car

2023-09-22 Thread Geert Uytterhoeven
On Fri, Sep 22, 2023 at 2:58 AM Wolfram Sang wrote: > Not RCAR, but R-Car. > > Signed-off-by: Wolfram Sang > Reviewed-by: Kieran Bingham > --- > > Changes since v1: > * rebased to 6.6-rc2 > * added tag from Kieran (Thanks!) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

  1   2   >