Re: [PATCH 1/2] fb: amifb: Mark driver struct with __refdata to prevent section mismatch warning

2023-11-10 Thread Uwe Kleine-König
Hello, On Fri, Nov 10, 2023 at 08:58:37AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 9, 2023 at 11:02 PM Uwe Kleine-König > wrote: > > As described in the added code comment, a reference to .exit.text is ok > > for drivers registered via module_platform_driver_probe(). Make this > > explicit

[REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-10 Thread Owen T. Heisler
#regzbot introduced: 89c290ea758911e660878e26270e084d862c03b0 #regzbot link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/273 #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=218124 ## Reproducing 1. Boot system to framebuffer console. 2. Run `systemctl suspend`. If undocked

[PATCH 0/1] Fix access violation in mtk_drm_crtc_dma_dev_get

2023-11-10 Thread Stuart Lee
Add error handling to check NULL input in mtk_drm_crtc_dma_dev_get function. While display path is not configured correctly, none of crtc is established. So the caller of mtk_drm_crtc_dma_dev_get may pass input parameter *crtc as NULL, Which may cause coredump when we try to get the container of

[PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get

2023-11-10 Thread Stuart Lee
Add error handling to check NULL input in mtk_drm_crtc_dma_dev_get function. While display path is not configured correctly, none of crtc is established. So the caller of mtk_drm_crtc_dma_dev_get may pass input parameter *crtc as NULL, Which may cause coredump when we try to get the container of

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Sebastian Wick
On Thu, Nov 09, 2023 at 06:38:20PM +, Dave Stevenson wrote: > Hi Simon > > On Thu, 9 Nov 2023 at 17:46, Simon Ser wrote: > > > > On Thursday, November 9th, 2023 at 16:42, Dave Stevenson > > wrote: > > > > > > > - What would be a good name for the heap? "vc4" is maybe a bit naive > > > > >

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-10 Thread Mina Almasry
On Thu, Nov 9, 2023 at 11:38 PM Yunsheng Lin wrote: > > On 2023/11/10 10:59, Mina Almasry wrote: > > On Thu, Nov 9, 2023 at 12:30 AM Paolo Abeni wrote: > >> > >> I'm trying to wrap my head around the whole infra... the above line is > >> confusing. Why do you increment dma_addr? it will be

[Bug 217872] RIP: 0010:amdgpu_vm_pde_update [amdgpu]

2023-11-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217872 b...@duck.com changed: What|Removed |Added CC||b...@duck.com --- Comment #2 from

RE: [PATCH v9 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-11-10 Thread Manna, Animesh
> -Original Message- > From: Nikula, Jani > Sent: Thursday, November 9, 2023 6:37 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Manna, Animesh ; Hogander, Jouni > ; Murthy, Arun R > Subject: Re: [PATCH v9 1/6] drm/panelreplay: dpcd

Re: [PATCH] drm/amd/pm: make power values signed

2023-11-10 Thread Lazar, Lijo
On 11/9/2023 2:11 PM, José Pekkarinen wrote: The following patch will convert the power values returned by amdgpu_hwmon_get_power to signed, fixing the following warnings reported by coccinelle: drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING: Unsigned expression compared with zero:

[PATCH] drm/panel: boe-tv101wum-nl6: Fine tune Himax83102-j02 panel HFP and HBP

2023-11-10 Thread Cong Yang
The refresh reported by modotest is 60.46Hz, and the actual measurement is 60.01Hz, which is outside the expected tolerance. Adjust hporch and pixel clock to fix it. After repair, modetest and actual measurement were all 60.01Hz. Fixes: 1bc2ef065f13 ("drm/panel: Support for Starry-himax83102-j02

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Christian König
Am 09.11.23 um 19:34 schrieb Danilo Krummrich: On 11/9/23 17:03, Christian König wrote: Am 09.11.23 um 16:50 schrieb Thomas Hellström: [SNIP] Did we get any resolution on this? FWIW, my take on this is that it would be possible to get GPUVM to work both with and without internal

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Thomas Hellström
On 11/10/23 09:50, Christian König wrote: Am 09.11.23 um 19:34 schrieb Danilo Krummrich: On 11/9/23 17:03, Christian König wrote: Am 09.11.23 um 16:50 schrieb Thomas Hellström: [SNIP] Did we get any resolution on this? FWIW, my take on this is that it would be possible to get GPUVM to

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Thomas Hellström
On 11/10/23 11:42, Christian König wrote: Am 10.11.23 um 10:39 schrieb Thomas Hellström: [SNIP] I was thinking more of the general design of a base-class that needs to be refcounted. Say a driver vm that inherits from gpu-vm, gem_object and yet another base-class that supplies its own

[PATCH] Remove custom dumb_map_offset implementations in i915 driver

2023-11-10 Thread Dipam Turkar
Making i915 use drm_gem_create_mmap_offset() instead of its custom implementations for associating GEM object with a fake offset. Signed-off-by: Dipam Turkar --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 192 --- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 4 -

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Simon Ser
On Thursday, November 9th, 2023 at 20:09, Maxime Ripard wrote: > On Thu, Nov 09, 2023 at 03:31:44PM +, Simon Ser wrote: > > > > - What would be a good name for the heap? "vc4" is maybe a bit naive and > > > > not precise enough. Something with "cma"? Do we need to plan a naming > > > >

Re: [PATCH drm-misc-next v9 02/12] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow()

2023-11-10 Thread Boris Brezillon
On Wed, 8 Nov 2023 01:12:32 +0100 Danilo Krummrich wrote: > Don't always WARN in drm_gpuvm_check_overflow() and separate it into a > drm_gpuvm_check_overflow() and a dedicated > drm_gpuvm_warn_check_overflow() variant. > > This avoids printing warnings due to invalid userspace requests. > >

Re: [PATCH drm-misc-next v9 03/12] drm/gpuvm: export drm_gpuvm_range_valid()

2023-11-10 Thread Boris Brezillon
On Wed, 8 Nov 2023 01:12:33 +0100 Danilo Krummrich wrote: > Drivers may use this function to validate userspace requests in advance, > hence export it. > > Reviewed-by: Thomas Hellström > Signed-off-by: Danilo Krummrich Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/drm_gpuvm.c |

Re: [RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > Whenever a correctable or an uncorrectable error happens an event is sent > to the corresponding listeners of these groups. > > v2: Rebase > > Signed-off-by: Aravind Iddamsetty > --- > drivers/gpu/drm/xe/xe_hw_error.c | 33

Re: [PATCH V2 3/4] dt-bindings: arm: rockchip: Add Powkiddy RK2023

2023-11-10 Thread Krzysztof Kozlowski
On 09/11/2023 22:50, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > powered by the Rockchip RK3566 SoC. Group the Powkiddy RK3566 based > devices together as they are both extremely similar. > > Signed-off-by: Chris Morgan >

Re: [PATCH V2 1/4] dt-bindings: display: panel: Update NewVision NV3051D compatibles

2023-11-10 Thread Krzysztof Kozlowski
On 09/11/2023 22:50, Chris Morgan wrote: > From: Chris Morgan > > Update the NewVision NV3051D compatible strings by adding a new panel, > the powkiddy,rk2023-panel, and removing another entry, the > anbernic,rg353v-panel. The rg353v-panel is exactly identical to the > rg353p-panel and is not

Re: [PATCH 1/2] fb: amifb: Mark driver struct with __refdata to prevent section mismatch warning

2023-11-10 Thread Geert Uytterhoeven
Hi Uwe, On Fri, Nov 10, 2023 at 9:57 AM Uwe Kleine-König wrote: > On Fri, Nov 10, 2023 at 08:58:37AM +0100, Geert Uytterhoeven wrote: > > On Thu, Nov 9, 2023 at 11:02 PM Uwe Kleine-König > > wrote: > > > As described in the added code comment, a reference to .exit.text is ok > > > for drivers

Re: [PATCH v18 14/26] drm/lima: Explicitly get and put drm-shmem pages

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:53 +0300 Dmitry Osipenko wrote: > To simplify the drm-shmem refcnt handling, we're moving away from > the implicit get_pages() that is used by get_pages_sgt(). From now on > drivers will have to pin pages while they use sgt. Lima driver doesn't > have shrinker, hence

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:54 +0300 Dmitry Osipenko wrote: > To simplify the drm-shmem refcnt handling, we're moving away from > the implicit get_pages() that is used by get_pages_sgt(). From now on > drivers will have to pin pages while they use sgt. Panfrost's shrinker > doesn't support

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-10 Thread Hans de Goede
Hi All, On 11/10/23 07:09, Kai-Heng Feng wrote: > Hi Owen, > > On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler wrote: >> >> #regzbot introduced: 89c290ea758911e660878e26270e084d862c03b0 >> #regzbot link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/273 >> #regzbot link:

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-11-10 Thread Arthur Grillo
On 08/11/23 13:36, Harry Wentland wrote: > When the floor LUT index (drm_fixp2int(lut_index) is the last > index of the array the ceil LUT index will point to an entry > beyond the array. Make sure we guard against it and use the > value of the floor LUT index. > > v3: > - Drop bits from

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-10 Thread Kai-Heng Feng
Hi Hans, On Fri, Nov 10, 2023 at 2:19 PM Hans de Goede wrote: > > Hi All, > > On 11/10/23 07:09, Kai-Heng Feng wrote: > > Hi Owen, > > > > On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler wrote: > >> > >> #regzbot introduced: 89c290ea758911e660878e26270e084d862c03b0 > >> #regzbot link:

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-10 Thread Vincenzo Frascino
Hi Arnd, On 11/8/23 12:58, Arnd Bergmann wrote: > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. > > Without a prototype, this now causes warnings

Re: [PATCH v18 12/26] drm/shmem-helper: Make drm_gem_shmem_get_pages() public

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:51 +0300 Dmitry Osipenko wrote: > We're going to move away from having implicit get_pages() done by > get_pages_sgt() to ease simplify refcnt handling. Drivers will manage Nit: ease or simplify, not both. > get/put_pages() by themselves. Expose the

Re: [PATCH 5/6] drm/plane: Extend damage tracking kernel-doc

2023-11-10 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Simon Ser
On Thursday, November 9th, 2023 at 19:38, Dave Stevenson wrote: > Hi Simon > > On Thu, 9 Nov 2023 at 17:46, Simon Ser wrote: > > > > On Thursday, November 9th, 2023 at 16:42, Dave Stevenson > > wrote: > > > > > > > - What would be a good name for the heap? "vc4" is maybe a bit naive > > >

[PATCH] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2023-11-10 Thread Dipam Turkar
Introduce unit tests for the drm_mode_create_dvi_i_properties() function to ensure the proper creation of DVI-I specific connector properties. Signed-off-by: Dipam Turkar --- drivers/gpu/drm/tests/drm_connector_test.c | 20 1 file changed, 20 insertions(+) diff --git

Re: [PATCH v18 18/26] drm/shmem-helper: Change sgt allocation policy

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:57 +0300 Dmitry Osipenko wrote: > In a preparation to addition of drm-shmem memory shrinker support, change > the SGT allocation policy in this way: > > 1. SGT can be allocated only if shmem pages are pinned at the > time of allocation, otherwise allocation fails. > >

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > Define the netlink registration interface and commands, attributes that > can be commonly used across by drm drivers. This patch intends to use > the generic netlink family to expose various stats of device. At present > it defines some commands

Re: [PATCH V2 4/4] arm64: dts: rockchip: add Powkiddy RK2023

2023-11-10 Thread Krzysztof Kozlowski
On 09/11/2023 22:50, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RK2023. The Powkiddy RK2023 is a handheld > gaming device with a 3.5 inch screen powered by the Rockchip RK3566 > SoC. The device is almost identical to the Anbernic RG353P except it > lacks eMMC, a

Re: [PATCH v18 05/26] drm/shmem-helper: Remove obsoleted is_iomem test

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:44 +0300 Dmitry Osipenko wrote: > Everything that uses the mapped buffer should be agnostic to is_iomem. > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove > the

[PATCH 05/11] drm/i915/dsc/mtl: Add support for fractional bpp

2023-11-10 Thread Ankit Nautiyal
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng ---

[PATCH 07/11] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-11-10 Thread Ankit Nautiyal
From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is set then while iterating over output bpp with fractional step size we will continue if

[PATCH 06/11] drm/i915/dp: Iterate over output bpp with fractional step size

2023-11-10 Thread Ankit Nautiyal
This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng ---

[PATCH 09/11] drm/i915/dp_mst: Use precision of 1/16 for computing bpp

2023-11-10 Thread Ankit Nautiyal
Modify the functions to deal with bpps with 1/16 precision. This will make way for cases when DSC with fractional bpp is used. For bpp without DSC, there is no change, as we still use whole numbers. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 56

[PATCH 04/11] drm/i915/audio: Consider fractional vdsc bpp while computing tu_data

2023-11-10 Thread Ankit Nautiyal
MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fix tu_data calculation while dealing with U6.4 format. (Stan) v3: -Use

[PATCH 03/11] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-11-10 Thread Ankit Nautiyal
MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. v1: Replace the computation of 'data_clock' with 'data_clock = DIV_ROUND_UP(data_clock, 16).' (Sui Jingfeng). v2:

[PATCH 02/11] drm/i915/display: Store compressed bpp in U6.4 format

2023-11-10 Thread Ankit Nautiyal
DSC parameter bits_per_pixel is stored in U6.4 format. The 4 bits represent the fractional part of the bpp. Currently we use compressed_bpp member of dsc structure to store only the integral part of the bits_per_pixel. To store the full bits_per_pixel along with the fractional part, compressed_bpp

[PATCH 01/11] drm/display/dp: Add helper function to get DSC bpp precision

2023-11-10 Thread Ankit Nautiyal
Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng Acked-by: Maxime Ripard --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h |

[PATCH 08/11] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-11-10 Thread Ankit Nautiyal
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by:

[PATCH 10/11] drm/i916/dp_mst: Iterate over the DSC bpps as per DSC precision support

2023-11-10 Thread Ankit Nautiyal
Currently we iterate over the bpp_x16 in step of 16. Use DSC fractional bpp precision supported by the sink to compute the appropriate steps to iterate over the bpps. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 11/11] drm/i915/dp_mst: Add support for forcing dsc fractional bpp via debugfs

2023-11-10 Thread Ankit Nautiyal
If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 14 +++--- 1 file changed, 11

Re: [PATCH v18 11/26] drm/shmem-helper: Prepare drm_gem_shmem_free() to shrinker addition

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:50 +0300 Dmitry Osipenko wrote: > Prepare drm_gem_shmem_free() to addition of memory shrinker support > to drm-shmem by adding and using variant of put_pages() that doesn't > touch reservation lock. Reservation shouldn't be touched because lockdep > will trigger a bogus

[PATCH 00/11] Add DSC fractional bpp support

2023-11-10 Thread Ankit Nautiyal
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series:

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Christian König
Am 10.11.23 um 10:39 schrieb Thomas Hellström: [SNIP] I was thinking more of the general design of a base-class that needs to be refcounted. Say a driver vm that inherits from gpu-vm, gem_object and yet another base-class that supplies its own refcount. What's the best-practice way to do

Re: [PATCH drm-misc-next v9 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Boris Brezillon
On Wed, 8 Nov 2023 01:12:39 +0100 Danilo Krummrich wrote: > Implement reference counting for struct drm_gpuvm. > > Signed-off-by: Danilo Krummrich Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/drm_gpuvm.c| 56 +- >

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Simon Ser
On Thursday, November 9th, 2023 at 20:17, Maxime Ripard wrote: > > Can we add another function pointer to the struct drm_driver (or > > similar) to do the allocation, and move the actual dmabuf handling > > code into the core? > > Yeah, I agree here, it just seems easier to provide a global

RE: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-10 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Thursday, November 9, 2023 5:26 PM > To: Shankar, Uma > Cc: Joshua Ashton ; Harry Wentland > ; dri-devel@lists.freedesktop.org; Sebastian Wick > ; Sasha McIntosh ; > Abhinav Kumar ; Shashank Sharma > ; Xaver Hugl ; Hector > Martin ;

Re: [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get

2023-11-10 Thread AngeloGioacchino Del Regno
Il 10/11/23 02:29, Stuart Lee ha scritto: Add error handling to check NULL input in mtk_drm_crtc_dma_dev_get function. While display path is not configured correctly, none of crtc is established. So the caller of mtk_drm_crtc_dma_dev_get may pass input parameter *crtc as NULL, Which may cause

Re: [RFC v3 3/5] drm/xe/RAS: Expose the error counters

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > We expose the various error counters supported on a hardware via genl > subsytem through the registered commands to userspace. The > DRM_RAS_CMD_QUERY lists the error names with config id, > DRM_RAD_CMD_READ_ONE returns the counter value for the

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-10 Thread Jani Nikula
On Thu, 09 Nov 2023, Luben Tuikov wrote: > Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially > when no devices are available. This makes it easier to browse kernel logs. Please do not merge patches before people have actually had a chance to look at them. This was

Re: [PATCH drm-misc-next v9 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Thomas Hellström
On 11/8/23 01:12, Danilo Krummrich wrote: Implement reference counting for struct drm_gpuvm. Signed-off-by: Danilo Krummrich Reviewed-by: Thomas Hellström --- drivers/gpu/drm/drm_gpuvm.c| 56 +- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 20

Re: [PATCH 6/6] drm/todo: Add entry about implementing buffer age for damage tracking

2023-11-10 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v18 17/26] drm/v3d: Explicitly get and put drm-shmem pages

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:56 +0300 Dmitry Osipenko wrote: > To simplify the drm-shmem refcnt handling, we're moving away from > the implicit get_pages() that is used by get_pages_sgt(). From now on > drivers will have to pin pages while they use sgt. V3D driver doesn't > support shrinker, hence

[PATCH] vgacon: drop IA64 reference in VGA_CONSOLE dependency list

2023-11-10 Thread Lukas Bulwahn
Commit e9e3300b6e77 ("vgacon: rework Kconfig dependencies") turns the dependencies into a positive list of supported architectures, which includes the IA64 architecture, but in the meantime, this architecture is removed in commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture"). Drop

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > Our hardware supports RAS(Reliability, Availability, Serviceability) by > reporting the errors to the host, which the KMD processes and exposes a > set of error counters which can be used by observability tools to take > corrective actions or

Re: [PATCH v6 2/8] drm/ttm/tests: Add tests for ttm_tt

2023-11-10 Thread kernel test robot
Hi Karolina, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.6 next-20231110

Re: [PATCH v3 5/6] drm/panfrost: Implement ability to turn on/off regulators in suspend

2023-11-10 Thread Steven Price
On 09/11/2023 10:25, AngeloGioacchino Del Regno wrote: > Some platforms/SoCs can power off the GPU entirely by completely cutting > off power, greatly enhancing battery time during system suspend: add a > new pm_feature GPU_PM_VREG_OFF to allow turning off the GPU regulators > during full suspend

Re: [PATCH v3 6/6] drm/panfrost: Set regulators on/off during system sleep on MediaTek SoCs

2023-11-10 Thread Steven Price
On 09/11/2023 10:25, AngeloGioacchino Del Regno wrote: > All of the MediaTek SoCs supported by Panfrost can completely cut power > to the GPU during full system sleep without any user-noticeable delay > in the resume operation, as shown by measurements taken on multiple > MediaTek SoCs

Re: [PATCH V2 4/4] arm64: dts: rockchip: add Powkiddy RK2023

2023-11-10 Thread Chris Morgan
On Fri, Nov 10, 2023 at 02:14:23PM +0100, Krzysztof Kozlowski wrote: > On 09/11/2023 22:50, Chris Morgan wrote: > > From: Chris Morgan > > > > Add support for the Powkiddy RK2023. The Powkiddy RK2023 is a handheld > > gaming device with a 3.5 inch screen powered by the Rockchip RK3566 > > SoC.

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-10 Thread Pavel Begunkov
On 11/7/23 23:03, Mina Almasry wrote: On Tue, Nov 7, 2023 at 2:55 PM David Ahern wrote: On 11/7/23 3:10 PM, Mina Almasry wrote: On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: On 11/5/23 7:44 PM, Mina Almasry wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h

Re: [PATCH V2 4/4] arm64: dts: rockchip: add Powkiddy RK2023

2023-11-10 Thread Krzysztof Kozlowski
On 10/11/2023 15:30, Chris Morgan wrote: > On Fri, Nov 10, 2023 at 02:14:23PM +0100, Krzysztof Kozlowski wrote: >>> + >>> +/delete-node/ _keys; >>> + >>> + { >>> + /delete-property/ stdout-path; >>> +}; >> >> If you have to delete so many nodes and properties, this means your >> common DTSI is

Re: [PATCH v18 16/26] drm/virtio: Explicitly get and put drm-shmem pages

2023-11-10 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:01:55 +0300 Dmitry Osipenko wrote: > We're moving away from implicit get_pages() that is done by > get_pages_sgt() to simplify the refcnt handling. Drivers will have > to pin pages while they use sgt. VirtIO-GPU doesn't support shrinker, > hence pages are pinned and sgt is

Re: [PATCH] Remove custom dumb_map_offset implementations in i915 driver

2023-11-10 Thread Tvrtko Ursulin
On 10/11/2023 10:58, Dipam Turkar wrote: Making i915 use drm_gem_create_mmap_offset() instead of its custom implementations for associating GEM object with a fake offset. Does it compile? Regards, Tvrtko Signed-off-by: Dipam Turkar --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 192

Re: [PATCH] drm/amd/pm: make power values signed

2023-11-10 Thread José Pekkarinen
On 2023-11-10 10:25, Lazar, Lijo wrote: On 11/9/2023 2:11 PM, José Pekkarinen wrote: The following patch will convert the power values returned by amdgpu_hwmon_get_power to signed, fixing the following warnings reported by coccinelle: drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING:

Re: [PATCH] vgacon: drop IA64 reference in VGA_CONSOLE dependency list

2023-11-10 Thread Javier Martinez Canillas
Lukas Bulwahn writes: > Commit e9e3300b6e77 ("vgacon: rework Kconfig dependencies") turns the > dependencies into a positive list of supported architectures, which > includes the IA64 architecture, but in the meantime, this architecture is > removed in commit cf8e8658100d ("arch: Remove Itanium

Design question backlight controller powered by bridge

2023-11-10 Thread Fuzzey, Martin
Hi all, I have a design problem I'm not sure how to solve cleanly. I have a board using a PTN3460 eDP => LVDS bridge and a LP8556 backlight controller. Both of these are already supported by the kernel. The PTN3460 has an electrical output signal (PVCGEN) that is intended to control power to

Re: [PATCH 04/22] [RESEND] time: make sysfs_get_uname() function visible in header

2023-11-10 Thread Uwe Kleine-König
Hello Arnd, On Wed, Nov 08, 2023 at 01:58:25PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > This function is defined globally in clocksource.c and used conditionally > in clockevent.c, which the declaration hidden when clockevent support s/which/with/ ? > is disabled. This causes a

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-10 Thread Jani Nikula
On Fri, 10 Nov 2023, Jani Nikula wrote: > On Thu, 09 Nov 2023, Luben Tuikov wrote: >> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially >> when no devices are available. This makes it easier to browse kernel logs. > > Please do not merge patches before people have

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Maxime Ripard
On Fri, Nov 10, 2023 at 11:21:15AM +, Simon Ser wrote: > On Thursday, November 9th, 2023 at 20:17, Maxime Ripard > wrote: > > > > Can we add another function pointer to the struct drm_driver (or > > > similar) to do the allocation, and move the actual dmabuf handling > > > code into the

Re: [PATCH] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2023-11-10 Thread Maxime Ripard
Hi, On Fri, Nov 10, 2023 at 04:33:23PM +0530, Dipam Turkar wrote: > Introduce unit tests for the drm_mode_create_dvi_i_properties() function to > ensure > the proper creation of DVI-I specific connector properties. > > Signed-off-by: Dipam Turkar > --- >

Re: [PATCH v3 0/6] drm/panfrost: Turn off clocks and regulators in PM

2023-11-10 Thread Steven Price
On 09/11/2023 10:25, AngeloGioacchino Del Regno wrote: > Changes in v3: > - Fixed the order of set_opp/opp_put in patch [5/6] > - Clearly specified MediaTek SoC models in patches [4/6], [6/6] > - Reordered clk_disable() for suspend in patch [3/6] > - Fixed blank line removal and alignment in

Re: [PATCH] drm/panel: auo, b101uan08.3: Fine tune the panel power sequence

2023-11-10 Thread Doug Anderson
Hi, On Thu, Nov 9, 2023 at 1:26 AM Xuxin Xiong wrote: > > For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that > MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. > > BUG=b:309908277 > TEST=emerge-kukui chromeos-kernel-5_10 BUG= and TEST= are not

[PATCH i-g-t 2/2] tests/kms_async_flips: Add test for atomic prop changes

2023-11-10 Thread André Almeida
DRM atomic API should reject modesetting during an async flip, so test if the kernel properly rejects to flip with prop changes. Signed-off-by: André Almeida --- tests/kms_async_flips.c | 68 + 1 file changed, 68 insertions(+) diff --git

[PATCH i-g-t 1/2] tests/kms_async_flips: add atomic test

2023-11-10 Thread André Almeida
From: Simon Ser This adds a simple test for DRM_MODE_PAGE_FLIP_ASYNC with the atomic uAPI. Signed-off-by: Simon Ser Signed-off-by: André Almeida --- include/drm-uapi/drm.h | 8 tests/kms_async_flips.c | 37 + 2 files changed, 45 insertions(+)

[PATCH i-g-t 0/2] Add test for atomic async page flip

2023-11-10 Thread André Almeida
This series adds tests for async page flip for DRM Atomic API. Kernel patches: https://lore.kernel.org/dri-devel/20231025005318.293690-1-andrealm...@igalia.com/ André Almeida (1): tests/kms_async_flips: Add test for atomic prop changes Simon Ser (1): tests/kms_async_flips: add atomic test

Re: [Intel-gfx] [PATCH] Remove custom dumb_map_offset implementations in i915 driver

2023-11-10 Thread kernel test robot
Hi Dipam, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Dipam-Turkar/Remove-custom-dumb_map_offset-implementations-in-i915-driver/20231110-185942 base: git://anongit.freedesktop.org/drm

Re: [PATCH] vgacon: drop IA64 reference in VGA_CONSOLE dependency list

2023-11-10 Thread Arnd Bergmann
On Fri, Nov 10, 2023, at 12:44, Lukas Bulwahn wrote: > Commit e9e3300b6e77 ("vgacon: rework Kconfig dependencies") turns the > dependencies into a positive list of supported architectures, which > includes the IA64 architecture, but in the meantime, this architecture is > removed in commit

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Maxime Ripard
On Fri, Nov 10, 2023 at 11:08:06AM +, Simon Ser wrote: > > On Thu, Nov 09, 2023 at 03:31:44PM +, Simon Ser wrote: > > > > > - What would be a good name for the heap? "vc4" is maybe a bit naive > > > > > and > > > > > not precise enough. Something with "cma"? Do we need to plan a naming >

Re: [PULL] drm-intel-next-fixes

2023-11-10 Thread Daniel Vetter
On Wed, Nov 08, 2023 at 04:04:14PM +0200, Jani Nikula wrote: > > Hi Dave & Daniel - > > I see Dave already sent the pull request for v6.7-rc1 fixes, but here's > some more. > > drm-intel-next-fixes-2023-11-08: > drm/i915 fixes for v6.7-rc1: > - Fix null dereference when perf interface is not

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Danilo Krummrich
On 11/10/23 11:52, Thomas Hellström wrote: On 11/10/23 11:42, Christian König wrote: Am 10.11.23 um 10:39 schrieb Thomas Hellström: [SNIP] I was thinking more of the general design of a base-class that needs to be refcounted. Say a driver vm that inherits from gpu-vm, gem_object and yet

[PATCH] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-10 Thread Hamza Mahfooz
For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask dynamically at runtime and document how to use

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-10 Thread Luben Tuikov
On 2023-11-10 07:40, Jani Nikula wrote: > On Thu, 09 Nov 2023, Luben Tuikov wrote: >> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially >> when no devices are available. This makes it easier to browse kernel logs. > > Please do not merge patches before people have

Re: [PATCH v3 1/6] drm/panfrost: Perform hard reset to recover GPU if soft reset fails

2023-11-10 Thread Steven Price
On 09/11/2023 10:25, AngeloGioacchino Del Regno wrote: > Even though soft reset should ideally never fail, during development of > some power management features I managed to get some bits wrong: this > resulted in GPU soft reset failures, where the GPU was never able to > recover, not even after

Re: [RFC PATCH v2] drm/test: add a test suite for GEM objects backed by shmem

2023-11-10 Thread Maxime Ripard
On Wed, Nov 08, 2023 at 02:42:03PM +0100, Marco Pagani wrote: > This patch introduces an initial KUnit test suite for GEM objects > backed by shmem buffers. > > Suggested-by: Javier Martinez Canillas > Signed-off-by: Marco Pagani > > v2: > - Improved description of test cases > - Cleaner error

[PATCH] drm/amd: Document device reset methods

2023-11-10 Thread André Almeida
Document what each amdgpu driver reset method does. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-10 Thread Danilo Krummrich
On 11/10/23 10:39, Thomas Hellström wrote: On 11/10/23 09:50, Christian König wrote: Am 09.11.23 um 19:34 schrieb Danilo Krummrich: On 11/9/23 17:03, Christian König wrote: Am 09.11.23 um 16:50 schrieb Thomas Hellström: [SNIP] Did we get any resolution on this? FWIW, my take on this is

Re: [PATCH 5/5] accel/ivpu: Use threaded IRQ to handle JOB done messages

2023-11-10 Thread Jeffrey Hugo
On 11/7/2023 5:35 AM, Jacek Lawrynowicz wrote: Remove job_done thread and replace it with generic callback based mechanism. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 30 ++--- drivers/accel/ivpu/ivpu_drv.h | 3 +- drivers/accel/ivpu/ivpu_hw_37xx.c |

Dependencies of DRM_LOONGSON

2023-11-10 Thread Jean Delvare
Hi Jingfeng, You recently added the loongson drm driver to the Linux kernel tree. Unlike all other loongson drivers, the drm driver doesn't have any dependency set on the platform or architecture, and is therefore proposed on all architectures. As far as I understand, this driver is only useful

Re: [PATCH] drm/amd: Document device reset methods

2023-11-10 Thread Alex Deucher
On Fri, Nov 10, 2023 at 10:56 AM André Almeida wrote: > > Document what each amdgpu driver reset method does. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 > 1 file changed, 20 insertions(+) > > diff --git

[PATCH v2] drm/amd: Document device reset methods

2023-11-10 Thread André Almeida
Document what each amdgpu driver reset method does. Signed-off-by: André Almeida --- v2: Add more details and small correction (Alex) drivers/gpu/drm/amd/amdgpu/amdgpu.h | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h

[GIT PULL] fbdev fixes and updates for v6.7-rc1

2023-11-10 Thread Helge Deller
The following changes since commit be3ca57cfb777ad820c6659d52e60bbdd36bf5ff: Merge tag 'media/v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media (2023-11-06 15:06:06 -0800) are available in the Git repository at:

Re: [PATCH] drm/amd: Document device reset methods

2023-11-10 Thread Randy Dunlap
Hi-- On 11/10/23 07:55, André Almeida wrote: > Document what each amdgpu driver reset method does. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >

Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

2023-11-10 Thread Jakub Kicinski
My brain is slightly fried after trying to catch up on the thread for close to 2h. So forgive me if I'm missing something. This applies to all emails I'm about to send :) On Sun, 5 Nov 2023 18:44:11 -0800 Mina Almasry wrote: > + trigger_device_reset(); The user space must not be

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-10 Thread Jakub Kicinski
On Sun, 5 Nov 2023 18:44:05 -0800 Mina Almasry wrote: > +static int mp_dmabuf_devmem_init(struct page_pool *pool) > +{ > + struct netdev_dmabuf_binding *binding = pool->mp_priv; > + > + if (!binding) > + return -EINVAL; > + > + if (pool->p.flags & PP_FLAG_DMA_MAP || > +

Re: [RFC PATCH v3 03/12] net: netdev netlink api to bind dma-buf to a net device

2023-11-10 Thread Jakub Kicinski
On Sun, 5 Nov 2023 18:44:02 -0800 Mina Almasry wrote: > + - > +name: queues > +doc: receive queues to bind the dma-buf to. > +type: u32 > +multi-attr: true I think that you should throw in the queue type. I know you made the op imply RX: > +- > +

  1   2   >