Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-14 Thread Jani Nikula
On Mon, 13 Nov 2023, Luben Tuikov wrote: > Hi Jani, > > On 2023-11-10 07:40, Jani Nikula wrote: >> On Thu, 09 Nov 2023, Luben Tuikov wrote: >>> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially >>> when no devices are available. This makes it easier to browse kernel

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Tvrtko Ursulin
On 10/11/2023 18:22, Michal Wajdeczko wrote: The Single Root I/O Virtualization (SR-IOV) extension to the PCI Express (PCIe) specification suite is supported starting from 12th generation of Intel Graphics processors. This RFC aims to explain how do we want to add support for SR-IOV to the

Re: [PATCH 05/17] dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC

2023-11-14 Thread Linus Walleij
On Wed, Nov 8, 2023 at 11:44 AM Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in >

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Vivi, Rodrigo
On Tue, 2023-11-14 at 12:37 +, Tvrtko Ursulin wrote: > > On 10/11/2023 18:22, Michal Wajdeczko wrote: > > The Single Root I/O Virtualization (SR-IOV) extension to the PCI > > Express (PCIe) specification suite is supported starting from 12th > > generation of Intel Graphics processors. > > >

Re: [PATCH] Remove custom dumb_map_offset implementation in msm driver

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 15:28, Dipam Turkar wrote: > > Make msm use drm_gem_create_map_offset() instead of its custom > implementation for associating GEM object with a fake offset. Since, > we already have this generic implementation, we don't need the custom > implementation and it is better to

Re: [PATCH v8 04/12] dt-bindings: phy: amlogic, g12a-mipi-dphy-analog: drop unneeded reg property and example

2023-11-14 Thread Neil Armstrong
On 10/11/2023 21:57, Rob Herring wrote: On Thu, Nov 09, 2023 at 10:00:05AM +0100, Neil Armstrong wrote: Now this bindings is referred from amlogic,meson-gx-hhi-sysctrl.yaml and is documented as a subnode of a simple-mfd, drop the invalid reg property. Why is it invalid? It's preferred to have

Re: [PATCH] drm/amd/display: fix NULL dereference

2023-11-14 Thread Hamza Mahfooz
On 11/14/23 01:36, José Pekkarinen wrote: The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output:

Re: [PATCH] drm/probe-helper: convert drm_connector_helper_get_modes_from_ddc() to struct drm_edid

2023-11-14 Thread Jani Nikula
On Tue, 14 Nov 2023, Thomas Zimmermann wrote: > Hi > > Am 14.11.23 um 11:58 schrieb Jani Nikula: >> Going forward, the struct drm_edid based functions drm_edid_read(), >> drm_edid_connector_update() and drm_edid_connector_add_modes() are the >> preferred ways of retrieving the EDID and updating

[PATCH 01/11] drm/rockchip: move output interface related definition to rockchip_drm_drv.h

2023-11-14 Thread Andy Yan
From: Andy Yan The output interface related definition can shared between vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated definition. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 - drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 -

[PATCH 02/11] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-11-14 Thread Andy Yan
From: Andy Yan This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c. regcache_sync will try to reload the configuration in regcache to hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on the upcoming rk3588 can not be set successfully before internal PD power on. Also

Re: [PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support

2023-11-14 Thread Rob Herring
On Tue, 14 Nov 2023 19:28:41 +0800, Andy Yan wrote: > From: Andy Yan > > The vop2 on rk3588 is similar to which on rk356x > but with 4 video outputs and need to reference > more grf modules. > > Signed-off-by: Andy Yan > --- > > .../display/rockchip/rockchip-vop2.yaml | 25

[PATCH 00/11] Add VOP2 support on rk3588

2023-11-14 Thread Andy Yan
From: Andy Yan This patch sets aims at enable the VOP2 support on rk3588. Main feature of VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support 4 4K Esmart windows with line

[PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Andy Yan
From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support 4 4K Esmart windows with line RGB/YUV support Signed-off-by: Andy Yan ---

[PATCH 10/11] drm/rockchip: vop2: Add debugfs support

2023-11-14 Thread Andy Yan
From: Andy Yan /sys/kernel/debug/dri/vop2/summary: dump vop display state /sys/kernel/debug/dri/vop2/regs: dump whole vop registers /sys/kernel/debug/dri/vop2/active_regs: only dump the registers of activated modules Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c |

[PATCH 11/11] arm64: dts: rockchip: Add vop on rk3588

2023-11-14 Thread Andy Yan
From: Andy Yan Add vop dt node for rk3588. Signed-off-by: Andy Yan --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++ 1 file changed, 96 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index

Re: [PATCH v2 6/8] dt-bindings: reserved-memory: Add secure CMA reserved memory range

2023-11-14 Thread Robin Murphy
On 13/11/2023 6:37 am, Yong Wu (吴勇) wrote: [...] +properties: + compatible: +const: secure_cma_region Still wrong compatible. Look at other bindings - there is nowhere underscore. Look at other reserved memory bindings especially. Also, CMA is a Linux thingy, so either not suitable for

[PATCH 04/11] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode

2023-11-14 Thread Andy Yan
From: Andy Yan The enable bit and transform offset of cluster windows should be cleared when it work at linear mode, or we may have a iommu fault issue. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 05/11] drm/rockchip: vop2: Set YUV/RGB overlay mode

2023-11-14 Thread Andy Yan
From: Andy Yan Set overlay mode register according to the output mode is yuv or rgb. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 19 --- 2 files changed, 17 insertions(+), 3 deletions(-) diff

[PATCH 03/11] drm/rockchip: vop2: set half_block_en bit in all mode

2023-11-14 Thread Andy Yan
From: Andy Yan At first we thought the half_block_en bit in AFBCD_CTRL register only work in afbc mode. But the fact is that it control the line buffer in all mode(afbc/tile/line), so we need configure it in all case. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c |

[PATCH 06/11] drm/rockchip: vop2: rename grf to sys_grf

2023-11-14 Thread Andy Yan
From: Andy Yan The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc) in the upcoming rk3588. So we rename the current system grf to sys_grf. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support

2023-11-14 Thread Andy Yan
From: Andy Yan The vop2 on rk3588 is similar to which on rk356x but with 4 video outputs and need to reference more grf modules. Signed-off-by: Andy Yan --- .../display/rockchip/rockchip-vop2.yaml | 25 +++ 1 file changed, 25 insertions(+) diff --git

[PATCH 07/11] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon

2023-11-14 Thread Andy Yan
From: Andy Yan Add VOP and VO GRF syscon compatibles for RK3588 Signed-off-by: Andy Yan --- Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml

Re: [PATCH 0/2] drm/bridge: start moving towards struct drm_edid

2023-11-14 Thread Jani Nikula
On Thu, 26 Oct 2023, Jani Nikula wrote: > This is just the first two patches of a lengthy series that I'm not > really sure how to proceed with. Basically the series converts all of > drm/bridge to the new struct drm_edid infrastructure. It's safer than > struct edid, because it contains meta

[PATCH] drm/amd/display: fix ptr comparison to 0

2023-11-14 Thread José Pekkarinen
This patch will address the following coccinelle warning where a pointer is compared to 0 instead of NULL. drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c:5423:19-20: WARNING comparing pointer to 0 Fixes: 7966f319c66d9 ("drm/amd/display: Introduce DML2") Signed-off-by: José Pekkarinen

Re: [PATCH v8 02/12] dt-bindings: soc: amlogic, meson-gx-hhi-sysctrl: add example covering meson-axg-hhi-sysctrl

2023-11-14 Thread Neil Armstrong
On 10/11/2023 21:12, Rob Herring wrote: On Thu, Nov 09, 2023 at 10:00:03AM +0100, Neil Armstrong wrote: Add a thirst example covering the meson-axg-hhi-sysctrl variant and more importantly the phy subnode. Signed-off-by: Neil Armstrong --- .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml

Re: [PATCH] drm/probe-helper: convert drm_connector_helper_get_modes_from_ddc() to struct drm_edid

2023-11-14 Thread Thomas Zimmermann
Hi Am 14.11.23 um 11:58 schrieb Jani Nikula: Going forward, the struct drm_edid based functions drm_edid_read(), drm_edid_connector_update() and drm_edid_connector_add_modes() are the preferred ways of retrieving the EDID and updating the connector. Cc: Thomas Zimmermann Signed-off-by: Jani

[PATCH] Remove custom dumb_map_offset implementation in msm driver

2023-11-14 Thread Dipam Turkar
Make msm use drm_gem_create_map_offset() instead of its custom implementation for associating GEM object with a fake offset. Since, we already have this generic implementation, we don't need the custom implementation and it is better to standardize the code for GEM based drivers. Signed-off-by:

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-14 Thread Frieder Schrempf
Hi Michael, On 13.11.23 17:43, Michael Walle wrote: > The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 > mode. It seems the bridge internally queues DSI packets and when the > FORCE_STOP_STATE bit is cleared, they are sent in close succession > without any useful timing

[PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment

2023-11-14 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warnings when merging drm-intel tree: Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation. Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5488: WARNING:

Re: Incomplete stable drm/ast backport - screen freeze on boot

2023-11-14 Thread Jocelyn Falempe
On 13/11/2023 17:37, Sasha Levin wrote: On Mon, Nov 13, 2023 at 10:49:01AM +0100, Thomas Zimmermann wrote: (cc: gregkh) Hi Jocelyn Am 13.11.23 um 10:36 schrieb Jocelyn Falempe: On 13/11/2023 09:34, Keno Fischer wrote: Greetings, When connected to a remote machine via the BMC KVM

RE: [PATCH 02/11] drm/i915/display: Store compressed bpp in U6.4 format

2023-11-14 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, November 10, 2023 3:40 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Sharma, Swati2 ; Kulkarni, Vandita > ; Kandpal, Suraj ; > suijingf...@loongson.cn > Subject: [PATCH 02/11]

Re: [PATCH] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v3)

2023-11-14 Thread David Hildenbrand
On 14.11.23 08:00, Vivek Kasireddy wrote: For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API

Re: Fbdev issue after the drm updates 'drm-next-2023-10-31-1'

2023-11-14 Thread Christian Zigotzky
On 13 November 2023 at 01:48 pm, Geert Uytterhoeven wrote: Thanks for your report! I can confirm there is no graphics output with m68k/virt, and bisected this to my own commit 6ae2ff23aa43a0c4 ("drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()"), ouch... It turns out the old

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-14 Thread Michael Walle
Hi Alexander, The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 mode. It seems the bridge internally queues DSI packets and when the FORCE_STOP_STATE bit is cleared, they are sent in close succession without any useful timing (this also means that the DSI lanes won't go

Re: linux-next: build warning after merge of the drm-intel tree

2023-11-14 Thread Jani Nikula
On Tue, 14 Nov 2023, Jani Nikula wrote: > On Tue, 14 Nov 2023, Stephen Rothwell wrote: >> Hi all, >> >> After merging the drm-intel tree, today's linux-next build (htmldocs) >> produced this warning: >> >> Documentation/gpu/drm-kms-helpers:296: >>

RE: [PATCH 04/11] drm/i915/audio: Consider fractional vdsc bpp while computing tu_data

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate the precision during calculation of transfer unit data for > hblank_early calculation. > > v2: > -Fix tu_data calculation while dealing with U6.4 format.

Re: [PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-14 Thread Pavel Machek
Hi! > > > From: Alex Deucher > > > > > > [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] > > > > > > For pptable structs that use flexible array sizes, use flexible arrays. > > > > > > Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 > > > Reviewed-by: Mario

Re: [Intel-gfx] [PATCH 00/11] Add DSC fractional bpp support

2023-11-14 Thread Nautiyal, Ankit K
On 11/10/2023 3:40 PM, Ankit Nautiyal wrote: This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link

Re: [Intel-xe] [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Michal Wajdeczko
On 14.11.2023 11:08, Francois Dugast wrote: > On Fri, Nov 10, 2023 at 07:22:31PM +0100, Michal Wajdeczko wrote: >> The Single Root I/O Virtualization (SR-IOV) extension to the PCI >> Express (PCIe) specification suite is supported starting from 12th >> generation of Intel Graphics processors.

Re: [PATCH v2 5/6] drm/vs: Add KMS crtc

2023-11-14 Thread Keith Zhao
On 2023/10/26 3:28, Dmitry Baryshkov wrote: > On 25/10/2023 13:39, Keith Zhao wrote: >> add 2 crtcs and 8 planes in vs-drm >> >> Signed-off-by: Keith Zhao >> --- >> drivers/gpu/drm/verisilicon/Makefile |8 +- >> drivers/gpu/drm/verisilicon/vs_crtc.c | 257 >>

[PATCH] drm/probe-helper: convert drm_connector_helper_get_modes_from_ddc() to struct drm_edid

2023-11-14 Thread Jani Nikula
Going forward, the struct drm_edid based functions drm_edid_read(), drm_edid_connector_update() and drm_edid_connector_add_modes() are the preferred ways of retrieving the EDID and updating the connector. Cc: Thomas Zimmermann Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_probe_helper.c |

Re: linux-next: build warning after merge of the drm-intel tree

2023-11-14 Thread Jani Nikula
On Tue, 14 Nov 2023, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/gpu/drm-kms-helpers:296: > drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected > indentation. >

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-14 Thread Keith Zhao
On 2023/11/13 21:31, Dmitry Baryshkov wrote: > On Mon, 13 Nov 2023 at 14:11, Keith Zhao wrote: >> >> >> >> On 2023/10/26 6:23, Dmitry Baryshkov wrote: >> > On 25/10/2023 13:39, Keith Zhao wrote: >> >> add hdmi driver as encoder and connect >> >> >> >> Signed-off-by: Keith Zhao >> >> --- >> >>

Re: [PATCH 1/1] drm/mediatek: Fix access violation in mtk_drm_crtc_dma_dev_get

2023-11-14 Thread Macpaul Lin
On 11/10/23 09:29, Stuart Lee wrote: Add error handling to check NULL input in mtk_drm_crtc_dma_dev_get function. While display path is not configured correctly, none of crtc is established. So the caller of mtk_drm_crtc_dma_dev_get may pass input parameter *crtc as NULL, Which may cause

RE: [PATCH 03/11] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-11-14 Thread Kandpal, Suraj
> MTL+ supports fractional compressed bits_per_pixel, with precision of > 1/16. This compressed bpp is stored in U6.4 format. > Accommodate this precision while computing m_n values. > > v1: > Replace the computation of 'data_clock' with 'data_clock = > DIV_ROUND_UP(data_clock, 16).' (Sui

Re: [Intel-xe] [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Francois Dugast
On Fri, Nov 10, 2023 at 07:22:31PM +0100, Michal Wajdeczko wrote: > The Single Root I/O Virtualization (SR-IOV) extension to the PCI > Express (PCIe) specification suite is supported starting from 12th > generation of Intel Graphics processors. > > This RFC aims to explain how do we want to add

[PATCH v2] drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-11-14 Thread Jani Nikula
Since the edid_firmware module parameter was moved from drm_kms_helper.ko to drm.ko in v4.15, we've had a backwards compatibility helper in place, with a DRM_NOTE() suggesting to migrate to drm.edid_firmware. This was added in commit ac6c35a4d8c7 ("drm: add backwards compatibility support for

Re: [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-11-14 Thread Krzysztof Kozlowski
On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > Merging > === > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), > so >they will touch the same lines in some of the

Re: [Intel-xe] [PATCH v3] Documentation/gpu: VM_BIND locking document

2023-11-14 Thread Thomas Hellström
Hi, Rodrigo On 11/1/23 21:11, Rodrigo Vivi wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention

[PATCH v2] drm/amd/display: fix NULL dereference

2023-11-14 Thread José Pekkarinen
The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector

Re: [PATCH 2/8] drm/bridge: it66121: Add bridge_to_it66121() helper and use it

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Instead of using the container_of() directly, which avoid the code lines > too long in horizontial. Just trivial cleanup, no functional change. > > Signed-off-by: Sui Jingfeng Reviewed-by: Dmitry Baryshkov > --- >

Re: [PATCH 1/8] drm/bridge: it66121: Use dev replace ctx->dev in the it66121_probe()

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > As the value of 'ctx->dev' has already been cached to the local variable > 'dev', so keep the usage consistent. Just trivial cleanup, no functional > change. > > Signed-off-by: Sui Jingfeng Reviewed-by: Dmitry

Re: [RFC PATCH v2] drm/test: add a test suite for GEM objects backed by shmem

2023-11-14 Thread Marco Pagani
On 2023-11-10 15:41, Maxime Ripard wrote: > On Wed, Nov 08, 2023 at 02:42:03PM +0100, Marco Pagani wrote: >> This patch introduces an initial KUnit test suite for GEM objects >> backed by shmem buffers. >> >> Suggested-by: Javier Martinez Canillas >> Signed-off-by: Marco Pagani >> >> v2: >> -

[PATCH v1 1/1] drm/i915/gt: Dont wait forever when idling in suspend

2023-11-14 Thread Alan Previn
When suspending, add a timeout when calling intel_gt_pm_wait_for_idle else if we have a leaked wakeref (which would be indicative of a bug elsewhere in the driver), driver will at exit the suspend-resume cycle, after the kernel detects the held reference and prints a message to abort suspending

[PATCH] drm/amdgpu/gmc11: fix logic typo in AGP check

2023-11-14 Thread ivlipski
From: Alex Deucher Should be && rather than ||. Fixes: b2e1cbe6281f ("drm/amdgpu/gmc11: disable AGP on GC 11.5") Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v8 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-11-14 Thread Danilo Krummrich
On 10/31/23 16:12, Sarah Walker wrote: From: Donald Robson Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v7: - Renamed helper to drm_gpuva_op_remap_to_unmap_range() -

[PATCH 7/8] drm/bridge: it66121: Add another implementation for getting match data

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Because if use the i2c_get_match_data() function on our platform, the following error will emerge. [3.597872] ACPI: bus type drm_connector registered [3.602877] loongson :00:06.1: Found LS7A1000 bridge chipset, revision: 1 [3.610013] loongson :00:06.1:

[PATCH 0/8] Allow link the it66121 display bridge driver as a lib

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng The goal is to make this driver usuable on non-DT based systems, while without introduce duplication and preserve code sharing. The first seven patch just doing trivial cleanup, the last patch try to solve the mentioned problem by allowing static linking. Tested on a

[PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Group the code lines(which with the same functional) into one dedicated function, which reduce the weight of it66121_probe() function. Just trivial cleanuo, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 53

[PATCH 6/8] drm/bridge: it66121: Add a helper to initialize the DRM bridge structure

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Helps the it66121_probe() function to reduce weight, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c

[PATCH 2/8] drm/bridge: it66121: Add bridge_to_it66121() helper and use it

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Instead of using the container_of() directly, which avoid the code lines too long in horizontial. Just trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 27 --- 1 file changed, 16

[PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Group those relavent code lines (which with common purpose) into one helper function, suppress the dependency on DT to function level. Just trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 32

[PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng The it66121_create_bridge() and it66121_destroy_bridge() are added to export the core functionalities. Create a connector manually by using bridge connector helpers when link as a lib. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 134

[PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Read the required chip id data back by calling regmap_bulk_read() once, reduce the number of local variables needed in it66121_probe() function. And store its values into struct it66121_ctx, as it will be used latter. Signed-off-by: Sui Jingfeng ---

[PATCH 1/8] drm/bridge: it66121: Use dev replace ctx->dev in the it66121_probe()

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng As the value of 'ctx->dev' has already been cached to the local variable 'dev', so keep the usage consistent. Just trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v6 1/2] drm/i915/guc: Flush context destruction worker at suspend

2023-11-14 Thread Alan Previn
When suspending, flush the context-guc-id deregistration worker at the final stages of intel_gt_suspend_late when we finally call gt_sanitize that eventually leads down to __uc_sanitize so that the deregistration worker doesn't fire off later as we reset the GuC microcontroller. Signed-off-by:

[PATCH v6 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-11-14 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal (via rcu_call) is triggered to free_engines which could lead us to the execution of the context destruction worker (after a prior worker flush). Thus, when suspending, insert rcu_barriers at the start of

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Michal Wajdeczko
On 14.11.2023 13:37, Tvrtko Ursulin wrote: > > On 10/11/2023 18:22, Michal Wajdeczko wrote: >> The Single Root I/O Virtualization (SR-IOV) extension to the PCI >> Express (PCIe) specification suite is supported starting from 12th >> generation of Intel Graphics processors. >> >> This RFC aims

Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes

2023-11-14 Thread Rob Herring
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. Unfortunately yamllint skips checking these due to a bug handling bracketed lists. There's an open issue for it[1]. > Signed-off-by: Krzysztof Kozlowski > --- >

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads), since these type of drivers need to handle buffer damages instead of frame damages. The drm_atomic_helper_buffer_damage_iter_init() has

[PATCH v6 0/2] Resolve suspend-resume racing with GuC destroy-context-worker

2023-11-14 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is launched right before the start of

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your feedback. > Hi > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: >> To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather >> than per-plane uploads), since these type of drivers need to handle buffer >>

Re: [PATCH 7/8] drm/bridge: it66121: Add another implementation for getting match data

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Because if use the i2c_get_match_data() function on our platform, the > following error will emerge. > > [3.597872] ACPI: bus type drm_connector registered > [3.602877] loongson :00:06.1: Found LS7A1000

Re: [PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Group the code lines(which with the same functional) into one dedicated > function, which reduce the weight of it66121_probe() function. Just trivial > cleanuo, no functional change. > > Signed-off-by: Sui Jingfeng >

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init, merged}() helpers

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: [...] >> struct drm_rect src; >> memset(iter, 0, sizeof(*iter)); >> @@ -223,7 +224,8 @@ __drm_atomic_helper_damage_iter_init(struct >> drm_atomic_helper_damage_iter *iter, >>

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-14 Thread Pavel Begunkov
On 11/11/23 17:19, David Ahern wrote: On 11/10/23 7:26 AM, Pavel Begunkov wrote: On 11/7/23 23:03, Mina Almasry wrote: On Tue, Nov 7, 2023 at 2:55 PM David Ahern wrote: On 11/7/23 3:10 PM, Mina Almasry wrote: On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: On 11/5/23 7:44 PM, Mina

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > The it66121_create_bridge() and it66121_destroy_bridge() are added to > export the core functionalities. Create a connector manually by using > bridge connector helpers when link as a lib. > > Signed-off-by: Sui

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Thomas Zimmermann
Hi Javier Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: Hello, This series is to fix an issue that surfaced after damage clipping was enabled for the virtio-gpu by commit 01f05940a9a7 ("drm/virtio: Enable fb damage clips property for the primary plane"). After that change, flickering

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init, merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads), since these type of drivers need to handle buffer damages instead of frame damages. The drm_atomic_helper_buffer_damage_iter_init() has

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-14 Thread Michael Walle
Hi, My current guess would be that the issue I was seeing was already fixed with dd9e329af723 ("drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec") and I didn't properly test both changes separately. I had the exact same thought, as I've found your second patch. My cheap

Re: [PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Group those relavent code lines (which with common purpose) into one helper > function, suppress the dependency on DT to function level. Just trivial > cleanup, no functional change. > > Signed-off-by: Sui Jingfeng >

Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2023-11-14 Thread Jeffrey Hugo
On 1/17/2023 8:24 PM, Jiasheng Jiang wrote: On Tue, Jan 10, 2023 at 11:24:47PM +0800, Jiasheng Jiang wrote: Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers that provide managed workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM

Re: [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Read the required chip id data back by calling regmap_bulk_read() once, > reduce the number of local variables needed in it66121_probe() function. > And store its values into struct it66121_ctx, as it will be used

Re: [PATCH 6/8] drm/bridge: it66121: Add a helper to initialize the DRM bridge structure

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Helps the it66121_probe() function to reduce weight, no functional change. This is not a proper commit message. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/ite-it66121.c | 24

Re: [PATCH] drm/nouveau: Prevents NULL pointer dereference in nouveau_uvmm_sm_prepare

2023-11-14 Thread Danilo Krummrich
Hi Yuran, On 10/26/23 19:03, Yuran Pereira wrote: There are instances where the "args" argument passed to nouveau_uvmm_sm_prepare() is NULL. I.e. when nouveau_uvmm_sm_prepare() is called from nouveau_uvmm_sm_unmap_prepare() ``` static int nouveau_uvmm_sm_unmap_prepare(struct nouveau_uvmm

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: >> Hello, >> >> This series is to fix an issue that surfaced after damage clipping was >> enabled for the virtio-gpu by commit 01f05940a9a7 ("drm/virtio: Enable >> fb damage clips property for the

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 14.11.23 um 16:58 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your feedback. Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads),

Re: [PATCH 04/17] dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC

2023-11-14 Thread Ulf Hansson
On Wed, 8 Nov 2023 at 11:44, Krzysztof Kozlowski wrote: > > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in >

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Thomas Zimmermann
Hi Am 14.11.23 um 17:28 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hi Javier Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: Hello, This series is to fix an issue that surfaced after damage clipping was enabled for the virtio-gpu by commit 01f05940a9a7

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Michal Wajdeczko
On 14.11.2023 14:22, Vivi, Rodrigo wrote: > On Tue, 2023-11-14 at 12:37 +, Tvrtko Ursulin wrote: >> >> On 10/11/2023 18:22, Michal Wajdeczko wrote: >>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI >>> Express (PCIe) specification suite is supported starting from 12th >>>

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Tvrtko Ursulin
On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote: On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote: alan:snip It

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Rodrigo Vivi
On Tue, Nov 14, 2023 at 05:27:18PM +, Tvrtko Ursulin wrote: > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > > > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > > > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote:

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi [...] >>> And why does it flicker? Is there old data stored somewhere? >>> >> >> It flickers because the framebuffer changed and so the damage tracking >> is not used correctly to flush the damaged areas to the backing storage. > > I think I got

Re: [PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Marijn Suijten
On what hardware have you been testing this? Dmitry and I have a stack of patches to resolve support for Active CTL programming on newer hardware (DPU 5.0+ IIRC), where a single CTL is responsible for programming multiple INTF and DSC blocks as used in bonded DSI. On 2023-11-14 12:42:16,

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 17:52 +, Tvrtko Ursulin wrote: > On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: > > On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: > > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Tvrtko Ursulin
On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: On Thu,

Re: [PATCH i-g-t 2/2] lib/kunit: Execute test cases synchronously

2023-11-14 Thread Janusz Krzysztofik
Hi Mauro, Thanks for review. On Friday, 10 November 2023 08:52:04 CET Mauro Carvalho Chehab wrote: > On Mon, 6 Nov 2023 10:59:38 +0100 > Janusz Krzysztofik wrote: > > > Up to now we've been loading a KUnit test module in background and parsing > > in parallel its KTAP output with results

Re: [PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Jonathan Marek
On 11/14/23 1:28 PM, Marijn Suijten wrote: On what hardware have you been testing this? Dmitry and I have a stack of patches to resolve support for Active CTL programming on newer hardware (DPU 5.0+ IIRC), where a single CTL is responsible for programming multiple INTF and DSC blocks as used in

Re: [Nouveau] [PATCH] nouveau: don't fail driver load if no display hw present.

2023-11-14 Thread Danilo Krummrich
On 11/5/23 21:37, Dave Airlie wrote: From: Dave Airlie If we get back ENODEV don't fail load. Maybe worth to note why this is OK in this case, might not be obvious to future readers of the code. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Maybe I'm missing

  1   2   >