Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-22 Thread Heiko Stübner
Am Donnerstag, 22. August 2024, 01:22:16 CEST schrieb Cristian Ciocaltea: > On 8/22/24 12:38 AM, Heiko Stuebner wrote: > > > > > > Am 21. August 2024 23:28:55 MESZ schrieb Conor Dooley : > >> Cristian, Heiko, > >> > >> On Wed, Aug 21, 2024 at 11:38:01PM +0300, Cristian Ciocaltea wrote: > >>> On 8

Re: [PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-22 Thread Julian Calaby
Hi Rong, On Tue, Aug 20, 2024 at 10:59 PM Rong Qianfeng wrote: > > Replace devm_clk_get() and clk_prepare_enable() with > devm_clk_get_enabled() that also disables and unprepares it on > driver detach. > > Signed-off-by: Rong Qianfeng > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 13 +++--

Re: [PATCH] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-22 Thread Anand Moon
Hi Rong, On Tue, 20 Aug 2024 at 18:30, Rong Qianfeng wrote: > > Replace devm_clk_get() and clk_prepare_enable() with > devm_clk_get_enabled() that also disables and unprepares it on > driver detach. > > Signed-off-by: Rong Qianfeng > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 13 +++-

[PATCH v1] drm/amd/display: Fix wrong assignment in dce100_resource_construct()

2024-08-22 Thread Yuesong Li
Fix the assignment for i2c_speed_in_khz_hdcp. Fixex: commit b15cde19c32d ("drm/amd/display: Add i2c speed arbitration for dc_i2c and hdcp_i2c") Signed-off-by: Yuesong Li --- .../gpu/drm/amd/display/dc/resource/dce100/dce100_resource.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-22 Thread Raag Jadav
On Tue, Aug 20, 2024 at 05:06:39PM +0300, Andy Shevchenko wrote: > On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote: > > On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > > > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote: > > > > > > But it still has an issu

Re: [PATCH RESEND] drm/amd/display: avoid using null object of framebuffer

2024-08-22 Thread Ma Ke
Alex Deucher wrote: > On Wed, Aug 21, 2024 at 3:45 AM Ma Ke wrote: > > > > Instead of using state->fb->obj[0] directly, get object from framebuffer > > by calling drm_gem_fb_get_obj() and return error code when object is > > null to avoid using null object of framebuffer. > > > > Cc: sta...@vger

[PATCH v7 0/4] drm/panic: Add a QR code panic screen

2024-08-22 Thread Jocelyn Falempe
This series adds a new panic screen, with the kmsg data embedded in a QR code. The main advantage of QR code, is that you can copy/paste the debug data to a bug report. The QR code encoder is written in rust, and is very specific to drm panic. The reason is that it is called in a panic handler,

[PATCH v7 1/4] drm/panic: Add integer scaling to blit()

2024-08-22 Thread Jocelyn Falempe
Add a parameter to the blit function, to upscale the image. This is necessary to draw a QR code, otherwise, the pixels are usually too small to be readable by most QR code reader. It can also be used later for drawing fonts on high DPI display. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/

[PATCH v7 2/4] drm/rect: Add drm_rect_overlap()

2024-08-22 Thread Jocelyn Falempe
Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Signed-off-by: Jocelyn Falempe --- v7: * rename r1/r2 to a/b in drm_rect_overlap() (Jani Nikula) drivers/gpu/drm/drm_panic.c | 3 +-- include/drm/drm_r

[PATCH v7 3/4] drm/panic: Simplify logo handling

2024-08-22 Thread Jocelyn Falempe
Move logo rectangle initialisation, and logo drawing in separate functions, so they can be re-used by different panic screens. It prepares the introduction of the QR code panic screen. Signed-off-by: Jocelyn Falempe --- v6: * rebase, and handle conflict with 5d45c01dea6f ("drm/panic: Add panic

[PATCH v7 4/4] drm/panic: Add a QR code panic screen

2024-08-22 Thread Jocelyn Falempe
This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the URL as a URL parameter. This allows to save space, and put about ~7500 bytes

Re: [PATCH v3 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-22 Thread Krzysztof Kozlowski
On Thu, Aug 22, 2024 at 06:46:48AM +, Rohit Agarwal wrote: > Add power domain binding to the mediatek DPI controller > for MT8186. > Also, add power domain binding for other SoCs like > MT6795 and MT8173 that already had power domain property. > > Signed-off-by: Rohit Agarwal > --- > .../bin

[PATCH v1] drivers:smumgr:Use min macro

2024-08-22 Thread Yang Ruibin
Instead of using the min() implementation of the ternary operator, use real macros. Signed-off-by: Yang Ruibin <11162...@vivo.com> --- drivers/gpu/drm/amd/pm/powerplay/smumgr/fiji_smumgr.c | 5 + drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c | 7 ++- drivers/gpu/drm/amd

[PATCH v1] drivers:smumgr:Variable names should be consistent

2024-08-22 Thread Yang Ruibin
The variable highest_pcie_level_enabled is named hightest_pcie_level_enabled in other modules. Please ensure the consistency of variable naming and use min macros instead of the triadic operator. Signed-off-by: Yang Ruibin <11162...@vivo.com> --- .../drm/amd/pm/powerplay/smumgr/tonga_smumgr.c |

[PATCH v1] drivers:smumgr:Variable names should be consistent with other modules

2024-08-22 Thread Yang Ruibin
The variable highest_pcie_level_enabled is named hightest_pcie_level_enabled in other modules. Please ensure the consistency of variable naming and use min macros instead of the triadic operator. Signed-off-by: Yang Ruibin <11162...@vivo.com> --- .../amd/pm/powerplay/smumgr/iceland_smumgr.c

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Christian König
Am 22.08.24 um 08:47 schrieb Thomas Hellström: As Sima said, this is complicated but not beyond comprehension: i915 https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c#L317 As far as I can tell what i915 does here is extremely questionable. if (s

Re: [PATCH] MAINTAINERS: udmabuf: Add myself as co-maintainer for udmabuf driver

2024-08-22 Thread Gerd Hoffmann
On Wed, Aug 21, 2024 at 09:58:06PM GMT, Vivek Kasireddy wrote: > I would like to help maintain the udmabuf driver, in light of the > recent changes that converted the driver to use folios instead > of pages. Furthermore, I also contribute to Qemu's virtio-gpu > module (and UI modules), that are pri

Re: [PATCH v2 1/4] udmabuf: cancel mmap page fault, direct map it

2024-08-22 Thread Christian König
Am 12.08.24 um 04:49 schrieb Huan Yang: 在 2024/8/10 9:28, Kasireddy, Vivek 写道: [Some people who received this message don't often get email from vivek.kasire...@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Huan, The current udmabuf mmap uses

Re: [PULL] drm-misc-next

2024-08-22 Thread Daniel Vetter
On Fri, Aug 16, 2024 at 10:41:09AM +0200, Thomas Zimmermann wrote: > Hi Dave, Sima, > > this is the weekly PR for drm-misc-next. Mostly small cleanups and > improvements. Rockchip received support for more modes and displays. > > Best regards > Thomas > > drm-misc-next-2024-08-16: > drm-misc-nex

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Thomas Hellström
On Thu, 2024-08-22 at 09:55 +0200, Christian König wrote: > Am 22.08.24 um 08:47 schrieb Thomas Hellström: > > > > > As Sima said, this is complicated but not beyond > > > > > comprehension: > > > > > i915 > > > > > https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/gpu/drm/i915/gem/i915_gem

Re: [PATCH v2 40/86] drm/stm: Run DRM default client setup

2024-08-22 Thread Raphael Gallais-Pou
On 8/21/24 14:59, Thomas Zimmermann wrote: > Call drm_client_setup_with-fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fourcc() > > Signed-off-by

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-22 Thread Conor Dooley
On Thu, Aug 22, 2024 at 09:01:34AM +0200, Heiko Stübner wrote: > @Conor: just for me, did some shift happen in our understanding of dt- > best-practices in terms of syscon via phandle vs. syscon via compatible? > > Because Rockchip boards are referencing their GRFs via phandes forever > but simila

[PATCH v4 1/5] udmabuf: direct map pfn when first page fault

2024-08-22 Thread Huan Yang
The current udmabuf mmap uses a page fault to populate the vma. However, the current udmabuf has already obtained and pinned the folio upon completion of the creation.This means that the physical memory has already been acquired, rather than being accessed dynamically. As a result, the page fault

[PATCH v4 0/5] udmbuf bug fix and some improvements

2024-08-22 Thread Huan Yang
This patchset attempts to fix some errors in udmabuf and remove the upin_list structure. Some of this fix just gather the patches which I upload before. Patch 1,2,4,5 has passed the udmabuf self-test suite's tests. Suggested by Kasireddy, Vivek Patch5 modified the unpin function, therefore runni

[PATCH v4 2/5] udmabuf: change folios array from kmalloc to kvmalloc

2024-08-22 Thread Huan Yang
When PAGE_SIZE 4096, MAX_PAGE_ORDER 10, 64bit machine, page_alloc only support 4MB. If above this, trigger this warn and return NULL. udmabuf can change size limit, if change it to 3072(3GB), and then alloc 3GB udmabuf, will fail create. [ 4080.876581] [ cut here ] [ 4080.

[PATCH v4 3/5] udmabuf: fix vmap_udmabuf error page set

2024-08-22 Thread Huan Yang
Currently vmap_udmabuf set page's array by each folio. But, ubuf->folios is only contain's the folio's head page. That mean we repeatedly mapped the folio head page to the vmalloc area. Due to udmabuf can use hugetlb, if HVO enabled, tail page may not exist, so, we can't use page array to map, in

[PATCH v4 5/5] udmabuf: remove udmabuf_folio

2024-08-22 Thread Huan Yang
Currently, udmabuf handles folio by creating an unpin list to record each folio obtained from the list and unpinning them when released. To maintain this approach, many data structures have been established. However, maintaining this type of data structure requires a significant amount of memory a

[PATCH v4 4/5] udmabuf: udmabuf_create codestyle cleanup

2024-08-22 Thread Huan Yang
There are some variables in udmabuf_create that are only used inside the loop. Therefore, there is no need to declare them outside the scope. This patch moved it into loop. It is difficult to understand the loop condition of the code that adds folio to the unpin_list. This patch move item folio p

Re: [PATCH V3 7/9] usb: dwc2: Refactor backup/restore of registers

2024-08-22 Thread kernel test robot
Hi Stefan, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on arm/for-next arm/fixes v6.11-rc4 next-20240822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Daniel Vetter
On Wed, Aug 21, 2024 at 10:14:34AM +0200, Christian König wrote: > Am 20.08.24 um 18:00 schrieb Thomas Hellström: > > > Or why exactly should shrinking fail? > > A common example would be not having runtime pm and the particular bo > > needs it to unbind, we want to try the next bo. Example: i915 G

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-22 Thread Daniel Vetter
On Mon, Aug 19, 2024 at 05:31:36PM +0200, Andi Shyti wrote: > Hi Sima, > > On Mon, Aug 19, 2024 at 04:17:01PM +0200, Daniel Vetter wrote: > > On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > > > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > > > On Tue, Aug 13,

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Christian König
Am 22.08.24 um 10:21 schrieb Thomas Hellström: On Thu, 2024-08-22 at 09:55 +0200, Christian König wrote: Am 22.08.24 um 08:47 schrieb Thomas Hellström: As Sima said, this is complicated but not beyond comprehension: i915 https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/gpu/drm/i915/gem

Re: [PATCH v1] drivers:smumgr:Use min macro

2024-08-22 Thread Yang Ruibin
Sorry, please ignore this patch. Because the corresponding header file is not included, there may be compilation errors. 在 2024/8/22 14:57, Yang Ruibin 写道: Instead of using the min() implementation of the ternary operator, use real macros. Signed-off-by: Yang Ruibin <11162...@vivo.com> ---

Re: [PATCH v1 0/6] drm/amd/display: Use max/min macro

2024-08-22 Thread 于佼良
在 2024/8/22 14:57, Yu Jiaoliang 写道: > *** BLURB HERE *** > > Yu Jiaoliang (6): >drm/amd/display: Use max/min macro >drm/amd/display: Use max/min macro >drm/amd/display: Use max/min macro >drm/amd/display: Use max/min macro >drm/amd/display: Use max/min macro >drm/amd/display

Re: [PATCH v2 0/2] Allow partial memory mapping for cpu memory

2024-08-22 Thread Daniel Vetter
On Mon, Aug 19, 2024 at 04:53:41PM +, Matthew Brost wrote: > On Mon, Aug 19, 2024 at 05:16:09PM +0200, Andi Shyti wrote: > > Hi Matt, > > > > On Wed, Aug 14, 2024 at 04:07:02PM +, Matthew Brost wrote: > > > On Wed, Aug 14, 2024 at 03:48:32PM +0200, Andi Shyti wrote: > > > > I am resending

Re: [PATCH] drm/panel: fix null pointer dereference in hx83102_get_modes

2024-08-22 Thread cong yang
Hi, Charles Han 于2024年8月22日周四 17:34写道: > > In hx83102_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a possible NULL > pointer dereference on failure of drm_mode_duplicate(). Add a > check to avoid npd. > > Fixes: 0ef94554dc40 ("drm/panel: himax-hx

Re: [PATCH V3 7/9] usb: dwc2: Refactor backup/restore of registers

2024-08-22 Thread Stefan Wahren
Am 21.08.24 um 23:40 schrieb Stefan Wahren: The DWC2 runtime PM code reuses similar patterns to backup and restore the registers. So consolidate them in USB mode specific variants. This also has the advantage it is usable for further PM improvements. Signed-off-by: Stefan Wahren --- drivers/u

Re: [PATCH] drm: komeda: Fix an issue related to normalized zpos

2024-08-22 Thread kernel test robot
Hi hongchi.peng, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.11-rc4 next-20240822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH v1 0/3] Add missing fixes to FastRPC driver

2024-08-22 Thread Ekansh Gupta
This patch series adds the listed bug fixes that have been missing in upstream fastRPC driver. - Store actual size of map and check it against the user passed size. - Consider map user VA and actual size for map lookup. - Skip refcount increment for DMA handles. Ekansh Gupta (3): misc: fastrpc:

[PATCH v1 1/3] misc: fastrpc: Save actual DMA size in fastrpc_map structure

2024-08-22 Thread Ekansh Gupta
For user passed fd buffer, map is created using DMA calls. The map related information is stored in fastrpc_map structure. The actual DMA size is not stored in the structure. Store the actual size of buffer and check it against the user passed size. Fixes: c68cfb718c8f ("misc: fastrpc: Add support

[PATCH v1 2/3] misc: fastrpc: Fix fastrpc_map_lookup operation

2024-08-22 Thread Ekansh Gupta
Fastrpc driver creates maps for user allocated fd buffers. Before creating a new map, the map list is checked for any already existing maps using map fd. Checking with just map fd is not sufficient as the user can pass offsetted buffer with less size when the map is created and then a larger size t

[PATCH v1 3/3] misc: fastrpc: Skip reference for DMA handles

2024-08-22 Thread Ekansh Gupta
If multiple dma handles are passed with same fd over a remote call the kernel driver takes a reference and expects that put for the map will be called as many times to free the map. But DSP only updates the fd one time in the fd list when the DSP refcount goes to zero and hence kernel make put call

Re: [PATCH AUTOSEL 5.10 04/38] drm/amdgpu: fix uninitialized scalar variable warning

2024-08-22 Thread Pavel Machek
Hi! > From: Tim Huang > > [ Upstream commit 9a5f15d2a29d06ce5bd50919da7221cda92afb69 ] > > Clear warning that uses uninitialized value fw_size. This is queued for 5.15 and 6.10, but not 6.1, for example. Mistake? Best regards, Pa

Re: [PATCH v1] ImgTec powerVR DRM driver: Convert to use time_before macro

2024-08-22 Thread Matt Coster
Hi Chen, Thanks for the patch! Just a couple minor notes. On 21/08/2024 10:21, Chen Yufan wrote: Subject: [PATCH v1] ImgTec powerVR DRM driver: Convert to use time_before macro The prefix here should be based on the source path. For us, that's "drm/imagination:". Use time_before instead

Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-22 Thread Cristian Ciocaltea
On 8/22/24 11:41 AM, Conor Dooley wrote: > On Thu, Aug 22, 2024 at 09:01:34AM +0200, Heiko Stübner wrote: >> @Conor: just for me, did some shift happen in our understanding of dt- >> best-practices in terms of syscon via phandle vs. syscon via compatible? >> >> Because Rockchip boards are referenci

Re: [PATCH V3 4/9] drm/vc4: hdmi: add PM suspend/resume support

2024-08-22 Thread kernel test robot
Hi Stefan, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on arm/for-next arm/fixes v6.11-rc4 next-20240822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH v2] gpu: drm: Use devm_clk_get_enabled() helpers

2024-08-22 Thread Rong Qianfeng
The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). While at it, use de

Re: [PATCH v2 RESEND 1/5] drm: panthor: expose some fw information through the query ioctl

2024-08-22 Thread Adrian Larumbe
> On 21.08.2024 11:37, Daniel Almeida wrote: > This is of interest to userspace, and similar in nature to the GPU > and CSIF information we already return in the query ioctl. > > Signed-off-by: Daniel Almeida Reviewed-by: Adrian Larumbe > --- > drivers/gpu/drm/panthor/panthor_device.h | 3 ++

Re: [PATCH v2 RESEND 2/5] drm: panthor: add devcoredump support

2024-08-22 Thread Adrian Larumbe
> On 21.08.2024 11:37, Daniel Almeida wrote: > Dump the GPU state using devcoredump. This is useful for debugging > purposes. > > Signed-off-by: Daniel Almeida Reviewed-by: Adrian Larumbe > --- > drivers/gpu/drm/panthor/Kconfig | 1 + > drivers/gpu/drm/panthor/Makefile| 1

Re: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-22 Thread Geert Uytterhoeven
Hi Biju, On Mon, Aug 5, 2024 at 6:22 PM Biju Das wrote: > The LCD controller is composed of Frame Compression Processor (FCPVD), > Video Signal Processor (VSPD), and Display Unit (DU). > > It has DPI interface and supports a maximum resolution of WXGA along > with 2 RPFs to support the blending o

Re: [PATCH v2 RESEND 4/5] drm: panthor: add debugfs knob to dump successful jobs

2024-08-22 Thread Adrian Larumbe
Hi Daniel, > On 21.08.2024 11:37, Daniel Almeida wrote: > It can be advantageous for userspace to have access to successful jobs. While it's true that perhaps having additional jobs as part of the same devcoredump file could provide further information as to why a later job failed, I see a few

[PULL] drm-misc-fixes

2024-08-22 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2024-08-22: Short summary of fixes pull: nouveau: - firmware: use dma non-coherent allocator The following changes since commit fd45cc614b8acca5bb435ba37fe9b3f9a17fab84: drm/rockchip: inno-hdmi: Fix i

RE: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-22 Thread Biju Das
Hi Geert Uytterhoeven, Thanks for the feedback. > -Original Message- > From: Geert Uytterhoeven > Sent: Thursday, August 22, 2024 1:31 PM > Subject: Re: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support > > Hi Biju, > > On Mon, Aug 5, 2024 at 6:22 PM Biju Das wrote: > > The L

Re: [PATCH v7 1/4] drm/panic: Add integer scaling to blit()

2024-08-22 Thread Thomas Zimmermann
Am 22.08.24 um 09:33 schrieb Jocelyn Falempe: Add a parameter to the blit function, to upscale the image. This is necessary to draw a QR code, otherwise, the pixels are usually too small to be readable by most QR code reader. It can also be used later for drawing fonts on high DPI display. Si

Re: [PATCH v7 2/4] drm/rect: Add drm_rect_overlap()

2024-08-22 Thread Thomas Zimmermann
Am 22.08.24 um 09:33 schrieb Jocelyn Falempe: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann There's an optional comment further bel

Re: [PATCH v7 3/4] drm/panic: Simplify logo handling

2024-08-22 Thread Thomas Zimmermann
Am 22.08.24 um 09:33 schrieb Jocelyn Falempe: Move logo rectangle initialisation, and logo drawing in separate functions, so they can be re-used by different panic screens. It prepares the introduction of the QR code panic screen. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmerma

Re: [PATCH V3 2/9] drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get

2024-08-22 Thread Maíra Canal
Hi Stefan, On 8/21/24 18:40, Stefan Wahren wrote: The commit 0f5251339eda ("drm/vc4: hdmi: Make sure the controller is powered in detect") introduced the necessary power management handling to avoid register access while controller is powered down. Unfortunately it just print a warning if pm_run

Re: [PATCH V3 3/9] drm/vc4: Get the rid of DRM_ERROR()

2024-08-22 Thread Maíra Canal
Hi Stefan, On 8/21/24 18:40, Stefan Wahren wrote: DRM_ERROR() has been deprecated in favor of pr_err(). However, we should prefer to use drm_err() whenever possible so we get device- specific output with the error message. In error case of kcalloc, we can simply drop DRM_ERROR(), because kcalloc

Re: [PATCH v7 2/4] drm/rect: Add drm_rect_overlap()

2024-08-22 Thread Jocelyn Falempe
On 22/08/2024 14:58, Thomas Zimmermann wrote: Am 22.08.24 um 09:33 schrieb Jocelyn Falempe: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmer

Re: [PATCH V3 5/9] drm/vc4: v3d: simplify clock retrieval

2024-08-22 Thread Maíra Canal
Hi Stefan, On 8/21/24 18:40, Stefan Wahren wrote: Common pattern of handling deferred probe can be simplified with dev_err_probe() and devm_clk_get_optional(). This results in much less code. Signed-off-by: Stefan Wahren Reviewed-by: Maíra Canal Applied to drm/misc/kernel/drm-misc-next! Be

Re: [PATCH v7 3/4] drm/panic: Simplify logo handling

2024-08-22 Thread Jocelyn Falempe
On 22/08/2024 15:00, Thomas Zimmermann wrote: Am 22.08.24 um 09:33 schrieb Jocelyn Falempe: Move logo rectangle initialisation, and logo drawing in separate functions, so they can be re-used by different panic screens. It prepares the introduction of the QR code panic screen. Signed-off-by: J

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Thomas Hellström
On Thu, 2024-08-22 at 11:29 +0200, Christian König wrote: > Am 22.08.24 um 10:21 schrieb Thomas Hellström: > > On Thu, 2024-08-22 at 09:55 +0200, Christian König wrote: > > > Am 22.08.24 um 08:47 schrieb Thomas Hellström: > > > > > > > As Sima said, this is complicated but not beyond > > > > > > >

[PATCH] drm/amd/display: let update_planes_and_stream_state define minimal state

2024-08-22 Thread Melissa Wen
Artifacts appear when using dc->current_state as the minimal transition state in a scenario where update_planes_and_stream_state() would set the context as the new one because the update type is FULL. To prevent those artifacts, instead of defining the minimal state according to plane addition (cur

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-08-22 Thread Christian König
Am 22.08.24 um 11:23 schrieb Daniel Vetter: On Wed, Aug 21, 2024 at 10:14:34AM +0200, Christian König wrote: Am 20.08.24 um 18:00 schrieb Thomas Hellström: Or why exactly should shrinking fail? A common example would be not having runtime pm and the particular bo needs it to unbind, we want to

Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-22 Thread Andy Shevchenko
On Thu, Aug 22, 2024 at 10:28:38AM +0300, Raag Jadav wrote: > On Tue, Aug 20, 2024 at 05:06:39PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote: > > > On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > > > > On Tue, Aug 20, 2024 at 11:50

Re: [PATCH] drm: komeda: Fix an issue related to normalized zpos

2024-08-22 Thread kernel test robot
Hi hongchi.peng, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.11-rc4 next-20240822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v5 1/4] drm: Add panel backlight quirks

2024-08-22 Thread Mario Limonciello
On 8/22/2024 01:12, Thomas Weißschuh wrote: On 2024-08-21 15:51:17+, Mario Limonciello wrote: On 8/18/2024 01:56, Thomas Weißschuh wrote: Panels using a PWM-controlled backlight source do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI thr

Re: [PATCH v5 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-08-22 Thread Mario Limonciello
On 8/22/2024 01:14, Thomas Weißschuh wrote: On 2024-08-21 15:54:14+, Mario Limonciello wrote: On 8/18/2024 01:56, Thomas Weißschuh wrote: Not all platforms provide correct PWM backlight capabilities through ATIF. I don't think correct is an accurate term here. How about 'optimial'? Loo

Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb

2024-08-22 Thread Lee Jones
On Mon, 19 Aug 2024, Stephen Boyd wrote: > This binding is about USB type-c control. Move the binding to the usb > directory as it's a better home than chrome. > > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: Lee Jones > Cc: Benson Leung > Cc: Guenter Roeck > Cc: Prash

Re: [PATCH v2 65/86] drm/amdgpu: Run DRM default client setup

2024-08-22 Thread Hamza Mahfooz
On 8/21/24 09:00, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The amdgpu driver specifies a preferred color mode depending on the available vid

Re: [PATCH] drm: komeda: Fix an issue related to normalized zpos

2024-08-22 Thread Liviu Dudau
Hi Hongchi, On Wed, Aug 21, 2024 at 04:56:13PM +0800, hongchi.peng wrote: > We use komeda_crtc_normalize_zpos to normalize zpos of affected planes > to their blending zorder in CU. If there's only one slave plane in > affected planes and its layer_split property is enabled, order++ for > its split

Re: [PATCH v2] drm/mediatek: Fix missing configuration flags in mtk_crtc_ddp_config()

2024-08-22 Thread Chun-Kuang Hu
Hi, Jason: Jason-JH.Lin via B4 Relay 於 2024年8月19日 週一 下午11:26寫道: > > From: "Jason-JH.Lin" > > In mtk_crtc_ddp_config(), mtk_crtc will use some configuration flags to > generate instructions to cmdq_handle, such as: > state->pending_config > mtk_crtc->pending_planes > plane_state->pending.co

Re: [PATCH] drm/mediatek: Declare Z Position for all planes

2024-08-22 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2024年7月18日 週四 下午4:25寫道: > > MediaTek SoCs support multiple planes, one of which is the primary > and all the others are overlays (and CURSOR is the last overlay). > > In all currently supported SoCs, the Z order of the overlays can't > be changed with any

Re: [PATCH] drm/panel: fix null pointer dereference in hx83102_get_modes

2024-08-22 Thread Doug Anderson
Hi, On Thu, Aug 22, 2024 at 3:02 AM cong yang wrote: > > Hi, > > Charles Han 于2024年8月22日周四 17:34写道: > > > > In hx83102_get_modes(), the return value of drm_mode_duplicate() > > is assigned to mode, which will lead to a possible NULL > > pointer dereference on failure of drm_mode_duplicate(). Add

Re: [PATCH] drm: mediatek: Drop unnecessary check for property presence

2024-08-22 Thread Chun-Kuang Hu
Hi, Rob: Rob Herring (Arm) 於 2024年8月1日 週四 上午4:14寫道: > > of_property_read_u32() returns -EINVAL if a property is not present, so > the preceeding check for presence with of_find_property() can be > dropped. Really, what the errno is shouldn't matter. Either the property > can be read and used or i

Re: [PATCH v2 65/86] drm/amdgpu: Run DRM default client setup

2024-08-22 Thread Alex Deucher
On Wed, Aug 21, 2024 at 9:06 AM Thomas Zimmermann wrote: > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The amdgpu driver specifies a preferred color mode depend

Re: [PATCH 0/3] Various prime/dumb buffer fixes

2024-08-22 Thread Benjamin Coddington
On 16 Aug 2024, at 14:32, Zack Rusin wrote: > This is the same series I've sent out earlier but with one extra patch, > that fixes the dumb buffer coherency on low mem systems. > > The second patch has also been updated to not use math functions. > > Zack Rusin (3): > drm/vmwgfx: Prevent unmappi

Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:27PM -0700, Stephen Boyd wrote: > -title: Google Chrome OS EC(Embedded Controller) Type C port driver. > +title: Google Chrome OS Embedded Controller (EC) USB type-c port driver Given that it gets chance to modify, how about s/Chrome OS/ChromeOS/?

Re: [PATCH v3 15/17] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:29PM -0700, Stephen Boyd wrote: > +struct cros_typec_dp_bridge { > + struct cros_typec_data *typec_data; > + struct drm_dp_typec_bridge_dev *dev; > +}; It looks like structs are all defined in cros_ec_typec.h. I think this struct definition can be also moved

Re: [PATCH v3 16/17] platform/chrome: cros_ec_typec: Support DP muxing

2024-08-22 Thread Tzung-Bi Shih
On Mon, Aug 19, 2024 at 03:38:30PM -0700, Stephen Boyd wrote: > @@ -671,6 +674,20 @@ static int cros_typec_configure_mux(struct > cros_typec_data *typec, int port_num, > if (port->mux_flags == resp.flags && port->role == pd_ctrl->role) > return 0; > > + dp_enabled = resp.

Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-22 Thread Thomas Zimmermann
Hi Am 12.08.24 um 08:59 schrieb Al Viro: Once something had been put into descriptor table, the only thing you can do with it is returning descriptor to userland - you can't withdraw it on subsequent failure exit, etc. You certainly can't count upon it staying in the same slot of descriptor tab

Re: [PATCH v2 1/2] drm/virtio: Use XRGB8888 also for big endian systems

2024-08-22 Thread Jocelyn Falempe
On 21/08/2024 13:12, Gerd Hoffmann wrote: On Tue, Aug 20, 2024 at 11:07:40AM GMT, Jocelyn Falempe wrote: Mesa doesn't support BGRX, that means most wayland compositors don't work on big endian guests. So you are doing a hard switch from native endian to little endian. While this should be

Re: [PATCH V3] video/aperture: optionally match the device in sysfb_disable()

2024-08-22 Thread Javier Martinez Canillas
Alex Deucher writes: Hello Alex, > In aperture_remove_conflicting_pci_devices(), we currently only > call sysfb_disable() on vga class devices. This leads to the > following problem when the pimary device is not VGA compatible: > > 1. A PCI device with a non-VGA class is the boot display > 2. T

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-22 Thread kernel test robot
Hi Harry, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240822] [If

[PULL] drm-misc-next

2024-08-22 Thread Thomas Zimmermann
Hi Dave, Sima, here's this week's PR for drm-misc-next. It adds support for more panels, and easier error handling for DSI code. Ast should finally have decent support for BMC output. Plus the usual bug fixes. In the kernel's string helpers there's the new function mem_is_zero(), which the EDID c

Re: [PATCH V3] video/aperture: optionally match the device in sysfb_disable()

2024-08-22 Thread Thomas Zimmermann
Am 21.08.24 um 21:11 schrieb Alex Deucher: In aperture_remove_conflicting_pci_devices(), we currently only call sysfb_disable() on vga class devices. This leads to the following problem when the pimary device is not VGA compatible: 1. A PCI device with a non-VGA class is the boot display 2.

Re: [PATCH v5 7/9] dma-buf: heaps: restricted_heap: Add MediaTek restricted heap and heap_init

2024-08-22 Thread Jens Wiklander
On Wed, May 15, 2024 at 1:25 PM Yong Wu wrote: > > Add a MediaTek restricted heap which uses TEE service call to restrict > buffer. Currently this restricted heap is NULL, Prepare for the later > patch. Mainly there are two changes: > a) Add a heap_init ops since TEE probe late than restricted hea

Re: [PATCH V3] video/aperture: optionally match the device in sysfb_disable()

2024-08-22 Thread Thomas Zimmermann
Am 21.08.24 um 21:11 schrieb Alex Deucher: In aperture_remove_conflicting_pci_devices(), we currently only call sysfb_disable() on vga class devices. This leads to the following problem when the pimary device is not VGA compatible: 1. A PCI device with a non-VGA class is the boot display 2.

[PULL] drm-xe-fixes

2024-08-22 Thread Rodrigo Vivi
Hi Dave and Sima, This is indeed a hectic week on our drm-xe-fixes. - 10 of the patches here are patches that got recent merged. - 9 are extra patches, mostly workarounds, which were already in drm-xe-next, but not picked up for fixes due the lack of Fixes tag. Lucas had identified them on a back

[PATCH] drm/panel: fix null pointer dereference in hx83102_get_modes

2024-08-22 Thread Charles Han
In hx83102_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver") Signed-off-by:

[PATCH v1] drivers:drm:exynos_drm_gsc:Fix wrong assignment in gsc_bind()

2024-08-22 Thread Yuesong Li
cocci reported a double assignment problem. Upon reviewing previous commits, it appears this may actually be an incorrect assignment. Fixes: 8b9550344d39 ("drm/ipp: clean up debug messages") Signed-off-by: Yuesong Li --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

2024-08-22 Thread Al Viro
On Thu, Aug 22, 2024 at 04:41:59PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 08:59 schrieb Al Viro: > > Once something had been put into descriptor table, the only thing you > > can do with it is returning descriptor to userland - you can't withdraw > > it on subsequent failure exit,

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-22 Thread Sergio Lopez Pascual
Gurchetan Singh writes: > On Thu, Aug 8, 2024 at 3:38 AM Sergio Lopez Pascual wrote: > >> Gurchetan Singh writes: >> >> > On Tue, Aug 6, 2024 at 1:15 PM Rob Clark wrote: >> > >> >> On Tue, Aug 6, 2024 at 9:15 AM Gurchetan Singh >> >> wrote: >> >> > >> >> > >> >> > >> >> > On Mon, Aug 5, 2024

Re: [PATCH v3 3/3] arm64: dts: mediatek: mt8186: Add svs node

2024-08-22 Thread Nícolas F . R . A . Prado
On Thu, Aug 22, 2024 at 06:46:50AM +, Rohit Agarwal wrote: > Add clock/irq/efuse setting in svs nodes for mt8186 SoC. > > Signed-off-by: Rohit Agarwal > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 20 > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/b

[PATCH v4 0/4] Add support for RZ/G2UL Display Unit

2024-08-22 Thread Biju Das
This patch series aims to add support for RZ/G2UL DU. The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The output of LCDC is connected display parallel interface (DPI) and supports a maximum resolution of WXGA along with

[PATCH v4 1/4] dt-bindings: display: renesas, rzg2l-du: Document RZ/G2UL DU bindings

2024-08-22 Thread Biju Das
Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L SoC, but has only DPI interface. While at it, add missing required property port@1 for RZ/G2L and RZ/V2L SoCs. Currently there is no user for the DPI interface and hence there won't be any ABI breakage for adding port@1 as requi

[PATCH v4 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-22 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI interface and supports a maximum resolution of WXGA along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU module i

Re: [PATCH 09/11] drm/tegra: convert to struct drm_edid

2024-08-22 Thread Jani Nikula
On Mon, 24 Jun 2024, Daniel Vetter wrote: > On Tue, May 14, 2024 at 03:55:15PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Signed-off-by: Jani Nikula >> >> --- >> >> Cc: Thierry Reding >> Cc: Mikko Perttunen

Re: [PATCH v1] drivers:smumgr:Variable names should be consistent

2024-08-22 Thread Alex Deucher
On Thu, Aug 22, 2024 at 3:49 AM Yang Ruibin <11162...@vivo.com> wrote: > > The variable highest_pcie_level_enabled is named > hightest_pcie_level_enabled in other modules. hightest is a typo. It should be highest. Please fix up the misspellings instead. Alex > Please ensure the consistency of

Re: [PATCH v2 78/86] drm/radeon: Run DRM default client setup

2024-08-22 Thread Alex Deucher
On Wed, Aug 21, 2024 at 9:06 AM Thomas Zimmermann wrote: > > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_cl

  1   2   >