Re: [PATCH v3] drm/gem: Internally test import_attach for imported objects

2025-05-05 Thread Boris Brezillon
On Wed, 30 Apr 2025 11:07:17 +0200 Simona Vetter wrote: > On Wed, Apr 16, 2025 at 11:38:03AM +0200, Simona Vetter wrote: > > On Wed, Apr 16, 2025 at 08:57:45AM +0200, Thomas Zimmermann wrote: > > > Test struct drm_gem_object.import_attach to detect imported objects. > > > > > > During object c

Re: `u64` by `u64` div/mod in DRM QR for arm32

2025-05-05 Thread Geert Uytterhoeven
Hi Russell, On Mon, 14 Apr 2025, Russell King (Oracle) wrote: On Mon, Apr 14, 2025 at 09:21:42PM +0200, Christian Schrefl wrote: Hi Miguel, On 14.04.25 8:14 PM, Miguel Ojeda wrote: Hi Jocelyn, Christian, I started build-testing arm 32-bit within my other usual routine tests, and I hi

Re: [PATCH v3 2/2] drivers: gpu: drm: panel: Add BOE TD4320

2025-05-05 Thread Neil Armstrong
On 30/04/2025 21:42, Barnabás Czémán wrote: Add driver for BOE TD4320 DSI panel, used in Xiaomi Redmi Note 7 mobile phone. Signed-off-by: Barnabás Czémán --- drivers/gpu/drm/panel/Kconfig| 9 ++ drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-

Re: [PATCH v5 2/3] drm/tidss: Update infrastructure to support K3 DSS cut-down versions

2025-05-05 Thread Devarsh Thakkar
Hi Tomi On 03/05/25 14:14, Tomi Valkeinen wrote: > On 02/05/2025 14:52, Devarsh Thakkar wrote: >> Hi, >> >> >> Ok I see what you mean to say.although functionally it is working >> fine but from readability point of view it is confusing since both >> functions use same argument name i.e hw_pl

Re: [PATCH v2 2/4] drm: panel: Add support for Renesas R61307 based MIPI DSI panel

2025-05-05 Thread Neil Armstrong
On 03/05/2025 11:41, Svyatoslav Ryhel wrote: R61307 is liquid crystal driver for high-definition amorphous silicon (a-Si) panels and is ideal for tablets and smartphones. Supported compatibles are: - hit,tx13d100vm0eaa - koe,tx13d100vm0eaa Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/

Re: [PATCH v2 4/4] drm: panel: Add support for Renesas R69328 based MIPI DSI panel

2025-05-05 Thread Neil Armstrong
On 03/05/2025 11:41, Svyatoslav Ryhel wrote: From: Maxim Schwalm Driver adds support for panels with Renesas R69328 IC Currently supported compatible is: - jdi,dx12d100vm0eaa Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Maxim Schwalm --- drivers/gpu/dr

Re: [PATCH] drm/panel: simple: Update timings for AUO G101EVN010

2025-05-05 Thread Neil Armstrong
On 28/04/2025 23:07, Kevin Baker wrote: Switch to panel timings based on datasheet for the AUO G101EVN01.0 LVDS panel. Default timings were tested on the panel. Previous mode-based timings resulted in horizontal display shift. Can you add a Fixes tag ? Thanks, Neil Signed-off-by: Kevin Bak

Re: [PATCH v3 0/2] BOE TD4320 panel

2025-05-05 Thread Neil Armstrong
Hi, On Wed, 30 Apr 2025 21:42:11 +0200, Barnabás Czémán wrote: > Add driver for BOE TD4320 DSI panel, used in Xiaomi Redmi Note 7 > smartphones. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/2] dt-bindings: display: panel: Add BOE TD4320 h

Re: [PATCH v4 21/33] drm/msm: Add _NO_SHARE flag

2025-05-05 Thread Christian König
On 5/2/25 18:56, Rob Clark wrote: > From: Rob Clark > > Buffers that are not shared between contexts can share a single resv > object. This way drm_gpuvm will not track them as external objects, and > submit-time validating overhead will be O(1) for all N non-shared BOs, > instead of O(n). > >

Re: [PATCH v6 06/10] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-05-05 Thread Jani Nikula
On Wed, 30 Apr 2025, Jeff Layton wrote: > Currently, there is no convenient way to see the info that the > ref_tracking infrastructure collects. Attempt to create a file in > debugfs when called from ref_tracker_dir_init(). > > The file is given the name "class@%px", as having the unmodified addre

Re: [PATCH v5 2/3] drm/tidss: Update infrastructure to support K3 DSS cut-down versions

2025-05-05 Thread Tomi Valkeinen
Hi, On 05/05/2025 10:49, Devarsh Thakkar wrote: Hi Tomi On 03/05/25 14:14, Tomi Valkeinen wrote: On 02/05/2025 14:52, Devarsh Thakkar wrote: Hi, Ok I see what you mean to say.although functionally it is working fine but from readability point of view it is confusing since both func

Re: [PATCH 7/8] drm/xe: Use DRM_GPU_SCHED_STAT_RUNNING to skip the reset

2025-05-05 Thread Matthew Brost
On Sat, May 03, 2025 at 05:59:58PM -0300, Maíra Canal wrote: > Xe can skip the reset if TDR has fired before the free job worker. Instead > of using the scheduler internals to add the job to the pending list, use > the DRM_GPU_SCHED_STAT_RUNNING status to skip the reset and rearm the > timer. > >

Re: [PATCH v8 06/14] tee: implement protected DMA-heap

2025-05-05 Thread Jens Wiklander
Hi, On Fri, May 2, 2025 at 3:59 PM Robin Murphy wrote: > > On 02/05/2025 10:59 am, Jens Wiklander wrote: > > Implement DMA heap for protected DMA-buf allocation in the TEE > > subsystem. > > > > Restricted memory refers to memory buffers behind a hardware enforced > > firewall. It is not accessib

Re: [PATCH 2/3] drm/panfrost: Add driver IOCTL for setting BO labels

2025-05-05 Thread Boris Brezillon
On Thu, 24 Apr 2025 03:21:31 +0100 Adrián Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. > > Signed-off-by: Adrián Larumbe Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 44 - > drivers/gpu/drm/panfrost/pa

Re: [PATCH 1/8] drm/sched: Allow drivers to skip the reset and keep on running

2025-05-05 Thread Matthew Brost
On Sat, May 03, 2025 at 05:59:52PM -0300, Maíra Canal wrote: > When the DRM scheduler times out, it's possible that the GPU isn't hung; > instead, a job may still be running, and there may be no valid reason to > reset the hardware. This can occur in two situations: > > 1. The GPU exposes some m

Re: [PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-05-05 Thread Liu Ying
On 04/30/2025, Luca Ceresoli wrote: > Hello Liu, Hi Luca, > > On Tue, 29 Apr 2025 10:10:55 +0800 > Liu Ying wrote: > >> Hi, >> >> On 04/25/2025, Luca Ceresoli wrote: >>> This is the new API for allocating DRM bridges. >>> >>> This driver embeds an array of channels in the main struct, and each

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-05 Thread Martin Blumenstingl
On Mon, May 5, 2025 at 8:43 PM I Hsin Cheng wrote: > > Coverity scan reported the usage of "mode->clock * 1000" may lead to > integer overflow. Use "1000ULL" instead of "1000" > when utilizing it to avoid potential integer overflow issue. > > Link: > https://scan5.scan.coverity.com/#/project-view

Re: [PATCH 3/3] virtgpu: deallocate capsets on device deinit

2025-05-05 Thread Dmitry Osipenko
On 5/5/25 11:59, Manos Pitsidianakis wrote: > diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c > b/drivers/gpu/drm/virtio/virtgpu_kms.c > index > 7b3c4d314f8eee692e2842a7056d6dc64936fc2f..a8b751179332b9ec2fbba1392a6ee0e638a5192e > 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_kms.c > +++ b/driv

Re: [RFC PATCH 0/2] Virtio-GPU suspend and resume

2025-05-05 Thread Dmitry Osipenko
On 4/19/25 02:29, dongwon@intel.com wrote: > From: Dongwon Kim > > This patch series introduces a freeze and restore mechanism for > the virtio-gpu driver: > > First patch adds `virtgpu_freeze` and `virtgpu_restore` functions. > These functions handle the deletion of virtio queues before sus

Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

2025-05-05 Thread Alex Hung
Reviewed-by: Alex Hung On 5/3/25 15:18, James Flowers wrote: Adds kernel-doc for externally linked dc_stream_remove_writeback function. Signed-off-by: James Flowers --- V1 -> V2: Corrected checkpatch warnings and errors drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 1 file

Re: [PATCH] drm/virtio: Fix NULL pointer deref in virtgpu_dma_buf_free_obj()

2025-05-05 Thread Dmitry Osipenko
On 5/2/25 02:24, Vivek Kasireddy wrote: > There is a chance that obj->dma_buf would be NULL by the time > virtgpu_dma_buf_free_obj() is called. This can happen for imported > prime objects, when drm_gem_object_exported_dma_buf_free() gets > called on them before drm_gem_object_free(). This is becau

Re: [PATCH v2] video: screen_info: Relocate framebuffers behind PCI bridges

2025-05-05 Thread Thomas Zimmermann
Hi Am 22.04.25 um 23:47 schrieb Bjorn Helgaas: On Tue, Apr 22, 2025 at 09:49:57AM +0200, Thomas Zimmermann wrote: Apply bridge window offsets to screen_info framebuffers during relocation. Fixes invalid access to I/O memory. Resources behind a PCI bridge can be located at a certain offset in t

Re: [PATCH 3/3] virtgpu: deallocate capsets on device deinit

2025-05-05 Thread Dmitry Osipenko
On 5/5/25 18:58, Dmitry Osipenko wrote: > On 5/5/25 11:59, Manos Pitsidianakis wrote: >> diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c >> b/drivers/gpu/drm/virtio/virtgpu_kms.c >> index >> 7b3c4d314f8eee692e2842a7056d6dc64936fc2f..a8b751179332b9ec2fbba1392a6ee0e638a5192e >> 100644 >> --- a/d

Re: [PATCH v2 2/6] bpf: Add dmabuf iterator

2025-05-05 Thread T.J. Mercier
On Mon, May 5, 2025 at 4:17 AM Christian König wrote: > > On 5/5/25 00:41, T.J. Mercier wrote: > > The dmabuf iterator traverses the list of all DMA buffers. > > > > DMA buffers are refcounted through their associated struct file. A > > reference is taken on each buffer as the list is iterated to

Re: [PATCH v1] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

2025-05-05 Thread Tomi Valkeinen
Hi, On 05/05/2025 20:47, Vitor Soares wrote: On Mon, 2025-05-05 at 18:30 +0300, Tomi Valkeinen wrote: Hi, On 05/05/2025 17:45, Vitor Soares wrote: On Tue, 2025-04-29 at 09:32 +0300, Tomi Valkeinen wrote: Hi, On 28/04/2025 12:40, Vitor Soares wrote: From: Vitor Soares The deprecated UNIVE

Re: [PATCH v2] drm/amd/display/dc/irq: Remove duplications of hpd_ack function from IRQ

2025-05-05 Thread Alex Hung
Thanks. I will send this patch for testing. Note I still see a warning of mismatch of author and SOB as below, but that can be fixed to "Sebastian Aguilera Novoa " manually after testing and before merging. $ ./scripts/checkpatch.pl v2-drm-amd-display-dc-irq-Remove-duplications-of-hpd_ack-fu

Re: [PATCH] drm/amd/display: Don't check for NULL divisor in fixpt code

2025-05-05 Thread Alex Hung
Reviewed-by: Alex Hung On 4/28/25 15:34, Harry Wentland wrote: [Why] We check for a NULL divisor but don't act on it. This check does nothing other than throw a warning. It does confuse static checkers though: See https://lkml.org/lkml/2025/4/26/371 [How] Drop the ASSERTs in both DC and SPL va

Re: [PATCH v2] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-05-05 Thread Thomas Zimmermann
Hi, there's one major issue here. You must not change the Kconfig symbols or you'll break kernel updates for a lot of people. So those TINYDRM_* must remain as is. Best regards Thomas Am 03.05.25 um 10:13 schrieb Marcus Folkesson: We start to have support many Sitronix displays in the tiny

[PATCH 1/3] virtgpu: add virtio_gpu_queue_cleanup()

2025-05-05 Thread Manos Pitsidianakis
When virtio_gpu_remove() is called, the queues are flushed and used buffers from the virtqueues are freed. However, the VIRTIO device might have left unused buffers in the avail rings, resulting in memory leaks. KASAN, slab debug and drm_mm_takedown all report the errors: BUG virtio-gpu-vbufs: Ob

[PATCH 0/3] virtgpu: fix memory leak on device removal

2025-05-05 Thread Manos Pitsidianakis
io/virtgpu_vq.c| 55 ++ 4 files changed, 75 insertions(+) --- base-commit: ad10b82c2bcac7f87ac6eaecfca33378b43425ee change-id: 20250505-virtgpu-queue-cleanup-v1-3392995cab5f -- γαῖα πυρί μιχθήτω

[PATCH 3/3] virtgpu: deallocate capsets on device deinit

2025-05-05 Thread Manos Pitsidianakis
virtio_gpu_device's capsets field is allocated with the DRM memory allocator but never freed. Add the appropriate freeing call inside virtio_gpu_deinit. Signed-off-by: Manos Pitsidianakis --- drivers/gpu/drm/virtio/virtgpu_kms.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu

[PATCH 2/3] virtgpu: add virtio_gpu_fence_cleanup()

2025-05-05 Thread Manos Pitsidianakis
When virtio_gpu_remove() is called, there might be in-flight command objects in the virtqueues that the VIRTIO device hasn't processed. These commands might use fences, which end up being leaked, as reported by /sys/kernel/debug/kmemleak. This commit adds a cleanup function that lowers the referen

[PATCH 2/2] drm/panel: Add Novatek NT37801 panel driver

2025-05-05 Thread Krzysztof Kozlowski
Add driver for the Novatek NT37801 or NT37810 AMOLED DSI 1440x3200 panel in CMD mode, used on Qualcomm MTP8750 board (SM8750). Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/pane

[PATCH 1/2] dt-bindings: display: panel: Add Novatek NT37801

2025-05-05 Thread Krzysztof Kozlowski
Add bindings for the Novatek NT37801 or NT37810 AMOLED DSI panel. Sources, like downstream DTS, schematics and hardware manuals, use two model names (NT37801 and NT37810), so choose one and hope it is correct. Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/panel/novatek,nt37801.yaml

[PATCH 0/2] drm/panel: Add Novatek NT37801 panel driver

2025-05-05 Thread Krzysztof Kozlowski
Add driver for the Novatek NT37801 or NT37810 AMOLED DSI panel, used on Qualcomm MTP8750 board (SM8750). Best regards, Krzysztof --- Krzysztof Kozlowski (2): dt-bindings: display: panel: Add Novatek NT37801 drm/panel: Add Novatek NT37801 panel driver .../bindings/display/panel/novat

Re: [PATCH v5 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-05-05 Thread Ayushi Makhija
On 4/26/2025 3:42 PM, Konrad Dybcio wrote: > On 4/24/25 8:24 AM, Ayushi Makhija wrote: >> Add anx7625 DSI to DP bridge device nodes. >> >> Signed-off-by: Ayushi Makhija >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 181 + >> 1 file changed, 181 insertions(+) >> >> dif

Re: [PATCH v2] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-05-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi, > > there's one major issue here. You must not change the Kconfig symbols or > you'll break kernel updates for a lot of people. So those TINYDRM_* must > remain as is. > I disagree. The https://docs.kernel.org/admin-guide/abi.html document explict

Re: [PATCH v2] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-05-05 Thread Thomas Zimmermann
Hi Javier, Marcus Am 05.05.25 um 11:27 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Hi, there's one major issue here. You must not change the Kconfig symbols or you'll break kernel updates for a lot of people. So those TINYDRM_* must remain as is. I disagree.

[PATCH v6 00/11] Add DSI display support for SA8775P target

2025-05-05 Thread Ayushi Makhija
This series enables the support for DSI to DP bridge ports (labled as DSI0 and DSI1) of the Qualcomm's SA8775P Ride platform. SA8775P SoC has DSI controller v2.5.1 and DSI PHY v4.2. The Ride platform is having ANX7625 DSI to DP bridge chip from Analogix. --- This patch depends on following series

[PATCH v6 08/11] drm/bridge: anx7625: enable HPD interrupts

2025-05-05 Thread Ayushi Makhija
When the device enters the suspend state, it prevents HPD interrupts from occurring. To address this, implement .hpd_enable() and .hpd_disable() callbacks functions of the drm_bridge. Signed-off-by: Ayushi Makhija Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18

[PATCH v6 10/11] drm/bridge: anx7625: fix anx7625_sink_detect() to return correct hpd status

2025-05-05 Thread Ayushi Makhija
In the anx7625_sink_detect(), the device is checked to see if it is a panel bridge, and it always sends a "connected" status to the connector. When adding the DP port on port 1 of the anx7625, it incorrectly treats it as a panel bridge and sends an always "connected" status. Instead of checking the

[PATCH v6 09/11] drm/bridge: anx7625: fix drm_bridge ops flags to support hot-plugging

2025-05-05 Thread Ayushi Makhija
The anx7625_link_bridge() checks if a device is not a panel bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT flags to the drm_bridge->ops. However, on port 1 of the anx7625 bridge, any device added is always treated as a panel bridge, preventing connector_detect() from being called. To res

[PATCH v6 06/11] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-05-05 Thread Ayushi Makhija
Add device tree nodes for the DSI0 and DSI1 controllers with their corresponding PHYs found on Qualcomm SA8775P SoC. Signed-off-by: Ayushi Makhija Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 186 +- 1 file changed

[PATCH v6 11/11] drm/bridge: anx7625: change the gpiod_set_value API

2025-05-05 Thread Ayushi Makhija
Use gpiod_set_value_cansleep() instead of gpiod_set_value() to fix the below call trace in the boot log: [5.690534] Call trace: [5.690536] gpiod_set_value+0x40/0xa4 [5.690540] anx7625_runtime_pm_resume+0xa0/0x324 [anx7625] [5.690545] __rpm_callback+0x48/0x1d8 [5.690549] rpm

[PATCH v6 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-05-05 Thread Ayushi Makhija
Add anx7625 DSI to DP bridge device nodes. Signed-off-by: Ayushi Makhija Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 183 + 1 file changed, 183 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/

Re: [PATCH v6 00/11] Add DSI display support for SA8775P target

2025-05-05 Thread Dmitry Baryshkov
On Mon, May 05, 2025 at 03:12:39PM +0530, Ayushi Makhija wrote: > This series enables the support for DSI to DP bridge ports > (labled as DSI0 and DSI1) of the Qualcomm's SA8775P Ride platform. > > SA8775P SoC has DSI controller v2.5.1 and DSI PHY v4.2. > The Ride platform is having ANX7625 DSI to

Re: [PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area

2025-05-05 Thread Jens Wiklander
Hi, On Fri, May 2, 2025 at 3:11 PM Robin Murphy wrote: > > On 02/05/2025 10:59 am, Jens Wiklander wrote: > > Export the global variable dma_contiguous_default_area so > > dev_get_cma_area() can be called a module. > > What dma_map_ops implementation is in a module? Without any other > context, I

Re: [PATCH v6 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-05-05 Thread Dmitry Baryshkov
On Mon, May 05, 2025 at 03:12:41PM +0530, Ayushi Makhija wrote: > Add anx7625 DSI to DP bridge device nodes. > > Signed-off-by: Ayushi Makhija > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 183 + > 1 file changed, 183 insertions(+) > > di

Re: [PATCH v2] drm/sitronix: move tiny Sitronix drivers to their own subdir

2025-05-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier, Marcus > > Am 05.05.25 um 11:27 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >>> Hi, >>> >>> there's one major issue here. You must not change the Kconfig symbols or >>> you'll break kernel updates for a lot of peopl

Re: [PATCH v4 06/11] firmware: qcom: scm: remove unused arguments to the shm_brige

2025-05-05 Thread Kuldeep Singh
On 4/29/2025 11:36 AM, Amirreza Zarrabi wrote: > shm_bridge create/delete functions always use the scm device. > There is no need to pass it as an argument. > > Signed-off-by: Amirreza Zarrabi There are 2 type of APIs exposed by tzmem driver for pool creation. devm_qcom_tzmem_pool_new and qc

Re: [PATCH v2 1/6] dma-buf: Rename and expose debugfs symbols

2025-05-05 Thread Christian König
On 5/5/25 00:41, T.J. Mercier wrote: > Expose the debugfs list and mutex so they are usable for the creation of > a BPF iterator for dmabufs without the need for CONFIG_DEBUG_FS. Rename > the symbols so it's clear debugfs is not required, and that the list > contains dmabufs and not some other type

Re: [PATCH 1/3] drm/shmem-helper: Import dmabuf without mapping its sg_table

2025-05-05 Thread Thomas Zimmermann
(cc'ing Christian) Hi, I don't feel qualified to fully review this patch. It would be good to have the issue with sg-tables solved, but I dislike the dedicated initializer macros. So my question is if this has any drawbacks. Or could we make this available and the default for all shmem-based

[PATCH] drm/msm/a6xx: Disable rgb565_predicator on Adreno 7c3

2025-05-05 Thread Konrad Dybcio
bank_bit = 14; gpu->ubwc_config.amsbc = 1; - gpu->ubwc_config.rgb565_predicator = 1; gpu->ubwc_config.uavflagprd_inv = 2; gpu->ubwc_config.macrotile_mode = 1; } --- base-commit: 407f60a151df3c44397e5afc0111eb9b026c38d3

Re: [PATCH 1/3] drm/shmem-helper: Import dmabuf without mapping its sg_table

2025-05-05 Thread Christian König
Hi Thomas & Shixiong, first of all the patch is still based on outdated code. For example the cache_sgt_mapping member is already removed in drm-misc-next. So if I'm not completely mistaken the issue is already resolved upstream. Regards, Christian. On 5/5/25 13:12, Thomas Zimmermann wrote: >

Re: [PATCH v8 09/14] cma: export cma_alloc() and cma_release()

2025-05-05 Thread Jens Wiklander
Hi, On Fri, May 2, 2025 at 5:50 PM Matthew Wilcox wrote: > > On Fri, May 02, 2025 at 11:59:23AM +0200, Jens Wiklander wrote: > > Export the two functions cma_alloc() and cma_release(). > > Why? This is clearly part of a larger series, but you've given those of > us who are subscribed to linux-mm

Re: [PATCH v2 2/4] drm: panel: Add support for Renesas R61307 based MIPI DSI panel

2025-05-05 Thread Svyatoslav Ryhel
пн, 5 трав. 2025 р. о 10:50 Neil Armstrong пише: > > On 03/05/2025 11:41, Svyatoslav Ryhel wrote: > > R61307 is liquid crystal driver for high-definition amorphous silicon > > (a-Si) panels and is ideal for tablets and smartphones. > > > > Supported compatibles are: > > - hit,tx13d100vm0eaa > > -

Re: [PATCH 00/11] Various dt-bindings fixes

2025-05-05 Thread Rob Herring
On Sun, May 4, 2025 at 11:13 AM Dmitry Baryshkov wrote: > > > On Thu, 06 Mar 2025 19:11:12 +0100, Konrad Dybcio wrote: > > A set of not quite related bindings warnings fixes. > > > > > > Applied, thanks! > > [02/11] dt-bindings: display: msm: sm8350-mdss: Describe the CPU-CFG icc path > ht

Re: [RFC PATCH v2 6/6] RFC: dma-buf: Remove DMA-BUF statistics

2025-05-05 Thread Christian König
On 5/5/25 00:41, T.J. Mercier wrote: > I think Android is probably the only remaining user of the dmabuf sysfs > files. The BPF infrastructure added earlier in this series will allow us > to get the same information much more cheaply. > > This patch is a RFC because I'd like to keep this for at le

Re: [PATCH v2 2/6] bpf: Add dmabuf iterator

2025-05-05 Thread Christian König
On 5/5/25 00:41, T.J. Mercier wrote: > The dmabuf iterator traverses the list of all DMA buffers. > > DMA buffers are refcounted through their associated struct file. A > reference is taken on each buffer as the list is iterated to ensure each > buffer persists for the duration of the bpf program

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-05 Thread Dmitry Baryshkov
On 05/05/2025 14:06, Luca Ceresoli wrote: Inki, Kyungmin, Seung-Woo, Alim, On Wed, 30 Apr 2025 10:08:14 +0200 Maxime Ripard wrote: Inki, Kyungmin, Seung-Woo, sorry for the mishap. Do you agree with the following patch, and it going through drm-misc? https://lore.kernel.org/dri-devel/20250424

Re: [PATCH v8 01/14] tee: tee_device_alloc(): copy dma_mask from parent device

2025-05-05 Thread Jens Wiklander
Hi, On Fri, May 2, 2025 at 3:36 PM Robin Murphy wrote: > > On 02/05/2025 10:59 am, Jens Wiklander wrote: > > If a parent device is supplied to tee_device_alloc(), copy the dma_mask > > field into the new device. This avoids future warnings when mapping a > > DMA-buf for the device. > > That also

Re: [PATCH v1 09/11] x86/mm/pat: remove MEMTYPE_*_MATCH

2025-05-05 Thread David Hildenbrand
On 28.04.25 22:23, Lorenzo Stoakes wrote: On Fri, Apr 25, 2025 at 10:17:13AM +0200, David Hildenbrand wrote: The "memramp() shrinking" scenario no longer applies, so let's remove that now-unnecessary handling. I wonder if we could remove even more of the code here given the simplifications her

Re: [PATCH v5 19/24] drm/msm/dsi: Add support for SM8750

2025-05-05 Thread Dmitry Baryshkov
On Mon, May 05, 2025 at 08:45:01AM +0200, Krzysztof Kozlowski wrote: > On 03/05/2025 00:52, Dmitry Baryshkov wrote: > > On Wed, Apr 30, 2025 at 03:00:49PM +0200, Krzysztof Kozlowski wrote: > >> Add support for DSI on Qualcomm SM8750 SoC with notable difference: > >> > >> DSI PHY PLLs, the parents o

Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-05-05 Thread Dmitry Baryshkov
On Wed, Apr 30, 2025 at 03:00:51PM +0200, Krzysztof Kozlowski wrote: > v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register > differences and new implementations of setup_alpha_out(), > setup_border_color() and setup_blend_config(). > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: K

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-05-05 Thread Luca Ceresoli
Hi Dmitry, On Mon, 5 May 2025 14:58:58 +0300 Dmitry Baryshkov wrote: > On 05/05/2025 14:06, Luca Ceresoli wrote: > > Inki, Kyungmin, Seung-Woo, Alim, > > > > On Wed, 30 Apr 2025 10:08:14 +0200 > > Maxime Ripard wrote: > > > >> Inki, Kyungmin, Seung-Woo, sorry for the mishap. Do you agree wi

Re: [PATCH v5 19/24] drm/msm/dsi: Add support for SM8750

2025-05-05 Thread Dmitry Baryshkov
On Wed, Apr 30, 2025 at 03:00:49PM +0200, Krzysztof Kozlowski wrote: > Add support for DSI on Qualcomm SM8750 SoC with notable difference: > > DSI PHY PLLs, the parents of pixel and byte clocks, cannot be used as > parents before DSI PHY is configured, the PLLs are prepared and their > initial rat

Re: (subset) [PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-05-05 Thread Heiko Stuebner
On Tue, 22 Apr 2025 15:04:39 +0800, Andy Yan wrote: > When preparing to convert the current inno hdmi driver into a > bridge driver, I found that there are several issues currently > existing with it: > > 1. When the system starts up, the first time it reads the EDID, it >will fail. This is

Re: [PATCH] drm/meson: Cast mode->clock to unsigned long long

2025-05-05 Thread I Hsin Cheng
On Sun, May 04, 2025 at 11:06:06PM +0200, Martin Blumenstingl wrote: > On Tue, Apr 29, 2025 at 11:00 PM Christophe JAILLET > wrote: > > > > Le 29/04/2025 à 21:07, I Hsin Cheng a écrit : > > > Coverity scan reported the usage of "mode->clock * 1000" may lead to > > > integer overflow. Cast the type

[PATCH] dt-bindings: display: msm: correct example in SM8350 MDSS schema

2025-05-05 Thread Dmitry Baryshkov
&config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>; +interconnect-names = "mdp0-mem", "mdp1-mem", "cpu-cfg"; power-domains = <&dispcc MDSS_GDSC>; resets = <&dispcc DISP_CC_MDSS_CORE_BCR>; --- base-commit: db76003ade5953d4a83c2bdc6e15c2d1c33e7350 change-id: 20250505-sm8350-fix-example-59d4d2dbec83 Best regards, -- Dmitry Baryshkov

Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-05-05 Thread David Hildenbrand
This change implies that we'll keep tracking the original PFN range even after splitting + partially unmapping it: not too bad, because it was not working reliably before. The only thing that kind-of worked before was shrinking such a mapping using mremap(): we managed to adjust the reservation i

Re: [PATCH v4 21/33] drm/msm: Add _NO_SHARE flag

2025-05-05 Thread Rob Clark
On Mon, May 5, 2025 at 12:54 AM Christian König wrote: > > On 5/2/25 18:56, Rob Clark wrote: > > From: Rob Clark > > > > Buffers that are not shared between contexts can share a single resv > > object. This way drm_gpuvm will not track them as external objects, and > > submit-time validating ove

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-05 Thread Dmitry Baryshkov
On 05/05/2025 09:17, Krzysztof Kozlowski wrote: On 03/05/2025 00:44, Dmitry Baryshkov wrote: On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit masks and shifts and make the code a bit more readable. Signed-o

Re: [PATCH 00/11] Various dt-bindings fixes

2025-05-05 Thread Dmitry Baryshkov
8350-mdss): interconnects: [[4294967295, 7, 0, 4294967295, 1, 0], [4294967295, 8, 0, 4294967295, 1, 0]] is too short from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8350-mdss.yaml# I've sent a patch fixing the issue, https://lore.kernel.org/linux-arm-msm/20250505-sm8

Re: [PATCH v1] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

2025-05-05 Thread Vitor Soares
On Tue, 2025-04-29 at 09:32 +0300, Tomi Valkeinen wrote: > Hi, > > On 28/04/2025 12:40, Vitor Soares wrote: > > From: Vitor Soares > > > > The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks > > for both runtime PM and system sleep. This causes the DSI clocks to be > > disabl

Re: [PATCH v4 21/33] drm/msm: Add _NO_SHARE flag

2025-05-05 Thread Christian König
On 5/5/25 16:15, Rob Clark wrote: > On Mon, May 5, 2025 at 12:54 AM Christian König > wrote: >> >> On 5/2/25 18:56, Rob Clark wrote: >>> From: Rob Clark >>> >>> Buffers that are not shared between contexts can share a single resv >>> object. This way drm_gpuvm will not track them as external obj

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-05-05 Thread Luca Ceresoli
On Mon, 5 May 2025 08:23:26 +0200 Maxime Ripard wrote: > On Mon, Apr 28, 2025 at 05:25:16PM +0200, Luca Ceresoli wrote: > > Hi Maxime, > > > > On Mon, 28 Apr 2025 13:39:23 +0200 > > Maxime Ripard wrote: > > > > > On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > > > > This i

Re: [PATCH 1/3] drm/shmem-helper: Import dmabuf without mapping its sg_table

2025-05-05 Thread Christian König
Hi Shixiong, could also be that I didn't fully got what you try to do here. Between which drivers and implementations are the BOs shared exactly? You could also just rebase your patches on drm-misc-next and send them out again and I can take another look. Regards, Christian. On 5/5/25 17:11,

Re: [PATCH v2 17/21] rust: num: Add an upward alignment helper for usize

2025-05-05 Thread Joel Fernandes
Hello, Alexandre, On 5/3/2025 10:37 AM, Alexandre Courbot wrote: > On Sat May 3, 2025 at 12:02 PM JST, Joel Fernandes wrote: >> >> >> On 5/2/2025 9:59 PM, Alexandre Courbot wrote: pub trait AlignUp { fn align_up(self, alignment: Self) -> Self; } macro_rules! align_up_i

Re: [PATCH v1] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

2025-05-05 Thread Tomi Valkeinen
Hi, On 05/05/2025 17:45, Vitor Soares wrote: On Tue, 2025-04-29 at 09:32 +0300, Tomi Valkeinen wrote: Hi, On 28/04/2025 12:40, Vitor Soares wrote: From: Vitor Soares The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks for both runtime PM and system sleep. This causes the

[PATCH v7 06/10] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-05-05 Thread Jeff Layton
Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Attempt to create a file in debugfs when called from ref_tracker_dir_init(). The file is given the name "class@%px", as having the unmodified address is helpful for debugging. This should be safe s

[PATCH v7 07/10] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file

2025-05-05 Thread Jeff Layton
Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 11 +++ lib/ref_tracker.c | 28 2 files changed, 39 insertions(+) diff --gi

[PATCH v7 08/10] net: add symlinks to ref_tracker_dir for netns

2025-05-05 Thread Jeff Layton
After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker with the ns.inum and net_cookie values in it, and register a symlink to the debugfs file for it. init_net is registered before the ref_tracker dir is created, so add a late_initcall()

[PATCH v7 09/10] i915: add ref_tracker_dir symlinks for each tracker

2025-05-05 Thread Jeff Layton
Now that there is the ability to create a symlink for each tracker, do so for the i915 entries. Signed-off-by: Jeff Layton --- drivers/gpu/drm/i915/intel_runtime_pm.c | 1 + drivers/gpu/drm/i915/intel_wakeref.c| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_r

[PATCH v7 10/10] ref_tracker: eliminate the ref_tracker_dir name field

2025-05-05 Thread Jeff Layton
Now that we have dentries and the ability to create meaningful symlinks to them, don't keep a name string in each tracker. Switch the output format to print "class@address", and drop the name field. Also, add a kerneldoc header for ref_tracker_dir_init(). Signed-off-by: Jeff Layton --- drivers/

[PATCH v7 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-05 Thread Jeff Layton
This one is quite a bit of a change from the last set. I've gone back to auto-registering the debugfs files for every ref_tracker_dir. With this, the callers should pass in a static string as a classname instead of an individual name string that gets copied. The debugfs file is given a name "class@

[PATCH v7 02/10] ref_tracker: add a top level debugfs directory for ref_tracker

2025-05-05 Thread Jeff Layton
Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 16 1 file changed, 16 insertions(+) diff

[PATCH v7 03/10] ref_tracker: have callers pass output function to pr_ostream()

2025-05-05 Thread Jeff Layton
In a later patch, we'll be adding a 3rd mechanism for outputting ref_tracker info via seq_file. Instead of a conditional, have the caller set a pointer to an output function in struct ostream. As part of this, the log prefix must be explicitly passed in, as it's too late for the pr_fmt macro. Revi

[PATCH v7 04/10] ref_tracker: add a static classname string to each ref_tracker_dir

2025-05-05 Thread Jeff Layton
A later patch in the series will be adding debugfs files for each ref_tracker that get created in ref_tracker_dir_init(). The format will be "class@%px". The current "name" string can vary between ref_tracker_dir objects of the same type, so it's not suitable for this purpose. Add a new "class" st

[PATCH v7 05/10] ref_tracker: allow pr_ostream() to print directly to a seq_file

2025-05-05 Thread Jeff Layton
Allow pr_ostream to also output directly to a seq_file without an intermediate buffer. The first caller of +ref_tracker_dir_seq_print() will come in a later patch, so mark that __maybe_unused for now. That designation will be removed once it is used. Reviewed-by: Andrew Lunn Signed-off-by: Jeff L

[PATCH v7 01/10] ref_tracker: don't use %pK in pr_ostream() output

2025-05-05 Thread Jeff Layton
As Thomas Weißschuh points out [1], it is now preferable to use %p instead of hashed pointers with printk(), since raw pointers should no longer be leaked into the kernel log. Change the ref_tracker infrastructure to use %p instead of %pK in its formats. [1]: https://lore.kernel.org/netdev/202504

Re: [PATCH v1] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()

2025-05-05 Thread Vitor Soares
On Mon, 2025-05-05 at 18:30 +0300, Tomi Valkeinen wrote: > Hi, > > On 05/05/2025 17:45, Vitor Soares wrote: > > On Tue, 2025-04-29 at 09:32 +0300, Tomi Valkeinen wrote: > > > Hi, > > > > > > On 28/04/2025 12:40, Vitor Soares wrote: > > > > From: Vitor Soares > > > > > > > > The deprecated UNIVE

Re: [PATCH v2] video: screen_info: Relocate framebuffers behind PCI bridges

2025-05-05 Thread Bjorn Helgaas
On Mon, May 05, 2025 at 03:05:34PM +0200, Thomas Zimmermann wrote: > Am 22.04.25 um 23:47 schrieb Bjorn Helgaas: > > On Tue, Apr 22, 2025 at 09:49:57AM +0200, Thomas Zimmermann wrote: > > > Apply bridge window offsets to screen_info framebuffers during > > > relocation. Fixes invalid access to I/O

[PATCH AUTOSEL 6.14 106/642] drm/amdgpu: don't free conflicting apertures for non-display devices

2025-05-05 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 9deacd6c55f1b31e5ab20db79df2e14ac480203c ] PCI_CLASS_ACCELERATOR_PROCESSING devices won't ever be the sysfb, so there is no need to free conflicting apertures. Reviewed-by: Kent Russell Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/g

[PATCH AUTOSEL 6.14 107/642] drm/amdgpu: adjust drm_firmware_drivers_only() handling

2025-05-05 Thread Sasha Levin
From: Alex Deucher [ Upstream commit e00e5c223878a60e391e5422d173c3382d378f87 ] Move to probe so we can check the PCI device type and only apply the drm_firmware_drivers_only() check for PCI DISPLAY classes. Also add a module parameter to override the nomodeset kernel parameter as a workaround

[PATCH AUTOSEL 6.14 105/642] drm/amd/display: Guard against setting dispclk low for dcn31x

2025-05-05 Thread Sasha Levin
From: Jing Zhou [ Upstream commit 9c2f4ae64bb6f6d83a54d88b9ee0f369cdbb9fa8 ] [WHY] We should never apply a minimum dispclk value while in prepare_bandwidth or while displays are active. This is always an optimizaiton for when all displays are disabled. [HOW] Defer dispclk optimization until saf

[PATCH AUTOSEL 6.14 104/642] drm/amdgpu: release xcp_mgr on exit

2025-05-05 Thread Sasha Levin
From: Flora Cui [ Upstream commit b5aaa82e2b12feaaa6958f7fa0917ddcc03c24ee ] Free on driver cleanup. Reviewed-by: Lijo Lazar Signed-off-by: Flora Cui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(

[PATCH AUTOSEL 6.14 152/642] drm/amdgpu: Update SRIOV video codec caps

2025-05-05 Thread Sasha Levin
From: David Rosca [ Upstream commit 19478f2011f8b53dee401c91423c4e0b73753e4f ] There have been multiple fixes to the video caps that are missing for SRIOV. Update the SRIOV caps with correct values. Signed-off-by: David Rosca Acked-by: Alex Deucher Reviewed-by: Ruijing Dong Signed-off-by: Al

[PATCH AUTOSEL 6.14 150/642] drm/amdgpu/gfx12: don't read registers in mqd init

2025-05-05 Thread Sasha Levin
From: Alex Deucher [ Upstream commit fc3c139cf0432b79fd08e23100a559ee51cd0be4 ] Just use the default values. There's not need to get the value from hardware and it could cause problems if we do that at runtime and gfxoff is active. Reviewed-by: Mukul Joshi Signed-off-by: Alex Deucher Signed-

[PATCH AUTOSEL 6.14 196/642] drm/amd/display: not abort link train when bw is low

2025-05-05 Thread Sasha Levin
From: Peichen Huang [ Upstream commit 8a21da2842bb22b2b80e5902d0438030d729bfd3 ] [WHY] DP tunneling should not abort link train even bandwidth become too low after downgrade. Otherwise, it would fail compliance test. [HOW} Do link train with downgrade settings even bandwidth is not enough Revi

[PATCH AUTOSEL 6.14 151/642] drm/amdgpu/gfx11: don't read registers in mqd init

2025-05-05 Thread Sasha Levin
From: Alex Deucher [ Upstream commit e27b36ea6ba5f29e91fcfb375ea29503708fcf43 ] Just use the default values. There's not need to get the value from hardware and it could cause problems if we do that at runtime and gfxoff is active. Reviewed-by: Mukul Joshi Signed-off-by: Alex Deucher Signed-

  1   2   3   4   5   >