Re: RFC: DSI panel lane frequency

2018-10-16 Thread Linus Walleij
On Tue, Oct 16, 2018 at 4:45 PM Andrzej Hajda wrote: > Yes, it is missing part, please add units (Hz ?) and some optional > propositions: > 1. maybe hs_speed instead of hs_frequency - shorter. > 2. s/operation/mode/ OK I fix! > > + unsigned long hs_frequency; > > + unsigned long lp

Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support

2018-10-16 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio Castro wrote: > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Laurent Pinchart > > --- > v1->v2: > * Added flags RCAR_DU_FEATURE_INTERLACED

RE: [PATCH 3/5] drm: rcar-du: Add r8a77470 support

2018-10-16 Thread Fabrizio Castro
Hello Laurent, Thank you for your feedback. > Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support > > Hi Fabrizio, > > Thank you for the patch. > > On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote: > > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. > > > > Si

[PATCH] gpu: ipu-v3: Fix CSI offsets for imx53

2018-10-16 Thread Steve Longerbeam
The CSI offsets are wrong for both CSI0 and CSI1. They are at physical address 0x1e03 and 0x1e038000 respectively. Fixes: 2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit") Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 4 ++-- 1 file changed, 2 insertions(+

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 01:46:09PM -0700, Deepak Rawat wrote: > Selftest for drm damage helper iterator functions. > > Cc: Daniel Vetter > Cc: alexandru-cosmin.gheor...@arm.com > Signed-off-by: Deepak Rawat > Reviewed-by: Daniel Vetter > Reviewed-by: Thomas Hellstrom I guess this needs your e

[PATCH DRM] drm: Shift * to be adjacent to pointer name

2018-10-16 Thread Mamta Shukla
Shift * to be adjacent to pointer name to follow Linux coding style. Issue found with checkpatch.pl ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Mamta Shukla --- drivers/gpu/drm/drm_memory.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v5 03/12] gpu: ipu-v3: Add planar support to interlaced scan

2018-10-16 Thread Steve Longerbeam
To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must be doubled. For full and partial planar 4:2:0 (YUV420, YVU420, NV12), chroma line stride must _not_ be double

Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Michael Ellerman
Christophe Leroy writes: > Get rid of platform specific _PAGE_ in powerpc common code and > use helpers instead. > > mm/dump_linuxpagetables.c will be handled separately > > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/book3s/32/pgtable.h

Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'

2018-10-16 Thread Michael Ellerman
YueHaibing writes: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init': > drivers/video/fbdev/chipsfb.c:352:22: warning: > variable 'size' set but not used [-Wunused-but-set-variable] > > It not used any more after commit > 8c8709334

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Christophe Leroy
On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/p

Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

2018-10-16 Thread Enric Balletbo i Serra
Ho Laurent, On 16/10/18 01:11, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote: >> This patch avoids that building the bridge/analogix source code with >> smatch triggers complaints about inconsistent in

[PATCH] drm/bufs: Fix Spectre v1 vulnerability

2018-10-16 Thread Gustavo A. R. Silva
idx can be indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/gpu/drm/drm_bufs.c:1420 drm_legacy_freebufs() warn: potential spectre issue 'dma->buflist' [r] (local cap) Fi

[PATCH v2 3/5] drm: rcar-du: Add r8a77470 support

2018-10-16 Thread Fabrizio Castro
Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver. Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart --- v1->v2: * Added flags RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC * Reworked comment drivers/gpu/drm/rcar-du/rcar_du_drv.c | 28 ++

[PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'

2018-10-16 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init': drivers/video/fbdev/chipsfb.c:352:22: warning: variable 'size' set but not used [-Wunused-but-set-variable] It not used any more after commit 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_

[PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

2018-10-16 Thread Enric Balletbo i Serra
This patch avoids that building the bridge/analogix source code with smatch triggers complaints about inconsistent indenting. It also fixes a typo in DRM_ERROR message, attch is replaced for attach. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v2: - Fix typ

[PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2018-10-16 Thread Steve Longerbeam
The function ipu_csi_init_interface() was inverting the F-bit for NTSC case, in the CCIR_CODE_1/2 registers. The result being that for NTSC bottom-top field order, the CSI would swap fields and capture in top-bottom order. Instead, base field swap on the field order of the input to the CSI, and th

Re: [PATCH v2] drm/atomic_helper: Stop modesets on unregistered connectors harder

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 04:39:46PM -0400, Lyude Paul wrote: > Unfortunately, it appears our fix in: > commit b5d29843d8ef ("drm/atomic_helper: Allow DPMS On<->Off changes > for unregistered connectors") > > Which attempted to work around the problems introduced by: > commit 4d80273976bf ("drm/atom

Re: [PATCH] drm: fix missing doc

2018-10-16 Thread Daniel Vetter
On Wed, Oct 17, 2018 at 02:10:31PM +0800, Chunming Zhou wrote: > flags is new param for drm_syncob_find_fence, so need update doc, reproduce: > make htmldocs > > reported: > htmldocs: drivers/gpu/drm/drm_syncobj.c:230: warning: Function parameter or > member 'flags' not described in 'drm_syncobj

[PATCH] drm: fix missing doc

2018-10-16 Thread Chunming Zhou
flags is new param for drm_syncob_find_fence, so need update doc, reproduce: make htmldocs reported: htmldocs: drivers/gpu/drm/drm_syncobj.c:230: warning: Function parameter or member 'flags' not described in 'drm_syncobj_find_fence' Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_syncob

[Bug 201273] Fatal error during GPU init amdgpu RX560

2018-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201273 --- Comment #4 from quirin.blae...@freenet.de --- I have mounted my monitor on the wall about a week ago. Hence the torsional moment at the HDMI-plug has changed. None of the described errors did occur since. So the crash may be triggered by a bad

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Jason Ekstrand writes: > Doing all of the CPU sampling on one side or the other of the GPU sampling > would probably reduce our window. True, although as I said, it's taking several µs to get through the loop, and the gpu clock tick is far smaller than that, so even adding the two values togethe

Re: linux-next: manual merge of the char-misc tree with the drm tree

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 02:22:57PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > MAINTAINERS > > between commit: > > fbb0de795078 ("Add udmabuf misc device") > > from the drm tree and commit: > > 9793c1fd1775 ("MAINTAI

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Jason Ekstrand writes: > The result is that we're looking at something like "end - start + > monotonic_raw_tick + max(gpu_tick, monotonic_tick)" Have I just come > full-circle? Yes. As monotonic_raw_tick and monotonic_tick are both 1... -- -keith signature.asc Description: PGP signature _

linux-next: manual merge of the char-misc tree with the drm tree

2018-10-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the char-misc tree got a conflict in: MAINTAINERS between commit: fbb0de795078 ("Add udmabuf misc device") from the drm tree and commit: 9793c1fd1775 ("MAINTAINERS: Clarify UIO vs UIOVEC maintainer") from the char-misc tree. I fixed it up (see below

[Bug 199025] Suspend hangs. Never fully suspends and impossible to return to running state. - Asus PRIME Z270-P

2018-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199025 Len Brown (l...@kernel.org) changed: What|Removed |Added CC||l...@kernel.org H

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Jason Ekstrand
On Tue, Oct 16, 2018 at 5:56 PM Keith Packard wrote: > Bas Nieuwenhuizen writes: > > > You can make the monotonic case the same as the raw case if you make > > sure to always sample the CPU first by e.g. splitting the loops into > > two and doing CPU in the first and GPU in the second. That way

[drm-tip:drm-tip 1685/1713] htmldocs: drivers/gpu/drm/drm_syncobj.c:230: warning: Function parameter or member 'flags' not described in 'drm_syncobj_find_fence'

2018-10-16 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: c4fc9e99d838c9b9a3f6bdb6e609b0cf820f9aef commit: 649fdce23cdf516e69aa8c18f4b44c62127f0e83 [1685/1713] drm: add flags to drm_syncobj_find_fence reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac8021

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Jason Ekstrand
On Tue, Oct 16, 2018 at 5:06 PM Keith Packard wrote: > Bas Nieuwenhuizen writes: > > > Well the complication here is that in the MONOTONIC (not > > MONOTONIC_RAW) case the CPU measurement can happen at the end of the > > MONOTONIC_RAW interval (as the order of measurements is based on > > argume

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Bas Nieuwenhuizen writes: > You can make the monotonic case the same as the raw case if you make > sure to always sample the CPU first by e.g. splitting the loops into > two and doing CPU in the first and GPU in the second. That way you > make the case above impossible. Right, I had thought of t

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #12 from Shmerl --- @Nicholas Kazlauskas: does it help to identify the source of the problem? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailin

[Bug 108464] System fails to reboot after Ctrl-Alt-Del

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108464 --- Comment #4 from Duncan Roe --- Created attachment 142063 --> https://bugs.freedesktop.org/attachment.cgi?id=142063&action=edit dmesg o/p as requested No Xorg involvement - boot up to command line only -- You are receiving this mail beca

[Bug 108464] System fails to reboot after Ctrl-Alt-Del

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108464 --- Comment #3 from Duncan Roe --- halt is fine btw, it's only reboot that breaks. Do you want extra debug turned on for dmesg? -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Bas Nieuwenhuizen
On Wed, Oct 17, 2018 at 12:06 AM Keith Packard wrote: > > Bas Nieuwenhuizen writes: > > > Well the complication here is that in the MONOTONIC (not > > MONOTONIC_RAW) case the CPU measurement can happen at the end of the > > MONOTONIC_RAW interval (as the order of measurements is based on > > argu

[Bug 108464] System fails to reboot after Ctrl-Alt-Del

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108464 --- Comment #2 from Duncan Roe --- Yes I thought that was weird (debug fs). But adjacent commit 30cdbfaa6aa469347db7fcda5949f1ccf7559ecf does not show the problem -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Bas Nieuwenhuizen writes: > Well the complication here is that in the MONOTONIC (not > MONOTONIC_RAW) case the CPU measurement can happen at the end of the > MONOTONIC_RAW interval (as the order of measurements is based on > argument order), so you can get a tick that started `period` (5 in > thi

[Bug 108464] System fails to reboot after Ctrl-Alt-Del

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108464 Alex Deucher changed: What|Removed |Added CC||harry.wentl...@amd.com,

[Bug 108464] System fails to reboot after Ctrl-Alt-Del

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108464 Bug ID: 108464 Summary: System fails to reboot after Ctrl-Alt-Del Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Seve

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Jason Ekstrand writes: > You've got me almost convinced as well. Thanks for the diagrams! I think > instead of adding 1 perhaps what we want is > > max2(sample_interval_ns, gpu_tick_ns + monotonic_tick_ns) > > Where monotonic_tick_ns is maybe as low as 1. Am I following you correctly? Not qu

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Bas Nieuwenhuizen
On Tue, Oct 16, 2018 at 11:07 PM Keith Packard wrote: > > Jason Ekstrand writes: > > > I think what Bas is getting at is that there are two problems: > > > > 1) We are not sampling at exactly the same time > > 2) The two clocks may not tick at exactly the same time. > > Thanks for the clarifica

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Jason Ekstrand
On Tue, Oct 16, 2018 at 4:07 PM Keith Packard wrote: > Jason Ekstrand writes: > > > I think what Bas is getting at is that there are two problems: > > > > 1) We are not sampling at exactly the same time > > 2) The two clocks may not tick at exactly the same time. > > Thanks for the clarificati

Re: [Intel-gfx] [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 02:04:21PM -0700, Manasi Navare wrote: > On Tue, Oct 16, 2018 at 10:45:55PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > > > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > > > On Tue, Oct 16, 2018 at 10:

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Jason Ekstrand writes: > I think what Bas is getting at is that there are two problems: > > 1) We are not sampling at exactly the same time > 2) The two clocks may not tick at exactly the same time. Thanks for the clarification. > If we want to be conservative, I suspect Bas may be right that

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 10:45:55PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 05, 2018 at 04:

Re: [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 12:58:24PM -0700, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Navare, Manasi D > >Sent: Friday, October 5, 2018 4:23 PM > >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > >Cc: Navare, Manasi D ; Jani Nikula > >; Ville Syrjala ;

[PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Rawat
Selftest for drm damage helper iterator functions. Cc: Daniel Vetter Cc: alexandru-cosmin.gheor...@arm.com Signed-off-by: Deepak Rawat Reviewed-by: Daniel Vetter Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/selftests/Makefile| 3 +- .../selftests/drm_damage_helper_selftests

[PATCH v2 1/2] drm/selftest: Refactor drm mode setting selftests

2018-10-16 Thread Deepak Rawat
With this patch split the kernel module specific code from actual selftest code. This is done to allow adding more selftests as separate file. Also added kernel module exit stub with this patch. Cc: Daniel Vetter Cc: alexandru-cosmin.gheor...@arm.com Signed-off-by: Deepak Rawat Reviewed-by: Dani

[PATCH v2] drm/atomic_helper: Stop modesets on unregistered connectors harder

2018-10-16 Thread Lyude Paul
Unfortunately, it appears our fix in: commit b5d29843d8ef ("drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors") Which attempted to work around the problems introduced by: commit 4d80273976bf ("drm/atomic_helper: Disallow new modesets on unregistered connectors") Is still

Re: [Freedreno] [PATCH] drm/msm: fix handling of cmdstream offset

2018-10-16 Thread Kristian Høgsberg
On Mon, Oct 15, 2018 at 10:33 AM Rob Clark wrote: > > Userspace hasn't used submit cmds with submit_offset != 0 for a while, > but this starts cropping up again with cmdstream sub-buffer-allocation > in libdrm_freedreno. > > Doesn't do much good to increment the buf ptr before assigning it. Revie

[Bug 107823] [amdgpu/displayport] Blackscreen on native resolution

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107823 --- Comment #9 from raxon...@gmail.com --- @Jan: Can you see if you get the black screen if you set amdgpu.dc=0 in the grub boot line? I am interested to help and learn something new, if you do not mind :) I dont have the monitor or else i wou

RE: [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-10-16 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Friday, October 5, 2018 4:23 PM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org >Cc: Navare, Manasi D ; Jani Nikula >; Ville Syrjala ; >Srivatsa, Anusha >Subject: [PATCH v5 20/28] drm/i915/dp: Configure i915 Picture

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 12:42:05PM -0700, Manasi Navare wrote: > On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > > On Icelake, a separate powe

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Jason Ekstrand
On Tue, Oct 16, 2018 at 2:35 PM Keith Packard wrote: > Bas Nieuwenhuizen writes: > > >> + end = radv_clock_gettime(CLOCK_MONOTONIC_RAW); > >> + > >> + uint64_t clock_period = end - begin; > >> + uint64_t device_period = DIV_ROUND_UP(100, > clock_crystal_freq); > >> + > >> +

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
On Tue, Oct 16, 2018 at 10:19:06PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > On Icelake, a separate power well PG2 is created for > > > VDSC engine used for eDP/MIPI DSI. This

Re: [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

2018-10-16 Thread Keith Packard
Bas Nieuwenhuizen writes: >> + end = radv_clock_gettime(CLOCK_MONOTONIC_RAW); >> + >> + uint64_t clock_period = end - begin; >> + uint64_t device_period = DIV_ROUND_UP(100, clock_crystal_freq); >> + >> + *pMaxDeviation = MAX2(clock_period, device_period); > > Should th

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 12:19:24PM -0700, Manasi Navare wrote: > Thanks for your review comments. > > On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > > On Icelake, a separate power well PG2 is created for > > > V

Re: [PATCH v5 26/28] drm/i915/dsc: Enable and disable appropriate power wells for VDSC

2018-10-16 Thread Ville Syrjälä
On Fri, Oct 05, 2018 at 04:23:04PM -0700, Manasi Navare wrote: > A separate power well 2 (PG2) is required for VDSC on eDP transcoder > whereas all other transcoders use the power wells associated with the > transcoders for VDSC. > This patch adds a helper to obtain correct power domain depending o

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > On Icelake, a separate power well PG2 is created for > > VDSC engine used for eDP/MIPI DSI. This patch adds a new > > display power domain for Power well 2. > > > > v

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Manasi Navare
Thanks for your review comments. On Tue, Oct 16, 2018 at 10:01:11PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > > On Icelake, a separate power well PG2 is created for > > VDSC engine used for eDP/MIPI DSI. This patch adds a new > > display power d

Re: [PATCH] drm/sti: clean up after drm_atomic_helper_shutdown rework

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 8:30 PM Benjamin Gaignard wrote: > > Le lun. 15 oct. 2018 à 10:00, Daniel Vetter a écrit : > > > > On Fri, Oct 12, 2018 at 11:46:39AM +0200, Benjamin Gaignard wrote: > > > Since drm_atomic_helper_shutdown() rework it is possible to do additional > > > clean up in sti drive

Re: [PATCH v5 19/28] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-16 Thread Ville Syrjälä
On Fri, Oct 05, 2018 at 04:22:57PM -0700, Manasi Navare wrote: > On Icelake, a separate power well PG2 is created for > VDSC engine used for eDP/MIPI DSI. This patch adds a new > display power domain for Power well 2. > > v2: > * Fix the power well mismatch CI error (Ville) > * Rename as VDSC_PIPE

[Bug 108317] [Polaris] Black Textures only on Polaris in Cemu Zelda Breath of the Wild

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108317 --- Comment #10 from John Galt --- Created attachment 142047 --> https://bugs.freedesktop.org/attachment.cgi?id=142047&action=edit apitrace of running the game, navigating the menu, and loading the game. Thank you for the attention on this is

Re: [PATCH] drm/sti: clean up after drm_atomic_helper_shutdown rework

2018-10-16 Thread Benjamin Gaignard
Le lun. 15 oct. 2018 à 10:00, Daniel Vetter a écrit : > > On Fri, Oct 12, 2018 at 11:46:39AM +0200, Benjamin Gaignard wrote: > > Since drm_atomic_helper_shutdown() rework it is possible to do additional > > clean up in sti driver: custom plane destroy functions become useless and > > clean up enco

[Bug 104362] GPU fault detected on wine-nine Path of Exile

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104362 --- Comment #9 from Vladimir Usikov --- My Radeon 7950 dead, can`t test any more. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.f

Re: [PATCH v2] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 7:28 PM Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 06:38:31PM +0200, Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 03:36:20PM +0200, Maarten Lankhorst wrote: > > > Op 15-10-18 om 19:05 schreef Rodrigo Siqueira: > > > > For historical reason, the function drm_wait_v

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 7:39 PM Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 06:41:51PM +0200, Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > > > On Tue, Oct 16, 2018 at 3:10 PM Bo

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 06:41:51PM +0200, Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > > > wrote: > > > > > > > > Hi Daniel, > > > > >

Re: [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Sean Paul
On Tue, Oct 16, 2018 at 12:44 PM Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 11:52:45AM -0400, Sean Paul wrote: > > From: Sean Paul > > > > It causes a WARN in drm_atomic_get_plane_state(), and is not used by > > atomic (or dpu). > > > > Signed-off-by: Sean Paul > > Reviewed-by: Daniel Vett

Re: [PATCH v2] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 06:38:31PM +0200, Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 03:36:20PM +0200, Maarten Lankhorst wrote: > > Op 15-10-18 om 19:05 schreef Rodrigo Siqueira: > > > For historical reason, the function drm_wait_vblank_ioctl always return > > > -EINVAL if something gets wrong.

[Bug 108317] [Polaris] Black Textures only on Polaris in Cemu Zelda Breath of the Wild

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108317 --- Comment #9 from Nicolai Hähnle --- Thanks for the report. An apitrace that reproduces the problem would be extremely helpful. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 107823] [amdgpu/displayport] Blackscreen on native resolution

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107823 --- Comment #8 from raxon...@gmail.com --- @Jan: I was wondering can you see the issue with their staging branch? Here is what I can recommend you to try : https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next If possible fo

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Lucas Stach
Am Dienstag, den 16.10.2018, 18:09 +0200 schrieb Stefan Agner: > This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. > > Using the component framework requires all components to undo in > ->unbind what ->bind does. Unfortunately that particular commit > broke this rule. In particular, th

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 06:09:23PM +0200, Stefan Agner wrote: > This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. > > Using the component framework requires all components to undo in > ->unbind what ->bind does. Unfortunately that particular commit > broke this rule. In particular, thi

Re: [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 11:52:45AM -0400, Sean Paul wrote: > From: Sean Paul > > It causes a WARN in drm_atomic_get_plane_state(), and is not used by > atomic (or dpu). > > Signed-off-by: Sean Paul Reviewed-by: Daniel Vetter I guess leftover from refactoring and upstreaming in parallel? -Dan

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > > wrote: > > > > > > Hi Daniel, > > > > > > On Tue, 16 Oct 2018 14:57:43 +0200 > > > Daniel Vetter wrote: > > > > >

Re: [PATCH v2] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 03:36:20PM +0200, Maarten Lankhorst wrote: > Op 15-10-18 om 19:05 schreef Rodrigo Siqueira: > > For historical reason, the function drm_wait_vblank_ioctl always return > > -EINVAL if something gets wrong. This scenario limits the flexibility > > for the userspace make detail

Re: [PATCH libdrm 2/2] gitignore: add _build

2018-10-16 Thread Eric Engestrom
On Tuesday, 2018-10-16 08:24:02 -0700, Lucas De Marchi wrote: > On 10/16/18 4:26 AM, Eric Engestrom wrote: > > On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote: > > > This is the directory used by meson/autotools (at least in the > > > .gitlab-ci configuration) so ignore the whole dir. >

RE: [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Singh Rawat
> > On Tue, Oct 16, 2018 at 02:21:17PM +0200, Daniel Vetter wrote: > > On Mon, Oct 15, 2018 at 04:11:41PM +, Deepak Singh Rawat wrote: > > > > On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > > > > Selftest for drm damage helper iterator functions. > > > > > > > > > > Cc: vill

Re: [PATCH 2/2 v2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-16 Thread Sam Ravnborg
Hi Linus. On Tue, Oct 16, 2018 at 02:34:09PM +0200, Linus Walleij wrote: > The Samsung S6D16D0 is a simple comman mode only DSI display > that is used on the ST-Ericsson Ux500 reference design > TVK1281618 user interface board (UIB). > > Cc: Sam Ravnborg > Cc: Andrzej Hajda > Signed-off-by: Lin

[PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Stefan Agner
This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. Using the component framework requires all components to undo in ->unbind what ->bind does. Unfortunately that particular commit broke this rule. In particular, this is an issue if a single component during probe fails. In that case, co

RE: [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-16 Thread Deepak Singh Rawat
> > > Obviously needs some adjusting on the igt side too, since we seem to be > > > missing the igt scaffolding for tests-drm-helper.ko. > > > -Daniel > > > > Hi Daniel, > > > > Thanks for the review. I am a little confused here. Should we have single > > kernel module for drm plane helper selftest

Re: [PATCH 1/2 v2] drm/panel: Add DT bindings for Samsung S6D16D0

2018-10-16 Thread Sam Ravnborg
Hi Linus. On Tue, Oct 16, 2018 at 02:34:08PM +0200, Linus Walleij wrote: > This adds the device tree bindings for the Samsung S6D16D0 > panel. This is a command mode only panel using DSI. > > Cc: devicet...@vger.kernel.org > Cc: Sam Ravnborg > Cc: Andrzej Hajda > Signed-off-by: Linus Walleij >

[PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Sean Paul
From: Sean Paul It causes a WARN in drm_atomic_get_plane_state(), and is not used by atomic (or dpu). Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dp

Re: [PATCH v2] drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread Alex Deucher
On Tue, Oct 16, 2018 at 11:00 AM Li, Sun peng (Leo) wrote: > > > > On 2018-10-16 08:33 AM, Daniel Vetter wrote: > > On Mon, Oct 15, 2018 at 09:46:40AM -0400, sunpeng...@amd.com wrote: > >> From: Leo Li > >> > >> This fixes a general protection fault, caused by accessing the contents > >> of a fli

[Bug 108379] high idle power consumption

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108379 --- Comment #1 from Alex Deucher --- Please attach your xorg log (if using X) and dmesg output. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri

Re: [PATCH 1/4] drm/scheduler: make sure timer is restarted

2018-10-16 Thread Grodzovsky, Andrey
Patches 1-3 Reviewed-by: Andrey Grodzovsky Patch 4 Acked-by: Andrey Grodzovsky Andrey On 10/16/2018 07:55 AM, Christian König wrote: > Make sure we always restart the timer after a timeout and remove the > device specific workarounds. > > Signed-off-by: Christian König > --- > drivers/gpu/

Re: [PATCH libdrm 2/2] gitignore: add _build

2018-10-16 Thread Lucas De Marchi
On 10/16/18 4:26 AM, Eric Engestrom wrote: On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote: This is the directory used by meson/autotools (at least in the .gitlab-ci configuration) so ignore the whole dir. This is extremely specific to this one case; what does this change for the g

Re: [PATCH] drm/amdgpu/vcn:Fix uninitialized symbol error

2018-10-16 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Zhu, James Sent: Tuesday, October 16, 2018 10:15:01 AM To: amd-...@lists.freedesktop.org Cc: jzh...@gmail.com; dri-devel@lists.freedesktop.org; kbu...@01.org; kbuild-...@01.org; dan.carpen...@oracle.com Subject

Re: [PATCH v2] drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-16 Thread Li, Sun peng (Leo)
On 2018-10-16 08:33 AM, Daniel Vetter wrote: > On Mon, Oct 15, 2018 at 09:46:40AM -0400, sunpeng...@amd.com wrote: >> From: Leo Li >> >> This fixes a general protection fault, caused by accessing the contents >> of a flip_done completion object that has already been freed. It occurs >> due to th

[ANNOUNCE] libdrm 2.4.96

2018-10-16 Thread robdclark
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrey Grodzovsky (2): amdgpu/test: Allow BO mapping flags to be passed in tests amdgpu/test: Fix deadlock tests for AI and RV v2 Rob Clark (14): xf86drmHash: remove redundant zero init freedreno/msm: get rid of ring_b

[Bug 201439] Amdgpu: general protection fault at dce110_vblank_set in display resume

2018-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201439 Michel Dänzer (mic...@daenzer.net) changed: What|Removed |Added CC||harry.wentl...@amd.co

Re: RFC: DSI panel lane frequency

2018-10-16 Thread Andrzej Hajda
On 16.10.2018 16:06, Linus Walleij wrote: > Hi folks, > > I just randomly add some people that committed code to the > DSI core so I can get some reasonable feedback. > > I started looking at some DSI drivers I'm adding and it seems > this platform (Ux500 MCDE) can control the bus frequency > of th

Re: [radeon-alex:drm-next-4.21-wip 10/27] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1174 vcn_v1_0_stop_dpg_mode() error: uninitialized symbol 'ret_code'.

2018-10-16 Thread James Zhu
Hi Dan, Thanks! I send out the correct patch for review. Best Regards! James Zhu On 2018-10-16 09:56 AM, Dan Carpenter wrote: > tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.21-wip > head: 6af94a9d0e185f48bef5cc1372f3ada89d003858 > commit: 15296db70619984157e60666da5da8994

[PATCH] drm/amdgpu/vcn:Fix uninitialized symbol error

2018-10-16 Thread Zhu, James
ret_code should be initialized with 0. The check of read/write ptr should be activate when UVD_POWER_STATUS_TILES is off. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0

RFC: DSI panel lane frequency

2018-10-16 Thread Linus Walleij
Hi folks, I just randomly add some people that committed code to the DSI core so I can get some reasonable feedback. I started looking at some DSI drivers I'm adding and it seems this platform (Ux500 MCDE) can control the bus frequency of the DSI interface. It can be controlled independently for

Re: [PATCH 05/10] drm/sun4i: Explicitly list and check formats supported by the frontend

2018-10-16 Thread Paul Kocialkowski
Hi, Le vendredi 23 mars 2018 à 11:06 +0100, Maxime Ripard a écrit : > On Wed, Mar 21, 2018 at 04:28:59PM +0100, Paul Kocialkowski wrote: > > In order to check whether the frontend supports a specific format, an > > explicit list and a related helper are introduced. > > > > They are then used to d

[radeon-alex:drm-next-4.21-wip 10/27] drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1174 vcn_v1_0_stop_dpg_mode() error: uninitialized symbol 'ret_code'.

2018-10-16 Thread Dan Carpenter
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.21-wip head: 6af94a9d0e185f48bef5cc1372f3ada89d003858 commit: 15296db70619984157e60666da5da8994a66870e [10/27] drm/amdgpu/vcn:Add ring W/R PTR check for VCN DPG mode stop smatch warnings: drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1174

Re: [PATCH 04/10] drm/sun4i: Explicitly list and check formats supported by the backend

2018-10-16 Thread Paul Kocialkowski
Hi, Le jeudi 29 mars 2018 à 09:56 +0200, Maxime Ripard a écrit : > On Tue, Mar 27, 2018 at 10:08:48AM +0200, Paul Kocialkowski wrote: > > On Fri, 2018-03-23 at 11:03 +0100, Maxime Ripard wrote: > > > On Wed, Mar 21, 2018 at 04:28:58PM +0100, Paul Kocialkowski wrote: > > > > In order to check wheth

Re: [PATCH] drm/edid: VSDB yCBCr420 Deep Color mode bit definitions

2018-10-16 Thread Jani Nikula
On Mon, 15 Oct 2018, "Sharma, Shashank" wrote: > Regards > > Shashank > > > On 10/15/2018 4:39 PM, Jani Nikula wrote: >> On Mon, 15 Oct 2018, Jani Nikula wrote: >>> On Fri, 05 Oct 2018, clinton.a.tay...@intel.com wrote: From: Clint Taylor HDMI Forum VSDB YCBCR420 deep color capabi

Re: [PATCH v2] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-16 Thread Maarten Lankhorst
Op 15-10-18 om 19:05 schreef Rodrigo Siqueira: > For historical reason, the function drm_wait_vblank_ioctl always return > -EINVAL if something gets wrong. This scenario limits the flexibility > for the userspace make detailed verification of the problem and take > some action. In particular, the v

[Bug 80618] [r600g] XCOM Ennemy Unknown crash (RV770)

2018-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80618 mirh changed: What|Removed |Added Status|NEW |NEEDINFO CC|

  1   2   >