Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 22:06:04) > On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > > + > > > +static int kunit_try_catch_test_init(struct kunit *test) > > > +{ > > > + struct kunit_try_catch_test_context *ctx; > > >

Re: [PATCH v12 09/18] kunit: test: add support for test abort

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 21:57:55) > On Mon, Aug 12, 2019 at 9:22 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 11:24:12) > > > diff --git a/include/kunit/test.h b/include/kunit/test.h > > > index 2625bcfeb19ac..93381f841e09f 100644 > > > --- a/include/kunit/test.h

Re: [PATCH v2 15/34] staging/vc04_services: convert put_page() to put_user_page*()

2019-08-12 Thread Stefan Wahren
On 05.08.19 00:48, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 22:02:59) > On Mon, Aug 12, 2019 at 9:56 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 17:41:05) > > > On Mon, Aug 12, 2019 at 4:59 PM Stephen Boyd wrote: > > > > > > > > > kunit_resource_destroy (respective equivalents to devm_kfree, and

Re: [PATCH v1 1/1] drm/exynos: drop use of drmP.h (2nd round)

2019-08-12 Thread Sam Ravnborg
Hi Inki. On Tue, Aug 13, 2019 at 10:03:51PM +0900, Inki Dae wrote: > Hi, > > On 19. 8. 13. 오전 3:51, Sam Ravnborg wrote: > > Hi Inki. > > > > Any plans to take this to the exynos tree? > > > > It will be merged to next. Thanks, one more off the list. Sam

Re: [PATCH v12 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:19) > Add myself as maintainer of KUnit, the Linux kernel's unit testing > framework. > > Signed-off-by: Brendan Higgins > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Logan Gunthorpe > --- Reviewed-by: Stephen Boyd

Re: [PATCH v12 11/18] kunit: test: add the concept of assertions

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:55 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:14) > > Add support for assertions which are like expectations except the test > > terminates if the assertion is not satisfied. > > > > The idea with assertions is that you use them to state all the

Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > + > > +static int kunit_try_catch_test_init(struct kunit *test) > > +{ > > + struct kunit_try_catch_test_context *ctx; > > + > > + ctx = kunit_kzalloc(test, sizeof(*ctx),

Re: [PATCH v12 05/18] kunit: test: add the concept of expectations

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 10:02 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 17:33:52) > > On Mon, Aug 12, 2019 at 04:57:00PM -0700, Stephen Boyd wrote: > > > Quoting Brendan Higgins (2019-08-12 11:24:08) > > > > + */ > > > > +#define KUNIT_EXPECT_TRUE(test, condition) \ > > > > +

Re: [PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:57 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 21:27:05) > > On Mon, Aug 12, 2019 at 4:56 PM Brendan Higgins > > wrote: > > > > > > On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd wrote: > > > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:07) > >

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:56 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 17:41:05) > > On Mon, Aug 12, 2019 at 4:59 PM Stephen Boyd wrote: > > > > > > > kunit_resource_destroy (respective equivalents to devm_kfree, and > > > > devres_destroy) and use kunit_kfree here? > > > >

Re: [PATCH v12 05/18] kunit: test: add the concept of expectations

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 17:33:52) > On Mon, Aug 12, 2019 at 04:57:00PM -0700, Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:08) > > > + */ > > > +#define KUNIT_EXPECT_TRUE(test, condition) \ > > > + KUNIT_TRUE_ASSERTION(test, KUNIT_EXPECTATION,

Re: [PATCH v12 09/18] kunit: test: add support for test abort

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:22 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:12) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > > index 2625bcfeb19ac..93381f841e09f 100644 > > --- a/include/kunit/test.h > > +++ b/include/kunit/test.h > > @@ -13,6 +13,7 @@ > >

Re: [PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 21:27:05) > On Mon, Aug 12, 2019 at 4:56 PM Brendan Higgins > wrote: > > > > On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:07) > > > > +#define KUNIT_INIT_FAIL_ASSERT_STRUCT(test, type) {

[PATCH v2 1/4] drm/komeda: Introduce komeda_coeffs_table/manager

2019-08-12 Thread james qian wang (Arm Technology China)
komeda display HWs have kinds of coefficient tables for various purposes like gamma/degamma. ususally these tables are shared by multiple HW component and have limited number. Introduce komeda_coeffs_table/manager for describing and managing these tables, like table reuse, racing. Signed-off-by:

[PATCH v2 2/4] drm/komeda: Introduce komeda_color_manager/state

2019-08-12 Thread james qian wang (Arm Technology China)
Many komeda component support color management like layer and IPS, so komeda_color_manager/state are introduced to manager gamma, csc and degamma together for easily share it to multiple componpent. And for komeda_color_manager which: - convert drm 3d gamma lut to komeda specific gamma coeffs -

[PATCH v2 3/4] drm: Increase DRM_OBJECT_MAX_PROPERTY to 32

2019-08-12 Thread james qian wang (Arm Technology China)
DRM_OBJECT_MAX_PROPERTY number 24 is not enough for komeda usage, increase it to 32 to fit komeda's requirement. Signed-off-by: James Qian Wang (Arm Technology China) --- include/drm/drm_mode_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 0/4] drm/komeda: Enable layer/plane color mgmt

2019-08-12 Thread james qian wang (Arm Technology China)
This patch series enabled layer/plane color management for komeda driver v2: Rebase it on drm-misc-next james qian wang (Arm Technology China) (4): drm/komeda: Introduce komeda_coeffs_table/manager drm/komeda: Introduce komeda_color_manager/state drm: Increase DRM_OBJECT_MAX_PROPERTY to 32

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 17:41:05) > On Mon, Aug 12, 2019 at 4:59 PM Stephen Boyd wrote: > > > > > kunit_resource_destroy (respective equivalents to devm_kfree, and > > > devres_destroy) and use kunit_kfree here? > > > > > > > Yes, or drop the API entirely? Does anything need this

[PATCH v2 4/4] drm/komeda: Enable Layer color management for komeda

2019-08-12 Thread james qian wang (Arm Technology China)
- D71 has 3 global layer gamma table which can be used for all layers as gamma lookup table, no matter inverse or forward. - Add komeda_color_manager/state to layer/layer_state for describe the color caps for the specific layer which will be initialized in d71_layer_init, and for D71 only

Re: [PATCH v12 11/18] kunit: test: add the concept of assertions

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:14) > Add support for assertions which are like expectations except the test > terminates if the assertion is not satisfied. > > The idea with assertions is that you use them to state all the > preconditions for your test. Logically speaking, these are

Re: [PATCH v12 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:20) > From: Iurii Zaikin > > KUnit tests for initialized data behavior of proc_dointvec that is > explicitly checked in the code. Includes basic parsing tests including > int min/max overflow. > > Signed-off-by: Iurii Zaikin > Signed-off-by: Brendan

Re: [PATCH v12 15/18] Documentation: kunit: add documentation for KUnit

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:18) > Add documentation for KUnit, the Linux kernel unit testing framework. > - Add intro and usage guide for KUnit > - Add API reference > > Signed-off-by: Felix Guo > Signed-off-by: Brendan Higgins > Cc: Jonathan Corbet > Reviewed-by: Greg

Re: [PATCH v2 0/2] drm/nouveau: CRTC Runtime PM ref tracking fixes

2019-08-12 Thread Ben Skeggs
On Thu, 8 Aug 2019 at 09:47, Lyude Paul wrote: > > Just some runtime PM fixes for some much less noticeable runtime PM ref > tracking issues that I got reminded of when fixing some unrelated issues > with nouveau. > > Changes since v1: > * Don't fix CRTC RPM code in dispnv04, because it's not

Re: [PATCH v2] drm/nouveau: Only recalculate PBN/VCPI on mode/connector changes

2019-08-12 Thread Ben Skeggs
On Fri, 9 Aug 2019 at 10:53, Lyude Paul wrote: > > I -thought- I had fixed this entirely, but it looks like that I didn't > test this thoroughly enough as we apparently still make one big mistake > with nv50_msto_atomic_check() - we don't handle the following scenario: > > * CRTC #1 has n VCPI

Re: [PATCH v12 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:17) > diff --git a/arch/um/configs/kunit_defconfig b/arch/um/configs/kunit_defconfig > new file mode 100644 > index 0..bfe49689038f1 > --- /dev/null > +++ b/arch/um/configs/kunit_defconfig > @@ -0,0 +1,8 @@ > +CONFIG_OF=y >

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107877 jason miller changed: What|Removed |Added URL||https://mywifiextlogn.com/ -- You are

Re: [PATCH v12 12/18] kunit: test: add tests for KUnit managed resources

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:15) > + > +static int kunit_resource_test_init(struct kunit *test) > +{ > + struct kunit_test_resource_context *ctx = > + kzalloc(sizeof(*ctx), GFP_KERNEL); > + > + if (!ctx) > + return -ENOMEM; Should this

Re: [PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 4:56 PM Brendan Higgins wrote: > > On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 11:24:07) > > > Add `struct kunit_assert` and friends which provide a structured way to > > > capture data from an expectation or an

Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:13) > + > +static int kunit_try_catch_test_init(struct kunit *test) > +{ > + struct kunit_try_catch_test_context *ctx; > + > + ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); Can this fail? Should return -ENOMEM in that case? > +

Re: [PATCH v12 09/18] kunit: test: add support for test abort

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:12) > diff --git a/include/kunit/test.h b/include/kunit/test.h > index 2625bcfeb19ac..93381f841e09f 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > struct

Re: [PATCH v1 1/1] drm/exynos: drop use of drmP.h (2nd round)

2019-08-12 Thread Inki Dae
Hi, On 19. 8. 13. 오전 3:51, Sam Ravnborg wrote: > Hi Inki. > > Any plans to take this to the exynos tree? > It will be merged to next. Thanks, Inki Dae > Sam > > On Sat, Aug 03, 2019 at 04:57:35PM +0200, Sam Ravnborg wrote: >> There was a few uses of drmP that was missed in the last

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #93 from Chris Hodapp --- Note: It might be good for someone else to double-check my conclusion before too much stock is put into it. Scientific method and all that. -- You are receiving this mail because: You are the assignee for

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #92 from ReddestDream --- >If you follow the callstack: I've been thinking all this over. The only thing unfortunately that really sticks out at me still is how Chris Hodapp says that reverting this commit:

[Bug 110457] System resumes failed and hits [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout on Acer Aspire A315-21G

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110457 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 110258] Lenovo V110-15AST AMD A9-9410 AMD R5 Stoney hangs after waking after suspend. 5.0 onwards

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110258 Alex Deucher changed: What|Removed |Added CC||jian-h...@endlessm.com --- Comment #14

[Bug 110457] System resumes failed and hits [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout on Acer Aspire A315-21G

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110457 --- Comment #11 from jian-h...@endlessm.com --- (In reply to Eugene Bright from comment #10) > The patch is on it's way > https://bugs.freedesktop.org/show_bug.cgi?id=110258#c12 I tried the patch upon Linux stable 5.2.8. It fixed this issue.

RE: [EXT] Re: [v2 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.

2019-08-12 Thread Wen He
> -Original Message- > From: Rob Herring > Sent: 2019年8月13日 7:30 > To: Wen He > Cc: linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; > devicet...@vger.kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > Leo Li > Subject: [EXT] Re: [v2 1/4] dt-bindings: display: Add

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 4:59 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 16:33:36) > > On Mon, Aug 12, 2019 at 03:55:19PM -0700, Stephen Boyd wrote: > > > Quoting Brendan Higgins (2019-08-12 11:24:06) > > > > +void string_stream_clear(struct string_stream *stream) > > > > +{ >

Re: [PATCH v12 05/18] kunit: test: add the concept of expectations

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 04:57:00PM -0700, Stephen Boyd wrote: > Quoting Brendan Higgins (2019-08-12 11:24:08) > > Add support for expectations, which allow properties to be specified and > > then verified in tests. > > > > Signed-off-by: Brendan Higgins > > Reviewed-by: Greg Kroah-Hartman > >

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 16:33:36) > On Mon, Aug 12, 2019 at 03:55:19PM -0700, Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:06) > > > +void string_stream_clear(struct string_stream *stream) > > > +{ > > > + struct string_stream_fragment *frag_container, > > >

Re: [PATCH v12 07/18] kunit: test: add initial tests

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:10) > Add a test for string stream along with a simpler example. > > Signed-off-by: Brendan Higgins > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Logan Gunthorpe > --- Reviewed-by: Stephen Boyd

Re: [PATCH v12 05/18] kunit: test: add the concept of expectations

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:08) > Add support for expectations, which allow properties to be specified and > then verified in tests. > > Signed-off-by: Brendan Higgins > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd Just some minor

Re: [PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 4:46 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:07) > > Add `struct kunit_assert` and friends which provide a structured way to > > capture data from an expectation or an assertion (introduced later in > > the series) so that it may be printed out

Re: [PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:07) > Add `struct kunit_assert` and friends which provide a structured way to > capture data from an expectation or an assertion (introduced later in > the series) so that it may be printed out in the event of a failure. > > Signed-off-by: Brendan Higgins

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 03:55:19PM -0700, Stephen Boyd wrote: > Quoting Brendan Higgins (2019-08-12 11:24:06) > > +void string_stream_clear(struct string_stream *stream) > > +{ > > + struct string_stream_fragment *frag_container, *frag_container_safe; > > + > > + spin_lock(>lock); > >

Re: [v2 1/4] dt-bindings: display: Add DT bindings for LS1028A HDP-TX PHY.

2019-08-12 Thread Rob Herring
On Fri, Jul 19, 2019 at 06:09:39PM +0800, Wen He wrote: > Add DT bindings documentmation for the HDP-TX PHY controller. The describes > which could be found on NXP Layerscape ls1028a platform. Not required, but please consider converting to DT schema (YAML) format. > > Signed-off-by: Wen He >

Re: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500

2019-08-12 Thread Rob Herring
On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote: > Add optional property node 'arm,malidp-arqos-value' for the Mali DP500. > This property describe the ARQoS levels of DP500's QoS signaling. > > Signed-off-by: Wen He > --- > Documentation/devicetree/bindings/display/arm,malidp.txt | 3

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:06) > +void string_stream_clear(struct string_stream *stream) > +{ > + struct string_stream_fragment *frag_container, *frag_container_safe; > + > + spin_lock(>lock); > + list_for_each_entry_safe(frag_container, > +

Re: [PATCH wn 3/4] dt-bindings: display: panel: add auo kd101n80-45na panel bindings

2019-08-12 Thread Rob Herring
On Sun, 11 Aug 2019 17:10:00 +0800, Jitao Shi wrote: > Add documentation for auo kd101n80-45na panel. > > Signed-off-by: Jitao Shi > Reviewed-by: Sam Ravnborg > --- > .../display/panel/auo,kd101n80-45na.txt | 34 +++ > 1 file changed, 34 insertions(+) > create mode

Re: [PATCH v12 02/18] kunit: test: add test resource management API

2019-08-12 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:05) > Create a common API for test managed resources like memory and test > objects. A lot of times a test will want to set up infrastructure to be > used in test cases; this could be anything from just wanting to allocate > some memory to setting up a

Re: [PATCH v5 1/4] dt-bindings: display: mediatek: update dpi supported chips

2019-08-12 Thread Rob Herring
On Wed, Aug 07, 2019 at 02:02:54PM +0800, Jitao Shi wrote: > Add decriptions about supported chips, including MT2701 & MT8173 & > mt8183 > > Signed-off-by: Jitao Shi > --- > .../bindings/display/mediatek/mediatek,dpi.txt| 11 +++ > 1 file changed, 11 insertions(+) And run a

Re: [PATCH v5 1/4] dt-bindings: display: mediatek: update dpi supported chips

2019-08-12 Thread Rob Herring
On Wed, Aug 07, 2019 at 02:02:54PM +0800, Jitao Shi wrote: > Add decriptions about supported chips, including MT2701 & MT8173 & > mt8183 > > Signed-off-by: Jitao Shi > --- > .../bindings/display/mediatek/mediatek,dpi.txt| 11 +++ > 1 file changed, 11 insertions(+) > > diff

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-08-12 Thread Brendan Higgins
On Fri, Aug 02, 2019 at 09:37:53AM +0200, John Ogness wrote: > On 2019-08-01, Brendan Higgins wrote: > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > >> On Thu 2019-07-25 13:21:12, Brendan Higgins wrote: > >>> On Wed, Jul 24, 2019 at 12:31 AM Petr Mladek wrote: > On Mon 2019-07-22

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-08-12 Thread Brendan Higgins
On Thu, Aug 1, 2019 at 2:43 PM Brendan Higgins wrote: > > On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-01 11:59:57) > > > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > > > wrote: > > > > > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek

Re: [PATCH v2 0/4] drm: drop drmP in tda998x, tegra, arm, armada

2019-08-12 Thread Sam Ravnborg
Hi all. On Sun, Aug 04, 2019 at 11:41:28AM +0200, Sam Ravnborg wrote: > This set of patches is one of the final steps before > we have succeeded to stop using drmP.h in all of drm/. > > There is a few patches in flight through other trees > and the plan is that all users shall be gone in the >

Re: [PATCH] nouveau/hmm: map pages after migration

2019-08-12 Thread Ralph Campbell
On 8/10/19 4:13 AM, Christoph Hellwig wrote: On something vaguely related to this patch: You use the NVIF_VMM_PFNMAP_V0_V* defines from nvif/if000c.h, which are a little odd as we only ever set these bits, but they also don't seem to appear to be in values that are directly fed to the

Re: [PATCH v2 1/1] drm/msm: drop use of drmP.h

2019-08-12 Thread Sean Paul
On Sun, Aug 04, 2019 at 08:55:51AM +0200, Sam Ravnborg wrote: > Drop the deprecated drmP.h header file, and trim msm_drv.h > to the relevant include files. > > This resulted in a suprisingly many edits as many files relied > on headers included via msm_drv.h. > But msm_drv.h is not supposed to

Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups

2019-08-12 Thread Hans de Goede
Hi, On 01-08-19 16:59, Sam Ravnborg wrote: Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote: 3 small cleanups: 1) Drop unused DRIVER_PATCHLEVEL 2) We do not set mode_config.preferred_depth, so instead of passing the unset mode_config.preferred_depth to

Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel

2019-08-12 Thread Rob Herring
On Sun, Aug 11, 2019 at 10:56 AM Sam Ravnborg wrote: > > Hi Laurent. > > My meta-schemas foo is very limited, but I noticed a few things. > Hopefully Rob finds time soon to review. > > Sam > > On Sun, Aug 11, 2019 at 02:10:42AM +0300, Laurent Pinchart wrote: > > The NEC NL8048HL11 is a

Re: [PATCH v2 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel

2019-08-12 Thread Rob Herring
On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart wrote: > > The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB > parallel data interface and an SPI control interface. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Convert to YAML > --- >

Re: [PATCH] dma-buf/sw_sync: Synchronize signal vs syncpt free

2019-08-12 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: d3862e44daa7 dma-buf/sw-sync: Fix locking around sync_timeline lists. The bot has tested the following trees: v5.2.8, v4.19.66, v4.14.138, v4.9.189. v5.2.8: Build OK! v4.19.66:

Re: [PATCH v2 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix

2019-08-12 Thread Rob Herring
On Sat, Aug 10, 2019 at 5:10 PM Laurent Pinchart wrote: > > The 'toppoly' vendor prefix is in use and refers to TPO, whose DT vendor > prefix is already defined as 'tpo'. Add 'toppoly' as an alternative and > document it as legacy. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: >

Re: [PATCH v1 1/1] drm/exynos: drop use of drmP.h (2nd round)

2019-08-12 Thread Sam Ravnborg
Hi Inki. Any plans to take this to the exynos tree? Sam On Sat, Aug 03, 2019 at 04:57:35PM +0200, Sam Ravnborg wrote: > There was a few uses of drmP that was missed in the last > patch removing this header from exynos. > > Remove the final uses of this header. > > Signed-off-by: Sam

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-12 Thread Sam Ravnborg
Hi Noralf. > > - drm_panel has proper support for modes. > > This is today duplicated in mipi_dbi. > > Could we make it so that when a panel is used then the panel > > has the mode info - as we then use the panel more in the way we do > > in other cases? > > As it is now the mode is

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #91 from ReddestDream --- >It returns 0 on success and -EIO on failure, which is then in turn returned >from vega20_set_fclk_to_highest_dpm_leve. Where did you see the check/retry on >EINVAL? Perhaps -EIO should be -EINVAL? I

[PATCH v12 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-08-12 Thread Brendan Higgins
Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section, and add Iurii as a maintainer. Signed-off-by: Brendan Higgins Cc: Iurii Zaikin Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Acked-by: Luis Chamberlain --- MAINTAINERS | 2 ++ 1 file changed, 2

[PATCH v12 05/18] kunit: test: add the concept of expectations

2019-08-12 Thread Brendan Higgins
Add support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- include/kunit/test.h | 843 +++ kunit/test.c | 58

[PATCH v12 01/18] kunit: test: add KUnit test runner core

2019-08-12 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call

[PATCH v12 15/18] Documentation: kunit: add documentation for KUnit

2019-08-12 Thread Brendan Higgins
Add documentation for KUnit, the Linux kernel unit testing framework. - Add intro and usage guide for KUnit - Add API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins Cc: Jonathan Corbet Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe ---

[PATCH v12 04/18] kunit: test: add assertion printing library

2019-08-12 Thread Brendan Higgins
Add `struct kunit_assert` and friends which provide a structured way to capture data from an expectation or an assertion (introduced later in the series) so that it may be printed out in the event of a failure. Signed-off-by: Brendan Higgins --- include/kunit/assert.h | 183

[PATCH v12 07/18] kunit: test: add initial tests

2019-08-12 Thread Brendan Higgins
Add a test for string stream along with a simpler example. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Kconfig | 21 + kunit/Makefile | 4 ++ kunit/example-test.c | 88

[PATCH v12 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-08-12 Thread Brendan Higgins
From: Iurii Zaikin KUnit tests for initialized data behavior of proc_dointvec that is explicitly checked in the code. Includes basic parsing tests including int min/max overflow. Signed-off-by: Iurii Zaikin Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan

[PATCH v12 10/18] kunit: test: add tests for kunit test abort

2019-08-12 Thread Brendan Higgins
Add KUnit tests for the KUnit test abort mechanism (see preceding commit). Add tests both for general try catch mechanism as well as non-architecture specific mechanism. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Makefile| 3 +-

[PATCH v12 09/18] kunit: test: add support for test abort

2019-08-12 Thread Brendan Higgins
Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails out of the test case early if the assertion is not met. The idea with assertions is that you use them to state all the preconditions for your test.

[PATCH v12 06/18] kbuild: enable building KUnit

2019-08-12 Thread Brendan Higgins
KUnit is a new unit testing framework for the kernel and when used is built into the kernel as a part of it. Add KUnit to the root Kconfig and Makefile to allow it to be actually built. Signed-off-by: Brendan Higgins Acked-by: Masahiro Yamada Cc: Michal Marek Reviewed-by: Greg Kroah-Hartman

[PATCH v12 11/18] kunit: test: add the concept of assertions

2019-08-12 Thread Brendan Higgins
Add support for assertions which are like expectations except the test terminates if the assertion is not satisfied. The idea with assertions is that you use them to state all the preconditions for your test. Logically speaking, these are the premises of the test case, so if a premise isn't true,

[PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-12 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. So provide a library for constructing the string as you go similar to C++'s std::string. string_stream is really just a string builder,

[PATCH v12 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-08-12 Thread Brendan Higgins
## TL;DR This revision removes dependence on kunit_stream in favor of kunit_assert, as suggested by Stephen Boyd. kunit_assert provides a more structured interface for constructing messages and allows most required data to be stored on the stack for most expectations until it is determined that a

[PATCH v12 02/18] kunit: test: add test resource management API

2019-08-12 Thread Brendan Higgins
Create a common API for test managed resources like memory and test objects. A lot of times a test will want to set up infrastructure to be used in test cases; this could be anything from just wanting to allocate some memory to setting up a driver stack; this defines facilities for creating "test

[PATCH v12 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-08-12 Thread Brendan Higgins
From: Felix Guo The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the

[PATCH v12 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-08-12 Thread Brendan Higgins
Fix the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() kunit_try_catch_throw is a function added in the following patch in this series; it allows KUnit, a unit testing framework for the

[PATCH v12 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-08-12 Thread Brendan Higgins
Add defconfig for UML and a fragment that can be used to configure other architectures for building KUnit tests. Add option to kunit_tool to use a defconfig to create the kunitconfig. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe ---

[PATCH v12 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-08-12 Thread Brendan Higgins
Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v12 12/18] kunit: test: add tests for KUnit managed resources

2019-08-12 Thread Brendan Higgins
From: Avinash Kondareddy Add unit tests for KUnit managed resources. KUnit managed resources (struct kunit_resource) are resources that are automatically cleaned up at the end of a KUnit test, similar to the concept of devm_* managed resources. Signed-off-by: Avinash Kondareddy Signed-off-by:

Re: [PATCH 4/4] drm/panel/ili9341: Support DPI panels

2019-08-12 Thread Sam Ravnborg
Hi Laurent/Noralf. On Mon, Aug 12, 2019 at 06:35:42PM +0300, Laurent Pinchart wrote: > On Mon, Aug 12, 2019 at 02:13:54PM +0200, Noralf Trønnes wrote: > > Den 11.08.2019 18.41, skrev Sam Ravnborg: > > > On Thu, Aug 01, 2019 at 03:52:49PM +0200, Noralf Trønnes wrote: > > >> Add support for panels

[Bug 203471] Tearing on Raven Ridge and RX560X PRIME setup even with Vsync enabled

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203471 --- Comment #15 from Haxk20 (haxk...@gmail.com) --- I have tried manually patching 5.3rc4 and even compiling drm-next-5.4 branch but sadly i still get tearing on the screen. Is there a config option to enable it or its enabled by default ? And as

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #90 from Tom B --- I'm not sure this is helpful but I managed to somewhat test the race condition theory. If you follow the callstack: vega20_set_fclk_to_highest_dpm_level -> smum_send_msg_to_smc_with_parameter ->

[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 --- Comment #9 from Maxim Sheviakov (shoeg...@tutanota.com) --- Thanks for your explanation. By the way, disabling runpm also seems to fix the other issue with disabling the display after activating the lockscreen as a powersaving measure. Is

Re: [PATCH] dma-buf/sw_sync: Synchronize signal vs syncpt free

2019-08-12 Thread Koenig, Christian
Am 12.08.19 um 17:42 schrieb Chris Wilson: > During release of the syncpt, we remove it from the list of syncpt and > the tree, but only if it is not already been removed. However, during > signaling, we first remove the syncpt from the list. So, if we > concurrently free and signal the syncpt,

[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 --- Comment #8 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Maxim Sheviakov from comment #7) > By the way, how *exactly* does disabling runpm affect the system? Does it > leave the discrete GPU always-on or vice verse? Or does it

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #89 from Tom B --- > It should return -EINVAL instead. Maybe then it would reset and try again > instead of just ignoring it and continuing with initialization anyway, > leading to instability. If you look at

[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 --- Comment #7 from Maxim Sheviakov (shoeg...@tutanota.com) --- By the way, how *exactly* does disabling runpm affect the system? Does it leave the discrete GPU always-on or vice verse? Or does it vary on each system? I have tried running The

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #88 from ReddestDream --- >The question then becomes: Why doesn't the race condition happen with only one >screen? Perhaps it's a matter of speed. With a single display, the driver >detect the displays, read/parse the EDID data,

[Bug 204559] amdgpu: kernel oops with constant gpu resets while using mpv

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204559 --- Comment #6 from Maxim Sheviakov (shoeg...@tutanota.com) --- Created attachment 284345 --> https://bugzilla.kernel.org/attachment.cgi?id=284345=edit dmesg -w with runpm=0 parameter I have left my laptop with a video playing for about half

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #87 from Tom B --- > Could be we've got a race condition between the powerplay setup and amdgpu handing off the card to drm_dev_register to advertise it for normal use. The question then becomes: Why doesn't the race condition

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #86 from ReddestDream --- >In addition to that, vega20_set_fclk_to_highest_dpm_level is called several >times before the card is initialized and even on 5.2.7 works. Something >happens during or just before the initialization

Re: [PATCH v3 3/3] MAINTAINERS: Update with Amlogic DRM bindings converted as YAML

2019-08-12 Thread Maxime Jourdan
On Thu, Aug 8, 2019 at 10:55 AM Neil Armstrong wrote: > > The amlogic,meson-dw-hdmi.txt and amlogic,meson-vpu.txt has been > converted to YAML schemas, update MAINTAINERS to match them again. > > Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH][drm-next] drm/amd/powerplay: remove redundant duplicated return check

2019-08-12 Thread Alex Deucher
Applied. thanks! Alex On Mon, Aug 5, 2019 at 6:29 AM Colin King wrote: > > From: Colin Ian King > > The check on ret is duplicated in two places, it is redundant code. > Remove it. > > Addresses-Coverity: ("Logically dead code") > Fixes: b94afb61cdae ("drm/amd/powerplay: honor hw limit on

Re: [PATCH] drm/amd/display: Fix a typo - dce_aduio_mask --> dce_audio_mask

2019-08-12 Thread Alex Deucher
Applied. thanks! Alex On Sat, Aug 10, 2019 at 9:55 AM Christophe JAILLET wrote: > > This should be 'dce_audio_mask', not 'dce_aduio_mask'. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +- >

  1   2   >