Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread Andrzej Hajda
On 29.08.2019 19:39, Rob Clark wrote: > On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: >> Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI >> host at probe time") landed in -next the HiKey board would fail >> to boot, looping: > No, please revert 83f35bc3a852.. that is going in

Re: [PATCH v5, 32/32] drm/mediatek: add support for mediatek SOC MT8183

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl > 2.rdma1 share drive with rdma0, but fifo size is different > 3.add mt8183 mutex private data, and mmsys

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-29 Thread David Riley
On Thu, Aug 29, 2019 at 11:09 PM Gerd Hoffmann wrote: > Hi, > > > { > > if (vbuf->resp_size > MAX_INLINE_RESP_SIZE) > > kfree(vbuf->resp_buf); > > - kfree(vbuf->data_buf); > > + kvfree(vbuf->data_buf); > > if (is_vmalloc_addr(vbuf->data_buf)) ... > > needed here I g

Re: [PATCH v5, 31/32] drm/mediatek: add connection from RDMA0 to DSI0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from RDMA0 to DSI0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insert

Re: [PATCH v5, 30/32] drm/mediatek: add connection from DITHER0 to DSI0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from DITHER0 to DSI0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 ins

Re: [PATCH v5, 29/32] drm/mediatek: add connection from OVL_2L1 to RDMA1

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from OVL_2L1 to RDMA1 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 6 ++ > 1 file changed, 6 i

Re: [PATCH v5, 28/32] drm/mediatek: add connection from OVL_2L0 to RDMA0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > this patch add add connection from OVL_2L0 to RDMA0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 14 ++ > 1 file

[Bug 103217] Recent noveau causes errors with scilab 5.5.2 on NVIDIA G84GL [Quadro FX 570]

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103217 --- Comment #9 from jaimeallen --- Much thanks for the most recent innovation. I'm completely engaged with the post of https://icasinoreviews.info/1-dollar-deposit-casinos/for the difficulties. The tip of the composing is devoured by me with res

Re: [PATCH v5, 27/32] drm/mediatek: add connection from RDMA1 to DSI0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from RDMA1 to DSI0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insert

[Bug 103217] Recent noveau causes errors with scilab 5.5.2 on NVIDIA G84GL [Quadro FX 570]

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103217 jaimeallen changed: What|Removed |Added Component|Drivers/DRI/nouveau |Drivers/DRI/i915 Assignee|nouvea

Re: [PATCH v5, 26/32] drm/mediatek: add connection from RDMA0 to COLOR0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from RDMA0 to COLOR0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 ins

[Bug 111524] AMD A9 R5 GPU doesn't work after resume

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111524 Samuel Sieb changed: What|Removed |Added Summary|GPU doesn't work after |AMD A9 R5 GPU doesn't work

[Bug 111524] GPU doesn't work after resume

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111524 Bug ID: 111524 Summary: GPU doesn't work after resume Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: not set Prio

Re: [PATCH v5, 25/32] drm/mediatek: add connection from OVL0 to OVL_2L0

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add connection from OVL0 to OVL_2L0 Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 ins

Re: [PATCH v5, 24/32] drm/mediatek: add clock property check before get it

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add clock property check before get it > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++ > 1 file changed, 6 insertions(+), 4

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-29 Thread Gerd Hoffmann
Hi, > { > if (vbuf->resp_size > MAX_INLINE_RESP_SIZE) > kfree(vbuf->resp_buf); > - kfree(vbuf->data_buf); > + kvfree(vbuf->data_buf); if (is_vmalloc_addr(vbuf->data_buf)) ... needed here I gues? > +/* Create sg_table from a vmalloc'd buffer. */ > +static struct sg

[PATCH] drm/virtio: add worker for object release

2019-08-29 Thread Gerd Hoffmann
Move object release into a separate worker. Releasing objects requires sending commands to the host. Doing that in the dequeue worker will cause deadlocks in case the command queue gets filled up, because the dequeue worker is also the one which will free up slots in the command queue. Reported-

Re: [PATCH v9 00/18] drm/virtio: switch from ttm to gem shmem helpers.

2019-08-29 Thread Gerd Hoffmann
On Thu, Aug 29, 2019 at 04:44:49PM -0700, Chia-I Wu wrote: > The series is > > Reviewed-by: Chia-I Wu Thanks. > However I ran into a deadlock with one GPU-heavy app. When I exits > Unigine Valley benchmark with ctrl-c, the entire driver locks up > probably 8 out of 10 times on my machine. W

Re: [PATCH v5, 22/32] drm/mediatek: add ovl0/ovl_2l0 usecase

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add ovl0/ovl_2l0 usecase > in ovl->ovl_2l0 direct link usecase: > 1. the crtc support layer number will 4+2 > 2. ovl_2l0 background color input select ovl0 when crtc init > an

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107877 --- Comment #30 from Kristy Murphy --- Thanks for showing this I was also looking for the same. Keep posting and help people like me. https://www.goassignmenthelp.com.au/assignment-help-melbourne/ -- You are receiving this mail because: You ar

Re: [PATCH v5, 13/32] drm/mediatek: move rdma sout from mtk_ddp_mout_en into mtk_ddp_sout_sel

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch move rdma sout from mtk_ddp_mout_en into mtk_ddp_sout_sel > rdma only has single output, but no multi output, > all these rdma->dsi/dpi usecase should move to mtk_ddp_sout_sel

Re: [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Fri, 2019-08-30 at 13:27 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > > From: Yongqiang Niu > > > > This patch add mmsys private data for ddp path config > > all these register offset and value will be differen

Re: [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add mmsys private data for ddp path config > all these register offset and value will be different in future SOC > add these define into mmsys private data > u32 ovl0_mo

Re: [PATCH v5, 11/32] drm/mediatek: split DISP_REG_CONFIG_DSI_SEL setting into another use case

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > Here is two modifition in this patch: > 1.bls->dpi0 and rdma1->dsi are differen usecase, > Split DISP_REG_CONFIG_DSI_SEL setting into anther usecase > 2.remove DISP_REG_CONFIG_DPI_SEL se

Re: [PATCH v5, 01/32] dt-bindings: mediatek: add binding for mt8183 display

2019-08-29 Thread CK Hu
Hi, Yongqiang: On Thu, 2019-08-29 at 22:50 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > Update device tree binding documention for the display subsystem for > Mediatek MT8183 SOCs > > Signed-off-by: Yongqiang Niu > --- > .../bindings/display/mediatek/mediatek,display.txt

[git pull] drm fixes for 5.3-rc7

2019-08-29 Thread Dave Airlie
Hi Linus, Nothing too crazy, there's probably more patches than I'd like at this stage, but they are all pretty self contained. Dave. drm-fixes-2019-08-30: drm fixes for 5.3-rc7 amdgpu: - Fix GFXOFF regression for PCO and RV2 - Fix missing fence reference - Fix VG20 power readings on certain SM

Re: [PATCH v5 0/5] Add HDMI jack support on RK3288

2019-08-29 Thread Cheng-yi Chiang
On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih wrote: > > On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang wrote: > > > > This patch series supports HDMI jack reporting on RK3288, which uses > > DRM dw-hdmi driver and hdmi-codec codec driver. > > > > The previous discussion about reporting jack sta

[Bug 111241] Shadertoy shader causing hang

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111241 --- Comment #10 from Dieter Nützel --- (In reply to Dieter Nützel from comment #9) > Created attachment 145215 [details] > Shadertoy-EOT-Grid-scene-2.png Saw it first @ 2. November 2018 -- You are receiving this mail because: You are the assi

[Bug 111241] Shadertoy shader causing hang

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111241 --- Comment #9 from Dieter Nützel --- Created attachment 145215 --> https://bugs.freedesktop.org/attachment.cgi?id=145215&action=edit Shadertoy-EOT-Grid-scene-2.png -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 111241] Shadertoy shader causing hang

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111241 --- Comment #8 from Dieter Nützel --- BTW Pierre-Eric can you look into this Shadertoy shader corruption, too? https://www.shadertoy.com/view/Xt3cWS I get it with Konqueror 5.0.97 KDE Frameworks 5.61.0 Qt 5.13.0 And Firefox 68.0.1 -- You

[Bug 111241] Shadertoy shader causing hang

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111241 --- Comment #7 from Dieter Nützel --- Works for me with commit # glsl: replace 'x + (-x)' with constant 0 https://cgit.freedesktop.org/mesa/mesa/commit/?id=47cc660d9c19572e5ef2dce7c8ae1766a2ac9885 Thanks Pierre-Eric! -- You are receiving thi

Re: [PATCH v9 00/18] drm/virtio: switch from ttm to gem shmem helpers.

2019-08-29 Thread Chia-I Wu
The series is Reviewed-by: Chia-I Wu However I ran into a deadlock with one GPU-heavy app. When I exits Unigine Valley benchmark with ctrl-c, the entire driver locks up probably 8 out of 10 times on my machine. When that happens, virtio_gpu_dequeue_ctrl_func does not return and is blocked in

Re: [BACKPORT 4.19.y 3/3] drm/tilcdc: Register cpufreq notifier after we have initialized crtc

2019-08-29 Thread Sasha Levin
On Thu, Aug 29, 2019 at 02:00:01PM -0600, Mathieu Poirier wrote: From: Jyri Sarha commit 432973fd3a20102840d5f7e61af9f1a03c217a4c upstream Register cpufreq notifier after we have initialized the crtc and unregister it before we remove the ctrc. Receiving a cpufreq notify without crtc causes a

Re: [BACKPORT 4.19.y 2/3] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value

2019-08-29 Thread Sasha Levin
On Thu, Aug 29, 2019 at 02:00:00PM -0600, Mathieu Poirier wrote: From: Pedro Sousa commit ebcb8f8508c5edf428f52525cec74d28edea7bcb upstream Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9 according to MIPI Alliance MPHY specification. Fixes: e785060ea3a1 ("ufs: definitions

Re: [BACKPORT 4.19.y 1/3] drm/bridge: tfp410: fix memleak in get_modes()

2019-08-29 Thread Sasha Levin
On Thu, Aug 29, 2019 at 01:59:59PM -0600, Mathieu Poirier wrote: From: Tomi Valkeinen commit c08f99c39083ab55a9c93b3e93cef48711294dad upstream We don't free the edid blob allocated by the call to drm_get_edid(), causing a memleak. Fix this by calling kfree(edid) at the end of the get_modes().

Re: [PATCH] drm: dw-hdmi-i2s: enable audio clock in audio_startup

2019-08-29 Thread Doug Anderson
Hi, On Wed, Aug 28, 2019 at 9:30 PM Cheng-Yi Chiang wrote: > > In the designware databook, the sequence of enabling audio clock and > setting format is not clearly specified. > Currently, audio clock is enabled in the end of hw_param ops after > setting format. > > On some monitors, there is a po

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-08-29 Thread mikhail . v . gavrilov
On Sun, Aug 25, 2019 at 10:13:05PM +0800, Hillf Danton wrote: > Can we try to add the fallback timer manually? > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > @@ -322,6 +322,10 @@ int amdgpu_fence_wait_empty(struct amdgp > } >

[Bug 109628] WARNING at dcn10_hw_sequencer.c:868 dcn10_verify_allow_pstate_change_high()

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109628 --- Comment #6 from Johannes Hirte --- seeing similar with a Dell Latitude 5495 with AMD Ryzen 5 PRO 2500U: kernel is 5.2.10 [ 1795.534761] [ cut here ] [ 1795.534791] WARNING: CPU: 7 PID: 765 at drivers/gpu/drm/amd/amd

[Bug 111414] [REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_state after removal of the blend state NULL check

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111414 Edmondo Tommasina changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-29 Thread David Riley
Userspace requested command buffer allocations could be too large to make as a contiguous allocation. Use vmalloc if necessary to satisfy those allocations. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 74 +++

[Bug 111414] [REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_state after removal of the blend state NULL check

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111414 --- Comment #7 from Dieter Nützel --- @Marek This one could be CLOSED. Your commit SOLVED it. My reported 'mpv' bug is compilation related. mpv: ../src/gallium/state_trackers/vdpau/vdpau_private.h:138: FormatYCBCRToPipe: Assertion `0' failed.

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

2019-08-29 Thread Sasha Levin
On Thu, Aug 29, 2019 at 02:44:15PM -0400, Sean Paul wrote: On Thu, Aug 29, 2019 at 01:06:58PM -0400, Lyude Paul wrote: Is it worth actually CCing stable on this? This patch is certainly correct but I don't think we use this struct for anything quite yet. Otherwise: Reviewed-by: Lyude Paul Th

[BACKPORT 4.19.y 1/3] drm/bridge: tfp410: fix memleak in get_modes()

2019-08-29 Thread Mathieu Poirier
From: Tomi Valkeinen commit c08f99c39083ab55a9c93b3e93cef48711294dad upstream We don't free the edid blob allocated by the call to drm_get_edid(), causing a memleak. Fix this by calling kfree(edid) at the end of the get_modes(). Signed-off-by: Tomi Valkeinen Signed-off-by: Andrzej Hajda Link:

[BACKPORT 4.19.y 0/3] Candidate from TI 4.19 product kernel

2019-08-29 Thread Mathieu Poirier
I re-used the same scripted approach taken by Arnd [1] to look at patches backported to TI's ti-linux-4.19.y tree [2] (the full list can be found below). Out of the lot about a hundred were considered but most of them either didn't apply cleanly, involved multiple files or did not compile. The

[BACKPORT 4.19.y 2/3] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value

2019-08-29 Thread Mathieu Poirier
From: Pedro Sousa commit ebcb8f8508c5edf428f52525cec74d28edea7bcb upstream Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9 according to MIPI Alliance MPHY specification. Fixes: e785060ea3a1 ("ufs: definitions for phy interface") Signed-off-by: Pedro Sousa Signed-off-by: Mart

[BACKPORT 4.19.y 3/3] drm/tilcdc: Register cpufreq notifier after we have initialized crtc

2019-08-29 Thread Mathieu Poirier
From: Jyri Sarha commit 432973fd3a20102840d5f7e61af9f1a03c217a4c upstream Register cpufreq notifier after we have initialized the crtc and unregister it before we remove the ctrc. Receiving a cpufreq notify without crtc causes a crash. Reported-by: Peter Ujfalusi Signed-off-by: Jyri Sarha Sig

Re: Couldn't read Speaker Allocation Data Block/SADs

2019-08-29 Thread Alex Deucher
On Thu, Aug 29, 2019 at 9:11 AM Jean Delvare wrote: > > Hi all, > > Since I connected my Dell display on my Radeon R5 240 (Oland) card over > DisplayPort instead of VGA, I get the following error messages logged at > every boot: > > [drm:dce_v6_0_encoder_mode_set [amdgpu]] *ERROR* Couldn't read S

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

2019-08-29 Thread Sean Paul
On Thu, Aug 29, 2019 at 01:06:58PM -0400, Lyude Paul wrote: > Is it worth actually CCing stable on this? This patch is certainly correct but > I don't think we use this struct for anything quite yet. > > Otherwise: Reviewed-by: Lyude Paul Thanks for the review! I've stripped the cc stable tag an

[PATCH AUTOSEL 4.14 09/27] drm/mediatek: set DMA max segment size

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 07098e820b9a89c570b91b1f21762f62b288 ] This driver requires imported PRIME buffers to appear contiguously in its IO address space. Make sure this is the case by setting the maximum DMA segment size to a more suitable value than the default 64KB. Sig

[PATCH AUTOSEL 4.14 08/27] drm/mediatek: use correct device to import PRIME buffers

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 4c6f3196e6ea111c456c6086dc3f57d4706b0b2d ] PRIME buffers should be imported using the DMA device. To this end, use a custom import function that mimics drm_gem_prime_import_dev(), but passes the correct device. Fixes: 119f5173628aa ("drm/mediatek: Add D

[PATCH AUTOSEL 4.19 15/45] drm/mediatek: set DMA max segment size

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 07098e820b9a89c570b91b1f21762f62b288 ] This driver requires imported PRIME buffers to appear contiguously in its IO address space. Make sure this is the case by setting the maximum DMA segment size to a more suitable value than the default 64KB. Sig

[PATCH AUTOSEL 4.19 14/45] drm/mediatek: use correct device to import PRIME buffers

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 4c6f3196e6ea111c456c6086dc3f57d4706b0b2d ] PRIME buffers should be imported using the DMA device. To this end, use a custom import function that mimics drm_gem_prime_import_dev(), but passes the correct device. Fixes: 119f5173628aa ("drm/mediatek: Add D

[PATCH AUTOSEL 5.2 65/76] drm/amdgpu: prevent memory leaks in AMDGPU_CS ioctl

2019-08-29 Thread Sasha Levin
From: Nicolai Hähnle [ Upstream commit 1a701ea924815b0518733aa8d5d05c1f6fa87062 ] Error out if the AMDGPU_CS ioctl is called with multiple SYNCOBJ_OUT and/or TIMELINE_SIGNAL chunks, since otherwise the last chunk wins while the allocated array as well as the reference counts of sync objects are

[PATCH AUTOSEL 5.2 28/76] drm/mediatek: set DMA max segment size

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 07098e820b9a89c570b91b1f21762f62b288 ] This driver requires imported PRIME buffers to appear contiguously in its IO address space. Make sure this is the case by setting the maximum DMA segment size to a more suitable value than the default 64KB. Sig

[PATCH AUTOSEL 5.2 27/76] drm/mediatek: use correct device to import PRIME buffers

2019-08-29 Thread Sasha Levin
From: Alexandre Courbot [ Upstream commit 4c6f3196e6ea111c456c6086dc3f57d4706b0b2d ] PRIME buffers should be imported using the DMA device. To this end, use a custom import function that mimics drm_gem_prime_import_dev(), but passes the correct device. Fixes: 119f5173628aa ("drm/mediatek: Add D

[PATCH] Revert "drm/bridge: adv7511: Attach to DSI host at probe time"

2019-08-29 Thread Rob Clark
From: Rob Clark This reverts commit 83f35bc3a852f1c3892c7474998c5cec707c7ba3. This commit the wrong direction, we should really be changing panel framework to attach dsi host after probe, rather than introducing the same probe-order problem that panels already have to bridges. The reason is, th

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread Rob Clark
On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: > > Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI > host at probe time") landed in -next the HiKey board would fail > to boot, looping: No, please revert 83f35bc3a852.. that is going in the *complete* wrong direction. We actual

Re: [Freedreno] [PATCH v7 6/7] drm/msm/gpu: add ocmem init/cleanup functions

2019-08-29 Thread Jordan Crouse
On Fri, Aug 23, 2019 at 05:16:36AM -0700, Brian Masney wrote: > The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support > that was missing upstream. Add two new functions (adreno_gpu_ocmem_init > and adreno_gpu_ocmem_cleanup) that removes some duplicated code. Reviewed-by: Jordan Cro

[PATCH 10/10] drm/msm: add atomic traces

2019-08-29 Thread Rob Clark
From: Rob Clark This was useful for debugging fps drops. I suspect it will be useful again. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/msm_atomic.c | 24 +++- drivers/gpu/drm/msm/msm_atomic_trace.h | 110 ++

[PATCH 09/10] drm/msm/dpu: async commit support

2019-08-29 Thread Rob Clark
From: Rob Clark In addition, moving to kms->flush_commit() lets us drop the only user of kms->commit(). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 -- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 5

[PATCH 08/10] drm/msm: async commit support

2019-08-29 Thread Rob Clark
From: Rob Clark Now that flush/wait/complete is decoupled from the "synchronous" part of atomic commit_tail(), add support to defer flush to a timer that expires shortly before vblank for async commits. In this way, multiple atomic commits (for example, cursor updates) can be coalesced into a si

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

2019-08-29 Thread Lyude Paul
Is it worth actually CCing stable on this? This patch is certainly correct but I don't think we use this struct for anything quite yet. Otherwise: Reviewed-by: Lyude Paul On Thu, 2019-08-29 at 12:52 -0400, Sean Paul wrote: > From: Sean Paul > > Spec says[1] Allocated_PBN is 16 bits > > [1]- D

[PATCH 07/10] drm/msm: split power control from prepare/complete_commit

2019-08-29 Thread Rob Clark
From: Rob Clark With atomic commit, ->prepare_commit() and ->complete_commit() may not be evenly balanced (although ->complete_commit() will complete each crtc that had been previously prepared). So these will no longer be a good place to enable/disable clocks needed for hw access. Signed-off-b

[PATCH 06/10] drm/msm: add kms->flush_commit()

2019-08-29 Thread Rob Clark
From: Rob Clark Add ->flush_commit(crtc_mask). Currently a no-op, but kms backends should migrate writing flush registers to this hook, so we can decouple pushing updates to hardware, and flushing the updates. Once we add async commit support, the hw updates will be pushed down to the hw synchr

[PATCH 05/10] drm/msm: convert kms->complete_commit() to crtc_mask

2019-08-29 Thread Rob Clark
From: Rob Clark Prep work for async commits, in which case this will be called after we no longer have the atomic state object. This drops some wait_for_vblanks(), but those should be unnecessary, as we call this after waiting for flush to complete. Signed-off-by: Rob Clark --- drivers/gpu/dr

[PATCH 04/10] drm/msm: add kms->wait_flush()

2019-08-29 Thread Rob Clark
From: Rob Clark First step in re-working the atomic related internal API to prepare for async updates pending.. ->wait_flush() is intended to block until there is no in-progress flush. A crtc_mask is used, rather than an atomic state object, as this will later be used for async flush after the a

[PATCH 03/10] drm/msm/dpu: handle_frame_done() from vblank irq

2019-08-29 Thread Rob Clark
From: Rob Clark Previously the callback was called from whoever called wait_for_vblank(), but that isn't a great plan when wait_for_vblank() stops getting called, and results in frame_done_timer expiring. Signed-off-by: Rob Clark Reviewed-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_cr

[PATCH 02/10] drm/msm/dpu: add real wait_for_commit_done()

2019-08-29 Thread Rob Clark
From: Rob Clark Just waiting for next vblank isn't ideal.. we should really be looking at the hw FLUSH register value to know if there is still an in-progress flush without stalling unnecessarily when there is no pending flush. Signed-off-by: Rob Clark Reviewed-by: Sean Paul --- .../drm/msm/d

[PATCH] drm: mst: Fix query_payload ack reply struct

2019-08-29 Thread Sean Paul
From: Sean Paul Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave Airlie Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul

[PATCH 01/10] drm/msm/dpu: unwind async commit handling

2019-08-29 Thread Rob Clark
From: Rob Clark It attempted to avoid fps drops in the presence of cursor updates. But it is racing, and can result in hw updates after flush before vblank, which leads to underruns. Signed-off-by: Rob Clark Reviewed-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 41

[PATCH v3 02/11] drm/msm: remove unlikely() from WARN_ON() conditions

2019-08-29 Thread Denis Efremov
"unlikely(WARN_ON(x))" is excessive. WARN_ON() already uses unlikely() internally. Signed-off-by: Denis Efremov Cc: Rob Clark Cc: Sean Paul Cc: Joe Perches Cc: Andrew Morton Cc: linux-arm-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 4

[PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls

2019-08-29 Thread Denis Efremov
IS_ERR(), IS_ERR_OR_NULL(), IS_ERR_VALUE() and WARN*() already contain unlikely() optimization internally. Thus, there is no point in calling these functions and defines under likely()/unlikely(). This check is based on the coccinelle rule developed by Enrico Weigelt https://lore.kernel.org/lkml/1

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-08-29 Thread Andrzej Hajda
On 26.08.2019 18:27, Laurent Pinchart wrote: > Hi Andrzej, > > On Thu, Aug 22, 2019 at 02:17:16PM +0200, Andrzej Hajda wrote: >> On 20.08.2019 00:45, Laurent Pinchart wrote: >>> On Mon, Aug 19, 2019 at 10:38:35AM +0200, Andrzej Hajda wrote: On 14.08.2019 14:40, Daniel Vetter wrote: > On We

[PATCH 00/10] drm/msm: async commit support (v2)

2019-08-29 Thread Rob Clark
From: Rob Clark Currently the dpu backend attempts to handle async commits. But it is racey and could result in flushing multiple times in a frame, or modifying hw state (such as scanout address or cursor position) after the previous flush, but before vblank, causing underflows (which manifest a

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 Robert changed: What|Removed |Added Priority|not set |medium -- You are receiving this mail because

Re: [PATCH v3 0/8] Add dual-LVDS panel support to EK874

2019-08-29 Thread Rob Herring
On Wed, Aug 28, 2019 at 1:36 PM Fabrizio Castro wrote: > > Dear All, > > this series adds support for dual-LVDS panel IDK-2121WR > from Advantech: > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > > V3 approaches the problem in a completely differ

Re: [PATCH V3] drm: Add LTTPR defines for DP 1.4a

2019-08-29 Thread Harry Wentland
On 2019-08-28 3:52 p.m., Siqueira, Rodrigo wrote: > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) > which is required to add support for systems with Thunderbolt or other > repeater devices. > > Changes since V2: > - Drop the kernel-doc comment > - Reorder LTTPR accordin

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread Andrzej Hajda
On 29.08.2019 08:05, John Stultz wrote: > Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI > host at probe time") landed in -next the HiKey board would fail > to boot, looping: > > adv7511 2-0039: failed to find dsi host > > messages over and over. Andrzej Hajda suggested this is du

[PATCH v5, 03/32] dt-bindings: mediatek: add ccorr description for mt8183 display

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu Update device tree binding documention for the display subsystem for Mediatek MT8183 SOCs Signed-off-by: Yongqiang Niu Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Doc

[PATCH v5, 10/32] drm/mediatek: add mutex sof register offset into ddp private data

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu mutex sof register offset will be private data of ddp Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/dri

[PATCH v5, 11/32] drm/mediatek: split DISP_REG_CONFIG_DSI_SEL setting into another use case

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu Here is two modifition in this patch: 1.bls->dpi0 and rdma1->dsi are differen usecase, Split DISP_REG_CONFIG_DSI_SEL setting into anther usecase 2.remove DISP_REG_CONFIG_DPI_SEL setting, DPI_SEL_IN_BLS is 0 and this is same with hardware defautl setting, Signed-off-by: Yongqi

[PATCH v5, 01/32] dt-bindings: mediatek: add binding for mt8183 display

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu Update device tree binding documention for the display subsystem for Mediatek MT8183 SOCs Signed-off-by: Yongqiang Niu --- .../bindings/display/mediatek/mediatek,display.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/dev

[PATCH v5, 08/32] drm/mediatek: add mutex mod register offset into ddp private data

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu mutex mod register offset will be private data of ddp. Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_

[PATCH v5, 15/32] drm/mediatek: add commponent OVL_2L0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add commponent OVL_2L0 Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp

[PATCH v5, 09/32] drm/mediatek: add mutex sof into ddp private data

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu mutex sof will be ddp private data Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 43 +++--- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/d

[PATCH v5, 17/32] drm/mediatek: add component DITHER

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add component DITHER Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 32 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 ++ 2 files changed, 34 insertions(+) diff --git a/drivers/

[PATCH v5, 20/32] drm/mediatek: add function to background color input select for ovl/ovl_2l direct link

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add function to background color input select for ovl/ovl_2l direct link for ovl/ovl_2l direct link usecase, we need set background color input select for these hardware. this is preparation patch for ovl/ovl_2l usecase Signed-off-by: Yongqiang Niu Reviewed-by: C

[PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add mmsys private data for ddp path config all these register offset and value will be different in future SOC add these define into mmsys private data u32 ovl0_mout_en; u32 rdma1_sout_sel_in; u32 rdma1_sout_dsi0; u32 dpi0_sel_in;

[PATCH v5, 18/32] drm/mediatek: add gmc_bits for ovl private data

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add gmc_bits for ovl private data GMC register was set RDMA ultra and pre-ultra threshold. 10bit GMC register define is different with other SOC, gmc_thrshd_l not used. Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c |

[PATCH v5, 29/32] drm/mediatek: add connection from OVL_2L1 to RDMA1

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add connection from OVL_2L1 to RDMA1 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 943e114..

[PATCH v5, 31/32] drm/mediatek: add connection from RDMA0 to DSI0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add connection from RDMA0 to DSI0 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index fd38658..6a7cb

[PATCH v5, 16/32] drm/mediatek: add component OVL_2L1

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add component OVL_2L1 Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_co

[PATCH v5, 22/32] drm/mediatek: add ovl0/ovl_2l0 usecase

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add ovl0/ovl_2l0 usecase in ovl->ovl_2l0 direct link usecase: 1. the crtc support layer number will 4+2 2. ovl_2l0 background color input select ovl0 when crtc init and disable it when crtc finish 3. config ovl_2l0 layer, if crtc config layer number is bigger than o

[PATCH v5, 28/32] drm/mediatek: add connection from OVL_2L0 to RDMA0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu this patch add add connection from OVL_2L0 to RDMA0 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c i

[PATCH v5, 32/32] drm/mediatek: add support for mediatek SOC MT8183

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add support for mediatek SOC MT8183 1.ovl_2l share driver with ovl 2.rdma1 share drive with rdma0, but fifo size is different 3.add mt8183 mutex private data, and mmsys private data 4.add mt8183 main and external path module for crtc create Signed-off-by: Yongqiang

[PATCH v5, 27/32] drm/mediatek: add connection from RDMA1 to DSI0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add connection from RDMA1 to DSI0 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 03a46ec..aa617

[PATCH v5, 23/32] drm/mediatek: distinguish ovl and ovl_2l by layer_nr

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu distinguish ovl and ovl_2l by layer_nr when get comp id Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drive

[PATCH v5, 26/32] drm/mediatek: add connection from RDMA0 to COLOR0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add connection from RDMA0 to COLOR0 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 42a130a..03

[PATCH v5, 25/32] drm/mediatek: add connection from OVL0 to OVL_2L0

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add connection from OVL0 to OVL_2L0 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index effc24a..42

[PATCH v5, 14/32] drm/mediatek: add ddp component CCORR

2019-08-29 Thread yongqiang.niu
From: Yongqiang Niu This patch add ddp component CCORR Signed-off-by: Yongqiang Niu Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 32 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 ++ 2 files changed, 34 insertions(+) diff --git a/drive

  1   2   3   >