Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-15 Thread Tony Lindgren
* H. Nikolaus Schaller [200415 16:43]: > If you agree I can add the clocks/clock-names property as an > optional property. This should solve omap and all others. Yes the clock can be optional property no problem. If we have a clock, we just enable/disable it from the pvr_runtime_suspend() and pvr

[PATCH v6 11/12] ARM: dts: sun8i: a83t: add sgx gpu child node

2020-04-15 Thread H. Nikolaus Schaller
From: Philipp Rossak We are adding the devicetree binding for the PVR-SGX-544-115 gpu. This driver is currently under development in the openpvrsgx-devgroup. Right now the full binding is not figured out, so we provide here a placeholder. It will be completed as soon as there is a demo available

[PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

2020-04-15 Thread H. Nikolaus Schaller
and add interrupt. Tested-by: H. Nikolaus Schaller # Pyra-Handheld. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap5.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 2ac7f021c284

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-15 Thread H. Nikolaus Schaller
Hi Neil, > Am 15.04.2020 um 14:54 schrieb Neil Armstrong : > > Hi, > > On 15/04/2020 14:43, H. Nikolaus Schaller wrote: >> >>> Am 15.04.2020 um 12:12 schrieb Maxime Ripard : >>> >>> Hi, >>> >>> On Wed, Apr 15, 2020 at 10:35:08AM +0200, H. Nikolaus Schaller wrote: The Imagination PVR/SGX

[PATCH v6 03/12] ARM: DTS: am3517: add sgx gpu child node

2020-04-15 Thread H. Nikolaus Schaller
and add interrupt. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am3517.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi index e0b5a00e2078..3fce56a646d1 100644 --- a/arch/arm/boot/dts/am35

[PATCH v6 04/12] ARM: DTS: omap34xx: add sgx gpu child node

2020-04-15 Thread H. Nikolaus Schaller
and add interrupt. According to omap3530 TRM the SGX register block is 64kB. See: 13.4 SGX Register Mapping, Table 13-2 Reported-by: Andrew F. Davis # register size Tested-by: H. Nikolaus Schaller # OpenPandora 600 MHz. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap34xx.

[PATCH v2] drm/hisilicon: Add the shutdown for hibmc_pci_driver

2020-04-15 Thread Tian Tao
add the shutdown function to release the resource. v2: Remove the unnecessary unmap function. Signed-off-by: Tian Tao Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilic

Re: [PATCH] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-04-15 Thread Maxime Ripard
On Mon, Apr 13, 2020 at 06:09:08PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 13. april 2020 ob 16:12:39 CEST je Chen-Yu Tsai napisal(a): > > On Mon, Apr 13, 2020 at 6:11 PM Chen-Yu Tsai wrote: > > > On Mon, Apr 13, 2020 at 5:55 PM Jernej Skrabec > wrote: > > > > m divider in DDC clock regist

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-15 Thread Maxime Ripard
On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do tr

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-15 Thread H. Nikolaus Schaller
Hi Maxime, > Am 15.04.2020 um 18:21 schrieb Maxime Ripard : > > On Wed, Apr 15, 2020 at 05:09:45PM +0200, H. Nikolaus Schaller wrote: >> Hi Maxime, >> >> Hm. Yes. We know that there likely are clocks and maybe reset >> but for some SoC this seems to be undocumented and the reset >> line the VHDL

Re: [PATCH 2/8] fs: extract simple_pin/release_fs to separate files

2020-04-15 Thread Luis Chamberlain
On Tue, Apr 14, 2020 at 02:42:56PM +0200, Emanuele Giuseppe Esposito wrote: > We will augment this family of functions with inode management. To avoid > littering include/linux/fs.h and fs/libfs.c, move them to a separate header, > with a Kconfig symbol to enable them. If there are no functional

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-15 Thread Joe Perches
On Wed, 2020-04-15 at 19:55 -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-sch

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 11:22 PM Arnd Bergmann wrote: > > On Wed, Apr 15, 2020 at 11:12 PM Laurent Pinchart > wrote: > > On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > > > On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann wrote: > > > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterh

Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

2020-04-15 Thread Tomi Valkeinen
On 15/04/2020 18:39, Laurent Pinchart wrote: Hi Yue, Thank you for the patch. On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote: drivers/gpu/drm/omapdrm/dss/venc.c:211:33: warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=] static const struct venc_co

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 9:50 PM Hans de Goede wrote: > > Hi, > > On 4/15/20 8:29 PM, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 8:19 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 4/15/20 7:54 PM, Daniel Vetter wrote: > >>> On Wed, Apr 15, 2020 at 03:02:53PM +0200, Hans de Goede wrote:

Re: [PATCH 1/8] apparmor: just use vfs_kern_mount to make .null

2020-04-15 Thread Luis Chamberlain
On Tue, Apr 14, 2020 at 02:42:55PM +0200, Emanuele Giuseppe Esposito wrote: > aa_mk_null_file is using simple_pin_fs/simple_release_fs with local > variables as arguments, for what would amount to a simple > vfs_kern_mount/mntput pair if everything was inlined. Just use > the normal filesystem API

[PULL] nouveau-fixes 5.7

2020-04-15 Thread Ben Skeggs
Nothing major here, just some missing MODULE_FIRMWARE() lines. Ben. The following changes since commit 374b55802cd567e9f340b7f27d2c5e20b069ac3c: drm/nouveau/kms/nv50-: wait for FIFO space on PIO channels (2020-04-07 14:37:50 +1000) are available in the Git repository at: git://github.com/s

linux-next: manual merge of the drm-misc tree with Linus' tree

2020-04-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: MAINTAINERS between commits: 4400b7d68f6e ("MAINTAINERS: sort entries by entry name") 3b50142d8528 ("MAINTAINERS: sort field names for all entries") from Linus' tree and commits: 5304058b1526 ("dt-bindings: displ

[PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-15 Thread Rob Herring
Fix various inconsistencies in schema indentation. Most of these are list indentation which should be 2 spaces more than the start of the enclosing keyword. This doesn't matter functionally, but affects running scripts which do transforms on the schema files. Signed-off-by: Rob Herring --- .../d

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings

2020-04-15 Thread Laurent Pinchart
Hi Doug, On Wed, Apr 15, 2020 at 04:49:00PM -0700, Doug Anderson wrote: > On Wed, Apr 15, 2020 at 1:33 PM Laurent Pinchart wrote: > > On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > > > Quoting Douglas Anderson (2020-04-15 08:48:40) > > > > Allow people to specify to use a GPIO for

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings

2020-04-15 Thread Doug Anderson
Hi, On Wed, Apr 15, 2020 at 1:33 PM Laurent Pinchart wrote: > > On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-04-15 08:48:40) > > > Allow people to specify to use a GPIO for hot-plug-detect. Add an > > > example. > > > > > > NOTE: The current pa

[pull] amdgpu drm-fixes-5.7

2020-04-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.7. The following changes since commit 7e7ea24f0b46cd3078bc9af29d1c1aced89d1c8e: drm/amdgpu/display: fix warning when compiling without debugfs (2020-04-08 17:53:11 -0400) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/am

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Arnd Bergmann
On Wed, Apr 15, 2020 at 11:12 PM Laurent Pinchart wrote: > On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > > On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann wrote: > > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven > > > wrote: > > > > On Wed, Apr 15, 2020 at 3:47 PM Arnd B

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 11:10 PM, Jani Nikula wrote: On Wed, 15 Apr 2020, Rajat Jain wrote: Hello, On Wed, Apr 15, 2020 at 8:40 AM Hans de Goede wrote: Hi, On 4/15/20 5:28 PM, Jani Nikula wrote: On Wed, 15 Apr 2020, Hans de Goede wrote: ii. Currently the "privacy-screen" property added by Rajat

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Laurent Pinchart
Hi Arnd, On Wed, Apr 15, 2020 at 09:07:14PM +0200, Arnd Bergmann wrote: > On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann wrote: > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven > > wrote: > > > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann wrote: > > > > On Tue, Apr 14, 2020 at 10:52 PM L

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Jani Nikula
On Wed, 15 Apr 2020, Rajat Jain wrote: > Hello, > > On Wed, Apr 15, 2020 at 8:40 AM Hans de Goede wrote: >> >> Hi, >> >> On 4/15/20 5:28 PM, Jani Nikula wrote: >> > On Wed, 15 Apr 2020, Hans de Goede wrote: >> >> ii. Currently the "privacy-screen" property added by Rajat's >> >> patch-set is an

Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings

2020-04-15 Thread Laurent Pinchart
On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > Quoting Douglas Anderson (2020-04-15 08:48:40) > > Allow people to specify to use a GPIO for hot-plug-detect. Add an > > example. > > > > NOTE: The current patch adding support for hpd-gpios to the Linux > > driver for hpd-gpios only

[PATCH] drm/dp_mst: Fix clearing payload state on topology disable

2020-04-15 Thread Lyude Paul
The issues caused by: commit 64e62bdf04ab ("drm/dp_mst: Remove VCPI while disabling topology mgr") Prompted me to take a closer look at how we clear the payload state in general when disabling the topology, and it turns out there's actually two subtle issues here. The first is that we're not gra

Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml

2020-04-15 Thread Laurent Pinchart
Hi Douglas, Thank you for the patch. On Wed, Apr 15, 2020 at 08:48:39AM -0700, Douglas Anderson wrote: > This moves the bindings over, based a lot on toshiba,tc358768.yaml. > Unless there's someone known to be better, I've set the maintainer in > the yaml as the first person to submit bindings.

[PULL] drm-intel-fixes

2020-04-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2020-04-15: - Fix guest page access by using the brand new VFIO dma r/w interface (Yan) - Fix for i915 perf read buffers (Ashutosh) Thanks, Rodrigo. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 8:29 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 8:19 PM Hans de Goede wrote: Hi, On 4/15/20 7:54 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 03:02:53PM +0200, Hans de Goede wrote: Hi, On 4/15/20 2:01 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 01:39:23PM +0

[Bug 204241] amdgpu fails to resume from suspend

2020-04-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 --- Comment #59 from Jaya Balan Aaron (bucket.s...@gmail.com) --- Comment on attachment 288507 --> https://bugzilla.kernel.org/attachment.cgi?id=288507 arch linux 5.6 resolution with kernel params Hi, Using arch linux kernel 5.5zen, 5.6. Not s

[Bug 204241] amdgpu fails to resume from suspend

2020-04-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 Jaya Balan Aaron (bucket.s...@gmail.com) changed: What|Removed |Added CC||bucket.s...@gma

Re: [PATCH v7 2/2] drm/panel: add support for rm69299 visionox panel driver

2020-04-15 Thread Matthias Kaehlcke
Hi, checkpatch finds multiple errors with this patch, as Sam reported on https://patchwork.kernel.org/cover/11461945/. Please fix those and send a new version (not sure which version number this should be (v11?), this series is a bit confusing in this aspect). Please also double check if there is

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Arnd Bergmann
On Wed, Apr 15, 2020 at 5:18 PM Arnd Bergmann wrote: > > On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven > wrote: > > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann wrote: > > > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart > > > wrote: > > > > Doesn't "imply" mean it gets selected by d

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 8:19 PM Hans de Goede wrote: > > Hi, > > On 4/15/20 7:54 PM, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 03:02:53PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 4/15/20 2:01 PM, Daniel Vetter wrote: > >>> On Wed, Apr 15, 2020 at 01:39:23PM +0200, Hans de Goede wro

Re: [PATCH] drm/bridge: Move mhl.h into driver directory

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 8:12 PM Laurent Pinchart wrote: > > Hi Daniel, > > On Wed, Apr 15, 2020 at 08:06:20PM +0200, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 08:48:06PM +0300, Laurent Pinchart wrote: > > > On Wed, Apr 15, 2020 at 07:38:33PM +0200, Daniel Vetter wrote: > > > > include/drm/b

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 7:54 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 03:02:53PM +0200, Hans de Goede wrote: Hi, On 4/15/20 2:01 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 01:39:23PM +0200, Hans de Goede wrote: Hi, On 4/15/20 12:22 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 12:1

Re: [PATCH] drm/bridge: Move mhl.h into driver directory

2020-04-15 Thread Laurent Pinchart
Hi Daniel, On Wed, Apr 15, 2020 at 08:06:20PM +0200, Daniel Vetter wrote: > On Wed, Apr 15, 2020 at 08:48:06PM +0300, Laurent Pinchart wrote: > > On Wed, Apr 15, 2020 at 07:38:33PM +0200, Daniel Vetter wrote: > > > include/drm/bridge is a bit a mistake, drivers are supposed to find > > > their bri

Re: [External] Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi Mark, On 4/15/20 7:14 PM, Mark Pearson wrote: Hi, -Original Message- From: Hans de Goede Sent: Wednesday, April 15, 2020 11:41 AM On 4/15/20 5:28 PM, Jani Nikula wrote: On Wed, 15 Apr 2020, Hans de Goede wrote: Moreover, do we actually need two properties, one which could indicat

Re: [PATCH] drm/bridge: Move mhl.h into driver directory

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 08:48:06PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Wed, Apr 15, 2020 at 07:38:33PM +0200, Daniel Vetter wrote: > > include/drm/bridge is a bit a mistake, drivers are supposed to find > > their bridges using one of the standard of_* f

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 03:02:53PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/20 2:01 PM, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 01:39:23PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 4/15/20 12:22 PM, Daniel Vetter wrote: > > > > On Wed, Apr 15, 2020 at 12:11 PM Hans de Goe

Re: [PATCH] drm/tidss: fix crash related to accessing freed memory

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 04:03:44PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Wed, Apr 15, 2020 at 02:52:43PM +0200, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 03:45:50PM +0300, Laurent Pinchart wrote: > > > On Wed, Apr 15, 2020 at 12:20:06PM +0300, Tomi Valkeinen wrote: > > >> tidss

Re: [PATCH] drm/bridge: Move mhl.h into driver directory

2020-04-15 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wed, Apr 15, 2020 at 07:38:33PM +0200, Daniel Vetter wrote: > include/drm/bridge is a bit a mistake, drivers are supposed to find > their bridges using one of the standard of_* functions the drm_bridge > core provides. I'm confused, I don't really see how t

Re: [PATCH v2] drm/etnaviv: rework perfmon query infrastructure

2020-04-15 Thread Greg Kroah-Hartman
On Wed, Apr 15, 2020 at 11:08:13PM +0530, Naresh Kamboju wrote: > On Tue, 3 Mar 2020 at 17:19, Lucas Stach wrote: > > > > On Fr, 2020-02-28 at 11:37 +0100, Christian Gmeiner wrote: > > > Report the correct perfmon domains and signals depending > > > on the supported feature flags. > > > > > > Repo

Re: [PATCH 05/59] drm/vboxvidoe: use managed pci functions

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 05:03:55PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/20 9:39 AM, Daniel Vetter wrote: > > Allows us to drop the cleanup code on the floor. > > > > Sam noticed in his review: > > > With this change we avoid calling pci_disable_device() > > > twise in case vbox_mm_init()

[PATCH] drm/bridge: Move mhl.h into driver directory

2020-04-15 Thread Daniel Vetter
include/drm/bridge is a bit a mistake, drivers are supposed to find their bridges using one of the standard of_* functions the drm_bridge core provides. dw-hdmi and analogix-dp are the only, historically grown exception that we haven't managed to get rid of yet. Make sure that at least no new ones

Re: [PATCH v3 1/2] DRM: ARC: add HDMI 2.0 TX encoder support

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 02:29:28AM +0300, Eugeniy Paltsev wrote: > The Synopsys ARC SoCs (like HSDK4xD) include on-chip DesignWare HDMI > encoders. Support them with a platform driver to provide platform glue > data to the dw-hdmi driver. > > Acked-by: Sam Ravnborg > Signed-off-by: Eugeniy Paltse

Re: [PATCH 05/59] drm/vboxvidoe: use managed pci functions

2020-04-15 Thread Thomas Zimmermann
The commit's headline says 'vboxvidoe'. Am 15.04.20 um 09:39 schrieb Daniel Vetter: > Allows us to drop the cleanup code on the floor. > > Sam noticed in his review: >> With this change we avoid calling pci_disable_device() >> twise in case vbox_mm_init() fails. >> Once in vbox_hw_fini() and once

Re: [PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-15 Thread Laurent Pinchart
Hi Enric, On Wed, Apr 15, 2020 at 07:26:02PM +0200, Enric Balletbo Serra wrote: > Missatge de Adrian Ratiu del dia dt., 14 > d’abr. 2020 a les 17:19: > > > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > > controller which is embedded in i.MX 6 SoCs. > > > > Based on followi

Re: [PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

2020-04-15 Thread Enric Balletbo Serra
Hi Adrian, Thank you for your patch. Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > This adds support for the Synopsis DesignWare MIPI DSI v1.01 host > controller which is embedded in i.MX 6 SoCs. > > Based on following patches, but updated/extended to work with existing >

[PATCH] drm: Don't free a struct never allocated by drm_gem_fb_init()

2020-04-15 Thread Andrzej Pietrasiewicz
drm_gem_fb_init() is passed the fb and never allocates it, so it should be not the one freeing it. As it is now the second call to kfree() is possible with the same fb. Coverity reported the following: *** CID 1492613: Memory - corruptions (USE_AFTER_FREE) /drivers/gpu/drm/drm_gem_framebuffer_he

Re: [PATCH v11 1/5] dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings

2020-04-15 Thread Laurent Pinchart
Hi Hyun, On Thu, Apr 02, 2020 at 06:11:25AM +0300, Laurent Pinchart wrote: > On Wed, Mar 18, 2020 at 06:08:57PM -0700, Hyun Kwon wrote: > > On Wed, 2020-03-18 at 12:26:51 -0700, Sam Ravnborg wrote: > >> On Wed, Mar 18, 2020 at 05:37:24PM +0200, Laurent Pinchart wrote: > >>> From: Hyun Kwon > >>>

Re: [PATCH v1 3/4] dt-bindings: media: add wiring property to video-interfaces

2020-04-15 Thread Sam Ravnborg
Hi Rob. On Tue, Apr 14, 2020 at 02:40:54PM -0500, Rob Herring wrote: > On Sun, Apr 12, 2020 at 08:20:11PM +0200, Sam Ravnborg wrote: > > The wiring property is used to describe the wiring between > > the connector and the panel. The property can be used when the > > wiring is used to change the mo

Re: [PATCH v1 2/4] dt-bindings: display: convert atmel lcdc to DT Schema

2020-04-15 Thread Sam Ravnborg
Hi Maxime. On Tue, Apr 14, 2020 at 10:30:10AM +0200, Maxime Ripard wrote: > On Sun, Apr 12, 2020 at 08:20:10PM +0200, Sam Ravnborg wrote: > > Add a new binding file to describe the bindings > > for the Atmel LCDC IP. > > This replaces the old txt based binding. > > > > The binding file describes t

Re: [PATCH v1 1/4] dt-bindings: display: convert atmel-hlcdc to DT Schema

2020-04-15 Thread Sam Ravnborg
Hi Maxime. On Tue, Apr 14, 2020 at 10:28:03AM +0200, Maxime Ripard wrote: > Hi Sam, > > On Sun, Apr 12, 2020 at 08:20:09PM +0200, Sam Ravnborg wrote: > > diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.yaml > > b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.yaml

Re: [PATCH AUTOSEL 5.6 084/129] drm/nouveau: workaround runpm fail by disabling PCI power management on certain intel bridges

2020-04-15 Thread Karol Herbst
in addition to that 028a12f5aa829 "drm/nouveau/gr/gp107,gp108: implement workaround for HW hanging during init" should probably get picked as well as it's fixing some runtime pm related issue on a handful of additional GPUs. I have a laptop myself which requires both of those patches. Applies to 5

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

2020-04-15 Thread Enric Balletbo Serra
Hi Adrian, Some few comments/nits below, Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > In order to support multiple versions of the Synopsis MIPI DSI host > controller, which have different register layouts but almost identical > HW protocols, we add a regmap infrastructu

[PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml

2020-04-15 Thread Douglas Anderson
This moves the bindings over, based a lot on toshiba,tc358768.yaml. Unless there's someone known to be better, I've set the maintainer in the yaml as the first person to submit bindings. Signed-off-by: Douglas Anderson --- .../bindings/display/bridge/ti,sn65dsi86.txt | 87 .../bindin

[PATCH 3/3] drm/bridge: ti-sn65dsi86: Allow one of the bridge GPIOs to be HPD

2020-04-15 Thread Douglas Anderson
As talked about in commit c2bfc223882d ("drm/bridge: ti-sn65dsi86: Remove the mystery delay"), the normal HPD pin on ti-sn65dsi86 is kinda useless, at least for embedded DisplayPort (eDP). However, despite the fact that the actual HPD pin on the bridge is mostly useless for eDP, the concept of HPD

[PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings

2020-04-15 Thread Douglas Anderson
Allow people to specify to use a GPIO for hot-plug-detect. Add an example. NOTE: The current patch adding support for hpd-gpios to the Linux driver for hpd-gpios only adds enough support to the driver so that the bridge can use one of its own GPIOs. The bindings, however, are written generically

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 5:28 PM, Jani Nikula wrote: On Wed, 15 Apr 2020, Hans de Goede wrote: ii. Currently the "privacy-screen" property added by Rajat's patch-set is an enum with 2 possible values: "Enabled" "Disabled" We could add a third value "Not Available", which would be the default and then f

Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

2020-04-15 Thread Laurent Pinchart
Hi Yue, Thank you for the patch. On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote: > drivers/gpu/drm/omapdrm/dss/venc.c:211:33: > warning: 'venc_config_pal_bdghi' defined but not used > [-Wunused-const-variable=] > static const struct venc_config venc_config_pal_bdghi = { >

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Jani Nikula
On Wed, 15 Apr 2020, Hans de Goede wrote: > ii. Currently the "privacy-screen" property added by Rajat's > patch-set is an enum with 2 possible values: > "Enabled" > "Disabled" > > We could add a third value "Not Available", which would be the > default and then for internal panels always add the

Re: [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings

2020-04-15 Thread Rob Herring
On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: > Add Display Port HPD GPIO description in bindings > > This Patch depends on: > https://patchwork.kernel.org/patch/11468505/ This belongs below the '---' and probably means you should send all this as one series. > > Signed-of

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Arnd Bergmann
On Wed, Apr 15, 2020 at 4:13 PM Geert Uytterhoeven wrote: > On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann wrote: > > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart > > wrote: > > > Doesn't "imply" mean it gets selected by default but can be manually > > > disabled ? > > > > That may be what

Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-04-15 Thread Rob Herring
On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > checkpatch.pl complains about some trailing whitespace. The previous patch too. > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > --- > .../bindings/leds/backlight/qcom-wled.

Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-04-15 Thread Rob Herring
On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote: > Convert the qcom-wled bindings from .txt to .yaml format. > Also replace PM8941 to WLED3 and PMI8998 to WLED4. > > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > Acked-by: Daniel Thompson > --- > .../bindin

Re: [PATCH 22/59] drm/gm12u320: Don't use drm_device->dev_private

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu

Re: [PATCH 21/59] drm/gm12u320: Use devm_drm_dev_alloc

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/tiny/gm12u320.c | 13 - 1

Re: [PATCH 06/59] drm/vboxvideo: Use devm_gen_pool_create

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Aside from deleting all the cleanup code we're now also setting a name for the pool Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/vboxvideo/vbox

Re: [PATCH 05/59] drm/vboxvidoe: use managed pci functions

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Allows us to drop the cleanup code on the floor. Sam noticed in his review: With this change we avoid calling pci_disable_device() twise in case vbox_mm_init() fails. Once in vbox_hw_fini() and once in the error path. v2: Include Sam's review rema

Re: [PATCH 02/59] drm/vboxvideo: drop DRM_MTRR_WC #define

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Doesn't apply to upstream kernels since a rather long time. Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/vboxvideo/vbox_ttm.c | 12

Re: [PATCH 03/59] drm/vboxvideo: Use devm_drm_dev_alloc

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: Straightforward conversion. Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(

Re: [PATCH 04/59] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 9:39 AM, Daniel Vetter wrote: We use the baseclass pattern here, so lets to the proper (and more typesafe) upcasting. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Hans de Goede LGTM: Reviewed-by: Hans de Goede Regards, Hans ---

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

2020-04-15 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel to Cc: ] Hi, On 4/15/20 4:20 PM, Andy Shevchenko wrote: > On Mon, Mar 30, 2020 at 12:51:44PM +0300, Andy Shevchenko wrote: >> On Tue, Mar 24, 2020 at 07:05:28PM +0200, Andy Shevchenko wrote: >>> Use the ->probe_new() callback. >>> >>> The driver does not use const struct i2c_de

[PATCH 01/34] docs: filesystems: fix references for doc files there

2020-04-15 Thread Mauro Carvalho Chehab
Several files there were renamed to ReST. Fix the broken references. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-devices-node | 2 +- Documentation/ABI/testing/procfs-smaps_rollup | 2 +- Documentation/admin-guide/cpu-load.rst

[PATCH 00/34] fs: convert remaining docs to ReST file format

2020-04-15 Thread Mauro Carvalho Chehab
This patch series convert the remaining files under Documentation/filesystems to the ReST file format. It is based on linux-next (next-20200414). PS.: I opted to add mainly ML from the output of get_maintainers.pl to the c/c list of patch 00/34, because otherwise the number of c/c would be too ma

Re: [RFC 5/6] drm/rcar-du: fix selection of CMM driver

2020-04-15 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Apr 15, 2020 at 3:47 PM Arnd Bergmann wrote: > On Tue, Apr 14, 2020 at 10:52 PM Laurent Pinchart > wrote: > > On Tue, Apr 14, 2020 at 10:38:27PM +0200, Arnd Bergmann wrote: > > > On Tue, Apr 14, 2020 at 10:17 PM Laurent Pinchart wrote: > > > > On Wed, Apr 08, 2020 at 10:27:10PM

Re: [PATCH] Optimized division operation to shift operation

2020-04-15 Thread Deucher, Alexander
[AMD Public Use] I've gone ahead and dropped the patch. Alex From: Koenig, Christian Sent: Wednesday, April 15, 2020 3:57 AM To: Jani Nikula ; Alex Deucher ; Bernard Zhao Cc: Sierra Guiza, Alejandro (Alex) ; Zeng, Oak ; Maling list - DRI developers ; David Ai

[PATCH 1/4] drm/lima: add lima_devfreq_resume/suspend

2020-04-15 Thread Qiang Yu
Used for device resume/suspend in the following commits. Tested-by: Bhushan Shah Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_devfreq.c | 24 drivers/gpu/drm/lima/lima_devfreq.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/lima/lima

[PATCH 2/4] drm/lima: power down ip blocks when pmu exit

2020-04-15 Thread Qiang Yu
Prepare resume/suspend PM. Tested-by: Bhushan Shah Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_device.h | 2 ++ drivers/gpu/drm/lima/lima_pmu.c| 43 ++ 2 files changed, 45 insertions(+) diff --git a/drivers/gpu/drm/lima/lima_device.h b/drivers/gpu/dr

[PATCH 3/4] drm/lima: add resume/suspend callback for each ip

2020-04-15 Thread Qiang Yu
For called when PM do resume/suspend. Tested-by: Bhushan Shah Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_bcast.c| 25 drivers/gpu/drm/lima/lima_bcast.h| 2 ++ drivers/gpu/drm/lima/lima_device.c | 4 +++ drivers/gpu/drm/lima/lima_device.h | 2 +- driver

[PATCH 4/4] drm/lima: add pm resume/suspend

2020-04-15 Thread Qiang Yu
Do hardware resume/suspend. Tested-by: Bhushan Shah Signed-off-by: Qiang Yu --- drivers/gpu/drm/lima/lima_device.c | 65 ++ drivers/gpu/drm/lima/lima_device.h | 3 ++ drivers/gpu/drm/lima/lima_drv.c| 7 3 files changed, 75 insertions(+) diff --git a/drive

[PATCH 0/4] drm/lima: add suspend/resume support

2020-04-15 Thread Qiang Yu
Suspend need to wait running jobs finish and put hardware in poweroff state. Resume need to re-init hardware. Qiang Yu (4): drm/lima: add lima_devfreq_resume/suspend drm/lima: power down ip blocks when pmu exit drm/lima: add resume/suspend callback for each ip drm/lima: add pm resume/suspe

Re: [PATCH v1.1 2/4] dt-bindings: display: bridge: Convert simple-bridge bindings to YAML

2020-04-15 Thread Rob Herring
On Tue, Apr 14, 2020 at 7:59 PM Laurent Pinchart wrote: > > The simple-bridge driver supports multiple simple or dumb bridges, > covered by different compatible strings but otherwise identical DT > bindings. Some of those bridges have undocumented bindings, while others > are documented in text fo

Re: [PATCH/RFC 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2020-04-15 Thread Rob Herring
On Tue, Apr 14, 2020 at 8:06 PM Laurent Pinchart wrote: > > Hi Rob, > > On Tue, Apr 14, 2020 at 06:10:05PM -0500, Rob Herring wrote: > > On Wed, Apr 08, 2020 at 02:45:52PM +0300, Laurent Pinchart wrote: > > > On Tue, Apr 07, 2020 at 09:12:51AM +0200, Maxime Ripard wrote: > > >> On Mon, Apr 06, 202

Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

2020-04-15 Thread Krzysztof Kozlowski
On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: > Hi Krzysztof, > > > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller > > wrote: > >> > >> and add interrupt. > >> > >> Tested-by: H. Nikolaus Schaller # Pyra

Re: [PATCH] drm/tidss: fix crash related to accessing freed memory

2020-04-15 Thread Tomi Valkeinen
Hi, On 15/04/2020 15:45, Laurent Pinchart wrote: +static void tidss_crtc_destroy(struct drm_crtc *crtc) +{ + struct tidss_crtc *tcrtc = to_tidss_crtc(crtc); + + drm_crtc_cleanup(crtc); + kfree(tcrtc); I would personally store the CRTC pointers, or embed the CRTC instances in

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

2020-04-15 Thread Krzysztof Kozlowski
On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller > > wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not cont

Re: [PATCH 1/1] AMDGPU: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)

2020-04-15 Thread Alex Deucher
On Wed, Apr 15, 2020 at 7:36 AM Sandeep wrote: > > Initialize thermal controller fields in the PowerPlay table for Hawaii > GPUs, so that fan speeds are reported. Missing your signed-off-by. > --- > .../drm/amd/powerplay/hwmgr/processpptables.c | 28 +++ > 1 file changed, 28 ins

Re: [PATCH] drm/tidss: fix crash related to accessing freed memory

2020-04-15 Thread Laurent Pinchart
Hi Daniel, On Wed, Apr 15, 2020 at 02:52:43PM +0200, Daniel Vetter wrote: > On Wed, Apr 15, 2020 at 03:45:50PM +0300, Laurent Pinchart wrote: > > On Wed, Apr 15, 2020 at 12:20:06PM +0300, Tomi Valkeinen wrote: > >> tidss uses devm_kzalloc to allocate DRM plane, encoder and crtc objects. > >> This

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Hans de Goede
Hi, On 4/15/20 2:01 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 01:39:23PM +0200, Hans de Goede wrote: Hi, On 4/15/20 12:22 PM, Daniel Vetter wrote: On Wed, Apr 15, 2020 at 12:11 PM Hans de Goede wrote: Hi, On 4/15/20 11:52 AM, Daniel Vetter wrote: iv. What every SoC subsystem d

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

2020-04-15 Thread Neil Armstrong
Hi, On 15/04/2020 14:43, H. Nikolaus Schaller wrote: > >> Am 15.04.2020 um 12:12 schrieb Maxime Ripard : >> >> Hi, >> >> On Wed, Apr 15, 2020 at 10:35:08AM +0200, H. Nikolaus Schaller wrote: >>> The Imagination PVR/SGX GPU is part of several SoC from >>> multiple vendors, e.g. TI OMAP, Ingenic JZ

Re: [PATCH] drm/tidss: fix crash related to accessing freed memory

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 03:45:50PM +0300, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Apr 15, 2020 at 12:20:06PM +0300, Tomi Valkeinen wrote: > > tidss uses devm_kzalloc to allocate DRM plane, encoder and crtc objects. > > This is not correct as the lifetime of tho

Re: [PATCH] drm/tidss: fix crash related to accessing freed memory

2020-04-15 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wed, Apr 15, 2020 at 12:20:06PM +0300, Tomi Valkeinen wrote: > tidss uses devm_kzalloc to allocate DRM plane, encoder and crtc objects. > This is not correct as the lifetime of those objects should be longer > than the underlying device's. > > When unloading

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: > Hi Maxime, > > > Am 15.04.2020 um 12:10 schrieb Maxime Ripard : > > > > Hi, > > > > On Wed, Apr 15, 2020 at 10:35:07AM +0200, H. Nikolaus Schaller wrote: > >> * rebased to v5.7-rc1 > >> * added DTS for for a31, a31s, a83t -

Re: [PATCH] drm/tegra: Clean up GPIO includes

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 02:24:27PM +0200, Linus Walleij wrote: > The Tegra DRM drivers includes the legacy GPIO headers > and but what it really > uses is since only gpio_desc > structs are ever referenced. > > Include the right header on the top level tegra/drm.h > file and drop all the surplu

[PATCH] drm/tegra: Clean up GPIO includes

2020-04-15 Thread Linus Walleij
The Tegra DRM drivers includes the legacy GPIO headers and but what it really uses is since only gpio_desc structs are ever referenced. Include the right header on the top level tegra/drm.h file and drop all the surplus includes. Signed-off-by: Linus Walleij --- drivers/gpu/drm/tegra/dpaux.c

Re: [PATCH 57/59] drm/ast: Use managed pci functions

2020-04-15 Thread Daniel Vetter
On Wed, Apr 15, 2020 at 10:17 AM Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 10:09 AM Daniel Vetter wrote: > > > > On Wed, Apr 15, 2020 at 9:52 AM Thomas Zimmermann > > wrote: > > > > > > Hi Daniel > > > > > > Am 15.04.20 um 09:40 schrieb Daniel Vetter: > > > > Allows us to remove a bit of

  1   2   3   >