Hi all,
After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
ERROR: modpost: "sched_setscheduler" [drivers/gpu/drm/drm.ko] undefined!
Caused by commit
616d91b68cd5 ("sched: Remove sched_setscheduler*() EXPORTs")
interacting with commit
5e6c2b4f9161
Break the requirement that device-dax instances are physically
contiguous. With this constraint removed it allows fragmented available
capacity to be fully allocated.
This capability is useful to mitigate the "noisy neighbor" problem with
memory-side-cache management for virtual machines, or any
Use sysfs_streq() in device_find_child_by_name() to allow it to use a
sysfs input string that might contain a trailing newline.
The other "device by name" interfaces,
{bus,driver,class}_find_device_by_name(), already account for sysfs
strings.
Cc: "Rafael J. Wysocki"
Reviewed-by: Greg
From: Joao Martins
Introduce a new module parameter for dax_hmem which
initializes all region devices as free, rather than allocating
a pagemap for the region by default.
All hmem devices created with dax_hmem.region_idle=1 will have full
available size for creating dynamic dax devices.
The 'struct resource' in 'struct dev_pagemap' is only used for holding
resource span information. The other fields, 'name', 'flags', 'desc',
'parent', 'sibling', and 'child' are all unused wasted space.
This is in preparation for introducing a multi-range extension of
devm_memremap_pages().
The
From: Joao Martins
Introduce a device align attribute. While doing so,
rename the region align attribute to be more explicitly
named as so, but keep it named as @align to retain the API
for tools like daxctl.
Changes on align may not always be valid, when say certain
mappings were created with
Make the device-dax 'size' attribute writable to allow capacity to be
split between multiple instances in a region. The intended consumers of
this capability are users that want to split a scarce memory resource
between device-dax and System-RAM access, or users that want to have
multiple security
From: Joao Martins
Introduce @align to struct dev_dax.
When creating a new device, we still initialize to the default
dax_region @align. Child devices belonging to a region may wish
to keep a different alignment property instead of a global
region-defined one.
Signed-off-by: Joao Martins
From: Joao Martins
Add a sysfs attribute which denotes a range from the dax region
to be allocated. It's an write only @mapping sysfs attribute in
the format of '-' to allocate a range. @start and
@end use hexadecimal values and the @pgoff is implicitly ordered
wrt to previous writes to @mapping
In support of interrogating the physical address layout of a device with
dis-contiguous ranges, introduce a sysfs directory with 'start', 'end',
and 'page_offset' attributes. The alternative is trying to parse
/proc/iomem, and that file will not reflect the extent layout until the
device is
In support of device-dax growing the ability to front physically
dis-contiguous ranges of memory, update devm_memremap_pages() to track
multiple ranges with a single reference counter and devm instance.
Cc: Paul Mackerras
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Dan Williams
Cc:
The passed in dev_pagemap is only required in the pmem case as the
libnvdimm core may have reserved a vmem_altmap for dev_memremap_pages()
to place the memmap in pmem directly. In the hmem case there is no
agent reserving an altmap so it can all be handled by a core internal
default.
Pass the
Add a seed device concept for dynamic dax regions to be able to split
the region amongst multiple sub-instances. The seed device, similar to
libnvdimm seed devices, is a device that starts with zero capacity
allocated and unbound to a driver. In contrast to libnvdimm seed devices
explicit 'create'
In support of detecting whether a resource might have been been claimed,
report the parent to the walk_iomem_res_desc() callback. For example,
the ACPI HMAT parser publishes "hmem" platform devices per target range.
However, if the HMAT is disabled / missing a fallback driver can attach
devices to
Several related issues around this unneeded attribute:
- The dax_kmem_res property allows the kmem driver to stash the adjusted
resource range that was used for the hotplug operation, but that can be
recalculated from the original base range.
- kmem is using an open coded release_resource()
All callers specify the same flags to alloc_dax_region(), so there is no
need to allow for anything other than PFN_DEV|PFN_MAP, or carry a
->pfn_flags around on the region. Device-dax instances are always page
backed.
Cc: Vishal Verma
Signed-off-by: Dan Williams
---
drivers/dax/bus.c |
In preparation for a facility that enables dax regions to be
sub-divided, introduce infrastructure to track and allocate region
capacity.
The new dax_region/available_size attribute is only enabled for volatile
hmem devices, not pmem devices that are defined by nvdimm namespace
boundaries. This
The hmem enabling in commit 'cf8741ac57ed ("ACPI: NUMA: HMAT: Register
"soft reserved" memory as an "hmem" device")' only registered ranges to
the hmem driver for each soft-reservation that also appeared in the
HMAT. While this is meant to encourage platform firmware to "do the
right thing" and
In preparation for exposing "Soft Reserved" memory ranges without an
HMAT, move the hmem device registration to its own compilation unit and
make the implementation generic.
The generic implementation drops usage acpi_map_pxm_to_online_node()
that was translating ACPI proximity domain values and
In preparation for adding more parameters to instance creation, move
existing parameters to a new struct.
Cc: Vishal Verma
Signed-off-by: Dan Williams
---
drivers/dax/bus.c | 14 +++---
drivers/dax/bus.h | 16
drivers/dax/hmem/hmem.c |8 +++-
In preparation to set a fallback value for dev_dax->target_node,
introduce generic fallback helpers for phys_to_target_node()
A generic implementation based on node-data or memblock was proposed,
but as noted by Mike:
"Here again, I would prefer to add a weak default for
Changes since v3 [1]:
- Update x86 boot options documentation for 'nohmat' (Randy)
- Fixup a handful of kbuild robot reports, the most significant being
moving usage of PUD_SIZE and PMD_SIZE under
#ifdef CONFIG_TRANSPARENT_HUGEPAGE protection.
[1]:
Disable parsing of the HMAT for debug, to workaround broken platform
instances, or cases where it is otherwise not wanted.
Cc: x...@kernel.org
Cc: "Rafael J. Wysocki"
Cc: Dave Hansen
Cc: Andy Lutomirski
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: "H.
In preparation for attaching a platform device per iomem resource teach
the efi_fake_mem code to create an e820 entry per instance. Similar to
E820_TYPE_PRAM, bypass merging resource when the e820 map is sanitized.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: "H. Peter Anvin"
In preparation for adding a new numa= option clean up the existing ones
to avoid ifdefs in numa_setup(), and provide feedback when the option is
numa=fake= option is invalid due to kernel config. The same does not
need to be done for numa=noacpi, since the capability is already hard
disabled at
GEN >= 10 hardware supports the programmable scaler filter.
Attach scaling filter property for CRTC and plane for GEN >= 10
hardwares and program scaler filter based on the selected filter
type.
changes since v3:
* None
changes since v2:
* Use updated functions
* Add ps_ctrl var to contain the
Integer scaling (IS) is a nearest-neighbor upscaling technique that
simply scales up the existing pixels by an integer
(i.e., whole number) multiplier.Nearest-neighbor (NN) interpolation
works by filling in the missing color values in the upscaled image
with that of the coordinate-mapped nearest
Introduce per-plane and per-CRTC scaling filter properties to allow
userspace to select the driver's default scaling filter or
Nearest-neighbor(NN) filter for upscaling operations on CRTC and
plane.
Drivers can set up this property for a plane by calling
drm_plane_create_scaling_filter() and for
Introduce scaler registers and bit fields needed to configure the
scaling filter in prgrammed mode and configure scaling filter
coefficients.
changes since v3:
* None
changes since v2:
* Change macro names to CNL_* and use +(set)*8 instead of adding
another trip through _PICK_EVEN (Ville).
Add documentation for newly introduced KMS plane and CRTC scaling
filter properties.
changes since v3:
* None
changes since v1:
* None
changes since RFC:
* Add separate documentation for plane and CRTC.
Signed-off-by: Pankaj Bharadiya
---
Documentation/gpu/drm-kms.rst | 12
1 file
Earlier, I kept this series on hold since we wanted to have a
reference userspace implementation in place.
Now, Sameer has implemented Integer scaling in Kodi Retro gaming
framework which demonstrate how Integer scaling gives distinctive
look to pixel art games when played on higher resolution
Hi, Frank:
Frank Wunderlich 於 2020年8月2日 週日 下午4:06寫道：
>
> > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr
> > Von: "Chun-Kuang Hu"
> > An: "Frank Wunderlich"
> > Cc: "Chun-Kuang Hu" , "Philipp Zabel"
> > , "David Airlie" , "linux-kernel"
> > , "DRI Development"
> > , "moderated
Hi, Frank:
Frank Wunderlich 於 2020年8月2日 週日 下午12:44寫道：
>
> Hi,
>
> Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu
> :
> >Hi, Frank:
> >> - disable tmds on phy on mt2701
> >> - support other resolutions like 1280x1024
> >
> >If this patch does two things, it should be broken into two
Hi,
On Sun, Aug 02, 2020 at 04:32:07PM +0200, Sam Ravnborg wrote:
> On Sun, Aug 02, 2020 at 04:26:05PM +0200, Sebastian Reichel wrote:
> > On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote:
> > > - Introduce backlight_{enable/disable)
> > > - Use get/set methods for
Hi,
On 7/29/20 10:12 AM, Andy Shevchenko wrote:
On Tue, Jul 28, 2020 at 09:55:22PM +0200, Hans de Goede wrote:
On 7/28/20 8:57 PM, Andy Shevchenko wrote:
On Fri, Jul 17, 2020 at 03:37:43PM +0200, Hans de Goede wrote:
...
Maybe I'm too picky, but I would go even further and split apply to
On Sun, Aug 02, 2020 at 02:14:06PM -0500, Bjorn Helgaas wrote:
> Wait, I'm not convinced yet. I know that if a PCI read fails, you
> normally get ~0 data because the host bridge fabricates it to complete
> the CPU load.
>
> But what guarantees that a PCI config register cannot contain ~0?
Well,
On Fri, Jul 31, 2020 at 11:20:33AM +0200, dan...@ffwll.ch wrote:
> On Wed, Jul 29, 2020 at 06:36:03PM +0200, Sam Ravnborg wrote:
> > Hi Daniel.
> >
> > On Wed, Jul 29, 2020 at 03:53:28PM +0200, dan...@ffwll.ch wrote:
> > > On Wed, Jul 29, 2020 at 03:41:45PM +0200, Thomas Zimmermann wrote:
> > > >
Hi,
On 8/2/20 1:25 PM, Andy Shevchenko wrote:
On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote:
On 7/29/20 12:54 PM, Andy Shevchenko wrote:
On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote:
...
One comment to consider, though. There are three channels in that PWM
On Sun, Aug 02, 2020 at 08:46:48PM +0200, Borislav Petkov wrote:
> On Sun, Aug 02, 2020 at 07:28:00PM +0200, Saheed Bolarinwa wrote:
> > Because the value ~0 has a meaning to some drivers and only
>
> No, ~0 means that the PCI read failed. For *every* PCI device I know.
Wait, I'm not convinced
On Sun, Aug 02, 2020 at 07:28:00PM +0200, Saheed Bolarinwa wrote:
> Because the value ~0 has a meaning to some drivers and only
No, ~0 means that the PCI read failed. For *every* PCI device I know.
Here's me reading from 0xf0 offset of my hostbridge:
# setpci -s 00:00.0 0xf0.l
0100
That
Purely conjecture, but I think the original locking inversion with the
legacy page flip code between flipping and ttm's bo move function
shoudn't exist anymore with atomic: With atomic the bo pinning and
actual modeset commit is completely separated in the code patsh.
This annotation was
Hi Joe.
On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote:
> These functions are now empty and no longer
> useful so remove the functions and their uses.
>
> Signed-off-by: Joe Perches
> ---
>
> > > It's too tedious to break apart into multiple patches.
> > > Done with coccinelle and
These functions are now empty and no longer
useful so remove the functions and their uses.
Signed-off-by: Joe Perches
---
> > It's too tedious to break apart into multiple patches.
> > Done with coccinelle and typing.
> >
> > Compiled allyesconfig x86-64 only.
V2: Removed 3 additional lines
Hi Anitha.
On Thu, Jul 30, 2020 at 01:44:44PM -0700, Anitha Chrisanthus wrote:
> This is a basic KMS atomic modesetting display driver for KeemBay family of
> SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge
> driver at the connector level.
>
> Single CRTC with LCD
On 8/1/20 5:56 AM, Borislav Petkov wrote:
> On Sat, Aug 01, 2020 at 01:24:29PM +0200, Saheed O. Bolarinwa wrote:
>> The return value of pci_read_config_*() may not indicate a device error.
>> However, the value read by these functions is more likely to indicate
>> this kind of error. This
On Sun, Aug 02, 2020 at 01:06:30PM +0200, Sam Ravnborg wrote:
> - Use blacklight_get_brightness() helper
> - Use devm_ variant to register backlight device and drop explicit
> unregister
> - Use macro for initialization
>
> Signed-off-by: Sam Ravnborg
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
Hi Sebastian.
On Sun, Aug 02, 2020 at 04:26:05PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote:
> > - Introduce backlight_{enable/disable)
> > - Use get/set methods for backlight_properties
> > - Drop redundant get_brightness()
Hi,
On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote:
> - Introduce backlight_{enable/disable)
> - Use get/set methods for backlight_properties
> - Drop redundant get_brightness() implementation
> The default implementation return the current brightness value
> - Use macro for
, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-add-init-macros-and-accessors/20200802-190940
base:for-backlight-next
config: x86_64
/20200802-190940
base:for-backlight-next
config: arm-randconfig-r016-20200802 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x
> > > diff --git a/drivers/gpu/drm/i915/i915_active.c
> > > b/drivers/gpu/drm/i915/i915_active.c
> > > index d960d0be5bd2..cc017e3cc9c5 100644
> > > --- a/drivers/gpu/drm/i915/i915_active.c
> > > +++ b/drivers/gpu/drm/i915/i915_active.c
> > > @@ -758,7 +758,7 @@ int
https://bugzilla.kernel.org/show_bug.cgi?id=207383
--- Comment #114 from Jeremy Kescher (jer...@kescher.at) ---
(In reply to Duncan from comment #108)
> (In reply to Paul Menzel from comment #107)
> > Everyone seeing this, it’d be great, if you tested
> >
> > [PATCH] drm/amd/display: Clear
Quoting Andi Shyti (2020-08-02 12:40:44)
> Hi Tianjia,
>
> > diff --git a/drivers/gpu/drm/i915/i915_active.c
> > b/drivers/gpu/drm/i915/i915_active.c
> > index d960d0be5bd2..cc017e3cc9c5 100644
> > --- a/drivers/gpu/drm/i915/i915_active.c
> > +++ b/drivers/gpu/drm/i915/i915_active.c
> > @@
Hi Tianjia,
> diff --git a/drivers/gpu/drm/i915/i915_active.c
> b/drivers/gpu/drm/i915/i915_active.c
> index d960d0be5bd2..cc017e3cc9c5 100644
> --- a/drivers/gpu/drm/i915/i915_active.c
> +++ b/drivers/gpu/drm/i915/i915_active.c
> @@ -758,7 +758,7 @@ int
- Replace direct access to backlight_properties with
backlight_get_brightness().
- Use macro for initialization
Signed-off-by: Sam Ravnborg
Cc: Robert Chiras
Cc: Thierry Reding
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-raydium-rm67191.c | 11 +++
1 file changed, 3
- Use blacklight_get_brightness() helper
- Use devm_ variant to register backlight device and drop explicit
unregister
- Use macro for initialization
Signed-off-by: Sam Ravnborg
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
---
- Use backlight_get_brightness() helper
- Use backlight_is_blank() helper
- Use macro for initialization
- Drop direct access to backlight properties
- Use the devm_ variant for registering backlight device, and drop
all explicit unregistering of the backlight device.
Signed-off-by: Sam
The backlight support is updated to utilise newly added macros and
functions thus simplifying the code.
- Introduced backlight_set_brightness() that can be called with a
NULL backlight_device
- backlight_update_status() can be called with a NULL backlight_device.
Benefit from this by removing
- Use drm_panel backlight support
- Use macro for backlight initialization
Signed-off-by: Sam Ravnborg
Cc: Paweł Chmiel
Cc: Thierry Reding
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 25 +++
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git
- Introduce backlight_{enable/disable)
- Use get/set methods for backlight_properties
- Drop redundant get_brightness() implementation
The default implementation return the current brightness value
- Use macro for backlight initialization
Signed-off-by: Sam Ravnborg
Cc: Tomi Valkeinen
Cc:
- Use macros for initialization
- Replace direct access to backlight_properties with get and set
operations
Signed-off-by: Sam Ravnborg
Cc: Alex Deucher
Cc: Christian König
Cc: amd-...@lists.freedesktop.org
---
drivers/gpu/drm/radeon/atombios_encoders.c| 23 ++-
Avoid using direct access to backlight_properties by introducing
set methods for power.
Dropped extra check as both set methods and backlight_update_status()
both accepts a NULL backlight device.
Signed-off-by: Sam Ravnborg
Cc: Rob Clark
Cc: Ezequiel Garcia
Cc: Jyri Sarha
Cc: Tomi Valkeinen
- Replace direct access to backlight_properties with
backlight_get_brightness().
- Use brightness and not power to determine if backlight is off
- Use the devm_ variant for registering backlight device, and drop
all explicit unregistering of the backlight device.
Signed-off-by: Sam Ravnborg
- Replace direct access to backlight_properties with
backlight_get_brightness().
- Drop debug printout
- Use macro for initialization
Signed-off-by: Sam Ravnborg
Cc: Linus Walleij
Cc: Thierry Reding
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-novatek-nt35510.c | 9 +++--
1 file
backlight_update_status() may be called from code that does not have
any valid backlight device. To avoid ifdeffery and too much conditionals
silently fail if the backlight_device is NULL.
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
Update backlight to use macro for initialization and the
backlight_get_brightness() operation to simply the update operation.
Moved init of backlight device so it comes after drm_panel_init().
This is the order that is required by drm_panel.
Signed-off-by: Sam Ravnborg
Cc: Vinay Simha BN
Cc:
Update backlight implementation to utilize newly added backlight
functionality.
- Use macros for initialization
- Replace direct access to backlight_properties with get and set
operations
- Dropped extra checks as some methods accepts a NULL backlight device.
One side-effect of these changes
- Use get/set methods for backlight_properties
- Use macro for backlight initialization
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Kieran Bingham
Cc: linux-renesas-...@vger.kernel.org
---
.../gpu/drm/shmobile/shmob_drm_backlight.c| 20 ---
1 file changed, 8
Device registration almost always uses a struct backlight_properties
variable to pass config info. Make it simpler and less error prone
by the introduction of a number of macros.
There is one macro for each type of backlight {firmware, platform, raw}.
All members in struct backlight_properties
Update backlight to use macro for initialization and the
backlight_get_brightness() operation to simply the update operation.
Signed-off-by: Sam Ravnborg
Cc: Konrad Dybcio
Cc: Thierry Reding
Cc: Sam Ravnborg
---
.../gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c | 15 +++
1 file
- Use macros for initialization
- Replace direct access to backlight_properties with get and set
operations
Signed-off-by: Sam Ravnborg
Cc: Alex Deucher
Cc: Christian König
Cc: amd-...@lists.freedesktop.org
Cc: Sam Ravnborg
---
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 15
- Use get method to read brightness
- Use drm_panel support for backlight
- This drops enable/disable operations as they are no longer needed.
The enable/disable operations had some backlight related comments
that are no longer valid. The only correct way to enable/disable
backlight
- Use backlight support from drm_panel.
This shifts this driver away from manually handling of power state.
- Add helper function for registering backlight, like other samsung
panel drivers do.
- Use devm_ for backlight register thus benefit from automatic
unregistering. Drop all explicit
- Use backlight support from drm_panel.
This shifts this driver away from manually handling of power state.
- Add helper function for registering backlight, like other samsung
panel drivers do.
- Use devm_ for backlight register thus benefit from automatic
unregistering. Drop all explicit
Add get and set operations to incapsualte access to backlight properties.
One easy win is that the get/set operatiosn can be used when backlight
is not included in the configuration, resulting in simpler code with
less ifdef's and thus more readable code.
The set/get methods hides some of the
Introduce use of DECLARE_BACKLIGHT_INIT_RAW when registering the
backlight. This makes the device registration a little simpler.
Use get/set operations for power thus avoid the use of the
rather confusion power states.
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo
The backlight drivers uses several different patterns when registering
a backlight:
- Register backlight and assign properties later
- Define a local backlight_properties variable and use memset
- Define a const backlight_properties and assign relevant properties
On top of this there was
Hi Joe.
On Sun, Aug 02, 2020 at 01:00:11AM -0700, Joe Perches wrote:
> These functions are now empty and no longer
> useful so remove the functions and their uses.
>
> Signed-off-by: Joe Perches
> ---
>
> It's too tedious to break apart into multiple patches.
> Done with coccinelle and typing.
These functions are now empty and no longer
useful so remove the functions and their uses.
Signed-off-by: Joe Perches
---
It's too tedious to break apart into multiple patches.
Done with coccinelle and typing.
Compiled allyesconfig x86-64 only.
Hi Marek.
On Tue, Jul 28, 2020 at 10:12:42PM +0200, Marek Vasut wrote:
> Add support for the Chefree CH101OLHLWH-002 10.1" (1280x800)
> color TFT LCD panel, connected over LVDS.
>
> Timings are taken from the datasheet version P0.5.
>
> Signed-off-by: Marek Vasut
> To:
Hi Bernard.
On Sat, Aug 01, 2020 at 08:02:13PM +0800, Bernard Zhao wrote:
> The function "int drm_panel_add(struct drm_panel *panel)"
> always returns 0, this return value is meaningless.
> Also, there is no need to check return value which calls
> "drm_panel_add and", error branch code will
On 31-07-20, 23:42, Laurent Pinchart wrote:
> Hi Vinod,
>
> On Fri, Jul 31, 2020 at 10:17:44PM +0530, Vinod Koul wrote:
> > On 31-07-20, 18:24, Laurent Pinchart wrote:
> > > Hello,
> > >
> > > This small series fixes a Kconfig dependency issue with the recently
> > > merged Xilixn DPSUB DRM/KMS
82 matches
Mail list logo
