Re: [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

On Mon, Nov 15, 2021 at 03:08:49PM +0100, Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 03:03:53PM +0100, Sascha Hauer wrote: > > Hi, > > > > On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: > > > Simplifying the code a bit. > > > > > > v2: use dma_resv_for_each_fence > > > > >

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

On 11/16/21 08:19, Christian König wrote: Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: On Wed, 2021-11-10 at 09:50 -0500, Zack Rusin wrote: TTM takes full control over TTM_PL_SYSTEM placed buffers. This makes driver internal usage of

Re: Panic with linus/master and panfrost

On Tue, Nov 16, 2021 at 8:39 AM Christian König wrote: > > Am 16.11.21 um 08:37 schrieb Daniel Vetter: > > On Mon, Nov 15, 2021 at 9:23 PM Christian König > > wrote: > >> > >> > >> Am 15.11.21 um 16:05 schrieb Daniel Vetter: > >>> You need > >>> > >>> commit

Re: Panic with linus/master and panfrost

Am 16.11.21 um 08:37 schrieb Daniel Vetter: On Mon, Nov 15, 2021 at 9:23 PM Christian König wrote: Am 15.11.21 um 16:05 schrieb Daniel Vetter: You need commit 13e9e30cafea10dff6bc8d63a38a61249e83fd65 Author: Christian König Date: Mon Oct 18 21:27:55 2021 +0200 drm/scheduler: fix

Re: Panic with linus/master and panfrost

On Mon, Nov 15, 2021 at 9:23 PM Christian König wrote: > > > > Am 15.11.21 um 16:05 schrieb Daniel Vetter: > > You need > > > > commit 13e9e30cafea10dff6bc8d63a38a61249e83fd65 > > Author: Christian König > > Date: Mon Oct 18 21:27:55 2021 +0200 > > > > drm/scheduler: fix

Re: [PATCH] drm/radeon:WARNING opportunity for max()

Am 16.11.21 um 06:50 schrieb zhaoxiao: Fix following coccicheck warning: drivers/gpu/drm/radeon/r100.c:3450:26-27: WARNING opportunity for max() drivers/gpu/drm/radeon/r100.c:2812:23-24: WARNING opportunity for max() Signed-off-by: zhaoxiao In general feel free to add my Acked-by, but I'm

Re: [PATCH v3 5/6] drm/i915/ttm: Implement asynchronous TTM moves

On 11/15/21 18:16, Matthew Auld wrote: Thanks for reviewing, Matthew, I'll take a look at the comments. /Thomas On 14/11/2021 11:12, Thomas Hellström wrote: Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: On Wed, 2021-11-10 at 09:50 -0500, Zack Rusin wrote: TTM takes full control over TTM_PL_SYSTEM placed buffers. This makes driver internal usage of TTM_PL_SYSTEM prone to errors because it requires

RE: [PATCH 3/4] drm/aspeed: Update INTR_STS handling

Hi Joel, Thanks for your comment. I will modify the patch and send it again. > -Original Message- > From: Joel Stanley > Sent: Tuesday, November 16, 2021 2:19 PM > To: Tommy Huang > Cc: David Airlie ; Daniel Vetter ; Rob > Herring ; Andrew Jeffery ; > linux-aspeed ;

[PATCH] In function nvkm_ioctl_map(), the variable "type" could be uninitialized if "nvkm_object_map()" returns error code, however, it does not check the return value and directly use the "type" in t

Fixes:01326050391ce("drm/nouveau/core/object: allow arguments to be passed to map function") Signed-off-by: Yizhuo Zhai --- drivers/gpu/drm/nouveau/nvkm/core/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c

Re: Questions about KMS flip

Am 16.11.21 um 04:27 schrieb Lang Yu: On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: [SNIP] Though a single call to dce_v*_0_crtc_do_set_base() will only pin the BO, I found it will be unpinned in next call to dce_v*_0_crtc_do_set_base(). Yeah, that's the normal case when the

[PATCH v1 3/3] phy: qcom: Program SSC only if supported by sink

Some legacy eDP sinks may not support SSC. The support for SSC is indicated through an opts flag from the controller driver. This change will enable SSC only if the sink supports it. Signed-off-by: Sankeerth Billakanti --- drivers/phy/qualcomm/phy-qcom-edp.c | 8 +--- 1 file changed, 5

[PATCH v1 1/3] dt-bindings: phy: Add eDP PHY compatible for sc7280

Add compatible string for the supported eDP PHY on sc7280 platform. Signed-off-by: Sankeerth Billakanti --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml

[PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

This series adds support for the eDP PHY on Qualcomm SC7280 platform. The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135 Sankeerth Billakanti (3): dt-bindings: phy: Add eDP PHY compatible for

[PATCH v1 2/3] phy: qcom: Add support for eDP PHY on sc7280

The sc7280 platform supports native eDP controller and PHY. This change will add support for the eDP PHY on sc7280. Signed-off-by: Sankeerth Billakanti --- drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c

[PATCH] In function nvkm_ioctl_map(), the variable "type" could be uninitialized if "nvkm_object_map()" returns error code, however, it does not check the return value and directly use the "type" in t

Fixes:01326050391ce("drm/nouveau/core/object: allow arguments to be passed to map function") Signed-off-by: Yizhuo Zhai --- drivers/gpu/drm/nouveau/nvkm/core/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/ioctl.c

Re: Panic with linus/master and panfrost

Am 16.11.21 um 00:04 schrieb Rob Clark: On Mon, Nov 15, 2021 at 2:43 PM Rob Clark wrote: On Mon, Nov 15, 2021 at 8:16 AM Ondřej Jirman wrote: On Mon, Nov 15, 2021 at 05:04:36PM +0100, megi xff wrote: On Mon, Nov 15, 2021 at 04:05:02PM +0100, Daniel Vetter wrote: You need commit

[PATCH v3 13/13] drm/msm/dsi: Pass DSC params to drm_panel

When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files

[PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul ---

[PATCH v3 11/13] drm/msm/dsi: add mode valid callback for dsi_mgr

Add a mode valid callback for dsi_mgr for checking mode being valid in case of DSC. For DSC the height and width needs to be multiple of slice, so we check that here Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi.h | 2 ++ drivers/gpu/drm/msm/dsi/dsi_host.c| 26

[PATCH v3 10/13] drm/msm/disp/dpu1: Add DSC support in RM

This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 66 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 files changed, 68 insertions(+) diff --git

[PATCH v3 09/13] drm/msm/disp/dpu1: Add support for DSC in topology

For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions up to 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compared to single LM, DSC at full width.

[PATCH v3 08/13] drm/msm: Add missing structure documentation

Somehow documentation for dspp was missed, so add that Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/msm_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index de7cb65bfc52..c4a588ad226e 100644 ---

[PATCH v3 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder

We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 140

[PATCH v3 06/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl

Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH v3 05/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d

We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul ---

[PATCH v3 04/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

This adds SDM845 DSC blocks into hw_catalog Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[PATCH v3 03/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block

In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++

[PATCH v3 02/13] drm/msm/disp/dpu1: Add support for DSC

Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

[PATCH v3 01/13] drm/msm/dsi: add support for dsc data

Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 132

[PATCH v3 00/13] drm/msm: Add Display Stream Compression Support

Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include DSC data and hardware block enabling for DPU1 then

Re: [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

Hi Karol: Thanks for the feedback, the patch might be too old to apply to the latest code tree. Let me check and get back to you soon. On Sat, Nov 13, 2021 at 12:22 PM Karol Herbst wrote: > > something seems to have messed with the patch so it doesn't apply correctly. > > On Thu, Jun 17, 2021 at

Re: [PATCH 2/2] drm/msm: Restore error return on invalid fence

On 11/15/2021 10:26 PM, Rob Clark wrote: On Mon, Nov 15, 2021 at 6:43 AM Akhil P Oommen wrote: On 11/12/2021 12:54 AM, Rob Clark wrote: From: Rob Clark When converting to use an idr to map userspace fence seqno values back to a dma_fence, we lost the error return when userspace passes

[PATCH] drm/radeon:WARNING opportunity for max()

Fix following coccicheck warning: drivers/gpu/drm/radeon/r100.c:3450:26-27: WARNING opportunity for max() drivers/gpu/drm/radeon/r100.c:2812:23-24: WARNING opportunity for max() Signed-off-by: zhaoxiao --- drivers/gpu/drm/radeon/r100.c | 10 ++ 1 file changed, 2 insertions(+), 8

Re: [PATCH 08/11] dmaengine: xilinx_dpdma: stop using slave_id field

On 15-11-21, 11:21, Arnd Bergmann wrote: > On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart > wrote: > > On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote: > > > @@ -1285,11 +1287,13 @@ static int xilinx_dpdma_config(struct dma_chan > > > *dchan, > > > spin_lock_irqsave(>lock,

[PATCH v2] backlight: ili922x: fix kernel-doc warnings & notation

ods at end of sentences so that the generated documentation flows correctly. (thanks, Daniel) drivers/video/backlight/ili922x.c | 29 ++-- 1 file changed, 19 insertions(+), 10 deletions(-) --- linux-next-2025.orig/drivers/video/backlight/ili922x.c +++ linux-nex

Re: [PATCH] backlight: ili922x: fix kernel-doc warnings & notation

On 11/15/21 3:38 AM, Daniel Thompson wrote: Thanks for the fixes. Just a could of quibbles about full stops/periods. --- drivers/video/backlight/ili922x.c | 29 ++-- 1 file changed, 19 insertions(+), 10 deletions(-) ---

[PATCH] drm/sun4i: remove no need type conversion to bool

This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index

[PATCH] drm/tegra: remove no need NULL check before kfree

This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/submit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index 776f825df52f..c2fc9677742e 100644 ---

[PATCH] drm/amd/display: remove no need NULL check before kfree

This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- .../drm/amd/display/dc/dcn10/dcn10_resource.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c

[PATCH] drm/amd/display: cleanup the code a bit

In function dc_sink_destruct, kfree will check pointer, no need to check again. This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git

Re: [PATCH linux-next] drm/msm/dp: remove unneeded variable

Quoting cgel@gmail.com (2021-11-10 04:05:12) > From: Changcheng Deng > > Fix the following coccicheck review: > ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > ---

Re: [PATCH] drm/msm: Fix mmap to include VM_IO and VM_DONTDUMP

Quoting Douglas Anderson (2021-11-10 11:33:42) > In commit 510410bfc034 ("drm/msm: Implement mmap as GEM object > function") we switched to a new/cleaner method of doing things. That's > good, but we missed a little bit. > > Before that commit, we used to _first_ run through the >

Re: Build regressions/improvements in v5.16-rc1

On Mon, Nov 15, 2021 at 05:44:33PM +0100, Marco Elver wrote: > On Mon, Nov 15, 2021 at 05:12PM +0100, Geert Uytterhoeven wrote: > [...] > > > + /kisskb/src/include/linux/fortify-string.h: error: call to > > > '__read_overflow' declared with attribute error: detected read beyond > > > size of

Re: Build regressions/improvements in v5.16-rc1

On Mon, Nov 15, 2021 at 05:44:33PM +0100, Marco Elver wrote: > On Mon, Nov 15, 2021 at 05:12PM +0100, Geert Uytterhoeven wrote: > [...] > > > + /kisskb/src/include/linux/fortify-string.h: error: call to > > > '__read_overflow' declared with attribute error: detected read beyond > > > size of

Re: [PATCH] drm/bridge: parade-ps8640: Fix additional suspend/resume at bootup

Quoting yangcong (2021-11-12 00:43:02) > Through log and waveform, we can see that there will be additional > suspend/resume when booting. This timing does not meet the ps8640 spec. > It seems that the delay of 500ms does not satisfied drm_panel_get_modes. > I increased it to 900ms and it seems

Re: [PATCH v10, 2/5] drm/mediatek: add component POSTMASK

Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道： > > This patch add component POSTMASK. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH v10, 5/5] drm/mediatek: add support for mediatek SOC MT8192

Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道： > > add support for mediatek SOC MT8192 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH v10, 3/5] drm/mediatek: add component RDMA4

Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道： > > This patch add component RDMA4 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v10, 1/5] drm/mediatek: add component OVL_2L2

Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道： > > This patch add component OVL_2L2 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH] fbdev: sh7760fb: document fallthrough cases

On Mon, Nov 15, 2021 at 09:35:09AM +0100, Geert Uytterhoeven wrote: > On Mon, Nov 15, 2021 at 7:33 AM Randy Dunlap wrote: > > Fix fallthrough warnings in sh776fb.c: > > > > ../drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info': > > ../drivers/video/fbdev/sh7760fb.c:138:23:

[Bug 214921] amdgpu hangs HP Laptop on shutdown

https://bugzilla.kernel.org/show_bug.cgi?id=214921 --- Comment #6 from spassw...@web.de --- Tested the patch with linux-5.15.2, linux-next-2025 and linux-5.16-rc1. It solves the hang on suspend (or shutdown) problem in all cases but resuming from suspend is still broken on linux-5.15.2 when

[Bug 214963] [amdgpu] resuming from suspend fails when IOMMU is missing

https://bugzilla.kernel.org/show_bug.cgi?id=214963 spassw...@web.de changed: What|Removed |Added Kernel Version|5.15.0, 5.15.1 |5.15.0, 5.15.1, 5.15.2 -- You may

Re: Panic with linus/master and panfrost

On Mon, Nov 15, 2021 at 2:43 PM Rob Clark wrote: > > On Mon, Nov 15, 2021 at 8:16 AM Ondřej Jirman wrote: > > > > On Mon, Nov 15, 2021 at 05:04:36PM +0100, megi xff wrote: > > > On Mon, Nov 15, 2021 at 04:05:02PM +0100, Daniel Vetter wrote: > > > > You need > > > > > > > > commit

[Bug 215025] [amdgpu] Thinkpad A275 hangs on shutdown / screen does not turn on after reboot

https://bugzilla.kernel.org/show_bug.cgi?id=215025 --- Comment #7 from Bjoern Franke (b...@nord-west.org) --- The patch fixes it, thanks. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 215025] [amdgpu] Thinkpad A275 hangs on shutdown / screen does not turn on after reboot

https://bugzilla.kernel.org/show_bug.cgi?id=215025 --- Comment #6 from Bjoern Franke (b...@nord-west.org) --- Created attachment 299595 --> https://bugzilla.kernel.org/attachment.cgi?id=299595=edit dmesg -- You may reply to this email to add a comment. You are receiving this mail because:

Re: Panic with linus/master and panfrost

On Mon, Nov 15, 2021 at 8:16 AM Ondřej Jirman wrote: > > On Mon, Nov 15, 2021 at 05:04:36PM +0100, megi xff wrote: > > On Mon, Nov 15, 2021 at 04:05:02PM +0100, Daniel Vetter wrote: > > > You need > > > > > > commit 13e9e30cafea10dff6bc8d63a38a61249e83fd65 > > > Author: Christian König > > >

Re: [PATCH v2 2/8] drm: improve drm_buddy_alloc function

Hi Matthew, I am preparing version3 of the buddy allocator, Please find the updated comments. SNIP >>> -int drm_buddy_alloc_range(struct drm_buddy_mm *mm, >>> - struct list_head *blocks, >>> - u64 start, u64 size) >>> +static struct drm_buddy_block * >>>

[PATCH v3 2/9] backlight: qcom-wled: Pass number of elements to read to read_u32_array

of_property_read_u32_array takes the number of elements to read as last argument. This does not always need to be 4 (sizeof(u32)) but should instead be the size of the array in DT as read just above with of_property_count_elems_of_size. To not make such an error go unnoticed again the driver now

[PATCH v3 8/9] backlight: qcom-wled: Remove unnecessary double whitespace

Remove redundant spaces inside for loop conditions. No other double spaces were found that are not part of indentation with `[^\s] `. Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson --- drivers/video/backlight/qcom-wled.c | 4 ++-- 1 file

[PATCH v3 9/9] backlight: qcom-wled: Respect enabled-strings in set_brightness

The hardware is capable of controlling any non-contiguous sequence of LEDs specified in the DT using qcom,enabled-strings as u32 array, and this also follows from the DT-bindings documentation. The numbers specified in this array represent indices of the LED strings that are to be enabled and

[PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom, enabled-strings

The length of qcom,enabled-strings as property array is enough to determine the number of strings to be enabled, without needing to set qcom,num-strings to override the default number of strings when less than the default (which is also the maximum) is provided in DT. This also introduces an

[PATCH v3 7/9] backlight: qcom-wled: Provide enabled_strings default for WLED 4 and 5

Only WLED 3 sets a sensible default that allows operating this driver with just qcom,num-strings in the DT; WLED 4 and 5 require qcom,enabled-strings to be provided otherwise enabled_strings remains zero-initialized, resulting in every string-specific register write (currently only the setup and

[PATCH v3 6/9] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3

The previous commit improves num_strings parsing to not go over the maximum of 3 strings for WLED3 anymore. Likewise this default index for a hypothetical 4th string is invalid and could access registers that are not mapped to the desired purpose. Removing this value gets rid of undesired

[PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion

The kernel already provides appropriate primitives to perform endianness conversion which should be used in favour of manual bit-wrangling. Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno --- drivers/video/backlight/qcom-wled.c | 23 +++ 1 file

[PATCH v3 4/9] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

When not specifying num-strings in the DT the default is used, but +1 is added to it which turns WLED3 into 4 and WLED4/5 into 5 strings instead of 3 and 4 respectively, causing out-of-bounds reads and register read/writes. This +1 exists for a deficiency in the DT parsing code, and is simply

[PATCH v3 1/9] backlight: qcom-wled: Validate enabled string indices in DT

The strings passed in DT may possibly cause out-of-bounds register accesses and should be validated before use. Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson ---

[PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

This patchset fixes WLED's handling of enabled-strings: besides some cleanup it is now actually possible to specify a non-contiguous array of enabled strings (not necessarily starting at zero) and the values from DT are now validated to prevent possible unexpected out-of-bounds register and array

Re: [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

Am 15.11.21 um 15:08 schrieb Daniel Vetter: On Mon, Nov 15, 2021 at 03:03:53PM +0100, Sascha Hauer wrote: Hi, On Fri, Sep 17, 2021 at 02:34:59PM +0200, Christian König wrote: Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König ---

Re: Panic with linus/master and panfrost

Am 15.11.21 um 16:05 schrieb Daniel Vetter: You need commit 13e9e30cafea10dff6bc8d63a38a61249e83fd65 Author: Christian König Date: Mon Oct 18 21:27:55 2021 +0200 drm/scheduler: fix drm_sched_job_add_implicit_dependencies which Christian pushed to drm-misc-next instead of

Re: [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

On 2021-11-09 13:38, Kuogee Hsieh wrote: From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divided the

[PATCH v4.5 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

From: Sean Paul This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

On Mon, 15 Nov 2021, Claudio Suarez wrote: > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: >> On Sun, 14 Nov 2021, Claudio Suarez wrote: >> > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: >> >> Hi Claudio, >> >> >> >> On Sat, Nov 13, 2021 at 08:27:30PM +0100,

Re: [PATCH] drm/virtio: add null check in virtio_gpu_poll

On Mon, Nov 15, 2021 at 9:58 AM Gurchetan Singh wrote: > From: Gurchetan Singh > > If vfpriv is null, we shouldn't check vfpriv->ring_idx_mask. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [RESEND PATCH v2 04/13] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

On 2021-11-15 11:23:27, Daniel Thompson wrote: > On Fri, Nov 12, 2021 at 10:43:37PM +0100, Marijn Suijten wrote: > > On 2021-11-12 13:35:03, Marijn Suijten wrote: > > > On 2021-11-12 12:08:39, Daniel Thompson wrote: > > > > On Fri, Nov 12, 2021 at 01:26:57AM +0100, Marijn Suijten wrote: > > > > >

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> Hi Claudio, > >> > >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > >> > The prefered way to log

[PATCH v1 1/2] ext4/xfs: add page refcount helper

From: Ralph Campbell There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ralph Campbell Signed-off-by: Alex Sierra Reviewed-by: Christoph

[PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration, etc.). Clean up the code so the reference

[PATCH v1 0/2] Remove extra ZONE_DEVICE page refcount

This patch includes Ralph Campbell’s ZONE_DEVICE refcount cleanup and additionally the changes necessary to avoid breaking the separately submitted MEMORY_DEVICE_COHERENT page migration code. Ralph’s original description: ZONE_DEVICE struct pages have an extra reference count that complicates the

[PATCH v1 6/9] lib: test_hmm add module param for zone device type

In order to configure device coherent in test_hmm, two module parameters should be passed, which correspond to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, private device type is configured. Signed-off-by: Alex Sierra --- lib/test_hmm.c

[PATCH v1 9/9] tools: update test_hmm script to support SP config

Add two more parameters to set spm_addr_dev0 & spm_addr_dev1 addresses. These two parameters configure the start SP addresses for each device in test_hmm driver. Consequently, this configures zone device type as coherent. Signed-off-by: Alex Sierra --- tools/testing/selftests/vm/test_hmm.sh |

[PATCH v1 2/9] mm: add device coherent vma selection for memory migration

This case is used to migrate pages from device memory, back to system memory. Device coherent type memory is cache coherent from device and CPU point of view. Signed-off-by: Alex Sierra --- v2: condition added when migrations from device coherent pages. --- include/linux/migrate.h | 1 +

[PATCH v1 7/9] lib: add support for device coherent type in test_hmm

Device Coherent type uses device memory that is coherently accesible by the CPU. This could be shown as SP (special purpose) memory range at the BIOS-e820 memory enumeration. If no SP memory is supported in system, this could be faked by setting CONFIG_EFI_FAKE_MEMMAP. Currently, test_hmm only

[PATCH v1 8/9] tools: update hmm-test to support device coherent type

Test cases such as migrate_fault and migrate_multiple, were modified to explicit migrate from device to sys memory without the need of page faults, when using device coherent type. Snapshot test case updated to read memory device type first and based on that, get the proper returned results

[PATCH v1 0/9] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory owned by a device that can be mapped into CPU page tables like MEMORY_DEVICE_GENERIC and can also be migrated like MEMORY_DEVICE_PRIVATE. Christoph, the suggestion to incorporate Ralph Campbell’s refcount cleanup patch into our

[PATCH v1 3/9] drm/amdkfd: add SPM support for SVM

When CPU is connected throug XGMI, it has coherent access to VRAM resource. In this case that resource is taken from a table in the device gmc aperture base. This resource is used along with the device type, which could be DEVICE_PRIVATE or DEVICE_COHERENT to create the device page map region.

[PATCH v1 5/9] lib: test_hmm add ioctl to get zone device type

new ioctl cmd added to query zone device type. This will be used once the test_hmm adds zone device coherent type. Signed-off-by: Alex Sierra --- lib/test_hmm.c | 15 ++- lib/test_hmm_uapi.h | 7 +++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git

[PATCH v1 4/9] drm/amdkfd: coherent type as sys mem on migration to ram

Coherent device type memory on VRAM to RAM migration, has similar access as System RAM from the CPU. This flag sets the source from the sender. Which in Coherent type case, should be set as MIGRATE_VMA_SELECT_DEVICE_COHERENT. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling ---

[PATCH v1 1/9] mm: add zone device coherent type memory support

Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. However, no one should be allowed to pin such memory so that it can always be evicted.

RE: [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

Hi Daniel, Greg, If it is the same or a similar crash reported here: https://lists.freedesktop.org/archives/dri-devel/2021-November/330018.html and here: https://lists.freedesktop.org/archives/dri-devel/2021-November/330212.html then the fix is already merged:

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

On Mon, Nov 15, 2021 at 09:10:54PM +0530, Tilak Tangudu wrote: > s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime > monitors the pci tree,if it sees complete tree as D3Hot,it transitions > the device to D3Cold.But i915 do not have D3Cold support in S2idle or in > runtime pm. so

Re: [PATCH v6 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup

Hi Nikolaus, Thomas, Le mer., nov. 10 2021 at 20:43:31 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie We need to hook up * HDMI connector * HDMI power regulator * JZ4780_CLK_HDMI @ 27 MHz * DDC pinmux * HDMI and LCDC endpoint connections Signed-off-by: Paul Boddie Signed-off-by:

Re: [PATCH v6 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers

Hi Nikolaus, Le mer., nov. 10 2021 at 20:43:30 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by:

[PATCH] drm/msm/adreno: Name the shadow buffer

From: Rob Clark This was the one GPU related kernel buffer which was not given a debug name. Let's fix that. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

Re: [PATCH v6 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780

Hi Nikolaus, I will look at the patches in depth in the coming days. Le mer., nov. 10 2021 at 20:43:26 +0100, H. Nikolaus Schaller a écrit : This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others.

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

On Mon, Nov 15, 2021 at 12:22:08PM +0200, Jani Nikula wrote: > On Sat, 13 Nov 2021, Claudio Suarez wrote: > > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > > drm core programs. > > > > Suggested-by: Ville Syrjälä > > Signed-off-by: Claudio Suarez > > --- > >

Re: [PATCH] drm/i915/dp: Perform 30ms delay after source OUI write

On Mon, 2021-11-15 at 12:53 +0200, Jani Nikula wrote: > On Fri, 12 Nov 2021, Lyude Paul wrote: > > While working on supporting the Intel HDR backlight interface, I noticed > > that there's a couple of laptops that will very rarely manage to boot up > > without detecting Intel HDR backlight

[PATCH v3] drm/msm/dp: employ bridge mechanism for display enable and disable

Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename

Re: [Intel-gfx] [PATCH] drm/i915: Don't read query SSEU for non-existent slice 0 on old platforms

On Fri, Nov 12, 2021 at 08:01:07AM -0800, Matt Roper wrote: > Pre-HSW platforms don't use the gt SSEU structures; this means that > calling intel_sseu_get_subslices() on slice 0 for these platforms will > trip a GEM_BUG_ON(slice >= sseu->max_slices) warning. > > Let's move the DSS lookup for a

[PATCH 5.15 261/917] drm/msm: prevent NULL dereference in msm_gpu_crashstate_capture()

From: Tim Gardner [ Upstream commit b220c154832c5cd0df34cbcbcc19d7135c16e823 ] Coverity complains of a possible NULL dereference: CID 120718 (#1 of 1): Dereference null return value (NULL_RETURNS) 23. dereference: Dereferencing a pointer that might be NULL state->bos when calling

  1   2   3   >