[PATCH v1, 1/1] soc: mediatek: cmdq: add cmdq_pkt_poll_addr function

2022-01-19 Thread Yongqiang Niu
From: mtk18742 add cmdq_pkt_poll_addr function in cmdq helper functions Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mtk-cmdq-helper.c | 39 include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + include/linux/soc/mediatek/mtk-cmdq.h| 2 ++ 3 files changed,

[PATCH v1, 0/1] soc: mediatek: cmdq: add cmdq_pkt_poll_addr function

2022-01-19 Thread Yongqiang Niu
add cmdq_pkt_poll_addr function mtk18742 (1): soc: mediatek: cmdq: add cmdq_pkt_poll_addr function drivers/soc/mediatek/mtk-cmdq-helper.c | 39 include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + include/linux/soc/mediatek/mtk-cmdq.h| 2 ++ 3 files changed, 42

[PATCH v5] dma-buf: system_heap: Add a size check for allocation

2022-01-19 Thread guangming.cao
From: Guangming Add a size check for allocation since the allocation size should be always less than the total DRAM size on system heap. Adding this check can prevent comsuming too much time for invalid allocations. Signed-off-by: Guangming --- drivers/dma-buf/heaps/system_heap.c | 8

Re: [PATCH v3 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-19 Thread Alistair Popple
On Wednesday, 12 January 2022 10:06:03 PM AEDT Alistair Popple wrote: > I have been looking at this in relation to the migration code and noticed we > have the following in try_to_migrate(): > > if (is_zone_device_page(page) && !is_device_private_page(page)) > return; > >

Re: [PATCH v3 10/10] tools: update test_hmm script to support SP config

2022-01-19 Thread Alistair Popple
Looks good, Reviewed-by: Alistair Popple On Tuesday, 11 January 2022 9:32:01 AM AEDT Alex Sierra wrote: > Add two more parameters to set spm_addr_dev0 & spm_addr_dev1 > addresses. These two parameters configure the start SP > addresses for each device in test_hmm driver. > Consequently, this

Re: [PATCH v3 09/10] tools: update hmm-test to support device coherent type

2022-01-19 Thread Alistair Popple
On Tuesday, 11 January 2022 9:32:00 AM AEDT Alex Sierra wrote: > Test cases such as migrate_fault and migrate_multiple, were modified to > explicit migrate from device to sys memory without the need of page > faults, when using device coherent type. > > Snapshot test case updated to read memory

Re: [RFC] amdgpu MST questions, and future plans

2022-01-19 Thread Lyude Paul
On Wed, 2022-01-19 at 17:56 -0500, Lyude Paul wrote: > Hi! I'm writing this email because I'm currently finishing up removing > pretty > much all of the non-atomic MST code in drm_dp_mst_topology_mgr.c as it's > really made it difficult to maintain MST over time. As well, once that's > complete

Re: [PATCH v3 08/10] lib: add support for device coherent type in test_hmm

2022-01-19 Thread Alistair Popple
On Tuesday, 11 January 2022 9:31:59 AM AEDT Alex Sierra wrote: > Device Coherent type uses device memory that is coherently accesible by > the CPU. This could be shown as SP (special purpose) memory range > at the BIOS-e820 memory enumeration. If no SP memory is supported in > system, this could

[Bug 213561] [bisected][regression] GFX10 AMDGPUs can no longer enter idle state after commit. Commit has been pushed to stable branches too.

2022-01-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213561 sosh...@gmail.com changed: What|Removed |Added CC||sosh...@gmail.com --- Comment #15

Re: [PATCH v3 07/10] lib: test_hmm add module param for zone device type

2022-01-19 Thread Alistair Popple
Thanks for splitting the coherent devices into separate device nodes. Couple of comments below. On Tuesday, 11 January 2022 9:31:58 AM AEDT Alex Sierra wrote: > In order to configure device coherent in test_hmm, two module parameters > should be passed, which correspond to the SP start address of

Re: [PATCH v3 06/10] lib: test_hmm add ioctl to get zone device type

2022-01-19 Thread Alistair Popple
On Tuesday, 11 January 2022 9:31:57 AM AEDT Alex Sierra wrote: [...] > +enum { > + /* 0 is reserved to catch uninitialized type fields */ This seems unnecessary and can be dropped to start at zero. Reviewed-by: Alistair Popple > + HMM_DMIRROR_MEMORY_DEVICE_PRIVATE = 1, > +}; > + >

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Vinod Koul
On 18-01-22, 19:50, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually describes

Re: [PATCH v5 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-19 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/drm-bridge-anx7625-send-DPCD-command-to-downstream/20220119-231952 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig

[PATCH] Revert "drm/ast: Support 1600x900 with 108MHz PCLK"

2022-01-19 Thread Dave Airlie
From: Dave Airlie This reverts commit 9bb7b689274b67ecb3641e399e76f84adc627df1. This caused a regression reported to Red Hat. Fixes: 9bb7b689274b ("drm/ast: Support 1600x900 with 108MHz PCLK") Signed-off-by: Dave Airlie --- drivers/gpu/drm/ast/ast_tables.h | 2 -- 1 file changed, 2

Re: [PATCH v3 01/10] mm: add zone device coherent type memory support

2022-01-19 Thread Alistair Popple
On Tuesday, 11 January 2022 9:31:52 AM AEDT Alex Sierra wrote: > Device memory that is cache coherent from device and CPU point of view. > This is used on platforms that have an advanced system bus (like CAPI > or CXL). Any page of a process can be migrated to such memory. However, > no one should

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 17:36 +0100, Javier Martinez Canillas wrote: > On 1/19/22 16:50, Thomas Zimmermann wrote: > > [snip] > > > > > > IMHO the best solution is to drop IORESOURCE_BUSY from sysfb > > > > > and have > > > > > drivers register/release the range with _BUSY. That would > > > > >

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 16:50 +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.22 um 16:12 schrieb Zack Rusin: > > On Wed, 2022-01-19 at 15:00 +0100, Thomas Zimmermann wrote: > > > Hi Zack > > > > > > Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: > > > > Hi > > > > > > > > Am 19.01.22 um 03:15

Re: [PATCH v4] dma-buf: system_heap: Add a size check for allocation

2022-01-19 Thread John Stultz
On Wed, Jan 19, 2022 at 7:34 PM wrote: > > From: Guangming > > Add a size check for allocation since the allocation size should be > always less than the total DRAM size on system heap. > And it can prevent consuming too much time for invalid allocations. > > Signed-off-by: Guangming > --- >

[PATCH v4] dma-buf: system_heap: Add a size check for allocation

2022-01-19 Thread guangming.cao
From: Guangming Add a size check for allocation since the allocation size should be always less than the total DRAM size on system heap. And it can prevent consuming too much time for invalid allocations. Signed-off-by: Guangming --- drivers/dma-buf/heaps/system_heap.c | 7 +++ 1 file

Re: [PATCH v5 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-19 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/drm-bridge-anx7625-send-DPCD-command-to-downstream/20220119-231952 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: arm-randconfig

Re: linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Wed, 17 Nov 2021 13:49:26 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/gpu_scheduler.h:316: warning: Function parameter or member 'work' > not described in 'drm_sched_job' > >

Re: linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Fri, 15 Oct 2021 21:01:04 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/drm_modeset_lock.h:74: warning: Function parameter or member > 'stack_depot' not described in

Re: linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Fri, 15 Oct 2021 20:54:22 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/gpu/drm-kms-helpers:451: > /home/sfr/next/next/drivers/gpu/drm/drm_privacy_screen.c:270: WARNING: Inline >

Re: [PATCH v2] phy: dphy: Correct clk_pre parameter

2022-01-19 Thread Liu Ying
Hi Heiko, Wyon, On Wed, 2022-01-19 at 10:37 +0800, Liu Ying wrote: > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE > parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, > kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy >

Re: [PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-19 Thread Jessica Zhang
On 1/19/2022 2:16 PM, Dmitry Baryshkov wrote: DPU driver contains code to parse clock items from device tree into special data struct and then enable/disable/set rate for the clocks using that data struct. However the DPU driver itself uses only parsing and enabling/disabling part (the rate

Re: [Freedreno] [PATCH v3 1/3] drm/msm: move utility functions from msm_drv.c

2022-01-19 Thread Jessica Zhang
On 1/19/2022 2:16 PM, Dmitry Baryshkov wrote: Move clock/IO/hrtimer utility functions from msm_drv.c to new msm_io_utils.c file. Signed-off-by: Dmitry Baryshkov Tested on: Qualcomm RB3 (debian, sdm845), Qualcomm RB5 (debian, qrb5165) Reviewed-by: Jessica Zhang ---

[pull] amdgpu, radeon drm-fixes-5.17

2022-01-19 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.17. This does not yet include the proper fix for the patch Linux reverted when he pulled in the original drm merge windows PR. I was waiting for rc1. At that point do you plan to merge rc1 into drm-fixes? If so, I can just drop the fix on top. The following

Re: [PATCH 3/3] drm: fix the warnning of string style for scheduler trace.

2022-01-19 Thread Huang Rui
Ping~ Seems this patch is missed. Thanks, Ray On Mon, Dec 13, 2021 at 02:34:22PM +0800, Huang, Ray wrote: > Use __string(), __assign_str() and __get_str() helpers in the TRACE_EVENT() > instead of string definitions in gpu scheduler trace. > > [ 158.890890] [ cut here

[PATCH] drm/rockchip: vop: Correct RK3399 VOP register fields

2022-01-19 Thread Brian Norris
Commit 7707f7227f09 ("drm/rockchip: Add support for afbc") switched up the rk3399_vop_big[] register windows, but it did so incorrectly. The biggest problem is in rk3288_win23_data[] vs. rk3368_win23_data[] .format field: RK3288's format: VOP_REG(RK3288_WIN2_CTRL0, 0x7, 1) RK3368's format:

Re: [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Ira Weiny
On Wed, Jan 19, 2022 at 06:24:22PM +0100, Daniel Vetter wrote: > On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > > From: Ira Weiny > > > > > > This series starts by converting the last easy kmap() uses to > > >

Re: [PATCH] drm/msm/hdmi: Fix missing put_device() call in msm_hdmi_get_phy

2022-01-19 Thread Dmitry Baryshkov
On 07/01/2022 11:50, Miaoqian Lin wrote: The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: e00012b256d4 ("drm/msm/hdmi: Make HDMI core get its PHY") Signed-off-by: Miaoqian Lin

Re: [PATCH] drm/msm/dsi: Fix missing put_device() call in dsi_get_phy

2022-01-19 Thread Dmitry Baryshkov
On 30/12/2021 10:09, Miaoqian Lin wrote: If of_find_device_by_node() succeeds, dsi_get_phy() doesn't a corresponding put_device(). Thus add put_device() to fix the exception handling. Fixes: ec31abf ("drm/msm/dsi: Separate PHY to another platform device") Signed-off-by: Miaoqian Lin

Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

2022-01-19 Thread Dmitry Baryshkov
On 28/12/2021 07:59, Bjorn Andersson wrote: The Qualcomm SM8350 platform comes with a single DisplayPort controller, add support for this in the DisplayPort driver. Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/dp-controller.yaml

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Stephen Boyd
Quoting Rob Herring (2022-01-18 17:50:38) > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually

Re: [PATCH] drm/msm/dpu: Bind pingpong block to intf on active ctls in cmd encoder

2022-01-19 Thread Dmitry Baryshkov
On 22/12/2021 13:55, Marijn Suijten wrote: As per the specification of DPU_CTL_ACTIVE_CFG the configuration of active blocks should be proactively specified, and the pingpong block is no different. The downstream display driver [1] confirms this by also calling bind_pingpong_blk on

[RFC] amdgpu MST questions, and future plans

2022-01-19 Thread Lyude Paul
Hi! I'm writing this email because I'm currently finishing up removing pretty much all of the non-atomic MST code in drm_dp_mst_topology_mgr.c as it's really made it difficult to maintain MST over time. As well, once that's complete it's likely I'm going to start on the (extremely overdue) task of

Re: [PATCH -next] drm/msm: remove variable set but not used

2022-01-19 Thread Dmitry Baryshkov
On 16/12/2021 06:11, Yang Li wrote: The code that uses variable mdss has been removed, So the declaration and assignment of the variable can be removed. Eliminate the following clang warning: drivers/gpu/drm/msm/msm_drv.c:513:19: warning: variable 'mdss' set but not used

[PATCH v2 3/4] drm/msm: split the main platform driver

2022-01-19 Thread Dmitry Baryshkov
Currently the msm platform driver is a multiplex handling several cases: - headless GPU-only driver, - MDP4 with flat device nodes, - MDP5/DPU MDSS with all the nodes being children of MDSS node. This results in not-so-perfect code, checking the hardware version (MDP4/MDP5/DPU) in several places,

[PATCH v2 4/4] drm/msm: stop using device's match data pointer

2022-01-19 Thread Dmitry Baryshkov
Let's make the match's data pointer a (sub-)driver's private data. The only user currently is the msm_drm_init() function, using this data to select kms_init callback. Pass this callback through the driver's private data instead. Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 1/4] drm/msm: unify MDSS drivers

2022-01-19 Thread Dmitry Baryshkov
MDP5 and DPU1 both provide the driver handling the MDSS region, which handles the irq domain and (incase of DPU1) adds some init for the UBWC controller. Unify those two pieces of code into a common driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 3

[PATCH v2 2/4] drm/msm: remove extra indirection for msm_mdss

2022-01-19 Thread Dmitry Baryshkov
Since now there is just one mdss subdriver, drop all the indirection, make msm_mdss struct completely opaque (and defined inside msm_mdss.c) and call mdss functions directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 44 drivers/gpu/drm/msm/msm_kms.h |

[PATCH v2 0/4] drm/msm: rework MDSS drivers

2022-01-19 Thread Dmitry Baryshkov
These patches coninue work started by AngeloGioacchino Del Regno in the previous cycle by further decoupling and dissecting MDSS and MDP drivers probe/binding paths. This removes code duplication between MDP5 and DPU1 MDSS drivers, by merging them and moving to the top level. This patchset

RE: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > except '"no\0\0yes" + v * 4' works a bit better. > > Is it a C code obfuscation contest? That would be: return &(v * 3)["no\0yes"]; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

[PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-19 Thread Dmitry Baryshkov
DPU driver contains code to parse clock items from device tree into special data struct and then enable/disable/set rate for the clocks using that data struct. However the DPU driver itself uses only parsing and enabling/disabling part (the rate setting is used by DP driver). Move this

[PATCH v3 1/3] drm/msm: move utility functions from msm_drv.c

2022-01-19 Thread Dmitry Baryshkov
Move clock/IO/hrtimer utility functions from msm_drv.c to new msm_io_utils.c file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/msm_drv.c | 118 --- drivers/gpu/drm/msm/msm_io_utils.c | 126

[PATCH v3 3/3] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-01-19 Thread Dmitry Baryshkov
In order to simplify DP code, drop hand-coded loops over clock arrays, replacing them with clk_bulk_* functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/dp/dp_clk_util.c | 120 ---

[PATCH v3 0/3] drm/msm: rework clock handling

2022-01-19 Thread Dmitry Baryshkov
msm_dss_clk_*() functions significantly duplicate clk_bulk_* family of functions. Drop custom code and use bulk clocks directly. This also removes dependency of DP driver on the DPU driver internals. Prerequisites: [1] Changes since v2: - Retain conditional code/prints in DP code to ease

[PATCH 3/3] drm/i915/guc: Flush G2H handler during a GT reset

2022-01-19 Thread Matthew Brost
Now that the error capture is fully decoupled from fence signalling (request retirement to free memory, which in turn depends on resets) we can safely flush the G2H handler during a GT reset. This is eliminates corner cases where GuC generated G2H (e.g. engine resets) race with a GT reset. v2:

[PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the GT when an engine reset failure is received to break this circular dependency. v2: (John Harrison) - Store engine reset mask - Fix typo in

[PATCH 0/3] Flush G2H handler during a GT reset

2022-01-19 Thread Matthew Brost
After a small fix to error capture code, we now can flush G2H during a GT reset which simplifies code and seals some extreme corner case races. v2: (CI) - Don't trigger GT reset from G2H handler v3: - Address John Harrison's comments Signed-off-by: Matthew Brost Matthew Brost (3):

[PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread Matthew Brost
Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL to fully decouple the error capture from fence signalling. v2: (John Harrison) - Fix typo in commit message (s/do/to) Fixes: 8b91cdd4f8649 ("drm/i915: Use __GFP_KSWAPD_RECLAIM in the capture code") Signed-off-by:

[PATCH] drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct

2022-01-19 Thread Matthew Brost
Realized that the GuC multi-lrc fini breadcrumb emit code is very delicate as the math this code does relies on functions it calls to emit a certain number of DWs. Add a few GEM_BUG_ONs to assert the math is correct. v2: - Rebase + resend for CI (Checkpatch) - Fix blank line warning

Re: [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
On Wed, Jan 19, 2022 at 01:07:22PM -0800, John Harrison wrote: > On 1/19/2022 12:54, Matthew Brost wrote: > > On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > > > On 1/18/2022 13:43, Matthew Brost wrote: > > > > The G2H handler needs to be flushed during a GT reset but a G2H > > >

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 12:53:43PM -0800, Lucas De Marchi wrote: > On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: > > On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: ... > > Yeah we can sed this anytime later we want to, but we need to get the foot > > in the door.

Re: [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread John Harrison
On 1/19/2022 12:54, Matthew Brost wrote: On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: On 1/18/2022 13:43, Matthew Brost wrote: The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 04:00:17PM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > >

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 21:25:08 +0200 Andy Shevchenko wrote: > > I say keep it one line! > > > > Reviewed-by: Steven Rostedt (Google) > > I believe Sakari strongly follows the 80 rule, which means... Checkpatch says "100" I think we need to simply update the docs (the documentation always

Re: [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > The G2H handler needs to be flushed during a GT reset but a G2H > > indicating engine reset failure can trigger a GT reset. Add a worker to > > trigger the GT when a engine reset failure

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 21:22:57 +0200 Andy Shevchenko wrote: > On Wed, Jan 19, 2022 at 04:38:26PM +, David Laight wrote: > > > > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; > > > > > > } > > > > > > return "yes\0no" + v * 4; > > > > > > :-) > > > > except

Re: [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread John Harrison
On 1/19/2022 12:47, Matthew Brost wrote: On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: On 1/18/2022 13:43, Matthew Brost wrote: Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL do fully decouple the error capture from fence signalling. s/do/to/

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >>

Re: [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread Matthew Brost
On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than > > GFP_KERNEL do fully decouple the error capture from fence signalling. > s/do/to/ > Yep. > > > > Fixes:

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, >case 3: >

Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation

2022-01-19 Thread John Stultz
On Wed, Jan 19, 2022 at 1:58 AM Guangming.Cao wrote: > On Fri, 2022-01-14 at 17:17 -0800, John Stultz wrote: > > If the max value is per-heap, why not enforce that value in the > > per-heap allocation function? > > > > Moving the check to the heap alloc to me seems simpler to me than > > adding

[PATCH v3 0/2] Add support for querying hw info that UMDs need

2022-01-19 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. v2: Rebased to newer baseline and added a kerneldoc comment. v3: Rebased to newer baseline and

[PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-01-19 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all

[PATCH v3 1/2] drm/i915/guc: Add fetch of hwconfig table

2022-01-19 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dpu: simplify clocks handling

2022-01-19 Thread Dmitry Baryshkov
On 19/01/2022 05:32, Jessica Zhang wrote: On 11/25/2021 6:35 PM, Dmitry Baryshkov wrote: DPU driver contains code to parse clock items from device tree into special data struct and then enable/disable/set rate for the clocks using that data struct. However the DPU driver itself uses only

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2022-01-19 Thread Paul Boddie
On Wednesday, 19 January 2022 07:40:22 CET H. Nikolaus Schaller wrote: > Hi Paul, > > > Am 18.01.2022 um 23:59 schrieb Paul Boddie : > > > > On Tuesday, 18 January 2022 17:58:58 CET Paul Cercueil wrote: > >> > >> Why is this JZ_LCD_OSDC_ALPHAEN bit needed now? I remember it working > >> fine

Re: [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-19 Thread Robert Beckett
On 19/01/2022 18:36, Jordan Justen wrote: Robert Beckett writes: From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for

Re: [PATCH 3/3] drm: Convert open yes/no strings to yesno()

2022-01-19 Thread Andy Shevchenko
On Tue, Jan 18, 2022 at 11:24:50PM -0800, Lucas De Marchi wrote: > linux/string_helpers.h provides a helper to return "yes"/"no" > strings. Replace the open coded versions with yesno(). The places were > identified with the following semantic patch: > > @@ > expression b; > @@ >

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 04:38:26PM +, David Laight wrote: > > > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > return "yes\0no" + v * 4; > > > > :-) > > except '"no\0\0yes" + v * 4' works a bit better. Is it a C code obfuscation contest? -- With

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 11:35:22AM +0900, Esaki Tomohito wrote: > On 2022/01/18 18:53, Andy Shevchenko wrote: > > On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote: > > > On 2022/01/14 23:16, Andy Shevchenko wrote: > > > > On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 11:18:59 +0200 > Sakari Ailus wrote: > > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > > tomoyo_io_buffer *head, > >

Re: [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-19 Thread Jordan Justen
Robert Beckett writes: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v2: Fixed suggestions on

Re: [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter

2022-01-19 Thread Javier Martinez Canillas
On 12/22/21 09:28, Javier Martinez Canillas wrote: > The nomodeset kernel command line parameter is used to prevent the KMS/DRM > drivers to be registered/probed. But only a few drivers implement support > for this and most DRM drivers just ignore it. > > This patch series is a v3 to make DRM

RE: [PATCH v2] hv: account for packet descriptor in maximum packet size

2022-01-19 Thread Michael Kelley (LINUX)
From: Wei Liu Sent: Friday, January 14, 2022 11:13 AM > > On Mon, Jan 10, 2022 at 01:44:19AM +0100, Andrea Parri wrote: > > (Extending Cc: list,) > > > > On Sun, Jan 09, 2022 at 05:55:16PM +0800, Yanming Liu wrote: > > > Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V > >

[PATCH] drm/i915: Fix vma resource freeing

2022-01-19 Thread Thomas Hellström
In some cases we use leftover kfree() instead of i915_vma_resource_free(). Fix this. Fixes: Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Reported-by: Robert Beckett Cc: Matthew Auld Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 4

Re: [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > From: Ira Weiny > > > > This series starts by converting the last easy kmap() uses to > > kmap_local_page(). > > > > There is one more call to kmap() wrapped in

Re: [PATCH 4/4] dma-buf: warn about containers in dma_resv object

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 02:43:39PM +0100, Christian König wrote: > Drivers should not add containers as shared fences to the dma_resv > object, instead each fence should be added individually. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 5 + > 1 file changed, 5

Re: [PATCH 3/4] dma-buf: Warn about dma_fence_chain container rules

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 02:43:38PM +0100, Christian König wrote: > Chaining of dma_fence_chain objects is only allowed through the prev > fence and not through the contained fence. > > Warn about that when we create a dma_fence_chain. > > Signed-off-by: Christian König > --- >

Re: [PATCH 2/4] dma-buf: warn about dma_fence_array container rules

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 02:43:37PM +0100, Christian König wrote: > It's not allowed to nest another dma_fence container into a dma_fence_array > or otherwise we can run into recursion. > > Warn about that when we create a dma_fence_array. > > Signed-off-by: Christian König > --- >

Re: [PATCH 1/4] dma-buf: consolidate dma_fence subclass checking

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 02:43:36PM +0100, Christian König wrote: > Consolidate the wrapper functions to check for dma_fence > subclasses in the dma_fence header. > > This makes it easier to document and also check the different > requirements for fence containers in the subclasses. > >

Re: [PATCH v5 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-01-19 Thread Hsin-Yi Wang
On Wed, Jan 19, 2022 at 11:38 PM Robert Foss wrote: > > On Wed, 19 Jan 2022 at 16:17, Hsin-Yi Wang wrote: > > > > From: Xin Ji > > > > Send DPCD command to downstream before anx7625 power down, > > let downstream monitor enter into standby mode. > > > > Signed-off-by: Xin Ji > > Signed-off-by:

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Helge Deller
Hi Thomas, On 1/19/22 16:37, Thomas Zimmermann wrote: > Am 19.01.22 um 16:05 schrieb Sven Schnelle: >> Daniel Vetter writes: >> >>> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds >>> wrote: >>> Irrespective of this code being buggy or not buggy I think the bigger >>> pictures, and really the

Re: [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Ira Weiny
On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of

RE: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > return "yes\0no" + v * 4; > > :-) except '"no\0\0yes" + v * 4' works a bit better. - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

RE: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } return "yes\0no" + v * 4; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Javier Martinez Canillas
On 1/19/22 16:50, Thomas Zimmermann wrote: [snip] IMHO the best solution is to drop IORESOURCE_BUSY from sysfb and have drivers register/release the range with _BUSY. That would signal the memory belongs to the sysfb device but is not busy unless a driver has been bound.

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-19 Thread Sven Schnelle
Hi Daniel, Daniel Vetter writes: > On Wed, Jan 19, 2022 at 05:15:44PM +0100, Sven Schnelle wrote: >> Hi Daniel, >> >> Daniel Vetter writes: >> >> > On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: >> >> Helge Deller writes: >> >> > Maybe on fast new x86 boxes the performance

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 06:13:39PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Helge Deller wrote: > > On 1/19/22 16:42, Daniel Vetter wrote: > >> If otoh you get the maintainership first to be able to cram in reverts > >> without discussions, then it's very backwards. > > I'm working on the

Re: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

2022-01-19 Thread Mark Brown
On Tue, Jan 18, 2022 at 07:53:25PM -0600, Rob Herring wrote: > For a single pinctrl mode, it is not necessary to define pinctrl > properties as the tools always allow pinctrl properties. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC] How to add hardware rotation, scaling etc to a DRM/KMS driver

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 05:55:22PM +0900, Daniel Palmer wrote: > Hi all, > > I've copied and pasted my way to mostly working DRM/KMS driver for a > low cost ARM SoC (Sigmastar SSD202D). The hardware is 2D only. > > One of the devices that uses this SoC has the screen upside down so it > needs

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 05:15:44PM +0100, Sven Schnelle wrote: > Hi Daniel, > > Daniel Vetter writes: > > > On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: > >> Helge Deller writes: > >> > Maybe on fast new x86 boxes the performance difference isn't huge, > >> > but for all old

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-19 Thread Sven Schnelle
Hi Daniel, Daniel Vetter writes: > On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: >> Helge Deller writes: >> > Maybe on fast new x86 boxes the performance difference isn't huge, >> > but for all old systems, or when emulated in qemu, this makes >> > a big difference. >> > >> >

Re: [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Petr Mladek wrote: > > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: > >> Add some helpers under lib/string_helpers.h so they can be used > >> throughout the kernel. When I started doing this there were 2

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-19 Thread Jani Nikula
On Wed, 19 Jan 2022, Helge Deller wrote: > On 1/19/22 16:42, Daniel Vetter wrote: >> If otoh you get the maintainership first to be able to cram in reverts >> without discussions, then it's very backwards. > I'm working on the Linux kernel since at least 23 years and am a maintainer > of parts

Re: [RFC 00/10] drm: selftests: Convert to KUnit

2022-01-19 Thread Daniel Vetter
On Tue, Jan 18, 2022 at 12:22:49AM +0100, Michał Winiarski wrote: > KUnit unifies the test structure and provides helper tools that simplify > the development. Basic use case allows running tests as regular processes, > leveraging User Mode Linux. > For example, to execute all DRM unit tests: >

Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2022-01-19 Thread Rob Herring
On Tue, 21 Dec 2021 08:52:09 -0400, Rob Herring wrote: > With 'unevaluatedProperties' support enabled, several SPI based display > binding examples have warnings: > > Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml: > lcd@0: Unevaluated properties are not allowed

Re: [RFC 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory

2022-01-19 Thread Randy Dunlap
Hi-- On 1/14/22 17:06, Hridya Valsaraju wrote: > diff --git a/init/Kconfig b/init/Kconfig > index cd23faa163d1..408910b21387 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -990,6 +990,13 @@ config BLK_CGROUP > > See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more

  1   2   3   >